Skip to contentSkip to conversation

clk: imx: imx7d: add the Keypad Port module clock

PATCH New Stefan Agner 3 participants 4 messages Feb 27, 2018 – Mar 5, 2018

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 clk: imx: imx7d: add the Keypad Port module clock

According to the i.MX7D Reference Manual, the Keypad Port module (KPP) requires this clock gate to be enabled.

---
 drivers/clk/imx/clk-imx7d.c             | 1 +
 include/dt-bindings/clock/imx7d-clock.h | 3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)
drivers/clk/imx/clk-imx7d.c +1 -0
index f34f1ecc4690..6b6e8851eabb 100644
@@ -858,6 +858,7 @@ static void __init imx7d_clocks_init(struct device_node *ccm_node)
 	clks[IMX7D_WDOG2_ROOT_CLK] = imx_clk_gate4("wdog2_root_clk", "wdog_post_div", base + 0x49d0, 0);
 	clks[IMX7D_WDOG3_ROOT_CLK] = imx_clk_gate4("wdog3_root_clk", "wdog_post_div", base + 0x49e0, 0);
 	clks[IMX7D_WDOG4_ROOT_CLK] = imx_clk_gate4("wdog4_root_clk", "wdog_post_div", base + 0x49f0, 0);
+	clks[IMX7D_KPP_ROOT_CLK] = imx_clk_gate4("kpp_root_clk", "ipg_root_clk", base + 0x4aa0, 0);
 	clks[IMX7D_CSI_MCLK_ROOT_CLK] = imx_clk_gate4("csi_mclk_root_clk", "csi_mclk_post_div", base + 0x4490, 0);
 	clks[IMX7D_AUDIO_MCLK_ROOT_CLK] = imx_clk_gate4("audio_mclk_root_clk", "audio_mclk_post_div", base + 0x4790, 0);
 	clks[IMX7D_WRCLK_ROOT_CLK] = imx_clk_gate4("wrclk_root_clk", "wrclk_post_div", base + 0x47a0, 0);
include/dt-bindings/clock/imx7d-clock.h +2 -1
index dc51904435d8..7653c8536b64 100644
@@ -453,5 +453,6 @@
 #define IMX7D_NAND_RAWNAND_CLK		440
 #define IMX7D_NAND_USDHC_BUS_RAWNAND_CLK 441
 #define IMX7D_SNVS_CLK			442
-#define IMX7D_CLK_END			443
+#define IMX7D_KPP_ROOT_CLK		443
+#define IMX7D_CLK_END			444
 #endif /* __DT_BINDINGS_CLOCK_IMX7D_H */
Signature · 1 line
2.16.2
#1 lore raw

PATCH 2/2 ARM: dts: imx7s: add Keypad Port module

Add the Keypad Port module. Add it disabled by default since only some boards use it. Boards which do need to specify additional properties as documented in the device tree bindings.

---
 arch/arm/boot/dts/imx7s.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)
arch/arm/boot/dts/imx7s.dtsi +8 -0
index 097b066ed23c..46400ba2217a 100644
@@ -499,6 +499,14 @@
 				status = "disabled";
 			};
 
+			kpp: kpp at 30320000 {
+				compatible = "fsl,imx7d-kpp", "fsl,imx21-kpp";
+				reg = <0x30320000 0x10000>;
+				interrupts = <GIC_SPI 80 IRQ_TYPE_LEVEL_HIGH>;
+				clocks = <&clks IMX7D_KPP_ROOT_CLK>;
+				status = "disabled";
+			};
+
 			iomuxc: iomuxc at 30330000 {
 				compatible = "fsl,imx7d-iomuxc";
 				reg = <0x30330000 0x10000>;
Signature · 1 line
2.16.2
#2 lore raw

PATCH 1/2 clk: imx: imx7d: add the Keypad Port module clock

In reply to Stefan Agner
Quoted 4 lines · Stefan Agner

According to the i.MX7D Reference Manual, the Keypad Port module (KPP) requires this clock gate to be enabled.

Applied both. But for future i.MX clock patches, please also copy clk maintainers to give them chance to comment.

Michael Turquette <[email protected]>
Stephen Boyd <[email protected]>

I will eventually need to send i.MX clock patches to them.

Shawn

maintainer
#3 lore raw

PATCH 1/2 clk: imx: imx7d: add the Keypad Port module clock

In reply to Stefan Agner
Quoted 8 lines · Stefan Agner

According to the i.MX7D Reference Manual, the Keypad Port module (KPP) requires this clock gate to be enabled.

---
 drivers/clk/imx/clk-imx7d.c             | 1 +
 include/dt-bindings/clock/imx7d-clock.h | 3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)