Skip to contentSkip to conversation

staging:comedi:comedi_pci.h Prefer a maximum 75 chars per line

PATCH Superseded Bhanusree Pola 2 participants 2 messages Oct 7, 2018 Staging

v6 of 7 Superseded Latest is v7 →

lore
Share & tools
lore

Bhanusree Pola

author
#0 lore raw

PATCH v6 1/1 staging:comedi:comedi_pci.h Prefer a maximum 75 chars per line

Adjust all lines exceeding 75 chars per line to fix checkpatch warning.

Signed-off-by Bhanusree Pola <[email protected]>

---

changes in v6:
-Always commit on the base version.

changes in v5:
-Fixed Change log
-Change in subject line. Do not send as 'Re:'

changes in v4:
-Remove Whitespace in comment section of module_comedi_pci_driver()
to fix checkpatch Error.

changes in v3:
-Comment section of module_pci_driver() exceeds 75 characters.
Adjust the chars to 75 per line
-Modified log message.
-Added change log.

changes in v2:
-comedi_pci_auto_config() function prototype is exceeds
75 characters per line. Adjust to 75 chars to improve readability and also adjust the arguments to match open parantheses.
-Comment section of module_comedi_pci_driver() exceeds 75
characters. Modified contents to adjust 75 chars per line.

 drivers/staging/comedi/comedi_pci.h | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/staging/comedi/comedi_pci.h +4 -2
index 4e069440cbdc..9d07c9a68f53 100644
@@ -31,7 +31,8 @@ int comedi_pci_enable(struct comedi_device *dev);
 void comedi_pci_disable(struct comedi_device *dev);
 void comedi_pci_detach(struct comedi_device *dev);
 
-int comedi_pci_auto_config(struct pci_dev *pcidev, struct comedi_driver *driver,
+int comedi_pci_auto_config(struct pci_dev *pcidev,
+			   struct comedi_driver *driver,
 			   unsigned long context);
 void comedi_pci_auto_unconfig(struct pci_dev *pcidev);
 

@@ -41,7 +42,8 @@ void comedi_pci_driver_unregister(struct comedi_driver *comedi_driver,
 				  struct pci_driver *pci_driver);
 
 /**
- * module_comedi_pci_driver() - Helper macro for registering a comedi PCI driver
+ * module_comedi_pci_driver() - Helper macro for registering a comedi PCI
+ * driver
  * @__comedi_driver: comedi_driver struct
  * @__pci_driver: pci_driver struct
  *
Signature · 1 line
2.17.1
maintainer
#1 lore raw

drivers/staging/comedi/comedi_pci.h void comedi_pci_driver_unregister(struct comedi_driver *comedi_driver, · line 46

Quoted 7 lines · Bhanusree Pola
drivers/staging/comedi/comedi_pci.h +2 -1
@@ -41,7 +42,8 @@ void comedi_pci_driver_unregister(struct comedi_driver *comedi_driver,
 				  struct pci_driver *pci_driver);
 
 /**
- * module_comedi_pci_driver() - Helper macro for registering a comedi PCI driver
+ * module_comedi_pci_driver() - Helper macro for registering a comedi PCI
+ * driver

I do not think that kerneldoc can handle wrapped lines like this, so it is fine to just leave this as-is.

checkpatch is just a hint, not a hard rule, sometimes it gets things wrong.

thanks,

greg k-h