Skip to contentSkip to conversation

libata: Apply NOLPM quirk for SAMSUNG MZ7TD256HAFV-000L9

PATCH Superseded Diego Viola 2 participants 4 messages Oct 26, 2018 libata

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 libata: Apply NOLPM quirk for SAMSUNG MZ7TD256HAFV-000L9

med_power_with_dipm causes my T450 to freeze with a SAMSUNG MZ7TD256HAFV-000L9 SSD (firmware DXT02L5Q).

Switching the LPM to max_performance fixes this issue.

---
 drivers/ata/libata-core.c | 1 +
 1 file changed, 1 insertion(+)
drivers/ata/libata-core.c +1 -0
index a9dd4ea7467d..a7f5202a4815 100644
@@ -4553,6 +4553,7 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
 	/* These specific Samsung models/firmware-revs do not handle LPM well */
 	{ "SAMSUNG MZMPC128HBFU-000MV", "CXM14M1Q", ATA_HORKAGE_NOLPM, },
 	{ "SAMSUNG SSD PM830 mSATA *",  "CXM13D1Q", ATA_HORKAGE_NOLPM, },
+	{ "SAMSUNG MZ7TD256HAFV-000L9", NULL,       ATA_HORKAGE_NOLPM, },
 
 	/* devices that don't properly handle queued TRIM commands */
 	{ "Micron_M500IT_*",		"MU01",	ATA_HORKAGE_NO_NCQ_TRIM |
Signature · 1 line
2.19.1
#1 lore raw

Hi,

Quoted 6 lines · Diego Viola

med_power_with_dipm causes my T450 to freeze with a SAMSUNG MZ7TD256HAFV-000L9 SSD (firmware DXT02L5Q).

Switching the LPM to max_performance fixes this issue.

Thank you for the patch, have you updated the firmware and confirmed that this happens with the latest firmware version too ?

If not please send a new version limiting the blacklist to your firmware version.

Regards,

Hans

Quoted 17 lines
---
  drivers/ata/libata-core.c | 1 +
  1 file changed, 1 insertion(+)
drivers/ata/libata-core.c +1 -0
index a9dd4ea7467d..a7f5202a4815 100644
@@ -4553,6 +4553,7 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
  	/* These specific Samsung models/firmware-revs do not handle LPM well */
  	{ "SAMSUNG MZMPC128HBFU-000MV", "CXM14M1Q", ATA_HORKAGE_NOLPM, },
  	{ "SAMSUNG SSD PM830 mSATA *",  "CXM13D1Q", ATA_HORKAGE_NOLPM, },
+	{ "SAMSUNG MZ7TD256HAFV-000L9", NULL,       ATA_HORKAGE_NOLPM, },
 
  	/* devices that don't properly handle queued TRIM commands */
  	{ "Micron_M500IT_*",		"MU01",	ATA_HORKAGE_NO_NCQ_TRIM |
#2 lore raw

Hi Hans,

Quoted 7 lines · Hans de Goede

Hi,

Quoted 3 lines · Diego Viola

med_power_with_dipm causes my T450 to freeze with a SAMSUNG MZ7TD256HAFV-000L9 SSD (firmware DXT02L5Q).

Quoted 6 lines
Quoted 3 lines

Switching the LPM to max_performance fixes this issue.

Thank you for the patch, have you updated the firmware and confirmed that this happens with the latest firmware version too ?

No, I haven't tired the latest one yet.

The last time I saw, Samsung/Lenovo doesn't make it very easy for Linux users, and I don't have a Windows installation to perform the upgrade.

Quoted 3 lines

If not please send a new version limiting the blacklist to your firmware version.

OK. Sent.

Quoted 22 lines

Regards,

Hans

Quoted 14 lines
---
  drivers/ata/libata-core.c | 1 +
  1 file changed, 1 insertion(+)
drivers/ata/libata-core.c +1 -0
index a9dd4ea7467d..a7f5202a4815 100644
@@ -4553,6 +4553,7 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
      /* These specific Samsung models/firmware-revs do not handle LPM well */
      { "SAMSUNG MZMPC128HBFU-000MV", "CXM14M1Q", ATA_HORKAGE_NOLPM, },
      { "SAMSUNG SSD PM830 mSATA *",  "CXM13D1Q", ATA_HORKAGE_NOLPM, },
+     { "SAMSUNG MZ7TD256HAFV-000L9", NULL,       ATA_HORKAGE_NOLPM, },
 
Quoted 3 lines

drivers/ata/libata-core.c static const struct ata_blacklist_entry ata_device_blacklist [] = { · line 4559

Quoted 3 lines
drivers/ata/libata-core.c +0 -0
      /* devices that don't properly handle queued TRIM commands */
      { "Micron_M500IT_*",            "MU01", ATA_HORKAGE_NO_NCQ_TRIM |

Regards,
Diego

#3 lore raw
Quoted 11 lines · Diego Viola

Hi Hans,

Quoted 7 lines · Hans de Goede

Hi,

Quoted 3 lines · Diego Viola

med_power_with_dipm causes my T450 to freeze with a SAMSUNG MZ7TD256HAFV-000L9 SSD (firmware DXT02L5Q).

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines

Switching the LPM to max_performance fixes this issue.

Thank you for the patch, have you updated the firmware and confirmed that this happens with the latest firmware version too ?

No, I haven't tired the latest one yet.

s/tired/tried/

Quoted 39 lines

The last time I saw, Samsung/Lenovo doesn't make it very easy for Linux users, and I don't have a Windows installation to perform the upgrade.

Quoted 3 lines

If not please send a new version limiting the blacklist to your firmware version.

OK. Sent.

Quoted 22 lines

Regards,

Hans

Quoted 14 lines
---
  drivers/ata/libata-core.c | 1 +
  1 file changed, 1 insertion(+)
drivers/ata/libata-core.c +1 -0
index a9dd4ea7467d..a7f5202a4815 100644
@@ -4553,6 +4553,7 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
      /* These specific Samsung models/firmware-revs do not handle LPM well */
      { "SAMSUNG MZMPC128HBFU-000MV", "CXM14M1Q", ATA_HORKAGE_NOLPM, },
      { "SAMSUNG SSD PM830 mSATA *",  "CXM13D1Q", ATA_HORKAGE_NOLPM, },
+     { "SAMSUNG MZ7TD256HAFV-000L9", NULL,       ATA_HORKAGE_NOLPM, },
 
Quoted 3 lines

drivers/ata/libata-core.c static const struct ata_blacklist_entry ata_device_blacklist [] = { · line 4559

Quoted 3 lines
drivers/ata/libata-core.c +0 -0
      /* devices that don't properly handle queued TRIM commands */
      { "Micron_M500IT_*",            "MU01", ATA_HORKAGE_NO_NCQ_TRIM |

Regards,
Diego