Skip to contentSkip to conversation

libata: Apply NOLPM quirk for SAMSUNG MZ7TD256HAFV-000L9

PATCH Applied Diego Viola 3 participants 7 messages Oct 26, 2018 – Oct 28, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 libata: Apply NOLPM quirk for SAMSUNG MZ7TD256HAFV-000L9

med_power_with_dipm causes my T450 to freeze with a SAMSUNG MZ7TD256HAFV-000L9 SSD (firmware DXT02L5Q).

Switching the LPM to max_performance fixes this issue.

---
 drivers/ata/libata-core.c | 1 +
 1 file changed, 1 insertion(+)
drivers/ata/libata-core.c +1 -0
index a9dd4ea7467d..6e594644cb1d 100644
@@ -4553,6 +4553,7 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
 	/* These specific Samsung models/firmware-revs do not handle LPM well */
 	{ "SAMSUNG MZMPC128HBFU-000MV", "CXM14M1Q", ATA_HORKAGE_NOLPM, },
 	{ "SAMSUNG SSD PM830 mSATA *",  "CXM13D1Q", ATA_HORKAGE_NOLPM, },
+	{ "SAMSUNG MZ7TD256HAFV-000L9", "DXT02L5Q", ATA_HORKAGE_NOLPM, },
 
 	/* devices that don't properly handle queued TRIM commands */
 	{ "Micron_M500IT_*",		"MU01",	ATA_HORKAGE_NO_NCQ_TRIM |
Signature · 1 line
2.19.1
Acked-by on v3 1/1
#1 lore raw

Hi,

Quoted 6 lines · Diego Viola

med_power_with_dipm causes my T450 to freeze with a SAMSUNG MZ7TD256HAFV-000L9 SSD (firmware DXT02L5Q).

Switching the LPM to max_performance fixes this issue.

Thanks, looks good to me:

Regards,

Hans

Quoted 17 lines
---
  drivers/ata/libata-core.c | 1 +
  1 file changed, 1 insertion(+)
drivers/ata/libata-core.c +1 -0
index a9dd4ea7467d..6e594644cb1d 100644
@@ -4553,6 +4553,7 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
  	/* These specific Samsung models/firmware-revs do not handle LPM well */
  	{ "SAMSUNG MZMPC128HBFU-000MV", "CXM14M1Q", ATA_HORKAGE_NOLPM, },
  	{ "SAMSUNG SSD PM830 mSATA *",  "CXM13D1Q", ATA_HORKAGE_NOLPM, },
+	{ "SAMSUNG MZ7TD256HAFV-000L9", "DXT02L5Q", ATA_HORKAGE_NOLPM, },
 
  	/* devices that don't properly handle queued TRIM commands */
  	{ "Micron_M500IT_*",		"MU01",	ATA_HORKAGE_NO_NCQ_TRIM |
Applied
#2 lore raw
In reply to Diego Viola
Quoted 4 lines · Diego Viola

med_power_with_dipm causes my T450 to freeze with a SAMSUNG MZ7TD256HAFV-000L9 SSD (firmware DXT02L5Q).

Switching the LPM to max_performance fixes this issue.

Applied, thanks.

Signature · 1 line
Jens Axboe
#3 lore raw
Quoted 5 lines · Jens Axboe
Quoted 3 lines · Diego Viola

med_power_with_dipm causes my T450 to freeze with a SAMSUNG MZ7TD256HAFV-000L9 SSD (firmware DXT02L5Q).

Quoted 7 lines
Quoted 1 line

Switching the LPM to max_performance fixes this issue.

Applied, thanks.

--
Jens Axboe

Jens, Hans,

Thank you.

Diego

#4 lore raw
Quoted 15 lines · Diego Viola
Quoted 5 lines · Jens Axboe
Quoted 3 lines · Diego Viola

med_power_with_dipm causes my T450 to freeze with a SAMSUNG MZ7TD256HAFV-000L9 SSD (firmware DXT02L5Q).

Quoted 7 lines
Quoted 1 line

Switching the LPM to max_performance fixes this issue.

Applied, thanks.

--
Jens Axboe

Quoted 5 lines

Jens, Hans,

Thank you.

Diego

Hi Hans and Jens,

I just wanted to give you guys an update about this problem.

I've managed to update my SSD firmware to the latest version[1].

For running the update, I've had to install Windows 10, ran the firmware update, remove Windows and reinstall Arch Linux.

The latest version of the firmware is DXT04L5Q, and it looks like there hasn't been a new update since 2015.

I'll be running with med_power_with_dipm and hope this firmware update fixes the problem, if it doesn't and I get another freeze, I'll send another patch blacklisting the drive completely. Is that OK?

1. https://support.lenovo.com/br/en/downloads/ds038904

Thanks and Best Regards,
Diego

#5 lore raw

Hi,

Quoted 31 lines · Diego Viola
Quoted 15 lines · Diego Viola
Quoted 5 lines · Jens Axboe
Quoted 3 lines · Diego Viola

med_power_with_dipm causes my T450 to freeze with a SAMSUNG MZ7TD256HAFV-000L9 SSD (firmware DXT02L5Q).

Quoted 7 lines
Quoted 1 line

Switching the LPM to max_performance fixes this issue.

Applied, thanks.

--
Jens Axboe

Quoted 5 lines

Jens, Hans,

Thank you.

Diego

Hi Hans and Jens,

I just wanted to give you guys an update about this problem.

I've managed to update my SSD firmware to the latest version[1].

For running the update, I've had to install Windows 10, ran the firmware update, remove Windows and reinstall Arch Linux.

Quoted 6 lines

The latest version of the firmware is DXT04L5Q, and it looks like there hasn't been a new update since 2015.

I'll be running with med_power_with_dipm and hope this firmware update fixes the problem, if it doesn't and I get another freeze, I'll send another patch blacklisting the drive completely. Is that OK?

Yes, if it still happens with the latest firmware then blacklisting it completely is the right thing to do.

Unfortunately for reasons which I do not understand OEM SSDs often use different (customized?) firmware compared to the model on which they are based and often see less updates and seem to have more bugs :|

Regards,

Hans

#6 lore raw

Hi Hans,

Quoted 45 lines · Hans de Goede

Hi,

Quoted 31 lines · Diego Viola
Quoted 15 lines · Diego Viola
Quoted 5 lines · Jens Axboe
Quoted 3 lines · Diego Viola

med_power_with_dipm causes my T450 to freeze with a SAMSUNG MZ7TD256HAFV-000L9 SSD (firmware DXT02L5Q).

Quoted 7 lines
Quoted 1 line

Switching the LPM to max_performance fixes this issue.

Applied, thanks.

--
Jens Axboe

Quoted 5 lines

Jens, Hans,

Thank you.

Diego

Hi Hans and Jens,

I just wanted to give you guys an update about this problem.

I've managed to update my SSD firmware to the latest version[1].

For running the update, I've had to install Windows 10, ran the firmware update, remove Windows and reinstall Arch Linux.

Quoted 6 lines

The latest version of the firmware is DXT04L5Q, and it looks like there hasn't been a new update since 2015.

I'll be running with med_power_with_dipm and hope this firmware update fixes the problem, if it doesn't and I get another freeze, I'll send another patch blacklisting the drive completely. Is that OK?

Yes, if it still happens with the latest firmware then blacklisting it completely is the right thing to do.

Quoted 7 lines

Unfortunately for reasons which I do not understand OEM SSDs often use different (customized?) firmware compared to the model on which they are based and often see less updates and seem to have more bugs :|

Regards,

Hans

I've just got another freeze with the latest firmware while I was watching some YouTube videos. I think it's safe to assume this drive is borked and won't get better, I'll send another patch.

Thanks,
Diego