firewire: Remove depends on HAS_DMA in case of platform dependency
PATCH RESEND v4 1/1 firewire: Remove depends on HAS_DMA in case of platform dependency
Remove dependencies on HAS_DMA where a Kconfig symbol depends on another symbol that implies HAS_DMA, and, optionally, on "|| COMPILE_TEST". In most cases this other symbol is an architecture or platform specific symbol, or PCI.
Generic symbols and drivers without platform dependencies keep their dependencies on HAS_DMA, to prevent compiling subsystems or drivers that cannot work anyway.
This simplifies the dependencies, and allows to improve compile-testing.
---
v4:
- Rebase to v4.18-rc1 (applies to next-20180622, too),
v3:
- Rebase to v4.17-rc1,
v2:
- Add Reviewed-by, Acked-by,
- Drop RFC state,
- Split per subsystem.
--- drivers/firewire/Kconfig | 1 - 1 file changed, 1 deletion(-)
drivers/firewire/Kconfig +0 -1
@@ -1,5 +1,4 @@ menu "IEEE 1394 (FireWire) support" - depends on HAS_DMA depends on PCI || COMPILE_TEST # firewire-core does not depend on PCI but is # not useful without PCI controller driver
Signature · 1 line
2.17.1
Quoted 9 lines · On Dec 03 Geert Uytterhoeven wrote:
Remove dependencies on
HAS_DMAwhere aKconfigsymbol depends on another symbol that impliesHAS_DMA, and, optionally, on "||COMPILE_TEST". In most cases this other symbol is an architecture or platform specific symbol, or PCI.Generic symbols and drivers without platform dependencies keep their dependencies on
HAS_DMA, to prevent compiling subsystems or drivers that cannot work anyway.
Quoted 5 lines
This simplifies the dependencies, and allows to improve compile-testing.
Signed-off-by Geert Uytterhoeven <[email protected]>Reviewed-by Mark Brown <[email protected]>Acked-by Robin Murphy <[email protected]>
Thanks for resending. Applied to linux1394.git #for-next.
Quoted 25 lines
---
v4:
- Rebase to v4.18-rc1 (applies to next-20180622, too),v3:
- Rebase to v4.17-rc1,v2:
- Add Reviewed-by, Acked-by,
- Drop RFC state,
- Split per subsystem.--- drivers/firewire/Kconfig | 1 - 1 file changed, 1 deletion(-)drivers/firewire/Kconfig +0
-1@@ -1,5 +1,4 @@ menu "IEEE 1394 (FireWire) support" - depends on HAS_DMA depends on PCI || COMPILE_TEST # firewire-core does not depend on PCI but is # not useful without PCI controller driver
Signature · 3 lines
Stefan Richter -======---=- ==-- ---== http://arcgraph.de/sr/