drm/sun4i: Allwinner A64 MIPI-DSI support
Subsystems (6)
v7 cover drm/sun4i: Allwinner A64 MIPI-DSI support
Here is next version changes for Allwinner A64 MIPI-DSI support
This series grouped the changes like previous version[1] with different sets to support three different panels types that can fit into the DSI controller.
set:1, for 4-lane, burst mode support
- patch 0001: 0009, DSI controller changes that support burst mode.
set:2, for A64 DSI support
- patch 0010: tcon dclk divider computation based on A64 BSP.
- patch 0011: 0017, Allwinner A64 DSI controller changes.
set:3, enable 4-lane burst mode panel:
- patch 0018: Overlay patch that enable Feiyang FY07024DI26A30-D burst mode panel on Pine64-LTS
set:4, enable 4-lane video mode panel:
- patch 0019: msg type MIPI_DSI_GENERIC_SHORT_WRITE_2_PARAM support
- patch 0020: Overlay patch that enable Bananapi S070WV20-CT16 ICN6211 panel on Bananapi M64
set:5, enable 2-lane video mode panel:
- patch 0021, 0022: DSI hfp and hbp timings fixes
- patch 0023: Enable Techstar TS8550B panel on Amarula A64-Relic
Changes for v7:
- moved vcc-dsi binding to required filed.
- drop quotes on fallback dphy bindings.
- drop min_rate clock pll-mipi patches.
- introduce dclk divider computation as like A64 BSP.
- add A64 DSI quark patches.
- fixed A64 DSI pipeline.
- add proper commit messages.
- collect Merlijn Wajer Tested-by credits.
Changes for v6:
- dropped unneeded changes, patches
- fixed all burst mode patches as per previous version comments
- rebase on master
- update proper commit message
- dropped unneeded comments
- order the patches that make review easy
Changes for v5:
- collect Rob, Acked-by
- droped "Fix VBP size calculation" patch
- updated vblk timing calculation.
- droped techstar, bananapi dsi panel drivers which may require bridge or other setup. it's under discussion.
Changes for v4:
- droppoed untested CCU_FEATURE_FIXED_POSTDIV check code in nkm min, max rate patches
- create two patches for "Add Allwinner A64 MIPI DSI support" one for has_mod_clk quirk and other one for A64 support
- use existing driver code construct for hblk computation
- dropped "Increase hfp packet overhead" patch [2], though BSP added this but we have no issues as of now.
(no issues on panel side w/o this change)
- create separate function for vblk computation
- enable vcc-dsi regulator in dsi_runtime_resume
- collect Rob, Acked-by
- update MAINTAINERS file for panel drivers
- cleanup commit messages
- fixed checkpatch warnings/errors
[1] https://patchwork.kernel.org/cover/10779893/
Any inputs?
Jagan.
Jagan Teki (23):
drm/sun4i: sun6i_mipi_dsi: Compute burst mode loop N1 instruction
delay
drm/sun4i: sun6i_mipi_dsi: Support instruction loop selection drm/sun4i: sun6i_mipi_dsi: Setup burst mode timings
drm/sun4i: sun6i_mipi_dsi: Simplify drq to support all modes
drm/sun4i: tcon: Export get tcon0 routine
drm/sun4i: sun6i_mipi_dsi: Probe tcon0 during dsi_bind
drm/sun4i: sun6i_mipi_dsi: Setup burst mode
drm/sun4i: sun6i_mipi_dsi: Enable trail_inv and trail_fill controls drm/sun4i: sun6i_mipi_dsi: Enable HBP, HSA_HSE for burst mode drm/sun4i: tcon: Compute DCLK dividers based on format, lanes
dt-bindings: sun6i-dsi: Add VCC-DSI supply property
drm/sun4i: sun6i_mipi_dsi: Add support for VCC-DSI voltage regulator
dt-bindings: sun6i-dsi: Add A64 MIPI-DSI compatible
dt-bindings: sun6i-dsi: Add A64 DPHY compatible (w/ A31 fallback) drm/sun4i: sun6i_mipi_dsi: Add has_mod_clk quirk
drm/sun4i: sun6i_mipi_dsi: Add Allwinner A64 MIPI DSI support
arm64: dts: allwinner: a64: Add MIPI DSI pipeline
[DO NOT MERGE] arm64: allwinner: a64: pine64-lts: Enable Feiyang FY07024DI26A30-D DSI
panel
drm/sun4i: sun6i_mipi_dsi: Add DSI Generic short write 2 param
transfer
[DO NOT MERGE] arm64: dts: allwinner: bananapi-m64: Bananapi S070WV20-CT16 DSI panel drm/sun4i: sun6i_mipi_dsi: Fix DSI hbp timing value
drm/sun4i: sun6i_mipi_dsi: Fix DSI hfp timing value
arm64: dts: allwinner: a64-amarula-relic: Add Techstar TS8550B
MIPI-DSI panel
.../bindings/display/sunxi/sun6i-dsi.txt | 3 + .../allwinner/sun50i-a64-amarula-relic.dts | 39 ++++ .../dts/allwinner/sun50i-a64-bananapi-m64.dts | 43 ++++ .../dts/allwinner/sun50i-a64-pine64-lts.dts | 39 ++++ arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 45 ++++ drivers/gpu/drm/sun4i/sun4i_tcon.c | 7 +- drivers/gpu/drm/sun4i/sun4i_tcon.h | 1 + drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 210 +++++++++++++++--- drivers/gpu/drm/sun4i/sun6i_mipi_dsi.h | 9 + 9 files changed, 367 insertions(+), 29 deletions(-)
Signature · 1 line
2.18.0.321.gffc6fa0e3
PATCH v7 1/23 drm/sun4i: sun6i_mipi_dsi: Compute burst mode loop N1 instruction delay
Loop N1 instruction delay varies between burst and non-burst video modes.
1) for burst mode panels it is computed based on the panel pixel clock along with horizontal sync and porch timings.
2) for non-burst mode panels, it is same as existing (50 - 1)
Reference code is available in BSP (from linux-sunxi drivers/video/sunxi/disp2/disp/de/lowlevel_sun50iw1/de_dsi.c)
dsi_dev[sel]->dsi_inst_loop_num.bits.loop_n1= (panel->lcd_ht-panel->lcd_x)*(150)/(panel->lcd_dclk_freq*8) - 50; => (((mode->htotal - mode->hdisplay) * 150) /
((mode->clock / 1000) * 8)) - 50;
This patch add loop N1 computation for burst mode by simplifying existing code to support all possible modes.
--- drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 20 +++++++++++++++++++- 1 file changed, 19 insertions(+), 1 deletion(-)
drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c +19 -1
@@ -354,6 +354,24 @@ static void sun6i_dsi_inst_init(struct sun6i_dsi *dsi, SUN6I_DSI_INST_JUMP_CFG_NUM(1)); }; +static u16 sun6i_dsi_setup_inst_delay (struct sun6i_dsi *dsi, +struct drm_display_mode *mode) +{ +struct mipi_dsi_device *device = dsi->device; +u32 hsync_porch, dclk; +u16 delay; + + hsync_porch = (mode->htotal - mode->hdisplay); + dclk = (mode->clock /1000 ); + +if (device->mode_flags &MIPI_DSI_MODE_VIDEO_BURST ) + delay = ((hsync_porch *150 ) / (dclk *8 )) -50 ; +else + delay =50 -1 ; + +return delay; +} +static u16 sun6i_dsi_get_video_start_delay (struct sun6i_dsi *dsi,struct drm_display_mode *mode) {
@@ -383,7 +401,7 @@ static void sun6i_dsi_setup_burst(struct sun6i_dsi *dsi,static void sun6i_dsi_setup_inst_loop (struct sun6i_dsi *dsi,struct drm_display_mode *mode) { -u16 delay =50 -1 ; +u16 delay =sun6i_dsi_setup_inst_delay (dsi, mode); regmap_write(dsi->regs, SUN6I_DSI_INST_LOOP_NUM_REG(0), SUN6I_DSI_INST_LOOP_NUM_N0(50 - 1) |
Signature · 1 line
2.18.0.321.gffc6fa0e3
PATCH v7 2/23 drm/sun4i: sun6i_mipi_dsi: Support instruction loop selection
In reply to Jagan TekiInstruction loop selection would require before writing loop number registers, so enable idle, LP11 bits on loop selection register.
Reference code available in BSP (from linux-sunxi/ drivers/video/sunxi/disp2/disp/de/lowlevel_sun50iw1/de_dsi.c)
(dsi_dev[sel]->dsi_inst_loop_sel.dwval = 2<<(4*DSI_INST_ID_LP11) |
3<<(4*DSI_INST_ID_DLY);
--- drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c +3 -0
@@ -403,6 +403,9 @@ static void sun6i_dsi_setup_inst_loop(struct sun6i_dsi *dsi, {u16 delay =sun6i_dsi_setup_inst_delay (dsi, mode); +regmap_write (dsi->regs,SUN6I_DSI_INST_LOOP_SEL_REG , +DSI_INST_ID_HSC << (4 *DSI_INST_ID_LP11 ) | +DSI_INST_ID_HSD << (4 *DSI_INST_ID_DLY ));regmap_write (dsi->regs,SUN6I_DSI_INST_LOOP_NUM_REG (0 ),SUN6I_DSI_INST_LOOP_NUM_N0 (50 -1 ) |SUN6I_DSI_INST_LOOP_NUM_N1 (delay));
Signature · 1 line
2.18.0.321.gffc6fa0e3
PATCH v7 3/23 drm/sun4i: sun6i_mipi_dsi: Setup burst mode timings
In reply to Jagan TekiBurst mode display timings are different from conventional video mode.
For burst mode most of the timings hsa, hbp, hfp, vblk are 0 and hblk is computed as (mode->hdisplay * Bpp)
This patch simply add burst mode timings without touching existing mode timings.
Reference code taken from BSP (from linux-sunxi/ drivers/video/sunxi/disp2/disp/de/lowlevel_sun50iw1/de_dsi.c)
dsi_hsa = 0;dsi_hbp = 0;dsi_hact = x*dsi_pixel_bits[format]/8;dsi_hblk = dsi_hact;dsi_hfp = 0;dsi_vblk = 0;
--- drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 7 +++++++ 1 file changed, 7 insertions(+)
drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c +7 -0
@@ -477,6 +477,12 @@ static void sun6i_dsi_setup_timings(struct sun6i_dsi *dsi,/* Do all timing calculations up front to allocate buffer space */ +if (device->mode_flags &MIPI_DSI_MODE_VIDEO_BURST ) { + hbp = hfp = hsa = vblk =0 ; + hblk = (mode->hdisplay * Bpp); + goto alloc_buf; + } +/* * A sync period is composed of a blanking packet (4 bytes + * payload + 2 bytes) and a sync event packet (4 bytes). Its
@@ -515,6 +521,7 @@ static void sun6i_dsi_setup_timings(struct sun6i_dsi *dsi,*/ vblk =0 ; +alloc_buf:/* How many bytes do we need to send all payloads? */ bytes =max_t (size_t,max (max (hfp, hblk),max (hsa, hbp)), vblk); buffer =kmalloc (bytes,GFP_KERNEL );
Signature · 1 line
2.18.0.321.gffc6fa0e3
PATCH v7 4/23 drm/sun4i: sun6i_mipi_dsi: Simplify drq to support all modes
In reply to Jagan TekiAllwinner MIPI DSI drq has enable mode bit and set bits.
1) drq for non-burst, with front porch less than 20 would need to set both enable mode bit and set bits.
2) drq for non-burst, with front porch greater or equal to 20 would not require to do any drq bit setup.
3) drq for burst mode, would only need to set enable mode bit.
This patch simplifies existing drq code by grouping into sun6i_dsi_get_drq and support all video modes.
--- drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 39 ++++++++++++++++---------- 1 file changed, 24 insertions(+), 15 deletions(-)
drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c +24 -15
@@ -354,6 +354,28 @@ static void sun6i_dsi_inst_init(struct sun6i_dsi *dsi, SUN6I_DSI_INST_JUMP_CFG_NUM(1)); }; +static int sun6i_dsi_get_drq (struct sun6i_dsi *dsi, +struct drm_display_mode *mode) +{ +struct mipi_dsi_device *device = dsi->device; + +if (device->mode_flags &MIPI_DSI_MODE_VIDEO_BURST ) +return SUN6I_DSI_TCON_DRQ_ENABLE_MODE ; + +if ((mode->hsync_start - mode->hdisplay) >20 ) { +/* Maaaaaagic */ +u16 drq = (mode->hsync_start - mode->hdisplay) -20 ; + + drq *=mipi_dsi_pixel_format_to_bpp (device->format); + drq /=32 ; + +return (SUN6I_DSI_TCON_DRQ_ENABLE_MODE | +SUN6I_DSI_TCON_DRQ_SET (drq)); + } + +return 0 ; +} +static u16 sun6i_dsi_setup_inst_delay (struct sun6i_dsi *dsi,struct drm_display_mode *mode) {
@@ -381,21 +403,8 @@ static u16 sun6i_dsi_get_video_start_delay(struct sun6i_dsi *dsi,static void sun6i_dsi_setup_burst (struct sun6i_dsi *dsi,struct drm_display_mode *mode) { -struct mipi_dsi_device *device = dsi->device; -u32 val =0 ; - -if ((mode->hsync_end - mode->hdisplay) >20 ) { -/* Maaaaaagic */ -u16 drq = (mode->hsync_end - mode->hdisplay) -20 ; - - drq *=mipi_dsi_pixel_format_to_bpp (device->format); - drq /=32 ; - - val = (SUN6I_DSI_TCON_DRQ_ENABLE_MODE | -SUN6I_DSI_TCON_DRQ_SET (drq)); - } - -regmap_write (dsi->regs,SUN6I_DSI_TCON_DRQ_REG , val); +regmap_write (dsi->regs,SUN6I_DSI_TCON_DRQ_REG , +sun6i_dsi_get_drq (dsi, mode)); } static void sun6i_dsi_setup_inst_loop(struct sun6i_dsi *dsi,
Signature · 1 line
2.18.0.321.gffc6fa0e3
PATCH v7 5/23 drm/sun4i: tcon: Export get tcon0 routine
In reply to Jagan TekiSometimes tcon attributes like tcon divider, clock rate etc are needed in interface drivers like DSI. So for such cases interface driver must probe the respective tcon and get the attributes.
Since tcon0 probe is already available, via sun4i_get_tcon0 function, export the same instead of probing tcon explicitly.
--- drivers/gpu/drm/sun4i/sun4i_tcon.c | 3 ++- drivers/gpu/drm/sun4i/sun4i_tcon.h | 1 + 2 files changed, 3 insertions(+), 1 deletion(-)
drivers/gpu/drm/sun4i/sun4i_tcon.c +2 -1
@@ -221,7 +221,7 @@ EXPORT_SYMBOL(sun4i_tcon_enable_vblank);* are located in TCON0. This helper returns a pointer to TCON0's * sun4i_tcon structure, or NULL if not found. */ -static struct sun4i_tcon *sun4i_get_tcon0 (struct drm_device *drm) +struct sun4i_tcon *sun4i_get_tcon0 (struct drm_device *drm) {struct sun4i_drv *drv = drm->dev_private;struct sun4i_tcon *tcon;
@@ -235,6 +235,7 @@ static struct sun4i_tcon *sun4i_get_tcon0(struct drm_device *drm)return NULL ; } +EXPORT_SYMBOL (sun4i_get_tcon0);void sun4i_tcon_set_mux (struct sun4i_tcon *tcon,int channel,const struct drm_encoder *encoder)
drivers/gpu/drm/sun4i/sun4i_tcon.h +1 -0
@@ -274,6 +274,7 @@ struct sun4i_tcon {struct drm_bridge *sun4i_tcon_find_bridge (struct device_node *node);struct drm_panel *sun4i_tcon_find_panel (struct device_node *node); +struct sun4i_tcon *sun4i_get_tcon0 (struct drm_device *drm);void sun4i_tcon_enable_vblank (struct sun4i_tcon *tcon,bool enable); void sun4i_tcon_mode_set(struct sun4i_tcon *tcon, const struct drm_encoder *encoder,
Signature · 1 line
2.18.0.321.gffc6fa0e3
PATCH v7 6/23 drm/sun4i: sun6i_mipi_dsi: Probe tcon0 during dsi_bind
In reply to Jagan TekiProbe tcon0 during dsi_bind, so-that the tcon attributes like divider value, clock rate can get whenever it need.
--- drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 7 +++++++ drivers/gpu/drm/sun4i/sun6i_mipi_dsi.h | 1 + 2 files changed, 8 insertions(+)
drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c +7 -0
@@ -24,6 +24,7 @@#include <drm/drm_panel.h> #include "sun4i_drv.h" +#include "sun4i_tcon.h" #include "sun6i_mipi_dsi.h" #include <video/mipi_display.h>
@@ -947,6 +948,7 @@ static int sun6i_dsi_bind(struct device *dev, struct device *master,struct drm_device *drm = data;struct sun4i_drv *drv = drm->dev_private;struct sun6i_dsi *dsi =dev_get_drvdata (dev); +struct sun4i_tcon *tcon0 =sun4i_get_tcon0 (drm);int ret;if (!dsi->panel)
@@ -954,6 +956,11 @@ static int sun6i_dsi_bind(struct device *dev, struct device *master, dsi->drv = drv; +if (!tcon0) +return -EINVAL ; + + dsi->tcon = tcon0; +drm_encoder_helper_add (&dsi->encoder, &sun6i_dsi_enc_helper_funcs); ret = drm_encoder_init(drm,
drivers/gpu/drm/sun4i/sun6i_mipi_dsi.h +1 -0
@@ -33,6 +33,7 @@ struct sun6i_dsi {struct device *dev;struct sun4i_drv *drv; +struct sun4i_tcon *tcon;struct mipi_dsi_device *device;struct drm_panel *panel; };
Signature · 1 line
2.18.0.321.gffc6fa0e3
PATCH v7 7/23 drm/sun4i: sun6i_mipi_dsi: Setup burst mode
In reply to Jagan TekiBurst mode in DSI would require separate setup initialization with respect to conventional video mode.
Allwinner DSI controller would need below sequence to setup the burst mode.
1) configure the burst drq.
2) configure the burst line.
3) finally enable mode.
To configure burst drq, controller would require to compute the edge0, edge1 and fill into burst mode register.
To configure burst line, controller would require to compute the line, sync values and fill into burst line register.
Enable burst mode, would require to enable burst mode bit in DSI control register.
Since there is no direct documentation for these computations the edge and line formulas are taken from BSP code (from linux-sunxi/ drivers/video/sunxi/disp2/disp/de/lowlevel_sun50iw1/de_dsi.c)
line_num = panel->lcd_ht*dsi_pixel_bits[panel->lcd_dsi_format]/
(8*panel->lcd_dsi_lane); edge1 = sync_point+(panel->lcd_x+panel->lcd_hbp+20)* dsi_pixel_bits[panel->lcd_dsi_format] /(8*panel->lcd_dsi_lane);
edge1 = (edge1>line_num)?line_num:edge1;
edge0 = edge1+(panel->lcd_x+40)*tcon_div/8;
edge0 = (edge0>line_num)?(edge0-line_num):1;
--- drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 70 ++++++++++++++++++++++++-- 1 file changed, 67 insertions(+), 3 deletions(-)
drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c +67 -3
@@ -355,6 +355,41 @@ static void sun6i_dsi_inst_init(struct sun6i_dsi *dsi, SUN6I_DSI_INST_JUMP_CFG_NUM(1)); }; +static u32 sun6i_dsi_get_edge1 (struct sun6i_dsi *dsi, +struct drm_display_mode *mode,u32 sync_point) +{ +struct mipi_dsi_device *device = dsi->device; +unsigned int bpp =mipi_dsi_pixel_format_to_bpp (device->format); +u32 hact_sync_bp; + +/* Horizontal timings duration excluding front porch */ + hact_sync_bp = (mode->hdisplay + mode->htotal - mode->hsync_start); + +return (sync_point + ((hact_sync_bp +20 ) * bpp / (8 * device->lanes))); +} + +static u32 sun6i_dsi_get_edge0 (struct sun6i_dsi *dsi, +struct drm_display_mode *mode,u32 edge1) +{ +struct sun4i_tcon *tcon = dsi->tcon; +unsigned long dclk_rate, dclk_parent_rate, tcon0_div; + + dclk_rate =clk_get_rate (tcon->dclk); + dclk_parent_rate =clk_get_rate (clk_get_parent (tcon->dclk)); + tcon0_div = dclk_parent_rate / dclk_rate; + +return (edge1 + (mode->hdisplay +40 ) * tcon0_div /8 ); +} + +static u32 sun6i_dsi_get_line_num (struct sun6i_dsi *dsi, +struct drm_display_mode *mode) +{ +struct mipi_dsi_device *device = dsi->device; +unsigned int bpp =mipi_dsi_pixel_format_to_bpp (device->format); + +return (mode->htotal * bpp / (8 * device->lanes)); +} +static int sun6i_dsi_get_drq (struct sun6i_dsi *dsi,struct drm_display_mode *mode) {
@@ -404,8 +439,32 @@ static u16 sun6i_dsi_get_video_start_delay(struct sun6i_dsi *dsi,static void sun6i_dsi_setup_burst (struct sun6i_dsi *dsi,struct drm_display_mode *mode) { -regmap_write (dsi->regs,SUN6I_DSI_TCON_DRQ_REG , -sun6i_dsi_get_drq (dsi, mode)); +struct mipi_dsi_device *device = dsi->device; +u32 sync_point =40 ; +u32 line_num =sun6i_dsi_get_line_num (dsi, mode); +u32 edge1 =sun6i_dsi_get_edge1 (dsi, mode, sync_point); +u32 edge0 =sun6i_dsi_get_edge0 (dsi, mode, edge1); +u32 val; + +if (edge1 > line_num) + edge1 = line_num; + +if (edge0 > line_num) + edge0 -= line_num; +else + edge0 =1 ; + +regmap_write (dsi->regs,SUN6I_DSI_BURST_DRQ_REG , +SUN6I_DSI_BURST_DRQ_EDGE1 (edge1) | +SUN6I_DSI_BURST_DRQ_EDGE0 (edge0)); +regmap_write (dsi->regs,SUN6I_DSI_BURST_LINE_REG , +SUN6I_DSI_BURST_LINE_NUM (line_num) | +SUN6I_DSI_BURST_LINE_SYNC_POINT (sync_point)); + +/* enable burst mode */ +regmap_read (dsi->regs,SUN6I_DSI_BASIC_CTL_REG , &val); + val |=SUN6I_DSI_BASIC_CTL_VIDEO_BURST ; +regmap_write (dsi->regs,SUN6I_DSI_BASIC_CTL_REG , val); } static void sun6i_dsi_setup_inst_loop(struct sun6i_dsi *dsi,
@@ -667,7 +726,12 @@ static void sun6i_dsi_encoder_enable(struct drm_encoder *encoder)SUN6I_DSI_BASIC_CTL1_VIDEO_PRECISION | SUN6I_DSI_BASIC_CTL1_VIDEO_MODE); -sun6i_dsi_setup_burst (dsi, mode); +regmap_write (dsi->regs,SUN6I_DSI_TCON_DRQ_REG , +sun6i_dsi_get_drq (dsi, mode)); + +if (device->mode_flags &MIPI_DSI_MODE_VIDEO_BURST ) +sun6i_dsi_setup_burst (dsi, mode); +sun6i_dsi_setup_inst_loop (dsi, mode);sun6i_dsi_setup_format (dsi, mode);sun6i_dsi_setup_timings (dsi, mode);
Signature · 1 line
2.18.0.321.gffc6fa0e3
PATCH v7 8/23 drm/sun4i: sun6i_mipi_dsi: Enable trail_inv and trail_fill controls
In reply to Jagan TekiThe burst mode panels with 4-lane would require to enable trail bits in DSI basic control register.
So, enable 2byte trail and trail_env for 4-lane burst mode devices.
Allwinner A64 BSP should also relie on same setup for enabling trail bit in DSI controller.
Reference code avialable in BSP (from linux-sunxi/ drivers/video/sunxi/disp2/disp/de/lowlevel_sun50iw1/de_dsi.c)
if (panel->lcd_dsi_lane == 4)
{
dsi_dev[sel]->dsi_basic_ctl.bits.trail_inv = 0xc;
dsi_dev[sel]->dsi_basic_ctl.bits.trail_fill = 1;
}
--- drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 6 ++++++ 1 file changed, 6 insertions(+)
drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c +6 -0
@@ -33,6 +33,8 @@#define SUN6I_DSI_CTL_EN BIT(0)#define SUN6I_DSI_BASIC_CTL_REG 0x00c +#define SUN6I_DSI_BASIC_CTL_TRAIL_INV (n) (((n) & 0xf) << 4) +#define SUN6I_DSI_BASIC_CTL_TRAIL_FILL BIT(3)#define SUN6I_DSI_BASIC_CTL_HBP_DIS BIT(2)#define SUN6I_DSI_BASIC_CTL_HSA_HSE_DIS BIT(1)#define SUN6I_DSI_BASIC_CTL_VIDEO_BURST BIT(0)
@@ -464,6 +466,10 @@ static void sun6i_dsi_setup_burst(struct sun6i_dsi *dsi,/* enable burst mode */ regmap_read (dsi->regs,SUN6I_DSI_BASIC_CTL_REG , &val); val |=SUN6I_DSI_BASIC_CTL_VIDEO_BURST ; +if (device->lanes ==4 ) { + val |=SUN6I_DSI_BASIC_CTL_TRAIL_INV (0xc ); + val |=SUN6I_DSI_BASIC_CTL_TRAIL_FILL ; + }regmap_write (dsi->regs,SUN6I_DSI_BASIC_CTL_REG , val); }
Signature · 1 line
2.18.0.321.gffc6fa0e3
PATCH v7 9/23 drm/sun4i: sun6i_mipi_dsi: Enable HBP, HSA_HSE for burst mode
In reply to Jagan TekiHorizontal back porch, sync active and sync end bits are needed to disable for burst mode panel operations.
So, disable them via dsi base control register.
--- drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c +6 -1
@@ -549,12 +549,17 @@ static void sun6i_dsi_setup_timings(struct sun6i_dsi *dsi,u16 hbp, hfp, hsa, hblk, vblk;size_t bytes;u8 *buffer; +u32 val =0 ;/* Do all timing calculations up front to allocate buffer space */ if (device->mode_flags &MIPI_DSI_MODE_VIDEO_BURST ) { hbp = hfp = hsa = vblk =0 ; hblk = (mode->hdisplay * Bpp); + +regmap_read (dsi->regs,SUN6I_DSI_BASIC_CTL_REG , &val); + val |=SUN6I_DSI_BASIC_CTL_HBP_DIS ; + val |=SUN6I_DSI_BASIC_CTL_HSA_HSE_DIS ; goto alloc_buf; }
@@ -603,7 +608,7 @@ static void sun6i_dsi_setup_timings(struct sun6i_dsi *dsi,if (WARN_ON (!buffer))return ; -regmap_write (dsi->regs,SUN6I_DSI_BASIC_CTL_REG ,0 ); +regmap_write (dsi->regs,SUN6I_DSI_BASIC_CTL_REG , val); regmap_write(dsi->regs, SUN6I_DSI_SYNC_HSS_REG, sun6i_dsi_build_sync_pkt(MIPI_DSI_H_SYNC_START,
Signature · 1 line
2.18.0.321.gffc6fa0e3
PATCH v7 10/23 drm/sun4i: tcon: Compute DCLK dividers based on format, lanes
In reply to Jagan TekiTCON dotclock compute the desired DCLK register divider based on panel pixel clock along with input DCLK or DSI clock dividers from tcon driver.
The current code allowing an input DCLK dividers ranging from 4 to 127, but the existing dclock logic is unable to compute the desired output DCLK divider value for new panels instead it ended-up producing unknown divider values which no longer exists.
So, add the computation logic 'format/lanes' to dclk min and max dividers and indeed it produced the desired DCLK divider even for the new panels.
This computation logic align with Allwinner A64 BSP, hoping that would work even for A33.
Tested this on 3 different panels, and below are the desired divider values with respect to pixel clock frequency.
- 55MHz pixel clock with 4-lane panel, and the desired DSI clock divider is 6 with the output parent clock rate of 330MHz.
- 30MHz pixel clock with 4-lane panel, and the desired DSI clock divider is 6 with parent clock rate of 180MHz.
- 27.5Mhz pixel clock with 2-lane pane, and the desired DSI clock divider is 12 with the output parent clock rate of 330MHz.
--- drivers/gpu/drm/sun4i/sun4i_tcon.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/sun4i/sun4i_tcon.c +2 -2
@@ -342,8 +342,8 @@ static void sun4i_tcon0_mode_set_cpu(struct sun4i_tcon *tcon,u32 block_space, start_delay;u32 tcon_div; - tcon->dclk_min_div =4 ; - tcon->dclk_max_div =127 ; + tcon->dclk_min_div = bpp / lanes; + tcon->dclk_max_div = bpp / lanes;sun4i_tcon0_mode_set_common (tcon, mode);
Signature · 1 line
2.18.0.321.gffc6fa0e3
PATCH v7 11/23 dt-bindings: sun6i-dsi: Add VCC-DSI supply property
In reply to Jagan TekiAllwinner MIPI DSI controllers are supplied with SoC DSI power rails via VCC-DSI pin.
Some board still work without supplying this but give more faith on datasheet and hardware schematics and document this supply property in required property list.
--- Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt +1 -0
@@ -21,6 +21,7 @@ Required properties: - phys: phandle to the D-PHY - phy-names: must be "dphy" - resets: phandle to the reset controller driving the encoder + - vcc-dsi-supply: the VCC-DSI power supply of the DSI encoder - ports: A ports node with endpoint definitions as defined in Documentation/devicetree/bindings/media/video-interfaces.txt. The
Signature · 1 line
2.18.0.321.gffc6fa0e3
PATCH v7 12/23 drm/sun4i: sun6i_mipi_dsi: Add support for VCC-DSI voltage regulator
In reply to Jagan TekiAllwinner MIPI DSI controllers are supplied with SoC DSI power rails via VCC-DSI pin.
Add support for this supply pin by adding voltage regulator handling code to MIPI DSI driver.
--- drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 14 ++++++++++++++ drivers/gpu/drm/sun4i/sun6i_mipi_dsi.h | 3 +++ 2 files changed, 17 insertions(+)
drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c +14 -0
@@ -1107,6 +1107,12 @@ static int sun6i_dsi_probe(struct platform_device *pdev)return PTR_ERR (base); } + dsi->regulator =devm_regulator_get (dev,"vcc-dsi" ); +if (IS_ERR (dsi->regulator)) { +dev_err (dev,"Couldn't get VCC-DSI supply\n" ); +return PTR_ERR (dsi->regulator); + } + dsi->regs =devm_regmap_init_mmio_clk (dev,"bus" , base, &sun6i_dsi_regmap_config);if (IS_ERR (dsi->regs)) {
@@ -1183,6 +1189,13 @@ static int sun6i_dsi_remove(struct platform_device *pdev)static int __maybe_unused sun6i_dsi_runtime_resume (struct device *dev) {struct sun6i_dsi *dsi =dev_get_drvdata (dev); +int err; + + err =regulator_enable (dsi->regulator); +if (err) { +dev_err (dsi->dev,"failed to enable VCC-DSI supply: %d\n" , err); +return err; + }reset_control_deassert (dsi->reset);clk_prepare_enable (dsi->mod_clk);
@@ -1215,6 +1228,7 @@ static int __maybe_unused sun6i_dsi_runtime_suspend(struct device *dev)clk_disable_unprepare (dsi->mod_clk);reset_control_assert (dsi->reset); +regulator_disable (dsi->regulator);return 0 ; }
drivers/gpu/drm/sun4i/sun6i_mipi_dsi.h +3 -0
@@ -13,6 +13,8 @@#include <drm/drm_encoder.h> #include <drm/drm_mipi_dsi.h> +#include <linux/regulator/consumer.h> +struct sun6i_dphy {struct clk *bus_clk;struct clk *mod_clk;
@@ -28,6 +30,7 @@ struct sun6i_dsi {struct clk *bus_clk;struct clk *mod_clk;struct regmap *regs; +struct regulator *regulator;struct reset_control *reset;struct sun6i_dphy *dphy;
Signature · 1 line
2.18.0.321.gffc6fa0e3
PATCH v7 13/23 dt-bindings: sun6i-dsi: Add A64 MIPI-DSI compatible
In reply to Jagan TekiThe MIPI DSI controller in Allwinner A64 is similar to A33.
But unlike A33, A64 doesn't have DSI_SCLK gating so it is valid to with separate compatible for A64 on the same driver.
--- Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt +1 -0
@@ -12,6 +12,7 @@ The DSI Encoder generates the DSI signal from the TCON's. Required properties: - compatible: value must be one of: * allwinner,sun6i-a31-mipi-dsi + * allwinner,sun50i-a64-mipi-dsi - reg: base address and size of memory-mapped region - interrupts: interrupt associated to this IP - clocks: phandles to the clocks feeding the DSI encoder
Signature · 1 line
2.18.0.321.gffc6fa0e3
PATCH v7 14/23 dt-bindings: sun6i-dsi: Add A64 DPHY compatible (w/ A31 fallback)
In reply to Jagan TekiThe MIPI DSI PHY controller on Allwinner A64 is similar on the one on A31.
Add A64 compatible and append A31 compatible as fallback.
--- Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt +1 -0
@@ -38,6 +38,7 @@ D-PHY Required properties: - compatible: value must be one of: * allwinner,sun6i-a31-mipi-dphy + * allwinner,sun50i-a64-mipi-dphy, allwinner,sun6i-a31-mipi-dphy - reg: base address and size of memory-mapped region - clocks: phandles to the clocks feeding the DSI encoder * bus: the DSI interface clock
Signature · 1 line
2.18.0.321.gffc6fa0e3
PATCH v7 15/23 drm/sun4i: sun6i_mipi_dsi: Add has_mod_clk quirk
In reply to Jagan TekiAs per the user manual, look like mod clock is not mandatory for all Allwinner MIPI DSI controllers, it is connected to CLK_DSI_SCLK for A31 and not available in A64.
So add has_mod_clk quirk and process the clk accordingly.
--- drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 38 ++++++++++++++++++-------- drivers/gpu/drm/sun4i/sun6i_mipi_dsi.h | 5 ++++ 2 files changed, 32 insertions(+), 11 deletions(-)
drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c +27 -11
@@ -10,6 +10,7 @@#include <linux/component.h> #include <linux/crc-ccitt.h> #include <linux/of_address.h> +#include <linux/of_device.h> #include <linux/pm_runtime.h> #include <linux/regmap.h> #include <linux/reset.h>
@@ -1099,6 +1100,7 @@ static int sun6i_dsi_probe(struct platform_device *pdev) dsi->dev = dev; dsi->host.ops = &sun6i_dsi_host_ops; dsi->host.dev = dev; + dsi->variant =of_device_get_match_data (dev); res =platform_get_resource (pdev,IORESOURCE_MEM ,0 ); base =devm_ioremap_resource (dev, res);
@@ -1126,17 +1128,20 @@ static int sun6i_dsi_probe(struct platform_device *pdev)return PTR_ERR (dsi->reset); } - dsi->mod_clk =devm_clk_get (dev,"mod" ); -if (IS_ERR (dsi->mod_clk)) { -dev_err (dev,"Couldn't get the DSI mod clock\n" ); -return PTR_ERR (dsi->mod_clk); +if (dsi->variant->has_mod_clk) { + dsi->mod_clk =devm_clk_get (dev,"mod" ); +if (IS_ERR (dsi->mod_clk)) { +dev_err (dev,"Couldn't get the DSI mod clock\n" ); +return PTR_ERR (dsi->mod_clk); + } }/* * In order to operate properly, that clock seems to be always * set to 297MHz. */ -clk_set_rate_exclusive (dsi->mod_clk,297000000 ); +if (dsi->variant->has_mod_clk) +clk_set_rate_exclusive (dsi->mod_clk,297000000 ); dphy_node =of_parse_phandle (dev->of_node,"phys" ,0 ); ret =sun6i_dphy_probe (dsi, dphy_node);
@@ -1168,7 +1173,8 @@ static int sun6i_dsi_probe(struct platform_device *pdev)pm_runtime_disable (dev);sun6i_dphy_remove (dsi); err_unprotect_clk: -clk_rate_exclusive_put (dsi->mod_clk); +if (dsi->variant->has_mod_clk) +clk_rate_exclusive_put (dsi->mod_clk);return ret; }
@@ -1181,7 +1187,8 @@ static int sun6i_dsi_remove(struct platform_device *pdev)mipi_dsi_host_unregister (&dsi->host);pm_runtime_disable (dev);sun6i_dphy_remove (dsi); -clk_rate_exclusive_put (dsi->mod_clk); +if (dsi->variant->has_mod_clk) +clk_rate_exclusive_put (dsi->mod_clk);return 0 ; }
@@ -1198,7 +1205,8 @@ static int __maybe_unused sun6i_dsi_runtime_resume(struct device *dev) }reset_control_deassert (dsi->reset); -clk_prepare_enable (dsi->mod_clk); +if (dsi->variant->has_mod_clk) +clk_prepare_enable (dsi->mod_clk);/* * Enable the DSI block.
@@ -1226,7 +1234,8 @@ static int __maybe_unused sun6i_dsi_runtime_suspend(struct device *dev) {struct sun6i_dsi *dsi =dev_get_drvdata (dev); -clk_disable_unprepare (dsi->mod_clk); +if (dsi->variant->has_mod_clk) +clk_disable_unprepare (dsi->mod_clk);reset_control_assert (dsi->reset);regulator_disable (dsi->regulator);
@@ -1239,9 +1248,16 @@ static const struct dev_pm_ops sun6i_dsi_pm_ops = { NULL) }; +static const struct sun6i_dsi_variant sun6i_a31_mipi_dsi = { + .has_mod_clk = true, +}; +static const struct of_device_id sun6i_dsi_of_table[] = { - { .compatible ="allwinner,sun6i-a31-mipi-dsi" }, - { } + { + .compatible ="allwinner,sun6i-a31-mipi-dsi" , + .data = &sun6i_a31_mipi_dsi, + }, + {/* sentinel */ } };MODULE_DEVICE_TABLE (of, sun6i_dsi_of_table);
drivers/gpu/drm/sun4i/sun6i_mipi_dsi.h +5 -0
@@ -22,6 +22,10 @@ struct sun6i_dphy {struct reset_control *reset; }; +struct sun6i_dsi_variant { +bool has_mod_clk; +}; +struct sun6i_dsi {struct drm_connector connector;struct drm_encoder encoder;
@@ -39,6 +43,7 @@ struct sun6i_dsi {struct sun4i_tcon *tcon;struct mipi_dsi_device *device;struct drm_panel *panel; +const struct sun6i_dsi_variant *variant; };static inline struct sun6i_dsi *host_to_sun6i_dsi (struct mipi_dsi_host *host)
Signature · 1 line
2.18.0.321.gffc6fa0e3
PATCH v7 16/23 drm/sun4i: sun6i_mipi_dsi: Add Allwinner A64 MIPI DSI support
In reply to Jagan TekiThe MIPI DSI controller in Allwinner A64 is similar to A33.
But unlike A33, A64 doesn't have DSI_SCLK gating so add compatible for Allwinner A64 with uninitialized has_mod_clk driver.
--- drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 7 +++++++ 1 file changed, 7 insertions(+)
drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c +7 -0
@@ -1252,11 +1252,18 @@ static const struct sun6i_dsi_variant sun6i_a31_mipi_dsi = { .has_mod_clk = true, }; +static const struct sun6i_dsi_variant sun50i_a64_mipi_dsi = { +}; +static const struct of_device_id sun6i_dsi_of_table[] = { { .compatible ="allwinner,sun6i-a31-mipi-dsi" , .data = &sun6i_a31_mipi_dsi, }, + { + .compatible ="allwinner,sun50i-a64-mipi-dsi" , + .data = &sun50i_a64_mipi_dsi, + }, {/* sentinel */ } };MODULE_DEVICE_TABLE (of, sun6i_dsi_of_table);
Signature · 1 line
2.18.0.321.gffc6fa0e3
PATCH v7 17/23 arm64: dts: allwinner: a64: Add MIPI DSI pipeline
In reply to Jagan TekiAdd MIPI DSI pipeline for Allwinner A64.
- dsi node, with A64 compatible since it doesn't support DSI_SCLK gating unlike A33
- dphy node, with A64 compatible with A33 fallback since DPHY on A64 and A33 is similar
- finally, attach the dsi_in to tcon0 for complete MIPI DSI
--- arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 45 +++++++++++++++++++ 1 file changed, 45 insertions(+)
arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi +45 -0
@@ -359,6 +359,12 @@ #address-cells = <1>; #size-cells = <0>; reg = <1>; + + tcon0_out_dsi: endpoint@1 { + reg = <1>; + remote-endpoint = <&dsi_in_tcon0>; + allwinner,tcon-channel = <1>; + }; }; }; };
@@ -936,6 +942,45 @@ status = "disabled"; }; + dsi: dsi@1ca0000 { + compatible = "allwinner,sun50i-a64-mipi-dsi"; + reg = <0x01ca0000 0x1000>; + interrupts = <GIC_SPI 89 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&ccu CLK_BUS_MIPI_DSI>; + clock-names = "bus"; + resets = <&ccu RST_BUS_MIPI_DSI>; + phys = <&dphy>; + phy-names = "dphy"; + status = "disabled"; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + #address-cells = <1>; + #size-cells = <0>; + reg = <0>; + + dsi_in_tcon0: endpoint { + remote-endpoint = <&tcon0_out_dsi>; + }; + }; + }; + }; + + dphy: d-phy@1ca1000 { + compatible = "allwinner,sun50i-a64-mipi-dphy", + "allwinner,sun6i-a31-mipi-dphy"; + reg = <0x01ca1000 0x1000>; + clocks = <&ccu CLK_BUS_MIPI_DSI>, + <&ccu CLK_DSI_DPHY>; + clock-names = "bus", "mod"; + resets = <&ccu RST_BUS_MIPI_DSI>; + status = "disabled"; + #phy-cells = <0>; + }; + csi: csi@1cb0000 { compatible = "allwinner,sun50i-a64-csi"; reg = <0x01cb0000 0x1000>;
Signature · 1 line
2.18.0.321.gffc6fa0e3
PATCH v7 18/23 arm64: allwinner: a64: pine64-lts: Enable Feiyang FY07024DI26A30-D DSI panel
In reply to Jagan TekiFeiyang FY07024DI26A30-D MIPI_DSI panel is desiged to attach with DSI connector on pine64 boards, enable the same for pine64 LTS.
DSI panel connected via board DSI port with,
- DC1SW as AVDD supply
- DLDO2 as DVDD supply
- DLDO1 as VCC-DSI supply
- PD24 gpio for reset pin
- PH10 gpio for backlight enable pin
--- .../dts/allwinner/sun50i-a64-pine64-lts.dts | 39 +++++++++++++++++++ 1 file changed, 39 insertions(+)
arch/arm64/boot/dts/allwinner/sun50i-a64-pine64-lts.dts +39 -0
@@ -5,9 +5,48 @@ */ #include "sun50i-a64-sopine-baseboard.dts" +#include <dt-bindings/pwm/pwm.h> / { model = "Pine64 LTS"; compatible = "pine64,pine64-lts", "allwinner,sun50i-r18", "allwinner,sun50i-a64"; + + backlight: backlight { + compatible = "pwm-backlight"; + pwms = <&r_pwm 0 50000 PWM_POLARITY_INVERTED>; + brightness-levels = <1 2 4 8 16 32 64 128 512>; + default-brightness-level = <8>; + enable-gpios = <&pio 7 10 GPIO_ACTIVE_HIGH>; /* LCD-BL-EN: PH10 */ + }; +}; + +&de { + status = "okay"; +}; + +&dphy { + status = "okay"; +}; + +&dsi { + vcc-dsi-supply = <®_dldo1>; /* VCC3V3-DSI */ + #address-cells = <1>; + #size-cells = <0>; + status = "okay"; + + panel@0 { + compatible = "feiyang,fy07024di26a30d"; + reg = <0>; + avdd-supply = <®_dc1sw>; /* VCC-LCD */ + dvdd-supply = <®_dldo2>; /* VCC-MIPI */ + reset-gpios = <&pio 3 24 GPIO_ACTIVE_HIGH>; /* LCD-RST: PD24 */ + backlight = <&backlight>; + }; +}; + +&r_pwm { + pinctrl-names = "default"; + pinctrl-0 = <&r_pwm_pin>; + status = "okay"; };
Signature · 1 line
2.18.0.321.gffc6fa0e3
PATCH v7 19/23 drm/sun4i: sun6i_mipi_dsi: Add DSI Generic short write 2 param transfer
In reply to Jagan TekiShort transfer write support for DCS and Generic transfer types share similar way to process command sequence in DSI block so add generic write 2 param transfer type macro so-that the panels which are requesting similar transfer type may process properly.
--- drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c +1 -0
@@ -984,6 +984,7 @@ static ssize_t sun6i_dsi_transfer(struct mipi_dsi_host *host,switch (msg->type) {case MIPI_DSI_DCS_SHORT_WRITE :case MIPI_DSI_DCS_SHORT_WRITE_PARAM : +case MIPI_DSI_GENERIC_SHORT_WRITE_2_PARAM : ret =sun6i_dsi_dcs_write_short (dsi, msg);break ;
Signature · 1 line
2.18.0.321.gffc6fa0e3
PATCH v7 20/23 arm64: dts: allwinner: bananapi-m64: Bananapi S070WV20-CT16 DSI panel
In reply to Jagan TekiThis patch add support for Bananapi S070WV20-CT16 DSI panel to BPI-M64 board.
DSI panel connected via board DSI port with,
- DLDO1 as VDD supply
- PD6 gpio for reset pin
- PD5 gpio for backlight enable pin
- PD7 gpio for backlight vdd supply
--- .../dts/allwinner/sun50i-a64-bananapi-m64.dts | 43 +++++++++++++++++++ 1 file changed, 43 insertions(+)
arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts +43 -0
@@ -45,6 +45,7 @@ #include "sun50i-a64.dtsi" #include <dt-bindings/gpio/gpio.h> +#include <dt-bindings/pwm/pwm.h> / { model = "BananaPi-M64";
@@ -56,6 +57,15 @@ serial1 = &uart1; }; + backlight: backlight { + compatible = "pwm-backlight"; + pwms = <&r_pwm 0 50000 PWM_POLARITY_INVERTED>; + brightness-levels = <1 2 4 8 16 32 64 128 512>; + default-brightness-level = <2>; + enable-gpios = <&pio 3 5 GPIO_ACTIVE_HIGH>; /* LCD-BL-EN: PD5 */ + power-supply = <®_vdd_backlight>; + }; + chosen { stdout-path = "serial0:115200n8"; };
@@ -126,6 +136,15 @@ }; }; + reg_vdd_backlight: vdd-backlight { + compatible = "regulator-fixed"; + regulator-name = "vdd-backlight"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + gpio = <&pio 3 7 GPIO_ACTIVE_HIGH>; /* LCD-PWR-EN: PD7 */ + enable-active-high; + }; + wifi_pwrseq: wifi_pwrseq { compatible = "mmc-pwrseq-simple"; reset-gpios = <&r_pio 0 2 GPIO_ACTIVE_LOW>; /* PL2 */
@@ -169,6 +188,24 @@ status = "okay"; }; +&dphy { + status = "okay"; +}; + +&dsi { + status = "okay"; + #address-cells = <1>; + #size-cells = <0>; + + panel@0 { + compatible = "bananapi,s070wv20-ct16-icn6211"; + reg = <0>; + reset-gpios = <&pio 3 6 GPIO_ACTIVE_HIGH>; /* LCD-RST: PD6 */ + vdd-supply = <®_dldo1>; + backlight = <&backlight>; + }; +}; + &ehci0 { status = "okay"; };
@@ -261,6 +298,12 @@ status = "okay"; }; +&r_pwm { + pinctrl-names = "default"; + pinctrl-0 = <&r_pwm_pin>; + status = "okay"; +}; + &r_rsb { status = "okay";
Signature · 1 line
2.18.0.321.gffc6fa0e3
PATCH v7 21/23 drm/sun4i: sun6i_mipi_dsi: Fix DSI hbp timing value
In reply to Jagan TekiCurrent driver is calculating hbp maximum value by subtracting hsync_start with hdisplay which is front porch value, but the hbp refers to back porch.
Back porch value is calculating by subtracting htotal with hsync_end as per drm_mode timings, and BSP code from BPI-M64-bsp is eventually following the same.
BPI-M64-bsp is computing hbp as
(in drivers/video/sunxi/disp2/disp/de/lowlevel_sun50iw1/de_dsi.c) dsi_hbp = (hbp-hspw)*dsi_pixel_bits[format]/8 - (4+2); => (panel->lcd_hbp - timmings->hor_sync_time)
=> (timmings->hor_back_porch + timmings->hor_sync_time -
timmings->hor_sync_time)
=> timmings->hor_back_porch
=> mode->htotal - mode->hsync_end
So, update the MIPI-DSI hbp value accordingly.
Tested on 2-lane, 4-lane DSI LCD panels.
--- drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c +1 -1
@@ -579,7 +579,7 @@ static void sun6i_dsi_setup_timings(struct sun6i_dsi *dsi,*/ #define HBP_PACKET_OVERHEAD 6 hbp =max ((unsigned int )HBP_PACKET_OVERHEAD , - (mode->hsync_start - mode->hdisplay) * Bpp -HBP_PACKET_OVERHEAD ); + (mode->htotal - mode->hsync_end) * Bpp -HBP_PACKET_OVERHEAD );/* * The frontporch is set using a blanking packet (4 bytes +
Signature · 1 line
2.18.0.321.gffc6fa0e3
PATCH v7 22/23 drm/sun4i: sun6i_mipi_dsi: Fix DSI hfp timing value
In reply to Jagan TekiCurrent driver is calculating hfp maximum value by subtracting htotal with hsync_end which is front back value, but the hpp refers to front porch.
Front porch value is calculating by subtracting hsync_start with hdisplay as per drm_mode timings, and BSP code from BPI-M64-bsp is eventually following the same.
BPI-M64-bsp is computing hfp as (from linux-sunxi/ drivers/video/sunxi/disp2/disp/de/lowlevel_sun50iw1/de_dsi.c)
dsi_hbp = (hbp-hspw)*dsi_pixel_bits[format]/8 - (4+2); dsi_hact = x * dsi_pixel_bits[format]/8; dsi_hblk = (ht-hspw)*dsi_pixel_bits[format]/8-(4+4+2); dsi_hfp = dsi_hblk - (4+dsi_hact+2) - (4+dsi_hbp+2);
Example,
u32 fmt = dsi_pixel_bits[format]/8;
=> ((ht-hspw)*fmt - 10) - (6 + x * fmt) - (6 + (hbp-hspw)*fmt - 6) => (ht - hspw - x - (hbp - hspw)) * fmt - 16
=> (ht - x - hbp) * fmt - 16
=> (ht - x - (timmings->hor_total_time - timmings->hor_front_porch - x)
* fmt - 16
=> (timmings->hor_total_time - x - timmings->hor_total_time + timmings->hor_front_porch + x) * fmt - 16
=> timmings->hor_front_porch * fmt - 16
So, update the DSI hfp timing accordingly.
Tested on 2-lane, 4-lane MIPI-DSI LCD panels.
--- drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c +2 -1
@@ -587,7 +587,8 @@ static void sun6i_dsi_setup_timings(struct sun6i_dsi *dsi,*/ #define HFP_PACKET_OVERHEAD 6 hfp =max ((unsigned int )HFP_PACKET_OVERHEAD , - (mode->htotal - mode->hsync_end) * Bpp -HFP_PACKET_OVERHEAD ); + (mode->hsync_start - mode->hdisplay) * Bpp - +HFP_PACKET_OVERHEAD );/* * hblk seems to be the line + porches length.
Signature · 1 line
2.18.0.321.gffc6fa0e3
PATCH v7 23/23 arm64: dts: allwinner: a64-amarula-relic: Add Techstar TS8550B MIPI-DSI panel
In reply to Jagan TekiAmarula A64-Relic board by default bound with Techstar TS8550B MIPI-DSI panel, add support for it.
DSI panel connected via board DSI port with,
- DLDO2 as VCC supply
- DLDO2 as IOVCC supply
- DLDO1 as VCC-DSI supply
- PD24 gpio for reset pin
- PD23 gpio for backlight enable pin
--- .../allwinner/sun50i-a64-amarula-relic.dts | 39 +++++++++++++++++++ 1 file changed, 39 insertions(+)
arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts +39 -0
@@ -9,6 +9,7 @@ #include "sun50i-a64.dtsi" #include <dt-bindings/gpio/gpio.h> +#include <dt-bindings/pwm/pwm.h> / { model = "Amarula A64-Relic";
@@ -18,6 +19,14 @@ serial0 = &uart0; }; + backlight: backlight { + compatible = "pwm-backlight"; + pwms = <&pwm 0 50000 PWM_POLARITY_INVERTED>; + brightness-levels = <1 2 4 8 16 32 64 128 512>; + default-brightness-level = <2>; + enable-gpios = <&pio 3 23 GPIO_ACTIVE_HIGH>; /* LCD-BL-EN: PD23 */ + }; + chosen { stdout-path = "serial0:115200n8"; };
@@ -83,6 +92,30 @@ }; }; +&de { + status = "okay"; +}; + +&dphy { + status = "okay"; +}; + +&dsi { + vcc-dsi-supply = <®_dldo1>; + #address-cells = <1>; + #size-cells = <0>; + status = "okay"; + + panel@0 { + compatible = "techstar,ts8550b", "sitronix,st7701"; + reg = <0>; + VCC-supply = <®_dldo2>; + IOVCC-supply = <®_dldo2>; + reset-gpios = <&pio 3 24 GPIO_ACTIVE_HIGH>; /* LCD-RST: PD24 */ + backlight = <&backlight>; + }; +}; + &ehci0 { status = "okay"; };
@@ -160,6 +193,12 @@ status = "okay"; }; +&pwm { + pinctrl-names = "default"; + pinctrl-0 = <&pwm_pin>; + status = "okay"; +}; + &r_rsb { status = "okay";
Signature · 1 line
2.18.0.321.gffc6fa0e3
Quoted 17 lines · Jagan Teki
Here is next version changes for Allwinner A64 MIPI-DSI support
This series grouped the changes like previous version[1] with different sets to support three different panels types that can fit into the DSI controller.
set:1, for 4-lane, burst mode support
- patch 0001: 0009, DSI controller changes that support burst mode.set:2, for A64 DSI support
- patch 0010: tcon dclk divider computation based on A64 BSP.
- patch 0011: 0017, Allwinner A64 DSI controller changes.set:3, enable 4-lane burst mode panel:
- patch 0018: Overlay patch that enable Feiyang FY07024DI26A30-D burst mode panel on Pine64-LTS
Quoted 8 lines
set:4, enable 4-lane video mode panel:
- patch 0019: msg typeMIPI_DSI_GENERIC_SHORT_WRITE_2_PARAMsupport
- patch 0020: Overlay patch that enable Bananapi S070WV20-CT16 ICN6211 panel on Bananapi M64set:5, enable 2-lane video mode panel:
- patch 0021, 0022: DSI hfp and hbp timings fixes
- patch 0023: Enable Techstar TS8550B panel on Amarula A64-Relic
You do realise that pushing through a series while the previous version's discussion hasn't settled yet will not get you anywhere, right?
Maxime
Signature · 3 lines
Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Quoted 24 lines · Maxime Ripard
Quoted 22 lines · Jagan Teki
Here is next version changes for Allwinner A64 MIPI-DSI support
This series grouped the changes like previous version[1] with different sets to support three different panels types that can fit into the DSI controller.
set:1, for 4-lane, burst mode support
- patch 0001: 0009, DSI controller changes that support burst mode.set:2, for A64 DSI support
- patch 0010: tcon dclk divider computation based on A64 BSP.
- patch 0011: 0017, Allwinner A64 DSI controller changes.set:3, enable 4-lane burst mode panel:
- patch 0018: Overlay patch that enable Feiyang FY07024DI26A30-D burst mode panel on Pine64-LTSset:4, enable 4-lane video mode panel:
- patch 0019: msg typeMIPI_DSI_GENERIC_SHORT_WRITE_2_PARAMsupport
- patch 0020: Overlay patch that enable Bananapi S070WV20-CT16 ICN6211 panel on Bananapi M64
Quoted 7 lines
Quoted 3 lines
set:5, enable 2-lane video mode panel:
- patch 0021, 0022: DSI hfp and hbp timings fixes
- patch 0023: Enable Techstar TS8550B panel on Amarula A64-RelicYou do realise that pushing through a series while the previous version's discussion hasn't settled yet will not get you anywhere, right?
Except the clock, I made few changes with your previous comments. Yes we can still under clock discussion page, no issues on that. just to group the remaining patches to finalize if any issues on those.
Quoted 70 lines · Jagan Teki
Here is next version changes for Allwinner A64 MIPI-DSI support
This series grouped the changes like previous version[1] with different sets to support three different panels types that can fit into the DSI controller.
set:1, for 4-lane, burst mode support
- patch 0001: 0009, DSI controller changes that support burst mode.set:2, for A64 DSI support
- patch 0010: tcon dclk divider computation based on A64 BSP.
- patch 0011: 0017, Allwinner A64 DSI controller changes.set:3, enable 4-lane burst mode panel:
- patch 0018: Overlay patch that enable Feiyang FY07024DI26A30-D burst mode panel on Pine64-LTSset:4, enable 4-lane video mode panel:
- patch 0019: msg typeMIPI_DSI_GENERIC_SHORT_WRITE_2_PARAMsupport
- patch 0020: Overlay patch that enable Bananapi S070WV20-CT16 ICN6211 panel on Bananapi M64set:5, enable 2-lane video mode panel:
- patch 0021, 0022: DSI hfp and hbp timings fixes
- patch 0023: Enable Techstar TS8550B panel on Amarula A64-RelicChanges for v7:
- moved vcc-dsi binding to required filed.
- drop quotes on fallback dphy bindings.
- dropmin_rateclock pll-mipi patches.
- introduce dclk divider computation as like A64 BSP.
- add A64 DSI quark patches.
- fixed A64 DSI pipeline.
- add proper commit messages.
- collect Merlijn Wajer Tested-by credits.
Changes for v6:
- dropped unneeded changes, patches
- fixed all burst mode patches as per previous version comments
- rebase on master
- update proper commit message
- dropped unneeded comments
- order the patches that make review easy
Changes for v5:
- collect Rob, Acked-by
- droped "Fix VBP size calculation" patch
- updated vblk timing calculation.
- droped techstar, bananapi dsi panel drivers which may require bridge or other setup. it's under discussion.
Changes for v4:
- droppoed untestedCCU_FEATURE_FIXED_POSTDIVcheck code in nkm min, max rate patches
- create two patches for "Add Allwinner A64 MIPI DSI support" one forhas_mod_clkquirk and other one for A64 support
- use existing driver code construct for hblk computation
- dropped "Increase hfp packet overhead" patch [2], though BSP added this but we have no issues as of now.
(no issues on panel side w/o this change)
- create separate function for vblk computation
- enable vcc-dsi regulator indsi_runtime_resume
- collect Rob, Acked-by
- updateMAINTAINERSfile for panel drivers
- cleanup commit messages
- fixed checkpatch warnings/errors[1] https://patchwork.kernel.org/cover/10779893/
Any inputs?
Jagan.
Quoted 11 lines
Jagan Teki (23):
drm/sun4i:sun6i_mipi_dsi: Compute burst mode loop N1 instruction
delay
drm/sun4i:sun6i_mipi_dsi: Support instruction loop selection drm/sun4i:sun6i_mipi_dsi: Setup burst mode timings drm/sun4i:sun6i_mipi_dsi: Simplify drq to support all modes drm/sun4i: tcon: Export get tcon0 routine
drm/sun4i:sun6i_mipi_dsi: Probe tcon0 duringdsi_binddrm/sun4i:sun6i_mipi_dsi: Setup burst mode
drm/sun4i:sun6i_mipi_dsi: Enabletrail_invandtrail_fillcontrols drm/sun4i:sun6i_mipi_dsi: Enable HBP,HSA_HSEfor burst mode
Can you pick these burst changes which are generic to all SoCs. and reset will send once we decide the tcon clock.
Quoted 83 lines · Jagan Teki
Quoted 70 lines · Jagan Teki
Here is next version changes for Allwinner A64 MIPI-DSI support
This series grouped the changes like previous version[1] with different sets to support three different panels types that can fit into the DSI controller.
set:1, for 4-lane, burst mode support
- patch 0001: 0009, DSI controller changes that support burst mode.set:2, for A64 DSI support
- patch 0010: tcon dclk divider computation based on A64 BSP.
- patch 0011: 0017, Allwinner A64 DSI controller changes.set:3, enable 4-lane burst mode panel:
- patch 0018: Overlay patch that enable Feiyang FY07024DI26A30-D burst mode panel on Pine64-LTSset:4, enable 4-lane video mode panel:
- patch 0019: msg typeMIPI_DSI_GENERIC_SHORT_WRITE_2_PARAMsupport
- patch 0020: Overlay patch that enable Bananapi S070WV20-CT16 ICN6211 panel on Bananapi M64set:5, enable 2-lane video mode panel:
- patch 0021, 0022: DSI hfp and hbp timings fixes
- patch 0023: Enable Techstar TS8550B panel on Amarula A64-RelicChanges for v7:
- moved vcc-dsi binding to required filed.
- drop quotes on fallback dphy bindings.
- dropmin_rateclock pll-mipi patches.
- introduce dclk divider computation as like A64 BSP.
- add A64 DSI quark patches.
- fixed A64 DSI pipeline.
- add proper commit messages.
- collect Merlijn Wajer Tested-by credits.
Changes for v6:
- dropped unneeded changes, patches
- fixed all burst mode patches as per previous version comments
- rebase on master
- update proper commit message
- dropped unneeded comments
- order the patches that make review easy
Changes for v5:
- collect Rob, Acked-by
- droped "Fix VBP size calculation" patch
- updated vblk timing calculation.
- droped techstar, bananapi dsi panel drivers which may require bridge or other setup. it's under discussion.
Changes for v4:
- droppoed untestedCCU_FEATURE_FIXED_POSTDIVcheck code in nkm min, max rate patches
- create two patches for "Add Allwinner A64 MIPI DSI support" one forhas_mod_clkquirk and other one for A64 support
- use existing driver code construct for hblk computation
- dropped "Increase hfp packet overhead" patch [2], though BSP added this but we have no issues as of now.
(no issues on panel side w/o this change)
- create separate function for vblk computation
- enable vcc-dsi regulator indsi_runtime_resume
- collect Rob, Acked-by
- updateMAINTAINERSfile for panel drivers
- cleanup commit messages
- fixed checkpatch warnings/errors[1] https://patchwork.kernel.org/cover/10779893/
Any inputs?
Jagan.Quoted 11 lines
Jagan Teki (23):
drm/sun4i:sun6i_mipi_dsi: Compute burst mode loop N1 instruction
delay
drm/sun4i:sun6i_mipi_dsi: Support instruction loop selection drm/sun4i:sun6i_mipi_dsi: Setup burst mode timings drm/sun4i:sun6i_mipi_dsi: Simplify drq to support all modes drm/sun4i: tcon: Export get tcon0 routine
drm/sun4i:sun6i_mipi_dsi: Probe tcon0 duringdsi_binddrm/sun4i:sun6i_mipi_dsi: Setup burst mode
drm/sun4i:sun6i_mipi_dsi: Enabletrail_invandtrail_fillcontrols drm/sun4i:sun6i_mipi_dsi: Enable HBP,HSA_HSEfor burst mode
Quoted 2 lines
Can you pick these burst changes which are generic to all SoCs. and reset will send once we decide the tcon clock.
These patches don't implement what we discussed last week, and as I told you already, most of them really need some work on the commit log and their explanations.
Maxime
Signature · 3 lines
Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Quoted 85 lines · Maxime Ripard
Quoted 83 lines · Jagan Teki
Quoted 81 lines · Jagan Teki
Here is next version changes for Allwinner A64 MIPI-DSI support
This series grouped the changes like previous version[1] with different sets to support three different panels types that can fit into the DSI controller.
set:1, for 4-lane, burst mode support
- patch 0001: 0009, DSI controller changes that support burst mode.set:2, for A64 DSI support
- patch 0010: tcon dclk divider computation based on A64 BSP.
- patch 0011: 0017, Allwinner A64 DSI controller changes.set:3, enable 4-lane burst mode panel:
- patch 0018: Overlay patch that enable Feiyang FY07024DI26A30-D burst mode panel on Pine64-LTSset:4, enable 4-lane video mode panel:
- patch 0019: msg typeMIPI_DSI_GENERIC_SHORT_WRITE_2_PARAMsupport
- patch 0020: Overlay patch that enable Bananapi S070WV20-CT16 ICN6211 panel on Bananapi M64set:5, enable 2-lane video mode panel:
- patch 0021, 0022: DSI hfp and hbp timings fixes
- patch 0023: Enable Techstar TS8550B panel on Amarula A64-RelicChanges for v7:
- moved vcc-dsi binding to required filed.
- drop quotes on fallback dphy bindings.
- dropmin_rateclock pll-mipi patches.
- introduce dclk divider computation as like A64 BSP.
- add A64 DSI quark patches.
- fixed A64 DSI pipeline.
- add proper commit messages.
- collect Merlijn Wajer Tested-by credits.
Changes for v6:
- dropped unneeded changes, patches
- fixed all burst mode patches as per previous version comments
- rebase on master
- update proper commit message
- dropped unneeded comments
- order the patches that make review easy
Changes for v5:
- collect Rob, Acked-by
- droped "Fix VBP size calculation" patch
- updated vblk timing calculation.
- droped techstar, bananapi dsi panel drivers which may require bridge or other setup. it's under discussion.
Changes for v4:
- droppoed untestedCCU_FEATURE_FIXED_POSTDIVcheck code in nkm min, max rate patches
- create two patches for "Add Allwinner A64 MIPI DSI support" one forhas_mod_clkquirk and other one for A64 support
- use existing driver code construct for hblk computation
- dropped "Increase hfp packet overhead" patch [2], though BSP added this but we have no issues as of now.
(no issues on panel side w/o this change)
- create separate function for vblk computation
- enable vcc-dsi regulator indsi_runtime_resume
- collect Rob, Acked-by
- updateMAINTAINERSfile for panel drivers
- cleanup commit messages
- fixed checkpatch warnings/errors[1] https://patchwork.kernel.org/cover/10779893/
Any inputs?
Jagan.Jagan Teki (23):
drm/sun4i:sun6i_mipi_dsi: Compute burst mode loop N1 instruction
delay
drm/sun4i:sun6i_mipi_dsi: Support instruction loop selection drm/sun4i:sun6i_mipi_dsi: Setup burst mode timings drm/sun4i:sun6i_mipi_dsi: Simplify drq to support all modes drm/sun4i: tcon: Export get tcon0 routine
drm/sun4i:sun6i_mipi_dsi: Probe tcon0 duringdsi_binddrm/sun4i:sun6i_mipi_dsi: Setup burst mode
drm/sun4i:sun6i_mipi_dsi: Enabletrail_invandtrail_fillcontrols drm/sun4i:sun6i_mipi_dsi: Enable HBP,HSA_HSEfor burst mode
Quoted 6 lines
Quoted 2 lines
Can you pick these burst changes which are generic to all SoCs. and reset will send once we decide the tcon clock.
These patches don't implement what we discussed last week, and as I told you already, most of them really need some work on the commit log and their explanations.
If I'm not wrong, we discussed about tcon_dclk (PLL_MIPI) last week
[1] and these burst changes between 01/23 to 09/23 which are generic changes to DSI and not related to clock. Apart from that I made few changes on commit logs between the versions (which I was mentioned on the cover-letter patch). If any issues issues on commit message, please let me know so-that I can rework.
Quoted 94 lines · Jagan Teki
Quoted 85 lines · Maxime Ripard
Quoted 83 lines · Jagan Teki
Quoted 81 lines · Jagan Teki
Here is next version changes for Allwinner A64 MIPI-DSI support
This series grouped the changes like previous version[1] with different sets to support three different panels types that can fit into the DSI controller.
set:1, for 4-lane, burst mode support
- patch 0001: 0009, DSI controller changes that support burst mode.set:2, for A64 DSI support
- patch 0010: tcon dclk divider computation based on A64 BSP.
- patch 0011: 0017, Allwinner A64 DSI controller changes.set:3, enable 4-lane burst mode panel:
- patch 0018: Overlay patch that enable Feiyang FY07024DI26A30-D burst mode panel on Pine64-LTSset:4, enable 4-lane video mode panel:
- patch 0019: msg typeMIPI_DSI_GENERIC_SHORT_WRITE_2_PARAMsupport
- patch 0020: Overlay patch that enable Bananapi S070WV20-CT16 ICN6211 panel on Bananapi M64set:5, enable 2-lane video mode panel:
- patch 0021, 0022: DSI hfp and hbp timings fixes
- patch 0023: Enable Techstar TS8550B panel on Amarula A64-RelicChanges for v7:
- moved vcc-dsi binding to required filed.
- drop quotes on fallback dphy bindings.
- dropmin_rateclock pll-mipi patches.
- introduce dclk divider computation as like A64 BSP.
- add A64 DSI quark patches.
- fixed A64 DSI pipeline.
- add proper commit messages.
- collect Merlijn Wajer Tested-by credits.
Changes for v6:
- dropped unneeded changes, patches
- fixed all burst mode patches as per previous version comments
- rebase on master
- update proper commit message
- dropped unneeded comments
- order the patches that make review easy
Changes for v5:
- collect Rob, Acked-by
- droped "Fix VBP size calculation" patch
- updated vblk timing calculation.
- droped techstar, bananapi dsi panel drivers which may require bridge or other setup. it's under discussion.
Changes for v4:
- droppoed untestedCCU_FEATURE_FIXED_POSTDIVcheck code in nkm min, max rate patches
- create two patches for "Add Allwinner A64 MIPI DSI support" one forhas_mod_clkquirk and other one for A64 support
- use existing driver code construct for hblk computation
- dropped "Increase hfp packet overhead" patch [2], though BSP added this but we have no issues as of now.
(no issues on panel side w/o this change)
- create separate function for vblk computation
- enable vcc-dsi regulator indsi_runtime_resume
- collect Rob, Acked-by
- updateMAINTAINERSfile for panel drivers
- cleanup commit messages
- fixed checkpatch warnings/errors[1] https://patchwork.kernel.org/cover/10779893/
Any inputs?
Jagan.Jagan Teki (23):
drm/sun4i:sun6i_mipi_dsi: Compute burst mode loop N1 instruction
delay
drm/sun4i:sun6i_mipi_dsi: Support instruction loop selection drm/sun4i:sun6i_mipi_dsi: Setup burst mode timings drm/sun4i:sun6i_mipi_dsi: Simplify drq to support all modes drm/sun4i: tcon: Export get tcon0 routine
drm/sun4i:sun6i_mipi_dsi: Probe tcon0 duringdsi_binddrm/sun4i:sun6i_mipi_dsi: Setup burst mode
drm/sun4i:sun6i_mipi_dsi: Enabletrail_invandtrail_fillcontrols drm/sun4i:sun6i_mipi_dsi: Enable HBP,HSA_HSEfor burst modeQuoted 6 lines
Quoted 2 lines
Can you pick these burst changes which are generic to all SoCs. and reset will send once we decide the tcon clock.
These patches don't implement what we discussed last week, and as I told you already, most of them really need some work on the commit log and their explanations.
Quoted 6 lines
If I'm not wrong, we discussed about
tcon_dclk(PLL_MIPI) last week
[1] and these burst changes between 01/23 to 09/23 which are generic changes to DSI and not related to clock. Apart from that I made few changes on commit logs between the versions (which I was mentioned on the cover-letter patch). If any issues issues on commit message, please let me know so-that I can rework.
Look like the same discussion rounding since from months. In fact I have grouped all changes by 'sets of patches' in this series which I was thinking of having more feasibility to review and merge, but seems like it ended-up fusing which patches are more prior and which are fixes. So, let me send it by breaking into different series based on the issues and generic changes.