drm/i915: Implement HDCP2.2
Subsystems (7)
v12 cover drm/i915: Implement HDCP2.2
This series enables the HDCP2.2 Type 0 for I915. The sequence for HDCP2.2 authentication and encryption is implemented as a generic flow between HDMI and DP. Encoder specific implementations are moved into hdcp_shim.
Intel HWs supports HDCP2.2 through ME FW. Hence this series introduces a client driver for mei bus, so that for HDCP2.2 authentication, HDCP2.2 stack in I915 can avail the services from ME FW. To enable this client driver set the config variable CONFIG_INTEL_MEI_HDCP.
Userspace interface remains unchanged as version agnostic. When userspace request for HDCP enable, Kernel will detect the HDCP source and sink's HDCP version(1.4/2.2)capability and enable the best capable version for that combination.
This series enables the HDCP2.2 for Type0 content streams.
Test-with: <[email protected]>
Major changes in v12
- hdcp disable from unbind is removed.
- hdcp component init and del are moved away from conenctor ops.
- Review comemnts from Tomas are addressed. [Tomas]
- Collected the r-bs and Acks given for v11.
- ICL mei dev id patch is cherry-picked fromgit://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git char-misc-linus
- Changes for component framework are merged into drm-tip already.
To ease the review process, series is hosted at
https://github.com/ramalingampc2008/drm-tip.git hdcp2_2_v12
Daniel Vetter (1):
drm/doc: document recommended component helper usage
Ramalingam C (34):
drm/i915: Gathering the HDCP1.4 routines together
drm: header for i915 - MEI_HDCP interface drm/i915: Initialize HDCP2.2
drm/i915: MEI interface definition
drm/i915: hdcp1.4 CP_IRQ handling and SW encryption tracking drm/i915: Enable and Disable of HDCP2.2
drm/i915: Implement HDCP2.2 receiver authentication
drm: helper functions for hdcp2 seq_num to from u32 drm/i915: Implement HDCP2.2 repeater authentication
drm: HDCP2.2 link check period
drm/i915: Implement HDCP2.2 link integrity check drm/i915: Handle HDCP2.2 downstream topology change
drm: removing the DP Errata msg and its msg id drm/i915: Implement the HDCP2.2 support for DP drm/i915: Implement the HDCP2.2 support for HDMI drm/i915: CP_IRQ handling for DP HDCP2.2 msgs drm/i915: Fix KBL HDCP2.2 encrypt status signalling misc/mei/hdcp: Client driver for HDCP application misc/mei/hdcp: Define ME FW interface for HDCP2.2 misc/mei/hdcp: Initiate Wired HDCP2.2 Tx Session misc/mei/hdcp: Verify Receiver Cert and prepare km misc/mei/hdcp: Verify H_prime
misc/mei/hdcp: Store the HDCP Pairing info misc/mei/hdcp: Initiate Locality check misc/mei/hdcp: Verify L_prime
misc/mei/hdcp: Prepare Session Key
misc/mei/hdcp: Repeater topology verification and ack misc/mei/hdcp: Verify M_prime
misc/mei/hdcp: Enabling the HDCP authentication misc/mei/hdcp: Closing wired HDCP2.2 Tx Session misc/mei/hdcp: Component framework for I915 Interface
FOR_TEST_ONLY: i915/Kconfig: Select mei_hdcp by I915
FOR_TESTING_ONLY: debugfs: Excluding the LSPCon for HDCP1.4
FOR_TESTING_ONLY: ICL: Limit clk to <= 340MHz
Tomas Winkler (3):
mei: bus: whitelist hdcp client
mei: bus: export to_mei_cl_device for mei client device drivers
mei: me: add ice lake point device id.
Documentation/driver-api/component.rst | 2 + Documentation/gpu/drm-internals.rst | 5 + drivers/gpu/drm/drm_drv.c | 14 + drivers/gpu/drm/i915/i915_debugfs.c | 10 +- drivers/gpu/drm/i915/i915_drv.c | 1 + drivers/gpu/drm/i915/i915_drv.h | 7 + drivers/gpu/drm/i915/intel_connector.c | 2 + drivers/gpu/drm/i915/intel_display.c | 4 + drivers/gpu/drm/i915/intel_dp.c | 350 ++++++++- drivers/gpu/drm/i915/intel_drv.h | 83 ++- drivers/gpu/drm/i915/intel_hdcp.c | 1242 +++++++++++++++++++++++++++++--- drivers/gpu/drm/i915/intel_hdmi.c | 240 +++++- drivers/misc/mei/Kconfig | 8 + drivers/misc/mei/Makefile | 2 + drivers/misc/mei/bus-fixup.c | 16 + drivers/misc/mei/bus.c | 1 - drivers/misc/mei/hdcp/Makefile | 7 + drivers/misc/mei/hdcp/mei_hdcp.c | 842 ++++++++++++++++++++++ drivers/misc/mei/hdcp/mei_hdcp.h | 389 ++++++++++ drivers/misc/mei/hw-me-regs.h | 2 + drivers/misc/mei/pci-me.c | 2 + include/drm/drm_hdcp.h | 25 +- include/drm/i915_component.h | 3 + include/drm/i915_mei_hdcp_interface.h | 148 ++++ include/linux/mei_cl_bus.h | 2 + 25 files changed, 3280 insertions(+), 127 deletions(-) create mode 100644 drivers/misc/mei/hdcp/Makefile create mode 100644 drivers/misc/mei/hdcp/mei_hdcp.c create mode 100644 drivers/misc/mei/hdcp/mei_hdcp.h create mode 100644 include/drm/i915_mei_hdcp_interface.h
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v12 1/38 drm/doc: document recommended component helper usage
From: Daniel Vetter <[email protected]>
Now that component has docs it's worth spending a few words and hyperlinks on recommended best practices in drm.
--- Documentation/driver-api/component.rst | 2 ++ Documentation/gpu/drm-internals.rst | 5 +++++ drivers/gpu/drm/drm_drv.c | 14 ++++++++++++++ 3 files changed, 21 insertions(+)
Documentation/driver-api/component.rst +2 -0
@@ -1,3 +1,5 @@ +.. _component: + ====================================== Component Helper for Aggregate Drivers ======================================
Documentation/gpu/drm-internals.rst +5 -0
@@ -93,6 +93,11 @@ Device Instance and Driver Handling Driver Load ----------- +Component Helper Usage +~~~~~~~~~~~~~~~~~~~~~~ + +.. kernel-doc:: drivers/gpu/drm/drm_drv.c + :doc: component helper usage recommendations IRQ Helper Library ~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/drm_drv.c +14 -0
@@ -457,6 +457,20 @@ static void drm_fs_inode_free(struct inode *inode) }/** +* DOC: component helper usage recommendations +* +* DRM drivers that drive hardware where a logical device consists of a pile of +* independent hardware blocks are recommended to use the :ref:`component helper +* library<component>`. The entire device initialization procedure should be run +* from the &component_master_ops.master_bind callback, starting with +* drm_dev_init(), then binding all components with component_bind_all() and +* finishing with drm_dev_register(). For consistency and easier sharing of +* components across drivers the opaque pointer passed to all components through +* component_bind_all() should point at &struct drm_device of the device +* instance, not some driver specific private structure. +*/ + +/** * drm_dev_init - Initialise new DRM device * @dev: DRM device * @driver: DRM driver
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH v12 01/38] drm/doc: document recommended component helper usage
Quoted 7 lines · Ramalingam C
From: Daniel Vetter <[email protected]>
Now that component has docs it's worth spending a few words and hyperlinks on recommended best practices in drm.
Cc Russell King - ARM Linux admin <[email protected]>Signed-off-by Daniel Vetter <[email protected]>
Just a quick reminder: When sending out other people's patches, you need to add your own s-o-b line per https://developercertificate.org/
Cheers, Daniel
Quoted 60 lines
--- Documentation/driver-api/component.rst | 2 ++ Documentation/gpu/drm-internals.rst | 5 +++++ drivers/gpu/drm/drm_drv.c | 14 ++++++++++++++ 3 files changed, 21 insertions(+)Documentation/driver-api/component.rst +2
-0@@ -1,3 +1,5 @@ +.. _component: + ====================================== Component Helper for Aggregate Drivers ======================================Documentation/gpu/drm-internals.rst +5
-0@@ -93,6 +93,11 @@ Device Instance and Driver Handling Driver Load ----------- +Component Helper Usage +~~~~~~~~~~~~~~~~~~~~~~ + +.. kernel-doc:: drivers/gpu/drm/drm_drv.c + :doc: component helper usage recommendations IRQ Helper Library ~~~~~~~~~~~~~~~~~~drivers/gpu/drm/drm_drv.c +14
-0@@ -457,6 +457,20 @@ static void drm_fs_inode_free(struct inode *inode) }/** +* DOC: component helper usage recommendations +* +* DRM drivers that drive hardware where a logical device consists of a pile of +* independent hardware blocks are recommended to use the :ref:`component helper +* library<component>`. The entire device initialization procedure should be run +* from the &component_master_ops.master_bind callback, starting with +* drm_dev_init(), then binding all components with component_bind_all() and +* finishing with drm_dev_register(). For consistency and easier sharing of +* components across drivers the opaque pointer passed to all components through +* component_bind_all() should point at &struct drm_device of the device +* instance, not some driver specific private structure. +*/ + +/** * drm_dev_init - Initialise new DRM device * @dev: DRM device * @driver: DRM driver Signature · 1 line
2.7.4
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH v12 01/38] drm/doc: document recommended component helper usage
In reply to Ramalingam CHi Daniel,
Thank you for the patch.
Quoted 44 lines · Ramalingam C
From: Daniel Vetter <[email protected]>
Now that component has docs it's worth spending a few words and hyperlinks on recommended best practices in drm.
Cc Russell King - ARM Linux admin <[email protected]>Signed-off-by Daniel Vetter <[email protected]>--- Documentation/driver-api/component.rst | 2 ++ Documentation/gpu/drm-internals.rst | 5 +++++ drivers/gpu/drm/drm_drv.c | 14 ++++++++++++++ 3 files changed, 21 insertions(+)Documentation/driver-api/component.rst +2
-0@@ -1,3 +1,5 @@ +.. _component: + ====================================== Component Helper for Aggregate Drivers ======================================Documentation/gpu/drm-internals.rst +5
-0@@ -93,6 +93,11 @@ Device Instance and Driver Handling Driver Load ----------- +Component Helper Usage +~~~~~~~~~~~~~~~~~~~~~~ + +.. kernel-doc:: drivers/gpu/drm/drm_drv.c + :doc: component helper usage recommendations IRQ Helper Library ~~~~~~~~~~~~~~~~~~drivers/gpu/drm/drm_drv.c +0
-0
drivers/gpu/drm/drm_drv.c static void drm_fs_inode_free(struct inode *inode) · line 464
Quoted 8 lines
drivers/gpu/drm/drm_drv.c +5
-0@@ -457,6 +457,20 @@ static void drm_fs_inode_free(struct inode *inode) }/** +* DOC: component helper usage recommendations +* +* DRM drivers that drive hardware where a logical device consists of a pile of +* independent hardware blocks are recommended to use the :ref:`component helper +* library<component>`.
That's the first recommendation I would challenge :-) When using drm_bridge and drm_panel, the component framework is not strictly needed. The DRM/KMS probe function can defer probe when a bridge or panel is missing. Only when two-way dependencies exist between the display controller and the external components is the component framework required.
Quoted 4 lines
The entire device initialization procedure should be run
+ * from the &component_master_ops.master_bind callback, starting with
+ *drm_dev_init(), then binding all components withcomponent_bind_all()and
+ * finishing withdrm_dev_register().
The omapdss driver, for instance, performs hardware-specific initialization of the DSS in the probe() handler itself (DT-related parsing, memory mapping, IRQ registration, ...). I don't see why this would need to move to the .master_bind() callback.
Quoted 4 lines
For consistency and easier sharing of
+ * components across drivers the opaque pointer passed to all components through
+ *component_bind_all()should point at &structdrm_deviceof the device
+ * instance, not some driver specific private structure.
I'd say "shall" instead of "should" to make this a hard requirement. The opaque pointer is something that I have never really liked in the component framework as it hinders reusability. I have a few ideas on how to fix that but haven't had time to try them out yet as the changes would be quite intrusive. Long term major changes will be needed there anyway as it makes no sense to have to frameworks with similar purposes in DRM/KMS and V4L2.
Quoted 6 lines
+ */
drivers/gpu/drm/drm_drv.c +2
-0+ +/** * drm_dev_init - Initialise new DRM device * @dev: DRM device * @driver: DRM driver
Signature · 7 lines
Regards, Laurent Pinchart _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH v12 01/38] drm/doc: document recommended component helper usage
Quoted 51 lines · Laurent Pinchart
Hi Daniel,
Thank you for the patch.
Quoted 46 lines · Ramalingam C
From: Daniel Vetter <[email protected]>
Now that component has docs it's worth spending a few words and hyperlinks on recommended best practices in drm.
Cc Russell King - ARM Linux admin <[email protected]>Signed-off-by Daniel Vetter <[email protected]>--- Documentation/driver-api/component.rst | 2 ++ Documentation/gpu/drm-internals.rst | 5 +++++ drivers/gpu/drm/drm_drv.c | 14 ++++++++++++++ 3 files changed, 21 insertions(+)Documentation/driver-api/component.rst +2
-0@@ -1,3 +1,5 @@ +.. _component: + ====================================== Component Helper for Aggregate Drivers ======================================Documentation/gpu/drm-internals.rst +5
-0@@ -93,6 +93,11 @@ Device Instance and Driver Handling Driver Load ----------- +Component Helper Usage +~~~~~~~~~~~~~~~~~~~~~~ + +.. kernel-doc:: drivers/gpu/drm/drm_drv.c + :doc: component helper usage recommendations IRQ Helper Library ~~~~~~~~~~~~~~~~~~drivers/gpu/drm/drm_drv.c +0
-0@@ -457,6 +457,20 @@ static void drm_fs_inode_free(struct inode *inode) }
Quoted 13 lines
drivers/gpu/drm/drm_drv.c static void drm_fs_inode_free(struct inode *inode)
Quoted 6 lines
drivers/gpu/drm/drm_drv.c +5
-0/** +* DOC: component helper usage recommendations +* +* DRM drivers that drive hardware where a logical device consists of a pile of +* independent hardware blocks are recommended to use the :ref:`component helper +* library<component>`. That's the first recommendation I would challenge :-) When using
drm_bridgeanddrm_panel, the component framework is not strictly needed. The DRM/KMS probe function can defer probe when a bridge or panel is missing. Only when two-way dependencies exist between the display controller and the external components is the component framework required.
In the component docs themselves (just landed) we explicitly restrict component to only the cases where there's no other subsytem specific way to assemble the pile. I'll add that here, explicitly pointing out panels/bridges.
Quoted 9 lines
Quoted 4 lines
The entire device initialization procedure should be run
+ * from the &component_master_ops.master_bind callback, starting with
+ *drm_dev_init(), then binding all components withcomponent_bind_all()and
+ * finishing withdrm_dev_register().The omapdss driver, for instance, performs hardware-specific initialization of the DSS in the
probe()handler itself (DT-related parsing, memory mapping, IRQ registration, ...). I don't see why this would need to move to the .master_bind() callback.
It's a bit the odd one out then. Not sure whether there's a hard reason for that or not.
Quoted 5 lines
Quoted 4 lines
For consistency and easier sharing of
+ * components across drivers the opaque pointer passed to all components through
+ *component_bind_all()should point at &structdrm_deviceof the device
+ * instance, not some driver specific private structure.
Quoted 7 lines
I'd say "shall" instead of "should" to make this a hard requirement. The opaque pointer is something that I have never really liked in the component framework as it hinders reusability. I have a few ideas on how to fix that but haven't had time to try them out yet as the changes would be quite intrusive. Long term major changes will be needed there anyway as it makes no sense to have to frameworks with similar purposes in DRM/KMS and V4L2.
We have a pile of components around i915 (but not for the core drm_device) which point at anything but drm_device. Otoh you'll never going to reuse those pieces. I think anytime you want to reuse component drivers across drivers you actually want a new subsystem (like drm_bridge/panel) with dedicated lookup functions, and no void * pointers anywhere. I'd go as far and say code reuse across drivers is mostly out of scope for component. -Daniel
Quoted 12 lines
Quoted 7 lines
+ */
drivers/gpu/drm/drm_drv.c +2
-0+ +/** * drm_dev_init - Initialise new DRM device * @dev: DRM device * @driver: DRM driver Signature · 3 lines
Regards, Laurent Pinchart
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v12 2/38 drm/i915: Gathering the HDCP1.4 routines together
In reply to Ramalingam CAll HDCP1.4 routines are gathered together, followed by the generic functions those can be extended for HDCP2.2 too.
--- drivers/gpu/drm/i915/intel_hdcp.c | 118 +++++++++++++++++++------------------- 1 file changed, 59 insertions(+), 59 deletions(-)
drivers/gpu/drm/i915/intel_hdcp.c +59 -59
@@ -730,6 +730,65 @@ struct intel_connector *intel_hdcp_to_connector(struct intel_hdcp *hdcp) return container_of(hdcp, struct intel_connector, hdcp); } +/* Implements Part 3 of the HDCP authorization procedure */ +int intel_hdcp_check_link (struct intel_connector *connector) +{ +struct intel_hdcp *hdcp = &connector->hdcp; +struct drm_i915_private *dev_priv = connector->base.dev->dev_private; +struct intel_digital_port *intel_dig_port =conn_to_dig_port (connector); +enum port port = intel_dig_port->base.port; +int ret =0 ; + +if (!hdcp->shim) +return -ENOENT ; + +mutex_lock (&hdcp->mutex); + +if (hdcp->value ==DRM_MODE_CONTENT_PROTECTION_UNDESIRED ) + goto out; + +if (!(I915_READ (PORT_HDCP_STATUS (port)) &HDCP_STATUS_ENC )) { +DRM_ERROR ("%s:%d HDCP check failed: link is not encrypted,%x\n" , + connector->base.name, connector->base.base.id, +I915_READ (PORT_HDCP_STATUS (port))); + ret = -ENXIO ; + hdcp->value =DRM_MODE_CONTENT_PROTECTION_DESIRED ; +schedule_work (&hdcp->prop_work); + goto out; + } + +if (hdcp->shim->check_link (intel_dig_port)) { +if (hdcp->value !=DRM_MODE_CONTENT_PROTECTION_UNDESIRED ) { + hdcp->value =DRM_MODE_CONTENT_PROTECTION_ENABLED ; +schedule_work (&hdcp->prop_work); + } + goto out; + } + +DRM_DEBUG_KMS ("[%s:%d] HDCP link failed, retrying authentication\n" , + connector->base.name, connector->base.base.id); + + ret =_intel_hdcp_disable (connector); +if (ret) { +DRM_ERROR ("Failed to disable hdcp (%d)\n" , ret); + hdcp->value =DRM_MODE_CONTENT_PROTECTION_DESIRED ; +schedule_work (&hdcp->prop_work); + goto out; + } + + ret =_intel_hdcp_enable (connector); +if (ret) { +DRM_ERROR ("Failed to enable hdcp (%d)\n" , ret); + hdcp->value =DRM_MODE_CONTENT_PROTECTION_DESIRED ; +schedule_work (&hdcp->prop_work); + goto out; + } + +out: +mutex_unlock (&hdcp->mutex); +return ret; +} +static void intel_hdcp_check_work (struct work_struct *work) { struct intel_hdcp *hdcp = container_of(to_delayed_work(work),
@@ -866,62 +925,3 @@ void intel_hdcp_atomic_check(struct drm_connector *connector, new_state->crtc); crtc_state->mode_changed = true; } - -/* Implements Part 3 of the HDCP authorization procedure */ -int intel_hdcp_check_link (struct intel_connector *connector) -{ -struct intel_hdcp *hdcp = &connector->hdcp; -struct drm_i915_private *dev_priv = connector->base.dev->dev_private; -struct intel_digital_port *intel_dig_port =conn_to_dig_port (connector); -enum port port = intel_dig_port->base.port; -int ret =0 ; - -if (!hdcp->shim) -return -ENOENT ; - -mutex_lock (&hdcp->mutex); - -if (hdcp->value ==DRM_MODE_CONTENT_PROTECTION_UNDESIRED ) - goto out; - -if (!(I915_READ (PORT_HDCP_STATUS (port)) &HDCP_STATUS_ENC )) { -DRM_ERROR ("%s:%d HDCP check failed: link is not encrypted,%x\n" , - connector->base.name, connector->base.base.id, -I915_READ (PORT_HDCP_STATUS (port))); - ret = -ENXIO ; - hdcp->value =DRM_MODE_CONTENT_PROTECTION_DESIRED ; -schedule_work (&hdcp->prop_work); - goto out; - } - -if (hdcp->shim->check_link (intel_dig_port)) { -if (hdcp->value !=DRM_MODE_CONTENT_PROTECTION_UNDESIRED ) { - hdcp->value =DRM_MODE_CONTENT_PROTECTION_ENABLED ; -schedule_work (&hdcp->prop_work); - } - goto out; - } - -DRM_DEBUG_KMS ("[%s:%d] HDCP link failed, retrying authentication\n" , - connector->base.name, connector->base.base.id); - - ret =_intel_hdcp_disable (connector); -if (ret) { -DRM_ERROR ("Failed to disable hdcp (%d)\n" , ret); - hdcp->value =DRM_MODE_CONTENT_PROTECTION_DESIRED ; -schedule_work (&hdcp->prop_work); - goto out; - } - - ret =_intel_hdcp_enable (connector); -if (ret) { -DRM_DEBUG_KMS ("Failed to enable hdcp (%d)\n" , ret); - hdcp->value =DRM_MODE_CONTENT_PROTECTION_DESIRED ; -schedule_work (&hdcp->prop_work); - goto out; - } - -out: -mutex_unlock (&hdcp->mutex); -return ret; -}
Signature · 6 lines
2.7.4 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH v12 3/38 drm: header for i915 - MEI_HDCP interface
In reply to Ramalingam CHeader defines the interface for the I915 and MEI_HDCP drivers. This interface is specific to the usage of mei_hdcp from gen9+ platforms for ME FW based HDCP2.2 services.
And Generic HDCP2.2 protocol specific definitions
are added at drm/drm_hdcp.h.
v2:
Commit msg is enhanced [Daniel]
v3:
i915_hdcp_comp_master is defined.
--- include/drm/i915_mei_hdcp_interface.h | 148 ++++++++++++++++++++++++++++++++++ 1 file changed, 148 insertions(+) create mode 100644 include/drm/i915_mei_hdcp_interface.h
include/drm/i915_mei_hdcp_interface.h new file +148 -0
@@ -0,0 +1,148 @@ +/* SPDX-License-Identifier: (GPL-2.0+) */ +/* +* Copyright © 2017-2018 Intel Corporation +* +* Authors: +* Ramalingam C <[email protected]> +*/ + +#ifndef _I915_MEI_HDCP_INTERFACE_H_ +#define _I915_MEI_HDCP_INTERFACE_H_ + +#include <linux/mutex.h> +#include <linux/device.h> +#include <drm/drm_hdcp.h> + +/** +* enum hdcp_port_type - HDCP port implementation type defined by ME FW +* @HDCP_PORT_TYPE_INVALID: Invalid hdcp port type +* @HDCP_PORT_TYPE_INTEGRATED: In-Host HDCP2.x port +* @HDCP_PORT_TYPE_LSPCON: HDCP2.2 discrete wired Tx port with LSPCON +* (HDMI 2.0) solution +* @HDCP_PORT_TYPE_CPDP: HDCP2.2 discrete wired Tx port using the CPDP (DP 1.3) +* solution +*/ +enum hdcp_port_type { +HDCP_PORT_TYPE_INVALID , +HDCP_PORT_TYPE_INTEGRATED , +HDCP_PORT_TYPE_LSPCON , +HDCP_PORT_TYPE_CPDP +}; + +/** +* enum hdcp_wired_protocol - HDCP adaptation used on the port +* @HDCP_PROTOCOL_INVALID: Invalid HDCP adaptation protocol +* @HDCP_PROTOCOL_HDMI: HDMI adaptation of HDCP used on the port +* @HDCP_PROTOCOL_DP: DP adaptation of HDCP used on the port +*/ +enum hdcp_wired_protocol { +HDCP_PROTOCOL_INVALID , +HDCP_PROTOCOL_HDMI , +HDCP_PROTOCOL_DP +}; + +/** +* struct hdcp_port_data - intel specific HDCP port data +* @port: port index as per I915 +* @port_type: HDCP port type as per ME FW classification +* @protocol: HDCP adaptation as per ME FW +* @k: No of streams transmitted on a port. Only on DP MST this is != 1 +* @seq_num_m: Count of RepeaterAuth_Stream_Manage msg propagated. +* Initialized to 0 on AKE_INIT. Incremented after every successful +* transmission of RepeaterAuth_Stream_Manage message. When it rolls +* over re-Auth has to be triggered. +* @streams: struct hdcp2_streamid_type[k]. Defines the type and id for the +* streams +*/ +struct hdcp_port_data { +short int port; +u8 port_type; +u8 protocol; +u16 k; +u32 seq_num_m; +struct hdcp2_streamid_type *streams; +}; + +/** +* struct i915_hdcp_component_ops- ops for HDCP2.2 services. +* @owner: Module providing the ops +* @initiate_hdcp2_session: Initiate a Wired HDCP2.2 Tx Session. +* And Prepare AKE_Init. +* @verify_receiver_cert_prepare_km: Verify the Receiver Certificate +* AKE_Send_Cert and prepare +AKE_Stored_Km/AKE_No_Stored_Km +* @verify_hprime: Verify AKE_Send_H_prime +* @store_pairing_info: Store pairing info received +* @initiate_locality_check: Prepare LC_Init +* @verify_lprime: Verify lprime +* @get_session_key: Prepare SKE_Send_Eks +* @repeater_check_flow_prepare_ack: Validate the Downstream topology +* and prepare rep_ack +* @verify_mprime: Verify mprime +* @enable_hdcp_authentication: Mark a port as authenticated. +* @close_hdcp_session: Close the Wired HDCP Tx session per port. +* This also disables the authenticated state of the port. +*/ +struct i915_hdcp_component_ops { +/** +* @owner: mei_hdcp module +*/ +struct module *owner; + +int (*initiate_hdcp2_session)(struct device *dev, +struct hdcp_port_data *data, +struct hdcp2_ake_init *ake_data); +int (*verify_receiver_cert_prepare_km)(struct device *dev, +struct hdcp_port_data *data, +struct hdcp2_ake_send_cert + *rx_cert, +bool *km_stored, +struct hdcp2_ake_no_stored_km + *ek_pub_km, +size_t *msg_sz); +int (*verify_hprime)(struct device *dev, +struct hdcp_port_data *data, +struct hdcp2_ake_send_hprime *rx_hprime); +int (*store_pairing_info)(struct device *dev, +struct hdcp_port_data *data, +struct hdcp2_ake_send_pairing_info + *pairing_info); +int (*initiate_locality_check)(struct device *dev, +struct hdcp_port_data *data, +struct hdcp2_lc_init *lc_init_data); +int (*verify_lprime)(struct device *dev, +struct hdcp_port_data *data, +struct hdcp2_lc_send_lprime *rx_lprime); +int (*get_session_key)(struct device *dev, +struct hdcp_port_data *data, +struct hdcp2_ske_send_eks *ske_data); +int (*repeater_check_flow_prepare_ack)(struct device *dev, +struct hdcp_port_data *data, +struct hdcp2_rep_send_receiverid_list + *rep_topology, +struct hdcp2_rep_send_ack + *rep_send_ack); +int (*verify_mprime)(struct device *dev, +struct hdcp_port_data *data, +struct hdcp2_rep_stream_ready *stream_ready); +int (*enable_hdcp_authentication)(struct device *dev, +struct hdcp_port_data *data); +int (*close_hdcp_session)(struct device *dev, +struct hdcp_port_data *data); +}; + +/** +* struct i915_hdcp_component_master - Used for communication between i915 +* and mei_hdcp drivers for the HDCP2.2 services +* @mei_dev: device that provide the HDCP2.2 service from MEI Bus. +* @hdcp_ops: Ops implemented by mei_hdcp driver, used by i915 driver. +*/ +struct i915_hdcp_comp_master { +struct device *mei_dev; +const struct i915_hdcp_component_ops *ops; + +/* To protect the above members. */ +struct mutex mutex; +}; + +#endif /* _I915_MEI_HDCP_INTERFACE_H_ */
Signature · 6 lines
2.7.4 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH v12 4/38 drm/i915: Initialize HDCP2.2
In reply to Ramalingam CAdd the HDCP2.2 initialization to the existing HDCP1.4 stack.
v2:
mei interface handle is protected with mutex. [Chris Wilson]
v3:
Notifiers are used for the mei interface state.
v4:
Poll for mei client device state
Error msg for out of mem [Uma]
Inline req for init function removed [Uma]
v5:
Rebase as Part of reordering.
Component is used for the I915 and MEI_HDCP interface [Daniel]
v6:
HDCP2.2 uses the I915 component master to communicate with mei_hdcp
- [Daniel]
Required HDCP2.2 variables defined [Sean Paul]
v7:
intel_hdcp2.2_init returns void [Uma]
Realigning the codes.
v8:
Avoid using bool structure members.
MEI interface related changes are moved into separate patch. Commit msg is updated accordingly.
intel_hdcp_exit is defined and used from i915_unload
v9:
Movement of the hdcp_check_link is moved to new patch [Daniel] intel_hdcp2_exit is removed as mei_comp will be unbind in i915_unload.
v10:
bool is used in struct to make coding simpler. [Daniel] hdmi hdcp init is placed correctly after encoder attachment.
v11:
hdcp2_capability check is moved into hdcp.c [Tomas]
--- drivers/gpu/drm/i915/intel_drv.h | 11 +++++++++++ drivers/gpu/drm/i915/intel_hdcp.c | 28 ++++++++++++++++++++++++++-- drivers/gpu/drm/i915/intel_hdmi.c | 6 +++--- 3 files changed, 40 insertions(+), 5 deletions(-)
drivers/gpu/drm/i915/intel_drv.h +11 -0
@@ -404,6 +404,17 @@ struct intel_hdcp {u64 value;struct delayed_work check_work;struct work_struct prop_work; + +/* HDCP2.2 related definitions */ +/* Flag indicates whether this connector supports HDCP2.2 or not. */ +bool hdcp2_supported; + +/* +* Content Stream Type defined by content owner. TYPE0(0x0) content can +* flow in the link protected by HDCP2.2 or HDCP1.4, where as TYPE1(0x1) +* content can flow only through a link protected by HDCP2.2. +*/ +u8 content_type; };struct intel_connector {
drivers/gpu/drm/i915/intel_hdcp.c +26 -2
@@ -832,14 +832,34 @@ bool is_hdcp_supported(struct drm_i915_private *dev_priv, enum port port)return INTEL_GEN (dev_priv) >=9 && port <PORT_E ; } +static bool is_hdcp2_supported (struct drm_i915_private *dev_priv) +{ +if (!IS_ENABLED (CONFIG_INTEL_MEI_HDCP )) +return false; + +return (INTEL_GEN (dev_priv) >=10 ||IS_GEMINILAKE (dev_priv) || +IS_KABYLAKE (dev_priv)); +} + +static void intel_hdcp2_init (struct intel_connector *connector) +{ +struct intel_hdcp *hdcp = &connector->hdcp; + +/* TODO: MEI interface needs to be initialized here */ + hdcp->hdcp2_supported = true; +} +int intel_hdcp_init (struct intel_connector *connector,const struct intel_hdcp_shim *shim) { +struct drm_i915_private *dev_priv =to_i915 (connector->base.dev);struct intel_hdcp *hdcp = &connector->hdcp;int ret; - ret =drm_connector_attach_content_protection_property ( - &connector->base); +if (!shim) +return -EINVAL ; + + ret =drm_connector_attach_content_protection_property (&connector->base);if (ret)return ret;
@@ -847,6 +867,10 @@ int intel_hdcp_init(struct intel_connector *connector,mutex_init (&hdcp->mutex);INIT_DELAYED_WORK (&hdcp->check_work, intel_hdcp_check_work);INIT_WORK (&hdcp->prop_work, intel_hdcp_prop_work); + +if (is_hdcp2_supported (dev_priv)) +intel_hdcp2_init (connector); +return 0 ; }
drivers/gpu/drm/i915/intel_hdmi.c +3 -3
@@ -2427,6 +2427,9 @@ void intel_hdmi_init_connector(struct intel_digital_port *intel_dig_port,intel_hdmi_add_properties (intel_hdmi, connector); +intel_connector_attach_encoder (intel_connector, intel_encoder); + intel_hdmi->attached_connector = intel_connector; +if (is_hdcp_supported (dev_priv, port)) {int ret =intel_hdcp_init (intel_connector, &intel_hdmi_hdcp_shim);
@@ -2434,9 +2437,6 @@ void intel_hdmi_init_connector(struct intel_digital_port *intel_dig_port,DRM_DEBUG_KMS ("HDCP init failed, skipping.\n" ); } -intel_connector_attach_encoder (intel_connector, intel_encoder); - intel_hdmi->attached_connector = intel_connector; -/* For G4X desktop chip, PEG_BAND_GAP_DATA 3:0 must first be written * 0xd. Failure to do so will result in spurious interrupts being * generated on the port when a cable is not attached.
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v12 5/38 drm/i915: MEI interface definition
In reply to Ramalingam CDefining the mei-i915 interface functions and initialization of the interface.
v2:
Adjust to the new interface changes. [Tomas]
Added further debug logs for the failures at MEI i/f.
port in hdcp_port data is equipped to handle -ve values.
v3:
mei comp is matched for global i915 comp master. [Daniel] In hdcp_shim hdcp_protocol() is replaced with const variable. [Daniel] mei wrappers are adjusted as per the i/f change [Daniel]
v4:
port initialization is done only at hdcp2_init only [Danvet]
v5:
I915 registers a subcomponent to be matched with mei_hdcp [Daniel]
v6:
HDCP_disable for all connectors incase of comp_unbind. Tear down HDCP comp interface at i915_unload [Daniel]
v7:
Component init and fini are moved out of connector ops [Daniel] hdcp_disable is not called from unbind. [Daniel]
--- drivers/gpu/drm/i915/i915_drv.c | 1 + drivers/gpu/drm/i915/i915_drv.h | 7 + drivers/gpu/drm/i915/intel_connector.c | 2 + drivers/gpu/drm/i915/intel_display.c | 4 + drivers/gpu/drm/i915/intel_drv.h | 8 + drivers/gpu/drm/i915/intel_hdcp.c | 398 ++++++++++++++++++++++++++++++++- include/drm/i915_component.h | 3 + 7 files changed, 422 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_drv.c +1 -0
@@ -906,6 +906,7 @@ static int i915_driver_init_early(struct drm_i915_private *dev_priv)mutex_init (&dev_priv->av_mutex);mutex_init (&dev_priv->wm.wm_mutex);mutex_init (&dev_priv->pps_mutex); +mutex_init (&dev_priv->hdcp_comp_mutex);i915_memcpy_init_early (dev_priv);intel_runtime_pm_init_early (dev_priv);
drivers/gpu/drm/i915/i915_drv.h +7 -0
@@ -55,6 +55,7 @@#include <drm/drm_util.h> #include <drm/drm_dsc.h> #include <drm/drm_connector.h> +#include <drm/i915_mei_hdcp_interface.h> #include "i915_fixed.h" #include "i915_params.h"
@@ -2055,6 +2056,12 @@ struct drm_i915_private {struct i915_pmu pmu; +struct i915_hdcp_comp_master *hdcp_master; +bool hdcp_comp_added; + +/* Mutex to protect the above hdcp component related values. */ +struct mutex hdcp_comp_mutex; +/* * NOTE: This is the dri1/ums dungeon, don't add stuff here. Your patch * will be rejected. Instead look for a better place.
drivers/gpu/drm/i915/intel_connector.c +2 -0
@@ -88,6 +88,8 @@ void intel_connector_destroy(struct drm_connector *connector)kfree (intel_connector->detect_edid); +intel_hdcp_cleanup (intel_connector); +if (!IS_ERR_OR_NULL (intel_connector->edid))kfree (intel_connector->edid);
drivers/gpu/drm/i915/intel_display.c +4 -0
@@ -15459,6 +15459,8 @@ int intel_modeset_init(struct drm_device *dev)intel_update_czclk (dev_priv);intel_modeset_init_hw (dev); +intel_hdcp_component_init (dev_priv); +if (dev_priv->max_cdclk_freq ==0 )intel_update_max_cdclk (dev_priv);
@@ -16320,6 +16322,8 @@ void intel_modeset_cleanup(struct drm_device *dev)/* flush any delayed tasks or pending work */ flush_scheduled_work (); +intel_hdcp_component_fini (dev_priv); +drm_mode_config_cleanup (dev);intel_overlay_cleanup (dev_priv);
drivers/gpu/drm/i915/intel_drv.h +8 -0
@@ -41,6 +41,7 @@#include <drm/drm_rect.h> #include <drm/drm_vblank.h> #include <drm/drm_atomic.h> +#include <drm/i915_mei_hdcp_interface.h> #include <media/cec-notifier.h> struct drm_printer ;
@@ -395,6 +396,9 @@ struct intel_hdcp_shim {/* Detects panel's hdcp capability. This is optional for HDMI. */ int (*hdcp_capable)(struct intel_digital_port *intel_dig_port,bool *hdcp_capable); + +/* HDCP adaptation(DP/HDMI) required on the port */ +enum hdcp_wired_protocol protocol; };struct intel_hdcp {
@@ -415,6 +419,7 @@ struct intel_hdcp {* content can flow only through a link protected by HDCP2.2. */ u8 content_type; +struct hdcp_port_data port_data; };struct intel_connector {
@@ -2088,6 +2093,9 @@ int intel_hdcp_disable(struct intel_connector *connector);int intel_hdcp_check_link (struct intel_connector *connector);bool is_hdcp_supported (struct drm_i915_private *dev_priv,enum port port);bool intel_hdcp_capable (struct intel_connector *connector); +void intel_hdcp_component_init (struct drm_i915_private *dev_priv); +void intel_hdcp_component_fini (struct drm_i915_private *dev_priv); +void intel_hdcp_cleanup (struct intel_connector *connector);/* intel_psr.c */ #define CAN_PSR (dev_priv) (HAS_PSR(dev_priv) && dev_priv->psr.sink_support)
drivers/gpu/drm/i915/intel_hdcp.c +397 -1
428 lines not on this page · raw message
include/drm/i915_component.h +3 -0
@@ -24,10 +24,13 @@#ifndef _I915_COMPONENT_H_#define _I915_COMPONENT_H_ +#include <linux/device.h> +#include "drm_audio_component.h" enum i915_component_type {I915_COMPONENT_AUDIO =1 , +I915_COMPONENT_HDCP , };/* MAX_PORT is the number of port
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v12 6/38 drm/i915: hdcp1.4 CP_IRQ handling and SW encryption tracking
In reply to Ramalingam C"hdcp_encrypted" flag is defined to denote the HDCP1.4 encryption status. This SW tracking is used to determine the need for real hdcp1.4 disable and hdcp_check_link upon CP_IRQ.
On CP_IRQ we filter the CP_IRQ related to the states like Link failure and reauthentication req etc and handle them in hdcp_check_link. CP_IRQ corresponding to the authentication msg availability are ignored.
WARN_ON is added for the abrupt stop of HDCP encryption of a port.
v2:
bool is used in struct for the cleaner coding. [Daniel] check_link work_fn is scheduled for cp_irq handling [Daniel]
v3:
rebased.
--- drivers/gpu/drm/i915/intel_dp.c | 2 +- drivers/gpu/drm/i915/intel_drv.h | 5 ++- drivers/gpu/drm/i915/intel_hdcp.c | 73 ++++++++++++++++++++++++++++----------- 3 files changed, 58 insertions(+), 22 deletions(-)
drivers/gpu/drm/i915/intel_dp.c +1 -1
@@ -4780,7 +4780,7 @@ static void intel_dp_check_service_irq(struct intel_dp *intel_dp)intel_dp_handle_test_request (intel_dp);if (val &DP_CP_IRQ ) -intel_hdcp_check_link (intel_dp->attached_connector); +intel_hdcp_handle_cp_irq (intel_dp->attached_connector);if (val &DP_SINK_SPECIFIC_IRQ )DRM_DEBUG_DRIVER ("Sink specific irq unhandled\n" );
drivers/gpu/drm/i915/intel_drv.h +4 -1
@@ -409,6 +409,9 @@ struct intel_hdcp {struct delayed_work check_work;struct work_struct prop_work; +/* HDCP1.4 Encryption status */ +bool hdcp_encrypted; +/* HDCP2.2 related definitions */ /* Flag indicates whether this connector supports HDCP2.2 or not. */ bool hdcp2_supported;
@@ -2090,12 +2093,12 @@ int intel_hdcp_init(struct intel_connector *connector, const struct intel_hdcp_shim *hdcp_shim);int intel_hdcp_enable (struct intel_connector *connector);int intel_hdcp_disable (struct intel_connector *connector); -int intel_hdcp_check_link (struct intel_connector *connector);bool is_hdcp_supported (struct drm_i915_private *dev_priv,enum port port);bool intel_hdcp_capable (struct intel_connector *connector);void intel_hdcp_component_init (struct drm_i915_private *dev_priv);void intel_hdcp_component_fini (struct drm_i915_private *dev_priv);void intel_hdcp_cleanup (struct intel_connector *connector); +void intel_hdcp_handle_cp_irq (struct intel_connector *connector);/* intel_psr.c */ #define CAN_PSR (dev_priv) (HAS_PSR(dev_priv) && dev_priv->psr.sink_support)
drivers/gpu/drm/i915/intel_hdcp.c +53 -20
123 lines not on this page · raw message
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v12 7/38 drm/i915: Enable and Disable of HDCP2.2
In reply to Ramalingam CConsidering that HDCP2.2 is more secure than HDCP1.4, When a setup supports HDCP2.2 and HDCP1.4, HDCP2.2 will be enabled.
When HDCP2.2 enabling fails and HDCP1.4 is supported, HDCP1.4 is enabled.
This change implements a sequence of enabling and disabling of HDCP2.2 authentication and HDCP2.2 port encryption.
v2:
Included few optimization suggestions [Chris Wilson] Commit message is updated as per the rebased version. intel_wait_for_register is used instead of wait_for. [Chris Wilson]
v3:
Extra comment added and Style issue fixed [Uma]
v4:
Rebased as part of patch reordering.
HDCP2 encryption status is tracked.
HW state check is moved into WARN_ON [Daniel]
v5:
Redefined the mei service functions as per comp redesign. Merged patches related to hdcp2.2 enabling and disabling [Sean Paul]. Required shim functionality is defined [Sean Paul]
v6:
Return values are handles [Uma]
Realigned the code.
Check for comp_master is removed.
v7:
HDCP2.2 is attempted only if mei interface is up.
Adjust to the new interface
Avoid bool usage in struct [Tomas]
v8:
mei_binded status check is removed. %s/hdcp2_in_use/hdcp2_encrypted
v9:
bool is used in struct intel_hdcp. [Daniel]
v10:
panel is replaced with sink [Uma]
Mei interface decided the hdcp2_capability.
WARN_ON if hdcp_enable is called when hdcp state is ENABLED. Reviewed-by Uma.
--- drivers/gpu/drm/i915/intel_drv.h | 7 ++ drivers/gpu/drm/i915/intel_hdcp.c | 212 +++++++++++++++++++++++++++++++++++--- 2 files changed, 205 insertions(+), 14 deletions(-)
drivers/gpu/drm/i915/intel_drv.h +7 -0
@@ -399,6 +399,10 @@ struct intel_hdcp_shim {/* HDCP adaptation(DP/HDMI) required on the port */ enum hdcp_wired_protocol protocol; + +/* Detects whether sink is HDCP2.2 capable */ +int (*hdcp_2_2_capable)(struct intel_digital_port *intel_dig_port, +bool *capable); };struct intel_hdcp {
@@ -416,6 +420,9 @@ struct intel_hdcp {/* Flag indicates whether this connector supports HDCP2.2 or not. */ bool hdcp2_supported; +/* HDCP2.2 Encryption status */ +bool hdcp2_encrypted; +/* * Content Stream Type defined by content owner. TYPE0(0x0) content can * flow in the link protected by HDCP2.2 or HDCP1.4, where as TYPE1(0x1)
drivers/gpu/drm/i915/intel_hdcp.c +198 -14
253 lines not on this page · raw message
Signature · 6 lines
2.7.4 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH v12 8/38 drm/i915: Implement HDCP2.2 receiver authentication
In reply to Ramalingam CImplements HDCP2.2 authentication for hdcp2.2 receivers, with following steps:
Authentication and Key exchange (AKE). Locality Check (LC).
Session Key Exchange(SKE).
DP Errata for stream type configuration for receivers.
At AKE, the HDCP Receiver’s public key certificate is verified by the HDCP Transmitter. A Master Key k m is exchanged.
At LC, the HDCP Transmitter enforces locality on the content by requiring that the Round Trip Time (RTT) between a pair of messages is not more than 20 ms.
At SKE, The HDCP Transmitter exchanges Session Key ks with the HDCP Receiver.
In DP HDCP2.2 encryption and decryption logics use the stream type as one of the parameter. So Before enabling the Encryption DP HDCP2.2 receiver needs to be communicated with stream type. This is added to spec as ERRATA.
This generic implementation is complete only with the hdcp2 specific functions defined at hdcp_shim.
v2: Rebased.
v3:
%s/PARING/PAIRING
Coding style fixing [Uma]
v4:
Rebased as part of patch reordering.
Defined the functions for mei services. [Daniel]
v5:
Redefined the mei service functions as per comp redesign. Required intel_hdcp members are defined [Sean Paul]
v6:
Typo of cipher is Fixed [Uma]
%s/uintxx_t/uxx
Check for comp_master is removed.
v7:
Adjust to the new interface.
Avoid using bool structure members. [Tomas]
v8: Rebased.
v9:
bool is used in struct intel_hdcp [Daniel] config_stream_type is redesigned [Daniel] Reviewed-by Uma.
--- drivers/gpu/drm/i915/intel_drv.h | 34 +++++++ drivers/gpu/drm/i915/intel_hdcp.c | 197 +++++++++++++++++++++++++++++++++++--- 2 files changed, 216 insertions(+), 15 deletions(-)
drivers/gpu/drm/i915/intel_drv.h +34 -0
@@ -403,6 +403,22 @@ struct intel_hdcp_shim {/* Detects whether sink is HDCP2.2 capable */ int (*hdcp_2_2_capable)(struct intel_digital_port *intel_dig_port,bool *capable); + +/* Write HDCP2.2 messages */ +int (*write_2_2_msg)(struct intel_digital_port *intel_dig_port, +void *buf,size_t size); + +/* Read HDCP2.2 messages */ +int (*read_2_2_msg)(struct intel_digital_port *intel_dig_port, +u8 msg_id,void *buf,size_t size); + +/* +* Implementation of DP HDCP2.2 Errata for the communication of stream +* type to Receivers. In DP HDCP2.2 Stream type is one of the input to +* the HDCP2.2 Cipher for En/De-Cryption. Not applicable for HDMI. +*/ +int (*config_stream_type)(struct intel_digital_port *intel_dig_port, +bool is_repeater,u8 type); };struct intel_hdcp {
@@ -430,6 +446,24 @@ struct intel_hdcp {*/ u8 content_type;struct hdcp_port_data port_data; + +bool is_paired; +bool is_repeater; + +/* +* Count of ReceiverID_List received. Initialized to 0 at AKE_INIT. +* Incremented after processing the RepeaterAuth_Send_ReceiverID_List. +* When it rolls over re-auth has to be triggered. +*/ +u32 seq_num_v; + +/* +* Count of RepeaterAuth_Stream_Manage msg propagated. +* Initialized to 0 on AKE_INIT. Incremented after every successful +* transmission of RepeaterAuth_Stream_Manage message. When it rolls +* over re-Auth has to be triggered. +*/ +u32 seq_num_m; };struct intel_connector {
drivers/gpu/drm/i915/intel_hdcp.c +182 -15
260 lines not on this page · raw message
Signature · 6 lines
2.7.4 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH v12 9/38 drm: helper functions for hdcp2 seq_num to from u32
In reply to Ramalingam CLibrary functions for endianness are aligned for 16/32/64 bits. But hdcp sequence numbers are 24bits(big endian).
So for their conversion to and from u32 helper functions are developed.
v2:
Comment is updated. [Daniel]
Reviewed-by Uma.
--- include/drm/drm_hdcp.h | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+)
include/drm/drm_hdcp.h +18 -0
@@ -252,4 +252,22 @@ struct hdcp2_dp_errata_stream_type {#define HDCP_2_2_HDMI_RXSTATUS_READY (x) ((x) & BIT(2))#define HDCP_2_2_HDMI_RXSTATUS_REAUTH_REQ (x) ((x) & BIT(3)) +/* +* Helper functions to convert 24bit big endian hdcp sequence number to +* host format and back +*/ +static inline +u32 drm_hdcp2_seq_num_to_u32 (u8 seq_num[HDCP_2_2_SEQ_NUM_LEN ]) +{ +return (u32)(seq_num[2 ] | seq_num[1 ] <<8 | seq_num[0 ] <<16 ); +} + +static inline +void drm_hdcp2_u32_to_seq_num (u8 seq_num[HDCP_2_2_SEQ_NUM_LEN ],u32 val) +{ + seq_num[0 ] = val >>16 ; + seq_num[1 ] = val >>8 ; + seq_num[2 ] = val; +} +#endif
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v12 10/38 drm/i915: Implement HDCP2.2 repeater authentication
In reply to Ramalingam CImplements the HDCP2.2 repeaters authentication steps such as verifying the downstream topology and sending stream management information.
v2: Rebased.
v3:
-EINVAL is returned for topology error and rollover scenario. Endianness conversion func from drm_hdcp.h is used [Uma]
v4:
Rebased as part of patches reordering.
Defined the mei service functions [Daniel]
v5:
Redefined the mei service functions as per comp redesign.
v6:
%s/uintxx_t/uxx
Check for comp_master is removed.
v7:
Adjust to the new mei interface.
style issue fixed.
v8:
drm_hdcp.h change is moved into separate patch [Daniel]
v9:
%s/__swab16/cpu_to_be16. [Tomas]
Reviewed-by Uma.
--- drivers/gpu/drm/i915/intel_hdcp.c | 125 +++++++++++++++++++++++++++++++++++++- 1 file changed, 123 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/intel_hdcp.c +123 -2
@@ -1041,7 +1041,7 @@ static int hdcp2_prepare_skey(struct intel_connector *connector,return ret; } -static __attribute__((unused)) int +static int hdcp2_verify_rep_topology_prepare_ack(struct intel_connector *connector, struct hdcp2_rep_send_receiverid_list *rep_topology,
@@ -1070,7 +1070,7 @@ hdcp2_verify_rep_topology_prepare_ack(struct intel_connector *connector,return ret; } -static __attribute__((unused))int +static int hdcp2_verify_mprime (struct intel_connector *connector,struct hdcp2_rep_stream_ready *stream_ready) {
@@ -1279,6 +1279,119 @@ static int hdcp2_session_key_exchange(struct intel_connector *connector)return 0 ; } +static +int hdcp2_propagate_stream_management_info (struct intel_connector *connector) +{ +struct intel_digital_port *intel_dig_port =conn_to_dig_port (connector); +struct intel_hdcp *hdcp = &connector->hdcp; +union { +struct hdcp2_rep_stream_manage stream_manage; +struct hdcp2_rep_stream_ready stream_ready; + } msgs; +const struct intel_hdcp_shim *shim = hdcp->shim; +int ret; + +/* Prepare RepeaterAuth_Stream_Manage msg */ + msgs.stream_manage.msg_id =HDCP_2_2_REP_STREAM_MANAGE ; +drm_hdcp2_u32_to_seq_num (msgs.stream_manage.seq_num_m, hdcp->seq_num_m); + +/* K no of streams is fixed as 1. Stored as big-endian. */ + msgs.stream_manage.k =cpu_to_be16 (1 ); + +/* For HDMI this is forced to be 0x0. For DP SST also this is 0x0. */ + msgs.stream_manage.streams[0 ].stream_id =0 ; + msgs.stream_manage.streams[0 ].stream_type = hdcp->content_type; + +/* Send it to Repeater */ + ret = shim->write_2_2_msg (intel_dig_port, &msgs.stream_manage, +sizeof (msgs.stream_manage)); +if (ret <0 ) +return ret; + + ret = shim->read_2_2_msg (intel_dig_port,HDCP_2_2_REP_STREAM_READY , + &msgs.stream_ready,sizeof (msgs.stream_ready)); +if (ret <0 ) +return ret; + + hdcp->port_data.seq_num_m = hdcp->seq_num_m; + hdcp->port_data.streams[0 ].stream_type = hdcp->content_type; + + ret =hdcp2_verify_mprime (connector, &msgs.stream_ready); +if (ret <0 ) +return ret; + + hdcp->seq_num_m++; + +if (hdcp->seq_num_m >HDCP_2_2_SEQ_NUM_MAX ) { +DRM_DEBUG_KMS ("seq_num_m roll over.\n" ); +return -1 ; + } + +return 0 ; +} + +static +int hdcp2_authenticate_repeater_topology (struct intel_connector *connector) +{ +struct intel_digital_port *intel_dig_port =conn_to_dig_port (connector); +struct intel_hdcp *hdcp = &connector->hdcp; +union { +struct hdcp2_rep_send_receiverid_list recvid_list; +struct hdcp2_rep_send_ack rep_ack; + } msgs; +const struct intel_hdcp_shim *shim = hdcp->shim; +u8 *rx_info; +u32 seq_num_v; +int ret; + + ret = shim->read_2_2_msg (intel_dig_port,HDCP_2_2_REP_SEND_RECVID_LIST , + &msgs.recvid_list,sizeof (msgs.recvid_list)); +if (ret <0 ) +return ret; + + rx_info = msgs.recvid_list.rx_info; + +if (HDCP_2_2_MAX_CASCADE_EXCEEDED (rx_info[1 ]) || +HDCP_2_2_MAX_DEVS_EXCEEDED (rx_info[1 ])) { +DRM_DEBUG_KMS ("Topology Max Size Exceeded\n" ); +return -EINVAL ; + } + +/* Converting and Storing the seq_num_v to local variable as DWORD */ + seq_num_v =drm_hdcp2_seq_num_to_u32 (msgs.recvid_list.seq_num_v); + +if (seq_num_v < hdcp->seq_num_v) { +/* Roll over of the seq_num_v from repeater. Reauthenticate. */ +DRM_DEBUG_KMS ("Seq_num_v roll over.\n" ); +return -EINVAL ; + } + + ret =hdcp2_verify_rep_topology_prepare_ack (connector, + &msgs.recvid_list, + &msgs.rep_ack); +if (ret <0 ) +return ret; + + hdcp->seq_num_v = seq_num_v; + ret = shim->write_2_2_msg (intel_dig_port, &msgs.rep_ack, +sizeof (msgs.rep_ack)); +if (ret <0 ) +return ret; + +return 0 ; +} + +static int hdcp2_authenticate_repeater (struct intel_connector *connector) +{ +int ret; + + ret =hdcp2_authenticate_repeater_topology (connector); +if (ret <0 ) +return ret; + +return hdcp2_propagate_stream_management_info (connector); +} +static int hdcp2_authenticate_sink (struct intel_connector *connector) {struct intel_digital_port *intel_dig_port =conn_to_dig_port (connector);
@@ -1312,6 +1425,14 @@ static int hdcp2_authenticate_sink(struct intel_connector *connector)return ret; } +if (hdcp->is_repeater) { + ret =hdcp2_authenticate_repeater (connector); +if (ret <0 ) { +DRM_DEBUG_KMS ("Repeater Auth Failed. Err: %d\n" , ret); +return ret; + } + } + hdcp->port_data.streams[0 ].stream_type = hdcp->content_type; ret =hdcp2_authenticate_port (connector);if (ret <0 )
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v12 11/38 drm: HDCP2.2 link check period
In reply to Ramalingam CTime period for HDCP2.2 link check.
--- include/drm/drm_hdcp.h | 1 + 1 file changed, 1 insertion(+)
include/drm/drm_hdcp.h +1 -0
@@ -13,6 +13,7 @@/* Period of hdcp checks (to ensure we're still authenticated) */ #define DRM_HDCP_CHECK_PERIOD_MS (128 * 16) +#define DRM_HDCP2_CHECK_PERIOD_MS 500/* Shared lengths/masks between HDMI/DVI/DisplayPort */ #define DRM_HDCP_AN_LEN 8
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v12 12/38 drm/i915: Implement HDCP2.2 link integrity check
In reply to Ramalingam CImplements the link integrity check once in 500mSec.
Once encryption is enabled, an ongoing Link Integrity Check is performed by the HDCP Receiver to check that cipher synchronization is maintained between the HDCP Transmitter and the HDCP Receiver.
On the detection of synchronization lost, the HDCP Receiver must assert the corresponding bits of the RxStatus register. The Transmitter polls the RxStatus register and it may initiate re-authentication.
v2:
Rebased.
v3:
enum check_link_response is used check the link status [Uma]
v4:
Rebased as part of patch reordering.
v5:
Required members of intel_hdcp is defined [Sean Paul]
v6:
hdcp2_check_link is cancelled at required places.
v7:
Rebased for the component i/f changes.
Errors due to the sinks are reported as DEBUG logs.
v8:
hdcp_check_work is used for both hdcp1 and hdcp2 check_link [Daniel] hdcp2.2 encryption status check is put under WARN_ON [Daniel] drm_hdcp.h changes are moved into separate patch [Daniel]
v9:
enum check_link_status is defined at intel_drv.h [Daniel]
--- drivers/gpu/drm/i915/intel_drv.h | 10 +++++ drivers/gpu/drm/i915/intel_hdcp.c | 88 ++++++++++++++++++++++++++++++++++++--- 2 files changed, 93 insertions(+), 5 deletions(-)
drivers/gpu/drm/i915/intel_drv.h +10 -0
@@ -324,6 +324,13 @@ struct intel_panel {struct intel_digital_port ; +enum check_link_response { +HDCP_LINK_PROTECTED =0 , +HDCP_TOPOLOGY_CHANGE , +HDCP_LINK_INTEGRITY_FAILURE , +HDCP_REAUTH_REQUEST +}; +/* * This structure serves as a translation layer between the generic HDCP code * and the bus-specific code. What that means is that HDCP over HDMI differs
@@ -419,6 +426,9 @@ struct intel_hdcp_shim {*/ int (*config_stream_type)(struct intel_digital_port *intel_dig_port,bool is_repeater,u8 type); + +/* HDCP2.2 Link Integrity Check */ +int (*check_2_2_link)(struct intel_digital_port *intel_dig_port); };struct intel_hdcp {
drivers/gpu/drm/i915/intel_hdcp.c +83 -5
126 lines not on this page · raw message
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v12 13/38 drm/i915: Handle HDCP2.2 downstream topology change
In reply to Ramalingam CWhen repeater notifies a downstream topology change, this patch reauthenticate the repeater alone without disabling the hdcp encryption. If that fails then complete reauthentication is executed.
v2:
Rebased.
v3:
Typo in commit msg is fixed [Uma]
v4:
Rebased as part of patch reordering.
Minor style fixes.
v5:
Rebased.
v6:
Rebased.
v7:
Errors due to sinks are reported as DEBUG logs.
--- drivers/gpu/drm/i915/intel_hdcp.c | 20 ++++++++++++++++++-- 1 file changed, 18 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/intel_hdcp.c +18 -2
@@ -1626,8 +1626,24 @@ static int intel_hdcp2_check_link(struct intel_connector *connector) goto out; } -DRM_DEBUG_KMS ("[%s:%d] HDCP2.2 link failed, retrying auth\n" , - connector->base.name, connector->base.base.id); +if (ret ==HDCP_TOPOLOGY_CHANGE ) { +if (hdcp->value ==DRM_MODE_CONTENT_PROTECTION_UNDESIRED ) + goto out; + +DRM_DEBUG_KMS ("HDCP2.2 Downstream topology change\n" ); + ret =hdcp2_authenticate_repeater_topology (connector); +if (!ret) { + hdcp->value =DRM_MODE_CONTENT_PROTECTION_ENABLED ; +schedule_work (&hdcp->prop_work); + goto out; + } +DRM_DEBUG_KMS ("[%s:%d] Repeater topology auth failed.(%d)\n" , + connector->base.name, connector->base.base.id, + ret); + }else { +DRM_DEBUG_KMS ("[%s:%d] HDCP2.2 link failed, retrying auth\n" , + connector->base.name, connector->base.base.id); + } ret =_intel_hdcp2_disable (connector);if (ret) {
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v12 14/38 drm: removing the DP Errata msg and its msg id
In reply to Ramalingam CSince DP ERRATA message is not defined at spec, those structure definition is removed from drm_hdcp.h
--- include/drm/drm_hdcp.h | 6 ------ 1 file changed, 6 deletions(-)
include/drm/drm_hdcp.h +0 -6
@@ -69,7 +69,6 @@#define HDCP_2_2_REP_SEND_ACK 15#define HDCP_2_2_REP_STREAM_MANAGE 16#define HDCP_2_2_REP_STREAM_READY 17 -#define HDCP_2_2_ERRATA_DP_STREAM_TYPE 50#define HDCP_2_2_RTX_LEN 8#define HDCP_2_2_RRX_LEN 8
@@ -220,11 +219,6 @@ struct hdcp2_rep_stream_ready {u8 m_prime[HDCP_2_2_MPRIME_LEN ]; } __packed; -struct hdcp2_dp_errata_stream_type { -u8 msg_id; -u8 stream_type; -} __packed; -/* HDCP2.2 TIMEOUTs in mSec */ #define HDCP_2_2_CERT_TIMEOUT_MS 100#define HDCP_2_2_HPRIME_NO_PAIRED_TIMEOUT_MS 1000
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v12 15/38 drm/i915: Implement the HDCP2.2 support for DP
In reply to Ramalingam CImplements the DP adaptation specific HDCP2.2 functions.
These functions perform the DPCD read and write for communicating the HDCP2.2 auth message back and forth.
v2:
wait for cp_irq is merged with this patch. Rebased.
v3:
wait_queue is used for wait for cp_irq [Chris Wilson]
v4:
Style fixed.
%s/PARING/PAIRING
Few style fixes [Uma]
v5:
Lookup table for DP HDCP2.2 msg details [Daniel]. Extra lines are removed.
v6: Rebased.
v7:
Fixed some regression introduced at v5. [Ankit] Macro HDCP_2_2_RX_CAPS_VERSION_VAL is reused [Uma] Converted a function to inline [Uma]
%s/uintxx_t/uxx
v8:
Error due to the sinks are reported as DEBUG logs. Adjust to the new mei interface.
v9:
ARRAY_SIZE for no of array members [Jon & Daniel] return of the wait_for_cp_irq is made as void [Daniel] Wait for HDCP2.2 msg is done based on polling the reg bit than
CP_IRQ based. [Daniel]
hdcp adaptation is added as a const in the hdcp_shim [Daniel]
v10:
config_stream_type is redefined [Daniel]
DP Errata specific defines are moved into intel_dp.c.
--- drivers/gpu/drm/i915/intel_dp.c | 333 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 333 insertions(+)
drivers/gpu/drm/i915/intel_dp.c +333 -0
@@ -5847,6 +5847,333 @@ int intel_dp_hdcp_capable(struct intel_digital_port *intel_dig_port,return 0 ; } +struct hdcp2_dp_errata_stream_type { +u8 msg_id; +u8 stream_type; +} __packed; + +static struct hdcp2_dp_msg_data { +u8 msg_id; +u32 offset; +bool msg_detectable; +u32 timeout; +u32 timeout2;/* Added for non_paired situation */ + } hdcp2_msg_data[] = { + {HDCP_2_2_AKE_INIT ,DP_HDCP_2_2_AKE_INIT_OFFSET , false,0 ,0 }, + {HDCP_2_2_AKE_SEND_CERT ,DP_HDCP_2_2_AKE_SEND_CERT_OFFSET , + false,HDCP_2_2_CERT_TIMEOUT_MS ,0 }, + {HDCP_2_2_AKE_NO_STORED_KM ,DP_HDCP_2_2_AKE_NO_STORED_KM_OFFSET , + false,0 ,0 }, + {HDCP_2_2_AKE_STORED_KM ,DP_HDCP_2_2_AKE_STORED_KM_OFFSET , + false,0 ,0 }, + {HDCP_2_2_AKE_SEND_HPRIME ,DP_HDCP_2_2_AKE_SEND_HPRIME_OFFSET , + true,HDCP_2_2_HPRIME_PAIRED_TIMEOUT_MS , +HDCP_2_2_HPRIME_NO_PAIRED_TIMEOUT_MS }, + {HDCP_2_2_AKE_SEND_PAIRING_INFO , +DP_HDCP_2_2_AKE_SEND_PAIRING_INFO_OFFSET , true, +HDCP_2_2_PAIRING_TIMEOUT_MS ,0 }, + {HDCP_2_2_LC_INIT ,DP_HDCP_2_2_LC_INIT_OFFSET , false,0 ,0 }, + {HDCP_2_2_LC_SEND_LPRIME ,DP_HDCP_2_2_LC_SEND_LPRIME_OFFSET , + false,HDCP_2_2_DP_LPRIME_TIMEOUT_MS ,0 }, + {HDCP_2_2_SKE_SEND_EKS ,DP_HDCP_2_2_SKE_SEND_EKS_OFFSET , false, +0 ,0 }, + {HDCP_2_2_REP_SEND_RECVID_LIST , +DP_HDCP_2_2_REP_SEND_RECVID_LIST_OFFSET , true, +HDCP_2_2_RECVID_LIST_TIMEOUT_MS ,0 }, + {HDCP_2_2_REP_SEND_ACK ,DP_HDCP_2_2_REP_SEND_ACK_OFFSET , false, +0 ,0 }, + {HDCP_2_2_REP_STREAM_MANAGE , +DP_HDCP_2_2_REP_STREAM_MANAGE_OFFSET , false, +0 ,0 }, + {HDCP_2_2_REP_STREAM_READY ,DP_HDCP_2_2_REP_STREAM_READY_OFFSET , + false,HDCP_2_2_STREAM_READY_TIMEOUT_MS ,0 }, +/* local define to shovel this through the write_2_2 interface */ +#define HDCP_2_2_ERRATA_DP_STREAM_TYPE 50 + {HDCP_2_2_ERRATA_DP_STREAM_TYPE , +DP_HDCP_2_2_REG_STREAM_TYPE_OFFSET , false, +0 ,0 }, + }; + +static inline +int intel_dp_hdcp2_read_rx_status (struct intel_digital_port *intel_dig_port, +u8 *rx_status) +{ +ssize_t ret; + + ret =drm_dp_dpcd_read (&intel_dig_port->dp.aux, +DP_HDCP_2_2_REG_RXSTATUS_OFFSET , rx_status, +HDCP_2_2_DP_RXSTATUS_LEN ); +if (ret !=HDCP_2_2_DP_RXSTATUS_LEN ) { +DRM_DEBUG_KMS ("Read bstatus from DP/AUX failed (%zd)\n" , ret); +return ret >=0 ? -EIO : ret; + } + +return 0 ; +} + +static +int hdcp2_detect_msg_availability (struct intel_digital_port *intel_dig_port, +u8 msg_id,bool *msg_ready) +{ +u8 rx_status; +int ret; + + *msg_ready = false; + ret =intel_dp_hdcp2_read_rx_status (intel_dig_port, &rx_status); +if (ret <0 ) +return ret; + +switch (msg_id) { +case HDCP_2_2_AKE_SEND_HPRIME : +if (HDCP_2_2_DP_RXSTATUS_H_PRIME (rx_status)) + *msg_ready = true; +break ; +case HDCP_2_2_AKE_SEND_PAIRING_INFO : +if (HDCP_2_2_DP_RXSTATUS_PAIRING (rx_status)) + *msg_ready = true; +break ; +case HDCP_2_2_REP_SEND_RECVID_LIST : +if (HDCP_2_2_DP_RXSTATUS_READY (rx_status)) + *msg_ready = true; +break ; +default : +DRM_ERROR ("Unidentified msg_id: %d\n" , msg_id); +return -EINVAL ; + } + +return 0 ; +} + +static ssize_t +intel_dp_hdcp2_wait_for_msg (struct intel_digital_port *intel_dig_port, +struct hdcp2_dp_msg_data *hdcp2_msg_data) +{ +struct intel_dp *dp = &intel_dig_port->dp; +struct intel_hdcp *hdcp = &dp->attached_connector->hdcp; +u8 msg_id = hdcp2_msg_data->msg_id; +int ret, timeout; +bool msg_ready = false; + +if (msg_id ==HDCP_2_2_AKE_SEND_HPRIME && !hdcp->is_paired) + timeout = hdcp2_msg_data->timeout2; +else + timeout = hdcp2_msg_data->timeout; + +/* +* There is no way to detect the CERT, LPRIME and STREAM_READY +* availability. So Wait for timeout and read the msg. +*/ +if (!hdcp2_msg_data->msg_detectable) { +mdelay (timeout); + ret =0 ; + }else { +/* TODO: In case if you need to wait on CP_IRQ, do it here */ + ret =__wait_for (ret = +hdcp2_detect_msg_availability (intel_dig_port, + msg_id, + &msg_ready), + !ret && msg_ready, timeout *1000 , +1000 ,5 *1000 ); + +if (!msg_ready) + ret = -ETIMEDOUT ; + } + +if (ret) +DRM_DEBUG_KMS ("msg_id %d, ret %d, timeout(mSec): %d\n" , + hdcp2_msg_data->msg_id, ret, timeout); + +return ret; +} + +static struct hdcp2_dp_msg_data *get_hdcp2_dp_msg_data (u8 msg_id) +{ +int i; + +for (i =0 ; i <ARRAY_SIZE (hdcp2_msg_data); i++) +if (hdcp2_msg_data[i].msg_id == msg_id) +return &hdcp2_msg_data[i]; + +return NULL ; +} + +static +int intel_dp_hdcp2_write_msg (struct intel_digital_port *intel_dig_port, +void *buf,size_t size) +{ +unsigned int offset; +u8 *byte = buf; +ssize_t ret, bytes_to_write, len; +struct hdcp2_dp_msg_data *hdcp2_msg_data; + + hdcp2_msg_data =get_hdcp2_dp_msg_data (*byte); +if (!hdcp2_msg_data) +return -EINVAL ; + + offset = hdcp2_msg_data->offset; + +/* No msg_id in DP HDCP2.2 msgs */ + bytes_to_write = size -1 ; + byte++; + +while (bytes_to_write) { + len = bytes_to_write >DP_AUX_MAX_PAYLOAD_BYTES ? +DP_AUX_MAX_PAYLOAD_BYTES : bytes_to_write; + + ret =drm_dp_dpcd_write (&intel_dig_port->dp.aux, + offset, (void *)byte, len); +if (ret <0 ) +return ret; + + bytes_to_write -= ret; + byte += ret; + offset += ret; + } + +return size; +} + +static +ssize_t get_receiver_id_list_size (struct intel_digital_port *intel_dig_port) +{ +u8 rx_info[HDCP_2_2_RXINFO_LEN ]; +u32 dev_cnt; +ssize_t ret; + + ret =drm_dp_dpcd_read (&intel_dig_port->dp.aux, +DP_HDCP_2_2_REG_RXINFO_OFFSET , + (void *)rx_info,HDCP_2_2_RXINFO_LEN ); +if (ret !=HDCP_2_2_RXINFO_LEN ) +return ret >=0 ? -EIO : ret; + + dev_cnt = (HDCP_2_2_DEV_COUNT_HI (rx_info[0 ]) <<4 | +HDCP_2_2_DEV_COUNT_LO (rx_info[1 ])); + +if (dev_cnt >HDCP_2_2_MAX_DEVICE_COUNT ) + dev_cnt =HDCP_2_2_MAX_DEVICE_COUNT ; + + ret =sizeof (struct hdcp2_rep_send_receiverid_list ) - +HDCP_2_2_RECEIVER_IDS_MAX_LEN + + (dev_cnt *HDCP_2_2_RECEIVER_ID_LEN ); + +return ret; +} + +static +int intel_dp_hdcp2_read_msg (struct intel_digital_port *intel_dig_port, +u8 msg_id,void *buf,size_t size) +{ +unsigned int offset; +u8 *byte = buf; +ssize_t ret, bytes_to_recv, len; +struct hdcp2_dp_msg_data *hdcp2_msg_data; + + hdcp2_msg_data =get_hdcp2_dp_msg_data (msg_id); +if (!hdcp2_msg_data) +return -EINVAL ; + offset = hdcp2_msg_data->offset; + + ret =intel_dp_hdcp2_wait_for_msg (intel_dig_port, hdcp2_msg_data); +if (ret <0 ) +return ret; + +if (msg_id ==HDCP_2_2_REP_SEND_RECVID_LIST ) { + ret =get_receiver_id_list_size (intel_dig_port); +if (ret <0 ) +return ret; + + size = ret; + } + bytes_to_recv = size -1 ; + +/* DP adaptation msgs has no msg_id */ + byte++; + +while (bytes_to_recv) { + len = bytes_to_recv >DP_AUX_MAX_PAYLOAD_BYTES ? +DP_AUX_MAX_PAYLOAD_BYTES : bytes_to_recv; + + ret =drm_dp_dpcd_read (&intel_dig_port->dp.aux, offset, + (void *)byte, len); +if (ret <0 ) { +DRM_DEBUG_KMS ("msg_id %d, ret %zd\n" , msg_id, ret); +return ret; + } + + bytes_to_recv -= ret; + byte += ret; + offset += ret; + } + byte = buf; + *byte = msg_id; + +return size; +} + +static +int intel_dp_hdcp2_config_stream_type (struct intel_digital_port *intel_dig_port, +bool is_repeater,u8 content_type) +{ +struct hdcp2_dp_errata_stream_type stream_type_msg; + +if (is_repeater) +return 0 ; + +/* +* Errata for DP: As Stream type is used for encryption, Receiver +* should be communicated with stream type for the decryption of the +* content. +* Repeater will be communicated with stream type as a part of it's +* auth later in time. +*/ + stream_type_msg.msg_id =HDCP_2_2_ERRATA_DP_STREAM_TYPE ; + stream_type_msg.stream_type = content_type; + +return intel_dp_hdcp2_write_msg (intel_dig_port, &stream_type_msg, +sizeof (stream_type_msg)); +} + +static +int intel_dp_hdcp2_check_link (struct intel_digital_port *intel_dig_port) +{ +u8 rx_status; +int ret; + + ret =intel_dp_hdcp2_read_rx_status (intel_dig_port, &rx_status); +if (ret) +return ret; + +if (HDCP_2_2_DP_RXSTATUS_REAUTH_REQ (rx_status)) + ret =HDCP_REAUTH_REQUEST ; +else if (HDCP_2_2_DP_RXSTATUS_LINK_FAILED (rx_status)) + ret =HDCP_LINK_INTEGRITY_FAILURE ; +else if (HDCP_2_2_DP_RXSTATUS_READY (rx_status)) + ret =HDCP_TOPOLOGY_CHANGE ; + +return ret; +} + +static +int intel_dp_hdcp2_capable (struct intel_digital_port *intel_dig_port, +bool *capable) +{ +u8 rx_caps[3 ]; +int ret; + + *capable = false; + ret =drm_dp_dpcd_read (&intel_dig_port->dp.aux, +DP_HDCP_2_2_REG_RX_CAPS_OFFSET , + rx_caps,HDCP_2_2_RXCAPS_LEN ); +if (ret !=HDCP_2_2_RXCAPS_LEN ) +return ret >=0 ? -EIO : ret; + +if (rx_caps[0 ] ==HDCP_2_2_RX_CAPS_VERSION_VAL && +HDCP_2_2_DP_HDCP_CAPABLE (rx_caps[2 ])) + *capable = true; + +return 0 ; +} +static const struct intel_hdcp_shim intel_dp_hdcp_shim = { .write_an_aksv = intel_dp_hdcp_write_an_aksv, .read_bksv = intel_dp_hdcp_read_bksv,
@@ -5859,6 +6186,12 @@ static const struct intel_hdcp_shim intel_dp_hdcp_shim = { .toggle_signalling = intel_dp_hdcp_toggle_signalling, .check_link = intel_dp_hdcp_check_link, .hdcp_capable = intel_dp_hdcp_capable, + .write_2_2_msg = intel_dp_hdcp2_write_msg, + .read_2_2_msg = intel_dp_hdcp2_read_msg, + .config_stream_type = intel_dp_hdcp2_config_stream_type, + .check_2_2_link = intel_dp_hdcp2_check_link, + .hdcp_2_2_capable = intel_dp_hdcp2_capable, + .protocol = HDCP_PROTOCOL_DP, };static void intel_edp_panel_vdd_sanitize (struct intel_dp *intel_dp)
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v12 16/38 drm/i915: Implement the HDCP2.2 support for HDMI
In reply to Ramalingam CImplements the HDMI adaptation specific HDCP2.2 operations.
Basically these are DDC read and write for authenticating through HDCP2.2 messages.
v2: Rebased.
v3:
No more special handling of Gmbus burst read for AKE_SEND_CERT. Style fixed with few naming. [Uma]
%s/PARING/PAIRING
v4:
msg_sz is initialized at definition.
Lookup table is defined for HDMI HDCP2.2 msgs [Daniel].
v5: Rebased.
v6:
Make a function as inline [Uma]
%s/uintxx_t/uxx
v7:
Errors due to sinks are reported as DEBUG logs. Adjust to the new mei interface.
v8:
ARRAY_SIZE for the # of array members [Jon & Daniel]. hdcp adaptation is added as a const in the hdcp_shim [Daniel]
--- drivers/gpu/drm/i915/intel_hdmi.c | 189 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 189 insertions(+)
drivers/gpu/drm/i915/intel_hdmi.c +189 -0
@@ -1129,6 +1129,190 @@ bool intel_hdmi_hdcp_check_link(struct intel_digital_port *intel_dig_port)return true; } +static struct hdcp2_hdmi_msg_data { +u8 msg_id; +u32 timeout; +u32 timeout2; + } hdcp2_msg_data[] = { + {HDCP_2_2_AKE_INIT ,0 ,0 }, + {HDCP_2_2_AKE_SEND_CERT ,HDCP_2_2_CERT_TIMEOUT_MS ,0 }, + {HDCP_2_2_AKE_NO_STORED_KM ,0 ,0 }, + {HDCP_2_2_AKE_STORED_KM ,0 ,0 }, + {HDCP_2_2_AKE_SEND_HPRIME ,HDCP_2_2_HPRIME_PAIRED_TIMEOUT_MS , +HDCP_2_2_HPRIME_NO_PAIRED_TIMEOUT_MS }, + {HDCP_2_2_AKE_SEND_PAIRING_INFO ,HDCP_2_2_PAIRING_TIMEOUT_MS , +0 }, + {HDCP_2_2_LC_INIT ,0 ,0 }, + {HDCP_2_2_LC_SEND_LPRIME ,HDCP_2_2_HDMI_LPRIME_TIMEOUT_MS ,0 }, + {HDCP_2_2_SKE_SEND_EKS ,0 ,0 }, + {HDCP_2_2_REP_SEND_RECVID_LIST , +HDCP_2_2_RECVID_LIST_TIMEOUT_MS ,0 }, + {HDCP_2_2_REP_SEND_ACK ,0 ,0 }, + {HDCP_2_2_REP_STREAM_MANAGE ,0 ,0 }, + {HDCP_2_2_REP_STREAM_READY ,HDCP_2_2_STREAM_READY_TIMEOUT_MS , +0 }, + }; + +static +int intel_hdmi_hdcp2_read_rx_status (struct intel_digital_port *intel_dig_port, +uint8_t *rx_status) +{ +return intel_hdmi_hdcp_read (intel_dig_port, +HDCP_2_2_HDMI_REG_RXSTATUS_OFFSET , + rx_status, +HDCP_2_2_HDMI_RXSTATUS_LEN ); +} + +static int get_hdcp2_msg_timeout (u8 msg_id,bool is_paired) +{ +int i; + +for (i =0 ; i <ARRAY_SIZE (hdcp2_msg_data); i++) +if (hdcp2_msg_data[i].msg_id == msg_id && + (msg_id !=HDCP_2_2_AKE_SEND_HPRIME || is_paired)) +return hdcp2_msg_data[i].timeout; +else if (hdcp2_msg_data[i].msg_id == msg_id) +return hdcp2_msg_data[i].timeout2; + +return -EINVAL ; +} + +static inline +int hdcp2_detect_msg_availability (struct intel_digital_port *intel_digital_port, +u8 msg_id,bool *msg_ready, +ssize_t *msg_sz) +{ +u8 rx_status[HDCP_2_2_HDMI_RXSTATUS_LEN ]; +int ret; + + ret =intel_hdmi_hdcp2_read_rx_status (intel_digital_port, rx_status); +if (ret <0 ) { +DRM_DEBUG_KMS ("rx_status read failed. Err %d\n" , ret); +return ret; + } + + *msg_sz = ((HDCP_2_2_HDMI_RXSTATUS_MSG_SZ_HI (rx_status[1 ]) <<8 ) | + rx_status[0 ]); + +if (msg_id ==HDCP_2_2_REP_SEND_RECVID_LIST ) + *msg_ready = (HDCP_2_2_HDMI_RXSTATUS_READY (rx_status[1 ]) && + *msg_sz); +else + *msg_ready = *msg_sz; + +return 0 ; +} + +static ssize_t +intel_hdmi_hdcp2_wait_for_msg (struct intel_digital_port *intel_dig_port, +u8 msg_id,bool paired) +{ +bool msg_ready = false; +int timeout, ret; +ssize_t msg_sz =0 ; + + timeout =get_hdcp2_msg_timeout (msg_id, paired); +if (timeout <0 ) +return timeout; + + ret =__wait_for (ret =hdcp2_detect_msg_availability (intel_dig_port, + msg_id, &msg_ready, + &msg_sz), + !ret && msg_ready && msg_sz, timeout *1000 , +1000 ,5 *1000 ); +if (ret) +DRM_DEBUG_KMS ("msg_id: %d, ret: %d, timeout: %d\n" , + msg_id, ret, timeout); + +return ret ? ret : msg_sz; +} + +static +int intel_hdmi_hdcp2_write_msg (struct intel_digital_port *intel_dig_port, +void *buf,size_t size) +{ +unsigned int offset; + + offset =HDCP_2_2_HDMI_REG_WR_MSG_OFFSET ; +return intel_hdmi_hdcp_write (intel_dig_port, offset, buf, size); +} + +static +int intel_hdmi_hdcp2_read_msg (struct intel_digital_port *intel_dig_port, +u8 msg_id,void *buf,size_t size) +{ +struct intel_hdmi *hdmi = &intel_dig_port->hdmi; +struct intel_hdcp *hdcp = &hdmi->attached_connector->hdcp; +unsigned int offset; +ssize_t ret; + + ret =intel_hdmi_hdcp2_wait_for_msg (intel_dig_port, msg_id, + hdcp->is_paired); +if (ret <0 ) +return ret; + +/* +* Available msg size should be equal to or lesser than the +* available buffer. +*/ +if (ret > size) { +DRM_DEBUG_KMS ("msg_sz(%zd) is more than exp size(%zu)\n" , + ret, size); +return -1 ; + } + + offset =HDCP_2_2_HDMI_REG_RD_MSG_OFFSET ; + ret =intel_hdmi_hdcp_read (intel_dig_port, offset, buf, ret); +if (ret) +DRM_DEBUG_KMS ("Failed to read msg_id: %d(%zd)\n" , msg_id, ret); + +return ret; +} + +static +int intel_hdmi_hdcp2_check_link (struct intel_digital_port *intel_dig_port) +{ +u8 rx_status[HDCP_2_2_HDMI_RXSTATUS_LEN ]; +int ret; + + ret =intel_hdmi_hdcp2_read_rx_status (intel_dig_port, rx_status); +if (ret) +return ret; + +/* +* Re-auth request and Link Integrity Failures are represented by +* same bit. i.e reauth_req. +*/ +if (HDCP_2_2_HDMI_RXSTATUS_REAUTH_REQ (rx_status[1 ])) + ret =HDCP_REAUTH_REQUEST ; +else if (HDCP_2_2_HDMI_RXSTATUS_READY (rx_status[1 ])) + ret =HDCP_TOPOLOGY_CHANGE ; + +return ret; +} + +static +int intel_hdmi_hdcp2_capable (struct intel_digital_port *intel_dig_port, +bool *capable) +{ +u8 hdcp2_version; +int ret; + + *capable = false; + ret =intel_hdmi_hdcp_read (intel_dig_port,HDCP_2_2_HDMI_REG_VER_OFFSET , + &hdcp2_version,sizeof (hdcp2_version)); +if (!ret && hdcp2_version &HDCP_2_2_HDMI_SUPPORT_MASK ) + *capable = true; + +return ret; +} + +static inline +enum hdcp_wired_protocol intel_hdmi_hdcp2_protocol (void ) +{ +return HDCP_PROTOCOL_HDMI ; +} +static const struct intel_hdcp_shim intel_hdmi_hdcp_shim = { .write_an_aksv = intel_hdmi_hdcp_write_an_aksv, .read_bksv = intel_hdmi_hdcp_read_bksv,
@@ -1140,6 +1324,11 @@ static const struct intel_hdcp_shim intel_hdmi_hdcp_shim = { .read_v_prime_part = intel_hdmi_hdcp_read_v_prime_part, .toggle_signalling = intel_hdmi_hdcp_toggle_signalling, .check_link = intel_hdmi_hdcp_check_link, + .write_2_2_msg = intel_hdmi_hdcp2_write_msg, + .read_2_2_msg = intel_hdmi_hdcp2_read_msg, + .check_2_2_link = intel_hdmi_hdcp2_check_link, + .hdcp_2_2_capable = intel_hdmi_hdcp2_capable, + .protocol = HDCP_PROTOCOL_HDMI, }; static void intel_hdmi_prepare(struct intel_encoder *encoder,
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v12 17/38 drm/i915: CP_IRQ handling for DP HDCP2.2 msgs
In reply to Ramalingam CImplements the
Waitqueue is created to wait for CP_IRQ Signaling the CP_IRQ arrival through atomic variable. For applicable DP HDCP2.2 msgs read wait for CP_IRQ.
As per HDCP2.2 spec "HDCP Transmitters must process CP_IRQ interrupts when they are received from HDCP Receivers"
Without CP_IRQ processing, DP HDCP2.2 H_Prime msg was getting corrupted while reading it based on corresponding status bit. This creates the random failures in reading the DP HDCP2.2 msgs.
v2:
CP_IRQ arrival is tracked based on the atomic val inc [daniel] Recording the reviewed-by Daniel from IRC.
--- drivers/gpu/drm/i915/intel_dp.c | 31 +++++++++++++++++++++++-------- drivers/gpu/drm/i915/intel_drv.h | 8 ++++++++ drivers/gpu/drm/i915/intel_hdcp.c | 11 ++++------- 3 files changed, 35 insertions(+), 15 deletions(-)
drivers/gpu/drm/i915/intel_dp.c +23 -8
@@ -5623,6 +5623,18 @@ void intel_dp_encoder_suspend(struct intel_encoder *intel_encoder)edp_panel_vdd_off_sync (intel_dp); } +static void intel_dp_hdcp_wait_for_cp_irq (struct intel_hdcp *hdcp,int timeout) +{ +long ret; + +#define C (hdcp->cp_irq_count_cached != atomic_read(&hdcp->cp_irq_count)) + ret =wait_event_interruptible_timeout (hdcp->cp_irq_queue,C , +msecs_to_jiffies (timeout)); + +if (!ret) +DRM_DEBUG_KMS ("Timedout at waiting for CP_IRQ\n" ); +} +static int intel_dp_hdcp_write_an_aksv (struct intel_digital_port *intel_dig_port,u8 *an)
@@ -5967,14 +5979,13 @@ intel_dp_hdcp2_wait_for_msg(struct intel_digital_port *intel_dig_port,mdelay (timeout); ret =0 ; }else { -/* TODO: In case if you need to wait on CP_IRQ, do it here */ - ret =__wait_for (ret = -hdcp2_detect_msg_availability (intel_dig_port, - msg_id, - &msg_ready), - !ret && msg_ready, timeout *1000 , -1000 ,5 *1000 ); - +/* +* As we want to check the msg availability at timeout, Ignoring +* the timeout at wait for CP_IRQ. +*/ +intel_dp_hdcp_wait_for_cp_irq (hdcp, timeout); + ret =hdcp2_detect_msg_availability (intel_dig_port, + msg_id, &msg_ready);if (!msg_ready) ret = -ETIMEDOUT ; }
@@ -6001,6 +6012,8 @@ staticint intel_dp_hdcp2_write_msg (struct intel_digital_port *intel_dig_port,void *buf,size_t size) { +struct intel_dp *dp = &intel_dig_port->dp; +struct intel_hdcp *hdcp = &dp->attached_connector->hdcp;unsigned int offset;u8 *byte = buf;ssize_t ret, bytes_to_write, len;
@@ -6016,6 +6029,8 @@ int intel_dp_hdcp2_write_msg(struct intel_digital_port *intel_dig_port, bytes_to_write = size -1 ; byte++; + hdcp->cp_irq_count_cached =atomic_read (&hdcp->cp_irq_count); +while (bytes_to_write) { len = bytes_to_write >DP_AUX_MAX_PAYLOAD_BYTES ?DP_AUX_MAX_PAYLOAD_BYTES : bytes_to_write;
drivers/gpu/drm/i915/intel_drv.h +8 -0
@@ -474,6 +474,14 @@ struct intel_hdcp {* over re-Auth has to be triggered. */ u32 seq_num_m; + +/* +* Work queue to signal the CP_IRQ. Used for the waiters to read the +* available information from HDCP DP sink. +*/ +wait_queue_head_t cp_irq_queue; +atomic_t cp_irq_count; +int cp_irq_count_cached; };struct intel_connector {
drivers/gpu/drm/i915/intel_hdcp.c +4 -7
@@ -1806,6 +1806,7 @@ int intel_hdcp_init(struct intel_connector *connector,if (is_hdcp2_supported (dev_priv))intel_hdcp2_init (connector); +init_waitqueue_head (&hdcp->cp_irq_queue);return 0 ; }
@@ -1935,12 +1936,8 @@ void intel_hdcp_handle_cp_irq(struct intel_connector *connector)if (!hdcp->shim)return ; -/* -* CP_IRQ could be triggered due to 1. HDCP2.2 auth msgs availability, -* 2. link failure and 3. repeater reauth request. At present we dont -* handle the CP_IRQ for the HDCP2.2 auth msg availability for read. -* To handle other two causes for CP_IRQ we have the work_fn which is -* scheduled here. -*/ +atomic_inc (&connector->hdcp.cp_irq_count); +wake_up_all (&connector->hdcp.cp_irq_queue); +schedule_delayed_work (&hdcp->check_work,0 ); }
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v12 18/38 drm/i915: Fix KBL HDCP2.2 encrypt status signalling
In reply to Ramalingam CHDCP transmitter is supposed to indicate the HDCP encryption status of the link through enc_en signals in a window of time called "window of opportunity" defined by HDCP HDMI spec.
But on KBL this timing of signalling has an issue. To fix the issue this WA of resetting the signalling is required.
v2:
WA is moved into the toggle_signalling [Daniel]
v3:
Commit msg is rewritten with more information
v4:
Reviewed-by Daniel.
--- drivers/gpu/drm/i915/intel_hdmi.c | 42 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 42 insertions(+)
drivers/gpu/drm/i915/intel_hdmi.c +42 -0
@@ -1083,10 +1083,44 @@ int intel_hdmi_hdcp_read_v_prime_part(struct intel_digital_port *intel_dig_port,return ret; } +static int kbl_repositioning_enc_en_signal (struct intel_connector *connector) +{ +struct drm_i915_private *dev_priv =to_i915 (connector->base.dev); +struct intel_digital_port *intel_dig_port =conn_to_dig_port (connector); +struct drm_crtc *crtc = connector->base.state->crtc; +struct intel_crtc *intel_crtc =container_of (crtc, + struct intel_crtc, base); +u32 scanline; +int ret; + +for (;;) { + scanline =I915_READ (PIPEDSL (intel_crtc->pipe)); +if (scanline >100 && scanline <200 ) +break ; +usleep_range (25 ,50 ); + } + + ret =intel_ddi_toggle_hdcp_signalling (&intel_dig_port->base, false); +if (ret) { +DRM_ERROR ("Disable HDCP signalling failed (%d)\n" , ret); +return ret; + } + ret =intel_ddi_toggle_hdcp_signalling (&intel_dig_port->base, true); +if (ret) { +DRM_ERROR ("Enable HDCP signalling failed (%d)\n" , ret); +return ret; + } + +return 0 ; +} +static int intel_hdmi_hdcp_toggle_signalling (struct intel_digital_port *intel_dig_port,bool enable) { +struct intel_hdmi *hdmi = &intel_dig_port->hdmi; +struct intel_connector *connector = hdmi->attached_connector; +struct drm_i915_private *dev_priv =to_i915 (connector->base.dev);int ret;if (!enable)
@@ -1098,6 +1132,14 @@ int intel_hdmi_hdcp_toggle_signalling(struct intel_digital_port *intel_dig_port, enable ? "Enable" : "Disable", ret);return ret; } + +/* +* WA: To fix incorrect positioning of the window of +* opportunity and enc_en signalling in KABYLAKE. +*/ +if (IS_KABYLAKE (dev_priv) && enable) +return kbl_repositioning_enc_en_signal (connector); +return 0 ; }
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v12 19/38 mei: bus: whitelist hdcp client
In reply to Ramalingam CFrom: Tomas Winkler <[email protected]>
Whitelist HDCP client for in kernel drm use
v2:
Rebased.
--- drivers/misc/mei/bus-fixup.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)
drivers/misc/mei/bus-fixup.c +16 -0
@@ -40,6 +40,9 @@ static const uuid_le mei_nfc_info_guid = MEI_UUID_NFC_INFO;#define MEI_UUID_MKHIF_FIX UUID_LE(0x55213584, 0x9a29, 0x4916, \ 0xba, 0xdf, 0xf, 0xb7, 0xed, 0x68, 0x2a, 0xeb) +#define MEI_UUID_HDCP UUID_LE(0xB638AB7E, 0x94E2, 0x4EA2, \ + 0xA5, 0x52, 0xD1, 0xC5, 0x4B, 0x62, 0x7F, 0x04) +#define MEI_UUID_ANY NULL_UUID_LE/**
@@ -71,6 +74,18 @@ static void blacklist(struct mei_cl_device *cldev) cldev->do_match =0 ; } +/** +* whitelist - forcefully whitelist client +* +* @cldev: me clients device +*/ +static void whitelist (struct mei_cl_device *cldev) +{ +dev_dbg (&cldev->dev,"running hook %s\n" , __func__); + + cldev->do_match =1 ; +} +#define OSTYPE_LINUX 2struct mei_os_ver {__le16 build;
@@ -472,6 +487,7 @@ static struct mei_fixup {MEI_FIXUP (MEI_UUID_NFC_HCI , mei_nfc),MEI_FIXUP (MEI_UUID_WD , mei_wd),MEI_FIXUP (MEI_UUID_MKHIF_FIX , mei_mkhi_fix), + MEI_FIXUP(MEI_UUID_HDCP, whitelist), };/**
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v12 20/38 mei: bus: export to_mei_cl_device for mei client device drivers
In reply to Ramalingam CFrom: Tomas Winkler <[email protected]>
Export to_mei_cl_device macro, it is needed also in mei client drivers.
--- drivers/misc/mei/bus.c | 1 - include/linux/mei_cl_bus.h | 2 ++ 2 files changed, 2 insertions(+), 1 deletion(-)
drivers/misc/mei/bus.c +0 -1
@@ -28,7 +28,6 @@#include "client.h" #define to_mei_cl_driver (d) container_of(d, struct mei_cl_driver, driver) -#define to_mei_cl_device (d) container_of(d, struct mei_cl_device, dev)/** * __mei_cl_send - internal client send (write)
include/linux/mei_cl_bus.h +2 -0
@@ -55,6 +55,8 @@ struct mei_cl_device {void *priv_data; }; +#define to_mei_cl_device (d) container_of(d, struct mei_cl_device, dev) +struct mei_cl_driver {struct device_driver driver;const char *name;
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v12 21/38 mei: me: add ice lake point device id.
In reply to Ramalingam CFrom: Tomas Winkler <[email protected]>
Add icelake mei device id.
Cherry-picked from git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git char-misc-linus
--- drivers/misc/mei/hw-me-regs.h | 2 ++ drivers/misc/mei/pci-me.c | 2 ++ 2 files changed, 4 insertions(+)
drivers/misc/mei/hw-me-regs.h +2 -0
@@ -139,6 +139,8 @@#define MEI_DEV_ID_CNP_H 0xA360/* Cannon Point H */ #define MEI_DEV_ID_CNP_H_4 0xA364/* Cannon Point H 4 (iTouch) */ +#define MEI_DEV_ID_ICP_LP 0x34E0/* Ice Lake Point LP */ +/* * MEI HW Section */
drivers/misc/mei/pci-me.c +2 -0
@@ -105,6 +105,8 @@ static const struct pci_device_id mei_me_pci_tbl[] = { {MEI_PCI_DEVICE(MEI_DEV_ID_CNP_H, MEI_ME_PCH12_CFG)}, {MEI_PCI_DEVICE(MEI_DEV_ID_CNP_H_4, MEI_ME_PCH8_CFG)}, + {MEI_PCI_DEVICE(MEI_DEV_ID_ICP_LP, MEI_ME_PCH12_CFG)}, +/* required last entry */ {0, } };
Signature · 1 line
2.7.4
Greg KH
maintainerRe: [PATCH v12 21/38] mei: me: add ice lake point device id.
Quoted 4 lines · Ramalingam C
From: Tomas Winkler <[email protected]>
Add icelake mei device id.
Quoted 8 lines
Cc <[email protected]>Signed-off-by Tomas Winkler <[email protected]>Signed-off-by Greg Kroah-Hartman <[email protected]>Cherry-picked from
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.gitchar-misc-linus--- drivers/misc/mei/hw-me-regs.h | 2 ++ drivers/misc/mei/pci-me.c | 2 ++ 2 files changed, 4 insertions(+)
Why are you sending us patches that are already applied?
RE: [PATCH v12 21/38] mei: me: add ice lake point device id.
Quoted 17 lines · Ramalingam C
Quoted 7 lines
From: Tomas Winkler <[email protected]>
Add icelake mei device id.
Cc <[email protected]>Signed-off-by Tomas Winkler <[email protected]>Signed-off-by Greg Kroah-Hartman <[email protected]>Quoted 7 lines
Cherry-picked from
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
char-misc-linus--- drivers/misc/mei/hw-me-regs.h | 2 ++ drivers/misc/mei/pci-me.c | 2 ++ 2 files changed, 4 insertions(+)
Quoted 1 line
Why are you sending us patches that are already applied?
They're unslinging it for GFX CI so they need it in their queue, it was not merged into the master branch at the time. Thanks
Tomas
Re: [PATCH v12 21/38] mei: me: add ice lake point device id.
In reply to Ramalingam CHi,
[This is an automated email]
This commit has been processed because it contains a -stable tag. The stable tag indicates that it's relevant for the following trees: all
The bot has tested the following trees: v4.20.7, v4.19.20, v4.14.98, v4.9.155, v4.4.173, v3.18.134.
v4.20.7: Build OK!
v4.19.20: Build OK!
v4.14.98: Build failed! Errors:
drivers/misc/mei/pci-me.c:108:37: error: ‘MEI_ME_PCH12_CFG’ undeclared here (not in a function); did you mean ‘MEI_ME_PCH8_CFG’?
v4.9.155: Failed to apply! Possible dependencies:
f8f4aa68a8ae ("mei: me: add cannon point device ids")
v4.4.173: Failed to apply! Possible dependencies:
f8f4aa68a8ae ("mei: me: add cannon point device ids")
v3.18.134: Build failed! Errors:
drivers/misc/mei/pci-me.c:86:37: error: ‘MEI_ME_PCH12_CFG’ undeclared here (not in a function)
How should we proceed with this patch?
--
Thanks,
Sasha
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Sasha Levin
maintainerRe: [PATCH v12 21/38] mei: me: add ice lake point device id.
In reply to Ramalingam CHi,
[This is an automated email]
This commit has been processed because it contains a -stable tag. The stable tag indicates that it's relevant for the following trees: all
The bot has tested the following trees: v4.20.7, v4.19.20, v4.14.98, v4.9.155, v4.4.173, v3.18.134.
v4.20.7: Build OK!
v4.19.20: Build OK!
v4.14.98: Build failed! Errors:
drivers/misc/mei/pci-me.c:108:37: error: ‘MEI_ME_PCH12_CFG’ undeclared here (not in a function); did you mean ‘MEI_ME_PCH8_CFG’?
v4.9.155: Failed to apply! Possible dependencies:
f8f4aa68a8ae ("mei: me: add cannon point device ids")
v4.4.173: Failed to apply! Possible dependencies:
f8f4aa68a8ae ("mei: me: add cannon point device ids")
v3.18.134: Build failed! Errors:
drivers/misc/mei/pci-me.c:86:37: error: ‘MEI_ME_PCH12_CFG’ undeclared here (not in a function)
How should we proceed with this patch?
--
Thanks,
Sasha
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v12 22/38 misc/mei/hdcp: Client driver for HDCP application
In reply to Ramalingam CME FW contributes a vital role in HDCP2.2 authentication. HDCP2.2 driver needs to communicate to ME FW for each step of the HDCP2.2 authentication.
ME FW prepare and HDCP2.2 authentication parameters and encrypt them as per spec. With such parameter Driver prepares HDCP2.2 auth messages and communicate with HDCP2.2 sink.
Similarly HDCP2.2 sink's response is shared with ME FW for decrypt and verification.
Once All the steps of HDCP2.2 authentications are complete on driver's request ME FW will configure the port as authenticated and supply the HDCP keys to the Gen HW for encryption.
Only after this stage HDCP2.2 driver can start the HDCP2.2 encryption for a port.
ME FW is interfaced to kernel through MEI Bus Driver. To obtain the HDCP2.2 services from the ME FW through MEI Bus driver MEI Client Driver is developed.
v2:
hdcp files are moved to drivers/misc/mei/hdcp/ [Tomas]
v3:
Squashed the Kbuild support [Tomas]
UUID renamed and Module License is modified [Tomas] drv_data is set to null at remove [Tomas]
v4:
Module name is changed to "MEI HDCP"
I915 Selects the MEI_HDCP
v5:
Remove redundant text from the License header Fix malformed licence
Removed the drv_data resetting.
v6:
K-Doc addition. [Tomas]
v7:
%s/UUID_LE/GUID_INIT [Tomas]
GPL Ver is 2.0 than 2.0+ [Tomas]
--- drivers/misc/mei/Kconfig | 7 +++++ drivers/misc/mei/Makefile | 2 ++ drivers/misc/mei/hdcp/Makefile | 7 +++++ drivers/misc/mei/hdcp/mei_hdcp.c | 64 ++++++++++++++++++++++++++++++++++++++++ 4 files changed, 80 insertions(+) create mode 100644 drivers/misc/mei/hdcp/Makefile create mode 100644 drivers/misc/mei/hdcp/mei_hdcp.c
drivers/misc/mei/Kconfig +7 -0
@@ -43,3 +43,10 @@ config INTEL_MEI_TXE Supported SoCs: Intel Bay Trail + +config INTEL_MEI_HDCP + tristate "Intel HDCP2.2 services of ME Interface" + select INTEL_MEI_ME + depends on DRM_I915 + help + MEI Support for HDCP2.2 Services on Intel platforms.
drivers/misc/mei/Makefile +2 -0
@@ -24,3 +24,5 @@ mei-txe-objs += hw-txe.o mei-$(CONFIG_EVENT_TRACING) += mei-trace.o CFLAGS_mei-trace.o = -I$(src) + +obj-$(CONFIG_INTEL_MEI_HDCP) += hdcp/
drivers/misc/mei/hdcp/Makefile new file +7 -0
@@ -0,0 +1,7 @@ +# SPDX-License-Identifier: GPL-2.0 +# +# Copyright (c) 2017-2018, Intel Corporation. +# +# Makefile - HDCP client driver for Intel MEI Bus Driver. + +obj-$(CONFIG_INTEL_MEI_HDCP) += mei_hdcp.o
drivers/misc/mei/hdcp/mei_hdcp.c new file +64 -0
64 lines not on this page · raw message
Signature · 6 lines
2.7.4 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH v12 23/38 misc/mei/hdcp: Define ME FW interface for HDCP2.2
In reply to Ramalingam CDefines the HDCP specific ME FW interfaces such as Request CMDs, payload structure for CMDs and their response status codes.
This patch defines payload size(Excluding the Header)for each WIRED HDCP2.2 CMDs.
v2: Rebased.
v3:
Extra comments are removed.
v4:
%s/\/\*\*/\/\*
v5:
Extra lines are removed.
v6:
Remove redundant text from the License header
%s/LPRIME_HALF/V_PRIME_HALF
%s/uintxx_t/uxx
v7:
Extra taps removed.
Acked-by Tomas Winkler <[email protected]>
--- drivers/misc/mei/hdcp/mei_hdcp.h | 366 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 366 insertions(+) create mode 100644 drivers/misc/mei/hdcp/mei_hdcp.h
drivers/misc/mei/hdcp/mei_hdcp.h new file +366 -0
@@ -0,0 +1,366 @@ +/* SPDX-License-Identifier: (GPL-2.0+) */ +/* +* Copyright © 2017-2018 Intel Corporation +* +* Authors: +* Ramalingam C <[email protected]> +*/ + +#ifndef __MEI_HDCP_H__ +#define __MEI_HDCP_H__ + +#include <drm/drm_hdcp.h> + +/* me_hdcp_status: Enumeration of all HDCP Status Codes */ +enum me_hdcp_status { +ME_HDCP_STATUS_SUCCESS =0x0000 , + +/* WiDi Generic Status Codes */ +ME_HDCP_STATUS_INTERNAL_ERROR =0x1000 , +ME_HDCP_STATUS_UNKNOWN_ERROR =0x1001 , +ME_HDCP_STATUS_INCORRECT_API_VERSION =0x1002 , +ME_HDCP_STATUS_INVALID_FUNCTION =0x1003 , +ME_HDCP_STATUS_INVALID_BUFFER_LENGTH =0x1004 , +ME_HDCP_STATUS_INVALID_PARAMS =0x1005 , +ME_HDCP_STATUS_AUTHENTICATION_FAILED =0x1006 , + +/* WiDi Status Codes */ +ME_HDCP_INVALID_SESSION_STATE =0x6000 , +ME_HDCP_SRM_FRAGMENT_UNEXPECTED =0x6001 , +ME_HDCP_SRM_INVALID_LENGTH =0x6002 , +ME_HDCP_SRM_FRAGMENT_OFFSET_INVALID =0x6003 , +ME_HDCP_SRM_VERIFICATION_FAILED =0x6004 , +ME_HDCP_SRM_VERSION_TOO_OLD =0x6005 , +ME_HDCP_RX_CERT_VERIFICATION_FAILED =0x6006 , +ME_HDCP_RX_REVOKED =0x6007 , +ME_HDCP_H_VERIFICATION_FAILED =0x6008 , +ME_HDCP_REPEATER_CHECK_UNEXPECTED =0x6009 , +ME_HDCP_TOPOLOGY_MAX_EXCEEDED =0x600A , +ME_HDCP_V_VERIFICATION_FAILED =0x600B , +ME_HDCP_L_VERIFICATION_FAILED =0x600C , +ME_HDCP_STREAM_KEY_ALLOC_FAILED =0x600D , +ME_HDCP_BASE_KEY_RESET_FAILED =0x600E , +ME_HDCP_NONCE_GENERATION_FAILED =0x600F , +ME_HDCP_STATUS_INVALID_E_KEY_STATE =0x6010 , +ME_HDCP_STATUS_INVALID_CS_ICV =0x6011 , +ME_HDCP_STATUS_INVALID_KB_KEY_STATE =0x6012 , +ME_HDCP_STATUS_INVALID_PAVP_MODE_ICV =0x6013 , +ME_HDCP_STATUS_INVALID_PAVP_MODE =0x6014 , +ME_HDCP_STATUS_LC_MAX_ATTEMPTS =0x6015 , + +/* New status for HDCP 2.1 */ +ME_HDCP_STATUS_MISMATCH_IN_M =0x6016 , + +/* New status code for HDCP 2.2 Rx */ +ME_HDCP_STATUS_RX_PROV_NOT_ALLOWED =0x6017 , +ME_HDCP_STATUS_RX_PROV_WRONG_SUBJECT =0x6018 , +ME_HDCP_RX_NEEDS_PROVISIONING =0x6019 , +ME_HDCP_BKSV_ICV_AUTH_FAILED =0x6020 , +ME_HDCP_STATUS_INVALID_STREAM_ID =0x6021 , +ME_HDCP_STATUS_CHAIN_NOT_INITIALIZED =0x6022 , +ME_HDCP_FAIL_NOT_EXPECTED =0x6023 , +ME_HDCP_FAIL_HDCP_OFF =0x6024 , +ME_HDCP_FAIL_INVALID_PAVP_MEMORY_MODE =0x6025 , +ME_HDCP_FAIL_AES_ECB_FAILURE =0x6026 , +ME_HDCP_FEATURE_NOT_SUPPORTED =0x6027 , +ME_HDCP_DMA_READ_ERROR =0x6028 , +ME_HDCP_DMA_WRITE_ERROR =0x6029 , +ME_HDCP_FAIL_INVALID_PACKET_SIZE =0x6030 , +ME_HDCP_H264_PARSING_ERROR =0x6031 , +ME_HDCP_HDCP2_ERRATA_VIDEO_VIOLATION =0x6032 , +ME_HDCP_HDCP2_ERRATA_AUDIO_VIOLATION =0x6033 , +ME_HDCP_TX_ACTIVE_ERROR =0x6034 , +ME_HDCP_MODE_CHANGE_ERROR =0x6035 , +ME_HDCP_STREAM_TYPE_ERROR =0x6036 , +ME_HDCP_STREAM_MANAGE_NOT_POSSIBLE =0x6037 , + +ME_HDCP_STATUS_PORT_INVALID_COMMAND =0x6038 , +ME_HDCP_STATUS_UNSUPPORTED_PROTOCOL =0x6039 , +ME_HDCP_STATUS_INVALID_PORT_INDEX =0x603a , +ME_HDCP_STATUS_TX_AUTH_NEEDED =0x603b , +ME_HDCP_STATUS_NOT_INTEGRATED_PORT =0x603c , +ME_HDCP_STATUS_SESSION_MAX_REACHED =0x603d , + +/* hdcp capable bit is not set in rx_caps(error is unique to DP) */ +ME_HDCP_STATUS_NOT_HDCP_CAPABLE =0x6041 , + +ME_HDCP_STATUS_INVALID_STREAM_COUNT =0x6042 , +}; + +#define HDCP_API_VERSION 0x00010000 + +#define HDCP_M_LEN 16 +#define HDCP_KH_LEN 16 + +/* Payload Buffer size(Excluding Header) for CMDs and corresponding response */ +/* Wired_Tx_AKE */ +#define WIRED_CMD_BUF_LEN_INITIATE_HDCP2_SESSION_IN (4 + 1) +#define WIRED_CMD_BUF_LEN_INITIATE_HDCP2_SESSION_OUT (4 + 8 + 3) + +#define WIRED_CMD_BUF_LEN_VERIFY_RECEIVER_CERT_IN (4 + 522 + 8 + 3) +#define WIRED_CMD_BUF_LEN_VERIFY_RECEIVER_CERT_MIN_OUT (4 + 1 + 3 + 16 + 16) +#define WIRED_CMD_BUF_LEN_VERIFY_RECEIVER_CERT_MAX_OUT (4 + 1 + 3 + 128) + +#define WIRED_CMD_BUF_LEN_AKE_SEND_HPRIME_IN (4 + 32) +#define WIRED_CMD_BUF_LEN_AKE_SEND_HPRIME_OUT (4) + +#define WIRED_CMD_BUF_LEN_SEND_PAIRING_INFO_IN (4 + 16) +#define WIRED_CMD_BUF_LEN_SEND_PAIRING_INFO_OUT (4) + +#define WIRED_CMD_BUF_LEN_CLOSE_SESSION_IN (4) +#define WIRED_CMD_BUF_LEN_CLOSE_SESSION_OUT (4) + +/* Wired_Tx_LC */ +#define WIRED_CMD_BUF_LEN_INIT_LOCALITY_CHECK_IN (4) +#define WIRED_CMD_BUF_LEN_INIT_LOCALITY_CHECK_OUT (4 + 8) + +#define WIRED_CMD_BUF_LEN_VALIDATE_LOCALITY_IN (4 + 32) +#define WIRED_CMD_BUF_LEN_VALIDATE_LOCALITY_OUT (4) + +/* Wired_Tx_SKE */ +#define WIRED_CMD_BUF_LEN_GET_SESSION_KEY_IN (4) +#define WIRED_CMD_BUF_LEN_GET_SESSION_KEY_OUT (4 + 16 + 8) + +/* Wired_Tx_SKE */ +#define WIRED_CMD_BUF_LEN_ENABLE_AUTH_IN (4 + 1) +#define WIRED_CMD_BUF_LEN_ENABLE_AUTH_OUT (4) + +/* Wired_Tx_Repeater */ +#define WIRED_CMD_BUF_LEN_VERIFY_REPEATER_IN (4 + 2 + 3 + 16 + 155) +#define WIRED_CMD_BUF_LEN_VERIFY_REPEATER_OUT (4 + 1 + 16) + +#define WIRED_CMD_BUF_LEN_REPEATER_AUTH_STREAM_REQ_MIN_IN (4 + 3 + \ + 32 + 2 + 2) + +#define WIRED_CMD_BUF_LEN_REPEATER_AUTH_STREAM_REQ_OUT (4) + +/* hdcp_command_id: Enumeration of all WIRED HDCP Command IDs */ +enum hdcp_command_id { + _WIDI_COMMAND_BASE =0x00030000 , +WIDI_INITIATE_HDCP2_SESSION = _WIDI_COMMAND_BASE, +HDCP_GET_SRM_STATUS , +HDCP_SEND_SRM_FRAGMENT , + +/* The wired HDCP Tx commands */ + _WIRED_COMMAND_BASE =0x00031000 , +WIRED_INITIATE_HDCP2_SESSION = _WIRED_COMMAND_BASE, +WIRED_VERIFY_RECEIVER_CERT , +WIRED_AKE_SEND_HPRIME , +WIRED_AKE_SEND_PAIRING_INFO , +WIRED_INIT_LOCALITY_CHECK , +WIRED_VALIDATE_LOCALITY , +WIRED_GET_SESSION_KEY , +WIRED_ENABLE_AUTH , +WIRED_VERIFY_REPEATER , +WIRED_REPEATER_AUTH_STREAM_REQ , +WIRED_CLOSE_SESSION , + + _WIRED_COMMANDS_COUNT, +}; + +union encrypted_buff { +u8 e_kpub_km[HDCP_2_2_E_KPUB_KM_LEN ]; +u8 e_kh_km_m[HDCP_2_2_E_KH_KM_M_LEN ]; +struct { +u8 e_kh_km[HDCP_KH_LEN ]; +u8 m[HDCP_M_LEN ]; + } __packed; +}; + +/* HDCP HECI message header. All header values are little endian. */ +struct hdcp_cmd_header { +u32 api_version; +u32 command_id; +enum me_hdcp_status status; +/* Length of the HECI message (excluding the header) */ +u32 buffer_len; +} __packed; + +/* Empty command request or response. No data follows the header. */ +struct hdcp_cmd_no_data { +struct hdcp_cmd_header header; +} __packed; + +/* Uniquely identifies the hdcp port being addressed for a given command. */ +struct hdcp_port_id { +u8 integrated_port_type; +u8 physical_port; +u16 reserved; +} __packed; + +/* +* Data structures for integrated wired HDCP2 Tx in +* support of the AKE protocol +*/ +/* HECI struct for integrated wired HDCP Tx session initiation. */ +struct wired_cmd_initiate_hdcp2_session_in { +struct hdcp_cmd_header header; +struct hdcp_port_id port; +u8 protocol;/* for HDMI vs DP */ +} __packed; + +struct wired_cmd_initiate_hdcp2_session_out { +struct hdcp_cmd_header header; +struct hdcp_port_id port; +u8 r_tx[HDCP_2_2_RTX_LEN ]; +struct hdcp2_tx_caps tx_caps; +} __packed; + +/* HECI struct for ending an integrated wired HDCP Tx session. */ +struct wired_cmd_close_session_in { +struct hdcp_cmd_header header; +struct hdcp_port_id port; +} __packed; + +struct wired_cmd_close_session_out { +struct hdcp_cmd_header header; +struct hdcp_port_id port; +} __packed; + +/* HECI struct for integrated wired HDCP Tx Rx Cert verification. */ +struct wired_cmd_verify_receiver_cert_in { +struct hdcp_cmd_header header; +struct hdcp_port_id port; +struct hdcp2_cert_rx cert_rx; +u8 r_rx[HDCP_2_2_RRX_LEN ]; +u8 rx_caps[HDCP_2_2_RXCAPS_LEN ]; +} __packed; + +struct wired_cmd_verify_receiver_cert_out { +struct hdcp_cmd_header header; +struct hdcp_port_id port; +u8 km_stored; +u8 reserved[3 ]; +union encrypted_buff ekm_buff; +} __packed; + +/* HECI struct for verification of Rx's Hprime in a HDCP Tx session */ +struct wired_cmd_ake_send_hprime_in { +struct hdcp_cmd_header header; +struct hdcp_port_id port; +u8 h_prime[HDCP_2_2_H_PRIME_LEN ]; +} __packed; + +struct wired_cmd_ake_send_hprime_out { +struct hdcp_cmd_header header; +struct hdcp_port_id port; +} __packed; + +/* +* HECI struct for sending in AKE pairing data generated by the Rx in an +* integrated wired HDCP Tx session. +*/ +struct wired_cmd_ake_send_pairing_info_in { +struct hdcp_cmd_header header; +struct hdcp_port_id port; +u8 e_kh_km[HDCP_2_2_E_KH_KM_LEN ]; +} __packed; + +struct wired_cmd_ake_send_pairing_info_out { +struct hdcp_cmd_header header; +struct hdcp_port_id port; +} __packed; + +/* Data structures for integrated wired HDCP2 Tx in support of the LC protocol*/ +/* +* HECI struct for initiating locality check with an +* integrated wired HDCP Tx session. +*/ +struct wired_cmd_init_locality_check_in { +struct hdcp_cmd_header header; +struct hdcp_port_id port; +} __packed; + +struct wired_cmd_init_locality_check_out { +struct hdcp_cmd_header header; +struct hdcp_port_id port; +u8 r_n[HDCP_2_2_RN_LEN ]; +} __packed; + +/* +* HECI struct for validating an Rx's LPrime value in an +* integrated wired HDCP Tx session. +*/ +struct wired_cmd_validate_locality_in { +struct hdcp_cmd_header header; +struct hdcp_port_id port; +u8 l_prime[HDCP_2_2_L_PRIME_LEN ]; +} __packed; + +struct wired_cmd_validate_locality_out { +struct hdcp_cmd_header header; +struct hdcp_port_id port; +} __packed; + +/* +* Data structures for integrated wired HDCP2 Tx in support of the +* SKE protocol +*/ +/* HECI struct for creating session key */ +struct wired_cmd_get_session_key_in { +struct hdcp_cmd_header header; +struct hdcp_port_id port; +} __packed; + +struct wired_cmd_get_session_key_out { +struct hdcp_cmd_header header; +struct hdcp_port_id port; +u8 e_dkey_ks[HDCP_2_2_E_DKEY_KS_LEN ]; +u8 r_iv[HDCP_2_2_RIV_LEN ]; +} __packed; + +/* HECI struct for the Tx enable authentication command */ +struct wired_cmd_enable_auth_in { +struct hdcp_cmd_header header; +struct hdcp_port_id port; +u8 stream_type; +} __packed; + +struct wired_cmd_enable_auth_out { +struct hdcp_cmd_header header; +struct hdcp_port_id port; +} __packed; + +/* +* Data structures for integrated wired HDCP2 Tx in support of +* the repeater protocols +*/ +/* +* HECI struct for verifying the downstream repeater's HDCP topology in an +* integrated wired HDCP Tx session. +*/ +struct wired_cmd_verify_repeater_in { +struct hdcp_cmd_header header; +struct hdcp_port_id port; +u8 rx_info[HDCP_2_2_RXINFO_LEN ]; +u8 seq_num_v[HDCP_2_2_SEQ_NUM_LEN ]; +u8 v_prime[HDCP_2_2_V_PRIME_HALF_LEN ]; +u8 receiver_ids[HDCP_2_2_RECEIVER_IDS_MAX_LEN ]; +} __packed; + +struct wired_cmd_verify_repeater_out { +struct hdcp_cmd_header header; +struct hdcp_port_id port; +u8 content_type_supported; +u8 v[HDCP_2_2_V_PRIME_HALF_LEN ]; +} __packed; + +/* +* HECI struct in support of stream management in an +* integrated wired HDCP Tx session. +*/ +struct wired_cmd_repeater_auth_stream_req_in { +struct hdcp_cmd_header header; +struct hdcp_port_id port; +u8 seq_num_m[HDCP_2_2_SEQ_NUM_LEN ]; +u8 m_prime[HDCP_2_2_MPRIME_LEN ]; +u16 k; +struct hdcp2_streamid_type streams[1 ]; +} __packed; + +struct wired_cmd_repeater_auth_stream_req_out { +struct hdcp_cmd_header header; +struct hdcp_port_id port; +} __packed; + +#endif /* __MEI_HDCP_H__ */
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v12 24/38 misc/mei/hdcp: Initiate Wired HDCP2.2 Tx Session
In reply to Ramalingam CRequest ME FW to start the HDCP2.2 session for an intel port. Prepares payloads for command WIRED_INITIATE_HDCP2_SESSION and sends to ME FW.
On Success, ME FW will start a HDCP2.2 session for the port and provides the content for HDCP2.2 AKE_Init message.
v2: Rebased.
v3:
cldev is add as a separate parameter [Tomas] Redundant comment and typecast are removed [Tomas]
v4:
%zd is used for size [Alexander]
%s/return -1/return -EIO [Alexander]
Spellings in commit msg is fixed [Uma]
v5: Rebased.
v6:
Collected the rb-ed by.
Realigning the patches in the series.
v7:
Adjust to the new mei interface.
Fix for kdoc.
v8:
K-Doc Addition.
memcpy for const length.
v9:
s/mei_hdcp_ddi/mei_fw_ddi s/i915_port/mei_i915_port [Tomas]
renamed func as mei_hdcp_* [Tomas]
Instead of macro, inline func for ddi index is used. [Tomas]
--- drivers/misc/mei/hdcp/mei_hdcp.c | 89 ++++++++++++++++++++++++++++++++++++++++ drivers/misc/mei/hdcp/mei_hdcp.h | 23 +++++++++++ 2 files changed, 112 insertions(+)
drivers/misc/mei/hdcp/mei_hdcp.c +89 -0
@@ -23,6 +23,95 @@#include <linux/slab.h> #include <linux/uuid.h> #include <linux/mei_cl_bus.h> +#include <drm/drm_connector.h> +#include <drm/i915_component.h> +#include <drm/i915_mei_hdcp_interface.h> + +#include "mei_hdcp.h" + +static inline u8 mei_get_ddi_index (short int port) +{ +enum mei_i915_port i915_port = (enum mei_i915_port )port; + +return (u8)(i915_port ==PORT_A ?MEI_DDI_A : i915_port); +} + +/** +* mei_hdcp_initiate_session() - Initiate a Wired HDCP2.2 Tx Session in ME FW +* @dev: device corresponding to the mei_cl_device +* @hdcp_data: Intel HW specific hdcp data +* @ake_data: AKE_Init msg output. +* +* Return: 0 on Success, <0 on Failure. +*/ +static int +mei_hdcp_initiate_session (struct device *dev,struct hdcp_port_data *data, +struct hdcp2_ake_init *ake_data) +{ +struct wired_cmd_initiate_hdcp2_session_in session_init_in = { {0 } }; +struct wired_cmd_initiate_hdcp2_session_out + session_init_out = { {0 } }; +struct mei_cl_device *cldev; +ssize_t byte; + +if (!dev || !data || !ake_data) +return -EINVAL ; + + cldev =to_mei_cl_device (dev); + + session_init_in.header.api_version =HDCP_API_VERSION ; + session_init_in.header.command_id =WIRED_INITIATE_HDCP2_SESSION ; + session_init_in.header.status =ME_HDCP_STATUS_SUCCESS ; + session_init_in.header.buffer_len = +WIRED_CMD_BUF_LEN_INITIATE_HDCP2_SESSION_IN ; + + session_init_in.port.integrated_port_type = data->port_type; + session_init_in.port.physical_port =mei_get_ddi_index (data->port); + session_init_in.protocol = data->protocol; + + byte =mei_cldev_send (cldev, (u8 *)&session_init_in, +sizeof (session_init_in)); +if (byte <0 ) { +dev_dbg (dev,"mei_cldev_send failed. %zd\n" , byte); +return byte; + } + + byte =mei_cldev_recv (cldev, (u8 *)&session_init_out, +sizeof (session_init_out)); +if (byte <0 ) { +dev_dbg (dev,"mei_cldev_recv failed. %zd\n" , byte); +return byte; + } + +if (session_init_out.header.status !=ME_HDCP_STATUS_SUCCESS ) { +dev_dbg (dev,"ME cmd 0x%08X Failed. Status: 0x%X\n" , +WIRED_INITIATE_HDCP2_SESSION , + session_init_out.header.status); +return -EIO ; + } + + ake_data->msg_id =HDCP_2_2_AKE_INIT ; + ake_data->tx_caps = session_init_out.tx_caps; +memcpy (ake_data->r_tx, session_init_out.r_tx,HDCP_2_2_RTX_LEN ); + +return 0 ; +} + +static __attribute__((unused)) +struct i915_hdcp_component_ops mei_hdcp_ops = { + .owner =THIS_MODULE , + .initiate_hdcp2_session = mei_hdcp_initiate_session, + .verify_receiver_cert_prepare_km =NULL , + .verify_hprime =NULL , + .store_pairing_info =NULL , + .initiate_locality_check =NULL , + .verify_lprime =NULL , + .get_session_key =NULL , + .repeater_check_flow_prepare_ack =NULL , + .verify_mprime =NULL , + .enable_hdcp_authentication =NULL , + .close_hdcp_session =NULL , +};static int mei_hdcp_probe (struct mei_cl_device *cldev,const struct mei_cl_device_id *id)
drivers/misc/mei/hdcp/mei_hdcp.h +23 -0
@@ -363,4 +363,27 @@ struct wired_cmd_repeater_auth_stream_req_out { struct hdcp_port_id port; } __packed; +enum mei_fw_ddi { +MEI_DDI_INVALID_PORT =0x0 , + +MEI_DDI_B =1 , +MEI_DDI_C , +MEI_DDI_D , +MEI_DDI_E , +MEI_DDI_F , +MEI_DDI_A =7 , +MEI_DDI_RANGE_END =MEI_DDI_A , +}; + +enum mei_i915_port { +PORT_NONE =-1 , + +PORT_A =0 , +PORT_B , +PORT_C , +PORT_D , +PORT_E , +PORT_F , +I915_MAX_PORTS , +};#endif /* __MEI_HDCP_H__ */
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
RE: [PATCH v12 24/38] misc/mei/hdcp: Initiate Wired HDCP2.2 Tx Session
Quoted 51 lines
Request ME FW to start the HDCP2.2 session for an intel port. Prepares payloads for command
WIRED_INITIATE_HDCP2_SESSIONand sends to ME FW.On Success, ME FW will start a HDCP2.2 session for the port and provides the content for HDCP2.2
AKE_Initmessage.v2: Rebased.
v3:
cldev is add as a separate parameter [Tomas] Redundant comment and typecast are removed [Tomas]
v4:
%zd is used for size [Alexander]
%s/return -1/return-EIO[Alexander]
Spellings in commit msg is fixed [Uma]
v5: Rebased.
v6:
Collected the rb-ed by.
Realigning the patches in the series.
v7:
Adjust to the new mei interface.
Fix for kdoc.
v8:
K-Doc Addition.
memcpy for const length.
v9:
s/mei_hdcp_ddi/mei_fw_ddi s/i915_port/mei_i915_port [Tomas]
renamed func as mei_hdcp_* [Tomas]
Instead of macro, inline func for ddi index is used. [Tomas]Signed-off-by Ramalingam C <[email protected]>Reviewed-by Uma Shankar <[email protected]>Acked-by Tomas Winkler <[email protected]>--- drivers/misc/mei/hdcp/mei_hdcp.c | 89 ++++++++++++++++++++++++++++++++++++++++ drivers/misc/mei/hdcp/mei_hdcp.h | 23 +++++++++++ 2 files changed, 112 insertions(+)drivers/misc/mei/hdcp/mei_hdcp.c +1
-0@@ -23,6 +23,95 @@#include <linux/slab.h> #include <linux/uuid.h> #include <linux/mei_cl_bus.h> +#include <drm/drm_connector.h>
drivers/misc/mei/hdcp/mei_hdcp.c line 36
Quoted 10 lines
drivers/misc/mei/hdcp/mei_hdcp.c +10
-0+#include <drm/i915_component.h> +#include <drm/i915_mei_hdcp_interface.h> + +#include "mei_hdcp.h" + +static inline u8 mei_get_ddi_index (short int port) { +enum mei_i915_port i915_port = (enum mei_i915_port )port; + +return (u8)(i915_port ==PORT_A ?MEI_DDI_A : i915_port); } +
Still the same code I haven't Acked that patch.
Thanks
Tomas
Quoted 115 lines
drivers/misc/mei/hdcp/mei_hdcp.c +77
-0+/** +* mei_hdcp_initiate_session() - Initiate a Wired HDCP2.2 Tx Session in +ME FW +* @dev: device corresponding to the mei_cl_device +* @hdcp_data: Intel HW specific hdcp data +* @ake_data: AKE_Init msg output. +* +* Return: 0 on Success, <0 on Failure. +*/ +static int +mei_hdcp_initiate_session (struct device *dev,struct hdcp_port_data *data, +struct hdcp2_ake_init *ake_data) +{ +struct wired_cmd_initiate_hdcp2_session_in session_init_in = { {0 } }; +struct wired_cmd_initiate_hdcp2_session_out + session_init_out = { {0 } }; +struct mei_cl_device *cldev; +ssize_t byte; + +if (!dev || !data || !ake_data) +return -EINVAL ; + + cldev =to_mei_cl_device (dev); + + session_init_in.header.api_version =HDCP_API_VERSION ; + session_init_in.header.command_id =WIRED_INITIATE_HDCP2_SESSION ; + session_init_in.header.status =ME_HDCP_STATUS_SUCCESS ; + session_init_in.header.buffer_len = +WIRED_CMD_BUF_LEN_INITIATE_HDCP2_SESSION_IN ; + + session_init_in.port.integrated_port_type = data->port_type; + session_init_in.port.physical_port =mei_get_ddi_index (data->port); + session_init_in.protocol = data->protocol; + + byte =mei_cldev_send (cldev, (u8 *)&session_init_in, +sizeof (session_init_in)); +if (byte <0 ) { +dev_dbg (dev,"mei_cldev_send failed. %zd\n" , byte); +return byte; + } + + byte =mei_cldev_recv (cldev, (u8 *)&session_init_out, +sizeof (session_init_out)); +if (byte <0 ) { +dev_dbg (dev,"mei_cldev_recv failed. %zd\n" , byte); +return byte; + } + +if (session_init_out.header.status !=ME_HDCP_STATUS_SUCCESS ) { +dev_dbg (dev,"ME cmd 0x%08X Failed. Status: 0x%X\n" , +WIRED_INITIATE_HDCP2_SESSION , + session_init_out.header.status); +return -EIO ; + } + + ake_data->msg_id =HDCP_2_2_AKE_INIT ; + ake_data->tx_caps = session_init_out.tx_caps; +memcpy (ake_data->r_tx, session_init_out.r_tx,HDCP_2_2_RTX_LEN ); + +return 0 ; +} + +static __attribute__((unused)) +struct i915_hdcp_component_ops mei_hdcp_ops = { + .owner =THIS_MODULE , + .initiate_hdcp2_session = mei_hdcp_initiate_session, + .verify_receiver_cert_prepare_km =NULL , + .verify_hprime =NULL , + .store_pairing_info =NULL , + .initiate_locality_check =NULL , + .verify_lprime =NULL , + .get_session_key =NULL , + .repeater_check_flow_prepare_ack =NULL , + .verify_mprime =NULL , + .enable_hdcp_authentication =NULL , + .close_hdcp_session =NULL , +}; static int mei_hdcp_probe(struct mei_cl_device *cldev, const struct mei_cl_device_id *id) diff --git
a/drivers/misc/mei/hdcp/mei_hdcp.hb/drivers/misc/mei/hdcp/mei_hdcp.hindex582a7e27ae29..28686f2ae88c100644drivers/misc/mei/hdcp/mei_hdcp.h +23
-1@@ -363,4 +363,27 @@ struct wired_cmd_repeater_auth_stream_req_out { struct hdcp_port_id port; } __packed; +enum mei_fw_ddi { +MEI_DDI_INVALID_PORT =0x0 , + +MEI_DDI_B =1 , +MEI_DDI_C , +MEI_DDI_D , +MEI_DDI_E , +MEI_DDI_F , +MEI_DDI_A =7 , +MEI_DDI_RANGE_END =MEI_DDI_A , +}; + +enum mei_i915_port { +PORT_NONE =-1 , + +PORT_A =0 , +PORT_B , +PORT_C , +PORT_D , +PORT_E , +PORT_F , +I915_MAX_PORTS , +};#endif /* __MEI_HDCP_H__ */ --
Quoted 1 line
2.7.4
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v12 24/38] misc/mei/hdcp: Initiate Wired HDCP2.2 Tx Session
Quoted 53 lines · Tomas
Quoted 53 lines
Request ME FW to start the HDCP2.2 session for an intel port. Prepares payloads for command
WIRED_INITIATE_HDCP2_SESSIONand sends to ME FW.On Success, ME FW will start a HDCP2.2 session for the port and provides the content for HDCP2.2
AKE_Initmessage.v2: Rebased.
v3:
cldev is add as a separate parameter [Tomas] Redundant comment and typecast are removed [Tomas]
v4:
%zd is used for size [Alexander]
%s/return -1/return-EIO[Alexander]
Spellings in commit msg is fixed [Uma]
v5: Rebased.
v6:
Collected the rb-ed by.
Realigning the patches in the series.
v7:
Adjust to the new mei interface.
Fix for kdoc.
v8:
K-Doc Addition.
memcpy for const length.
v9:
s/mei_hdcp_ddi/mei_fw_ddi s/i915_port/mei_i915_port [Tomas]
renamed func as mei_hdcp_* [Tomas]
Instead of macro, inline func for ddi index is used. [Tomas]Signed-off-by Ramalingam C <[email protected]>Reviewed-by Uma Shankar <[email protected]>Acked-by Tomas Winkler <[email protected]>--- drivers/misc/mei/hdcp/mei_hdcp.c | 89 ++++++++++++++++++++++++++++++++++++++++ drivers/misc/mei/hdcp/mei_hdcp.h | 23 +++++++++++ 2 files changed, 112 insertions(+)drivers/misc/mei/hdcp/mei_hdcp.c +4
-0@@ -23,6 +23,95 @@#include <linux/slab.h> #include <linux/uuid.h> #include <linux/mei_cl_bus.h> +#include <drm/drm_connector.h> +#include <drm/i915_component.h> +#include <drm/i915_mei_hdcp_interface.h> +
Quoted 8 lines
drivers/misc/mei/hdcp/mei_hdcp.c line 38
Quoted 7 lines
drivers/misc/mei/hdcp/mei_hdcp.c +7
-0+#include "mei_hdcp.h" + +static inline u8 mei_get_ddi_index (short int port) { +enum mei_i915_port i915_port = (enum mei_i915_port )port; + +return (u8)(i915_port ==PORT_A ?MEI_DDI_A : i915_port); } +Still the same code I haven't Acked that patch.
Sorry. I will remove the ack part.
I prefer this approach as it is not so complicated stuff here. still if you insist I will use switch case.
Thanks
--Ram
Quoted 112 lines
Thanks
TomasQuoted 108 lines
drivers/misc/mei/hdcp/mei_hdcp.c +77
-0+/** +* mei_hdcp_initiate_session() - Initiate a Wired HDCP2.2 Tx Session in +ME FW +* @dev: device corresponding to the mei_cl_device +* @hdcp_data: Intel HW specific hdcp data +* @ake_data: AKE_Init msg output. +* +* Return: 0 on Success, <0 on Failure. +*/ +static int +mei_hdcp_initiate_session (struct device *dev,struct hdcp_port_data *data, +struct hdcp2_ake_init *ake_data) +{ +struct wired_cmd_initiate_hdcp2_session_in session_init_in = { {0 } }; +struct wired_cmd_initiate_hdcp2_session_out + session_init_out = { {0 } }; +struct mei_cl_device *cldev; +ssize_t byte; + +if (!dev || !data || !ake_data) +return -EINVAL ; + + cldev =to_mei_cl_device (dev); + + session_init_in.header.api_version =HDCP_API_VERSION ; + session_init_in.header.command_id =WIRED_INITIATE_HDCP2_SESSION ; + session_init_in.header.status =ME_HDCP_STATUS_SUCCESS ; + session_init_in.header.buffer_len = +WIRED_CMD_BUF_LEN_INITIATE_HDCP2_SESSION_IN ; + + session_init_in.port.integrated_port_type = data->port_type; + session_init_in.port.physical_port =mei_get_ddi_index (data->port); + session_init_in.protocol = data->protocol; + + byte =mei_cldev_send (cldev, (u8 *)&session_init_in, +sizeof (session_init_in)); +if (byte <0 ) { +dev_dbg (dev,"mei_cldev_send failed. %zd\n" , byte); +return byte; + } + + byte =mei_cldev_recv (cldev, (u8 *)&session_init_out, +sizeof (session_init_out)); +if (byte <0 ) { +dev_dbg (dev,"mei_cldev_recv failed. %zd\n" , byte); +return byte; + } + +if (session_init_out.header.status !=ME_HDCP_STATUS_SUCCESS ) { +dev_dbg (dev,"ME cmd 0x%08X Failed. Status: 0x%X\n" , +WIRED_INITIATE_HDCP2_SESSION , + session_init_out.header.status); +return -EIO ; + } + + ake_data->msg_id =HDCP_2_2_AKE_INIT ; + ake_data->tx_caps = session_init_out.tx_caps; +memcpy (ake_data->r_tx, session_init_out.r_tx,HDCP_2_2_RTX_LEN ); + +return 0 ; +} + +static __attribute__((unused)) +struct i915_hdcp_component_ops mei_hdcp_ops = { + .owner =THIS_MODULE , + .initiate_hdcp2_session = mei_hdcp_initiate_session, + .verify_receiver_cert_prepare_km =NULL , + .verify_hprime =NULL , + .store_pairing_info =NULL , + .initiate_locality_check =NULL , + .verify_lprime =NULL , + .get_session_key =NULL , + .repeater_check_flow_prepare_ack =NULL , + .verify_mprime =NULL , + .enable_hdcp_authentication =NULL , + .close_hdcp_session =NULL , +}; static int mei_hdcp_probe(struct mei_cl_device *cldev, const struct mei_cl_device_id *id) diff --git
a/drivers/misc/mei/hdcp/mei_hdcp.hb/drivers/misc/mei/hdcp/mei_hdcp.hindex582a7e27ae29..28686f2ae88c100644drivers/misc/mei/hdcp/mei_hdcp.h +18
-0@@ -363,4 +363,27 @@ struct wired_cmd_repeater_auth_stream_req_out {struct hdcp_port_id port; } __packed; +enum mei_fw_ddi { +MEI_DDI_INVALID_PORT =0x0 , + +MEI_DDI_B =1 , +MEI_DDI_C , +MEI_DDI_D , +MEI_DDI_E , +MEI_DDI_F , +MEI_DDI_A =7 , +MEI_DDI_RANGE_END =MEI_DDI_A , +}; + +enum mei_i915_port { +PORT_NONE =-1 , + +PORT_A =0 , +PORT_B , +PORT_C ,
Quoted 8 lines
Quoted 8 lines
drivers/misc/mei/hdcp/mei_hdcp.h +5
-1+PORT_D , +PORT_E , +PORT_F , + I915_MAX_PORTS, +};#endif /* __MEI_HDCP_H__ */ --2.7.4
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
RE: [PATCH v12 24/38] misc/mei/hdcp: Initiate Wired HDCP2.2 Tx Session
Quoted 64 lines · Tomas
Quoted 2 lines
Quoted 2 lines
Request ME FW to start the HDCP2.2 session for an intel port. Prepares payloads for command
WIRED_INITIATE_HDCP2_SESSIONandsends
Quoted 51 lines
Quoted 51 lines
to ME FW.
On Success, ME FW will start a HDCP2.2 session for the port and provides the content for HDCP2.2
AKE_Initmessage.v2: Rebased.
v3:
cldev is add as a separate parameter [Tomas] Redundant comment and typecast are removed [Tomas]
v4:
%zd is used for size [Alexander]
%s/return -1/return-EIO[Alexander]
Spellings in commit msg is fixed [Uma]
v5: Rebased.
v6:
Collected the rb-ed by.
Realigning the patches in the series.
v7:
Adjust to the new mei interface.
Fix for kdoc.
v8:
K-Doc Addition.
memcpy for const length.
v9:
s/mei_hdcp_ddi/mei_fw_ddi s/i915_port/mei_i915_port [Tomas]
renamed func as mei_hdcp_* [Tomas]
Instead of macro, inline func for ddi index is used. [Tomas]Signed-off-by Ramalingam C <[email protected]>Reviewed-by Uma Shankar <[email protected]>Acked-by Tomas Winkler <[email protected]>--- drivers/misc/mei/hdcp/mei_hdcp.c | 89 ++++++++++++++++++++++++++++++++++++++++ drivers/misc/mei/hdcp/mei_hdcp.h | 23 +++++++++++ 2 files changed, 112 insertions(+)drivers/misc/mei/hdcp/mei_hdcp.c +4
-0@@ -23,6 +23,95 @@#include <linux/slab.h> #include <linux/uuid.h> #include <linux/mei_cl_bus.h> +#include <drm/drm_connector.h> +#include <drm/i915_component.h> +#include <drm/i915_mei_hdcp_interface.h> +Quoted 8 lines
drivers/misc/mei/hdcp/mei_hdcp.c line 38
Quoted 7 lines
drivers/misc/mei/hdcp/mei_hdcp.c +7
-0+#include "mei_hdcp.h" + +static inline u8 mei_get_ddi_index (short int port) { +enum mei_i915_port i915_port = (enum mei_i915_port )port; + +return (u8)(i915_port ==PORT_A ?MEI_DDI_A : i915_port); } +Still the same code I haven't Acked that patch.
Quoted 4 lines
Sorry. I will remove the ack part.
I prefer this approach as it is not so complicated stuff here. still if you insist I will use switch case.
Yes, I believe that the translation should be understood. This function should returns
MEI_DDI_XXX only (it could be u8)
It's by accident that MEI_DDI_B equals PORT_B etc. Please also remove dual enum i915_port and eum port as well. Thanks
Tomas
Quoted 117 lines
Thanks
--RamQuoted 4 lines
Thanks
TomasQuoted 11 lines
drivers/misc/mei/hdcp/mei_hdcp.c
Quoted 11 lines
drivers/misc/mei/hdcp/mei_hdcp.c +11
-0+/** +* mei_hdcp_initiate_session() - Initiate a Wired HDCP2.2 Tx Session +in ME FW +* @dev: device corresponding to the mei_cl_device +* @hdcp_data: Intel HW specific hdcp data +* @ake_data: AKE_Init msg output. +* +* Return: 0 on Success, <0 on Failure. +*/ +static int +mei_hdcp_initiate_session(struct device *dev, struct hdcp_port_data*data,
Quoted 68 lines
Quoted 68 lines
drivers/misc/mei/hdcp/mei_hdcp.c +65
-0+ struct hdcp2_ake_init *ake_data) { +struct wired_cmd_initiate_hdcp2_session_in session_init_in = { {0 } }; +struct wired_cmd_initiate_hdcp2_session_out + session_init_out = { {0 } }; +struct mei_cl_device *cldev; +ssize_t byte; + +if (!dev || !data || !ake_data) +return -EINVAL ; + + cldev =to_mei_cl_device (dev); + + session_init_in.header.api_version =HDCP_API_VERSION ; + session_init_in.header.command_id =WIRED_INITIATE_HDCP2_SESSION ; + session_init_in.header.status =ME_HDCP_STATUS_SUCCESS ; + session_init_in.header.buffer_len = +WIRED_CMD_BUF_LEN_INITIATE_HDCP2_SESSION_IN ; + + session_init_in.port.integrated_port_type = data->port_type; + session_init_in.port.physical_port =mei_get_ddi_index (data->port); + session_init_in.protocol = data->protocol; + + byte =mei_cldev_send (cldev, (u8 *)&session_init_in, +sizeof (session_init_in)); +if (byte <0 ) { +dev_dbg (dev,"mei_cldev_send failed. %zd\n" , byte); +return byte; + } + + byte =mei_cldev_recv (cldev, (u8 *)&session_init_out, +sizeof (session_init_out)); +if (byte <0 ) { +dev_dbg (dev,"mei_cldev_recv failed. %zd\n" , byte); +return byte; + } + +if (session_init_out.header.status !=ME_HDCP_STATUS_SUCCESS ) { +dev_dbg (dev,"ME cmd 0x%08X Failed. Status: 0x%X\n" , +WIRED_INITIATE_HDCP2_SESSION , + session_init_out.header.status); +return -EIO ; + } + + ake_data->msg_id =HDCP_2_2_AKE_INIT ; + ake_data->tx_caps = session_init_out.tx_caps; +memcpy (ake_data->r_tx, session_init_out.r_tx,HDCP_2_2_RTX_LEN ); + +return 0 ; +} + +static __attribute__((unused)) +struct i915_hdcp_component_ops mei_hdcp_ops = { + .owner =THIS_MODULE , + .initiate_hdcp2_session = mei_hdcp_initiate_session, + .verify_receiver_cert_prepare_km =NULL , + .verify_hprime =NULL , + .store_pairing_info =NULL , + .initiate_locality_check =NULL , + .verify_lprime =NULL , + .get_session_key =NULL , + .repeater_check_flow_prepare_ack =NULL , + .verify_mprime =NULL , + .enable_hdcp_authentication =NULL , + .close_hdcp_session =NULL , +};Quoted 7 lines
drivers/misc/mei/hdcp/mei_hdcp.h struct wired_cmd_repeater_auth_stream_req_out
Quoted 7 lines
static int mei_hdcp_probe(struct
mei_cl_device*cldev,
const structmei_cl_device_id*id) diff --gita/drivers/misc/mei/hdcp/mei_hdcp.hb/drivers/misc/mei/hdcp/mei_hdcp.hindex582a7e27ae29..28686f2ae88c100644drivers/misc/mei/hdcp/mei_hdcp.h +0
-0@@ -363,4 +363,27 @@ struct wired_cmd_repeater_auth_stream_req_out{
Quoted 21 lines
Quoted 21 lines
drivers/misc/mei/hdcp/mei_hdcp.h +18
-0struct hdcp_port_id port; } __packed; +enum mei_fw_ddi { +MEI_DDI_INVALID_PORT =0x0 , + +MEI_DDI_B =1 , +MEI_DDI_C , +MEI_DDI_D , +MEI_DDI_E , +MEI_DDI_F , +MEI_DDI_A =7 , +MEI_DDI_RANGE_END =MEI_DDI_A , +}; + +enum mei_i915_port { +PORT_NONE =-1 , + +PORT_A =0 , +PORT_B , +PORT_C ,
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
drivers/misc/mei/hdcp/mei_hdcp.h +5
-1+PORT_D , +PORT_E , +PORT_F , + I915_MAX_PORTS, +};#endif /* __MEI_HDCP_H__ */ --2.7.4
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v12 24/38] misc/mei/hdcp: Initiate Wired HDCP2.2 Tx Session
Quoted 65 lines · Tomas
Quoted 65 lines · Tomas
Quoted 2 lines
Quoted 2 lines
Request ME FW to start the HDCP2.2 session for an intel port. Prepares payloads for command
WIRED_INITIATE_HDCP2_SESSIONandsends
Quoted 51 lines
Quoted 51 lines
to ME FW.
On Success, ME FW will start a HDCP2.2 session for the port and provides the content for HDCP2.2
AKE_Initmessage.v2: Rebased.
v3:
cldev is add as a separate parameter [Tomas] Redundant comment and typecast are removed [Tomas]
v4:
%zd is used for size [Alexander]
%s/return -1/return-EIO[Alexander]
Spellings in commit msg is fixed [Uma]
v5: Rebased.
v6:
Collected the rb-ed by.
Realigning the patches in the series.
v7:
Adjust to the new mei interface.
Fix for kdoc.
v8:
K-Doc Addition.
memcpy for const length.
v9:
s/mei_hdcp_ddi/mei_fw_ddi s/i915_port/mei_i915_port [Tomas]
renamed func as mei_hdcp_* [Tomas]
Instead of macro, inline func for ddi index is used. [Tomas]Signed-off-by Ramalingam C <[email protected]>Reviewed-by Uma Shankar <[email protected]>Acked-by Tomas Winkler <[email protected]>--- drivers/misc/mei/hdcp/mei_hdcp.c | 89 ++++++++++++++++++++++++++++++++++++++++ drivers/misc/mei/hdcp/mei_hdcp.h | 23 +++++++++++ 2 files changed, 112 insertions(+)drivers/misc/mei/hdcp/mei_hdcp.c +4
-0@@ -23,6 +23,95 @@#include <linux/slab.h> #include <linux/uuid.h> #include <linux/mei_cl_bus.h> +#include <drm/drm_connector.h> +#include <drm/i915_component.h> +#include <drm/i915_mei_hdcp_interface.h> +Quoted 8 lines
drivers/misc/mei/hdcp/mei_hdcp.c line 38
Quoted 7 lines
drivers/misc/mei/hdcp/mei_hdcp.c +7
-0+#include "mei_hdcp.h" + +static inline u8 mei_get_ddi_index (short int port) { +enum mei_i915_port i915_port = (enum mei_i915_port )port; + +return (u8)(i915_port ==PORT_A ?MEI_DDI_A : i915_port); } +Still the same code I haven't Acked that patch.
Sorry. I will remove the ack part.
Quoted 7 lines
Quoted 2 lines
I prefer this approach as it is not so complicated stuff here. still if you insist I will use switch case.
Yes, I believe that the translation should be understood. This function should returns
MEI_DDI_XXXonly (it could be u8)
It's by accident thatMEI_DDI_BequalsPORT_Betc. Please also remove dual enumi915_portand eum port as well.
this will do?
static inline u8 mei_get_ddi_index(short int port) {
switch (port) {
case PORT_A:
return (u8)MEI_DDI_A; case PORT_B:
return (u8)MEI_DDI_B; case PORT_C:
return (u8)MEI_DDI_C; case PORT_D:
return (u8)MEI_DDI_D; case PORT_E:
return (u8)MEI_DDI_E; case PORT_F:
return (u8)MEI_DDI_F; default:
return (u8)MEI_DDI_INVALID_PORT; }
}
-Ram
Quoted 119 lines
Thanks
TomasQuoted 116 lines
Thanks
--RamQuoted 4 lines
Thanks
TomasQuoted 11 lines
drivers/misc/mei/hdcp/mei_hdcp.c
Quoted 11 lines
drivers/misc/mei/hdcp/mei_hdcp.c +11
-0+/** +* mei_hdcp_initiate_session() - Initiate a Wired HDCP2.2 Tx Session +in ME FW +* @dev: device corresponding to the mei_cl_device +* @hdcp_data: Intel HW specific hdcp data +* @ake_data: AKE_Init msg output. +* +* Return: 0 on Success, <0 on Failure. +*/ +static int +mei_hdcp_initiate_session(struct device *dev, struct hdcp_port_data*data,
Quoted 68 lines
Quoted 68 lines
drivers/misc/mei/hdcp/mei_hdcp.c +65
-0+ struct hdcp2_ake_init *ake_data) { +struct wired_cmd_initiate_hdcp2_session_in session_init_in = { {0 } }; +struct wired_cmd_initiate_hdcp2_session_out + session_init_out = { {0 } }; +struct mei_cl_device *cldev; +ssize_t byte; + +if (!dev || !data || !ake_data) +return -EINVAL ; + + cldev =to_mei_cl_device (dev); + + session_init_in.header.api_version =HDCP_API_VERSION ; + session_init_in.header.command_id =WIRED_INITIATE_HDCP2_SESSION ; + session_init_in.header.status =ME_HDCP_STATUS_SUCCESS ; + session_init_in.header.buffer_len = +WIRED_CMD_BUF_LEN_INITIATE_HDCP2_SESSION_IN ; + + session_init_in.port.integrated_port_type = data->port_type; + session_init_in.port.physical_port =mei_get_ddi_index (data->port); + session_init_in.protocol = data->protocol; + + byte =mei_cldev_send (cldev, (u8 *)&session_init_in, +sizeof (session_init_in)); +if (byte <0 ) { +dev_dbg (dev,"mei_cldev_send failed. %zd\n" , byte); +return byte; + } + + byte =mei_cldev_recv (cldev, (u8 *)&session_init_out, +sizeof (session_init_out)); +if (byte <0 ) { +dev_dbg (dev,"mei_cldev_recv failed. %zd\n" , byte); +return byte; + } + +if (session_init_out.header.status !=ME_HDCP_STATUS_SUCCESS ) { +dev_dbg (dev,"ME cmd 0x%08X Failed. Status: 0x%X\n" , +WIRED_INITIATE_HDCP2_SESSION , + session_init_out.header.status); +return -EIO ; + } + + ake_data->msg_id =HDCP_2_2_AKE_INIT ; + ake_data->tx_caps = session_init_out.tx_caps; +memcpy (ake_data->r_tx, session_init_out.r_tx,HDCP_2_2_RTX_LEN ); + +return 0 ; +} + +static __attribute__((unused)) +struct i915_hdcp_component_ops mei_hdcp_ops = { + .owner =THIS_MODULE , + .initiate_hdcp2_session = mei_hdcp_initiate_session, + .verify_receiver_cert_prepare_km =NULL , + .verify_hprime =NULL , + .store_pairing_info =NULL , + .initiate_locality_check =NULL , + .verify_lprime =NULL , + .get_session_key =NULL , + .repeater_check_flow_prepare_ack =NULL , + .verify_mprime =NULL , + .enable_hdcp_authentication =NULL , + .close_hdcp_session =NULL , +};Quoted 7 lines
drivers/misc/mei/hdcp/mei_hdcp.h struct wired_cmd_repeater_auth_stream_req_out
Quoted 7 lines
static int mei_hdcp_probe(struct
mei_cl_device*cldev,
const structmei_cl_device_id*id) diff --gita/drivers/misc/mei/hdcp/mei_hdcp.hb/drivers/misc/mei/hdcp/mei_hdcp.hindex582a7e27ae29..28686f2ae88c100644drivers/misc/mei/hdcp/mei_hdcp.h +0
-0@@ -363,4 +363,27 @@ struct wired_cmd_repeater_auth_stream_req_out{
Quoted 21 lines
Quoted 21 lines
drivers/misc/mei/hdcp/mei_hdcp.h +18
-0struct hdcp_port_id port; } __packed; +enum mei_fw_ddi { +MEI_DDI_INVALID_PORT =0x0 , + +MEI_DDI_B =1 , +MEI_DDI_C , +MEI_DDI_D , +MEI_DDI_E , +MEI_DDI_F , +MEI_DDI_A =7 , +MEI_DDI_RANGE_END =MEI_DDI_A , +}; + +enum mei_i915_port { +PORT_NONE =-1 , + +PORT_A =0 , +PORT_B , +PORT_C ,
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
drivers/misc/mei/hdcp/mei_hdcp.h +5
-1+PORT_D , +PORT_E , +PORT_F , + I915_MAX_PORTS, +};#endif /* __MEI_HDCP_H__ */ --2.7.4
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v12 24/38] misc/mei/hdcp: Initiate Wired HDCP2.2 Tx Session
Quoted 89 lines · Tomas
Quoted 65 lines
Quoted 65 lines · Tomas
Quoted 2 lines
Quoted 2 lines
Request ME FW to start the HDCP2.2 session for an intel port. Prepares payloads for command
WIRED_INITIATE_HDCP2_SESSIONandsends
Quoted 51 lines
Quoted 51 lines
to ME FW.
On Success, ME FW will start a HDCP2.2 session for the port and provides the content for HDCP2.2
AKE_Initmessage.v2: Rebased.
v3:
cldev is add as a separate parameter [Tomas] Redundant comment and typecast are removed [Tomas]
v4:
%zd is used for size [Alexander]
%s/return -1/return-EIO[Alexander]
Spellings in commit msg is fixed [Uma]
v5: Rebased.
v6:
Collected the rb-ed by.
Realigning the patches in the series.
v7:
Adjust to the new mei interface.
Fix for kdoc.
v8:
K-Doc Addition.
memcpy for const length.
v9:
s/mei_hdcp_ddi/mei_fw_ddi s/i915_port/mei_i915_port [Tomas]
renamed func as mei_hdcp_* [Tomas]
Instead of macro, inline func for ddi index is used. [Tomas]Signed-off-by Ramalingam C <[email protected]>Reviewed-by Uma Shankar <[email protected]>Acked-by Tomas Winkler <[email protected]>--- drivers/misc/mei/hdcp/mei_hdcp.c | 89 ++++++++++++++++++++++++++++++++++++++++ drivers/misc/mei/hdcp/mei_hdcp.h | 23 +++++++++++ 2 files changed, 112 insertions(+)drivers/misc/mei/hdcp/mei_hdcp.c +4
-0@@ -23,6 +23,95 @@#include <linux/slab.h> #include <linux/uuid.h> #include <linux/mei_cl_bus.h> +#include <drm/drm_connector.h> +#include <drm/i915_component.h> +#include <drm/i915_mei_hdcp_interface.h> +Quoted 8 lines
drivers/misc/mei/hdcp/mei_hdcp.c line 38
Quoted 7 lines
drivers/misc/mei/hdcp/mei_hdcp.c +7
-0+#include "mei_hdcp.h" + +static inline u8 mei_get_ddi_index (short int port) { +enum mei_i915_port i915_port = (enum mei_i915_port )port; + +return (u8)(i915_port ==PORT_A ?MEI_DDI_A : i915_port); } +Still the same code I haven't Acked that patch.
Sorry. I will remove the ack part.
Quoted 7 lines
Quoted 2 lines
I prefer this approach as it is not so complicated stuff here. still if you insist I will use switch case.
Yes, I believe that the translation should be understood. This function should returns
MEI_DDI_XXXonly (it could be u8)
It's by accident thatMEI_DDI_BequalsPORT_Betc. Please also remove dual enumi915_portand eum port as well.this will do?
static inline u8mei_get_ddi_index(short int port){
switch (port) {
casePORT_A:
return (u8)MEI_DDI_A;
casePORT_B:
return (u8)MEI_DDI_B;
casePORT_C:
return (u8)MEI_DDI_C;
casePORT_D:
return (u8)MEI_DDI_D;
Quoted 8 lines
case
PORT_E:
return (u8)MEI_DDI_E; casePORT_F:
return (u8)MEI_DDI_F; default:
return (u8)MEI_DDI_INVALID_PORT; }
}
You can drop (u8)
Quoted 1 line
+ switch (port) {
+ case PORT_A:
+ return MEI_DDI_A;
+ case PORT_B:
+ return MEI_DDI_B;
+ case PORT_C:
+ return MEI_DDI_C;
+ case PORT_D:
+ return MEI_DDI_D;
+ case PORT_E:
+ return MEI_DDI_E;
+ case PORT_F:
+ return MEI_DDI_F;
+ default:
+ return MEI_DDI_INVALID_PORT;
Quoted 107 lines
-Ram
Quoted 91 lines
Thanks
TomasQuoted 88 lines
Thanks
--RamQuoted 4 lines
Thanks
TomasQuoted 12 lines
drivers/misc/mei/hdcp/mei_hdcp.c
Quoted 12 lines
drivers/misc/mei/hdcp/mei_hdcp.c +12
-0+/** +* mei_hdcp_initiate_session() - Initiate a Wired HDCP2.2 Tx +Session in ME FW +* @dev: device corresponding to the mei_cl_device +* @hdcp_data: Intel HW specific hdcp data +* @ake_data: AKE_Init msg output. +* +* Return: 0 on Success, <0 on Failure. +*/ +static int +mei_hdcp_initiate_session (struct device *dev,struct +hdcp_port_data*data,
Quoted 68 lines
Quoted 68 lines
drivers/misc/mei/hdcp/mei_hdcp.c +65
-0+ struct hdcp2_ake_init *ake_data) { +struct wired_cmd_initiate_hdcp2_session_in session_init_in = { {0 } }; +struct wired_cmd_initiate_hdcp2_session_out + session_init_out = { {0 } }; +struct mei_cl_device *cldev; +ssize_t byte; + +if (!dev || !data || !ake_data) +return -EINVAL ; + + cldev =to_mei_cl_device (dev); + + session_init_in.header.api_version =HDCP_API_VERSION ; + session_init_in.header.command_id =WIRED_INITIATE_HDCP2_SESSION ; + session_init_in.header.status =ME_HDCP_STATUS_SUCCESS ; + session_init_in.header.buffer_len = +WIRED_CMD_BUF_LEN_INITIATE_HDCP2_SESSION_IN ; + + session_init_in.port.integrated_port_type = data->port_type; + session_init_in.port.physical_port =mei_get_ddi_index (data->port); + session_init_in.protocol = data->protocol; + + byte =mei_cldev_send (cldev, (u8 *)&session_init_in, +sizeof (session_init_in)); +if (byte <0 ) { +dev_dbg (dev,"mei_cldev_send failed. %zd\n" , byte); +return byte; + } + + byte =mei_cldev_recv (cldev, (u8 *)&session_init_out, +sizeof (session_init_out)); +if (byte <0 ) { +dev_dbg (dev,"mei_cldev_recv failed. %zd\n" , byte); +return byte; + } + +if (session_init_out.header.status !=ME_HDCP_STATUS_SUCCESS ) { +dev_dbg (dev,"ME cmd 0x%08X Failed. Status: 0x%X\n" , +WIRED_INITIATE_HDCP2_SESSION , + session_init_out.header.status); +return -EIO ; + } + + ake_data->msg_id =HDCP_2_2_AKE_INIT ; + ake_data->tx_caps = session_init_out.tx_caps; +memcpy (ake_data->r_tx, session_init_out.r_tx,HDCP_2_2_RTX_LEN ); + +return 0 ; +} + +static __attribute__((unused)) +struct i915_hdcp_component_ops mei_hdcp_ops = { + .owner =THIS_MODULE , + .initiate_hdcp2_session = mei_hdcp_initiate_session, + .verify_receiver_cert_prepare_km =NULL , + .verify_hprime =NULL , + .store_pairing_info =NULL , + .initiate_locality_check =NULL , + .verify_lprime =NULL , + .get_session_key =NULL , + .repeater_check_flow_prepare_ack =NULL , + .verify_mprime =NULL , + .enable_hdcp_authentication =NULL , + .close_hdcp_session =NULL , +};Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
drivers/misc/mei/hdcp/mei_hdcp.h struct
Quoted 8 lines
static int mei_hdcp_probe(struct
mei_cl_device*cldev,
const structmei_cl_device_id*id) diff --gita/drivers/misc/mei/hdcp/mei_hdcp.hb/drivers/misc/mei/hdcp/mei_hdcp.h
index582a7e27ae29..28686f2ae88c100644drivers/misc/mei/hdcp/mei_hdcp.h +0
-0@@ -363,4 +363,27 @@ struct
wired_cmd_repeater_auth_stream_req_outQuoted 4 lines
Quoted 4 lines
{
Quoted 3 lines
Quoted 3 lines
drivers/misc/mei/hdcp/mei_hdcp.h +0
-0struct hdcp_port_id port; } __packed;
Quoted 13 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
drivers/misc/mei/hdcp/mei_hdcp.h +5
-0+enum mei_fw_ddi { +MEI_DDI_INVALID_PORT =0x0 , + +MEI_DDI_B =1 , +MEI_DDI_C ,Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
drivers/misc/mei/hdcp/mei_hdcp.h struct wired_cmd_repeater_auth_stream_req_out { · line 378
Quoted 8 lines
drivers/misc/mei/hdcp/mei_hdcp.h +8
-0+MEI_DDI_D , +MEI_DDI_E , +MEI_DDI_F , +MEI_DDI_A =7 , + MEI_DDI_RANGE_END = MEI_DDI_A, +}; + +enum mei_i915_port {
This doesn't belong to here, this is defined twice and it's i915 not HDCP FW enum
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
drivers/misc/mei/hdcp/mei_hdcp.h struct wired_cmd_repeater_auth_stream_req_out { · line 379
Quoted 1 line
drivers/misc/mei/hdcp/mei_hdcp.h +1
-0+ PORT_NONE = -1,
Please note that you are using a negative value here why you are casting it to u16, maybe 0xFFFFFF will be better.
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
drivers/misc/mei/hdcp/mei_hdcp.h struct wired_cmd_repeater_auth_stream_req_out { · line 388
Quoted 9 lines
drivers/misc/mei/hdcp/mei_hdcp.h +9
-0+ +PORT_A =0 , +PORT_B , +PORT_C , +PORT_D , +PORT_E , +PORT_F , + I915_MAX_PORTS, +};
This should be put from drivers/gpu/drm/i915/intel_display.h Into include/drm/intel_<someheader>.h
Together with the port_name() macro
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
drivers/misc/mei/hdcp/mei_hdcp.h +0
-1#endif /* __MEI_HDCP_H__ */ --2.7.4
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v13 24/38 misc/mei/hdcp: Initiate Wired HDCP2.2 Tx Session
In reply to Ramalingam CRequest ME FW to start the HDCP2.2 session for an intel port. Prepares payloads for command WIRED_INITIATE_HDCP2_SESSION and sends to ME FW.
On Success, ME FW will start a HDCP2.2 session for the port and provides the content for HDCP2.2 AKE_Init message.
v2: Rebased.
v3:
cldev is add as a separate parameter [Tomas]
Redundant comment and typecast are removed [Tomas]
v4:
%zd is used for size [Alexander]
%s/return -1/return -EIO [Alexander]
Spellings in commit msg is fixed [Uma]
v5: Rebased.
v6:
Collected the rb-ed by.
Realigning the patches in the series.
v7:
Adjust to the new mei interface.
Fix for kdoc.
v8:
K-Doc Addition.
memcpy for const length.
v9:
s/mei_hdcp_ddi/mei_fw_ddi
s/i915_port/mei_i915_port [Tomas]
renamed func as mei_hdcp_* [Tomas]
Instead of macro, inline func for ddi index is used. [Tomas]
v10:
Switch case for the coversion between i915_port to mei_ddi [Tomas]
--- drivers/misc/mei/hdcp/mei_hdcp.c | 102 +++++++++++++++++++++++++++++++++++++++ drivers/misc/mei/hdcp/mei_hdcp.h | 23 +++++++++ 2 files changed, 125 insertions(+)
drivers/misc/mei/hdcp/mei_hdcp.c +102 -0
@@ -23,6 +23,108 @@#include <linux/slab.h> #include <linux/uuid.h> #include <linux/mei_cl_bus.h> +#include <drm/drm_connector.h> +#include <drm/i915_component.h> +#include <drm/i915_mei_hdcp_interface.h> + +#include "mei_hdcp.h" + +static inline u8 mei_get_ddi_index (short int port) +{ +switch (port) { +case PORT_A : +return MEI_DDI_A ; +case PORT_B : +return MEI_DDI_B ; +case PORT_C : +return MEI_DDI_C ; +case PORT_D : +return MEI_DDI_D ; +case PORT_E : +return MEI_DDI_E ; +case PORT_F : +return MEI_DDI_F ; +default : +return MEI_DDI_INVALID_PORT ; + } +} + +/** +* mei_hdcp_initiate_session() - Initiate a Wired HDCP2.2 Tx Session in ME FW +* @dev: device corresponding to the mei_cl_device +* @hdcp_data: Intel HW specific hdcp data +* @ake_data: AKE_Init msg output. +* +* Return: 0 on Success, <0 on Failure. +*/ +static int +mei_hdcp_initiate_session (struct device *dev,struct hdcp_port_data *data, +struct hdcp2_ake_init *ake_data) +{ +struct wired_cmd_initiate_hdcp2_session_in session_init_in = { {0 } }; +struct wired_cmd_initiate_hdcp2_session_out + session_init_out = { {0 } }; +struct mei_cl_device *cldev; +ssize_t byte; + +if (!dev || !data || !ake_data) +return -EINVAL ; + + cldev =to_mei_cl_device (dev); + + session_init_in.header.api_version =HDCP_API_VERSION ; + session_init_in.header.command_id =WIRED_INITIATE_HDCP2_SESSION ; + session_init_in.header.status =ME_HDCP_STATUS_SUCCESS ; + session_init_in.header.buffer_len = +WIRED_CMD_BUF_LEN_INITIATE_HDCP2_SESSION_IN ; + + session_init_in.port.integrated_port_type = data->port_type; + session_init_in.port.physical_port =mei_get_ddi_index (data->port); + session_init_in.protocol = data->protocol; + + byte =mei_cldev_send (cldev, (u8 *)&session_init_in, +sizeof (session_init_in)); +if (byte <0 ) { +dev_dbg (dev,"mei_cldev_send failed. %zd\n" , byte); +return byte; + } + + byte =mei_cldev_recv (cldev, (u8 *)&session_init_out, +sizeof (session_init_out)); +if (byte <0 ) { +dev_dbg (dev,"mei_cldev_recv failed. %zd\n" , byte); +return byte; + } + +if (session_init_out.header.status !=ME_HDCP_STATUS_SUCCESS ) { +dev_dbg (dev,"ME cmd 0x%08X Failed. Status: 0x%X\n" , +WIRED_INITIATE_HDCP2_SESSION , + session_init_out.header.status); +return -EIO ; + } + + ake_data->msg_id =HDCP_2_2_AKE_INIT ; + ake_data->tx_caps = session_init_out.tx_caps; +memcpy (ake_data->r_tx, session_init_out.r_tx,HDCP_2_2_RTX_LEN ); + +return 0 ; +} + +static __attribute__((unused)) +struct i915_hdcp_component_ops mei_hdcp_ops = { + .owner =THIS_MODULE , + .initiate_hdcp2_session = mei_hdcp_initiate_session, + .verify_receiver_cert_prepare_km =NULL , + .verify_hprime =NULL , + .store_pairing_info =NULL , + .initiate_locality_check =NULL , + .verify_lprime =NULL , + .get_session_key =NULL , + .repeater_check_flow_prepare_ack =NULL , + .verify_mprime =NULL , + .enable_hdcp_authentication =NULL , + .close_hdcp_session =NULL , +};static int mei_hdcp_probe (struct mei_cl_device *cldev,const struct mei_cl_device_id *id)
drivers/misc/mei/hdcp/mei_hdcp.h +23 -0
@@ -363,4 +363,27 @@ struct wired_cmd_repeater_auth_stream_req_out { struct hdcp_port_id port; } __packed; +enum mei_fw_ddi { +MEI_DDI_INVALID_PORT =0x0 , + +MEI_DDI_B =1 , +MEI_DDI_C , +MEI_DDI_D , +MEI_DDI_E , +MEI_DDI_F , +MEI_DDI_A =7 , +MEI_DDI_RANGE_END =MEI_DDI_A , +}; + +enum mei_i915_port { +PORT_NONE =-1 , + +PORT_A =0 , +PORT_B , +PORT_C , +PORT_D , +PORT_E , +PORT_F , +I915_MAX_PORTS , +};#endif /* __MEI_HDCP_H__ */
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v12 25/38 misc/mei/hdcp: Verify Receiver Cert and prepare km
In reply to Ramalingam CRequests for verification for receiver certification and also the preparation for next AKE auth message with km.
On Success ME FW validate the HDCP2.2 receivers certificate and do the revocation check on the receiver ID. AKE_Stored_Km will be prepared if the receiver is already paired, else AKE_No_Stored_Km will be prepared.
Here AKE_Stored_Km and AKE_No_Stored_Km are HDCP2.2 protocol msgs.
v2: Rebased.
v3:
cldev is passed as first parameter [Tomas] Redundant comments and cast are removed [Tomas]
v4:
%zd is used for ssize_t [Alexander] %s/return -1/return -EIO [Alexander]
v5: Rebased.
v6:
Collected the Rb-ed by.
Rebasing.
v7:
Adjust to the new mei interface.
Fix for Kdoc.
v8:
K-Doc Addition. [Tomas]
memcpy for const length.
v9:
renamed func as mei_hdcp_* [Tomas] Inline function is defined for DDI index [Tomas]
v10:
Fixed the conversion of u8 to bool [Tomas]
--- drivers/misc/mei/hdcp/mei_hdcp.c | 83 +++++++++++++++++++++++++++++++++++++++- 1 file changed, 82 insertions(+), 1 deletion(-)
drivers/misc/mei/hdcp/mei_hdcp.c +82 -1
@@ -97,11 +97,92 @@ mei_hdcp_initiate_session(struct device *dev, struct hdcp_port_data *data,return 0 ; } +/** +* mei_hdcp_verify_receiver_cert_prepare_km() - Verify the Receiver Certificate +* AKE_Send_Cert and prepare AKE_Stored_Km/AKE_No_Stored_Km +* @dev: device corresponding to the mei_cl_device +* @hdcp_data: Intel HW specific hdcp data +* @rx_cert: AKE_Send_Cert for verification +* @km_stored: Pairing status flag output +* @ek_pub_km: AKE_Stored_Km/AKE_No_Stored_Km output msg +* @msg_sz : size of AKE_XXXXX_Km output msg +* +* Return: 0 on Success, <0 on Failure +*/ +static int +mei_hdcp_verify_receiver_cert_prepare_km (struct device *dev, +struct hdcp_port_data *data, +struct hdcp2_ake_send_cert *rx_cert, +bool *km_stored, +struct hdcp2_ake_no_stored_km + *ek_pub_km, +size_t *msg_sz) +{ +struct wired_cmd_verify_receiver_cert_in verify_rxcert_in = { {0 } }; +struct wired_cmd_verify_receiver_cert_out verify_rxcert_out = { {0 } }; +struct mei_cl_device *cldev; +ssize_t byte; + +if (!dev || !data || !rx_cert || !km_stored || !ek_pub_km || !msg_sz) +return -EINVAL ; + + cldev =to_mei_cl_device (dev); + + verify_rxcert_in.header.api_version =HDCP_API_VERSION ; + verify_rxcert_in.header.command_id =WIRED_VERIFY_RECEIVER_CERT ; + verify_rxcert_in.header.status =ME_HDCP_STATUS_SUCCESS ; + verify_rxcert_in.header.buffer_len = +WIRED_CMD_BUF_LEN_VERIFY_RECEIVER_CERT_IN ; + + verify_rxcert_in.port.integrated_port_type = data->port_type; + verify_rxcert_in.port.physical_port =mei_get_ddi_index (data->port); + + verify_rxcert_in.cert_rx = rx_cert->cert_rx; +memcpy (verify_rxcert_in.r_rx, &rx_cert->r_rx,HDCP_2_2_RRX_LEN ); +memcpy (verify_rxcert_in.rx_caps, rx_cert->rx_caps,HDCP_2_2_RXCAPS_LEN ); + + byte =mei_cldev_send (cldev, (u8 *)&verify_rxcert_in, +sizeof (verify_rxcert_in)); +if (byte <0 ) { +dev_dbg (dev,"mei_cldev_send failed: %zd\n" , byte); +return byte; + } + + byte =mei_cldev_recv (cldev, (u8 *)&verify_rxcert_out, +sizeof (verify_rxcert_out)); +if (byte <0 ) { +dev_dbg (dev,"mei_cldev_recv failed: %zd\n" , byte); +return byte; + } + +if (verify_rxcert_out.header.status !=ME_HDCP_STATUS_SUCCESS ) { +dev_dbg (dev,"ME cmd 0x%08X Failed. Status: 0x%X\n" , +WIRED_VERIFY_RECEIVER_CERT , + verify_rxcert_out.header.status); +return -EIO ; + } + + *km_stored = !!verify_rxcert_out.km_stored; +if (verify_rxcert_out.km_stored) { + ek_pub_km->msg_id =HDCP_2_2_AKE_STORED_KM ; + *msg_sz =sizeof (struct hdcp2_ake_stored_km ); + }else { + ek_pub_km->msg_id =HDCP_2_2_AKE_NO_STORED_KM ; + *msg_sz =sizeof (struct hdcp2_ake_no_stored_km ); + } + +memcpy (ek_pub_km->e_kpub_km, &verify_rxcert_out.ekm_buff, +sizeof (verify_rxcert_out.ekm_buff)); + +return 0 ; +} +static __attribute__((unused))struct i915_hdcp_component_ops mei_hdcp_ops = { .owner =THIS_MODULE , .initiate_hdcp2_session = mei_hdcp_initiate_session, - .verify_receiver_cert_prepare_km =NULL , + .verify_receiver_cert_prepare_km = + mei_hdcp_verify_receiver_cert_prepare_km, .verify_hprime =NULL , .store_pairing_info =NULL , .initiate_locality_check =NULL ,
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v12 26/38 misc/mei/hdcp: Verify H_prime
In reply to Ramalingam CRequests for the verification of AKE_Send_H_prime.
ME will calculate the H and comparing it with received H_Prime. The result will be returned as status.
Here AKE_Send_H_prime is a HDCP2.2 Authentication msg.
v2: Rebased.
v3:
cldev is passed as first parameter [Tomas] Redundant comments and cast are removed [Tomas]
v4:
%zd for ssize_t [Alexander]
%s/return -1/return -EIO [Alexander] Styles and typos fixed [Uma]
v5: Rebased.
v6:
Collected the Rb-ed by.
Rebasing.
v7:
Adjust to the new mei interface.
Fix for Kdoc.
v8:
K-Doc Addition [Tomas]
memcpy for const length.
v9:
renamed func as mei_hdcp_* [Tomas] Inline function is defined for DDI index [Tomas]
--- drivers/misc/mei/hdcp/mei_hdcp.c | 58 +++++++++++++++++++++++++++++++++++++++- 1 file changed, 57 insertions(+), 1 deletion(-)
drivers/misc/mei/hdcp/mei_hdcp.c +57 -1
@@ -177,13 +177,69 @@ mei_hdcp_verify_receiver_cert_prepare_km(struct device *dev,return 0 ; } +/** +* mei_hdcp_verify_hprime() - Verify AKE_Send_H_prime at ME FW. +* @dev: device corresponding to the mei_cl_device +* @hdcp_data: Intel HW specific hdcp data +* @rx_hprime: AKE_Send_H_prime msg for ME FW verification +* +* Return: 0 on Success, <0 on Failure +*/ +static int +mei_hdcp_verify_hprime (struct device *dev,struct hdcp_port_data *data, +struct hdcp2_ake_send_hprime *rx_hprime) +{ +struct wired_cmd_ake_send_hprime_in send_hprime_in = { {0 } }; +struct wired_cmd_ake_send_hprime_out send_hprime_out = { {0 } }; +struct mei_cl_device *cldev; +ssize_t byte; + +if (!dev || !data || !rx_hprime) +return -EINVAL ; + + cldev =to_mei_cl_device (dev); + + send_hprime_in.header.api_version =HDCP_API_VERSION ; + send_hprime_in.header.command_id =WIRED_AKE_SEND_HPRIME ; + send_hprime_in.header.status =ME_HDCP_STATUS_SUCCESS ; + send_hprime_in.header.buffer_len =WIRED_CMD_BUF_LEN_AKE_SEND_HPRIME_IN ; + + send_hprime_in.port.integrated_port_type = data->port_type; + send_hprime_in.port.physical_port =mei_get_ddi_index (data->port); + +memcpy (send_hprime_in.h_prime, rx_hprime->h_prime, +HDCP_2_2_H_PRIME_LEN ); + + byte =mei_cldev_send (cldev, (u8 *)&send_hprime_in, +sizeof (send_hprime_in)); +if (byte <0 ) { +dev_dbg (dev,"mei_cldev_send failed. %zd\n" , byte); +return byte; + } + + byte =mei_cldev_recv (cldev, (u8 *)&send_hprime_out, +sizeof (send_hprime_out)); +if (byte <0 ) { +dev_dbg (dev,"mei_cldev_recv failed. %zd\n" , byte); +return byte; + } + +if (send_hprime_out.header.status !=ME_HDCP_STATUS_SUCCESS ) { +dev_dbg (dev,"ME cmd 0x%08X Failed. Status: 0x%X\n" , +WIRED_AKE_SEND_HPRIME , send_hprime_out.header.status); +return -EIO ; + } + +return 0 ; +} +static __attribute__((unused))struct i915_hdcp_component_ops mei_hdcp_ops = { .owner =THIS_MODULE , .initiate_hdcp2_session = mei_hdcp_initiate_session, .verify_receiver_cert_prepare_km = mei_hdcp_verify_receiver_cert_prepare_km, - .verify_hprime =NULL , + .verify_hprime = mei_hdcp_verify_hprime, .store_pairing_info =NULL , .initiate_locality_check =NULL , .verify_lprime =NULL ,
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v12 27/38 misc/mei/hdcp: Store the HDCP Pairing info
In reply to Ramalingam CProvides Pairing info to ME to store.
Pairing is a process to fast track the subsequent authentication with the same HDCP sink.
On Success, received HDCP pairing info is stored in non-volatile memory of ME.
v2: Rebased.
v3:
cldev is passed as first parameter [Tomas] Redundant comments and cast are removed [Tomas]
v4:
%zd for ssize_t [Alexander]
%s/return -1/return -EIO [Alexander] Style fixed [Uma]
v5: Rebased.
v6:
Collected the Rb-ed by.
Rebasing.
v7:
Adjust to the new mei interface.
Fix for Kdoc.
v8:
K-Doc addition. [Tomas]
memcpy for const length.
v9:
renamed func as mei_hdcp_* [Tomas] Inline function is defined for DDI index [Tomas]
--- drivers/misc/mei/hdcp/mei_hdcp.c | 60 +++++++++++++++++++++++++++++++++++++++- 1 file changed, 59 insertions(+), 1 deletion(-)
drivers/misc/mei/hdcp/mei_hdcp.c +59 -1
@@ -233,6 +233,64 @@ mei_hdcp_verify_hprime(struct device *dev, struct hdcp_port_data *data,return 0 ; } +/** +* mei_hdcp_store_pairing_info() - Store pairing info received at ME FW +* @dev: device corresponding to the mei_cl_device +* @hdcp_data: Intel HW specific hdcp data +* @pairing_info: AKE_Send_Pairing_Info msg input to ME FW +* +* Return: 0 on Success, <0 on Failure +*/ +static int +mei_hdcp_store_pairing_info (struct device *dev,struct hdcp_port_data *data, +struct hdcp2_ake_send_pairing_info *pairing_info) +{ +struct wired_cmd_ake_send_pairing_info_in pairing_info_in = { {0 } }; +struct wired_cmd_ake_send_pairing_info_out pairing_info_out = { {0 } }; +struct mei_cl_device *cldev; +ssize_t byte; + +if (!dev || !data || !pairing_info) +return -EINVAL ; + + cldev =to_mei_cl_device (dev); + + pairing_info_in.header.api_version =HDCP_API_VERSION ; + pairing_info_in.header.command_id =WIRED_AKE_SEND_PAIRING_INFO ; + pairing_info_in.header.status =ME_HDCP_STATUS_SUCCESS ; + pairing_info_in.header.buffer_len = +WIRED_CMD_BUF_LEN_SEND_PAIRING_INFO_IN ; + + pairing_info_in.port.integrated_port_type = data->port_type; + pairing_info_in.port.physical_port =mei_get_ddi_index (data->port); + +memcpy (pairing_info_in.e_kh_km, pairing_info->e_kh_km, +HDCP_2_2_E_KH_KM_LEN ); + + byte =mei_cldev_send (cldev, (u8 *)&pairing_info_in, +sizeof (pairing_info_in)); +if (byte <0 ) { +dev_dbg (dev,"mei_cldev_send failed. %zd\n" , byte); +return byte; + } + + byte =mei_cldev_recv (cldev, (u8 *)&pairing_info_out, +sizeof (pairing_info_out)); +if (byte <0 ) { +dev_dbg (dev,"mei_cldev_recv failed. %zd\n" , byte); +return byte; + } + +if (pairing_info_out.header.status !=ME_HDCP_STATUS_SUCCESS ) { +dev_dbg (dev,"ME cmd 0x%08X failed. Status: 0x%X\n" , +WIRED_AKE_SEND_PAIRING_INFO , + pairing_info_out.header.status); +return -EIO ; + } + +return 0 ; +} +static __attribute__((unused))struct i915_hdcp_component_ops mei_hdcp_ops = { .owner =THIS_MODULE ,
@@ -240,7 +298,7 @@ struct i915_hdcp_component_ops mei_hdcp_ops = { .verify_receiver_cert_prepare_km = mei_hdcp_verify_receiver_cert_prepare_km, .verify_hprime = mei_hdcp_verify_hprime, - .store_pairing_info = NULL, + .store_pairing_info = mei_hdcp_store_pairing_info, .initiate_locality_check = NULL, .verify_lprime = NULL, .get_session_key = NULL,
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v12 28/38 misc/mei/hdcp: Initiate Locality check
In reply to Ramalingam CRequests ME to start the second stage of HDCP2.2 authentication, called Locality Check.
On Success, ME FW will provide LC_Init message to send to hdcp sink.
v2: Rebased.
v3:
cldev is passed as first parameter [Tomas] Redundant comments and cast are removed [Tomas]
v4:
%zd used for ssize_t [Alexander] %s/return -1/return -EIO [Alexander] Style fixed [Uma]
v5: Rebased.
v6:
Collected the Rb-ed by.
Rebasing.
v7:
Adjust to the new mei interface.
Fix for Kdoc.
v8:
K-Doc addition. [Tomas]
v9:
renamed func as mei_hdcp_* [Tomas] Inline function is defined for DDI index [Tomas]
--- drivers/misc/mei/hdcp/mei_hdcp.c | 57 +++++++++++++++++++++++++++++++++++++++- 1 file changed, 56 insertions(+), 1 deletion(-)
drivers/misc/mei/hdcp/mei_hdcp.c +56 -1
@@ -291,6 +291,61 @@ mei_hdcp_store_pairing_info(struct device *dev, struct hdcp_port_data *data,return 0 ; } +/** +* mei_hdcp_initiate_locality_check() - Prepare LC_Init +* @dev: device corresponding to the mei_cl_device +* @hdcp_data: Intel HW specific hdcp data +* @lc_init_data: LC_Init msg output +* +* Return: 0 on Success, <0 on Failure +*/ +static int +mei_hdcp_initiate_locality_check (struct device *dev, +struct hdcp_port_data *data, +struct hdcp2_lc_init *lc_init_data) +{ +struct wired_cmd_init_locality_check_in lc_init_in = { {0 } }; +struct wired_cmd_init_locality_check_out lc_init_out = { {0 } }; +struct mei_cl_device *cldev; +ssize_t byte; + +if (!dev || !data || !lc_init_data) +return -EINVAL ; + + cldev =to_mei_cl_device (dev); + + lc_init_in.header.api_version =HDCP_API_VERSION ; + lc_init_in.header.command_id =WIRED_INIT_LOCALITY_CHECK ; + lc_init_in.header.status =ME_HDCP_STATUS_SUCCESS ; + lc_init_in.header.buffer_len =WIRED_CMD_BUF_LEN_INIT_LOCALITY_CHECK_IN ; + + lc_init_in.port.integrated_port_type = data->port_type; + lc_init_in.port.physical_port =mei_get_ddi_index (data->port); + + byte =mei_cldev_send (cldev, (u8 *)&lc_init_in,sizeof (lc_init_in)); +if (byte <0 ) { +dev_dbg (dev,"mei_cldev_send failed. %zd\n" , byte); +return byte; + } + + byte =mei_cldev_recv (cldev, (u8 *)&lc_init_out,sizeof (lc_init_out)); +if (byte <0 ) { +dev_dbg (dev,"mei_cldev_recv failed. %zd\n" , byte); +return byte; + } + +if (lc_init_out.header.status !=ME_HDCP_STATUS_SUCCESS ) { +dev_dbg (dev,"ME cmd 0x%08X Failed. status: 0x%X\n" , +WIRED_INIT_LOCALITY_CHECK , lc_init_out.header.status); +return -EIO ; + } + + lc_init_data->msg_id =HDCP_2_2_LC_INIT ; +memcpy (lc_init_data->r_n, lc_init_out.r_n,HDCP_2_2_RN_LEN ); + +return 0 ; +} +static __attribute__((unused))struct i915_hdcp_component_ops mei_hdcp_ops = { .owner =THIS_MODULE ,
@@ -299,7 +354,7 @@ struct i915_hdcp_component_ops mei_hdcp_ops = { mei_hdcp_verify_receiver_cert_prepare_km, .verify_hprime = mei_hdcp_verify_hprime, .store_pairing_info = mei_hdcp_store_pairing_info, - .initiate_locality_check = NULL, + .initiate_locality_check = mei_hdcp_initiate_locality_check, .verify_lprime = NULL, .get_session_key = NULL, .repeater_check_flow_prepare_ack = NULL,
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v12 29/38 misc/mei/hdcp: Verify L_prime
In reply to Ramalingam CRequest to ME to verify the LPrime received from HDCP sink.
On Success, ME FW will verify the received Lprime by calculating and comparing with L.
This represents the completion of Locality Check.
v2: Rebased.
v3:
cldev is passed as first parameter [Tomas] Redundant comments and cast are removed [Tomas]
v4:
%zd for ssize_t [Alexander]
%s/return -1/return -EIO [Alexander] Style fixed [Uma]
v5: Rebased.
v6:
Collected the Rb-ed by.
Rebasing.
v7:
Adjust to the new mei interface.
Fix for Kdoc.
v8:
K-Doc addition. [Tomas]
memcpy for const length.
v9:
renamed func as mei_hdcp_* [Tomas] Inline function is defined for DDI index [Tomas]
--- drivers/misc/mei/hdcp/mei_hdcp.c | 60 +++++++++++++++++++++++++++++++++++++++- 1 file changed, 59 insertions(+), 1 deletion(-)
drivers/misc/mei/hdcp/mei_hdcp.c +59 -1
@@ -346,6 +346,64 @@ mei_hdcp_initiate_locality_check(struct device *dev,return 0 ; } +/** +* mei_hdcp_verify_lprime() - Verify lprime. +* @dev: device corresponding to the mei_cl_device +* @hdcp_data: Intel HW specific hdcp data +* @rx_lprime: LC_Send_L_prime msg for ME FW verification +* +* Return: 0 on Success, <0 on Failure +*/ +static int +mei_hdcp_verify_lprime (struct device *dev,struct hdcp_port_data *data, +struct hdcp2_lc_send_lprime *rx_lprime) +{ +struct wired_cmd_validate_locality_in verify_lprime_in = { {0 } }; +struct wired_cmd_validate_locality_out verify_lprime_out = { {0 } }; +struct mei_cl_device *cldev; +ssize_t byte; + +if (!dev || !data || !rx_lprime) +return -EINVAL ; + + cldev =to_mei_cl_device (dev); + + verify_lprime_in.header.api_version =HDCP_API_VERSION ; + verify_lprime_in.header.command_id =WIRED_VALIDATE_LOCALITY ; + verify_lprime_in.header.status =ME_HDCP_STATUS_SUCCESS ; + verify_lprime_in.header.buffer_len = +WIRED_CMD_BUF_LEN_VALIDATE_LOCALITY_IN ; + + verify_lprime_in.port.integrated_port_type = data->port_type; + verify_lprime_in.port.physical_port =mei_get_ddi_index (data->port); + +memcpy (verify_lprime_in.l_prime, rx_lprime->l_prime, +HDCP_2_2_L_PRIME_LEN ); + + byte =mei_cldev_send (cldev, (u8 *)&verify_lprime_in, +sizeof (verify_lprime_in)); +if (byte <0 ) { +dev_dbg (dev,"mei_cldev_send failed. %zd\n" , byte); +return byte; + } + + byte =mei_cldev_recv (cldev, (u8 *)&verify_lprime_out, +sizeof (verify_lprime_out)); +if (byte <0 ) { +dev_dbg (dev,"mei_cldev_recv failed. %zd\n" , byte); +return byte; + } + +if (verify_lprime_out.header.status !=ME_HDCP_STATUS_SUCCESS ) { +dev_dbg (dev,"ME cmd 0x%08X failed. status: 0x%X\n" , +WIRED_VALIDATE_LOCALITY , + verify_lprime_out.header.status); +return -EIO ; + } + +return 0 ; +} +static __attribute__((unused))struct i915_hdcp_component_ops mei_hdcp_ops = { .owner =THIS_MODULE ,
@@ -355,7 +413,7 @@ struct i915_hdcp_component_ops mei_hdcp_ops = { .verify_hprime = mei_hdcp_verify_hprime, .store_pairing_info = mei_hdcp_store_pairing_info, .initiate_locality_check = mei_hdcp_initiate_locality_check, - .verify_lprime = NULL, + .verify_lprime = mei_hdcp_verify_lprime, .get_session_key = NULL, .repeater_check_flow_prepare_ack = NULL, .verify_mprime = NULL,
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v12 30/38 misc/mei/hdcp: Prepare Session Key
In reply to Ramalingam CRequest to ME to prepare the encrypted session key.
On Success, ME provides Encrypted session key. Function populates the HDCP2.2 authentication msg SKE_Send_Eks.
v2: Rebased.
v3:
cldev is passed as first parameter [Tomas] Redundant comments and cast are removed [Tomas]
v4:
%zd for ssize_t [Alexander]
%s/return -1/return -EIO [Alexander] Style fixed [Uma]
v5: Rebased.
v6:
Collected the Rb-ed by.
Rebasing.
v7:
Adjust to the new mei interface.
Fix for Kdoc.
v8:
K-Doc addition. [Tomas]
v9:
renamed func as mei_hdcp_* [Tomas] Inline function is defined for DDI index [Tomas]
--- drivers/misc/mei/hdcp/mei_hdcp.c | 59 +++++++++++++++++++++++++++++++++++++++- 1 file changed, 58 insertions(+), 1 deletion(-)
drivers/misc/mei/hdcp/mei_hdcp.c +58 -1
@@ -404,6 +404,63 @@ mei_hdcp_verify_lprime(struct device *dev, struct hdcp_port_data *data,return 0 ; } +/** +* mei_hdcp_get_session_key() - Prepare SKE_Send_Eks. +* @dev: device corresponding to the mei_cl_device +* @hdcp_data: Intel HW specific hdcp data +* @ske_data: SKE_Send_Eks msg output from ME FW. +* +* Return: 0 on Success, <0 on Failure +*/ +static int mei_hdcp_get_session_key (struct device *dev, +struct hdcp_port_data *data, +struct hdcp2_ske_send_eks *ske_data) +{ +struct wired_cmd_get_session_key_in get_skey_in = { {0 } }; +struct wired_cmd_get_session_key_out get_skey_out = { {0 } }; +struct mei_cl_device *cldev; +ssize_t byte; + +if (!dev || !data || !ske_data) +return -EINVAL ; + + cldev =to_mei_cl_device (dev); + + get_skey_in.header.api_version =HDCP_API_VERSION ; + get_skey_in.header.command_id =WIRED_GET_SESSION_KEY ; + get_skey_in.header.status =ME_HDCP_STATUS_SUCCESS ; + get_skey_in.header.buffer_len =WIRED_CMD_BUF_LEN_GET_SESSION_KEY_IN ; + + get_skey_in.port.integrated_port_type = data->port_type; + get_skey_in.port.physical_port =mei_get_ddi_index (data->port); + + byte =mei_cldev_send (cldev, (u8 *)&get_skey_in,sizeof (get_skey_in)); +if (byte <0 ) { +dev_dbg (dev,"mei_cldev_send failed. %zd\n" , byte); +return byte; + } + + byte =mei_cldev_recv (cldev, (u8 *)&get_skey_out,sizeof (get_skey_out)); + +if (byte <0 ) { +dev_dbg (dev,"mei_cldev_recv failed. %zd\n" , byte); +return byte; + } + +if (get_skey_out.header.status !=ME_HDCP_STATUS_SUCCESS ) { +dev_dbg (dev,"ME cmd 0x%08X failed. status: 0x%X\n" , +WIRED_GET_SESSION_KEY , get_skey_out.header.status); +return -EIO ; + } + + ske_data->msg_id =HDCP_2_2_SKE_SEND_EKS ; +memcpy (ske_data->e_dkey_ks, get_skey_out.e_dkey_ks, +HDCP_2_2_E_DKEY_KS_LEN ); +memcpy (ske_data->riv, get_skey_out.r_iv,HDCP_2_2_RIV_LEN ); + +return 0 ; +} +static __attribute__((unused))struct i915_hdcp_component_ops mei_hdcp_ops = { .owner =THIS_MODULE ,
@@ -414,7 +471,7 @@ struct i915_hdcp_component_ops mei_hdcp_ops = { .store_pairing_info = mei_hdcp_store_pairing_info, .initiate_locality_check = mei_hdcp_initiate_locality_check, .verify_lprime = mei_hdcp_verify_lprime, - .get_session_key = NULL, + .get_session_key = mei_hdcp_get_session_key, .repeater_check_flow_prepare_ack = NULL, .verify_mprime = NULL, .enable_hdcp_authentication = NULL,
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v12 31/38 misc/mei/hdcp: Repeater topology verification and ack
In reply to Ramalingam CRequest ME to verify the downstream topology information received.
ME FW will validate the Repeaters receiver id list and downstream topology.
On Success ME FW will provide the Least Significant 128bits of VPrime, which forms the repeater ack.
v2: Rebased.
v3:
cldev is passed as first parameter [Tomas] Redundant comments and cast are removed [Tomas]
v4:
%zd for ssize_t [Alexander]
%s/return -1/return -EIO [Alexander] Style and typos fixed [Uma]
v5: Rebased.
v6: Rebasing.
v7:
Adjust to the new mei interface.
Fix for Kdoc.
v8:
K-Doc addition. [Tomas]
v9:
renamed func as mei_hdcp_* [Tomas] Inline function is defined for DDI index [Tomas]
--- drivers/misc/mei/hdcp/mei_hdcp.c | 77 +++++++++++++++++++++++++++++++++++++++- 1 file changed, 76 insertions(+), 1 deletion(-)
drivers/misc/mei/hdcp/mei_hdcp.c +76 -1
@@ -461,6 +461,80 @@ static int mei_hdcp_get_session_key(struct device *dev,return 0 ; } +/** +* mei_hdcp_repeater_check_flow_prepare_ack() - Validate the Downstream topology +* and prepare rep_ack. +* @dev: device corresponding to the mei_cl_device +* @hdcp_data: Intel HW specific hdcp data +* @rep_topology: Receiver ID List to be validated +* @rep_send_ack : repeater ack from ME FW. +* +* Return: 0 on Success, <0 on Failure +*/ +static int +mei_hdcp_repeater_check_flow_prepare_ack (struct device *dev, +struct hdcp_port_data *data, +struct hdcp2_rep_send_receiverid_list + *rep_topology, +struct hdcp2_rep_send_ack + *rep_send_ack) +{ +struct wired_cmd_verify_repeater_in verify_repeater_in = { {0 } }; +struct wired_cmd_verify_repeater_out verify_repeater_out = { {0 } }; +struct mei_cl_device *cldev; +ssize_t byte; + +if (!dev || !rep_topology || !rep_send_ack || !data) +return -EINVAL ; + + cldev =to_mei_cl_device (dev); + + verify_repeater_in.header.api_version =HDCP_API_VERSION ; + verify_repeater_in.header.command_id =WIRED_VERIFY_REPEATER ; + verify_repeater_in.header.status =ME_HDCP_STATUS_SUCCESS ; + verify_repeater_in.header.buffer_len = +WIRED_CMD_BUF_LEN_VERIFY_REPEATER_IN ; + + verify_repeater_in.port.integrated_port_type = data->port_type; + verify_repeater_in.port.physical_port =mei_get_ddi_index (data->port); + +memcpy (verify_repeater_in.rx_info, rep_topology->rx_info, +HDCP_2_2_RXINFO_LEN ); +memcpy (verify_repeater_in.seq_num_v, rep_topology->seq_num_v, +HDCP_2_2_SEQ_NUM_LEN ); +memcpy (verify_repeater_in.v_prime, rep_topology->v_prime, +HDCP_2_2_V_PRIME_HALF_LEN ); +memcpy (verify_repeater_in.receiver_ids, rep_topology->receiver_ids, +HDCP_2_2_RECEIVER_IDS_MAX_LEN ); + + byte =mei_cldev_send (cldev, (u8 *)&verify_repeater_in, +sizeof (verify_repeater_in)); +if (byte <0 ) { +dev_dbg (dev,"mei_cldev_send failed. %zd\n" , byte); +return byte; + } + + byte =mei_cldev_recv (cldev, (u8 *)&verify_repeater_out, +sizeof (verify_repeater_out)); +if (byte <0 ) { +dev_dbg (dev,"mei_cldev_recv failed. %zd\n" , byte); +return byte; + } + +if (verify_repeater_out.header.status !=ME_HDCP_STATUS_SUCCESS ) { +dev_dbg (dev,"ME cmd 0x%08X failed. status: 0x%X\n" , +WIRED_VERIFY_REPEATER , + verify_repeater_out.header.status); +return -EIO ; + } + +memcpy (rep_send_ack->v, verify_repeater_out.v, +HDCP_2_2_V_PRIME_HALF_LEN ); + rep_send_ack->msg_id =HDCP_2_2_REP_SEND_ACK ; + +return 0 ; +} +static __attribute__((unused))struct i915_hdcp_component_ops mei_hdcp_ops = { .owner =THIS_MODULE ,
@@ -472,7 +546,8 @@ struct i915_hdcp_component_ops mei_hdcp_ops = { .initiate_locality_check = mei_hdcp_initiate_locality_check, .verify_lprime = mei_hdcp_verify_lprime, .get_session_key = mei_hdcp_get_session_key, - .repeater_check_flow_prepare_ack = NULL, + .repeater_check_flow_prepare_ack = + mei_hdcp_repeater_check_flow_prepare_ack, .verify_mprime = NULL, .enable_hdcp_authentication = NULL, .close_hdcp_session = NULL,
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v12 32/38 misc/mei/hdcp: Verify M_prime
In reply to Ramalingam CRequest to ME to verify the M_Prime received from the HDCP sink.
ME FW will calculate the M and compare with M_prime received as part of RepeaterAuth_Stream_Ready, which is HDCP2.2 protocol msg.
On successful completion of this stage, downstream propagation of the stream management info is completed.
v2: Rebased.
v3:
cldev is passed as first parameter [Tomas] Redundant comments and cast are removed [Tomas]
v4:
%zd for ssize_t [Alexander]
%s/return -1/return -EIO [Alexander] endianness conversion func is moved to drm_hdcp.h [Uma]
v5: Rebased.
v6:
Collected the Rb-ed by.
Rebasing.
v7:
Adjust to the new mei interface.
Fix for Kdoc.
v8:
K-Doc addition. [Tomas] drm_hdcp2_u32_to_seq_num() is used for u32 to seq_num.
v9:
renamed func as mei_hdcp_* [Tomas]
Inline function is defined for DDI index [Tomas]
--- drivers/misc/mei/hdcp/mei_hdcp.c | 67 +++++++++++++++++++++++++++++++++++++++- 1 file changed, 66 insertions(+), 1 deletion(-)
drivers/misc/mei/hdcp/mei_hdcp.c +66 -1
@@ -535,6 +535,71 @@ mei_hdcp_repeater_check_flow_prepare_ack(struct device *dev,return 0 ; } +/** +* mei_hdcp_verify_mprime() - Verify mprime. +* @dev: device corresponding to the mei_cl_device +* @hdcp_data: Intel HW specific hdcp data +* @stream_ready: RepeaterAuth_Stream_Ready msg for ME FW verification. +* +* Return: 0 on Success, <0 on Failure +*/ +static int mei_hdcp_verify_mprime (struct device *dev, +struct hdcp_port_data *data, +struct hdcp2_rep_stream_ready *stream_ready) +{ +struct wired_cmd_repeater_auth_stream_req_in + verify_mprime_in = { {0 } }; +struct wired_cmd_repeater_auth_stream_req_out + verify_mprime_out = { {0 } }; +struct mei_cl_device *cldev; +ssize_t byte; + +if (!dev || !stream_ready || !data) +return -EINVAL ; + + cldev =to_mei_cl_device (dev); + + verify_mprime_in.header.api_version =HDCP_API_VERSION ; + verify_mprime_in.header.command_id =WIRED_REPEATER_AUTH_STREAM_REQ ; + verify_mprime_in.header.status =ME_HDCP_STATUS_SUCCESS ; + verify_mprime_in.header.buffer_len = +WIRED_CMD_BUF_LEN_REPEATER_AUTH_STREAM_REQ_MIN_IN ; + + verify_mprime_in.port.integrated_port_type = data->port_type; + verify_mprime_in.port.physical_port =mei_get_ddi_index (data->port); + +memcpy (verify_mprime_in.m_prime, stream_ready->m_prime, +HDCP_2_2_MPRIME_LEN ); +drm_hdcp2_u32_to_seq_num (verify_mprime_in.seq_num_m, data->seq_num_m); +memcpy (verify_mprime_in.streams, data->streams, + (data->k *sizeof (struct hdcp2_streamid_type ))); + + verify_mprime_in.k =__swab16 (data->k); + + byte =mei_cldev_send (cldev, (u8 *)&verify_mprime_in, +sizeof (verify_mprime_in)); +if (byte <0 ) { +dev_dbg (dev,"mei_cldev_send failed. %zd\n" , byte); +return byte; + } + + byte =mei_cldev_recv (cldev, (u8 *)&verify_mprime_out, +sizeof (verify_mprime_out)); +if (byte <0 ) { +dev_dbg (dev,"mei_cldev_recv failed. %zd\n" , byte); +return byte; + } + +if (verify_mprime_out.header.status !=ME_HDCP_STATUS_SUCCESS ) { +dev_dbg (dev,"ME cmd 0x%08X failed. status: 0x%X\n" , +WIRED_REPEATER_AUTH_STREAM_REQ , + verify_mprime_out.header.status); +return -EIO ; + } + +return 0 ; +} +static __attribute__((unused))struct i915_hdcp_component_ops mei_hdcp_ops = { .owner =THIS_MODULE ,
@@ -548,7 +613,7 @@ struct i915_hdcp_component_ops mei_hdcp_ops = { .get_session_key = mei_hdcp_get_session_key, .repeater_check_flow_prepare_ack = mei_hdcp_repeater_check_flow_prepare_ack, - .verify_mprime = NULL, + .verify_mprime = mei_hdcp_verify_mprime, .enable_hdcp_authentication = NULL, .close_hdcp_session = NULL, };
Signature · 6 lines
2.7.4 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v12 32/38] misc/mei/hdcp: Verify M_prime
Quoted 46 lines
Request to ME to verify the
M_Primereceived from the HDCP sink.ME FW will calculate the M and compare with
M_primereceived as part ofRepeaterAuth_Stream_Ready, which is HDCP2.2 protocol msg.On successful completion of this stage, downstream propagation of the stream management info is completed.
v2: Rebased.
v3:
cldev is passed as first parameter [Tomas] Redundant comments and cast are removed [Tomas]
v4:
%zd forssize_t[Alexander]
%s/return -1/return-EIO[Alexander] endianness conversion func is moved todrm_hdcp.h[Uma]
v5: Rebased.
v6:
Collected the Rb-ed by.
Rebasing.
v7:
Adjust to the new mei interface.
Fix for Kdoc.
v8:
K-Doc addition. [Tomas]drm_hdcp2_u32_to_seq_num()is used for u32 toseq_num.
v9:
renamed func as mei_hdcp_* [Tomas]
Inline function is defined for DDI index [Tomas]Signed-off-by Ramalingam C <[email protected]>Reviewed-by Uma Shankar <[email protected]>Acked-by Tomas Winkler <[email protected]>--- drivers/misc/mei/hdcp/mei_hdcp.c | 67 +++++++++++++++++++++++++++++++++++++++- 1 file changed, 66 insertions(+), 1 deletion(-)drivers/misc/mei/hdcp/mei_hdcp.c +0
-0
drivers/misc/mei/hdcp/mei_hdcp.c mei_hdcp_repeater_check_flow_prepare_ack(struct · line 542
Quoted 8 lines
drivers/misc/mei/hdcp/mei_hdcp.c +4
-0@@ -535,6 +535,71 @@ mei_hdcp_repeater_check_flow_prepare_ack(structdevice *dev, return 0; } +/** +* mei_hdcp_verify_mprime() - Verify mprime. +* @dev: device corresponding to the mei_cl_device +* @hdcp_data: Intel HW specific hdcp data
This should be @data across all the functions.
Quoted 77 lines
drivers/misc/mei/hdcp/mei_hdcp.c +24
-0+* @stream_ready: RepeaterAuth_Stream_Ready msg for ME FW verification. +* +* Return: 0 on Success, <0 on Failure +*/ +static int mei_hdcp_verify_mprime (struct device *dev, +struct hdcp_port_data *data, +struct hdcp2_rep_stream_ready *stream_ready) { +struct wired_cmd_repeater_auth_stream_req_in + verify_mprime_in = { {0 } }; +struct wired_cmd_repeater_auth_stream_req_out + verify_mprime_out = { {0 } }; +struct mei_cl_device *cldev; +ssize_t byte; + +if (!dev || !stream_ready || !data) +return -EINVAL ; + + cldev =to_mei_cl_device (dev); + + verify_mprime_in.header.api_version =HDCP_API_VERSION ; + verify_mprime_in.header.command_id =WIRED_REPEATER_AUTH_STREAM_REQ ; + verify_mprime_in.header.status =ME_HDCP_STATUS_SUCCESS ; + verify_mprime_in.header.buffer_len = +WIRED_CMD_BUF_LEN_REPEATER_AUTH_STREAM_REQ_MIN_IN;drivers/misc/mei/hdcp/mei_hdcp.c +7
-0+ + verify_mprime_in.port.integrated_port_type = data->port_type; + verify_mprime_in.port.physical_port =mei_get_ddi_index (data->port); + +memcpy (verify_mprime_in.m_prime, stream_ready->m_prime, +HDCP_2_2_MPRIME_LEN ); + drm_hdcp2_u32_to_seq_num(verify_mprime_in.seq_num_m, data-Quoted 1 line
seq_num_m);drivers/misc/mei/hdcp/mei_hdcp.c +30
-2+memcpy (verify_mprime_in.streams, data->streams, + (data->k *sizeof (struct hdcp2_streamid_type ))); + + verify_mprime_in.k =__swab16 (data->k); + + byte =mei_cldev_send (cldev, (u8 *)&verify_mprime_in, +sizeof (verify_mprime_in)); +if (byte <0 ) { +dev_dbg (dev,"mei_cldev_send failed. %zd\n" , byte); +return byte; + } + + byte =mei_cldev_recv (cldev, (u8 *)&verify_mprime_out, +sizeof (verify_mprime_out)); +if (byte <0 ) { +dev_dbg (dev,"mei_cldev_recv failed. %zd\n" , byte); +return byte; + } + +if (verify_mprime_out.header.status !=ME_HDCP_STATUS_SUCCESS ) { +dev_dbg (dev,"ME cmd 0x%08X failed. status: 0x%X\n" , +WIRED_REPEATER_AUTH_STREAM_REQ , + verify_mprime_out.header.status); +return -EIO ; + } + +return 0 ; +} +static __attribute__((unused))struct i915_hdcp_component_ops mei_hdcp_ops = { .owner =THIS_MODULE ,@@ -548,7 +613,7 @@ struct i915_hdcp_component_ops mei_hdcp_ops = { .get_session_key = mei_hdcp_get_session_key, .repeater_check_flow_prepare_ack = mei_hdcp_repeater_check_flow_prepare_ack, - .verify_mprime = NULL, + .verify_mprime = mei_hdcp_verify_mprime, .enable_hdcp_authentication = NULL, .close_hdcp_session = NULL, }; --
Quoted 1 line
2.7.4
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v12 33/38 misc/mei/hdcp: Enabling the HDCP authentication
In reply to Ramalingam CRequest to ME to configure a port as authenticated.
On Success, ME FW will mark the port as authenticated and provides HDCP cipher with the encryption keys.
Enabling the Authentication can be requested once all stages of HDCP2.2 authentication is completed by interacting with ME FW.
Only after this stage, driver can enable the HDCP encryption for the port, through HW registers.
v2: Rebased.
v3:
cldev is passed as first parameter [Tomas] Redundant comments and cast are removed [Tomas]
v4:
%zd for ssize_t [Alexander]
%s/return -1/return -EIO [Alexander] Style and typos fixed [Uma]
v5: Rebased.
v6:
Collected the Rb-ed by.
Rebased.
v7:
Adjust to the new mei interface.
Fix for Kdoc.
v8:
K-Doc addition. [Tomas]
v9:
renamed func as mei_hdcp_* [Tomas] Inline function is defined for DDI index [Tomas]
--- drivers/misc/mei/hdcp/mei_hdcp.c | 55 +++++++++++++++++++++++++++++++++++++++- 1 file changed, 54 insertions(+), 1 deletion(-)
drivers/misc/mei/hdcp/mei_hdcp.c +54 -1
@@ -600,6 +600,59 @@ static int mei_hdcp_verify_mprime(struct device *dev,return 0 ; } +/** +* mei_hdcp_enable_authentication() - Mark a port as authenticated +* through ME FW +* @dev: device corresponding to the mei_cl_device +* @hdcp_data: Intel HW specific hdcp data +* +* Return: 0 on Success, <0 on Failure +*/ +static int mei_hdcp_enable_authentication (struct device *dev, +struct hdcp_port_data *data) +{ +struct wired_cmd_enable_auth_in enable_auth_in = { {0 } }; +struct wired_cmd_enable_auth_out enable_auth_out = { {0 } }; +struct mei_cl_device *cldev; +ssize_t byte; + +if (!dev || !data) +return -EINVAL ; + + cldev =to_mei_cl_device (dev); + + enable_auth_in.header.api_version =HDCP_API_VERSION ; + enable_auth_in.header.command_id =WIRED_ENABLE_AUTH ; + enable_auth_in.header.status =ME_HDCP_STATUS_SUCCESS ; + enable_auth_in.header.buffer_len =WIRED_CMD_BUF_LEN_ENABLE_AUTH_IN ; + + enable_auth_in.port.integrated_port_type = data->port_type; + enable_auth_in.port.physical_port =mei_get_ddi_index (data->port); + enable_auth_in.stream_type = data->streams[0 ].stream_type; + + byte =mei_cldev_send (cldev, (u8 *)&enable_auth_in, +sizeof (enable_auth_in)); +if (byte <0 ) { +dev_dbg (dev,"mei_cldev_send failed. %zd\n" , byte); +return byte; + } + + byte =mei_cldev_recv (cldev, (u8 *)&enable_auth_out, +sizeof (enable_auth_out)); +if (byte <0 ) { +dev_dbg (dev,"mei_cldev_recv failed. %zd\n" , byte); +return byte; + } + +if (enable_auth_out.header.status !=ME_HDCP_STATUS_SUCCESS ) { +dev_dbg (dev,"ME cmd 0x%08X failed. status: 0x%X\n" , +WIRED_ENABLE_AUTH , enable_auth_out.header.status); +return -EIO ; + } + +return 0 ; +} +static __attribute__((unused))struct i915_hdcp_component_ops mei_hdcp_ops = { .owner =THIS_MODULE ,
@@ -614,7 +667,7 @@ struct i915_hdcp_component_ops mei_hdcp_ops = { .repeater_check_flow_prepare_ack = mei_hdcp_repeater_check_flow_prepare_ack, .verify_mprime = mei_hdcp_verify_mprime, - .enable_hdcp_authentication = NULL, + .enable_hdcp_authentication = mei_hdcp_enable_authentication, .close_hdcp_session = NULL, };
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v12 34/38 misc/mei/hdcp: Closing wired HDCP2.2 Tx Session
In reply to Ramalingam CRequest the ME to terminate the HDCP2.2 session for a port.
On Success, ME FW will mark the intel port as Deauthenticated and terminate the wired HDCP2.2 Tx session started due to the cmd WIRED_INITIATE_HDCP2_SESSION.
v2: Rebased.
v3:
cldev is passed as first parameter [Tomas] Redundant comments and cast are removed [Tomas]
v4:
%zd for ssize_t [Alexander]
%s/return -1/return -EIO [Alexander] Style and typos fixed [Uma]
v5:
Extra line is removed.
v6:
Collected the Rb-ed by.
Rebased.
v7:
Adjust to the new mei interface.
Fix for Kdoc.
v8:
K-Doc addition.[Tomas]
v9:
renamed func as mei_hdcp_* [Tomas] Inline function is defined for DDI index [Tomas]
--- drivers/misc/mei/hdcp/mei_hdcp.c | 55 +++++++++++++++++++++++++++++++++++++++- 1 file changed, 54 insertions(+), 1 deletion(-)
drivers/misc/mei/hdcp/mei_hdcp.c +54 -1
@@ -653,6 +653,59 @@ static int mei_hdcp_enable_authentication(struct device *dev,return 0 ; } +/** +* mei_hdcp_close_session() - Close the Wired HDCP Tx session of ME FW per port. +* This also disables the authenticated state of the port. +* @dev: device corresponding to the mei_cl_device +* @hdcp_data: Intel HW specific hdcp data +* +* Return: 0 on Success, <0 on Failure +*/ +static int +mei_hdcp_close_session (struct device *dev,struct hdcp_port_data *data) +{ +struct wired_cmd_close_session_in session_close_in = { {0 } }; +struct wired_cmd_close_session_out session_close_out = { {0 } }; +struct mei_cl_device *cldev; +ssize_t byte; + +if (!dev || !data) +return -EINVAL ; + + cldev =to_mei_cl_device (dev); + + session_close_in.header.api_version =HDCP_API_VERSION ; + session_close_in.header.command_id =WIRED_CLOSE_SESSION ; + session_close_in.header.status =ME_HDCP_STATUS_SUCCESS ; + session_close_in.header.buffer_len = +WIRED_CMD_BUF_LEN_CLOSE_SESSION_IN ; + + session_close_in.port.integrated_port_type = data->port_type; + session_close_in.port.physical_port =mei_get_ddi_index (data->port); + + byte =mei_cldev_send (cldev, (u8 *)&session_close_in, +sizeof (session_close_in)); +if (byte <0 ) { +dev_dbg (dev,"mei_cldev_send failed. %zd\n" , byte); +return byte; + } + + byte =mei_cldev_recv (cldev, (u8 *)&session_close_out, +sizeof (session_close_out)); +if (byte <0 ) { +dev_dbg (dev,"mei_cldev_recv failed. %zd\n" , byte); +return byte; + } + +if (session_close_out.header.status !=ME_HDCP_STATUS_SUCCESS ) { +dev_dbg (dev,"Session Close Failed. status: 0x%X\n" , + session_close_out.header.status); +return -EIO ; + } + +return 0 ; +} +static __attribute__((unused))struct i915_hdcp_component_ops mei_hdcp_ops = { .owner =THIS_MODULE ,
@@ -668,7 +721,7 @@ struct i915_hdcp_component_ops mei_hdcp_ops = { mei_hdcp_repeater_check_flow_prepare_ack, .verify_mprime = mei_hdcp_verify_mprime, .enable_hdcp_authentication = mei_hdcp_enable_authentication, - .close_hdcp_session = NULL, + .close_hdcp_session = mei_hdcp_close_session, }; static int mei_hdcp_probe(struct mei_cl_device *cldev,
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v12 35/38 misc/mei/hdcp: Component framework for I915 Interface
In reply to Ramalingam CMei hdcp driver is designed as component slave for the I915 component master.
v2: Rebased.
v3:
Notifier chain is adopted for cldev state update [Tomas]
v4:
Made static dummy functions as inline in mei_hdcp.h
API for polling client device status
IS_ENABLED used in header, for config status for mei_hdcp.
v5:
Replacing the notifier with component framework. [Daniel]
v6:
Rebased on the I915 comp master redesign.
v7:
mei_hdcp_component_registered is made static [Uma]
Need for global static variable mei_cldev is removed.
v8:
master comp is added to be matched with i915 subcomponent [daniel]
v9:
only comp_master is set and retrieved as driver_data [Daniel] Reviewed-by Daniel.
v10:
small corrections at probe [Tomas]
--- drivers/misc/mei/hdcp/mei_hdcp.c | 82 +++++++++++++++++++++++++++++++++++++++- 1 file changed, 80 insertions(+), 2 deletions(-)
drivers/misc/mei/hdcp/mei_hdcp.c +80 -2
@@ -23,6 +23,7 @@#include <linux/slab.h> #include <linux/uuid.h> #include <linux/mei_cl_bus.h> +#include <linux/component.h> #include <drm/drm_connector.h> #include <drm/i915_component.h> #include <drm/i915_mei_hdcp_interface.h>
@@ -706,8 +707,7 @@ mei_hdcp_close_session(struct device *dev, struct hdcp_port_data *data)return 0 ; } -static __attribute__((unused)) -struct i915_hdcp_component_ops mei_hdcp_ops = { +static struct i915_hdcp_component_ops mei_hdcp_ops = { .owner =THIS_MODULE , .initiate_hdcp2_session = mei_hdcp_initiate_session, .verify_receiver_cert_prepare_km =
@@ -724,20 +724,98 @@ struct i915_hdcp_component_ops mei_hdcp_ops = { .close_hdcp_session = mei_hdcp_close_session, }; +static int mei_component_master_bind (struct device *dev) +{ +struct mei_cl_device *cldev =to_mei_cl_device (dev); +struct i915_hdcp_comp_master *comp_master = +mei_cldev_get_drvdata (cldev); +int ret; + +dev_info (dev,"%s\n" , __func__); + comp_master->ops = &mei_hdcp_ops; + comp_master->mei_dev = dev; + ret =component_bind_all (dev, comp_master); +if (ret <0 ) +return ret; + +return 0 ; +} + +static void mei_component_master_unbind (struct device *dev) +{ +struct mei_cl_device *cldev =to_mei_cl_device (dev); +struct i915_hdcp_comp_master *comp_master = +mei_cldev_get_drvdata (cldev); + +dev_info (dev,"%s\n" , __func__); +component_unbind_all (dev, comp_master); +} + +static const struct component_master_ops mei_component_master_ops = { + .bind = mei_component_master_bind, + .unbind = mei_component_master_unbind, +}; + +static int mei_hdcp_component_match (struct device *dev,int subcomponent, +void *data) +{ +return !strcmp (dev->driver->name,"i915" ) && + subcomponent ==I915_COMPONENT_HDCP ; +} +static int mei_hdcp_probe (struct mei_cl_device *cldev,const struct mei_cl_device_id *id) { +struct i915_hdcp_comp_master *comp_master; +struct component_match *master_match;int ret; ret =mei_cldev_enable (cldev);if (ret <0 )dev_err (&cldev->dev,"mei_cldev_enable Failed. %d\n" , ret); + comp_master =kzalloc (sizeof (*comp_master),GFP_KERNEL ); +if (!comp_master) { + ret = -ENOMEM ; + goto err_exit; + } + + master_match =NULL ; +component_match_add_typed (&cldev->dev, &master_match, + mei_hdcp_component_match, comp_master); +if (IS_ERR_OR_NULL (master_match)) { + ret = -ENOMEM ; + goto err_exit; + } + +mei_cldev_set_drvdata (cldev, comp_master); + ret =component_master_add_with_match (&cldev->dev, + &mei_component_master_ops, + master_match); +if (ret <0 ) { +dev_err (&cldev->dev,"Master comp add failed %d\n" , ret); + goto err_exit; + } + +return 0 ; + +err_exit: +mei_cldev_set_drvdata (cldev,NULL ); +kfree (comp_master); +mei_cldev_disable (cldev); +return ret; }static int mei_hdcp_remove (struct mei_cl_device *cldev) { +struct i915_hdcp_comp_master *comp_master = +mei_cldev_get_drvdata (cldev); + +component_master_del (&cldev->dev, &mei_component_master_ops); +kfree (comp_master); +mei_cldev_set_drvdata (cldev,NULL ); +return mei_cldev_disable (cldev); }
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v12 36/38 FOR_TEST_ONLY: i915/Kconfig: Select mei_hdcp by I915
In reply to Ramalingam CFOR TESTING PURPOSE ONLY.
By default INTEL_MEI_HDCP is set to y. This patch is created to test the interface between I915 and MEI_HDCP.
--- drivers/misc/mei/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/misc/mei/Kconfig +1 -0
@@ -48,5 +48,6 @@ config INTEL_MEI_HDCP tristate "Intel HDCP2.2 services of ME Interface" select INTEL_MEI_ME depends on DRM_I915 + default y help MEI Support for HDCP2.2 Services on Intel platforms.
Signature · 6 lines
2.7.4 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH v12 37/38 FOR_TESTING_ONLY: debugfs: Excluding the LSPCon for HDCP1.4
In reply to Ramalingam CJust excluding the LSPCon HDMI ports from the HDCP1.4 testing.
--- drivers/gpu/drm/i915/i915_debugfs.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/i915_debugfs.c +8 -2
@@ -4782,6 +4782,9 @@ static int i915_hdcp_sink_capability_show(struct seq_file *m, void *data) {struct drm_connector *connector = m->private;struct intel_connector *intel_connector =to_intel_connector (connector); +struct intel_digital_port *intel_dig_port = +conn_to_dig_port (intel_connector); +bool is_hdcp14;if (connector->status != connector_status_connected)return -ENODEV ;
@@ -4792,8 +4795,11 @@ static int i915_hdcp_sink_capability_show(struct seq_file *m, void *data)seq_printf (m,"%s:%d HDCP version: " , connector->name, connector->base.id); -seq_printf (m,"%s " , !intel_hdcp_capable (intel_connector) ? -"None" :"HDCP1.4" ); + +/* Excluding the Lspcon for Testing Purpose */ + is_hdcp14 =intel_hdcp_capable (intel_connector) && + !intel_dig_port->lspcon.active; +seq_printf (m,"%s " , !is_hdcp14 ?"None" :"HDCP1.4" );seq_puts (m,"\n" );return 0 ;
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v12 38/38 FOR_TESTING_ONLY: ICL: Limit clk to <= 340MHz
In reply to Ramalingam CPruning 4k60 modes.
--- drivers/gpu/drm/i915/intel_hdmi.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/gpu/drm/i915/intel_hdmi.c +3 -0
@@ -1800,6 +1800,9 @@ intel_hdmi_mode_valid(struct drm_connector *connector,if (mode->flags &DRM_MODE_FLAG_DBLSCAN )return MODE_NO_DBLESCAN ; +if (mode->clock >340000 ) +return MODE_CLOCK_HIGH ; + clock = mode->clock;if ((mode->flags &DRM_MODE_FLAG_3D_MASK ) ==DRM_MODE_FLAG_3D_FRAME_PACKING )
Signature · 6 lines
2.7.4 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Patchwork
CI✗ Fi.CI.CHECKPATCH: warning for drm/i915: Implement HDCP2.2
In reply to Ramalingam C== Series Details ==
== Series Details ==
Series: drm/i915: Implement HDCP2.2
URL : https://patchwork.freedesktop.org/series/56453/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip d6c858444861 drm/doc: document recommended component helper usage -:17: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #17: FILE: Documentation/driver-api/component.rst:1: +.. _component:
total: 0 errors, 1 warnings, 0 checks, 36 lines checkeddc007e445cf1 drm/i915: Gathering the HDCP1.4 routines together9b759b7f3a76 drm: header for i915 - MEI_HDCP interface
-:23: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #23:
new file mode 100644
total: 0 errors, 1 warnings, 0 checks, 148 lines checkedb11a2b04d1d3 drm/i915: Initialize HDCP2.22bad8d56c3a8 drm/i915: MEI interface definition21370a181737 drm/i915: hdcp1.4 CP_IRQ handling and SW encryption tracking a34a3cc1d1f7 drm/i915: Enable and Disable of HDCP2.29c38a4eee03d drm/i915: Implement HDCP2.2 receiver authentication6f5dd1679365 drm: helper functions for hdcp2 seq_num to from u329ba57e3a2eae drm/i915: Implement HDCP2.2 repeater authenticationfc6c7208a8c8 drm: HDCP2.2 link check period2094a6d20da8 drm/i915: Implement HDCP2.2 link integrity check08e110cc5c59 drm/i915: Handle HDCP2.2 downstream topology change084805ec717f drm: removing the DP Errata msg and its msg id863a38b4d755 drm/i915: Implement the HDCP2.2 support for DPad4f4f59bc1e drm/i915: Implement the HDCP2.2 support for HDMIa3212af92f2a drm/i915: CP_IRQ handling for DP HDCP2.2 msgs4bf77130b96f drm/i915: Fix KBL HDCP2.2 encrypt status signallingb9aaefba309e mei: bus: whitelist hdcp clientb7eb7a6b3902 mei: bus: export to_mei_cl_device for mei client device drivers f89126053b2b mei: me: add ice lake point device id.dae119018765 misc/mei/hdcp: Client driver for HDCP application
-:77: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #77:
new file mode 100644
total: 0 errors, 1 warnings, 0 checks, 86 lines checked168884329cc5 misc/mei/hdcp: Define ME FW interface for HDCP2.2
-:30: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #30:
new file mode 100644
total: 0 errors, 1 warnings, 0 checks, 366 lines checked 74e46208ff60 misc/mei/hdcp: Initiate Wired HDCP2.2 Tx Session fde0890e79ba misc/mei/hdcp: Verify Receiver Cert and prepare km 2bb5b21cf2cf misc/mei/hdcp: Verify H_prime7574362210dd misc/mei/hdcp: Store the HDCP Pairing info 3f212736e75b misc/mei/hdcp: Initiate Locality check d09676f87942 misc/mei/hdcp: Verify L_prime5b36daa21d7a misc/mei/hdcp: Prepare Session Key0b5407999503 misc/mei/hdcp: Repeater topology verification and ack 3bf147bfe06f misc/mei/hdcp: Verify M_primeee63d118d53c misc/mei/hdcp: Enabling the HDCP authentication de2374ba3898 misc/mei/hdcp: Closing wired HDCP2.2 Tx Session a8fd049b267a misc/mei/hdcp: Component framework for I915 Interface 4f87a3f9d3cf FOR_TEST_ONLY: i915/Kconfig: Select mei_hdcp by I915 b796a4ae731d FOR_TESTING_ONLY: debugfs: Excluding the LSPCon for HDCP1.4 8c5029f9c557 FOR_TESTING_ONLY: ICL: Limit clk to <= 340MHz
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.SPARSE: warning for drm/i915: Implement HDCP2.2
In reply to Ramalingam C== Series Details ==
== Series Details ==
Series: drm/i915: Implement HDCP2.2
URL : https://patchwork.freedesktop.org/series/56453/
State : warning
== Summary ==
$ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/doc: document recommended component helper usage Okay!
Commit: drm/i915: Gathering the HDCP1.4 routines together Okay!
Commit: drm: header for i915 - MEI_HDCP interface
Okay!
Commit: drm/i915: Initialize HDCP2.2
Okay!
Commit: drm/i915: MEI interface definition -drivers/gpu/drm/i915/selftests/../i915_drv.h:3571:16: warning: expression using sizeof(void) +drivers/gpu/drm/i915/selftests/../i915_drv.h:3578:16: warning: expression using sizeof(void) +./include/linux/slab.h:664:13: error: not a function <noident>
Commit: drm/i915: hdcp1.4 CP_IRQ handling and SW encryption tracking +drivers/gpu/drm/i915/intel_hdcp.c:749:5: warning: symbol 'intel_hdcp_check_link' was not declared. Should it be static?
Commit: drm/i915: Enable and Disable of HDCP2.2
Okay!
Commit: drm/i915: Implement HDCP2.2 receiver authentication Okay!
Commit: drm: helper functions for hdcp2 seq_num to from u32 Okay!
Commit: drm/i915: Implement HDCP2.2 repeater authentication Okay!
Commit: drm: HDCP2.2 link check period
Okay!
Commit: drm/i915: Implement HDCP2.2 link integrity check Okay!
Commit: drm/i915: Handle HDCP2.2 downstream topology change Okay!
Commit: drm: removing the DP Errata msg and its msg id Okay!
Commit: drm/i915: Implement the HDCP2.2 support for DP Okay!
Commit: drm/i915: Implement the HDCP2.2 support for HDMI Okay!
Commit: drm/i915: CP_IRQ handling for DP HDCP2.2 msgs Okay!
Commit: drm/i915: Fix KBL HDCP2.2 encrypt status signalling Okay!
Commit: mei: bus: whitelist hdcp client
Okay!
Commit: mei: bus: export to_mei_cl_device for mei client device drivers Okay!
Commit: mei: me: add ice lake point device id.
Okay!
Commit: misc/mei/hdcp: Client driver for HDCP application +Error in reading or end of file.
Commit: misc/mei/hdcp: Define ME FW interface for HDCP2.2 Okay!
Commit: misc/mei/hdcp: Initiate Wired HDCP2.2 Tx Session Okay!
Commit: misc/mei/hdcp: Verify Receiver Cert and prepare km Okay!
Commit: misc/mei/hdcp: Verify H_prime
Okay!
Commit: misc/mei/hdcp: Store the HDCP Pairing info Okay!
Commit: misc/mei/hdcp: Initiate Locality check
Okay!
Commit: misc/mei/hdcp: Verify L_prime
Okay!
Commit: misc/mei/hdcp: Prepare Session Key
Okay!
Commit: misc/mei/hdcp: Repeater topology verification and ack Okay!
Commit: misc/mei/hdcp: Verify M_prime
Okay!
Commit: misc/mei/hdcp: Enabling the HDCP authentication Okay!
Commit: misc/mei/hdcp: Closing wired HDCP2.2 Tx Session Okay!
Commit: misc/mei/hdcp: Component framework for I915 Interface Okay!
Commit: FOR_TEST_ONLY: i915/Kconfig: Select mei_hdcp by I915 Okay!
Commit: FOR_TESTING_ONLY: debugfs: Excluding the LSPCon for HDCP1.4 Okay!
Commit: FOR_TESTING_ONLY: ICL: Limit clk to <= 340MHz Okay!
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915: Implement HDCP2.2
In reply to Ramalingam C== Series Details ==
== Series Details ==
Series: drm/i915: Implement HDCP2.2
URL : https://patchwork.freedesktop.org/series/56453/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5571 -> Patchwork_12187
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/56453/revisions/1/mbox/
Known issues
------------
Here are the changes found in Patchwork_12187 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live_evict:
- fi-bsw-kefka: PASS -> DMESG-WARN [fdo#107709]
* igt@kms_content_protection@atomic:
- fi-skl-gvtdvm: NOTRUN -> FAIL [fdo#108597] +1
* igt@kms_content_protection@legacy:
- fi-cfl-8109u: NOTRUN -> FAIL [fdo#108739] +1
* igt@pm_rpm@basic-rte:
- fi-byt-n2820: PASS -> FAIL [fdo#108800]
#### Possible fixes ####
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: FAIL [fdo#109485] -> PASS
* igt@kms_pipe_crc_basic@read-crc-pipe-b:
- fi-byt-clapper: FAIL [fdo#107362] -> PASS +1
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107709]: https://bugs.freedesktop.org/show_bug.cgi?id=107709
[fdo#108597]: https://bugs.freedesktop.org/show_bug.cgi?id=108597
[fdo#108739]: https://bugs.freedesktop.org/show_bug.cgi?id=108739
[fdo#108800]: https://bugs.freedesktop.org/show_bug.cgi?id=108800
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109485]: https://bugs.freedesktop.org/show_bug.cgi?id=109485
[fdo#109527]: https://bugs.freedesktop.org/show_bug.cgi?id=109527
Participating hosts (50 -> 45)
------------------------------
Missing (5): fi-kbl-soraka fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-bdw-samus
Build changes
-------------
* IGT: IGT_4815 -> IGTPW_2356
* Linux: CI_DRM_5571 -> Patchwork_12187
CI_DRM_5571: dd61c93126a4c9eea6a6b2cc9d731dd77d92e0a2 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2356: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2356/
IGT_4815: 947301563259726b65ce47d3a3fe37931ed42efe @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_12187: 8c5029f9c5572cebe871e54c9253b494158d3cd5 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
8c5029f9c557 FOR_TESTING_ONLY: ICL: Limit clk to <= 340MHz b796a4ae731d FOR_TESTING_ONLY: debugfs: Excluding the LSPCon for HDCP1.4 4f87a3f9d3cf FOR_TEST_ONLY: i915/Kconfig: Select mei_hdcp by I915 a8fd049b267a misc/mei/hdcp: Component framework for I915 Interface de2374ba3898 misc/mei/hdcp: Closing wired HDCP2.2 Tx Session ee63d118d53c misc/mei/hdcp: Enabling the HDCP authentication 3bf147bfe06f misc/mei/hdcp: Verify M_prime0b5407999503 misc/mei/hdcp: Repeater topology verification and ack 5b36daa21d7a misc/mei/hdcp: Prepare Session Keyd09676f87942 misc/mei/hdcp: Verify L_prime3f212736e75b misc/mei/hdcp: Initiate Locality check7574362210dd misc/mei/hdcp: Store the HDCP Pairing info 2bb5b21cf2cf misc/mei/hdcp: Verify H_primefde0890e79ba misc/mei/hdcp: Verify Receiver Cert and prepare km 74e46208ff60 misc/mei/hdcp: Initiate Wired HDCP2.2 Tx Session 168884329cc5 misc/mei/hdcp: Define ME FW interface for HDCP2.2 dae119018765 misc/mei/hdcp: Client driver for HDCP application f89126053b2b mei: me: add ice lake point device id.b7eb7a6b3902 mei: bus: export to_mei_cl_device for mei client device drivers b9aaefba309e mei: bus: whitelist hdcp client4bf77130b96f drm/i915: Fix KBL HDCP2.2 encrypt status signalling a3212af92f2a drm/i915: CP_IRQ handling for DP HDCP2.2 msgs ad4f4f59bc1e drm/i915: Implement the HDCP2.2 support for HDMI 863a38b4d755 drm/i915: Implement the HDCP2.2 support for DP 084805ec717f drm: removing the DP Errata msg and its msg id 08e110cc5c59 drm/i915: Handle HDCP2.2 downstream topology change 2094a6d20da8 drm/i915: Implement HDCP2.2 link integrity check fc6c7208a8c8 drm: HDCP2.2 link check period9ba57e3a2eae drm/i915: Implement HDCP2.2 repeater authentication 6f5dd1679365 drm: helper functions for hdcp2 seq_num to from u32 9c38a4eee03d drm/i915: Implement HDCP2.2 receiver authentication a34a3cc1d1f7 drm/i915: Enable and Disable of HDCP2.2 21370a181737 drm/i915: hdcp1.4 CP_IRQ handling and SW encryption tracking 2bad8d56c3a8 drm/i915: MEI interface definitionb11a2b04d1d3 drm/i915: Initialize HDCP2.29b759b7f3a76 drm: header for i915 - MEI_HDCP interface dc007e445cf1 drm/i915: Gathering the HDCP1.4 routines together d6c858444861 drm/doc: document recommended component helper usage
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12187/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.IGT: success for drm/i915: Implement HDCP2.2
In reply to Ramalingam C== Series Details ==
== Series Details ==
Series: drm/i915: Implement HDCP2.2
URL : https://patchwork.freedesktop.org/series/56453/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5571_full -> Patchwork_12187_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_12187_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_big:
- shard-hsw: PASS -> TIMEOUT [fdo#107937]
* igt@gem_mmap_gtt@hang:
- shard-snb: PASS -> INCOMPLETE [fdo#105411]
* igt@gem_tiled_blits@interruptible:
- shard-apl: PASS -> INCOMPLETE [fdo#103927]
* igt@kms_busy@extended-modeset-hang-newfb-render-b:
- shard-kbl: NOTRUN -> DMESG-WARN [fdo#107956]
* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-c:
- shard-glk: NOTRUN -> DMESG-WARN [fdo#107956]
* igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
- shard-glk: PASS -> FAIL [fdo#108145]
* igt@kms_cursor_crc@cursor-256x256-dpms:
- shard-kbl: PASS -> FAIL [fdo#103232] +1
* igt@kms_cursor_crc@cursor-256x256-suspend:
- shard-glk: NOTRUN -> FAIL [fdo#103232]
* igt@kms_cursor_crc@cursor-256x85-onscreen:
- shard-apl: PASS -> FAIL [fdo#103232] +4
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt:
- shard-glk: PASS -> FAIL [fdo#103167] +1
* igt@kms_plane@pixel-format-pipe-c-planes:
- shard-apl: PASS -> FAIL [fdo#103166] +1
* igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb:
- shard-apl: PASS -> FAIL [fdo#108145]
* igt@kms_plane_multiple@atomic-pipe-a-tiling-y:
- shard-glk: PASS -> FAIL [fdo#103166] +1
#### Possible fixes ####
* igt@kms_cursor_crc@cursor-128x128-suspend:
- shard-apl: FAIL [fdo#103191] / [fdo#103232] -> PASS
* igt@kms_cursor_crc@cursor-64x21-random:
- shard-apl: FAIL [fdo#103232] -> PASS +9
* igt@kms_cursor_crc@cursor-64x64-onscreen:
- shard-kbl: FAIL [fdo#103232] -> PASS +1
* igt@kms_cursor_crc@cursor-alpha-opaque:
- shard-apl: FAIL [fdo#109350] -> PASS
* igt@kms_flip@modeset-vs-vblank-race-interruptible:
- shard-glk: FAIL [fdo#103060] -> PASS
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt:
- shard-apl: FAIL [fdo#103167] -> PASS +7
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-mmap-cpu:
- shard-glk: FAIL [fdo#103167] -> PASS +1
* igt@kms_frontbuffer_tracking@fbc-farfromfence:
- shard-snb: INCOMPLETE [fdo#105411] -> PASS
* igt@kms_plane_multiple@atomic-pipe-b-tiling-none:
- shard-glk: FAIL [fdo#103166] -> PASS +4
* igt@kms_plane_multiple@atomic-pipe-b-tiling-y:
- shard-kbl: FAIL [fdo#103166] -> PASS +2
* igt@kms_plane_multiple@atomic-pipe-c-tiling-yf:
- shard-apl: FAIL [fdo#103166] -> PASS +5
* igt@kms_setmode@basic:
- shard-hsw: FAIL [fdo#99912] -> PASS
* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-hsw: FAIL [fdo#104894] -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103060]: https://bugs.freedesktop.org/show_bug.cgi?id=103060
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104894]: https://bugs.freedesktop.org/show_bug.cgi?id=104894
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#107937]: https://bugs.freedesktop.org/show_bug.cgi?id=107937
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108597]: https://bugs.freedesktop.org/show_bug.cgi?id=108597
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109350]: https://bugs.freedesktop.org/show_bug.cgi?id=109350
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (7 -> 5)
------------------------------
Missing (2): shard-skl shard-iclb
Build changes
-------------
* IGT: IGT_4815 -> IGTPW_2356
* Linux: CI_DRM_5571 -> Patchwork_12187
CI_DRM_5571: dd61c93126a4c9eea6a6b2cc9d731dd77d92e0a2 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2356: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2356/
IGT_4815: 947301563259726b65ce47d3a3fe37931ed42efe @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_12187: 8c5029f9c5572cebe871e54c9253b494158d3cd5 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12187/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.CHECKPATCH: warning for drm/i915: Implement HDCP2.2 (rev2)
In reply to Ramalingam C== Series Details ==
== Series Details ==
Series: drm/i915: Implement HDCP2.2 (rev2)
URL : https://patchwork.freedesktop.org/series/56453/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip d289db6f93f4 drm/doc: document recommended component helper usage -:17: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #17: FILE: Documentation/driver-api/component.rst:1: +.. _component:
total: 0 errors, 1 warnings, 0 checks, 36 lines checked66627b97871e drm/i915: Gathering the HDCP1.4 routines together05f70c9176f2 drm: header for i915 - MEI_HDCP interface
-:23: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #23:
new file mode 100644
total: 0 errors, 1 warnings, 0 checks, 148 lines checkedfbbe37d35a5f drm/i915: Initialize HDCP2.2fd9279c5f707 drm/i915: MEI interface definition5ceae34143e4 drm/i915: hdcp1.4 CP_IRQ handling and SW encryption tracking 658d7ed60637 drm/i915: Enable and Disable of HDCP2.2aacc34ccd4a8 drm/i915: Implement HDCP2.2 receiver authenticationc24dd6750551 drm: helper functions for hdcp2 seq_num to from u32e8fe65a1bca5 drm/i915: Implement HDCP2.2 repeater authentication09c5d7af9f4c drm: HDCP2.2 link check period482f81a281f0 drm/i915: Implement HDCP2.2 link integrity check80cbba80f927 drm/i915: Handle HDCP2.2 downstream topology changede0f7ba78eef drm: removing the DP Errata msg and its msg idcf3e9c26d366 drm/i915: Implement the HDCP2.2 support for DP9c74bcbfbe8b drm/i915: Implement the HDCP2.2 support for HDMI67a4708b97e0 drm/i915: CP_IRQ handling for DP HDCP2.2 msgs6a6e6ffa8401 drm/i915: Fix KBL HDCP2.2 encrypt status signalling909179cd6436 mei: bus: whitelist hdcp clientcaa6b3b066bb mei: bus: export to_mei_cl_device for mei client device drivers e67ca8f6096e misc/mei/hdcp: Client driver for HDCP application
-:77: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #77:
new file mode 100644
total: 0 errors, 1 warnings, 0 checks, 86 lines checkedcd42111b6ad9 misc/mei/hdcp: Define ME FW interface for HDCP2.2
-:30: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #30:
new file mode 100644
total: 0 errors, 1 warnings, 0 checks, 366 lines checked 791dc39bdefa misc/mei/hdcp: Initiate Wired HDCP2.2 Tx Session 081b5fc8e493 misc/mei/hdcp: Verify Receiver Cert and prepare km bc598d2bb03c misc/mei/hdcp: Verify H_primef07e849fb6c4 misc/mei/hdcp: Store the HDCP Pairing info 06490f48dbf7 misc/mei/hdcp: Initiate Locality check 4b944818a5ac misc/mei/hdcp: Verify L_primef920f96f5f98 misc/mei/hdcp: Prepare Session Key41ba41d24249 misc/mei/hdcp: Repeater topology verification and ack 9b0801a7d533 misc/mei/hdcp: Verify M_prime150c5a487e9a misc/mei/hdcp: Enabling the HDCP authentication 26a7d5f34805 misc/mei/hdcp: Closing wired HDCP2.2 Tx Session c25f39ad6a37 misc/mei/hdcp: Component framework for I915 Interface 48910a3fe609 FOR_TEST_ONLY: i915/Kconfig: Select mei_hdcp by I915 eb90c2de5ccf FOR_TESTING_ONLY: debugfs: Excluding the LSPCon for HDCP1.4 68f27452659a FOR_TESTING_ONLY: ICL: Limit clk to <= 340MHz
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.SPARSE: warning for drm/i915: Implement HDCP2.2 (rev2)
In reply to Ramalingam C== Series Details ==
== Series Details ==
Series: drm/i915: Implement HDCP2.2 (rev2)
URL : https://patchwork.freedesktop.org/series/56453/
State : warning
== Summary ==
$ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/doc: document recommended component helper usage Okay!
Commit: drm/i915: Gathering the HDCP1.4 routines together Okay!
Commit: drm: header for i915 - MEI_HDCP interface
Okay!
Commit: drm/i915: Initialize HDCP2.2
Okay!
Commit: drm/i915: MEI interface definition -drivers/gpu/drm/i915/selftests/../i915_drv.h:3571:16: warning: expression using sizeof(void) +drivers/gpu/drm/i915/selftests/../i915_drv.h:3578:16: warning: expression using sizeof(void) +./include/linux/slab.h:664:13: error: not a function <noident>
Commit: drm/i915: hdcp1.4 CP_IRQ handling and SW encryption tracking +drivers/gpu/drm/i915/intel_hdcp.c:749:5: warning: symbol 'intel_hdcp_check_link' was not declared. Should it be static?
Commit: drm/i915: Enable and Disable of HDCP2.2
Okay!
Commit: drm/i915: Implement HDCP2.2 receiver authentication Okay!
Commit: drm: helper functions for hdcp2 seq_num to from u32 Okay!
Commit: drm/i915: Implement HDCP2.2 repeater authentication Okay!
Commit: drm: HDCP2.2 link check period
Okay!
Commit: drm/i915: Implement HDCP2.2 link integrity check Okay!
Commit: drm/i915: Handle HDCP2.2 downstream topology change Okay!
Commit: drm: removing the DP Errata msg and its msg id Okay!
Commit: drm/i915: Implement the HDCP2.2 support for DP Okay!
Commit: drm/i915: Implement the HDCP2.2 support for HDMI Okay!
Commit: drm/i915: CP_IRQ handling for DP HDCP2.2 msgs Okay!
Commit: drm/i915: Fix KBL HDCP2.2 encrypt status signalling Okay!
Commit: mei: bus: whitelist hdcp client
Okay!
Commit: mei: bus: export to_mei_cl_device for mei client device drivers Okay!
Commit: misc/mei/hdcp: Client driver for HDCP application +Error in reading or end of file.
Commit: misc/mei/hdcp: Define ME FW interface for HDCP2.2 Okay!
Commit: misc/mei/hdcp: Initiate Wired HDCP2.2 Tx Session Okay!
Commit: misc/mei/hdcp: Verify Receiver Cert and prepare km Okay!
Commit: misc/mei/hdcp: Verify H_prime
Okay!
Commit: misc/mei/hdcp: Store the HDCP Pairing info Okay!
Commit: misc/mei/hdcp: Initiate Locality check
Okay!
Commit: misc/mei/hdcp: Verify L_prime
Okay!
Commit: misc/mei/hdcp: Prepare Session Key
Okay!
Commit: misc/mei/hdcp: Repeater topology verification and ack Okay!
Commit: misc/mei/hdcp: Verify M_prime
Okay!
Commit: misc/mei/hdcp: Enabling the HDCP authentication Okay!
Commit: misc/mei/hdcp: Closing wired HDCP2.2 Tx Session Okay!
Commit: misc/mei/hdcp: Component framework for I915 Interface Okay!
Commit: FOR_TEST_ONLY: i915/Kconfig: Select mei_hdcp by I915 Okay!
Commit: FOR_TESTING_ONLY: debugfs: Excluding the LSPCon for HDCP1.4 Okay!
Commit: FOR_TESTING_ONLY: ICL: Limit clk to <= 340MHz Okay!
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915: Implement HDCP2.2 (rev2)
In reply to Ramalingam C== Series Details ==
== Series Details ==
Series: drm/i915: Implement HDCP2.2 (rev2)
URL : https://patchwork.freedesktop.org/series/56453/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5584 -> Patchwork_12188
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/56453/revisions/2/mbox/
Known issues
------------
Here are the changes found in Patchwork_12188 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_busy@basic-flip-a:
- fi-gdg-551: PASS -> FAIL [fdo#103182]
* igt@kms_content_protection@atomic:
- fi-skl-gvtdvm: NOTRUN -> FAIL [fdo#108597] +1
* igt@kms_content_protection@legacy:
- fi-cfl-8109u: NOTRUN -> FAIL [fdo#108739] +1
* igt@kms_frontbuffer_tracking@basic:
- fi-byt-clapper: PASS -> FAIL [fdo#103167]
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- fi-byt-clapper: PASS -> FAIL [fdo#103191] / [fdo#107362] +1
#### Possible fixes ####
* igt@gem_ctx_create@basic-files:
- {fi-icl-y}: INCOMPLETE [fdo#109100] -> PASS
* igt@pm_rpm@module-reload:
- fi-skl-6770hq: FAIL [fdo#108511] -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#105998]: https://bugs.freedesktop.org/show_bug.cgi?id=105998
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#108511]: https://bugs.freedesktop.org/show_bug.cgi?id=108511
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#108597]: https://bugs.freedesktop.org/show_bug.cgi?id=108597
[fdo#108739]: https://bugs.freedesktop.org/show_bug.cgi?id=108739
[fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109294]: https://bugs.freedesktop.org/show_bug.cgi?id=109294
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109527]: https://bugs.freedesktop.org/show_bug.cgi?id=109527
[fdo#109528]: https://bugs.freedesktop.org/show_bug.cgi?id=109528
[fdo#109530]: https://bugs.freedesktop.org/show_bug.cgi?id=109530
Participating hosts (41 -> 39)
------------------------------
Additional (1): fi-skl-6700hq
Missing (3): fi-ilk-m540 fi-bsw-cyan fi-bdw-samus
Build changes
-------------
* IGT: IGT_4815 -> IGTPW_2356
* Linux: CI_DRM_5584 -> Patchwork_12188
CI_DRM_5584: f59dc044477c599513df2650437c4c7d5b94c52d @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2356: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2356/
IGT_4815: 947301563259726b65ce47d3a3fe37931ed42efe @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_12188: 68f27452659ab95f77baa58e3f5c4ef9cc32445a @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
68f27452659a FOR_TESTING_ONLY: ICL: Limit clk to <= 340MHz eb90c2de5ccf FOR_TESTING_ONLY: debugfs: Excluding the LSPCon for HDCP1.4 48910a3fe609 FOR_TEST_ONLY: i915/Kconfig: Select mei_hdcp by I915 c25f39ad6a37 misc/mei/hdcp: Component framework for I915 Interface 26a7d5f34805 misc/mei/hdcp: Closing wired HDCP2.2 Tx Session 150c5a487e9a misc/mei/hdcp: Enabling the HDCP authentication 9b0801a7d533 misc/mei/hdcp: Verify M_prime41ba41d24249 misc/mei/hdcp: Repeater topology verification and ack f920f96f5f98 misc/mei/hdcp: Prepare Session Key4b944818a5ac misc/mei/hdcp: Verify L_prime06490f48dbf7 misc/mei/hdcp: Initiate Locality checkf07e849fb6c4 misc/mei/hdcp: Store the HDCP Pairing info bc598d2bb03c misc/mei/hdcp: Verify H_prime081b5fc8e493 misc/mei/hdcp: Verify Receiver Cert and prepare km 791dc39bdefa misc/mei/hdcp: Initiate Wired HDCP2.2 Tx Session cd42111b6ad9 misc/mei/hdcp: Define ME FW interface for HDCP2.2 e67ca8f6096e misc/mei/hdcp: Client driver for HDCP application caa6b3b066bb mei: bus: export to_mei_cl_device for mei client device drivers 909179cd6436 mei: bus: whitelist hdcp client6a6e6ffa8401 drm/i915: Fix KBL HDCP2.2 encrypt status signalling 67a4708b97e0 drm/i915: CP_IRQ handling for DP HDCP2.2 msgs 9c74bcbfbe8b drm/i915: Implement the HDCP2.2 support for HDMI cf3e9c26d366 drm/i915: Implement the HDCP2.2 support for DP de0f7ba78eef drm: removing the DP Errata msg and its msg id 80cbba80f927 drm/i915: Handle HDCP2.2 downstream topology change 482f81a281f0 drm/i915: Implement HDCP2.2 link integrity check 09c5d7af9f4c drm: HDCP2.2 link check periode8fe65a1bca5 drm/i915: Implement HDCP2.2 repeater authentication c24dd6750551 drm: helper functions for hdcp2 seq_num to from u32 aacc34ccd4a8 drm/i915: Implement HDCP2.2 receiver authentication 658d7ed60637 drm/i915: Enable and Disable of HDCP2.2 5ceae34143e4 drm/i915: hdcp1.4 CP_IRQ handling and SW encryption tracking fd9279c5f707 drm/i915: MEI interface definitionfbbe37d35a5f drm/i915: Initialize HDCP2.205f70c9176f2 drm: header for i915 - MEI_HDCP interface 66627b97871e drm/i915: Gathering the HDCP1.4 routines together d289db6f93f4 drm/doc: document recommended component helper usage
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12188/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.IGT: failure for drm/i915: Implement HDCP2.2 (rev2)
In reply to Ramalingam C== Series Details ==
== Series Details ==
Series: drm/i915: Implement HDCP2.2 (rev2)
URL : https://patchwork.freedesktop.org/series/56453/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_5584_full -> Patchwork_12188_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_12188_full absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_12188_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_12188_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_eio@unwedge-stress:
- shard-snb: PASS -> FAIL
Known issues
------------
Here are the changes found in Patchwork_12188_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_mmap_gtt@hang:
- shard-snb: PASS -> INCOMPLETE [fdo#105411]
* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-a:
- shard-hsw: PASS -> DMESG-WARN [fdo#107956]
* igt@kms_cursor_crc@cursor-128x128-random:
- shard-apl: PASS -> FAIL [fdo#103232] +5
* igt@kms_cursor_crc@cursor-256x256-dpms:
- shard-kbl: PASS -> FAIL [fdo#103232] +1
* igt@kms_cursor_crc@cursor-256x256-suspend:
- shard-glk: NOTRUN -> FAIL [fdo#103232]
- shard-apl: PASS -> FAIL [fdo#103191] / [fdo#103232]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-fullscreen:
- shard-glk: PASS -> FAIL [fdo#103167] +7
* igt@kms_plane@pixel-format-pipe-b-planes-source-clamping:
- shard-apl: PASS -> FAIL [fdo#108948]
* igt@kms_plane_alpha_blend@pipe-a-alpha-basic:
- shard-apl: NOTRUN -> FAIL [fdo#108145]
* igt@kms_plane_multiple@atomic-pipe-a-tiling-y:
- shard-glk: PASS -> FAIL [fdo#103166] +4
* igt@kms_plane_multiple@atomic-pipe-b-tiling-yf:
- shard-apl: PASS -> FAIL [fdo#103166] +2
* igt@kms_setmode@basic:
- shard-apl: PASS -> FAIL [fdo#99912]
- shard-kbl: PASS -> FAIL [fdo#99912]
#### Possible fixes ####
* igt@gem_exec_flush@basic-wb-rw-before-default:
- shard-apl: INCOMPLETE [fdo#103927] -> PASS
* igt@kms_atomic_transition@plane-all-transition-fencing:
- shard-hsw: INCOMPLETE [fdo#103540] / [fdo#109225] -> PASS
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-a:
- shard-kbl: DMESG-WARN [fdo#107956] -> PASS
* igt@kms_cursor_crc@cursor-128x128-suspend:
- shard-apl: FAIL [fdo#103191] / [fdo#103232] -> PASS
* igt@kms_cursor_crc@cursor-64x21-random:
- shard-apl: FAIL [fdo#103232] -> PASS +5
* igt@kms_cursor_crc@cursor-64x64-onscreen:
- shard-kbl: FAIL [fdo#103232] -> PASS +1
* {igt@kms_flip@flip-vs-suspend}:
- shard-kbl: DMESG-WARN [fdo#108566] -> PASS
* igt@kms_flip@plain-flip-fb-recreate-interruptible:
- shard-kbl: FAIL [fdo#100368] -> PASS
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-mmap-wc:
- shard-glk: FAIL [fdo#103167] -> PASS
* igt@kms_frontbuffer_tracking@fbc-farfromfence:
- shard-snb: INCOMPLETE [fdo#105411] -> PASS
* igt@kms_plane@plane-position-covered-pipe-c-planes:
- shard-apl: FAIL [fdo#103166] -> PASS +4
* igt@kms_plane_multiple@atomic-pipe-b-tiling-y:
- shard-kbl: FAIL [fdo#103166] -> PASS +2
* igt@kms_rotation_crc@multiplane-rotation-cropping-bottom:
- shard-kbl: DMESG-FAIL [fdo#105763] -> PASS
* igt@kms_universal_plane@universal-plane-pipe-c-functional:
- shard-glk: FAIL [fdo#103166] -> PASS +6
* igt@pm_rc6_residency@rc6-accuracy:
- shard-snb: {SKIP} [fdo#109271] -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#100368]: https://bugs.freedesktop.org/show_bug.cgi?id=100368
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#108597]: https://bugs.freedesktop.org/show_bug.cgi?id=108597
[fdo#108948]: https://bugs.freedesktop.org/show_bug.cgi?id=108948
[fdo#109225]: https://bugs.freedesktop.org/show_bug.cgi?id=109225
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
Participating hosts (7 -> 5)
------------------------------
Missing (2): shard-skl shard-iclb
Build changes
-------------
* IGT: IGT_4815 -> IGTPW_2356
* Linux: CI_DRM_5584 -> Patchwork_12188
CI_DRM_5584: f59dc044477c599513df2650437c4c7d5b94c52d @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2356: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2356/
IGT_4815: 947301563259726b65ce47d3a3fe37931ed42efe @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_12188: 68f27452659ab95f77baa58e3f5c4ef9cc32445a @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12188/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx