Staging: vt6655: Modify comment style for SPDX License Identifier
PATCH v2 1/1 Staging: vt6655: Modify comment style for SPDX License Identifier
FIx the warning by changing comment style based on header file type as per License identifier syntax
---
Changes in v2
- Modified subject line and commit log
drivers/staging/vt6655/baseband.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/vt6655/baseband.h +1 -1
@@ -1,4 +1,4 @@ -* SPDX-License-Identifier: GPL-2.0+ */ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved.
Signature · 1 line
2.17.1
Greg KH
maintainerQuoted 16 lines · Madhumitha Prabakaran
FIx the warning by changing comment style based on header file type as per License identifier syntax
Signed-off-by Madhumitha Prabakaran <[email protected]>---
Changes in v2
- Modified subject line and commit logdrivers/staging/vt6655/baseband.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/vt6655/baseband.h +0
-0
drivers/staging/vt6655/baseband.h line 1
Quoted 2 lines
drivers/staging/vt6655/baseband.h +1
-1@@ -1,4 +1,4 @@ -* SPDX-License-Identifier: GPL-2.0+ */ +/* SPDX-License-Identifier: GPL-2.0+ */
This patch does not apply to my tree :(
Quoted 12 lines · Greg KH
Quoted 11 lines · Madhumitha Prabakaran
FIx the warning by changing comment style based on header file type as per License identifier syntax
Signed-off-by Madhumitha Prabakaran <[email protected]>---
Changes in v2
- Modified subject line and commit logdrivers/staging/vt6655/baseband.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 10 lines
drivers/staging/vt6655/baseband.h line 1
Quoted 7 lines
drivers/staging/vt6655/baseband.h +1
-1@@ -1,4 +1,4 @@ -* SPDX-License-Identifier: GPL-2.0+ */ +/* SPDX-License-Identifier: GPL-2.0+ */ This patch does not apply to my tree :(
I didn't understand why it doesn't apply to your tree.
Greg KH
maintainerQuoted 25 lines · Madhumthia Prabakaran
Quoted 12 lines · Greg KH
Quoted 11 lines · Madhumitha Prabakaran
FIx the warning by changing comment style based on header file type as per License identifier syntax
Signed-off-by Madhumitha Prabakaran <[email protected]>---
Changes in v2
- Modified subject line and commit logdrivers/staging/vt6655/baseband.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Quoted 10 lines
drivers/staging/vt6655/baseband.h line 1
Quoted 7 lines
drivers/staging/vt6655/baseband.h +1
-1@@ -1,4 +1,4 @@ -* SPDX-License-Identifier: GPL-2.0+ */ +/* SPDX-License-Identifier: GPL-2.0+ */ This patch does not apply to my tree :(
Quoted 2 lines
I didn't understand why it doesn't apply to your tree.
Neither do I :)
Please try rebasing your patch on the top of my staging-testing branch and see if that produces a different patch or not. If it does, please resend.
thanks,
greg k-h
Quoted 31 lines · Greg KH
Quoted 25 lines · Madhumthia Prabakaran
Quoted 12 lines · Greg KH
Quoted 11 lines · Madhumitha Prabakaran
FIx the warning by changing comment style based on header file type as per License identifier syntax
Signed-off-by Madhumitha Prabakaran <[email protected]>---
Changes in v2
- Modified subject line and commit logdrivers/staging/vt6655/baseband.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Quoted 10 lines
drivers/staging/vt6655/baseband.h line 1
Quoted 7 lines
drivers/staging/vt6655/baseband.h +1
-1@@ -1,4 +1,4 @@ -* SPDX-License-Identifier: GPL-2.0+ */ +/* SPDX-License-Identifier: GPL-2.0+ */ This patch does not apply to my tree :(
Quoted 2 lines
I didn't understand why it doesn't apply to your tree.
Neither do I :)
Quoted 7 lines
Please try rebasing your patch on the top of my staging-testing branch and see if that produces a different patch or not. If it does, please resend.
thanks,
greg k-h
I will rebase it and send it again.
Also, I want to make sure whether you got a similar patch with same commit log or not.
Thanks,
Madhumitha
Greg KH
maintainerQuoted 36 lines · Madhumthia Prabakaran
Quoted 35 lines · Greg KH
Quoted 25 lines · Madhumthia Prabakaran
Quoted 12 lines · Greg KH
Quoted 11 lines · Madhumitha Prabakaran
FIx the warning by changing comment style based on header file type as per License identifier syntax
Signed-off-by Madhumitha Prabakaran <[email protected]>---
Changes in v2
- Modified subject line and commit logdrivers/staging/vt6655/baseband.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Quoted 10 lines
drivers/staging/vt6655/baseband.h line 1
Quoted 7 lines
drivers/staging/vt6655/baseband.h +1
-1@@ -1,4 +1,4 @@ -* SPDX-License-Identifier: GPL-2.0+ */ +/* SPDX-License-Identifier: GPL-2.0+ */ This patch does not apply to my tree :(
Quoted 2 lines
I didn't understand why it doesn't apply to your tree.
Neither do I :)
Please try rebasing your patch on the top of my staging-testing branch and see if that produces a different patch or not. If it does, please resend.
Quoted 8 lines
Quoted 3 lines
thanks,
greg k-h
I will rebase it and send it again.
Also, I want to make sure whether you got a similar patch with same commit log or not.
I have no idea.
Remember, I get over 1000 emails a day to do something with, I have the short-term memory of a squirrel and have no idea if someone has sent something prior to this at all, sorry.
It is your job as a patch submitter to make it as easy as possible for me to apply patches. Sometimes that requires extra work, and rebasing patches due to other people's patches colliding with your work. That's just part of the development process.
thanks,
greg k-h
Quoted 52 lines · Greg KH
Quoted 36 lines · Madhumthia Prabakaran
Quoted 35 lines · Greg KH
Quoted 25 lines · Madhumthia Prabakaran
Quoted 12 lines · Greg KH
Quoted 11 lines · Madhumitha Prabakaran
FIx the warning by changing comment style based on header file type as per License identifier syntax
Signed-off-by Madhumitha Prabakaran <[email protected]>---
Changes in v2
- Modified subject line and commit logdrivers/staging/vt6655/baseband.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Quoted 10 lines
drivers/staging/vt6655/baseband.h line 1
Quoted 7 lines
drivers/staging/vt6655/baseband.h +1
-1@@ -1,4 +1,4 @@ -* SPDX-License-Identifier: GPL-2.0+ */ +/* SPDX-License-Identifier: GPL-2.0+ */ This patch does not apply to my tree :(
Quoted 2 lines
I didn't understand why it doesn't apply to your tree.
Neither do I :)
Please try rebasing your patch on the top of my staging-testing branch and see if that produces a different patch or not. If it does, please resend.
Quoted 8 lines
Quoted 3 lines
thanks,
greg k-h
I will rebase it and send it again.
Also, I want to make sure whether you got a similar patch with same commit log or not.
I have no idea.
Remember, I get over 1000 emails a day to do something with, I have the short-term memory of a squirrel and have no idea if someone has sent something prior to this at all, sorry.
Quoted 8 lines
It is your job as a patch submitter to make it as easy as possible for me to apply patches. Sometimes that requires extra work, and rebasing patches due to other people's patches colliding with your work. That's just part of the development process.
thanks,
greg k-h
No problem, I understand. I will rebase it and send it again.
Thanks,
Madhumitha
Quoted 25 lines · Madhumthia Prabakaran
Quoted 12 lines · Greg KH
Quoted 11 lines · Madhumitha Prabakaran
FIx the warning by changing comment style based on header file type as per License identifier syntax
Signed-off-by Madhumitha Prabakaran <[email protected]>---
Changes in v2
- Modified subject line and commit logdrivers/staging/vt6655/baseband.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Quoted 10 lines
drivers/staging/vt6655/baseband.h line 1
Quoted 7 lines
drivers/staging/vt6655/baseband.h +1
-1@@ -1,4 +1,4 @@ -* SPDX-License-Identifier: GPL-2.0+ */ +/* SPDX-License-Identifier: GPL-2.0+ */ This patch does not apply to my tree :(
Quoted 1 line
I didn't understand why it doesn't apply to your tree.
The - line is not a valid comment. That is surely not what there was before in the kernel.
julia
Quoted 8 lines
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190227164328.GB22354%40madhuleo.
For more options, visit https://groups.google.com/d/optout.