Staging: vt6655: Alignment of static function declaration
PATCH v3 1/1 Staging: vt6655: Alignment of static function declaration
Align function arguments and function return type to improve readability.
---
Changes in v3
- Included driver name in subject line.
Changes in v2
- Improved alignment of function declaration
- Modified subject line and commit log
--- drivers/staging/vt6655/card.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/vt6655/card.c +1 -1
@@ -62,7 +62,7 @@ static const unsigned short cwRXBCNTSFOff[MAX_RATE] = {static void s_vCalculateOFDMRParameter (unsigned char byRate,u8 bb_type,unsigned char *pbyTxRate, -unsigned char *pbyRsvTime) +unsigned char *pbyRsvTime);/*--------------------- Export Functions --------------------------*/
Signature · 1 line
2.17.1
Greg KH
maintainerQuoted 20 lines · Madhumitha Prabakaran
Align function arguments and function return type to improve readability.
Signed-off-by Madhumitha Prabakaran <[email protected]>---
Changes in v3
- Included driver name in subject line.Changes in v2
- Improved alignment of function declaration
- Modified subject line and commit log--- drivers/staging/vt6655/card.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/vt6655/card.c +0
-0
drivers/staging/vt6655/card.c static const unsigned short cwRXBCNTSFOff[MAX_RATE] = { · line 65
Quoted 5 lines
drivers/staging/vt6655/card.c +1
-1@@ -62,7 +62,7 @@ static const unsigned short cwRXBCNTSFOff[MAX_RATE] = {static void s_vCalculateOFDMRParameter (unsigned char byRate,u8 bb_type,unsigned char *pbyTxRate, -unsigned char *pbyRsvTime) +unsigned char *pbyRsvTime);
The patch does not do what your changelog text says it is doing :(
Quoted 22 lines · Greg KH
Quoted 21 lines · Madhumitha Prabakaran
Align function arguments and function return type to improve readability.
Signed-off-by Madhumitha Prabakaran <[email protected]>---
Changes in v3
- Included driver name in subject line.Changes in v2
- Improved alignment of function declaration
- Modified subject line and commit log--- drivers/staging/vt6655/card.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/vt6655/card.c +0
-0@@ -62,7 +62,7 @@ static const unsigned short cwRXBCNTSFOff[MAX_RATE] = {
Quoted 6 lines
drivers/staging/vt6655/card.c static const unsigned short cwRXBCNTSFOff[MAX_RATE] = { · line 65
Quoted 4 lines
drivers/staging/vt6655/card.c +1
-1static void s_vCalculateOFDMRParameter (unsigned char byRate,u8 bb_type,unsigned char *pbyTxRate, -unsigned char *pbyRsvTime) +unsigned char *pbyRsvTime);The patch does not do what your changelog text says it is doing :(
I want to ensure whether you mean 'git diff' is not same as it is stated in commit log. I think, i didn't reset the commited patch and just edited the subject line. Please correct me, if I'm wrong
Greg KH
maintainerQuoted 23 lines · Madhumthia Prabakaran
Quoted 22 lines · Greg KH
Quoted 21 lines · Madhumitha Prabakaran
Align function arguments and function return type to improve readability.
Signed-off-by Madhumitha Prabakaran <[email protected]>---
Changes in v3
- Included driver name in subject line.Changes in v2
- Improved alignment of function declaration
- Modified subject line and commit log--- drivers/staging/vt6655/card.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/vt6655/card.c +0
-0@@ -62,7 +62,7 @@ static const unsigned short cwRXBCNTSFOff[MAX_RATE] = {
Quoted 8 lines
Quoted 6 lines
drivers/staging/vt6655/card.c static const unsigned short cwRXBCNTSFOff[MAX_RATE] = { · line 65
Quoted 4 lines
drivers/staging/vt6655/card.c +1
-1static void s_vCalculateOFDMRParameter (unsigned char byRate,u8 bb_type,unsigned char *pbyTxRate, -unsigned char *pbyRsvTime) +unsigned char *pbyRsvTime);The patch does not do what your changelog text says it is doing :(
I want to ensure whether you mean 'git diff' is not same as it is stated in commit log. I think, i didn't reset the commited patch and just edited the subject line. Please correct me, if I'm wrong
I have no idea what you did here, but the diff here is not doing what your changelog says it is doing. So something got out of sync.
greg k-h
Quoted 31 lines · Greg KH
Quoted 30 lines · Madhumthia Prabakaran
Quoted 28 lines · Greg KH
Quoted 20 lines · Madhumitha Prabakaran
Align function arguments and function return type to improve readability.
Signed-off-by Madhumitha Prabakaran <[email protected]>---
Changes in v3
- Included driver name in subject line.Changes in v2
- Improved alignment of function declaration
- Modified subject line and commit log--- drivers/staging/vt6655/card.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/vt6655/card.c +0
-0drivers/staging/vt6655/card.c static const unsigned short cwRXBCNTSFOff[MAX_RATE] = { · line 65
Quoted 5 lines
drivers/staging/vt6655/card.c +1
-1@@ -62,7 +62,7 @@ static const unsigned short cwRXBCNTSFOff[MAX_RATE] = {static void s_vCalculateOFDMRParameter (unsigned char byRate,u8 bb_type,unsigned char *pbyTxRate, -unsigned char *pbyRsvTime) +unsigned char *pbyRsvTime);The patch does not do what your changelog text says it is doing :(
Quoted 6 lines
Quoted 1 line
I want to ensure whether you mean 'git diff' is not same as it is stated in commit log. I think, i didn't reset the commited patch and just edited the subject line. Please correct me, if I'm wrong
I have no idea what you did here, but the diff here is not doing what your changelog says it is doing. So something got out of sync.
greg k-h
I will fix it and update it. Thanks
Quoted 23 lines · Madhumthia Prabakaran
Quoted 22 lines · Greg KH
Quoted 21 lines · Madhumitha Prabakaran
Align function arguments and function return type to improve readability.
Signed-off-by Madhumitha Prabakaran <[email protected]>---
Changes in v3
- Included driver name in subject line.Changes in v2
- Improved alignment of function declaration
- Modified subject line and commit log--- drivers/staging/vt6655/card.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/vt6655/card.c +0
-0@@ -62,7 +62,7 @@ static const unsigned short cwRXBCNTSFOff[MAX_RATE] = {
Quoted 8 lines
Quoted 6 lines
drivers/staging/vt6655/card.c static const unsigned short cwRXBCNTSFOff[MAX_RATE] = { · line 65
Quoted 4 lines
drivers/staging/vt6655/card.c +1
-1static void s_vCalculateOFDMRParameter (unsigned char byRate,u8 bb_type,unsigned char *pbyTxRate, -unsigned char *pbyRsvTime) +unsigned char *pbyRsvTime);The patch does not do what your changelog text says it is doing :(
I want to ensure whether you mean 'git diff' is not same as it is stated in commit log. I think, i didn't reset the commited patch and just edited the subject line. Please correct me, if I'm wrong
The issue is that the effect of your patch is to add a semicolon. But I suspect that the semicolon was there in the original code. You removed it at some point, and then added it back.
julia
Quoted 8 lines
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190227163950.GA22354%40madhuleo.
For more options, visit https://groups.google.com/d/optout.
Quoted 34 lines · Julia Lawall
Quoted 30 lines · Madhumthia Prabakaran
Quoted 28 lines · Greg KH
Quoted 20 lines · Madhumitha Prabakaran
Align function arguments and function return type to improve readability.
Signed-off-by Madhumitha Prabakaran <[email protected]>---
Changes in v3
- Included driver name in subject line.Changes in v2
- Improved alignment of function declaration
- Modified subject line and commit log--- drivers/staging/vt6655/card.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/vt6655/card.c +0
-0drivers/staging/vt6655/card.c static const unsigned short cwRXBCNTSFOff[MAX_RATE] = { · line 65
Quoted 5 lines
drivers/staging/vt6655/card.c +1
-1@@ -62,7 +62,7 @@ static const unsigned short cwRXBCNTSFOff[MAX_RATE] = {static void s_vCalculateOFDMRParameter (unsigned char byRate,u8 bb_type,unsigned char *pbyTxRate, -unsigned char *pbyRsvTime) +unsigned char *pbyRsvTime);The patch does not do what your changelog text says it is doing :(
Quoted 16 lines
Quoted 1 line
I want to ensure whether you mean 'git diff' is not same as it is stated in commit log. I think, i didn't reset the commited patch and just edited the subject line. Please correct me, if I'm wrong
The issue is that the effect of your patch is to add a semicolon. But I suspect that the semicolon was there in the original code. You removed it at some point, and then added it back.
julia
Quoted 8 lines
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190227163950.GA22354%40madhuleo.
For more options, visit https://groups.google.com/d/optout.
Instead of reviewing and rebasing a patch, I used a wrong technique to commit it. I will fix and resend it.
Thanks,
Madhumitha