Skip to contentSkip to conversation

Staging: vt6655: Alignment of function declaration

PATCH In review Madhumitha Prabakaran 2 participants 2 messages Feb 27, 2019 Staging

lore
Share & tools
lore
#0 lore raw

PATCH v4 1/1 Staging: vt6655: Alignment of function declaration

Align function arguments and function type to improve readability.

---
Changes in v4-
- Log message and git diff are matching. Change is made on code in Greg's tree

Changes in v3-
- Included driver name in subject line

Changes in v2-
- Modified subject line and commit log

---
 drivers/staging/vt6655/card.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/staging/vt6655/card.c +1 -4
index 52e9e6b90b56..3226dbaab3bb 100644
@@ -506,10 +506,7 @@ bool CARDbRadioPowerOn(struct vnt_private *priv)
 	return bResult;
 }
 
-void
-CARDvSafeResetTx(
-	struct vnt_private *priv
-)
+void CARDvSafeResetTx(struct vnt_private *priv)
 {
 	unsigned int uu;
 	struct vnt_tx_desc *pCurrTD;
Signature · 1 line
2.17.1
#1 lore raw
Quoted 22 lines · Madhumitha Prabakaran

Align function arguments and function type to improve readability.

---
Changes in v4-
- Log message and git diff are matching. Change is made on code in Greg's tree

Changes in v3-
- Included driver name in subject line

Changes in v2-
- Modified subject line and commit log

---
 drivers/staging/vt6655/card.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/staging/vt6655/card.c +0 -0
index 52e9e6b90b56..3226dbaab3bb 100644

drivers/staging/vt6655/card.c bool CARDbRadioPowerOn(struct vnt_private *priv) · line 509

Quoted 8 lines
drivers/staging/vt6655/card.c +1 -4
@@ -506,10 +506,7 @@ bool CARDbRadioPowerOn(struct vnt_private *priv)
 	return bResult;
 }
 
-void
-CARDvSafeResetTx(
-	struct vnt_private *priv
-)
+void CARDvSafeResetTx(struct vnt_private *priv)

This looks better. I pulled Greg's tree and this applied fine.

julia

Quoted 13 lines
drivers/staging/vt6655/card.c +0 -1
 {
 	unsigned int uu;
 	struct vnt_tx_desc *pCurrTD;
--

2.17.1

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190227205040.9881-1-madhumithabiw%40gmail.com.
For more options, visit https://groups.google.com/d/optout.