Skip to contentSkip to conversation

Staging: vt6655: Alignment of function declaration

PATCH Superseded Madhumitha Prabakaran 3 participants 3 messages Feb 27, 2019 Staging

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 Staging: vt6655: Alignment of function declaration

Align function arguments and function type to improve readability.

---
Changes in v3-
-Included driver name in subject line

Changes in v2-
- Modified subject line and commit log

---
 drivers/staging/vt6655/card.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/vt6655/card.c +1 -1
index 2996bf614caa..8d0182f5725c 100644
@@ -499,7 +499,7 @@ bool CARDbRadioPowerOn(struct vnt_private *priv)
 	return bResult;
 }
 
-void CARDvSafeResetTx(truct vnt_private *priv)
+void CARDvSafeResetTx(struct vnt_private *priv)
 {
 	unsigned int uu;
 	struct vnt_tx_desc *pCurrTD;
Signature · 1 line
2.17.1
maintainer
#1 lore raw
Quoted 18 lines · Madhumitha Prabakaran

Align function arguments and function type to improve readability.

---
Changes in v3-
-Included driver name in subject line

Changes in v2-
- Modified subject line and commit log

---
 drivers/staging/vt6655/card.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/vt6655/card.c +0 -0
index 2996bf614caa..8d0182f5725c 100644

drivers/staging/vt6655/card.c bool CARDbRadioPowerOn(struct vnt_private *priv) · line 502

Quoted 5 lines
drivers/staging/vt6655/card.c +1 -1
@@ -499,7 +499,7 @@ bool CARDbRadioPowerOn(struct vnt_private *priv)
 	return bResult;
 }
 
-void CARDvSafeResetTx(truct vnt_private *priv)
+void CARDvSafeResetTx(struct vnt_private *priv)

Are you sure about this patch???

#2 lore raw
In reply to Madhumitha Prabakaran
Quoted 18 lines · Madhumitha Prabakaran

Align function arguments and function type to improve readability.

---
Changes in v3-
-Included driver name in subject line

Changes in v2-
- Modified subject line and commit log

---
 drivers/staging/vt6655/card.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/vt6655/card.c +0 -0
index 2996bf614caa..8d0182f5725c 100644

drivers/staging/vt6655/card.c bool CARDbRadioPowerOn(struct vnt_private *priv) · line 502

Quoted 4 lines
drivers/staging/vt6655/card.c +0 -1
@@ -499,7 +499,7 @@ bool CARDbRadioPowerOn(struct vnt_private *priv)
 	return bResult;
 }
 
-void CARDvSafeResetTx(truct vnt_private *priv)

This is invalid code and clearly was not in the kernel previously. I think that you are making your changes based on some change you previously made, rather than based on the code in Greg's tree.

julia

Quoted 14 lines
drivers/staging/vt6655/card.c +1 -1
+void CARDvSafeResetTx(struct vnt_private *priv)
 {
 	unsigned int uu;
 	struct vnt_tx_desc *pCurrTD;
--

2.17.1

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190227161227.22128-1-madhumithabiw%40gmail.com.
For more options, visit https://groups.google.com/d/optout.