Skip to contentSkip to conversation

dt-bindings: misc: aspeed-p2a-ctrl: add support

PATCH Superseded Patrick Venture 2 participants 5 messages Mar 4, 2019 – Mar 12, 2019

Subsystems (2)

v6 of 10 Superseded Latest is v10 →

lore
Share & tools
lore
#0 lore raw

PATCH v6 1/2 dt-bindings: misc: aspeed-p2a-ctrl: add support

Document the ast2400, ast2500 PCI-to-AHB bridge control driver bindings.

---
Changes for v6:
- None
Changes for v5:
- None
Changes for v4:
- None
Changes for v3:
- None
Changes for v2:
- Added comment about syscon required parameter.

---
 .../bindings/misc/aspeed-p2a-ctrl.txt         | 32 +++++++++++++++++++
 1 file changed, 32 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/misc/aspeed-p2a-ctrl.txt
Documentation/devicetree/bindings/misc/aspeed-p2a-ctrl.txt new file +32 -0
new file mode 100644
index 000000000000..1092d62d1c92
@@ -0,0 +1,32 @@
+======================================================================
+Device tree bindings for Aspeed AST2400/AST2500 PCI-to-AHB Bridge Control Driver
+======================================================================
+
+The bridge is available on platforms with the VGA enabled on the Aspeed device.
+In this case, the host has access to a 64KiB window into all of the BMC's
+memory.  The BMC can disable this bridge.  If the bridge is enabled, the host
+has read access to all the regions of memory, however the host only has read
+and write access depending on a register controlled by the BMC.
+
+Required properties:
+===================
+
+ - compatible: must be one of:
+	- "aspeed,ast2400-p2a-ctrl"
+	- "aspeed,ast2500-p2a-ctrl"
+
+ - syscon: handle to syscon device node controlling PCI.
+
+Optional properties:
+===================
+
+- memory-region: A phandle to a reserved_memory region to be used for the PCI
+		to AHB mapping
+
+Example:
+
+p2a: p2a-control at 1e6e2000 {
+	compatible = "aspeed,ast2400-p2a-ctrl";
+	memory-region = <&reserved_memory>;
+	syscon = <&syscon>;
+};
Signature · 1 line
2.21.0.352.gf09ad66450-goog
maintainer
#1 lore raw
Quoted 46 lines · Patrick Venture

Document the ast2400, ast2500 PCI-to-AHB bridge control driver bindings.

---
Changes for v6:
- None
Changes for v5:
- None
Changes for v4:
- None
Changes for v3:
- None
Changes for v2:
- Added comment about syscon required parameter.

---
 .../bindings/misc/aspeed-p2a-ctrl.txt         | 32 +++++++++++++++++++
 1 file changed, 32 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/misc/aspeed-p2a-ctrl.txt
Documentation/devicetree/bindings/misc/aspeed-p2a-ctrl.txt new file +21 -0
new file mode 100644
index 000000000000..1092d62d1c92
@@ -0,0 +1,32 @@
+======================================================================
+Device tree bindings for Aspeed AST2400/AST2500 PCI-to-AHB Bridge Control Driver
+======================================================================
+
+The bridge is available on platforms with the VGA enabled on the Aspeed device.
+In this case, the host has access to a 64KiB window into all of the BMC's
+memory.  The BMC can disable this bridge.  If the bridge is enabled, the host
+has read access to all the regions of memory, however the host only has read
+and write access depending on a register controlled by the BMC.
+
+Required properties:
+===================
+
+ - compatible: must be one of:
+	- "aspeed,ast2400-p2a-ctrl"
+	- "aspeed,ast2500-p2a-ctrl"
+
+ - syscon: handle to syscon device node controlling PCI.
+
+Optional properties:
+===================

Documentation/devicetree/bindings/misc/aspeed-p2a-ctrl.txt line 31

Quoted 10 lines
Documentation/devicetree/bindings/misc/aspeed-p2a-ctrl.txt new file +10 -0
+
+- memory-region: A phandle to a reserved_memory region to be used for the PCI
+		to AHB mapping
+
+Example:
+
+p2a: p2a-control at 1e6e2000 {
+	compatible = "aspeed,ast2400-p2a-ctrl";
+	memory-region = <&reserved_memory>;
+	syscon = <&syscon>;

Make this node a child of what you are pointing to instead if this the only control interface.

Rob

#2 lore raw
Quoted 53 lines · Rob Herring
Quoted 51 lines · Patrick Venture

Document the ast2400, ast2500 PCI-to-AHB bridge control driver bindings.

---
Changes for v6:
- None
Changes for v5:
- None
Changes for v4:
- None
Changes for v3:
- None
Changes for v2:
- Added comment about syscon required parameter.

---
 .../bindings/misc/aspeed-p2a-ctrl.txt         | 32 +++++++++++++++++++
 1 file changed, 32 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/misc/aspeed-p2a-ctrl.txt
Documentation/devicetree/bindings/misc/aspeed-p2a-ctrl.txt new file +26 -0
new file mode 100644
index 000000000000..1092d62d1c92
@@ -0,0 +1,32 @@
+======================================================================
+Device tree bindings for Aspeed AST2400/AST2500 PCI-to-AHB Bridge Control Driver
+======================================================================
+
+The bridge is available on platforms with the VGA enabled on the Aspeed device.
+In this case, the host has access to a 64KiB window into all of the BMC's
+memory.  The BMC can disable this bridge.  If the bridge is enabled, the host
+has read access to all the regions of memory, however the host only has read
+and write access depending on a register controlled by the BMC.
+
+Required properties:
+===================
+
+ - compatible: must be one of:
+     - "aspeed,ast2400-p2a-ctrl"
+     - "aspeed,ast2500-p2a-ctrl"
+
+ - syscon: handle to syscon device node controlling PCI.
+
+Optional properties:
+===================
+
+- memory-region: A phandle to a reserved_memory region to be used for the PCI
+             to AHB mapping
+
+Example:
Quoted 8 lines

Documentation/devicetree/bindings/misc/aspeed-p2a-ctrl.txt line 31

Quoted 5 lines
Documentation/devicetree/bindings/misc/aspeed-p2a-ctrl.txt new file +5 -0
+
+p2a: p2a-control at 1e6e2000 {
+     compatible = "aspeed,ast2400-p2a-ctrl";
+     memory-region = <&reserved_memory>;
+     syscon = <&syscon>;

Make this node a child of what you are pointing to instead if this the only control interface.

You're suggesting I make this a child of the syscon?

Quoted 5 lines

Rob

maintainer
#3 lore raw
Quoted 64 lines · Patrick Venture
Quoted 53 lines · Rob Herring
Quoted 51 lines · Patrick Venture

Document the ast2400, ast2500 PCI-to-AHB bridge control driver bindings.

---
Changes for v6:
- None
Changes for v5:
- None
Changes for v4:
- None
Changes for v3:
- None
Changes for v2:
- Added comment about syscon required parameter.

---
 .../bindings/misc/aspeed-p2a-ctrl.txt         | 32 +++++++++++++++++++
 1 file changed, 32 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/misc/aspeed-p2a-ctrl.txt
Documentation/devicetree/bindings/misc/aspeed-p2a-ctrl.txt new file +26 -0
new file mode 100644
index 000000000000..1092d62d1c92
@@ -0,0 +1,32 @@
+======================================================================
+Device tree bindings for Aspeed AST2400/AST2500 PCI-to-AHB Bridge Control Driver
+======================================================================
+
+The bridge is available on platforms with the VGA enabled on the Aspeed device.
+In this case, the host has access to a 64KiB window into all of the BMC's
+memory.  The BMC can disable this bridge.  If the bridge is enabled, the host
+has read access to all the regions of memory, however the host only has read
+and write access depending on a register controlled by the BMC.
+
+Required properties:
+===================
+
+ - compatible: must be one of:
+     - "aspeed,ast2400-p2a-ctrl"
+     - "aspeed,ast2500-p2a-ctrl"
+
+ - syscon: handle to syscon device node controlling PCI.
+
+Optional properties:
+===================
+
+- memory-region: A phandle to a reserved_memory region to be used for the PCI
+             to AHB mapping
+
+Example:
Quoted 8 lines

Documentation/devicetree/bindings/misc/aspeed-p2a-ctrl.txt line 31

Quoted 5 lines
Documentation/devicetree/bindings/misc/aspeed-p2a-ctrl.txt new file +5 -0
+
+p2a: p2a-control at 1e6e2000 {
+     compatible = "aspeed,ast2400-p2a-ctrl";
+     memory-region = <&reserved_memory>;
+     syscon = <&syscon>;

Make this node a child of what you are pointing to instead if this the only control interface.

Quoted 1 line

You're suggesting I make this a child of the syscon?

Yes.

Rob

#4 lore raw
Quoted 66 lines · Rob Herring
Quoted 64 lines · Patrick Venture
Quoted 61 lines · Rob Herring
Quoted 46 lines · Patrick Venture

Document the ast2400, ast2500 PCI-to-AHB bridge control driver bindings.

---
Changes for v6:
- None
Changes for v5:
- None
Changes for v4:
- None
Changes for v3:
- None
Changes for v2:
- Added comment about syscon required parameter.

---
 .../bindings/misc/aspeed-p2a-ctrl.txt         | 32 +++++++++++++++++++
 1 file changed, 32 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/misc/aspeed-p2a-ctrl.txt
Documentation/devicetree/bindings/misc/aspeed-p2a-ctrl.txt new file +21 -0
new file mode 100644
index 000000000000..1092d62d1c92
@@ -0,0 +1,32 @@
+======================================================================
+Device tree bindings for Aspeed AST2400/AST2500 PCI-to-AHB Bridge Control Driver
+======================================================================
+
+The bridge is available on platforms with the VGA enabled on the Aspeed device.
+In this case, the host has access to a 64KiB window into all of the BMC's
+memory.  The BMC can disable this bridge.  If the bridge is enabled, the host
+has read access to all the regions of memory, however the host only has read
+and write access depending on a register controlled by the BMC.
+
+Required properties:
+===================
+
+ - compatible: must be one of:
+     - "aspeed,ast2400-p2a-ctrl"
+     - "aspeed,ast2500-p2a-ctrl"
+
+ - syscon: handle to syscon device node controlling PCI.
+
+Optional properties:
+===================

Documentation/devicetree/bindings/misc/aspeed-p2a-ctrl.txt line 31

Quoted 10 lines
Documentation/devicetree/bindings/misc/aspeed-p2a-ctrl.txt new file +10 -0
+
+- memory-region: A phandle to a reserved_memory region to be used for the PCI
+             to AHB mapping
+
+Example:
+
+p2a: p2a-control at 1e6e2000 {
+     compatible = "aspeed,ast2400-p2a-ctrl";
+     memory-region = <&reserved_memory>;
+     syscon = <&syscon>;

Make this node a child of what you are pointing to instead if this the only control interface.

Quoted 3 lines
Quoted 1 line

You're suggesting I make this a child of the syscon?

Yes.

Roger that, will update and send out a patchset v6 with the corresponding changes.

Quoted 2 lines

Rob