drivers: ifpga_rawdev: fix fd leak in rte_fpga_do_pr
PATCH v3 1/1 drivers: ifpga_rawdev: fix fd leak in rte_fpga_do_pr
In rte_fpga_do_pr() function, if 'stat' return error the 'file_fd' is never closed thus leading a fd leak. This patch avoids this.
Coverity issue: 279441
Fixes ef1e8ede3da59e("raw/ifpga: add Intel FPGA bus rawdev driver")
Signed-off-by Li Qiang <[email protected]>
---
Change since v2: add proper tags in commit message
drivers/raw/ifpga_rawdev/ifpga_rawdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/raw/ifpga_rawdev/ifpga_rawdev.c +2 -1
@@ -244,7 +244,8 @@ rte_fpga_do_pr(struct rte_rawdev *rawdev, int port_id,if (ret) {IFPGA_RAWDEV_PMD_ERR ("stat on bitstream file failed: %s\n" , file_name); -return -EINVAL ; + ret = -EINVAL ; + goto close_fd; } buffer_size = file_stat.st_size;IFPGA_RAWDEV_PMD_INFO ("bitstream file size: %zu\n" , buffer_size);
Signature · 1 line
2.19.1.3.ge56e4f7