Skip to contentSkip to conversation

arm: kirkwood: dts: Add openrd-* dtb makefile build targets

PATCH New Stefan Roese 3 participants 14 messages Apr 11, 2019 – Apr 26, 2019 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

PATCH 1/3 arm: kirkwood: dts: Add openrd-* dtb makefile build targets

The following Kirkwood dtb build targets are currently missing:

kirkwood-openrd-base.dtb
kirkwood-openrd-client.dtb
kirkwood-openrd-ultimate.dtb

This patch adds them to the Makefile to fix the build error.

---
 arch/arm/dts/Makefile | 3 +++
 1 file changed, 3 insertions(+)
arch/arm/dts/Makefile +3 -0
index 4f05df1321..f36b801219 100644
@@ -56,6 +56,9 @@ dtb-$(CONFIG_KIRKWOOD) += \
 	kirkwood-ns2lite.dtb \
 	kirkwood-ns2max.dtb \
 	kirkwood-ns2mini.dtb \
+	kirkwood-openrd-base.dtb \
+	kirkwood-openrd-client.dtb \
+	kirkwood-openrd-ultimate.dtb \
 	kirkwood-pogo_e02.dtb \
 	kirkwood-sheevaplug.dtb
 
Signature · 1 line
2.21.0
#1 lore raw

PATCH 1/3 arm: kirkwood: dts: Add openrd-* dtb makefile build targets

Quoted 10 lines · Stefan Roese

The following Kirkwood dtb build targets are currently missing:

kirkwood-openrd-base.dtb
kirkwood-openrd-client.dtb
kirkwood-openrd-ultimate.dtb

This patch adds them to the Makefile to fix the build error.

Applied to u-boot-marvell/master.

Thanks,
Stefan

#2 lore raw

PATCH 2/3 arm: kirkwood: openrd: Remove superfluous CONFIG_ENV_ADDR

In reply to Stefan Roese

Remove the superfluous CONFIG_ENV_ADDR definition. Its not needed as CONFIG_ENV_OFFSET is also set to the same value.

---
 include/configs/openrd.h | 1 -
 1 file changed, 1 deletion(-)
include/configs/openrd.h +0 -1
index 17611bc568..c96d4c4d48 100644
@@ -41,7 +41,6 @@
  * it has to be rounded to sector size
  */
 #define CONFIG_ENV_SIZE			0x20000	/* 128k */
-#define CONFIG_ENV_ADDR			0x60000
 #define CONFIG_ENV_OFFSET		0x60000	/* env starts here */
 /*
  * Environment is right behind U-Boot in flash. Make sure U-Boot
Signature · 1 line
2.21.0
#3 lore raw

PATCH 2/3 arm: kirkwood: openrd: Remove superfluous CONFIG_ENV_ADDR

Quoted 6 lines · Stefan Roese,

Remove the superfluous CONFIG_ENV_ADDR definition. Its not needed as CONFIG_ENV_OFFSET is also set to the same value.

Quoted 20 lines
---
 include/configs/openrd.h | 1 -
 1 file changed, 1 deletion(-)
include/configs/openrd.h +0 -2
index 17611bc568..c96d4c4d48 100644
@@ -41,7 +41,6 @@
  * it has to be rounded to sector size
  */
 #define CONFIG_ENV_SIZE                        0x20000 /* 128k */
-#define CONFIG_ENV_ADDR                        0x60000
 #define CONFIG_ENV_OFFSET              0x60000 /* env starts here */
 /*
  * Environment is right behind U-Boot in flash. Make sure U-Boot
--

2.21.0

#5 lore raw

PATCH 1/3 arm: kirkwood: dts: Add openrd-* dtb makefile build targets

In reply to Stefan Roese
Quoted 11 lines · Stefan Roese,

The following Kirkwood dtb build targets are currently missing:

kirkwood-openrd-base.dtb
kirkwood-openrd-client.dtb
kirkwood-openrd-ultimate.dtb

This patch adds them to the Makefile to fix the build error.

Quoted 22 lines
---
 arch/arm/dts/Makefile | 3 +++
 1 file changed, 3 insertions(+)
arch/arm/dts/Makefile +3 -1
index 4f05df1321..f36b801219 100644
@@ -56,6 +56,9 @@ dtb-$(CONFIG_KIRKWOOD) += \
        kirkwood-ns2lite.dtb \
        kirkwood-ns2max.dtb \
        kirkwood-ns2mini.dtb \
+       kirkwood-openrd-base.dtb \
+       kirkwood-openrd-client.dtb \
+       kirkwood-openrd-ultimate.dtb \
        kirkwood-pogo_e02.dtb \
        kirkwood-sheevaplug.dtb
 
--

2.21.0

#6 lore raw

PATCH 3/3 arm: kirkwood: openrd: Increase U-Boot size in flash to make it fit

In reply to Stefan Roese

We have run now multiple times into size issues with the openrd board port. To finally fix this, this patch now moves the U-Boot size from 0x6.0000 to 0x8.0000, giving enough space for the next time.

This also changes the environment location and potentially the MTD partitioning, but I see no better fix for now. Especially since this board does not have an active maintainer.

---
 include/configs/openrd.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/configs/openrd.h +1 -1
index c96d4c4d48..62d8862cc7 100644
@@ -41,7 +41,7 @@
  * it has to be rounded to sector size
  */
 #define CONFIG_ENV_SIZE			0x20000	/* 128k */
-#define CONFIG_ENV_OFFSET		0x60000	/* env starts here */
+#define CONFIG_ENV_OFFSET		0x80000	/* env starts here */
 /*
  * Environment is right behind U-Boot in flash. Make sure U-Boot
  * doesn't grow into the environment area.
Signature · 1 line
2.21.0
#7 lore raw

PATCH 3/3 arm: kirkwood: openrd: Increase U-Boot size in flash to make it fit

Quoted 10 lines · Stefan Roese,

We have run now multiple times into size issues with the openrd board port. To finally fix this, this patch now moves the U-Boot size from 0x6.0000 to 0x8.0000, giving enough space for the next time.

This also changes the environment location and potentially the MTD partitioning, but I see no better fix for now. Especially since this board does not have an active maintainer.

One alternative option I looked at was trimming down the dtb to drop the nodes that aren't used in u-boot. This might just get it under the 0x60000 limit ... for a while.

I agree that this is the best approach in leiu of anyone maintiaining the board. Once this is applied the openrd boards can be reenabled in travis.

---

Quoted 20 lines
 include/configs/openrd.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/configs/openrd.h +1 -2
index c96d4c4d48..62d8862cc7 100644
@@ -41,7 +41,7 @@
  * it has to be rounded to sector size
  */
 #define CONFIG_ENV_SIZE                        0x20000 /* 128k */
-#define CONFIG_ENV_OFFSET              0x60000 /* env starts here */
+#define CONFIG_ENV_OFFSET              0x80000 /* env starts here */
 /*
  * Environment is right behind U-Boot in flash. Make sure U-Boot
  * doesn't grow into the environment area.
--

2.21.0

#8 lore raw

PATCH 3/3 arm: kirkwood: openrd: Increase U-Boot size in flash to make it fit

Quoted 14 lines · Chris Packham
Quoted 10 lines · Stefan Roese,

We have run now multiple times into size issues with the openrd board port. To finally fix this, this patch now moves the U-Boot size from 0x6.0000 to 0x8.0000, giving enough space for the next time.

This also changes the environment location and potentially the MTD partitioning, but I see no better fix for now. Especially since this board does not have an active maintainer.

Quoted 8 lines

One alternative option I looked at was trimming down the dtb to drop the nodes that aren't used in u-boot. This might just get it under the 0x60000 limit ... for a while.

I agree that this is the best approach in leiu of anyone maintiaining the board. Once this is applied the openrd boards can be reenabled in travis.

Please note the board is currently orphaned and excluded from travis builds due to the size problem. So if someone is going to address this, I want to see the board un-orphaned too (and travis updated to build it again), thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190413/61a63c16/attachment.sig>
#9 lore raw

PATCH 3/3 arm: kirkwood: openrd: Increase U-Boot size in flash to make it fit

Quoted 22 lines · Tom Rini
Quoted 21 lines · Chris Packham
Quoted 10 lines · Stefan Roese,

We have run now multiple times into size issues with the openrd board port. To finally fix this, this patch now moves the U-Boot size from 0x6.0000 to 0x8.0000, giving enough space for the next time.

This also changes the environment location and potentially the MTD partitioning, but I see no better fix for now. Especially since this board does not have an active maintainer.

One alternative option I looked at was trimming down the dtb to drop the nodes that aren't used in u-boot. This might just get it under the 0x60000 limit ... for a while.

I agree that this is the best approach in leiu of anyone maintiaining the board. Once this is applied the openrd boards can be reenabled in travis.

Quoted 6 lines
Quoted 1 line

Please note the board is currently orphaned and excluded from travis builds due to the size problem. So if someone is going to address this, I want to see the board un-orphaned too (and travis updated to build it again), thanks!

Anyone? Thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190424/ce524ae3/attachment.sig>
#10 lore raw

PATCH 3/3 arm: kirkwood: openrd: Increase U-Boot size in flash to make it fit

Quoted 23 lines · Tom Rini
Quoted 22 lines · Tom Rini
Quoted 21 lines · Chris Packham
Quoted 10 lines · Stefan Roese,

We have run now multiple times into size issues with the openrd board port. To finally fix this, this patch now moves the U-Boot size from 0x6.0000 to 0x8.0000, giving enough space for the next time.

This also changes the environment location and potentially the MTD partitioning, but I see no better fix for now. Especially since this board does not have an active maintainer.

One alternative option I looked at was trimming down the dtb to drop the nodes that aren't used in u-boot. This might just get it under the 0x60000 limit ... for a while.

I agree that this is the best approach in leiu of anyone maintiaining the board. Once this is applied the openrd boards can be reenabled in travis.

Quoted 8 lines
Quoted 6 lines
Quoted 1 line

Please note the board is currently orphaned and excluded from travis builds due to the size problem. So if someone is going to address this, I want to see the board un-orphaned too (and travis updated to build it again), thanks!

Anyone? Thanks!

I can add myself as maintainer and add it back to the travis builds. Even though I can only compile test because I don't have access to this board.

Thanks,
Stefan

#11 lore raw

PATCH 3/3 arm: kirkwood: openrd: Increase U-Boot size in flash to make it fit

Quoted 31 lines · Stefan Roese
Quoted 30 lines · Tom Rini
Quoted 28 lines · Tom Rini
Quoted 14 lines · Chris Packham
Quoted 10 lines · Stefan Roese,

We have run now multiple times into size issues with the openrd board port. To finally fix this, this patch now moves the U-Boot size from 0x6.0000 to 0x8.0000, giving enough space for the next time.

This also changes the environment location and potentially the MTD partitioning, but I see no better fix for now. Especially since this board does not have an active maintainer.

Quoted 8 lines

One alternative option I looked at was trimming down the dtb to drop the nodes that aren't used in u-boot. This might just get it under the 0x60000 limit ... for a while.

I agree that this is the best approach in leiu of anyone maintiaining the board. Once this is applied the openrd boards can be reenabled in travis.

Please note the board is currently orphaned and excluded from travis builds due to the size problem. So if someone is going to address this, I want to see the board un-orphaned too (and travis updated to build it again), thanks!

Quoted 5 lines
Quoted 1 line

Anyone? Thanks!

I can add myself as maintainer and add it back to the travis builds. Even though I can only compile test because I don't have access to this board.

OK. Make sure to include updating the travis rules when you update the MAINTAINERS file, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190424/75e4b5a1/attachment.sig>
#12 lore raw

PATCH 3/3 arm: kirkwood: openrd: Increase U-Boot size in flash to make it fit

Quoted 32 lines · Tom Rini
Quoted 31 lines · Stefan Roese
Quoted 30 lines · Tom Rini
Quoted 28 lines · Tom Rini
Quoted 14 lines · Chris Packham
Quoted 10 lines · Stefan Roese,

We have run now multiple times into size issues with the openrd board port. To finally fix this, this patch now moves the U-Boot size from 0x6.0000 to 0x8.0000, giving enough space for the next time.

This also changes the environment location and potentially the MTD partitioning, but I see no better fix for now. Especially since this board does not have an active maintainer.

Quoted 8 lines

One alternative option I looked at was trimming down the dtb to drop the nodes that aren't used in u-boot. This might just get it under the 0x60000 limit ... for a while.

I agree that this is the best approach in leiu of anyone maintiaining the board. Once this is applied the openrd boards can be reenabled in travis.

Please note the board is currently orphaned and excluded from travis builds due to the size problem. So if someone is going to address this, I want to see the board un-orphaned too (and travis updated to build it again), thanks!

Quoted 8 lines
Quoted 5 lines
Quoted 1 line

Anyone? Thanks!

I can add myself as maintainer and add it back to the travis builds. Even though I can only compile test because I don't have access to this board.

OK. Make sure to include updating the travis rules when you update the MAINTAINERS file, thanks!

Yep. I'll send a patch for this once I've pushed this patch here to mainline, which should happen shortly.

Thanks,
Stefan

#13 lore raw

PATCH 3/3 arm: kirkwood: openrd: Increase U-Boot size in flash to make it fit

In reply to Stefan Roese
Quoted 10 lines · Stefan Roese

We have run now multiple times into size issues with the openrd board port. To finally fix this, this patch now moves the U-Boot size from 0x6.0000 to 0x8.0000, giving enough space for the next time.

This also changes the environment location and potentially the MTD partitioning, but I see no better fix for now. Especially since this board does not have an active maintainer.

Applied to u-boot-marvell/master.

Thanks,
Stefan