Skip to contentSkip to conversation

arm64: dts: ls1028a: Add USB dt nodes

PATCH Superseded Ran Wang 2 participants 5 messages Apr 26, 2019 – May 8, 2019

Subsystems (2)

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore

Ran Wang

author
#0 lore raw

PATCH v2 1/1 arm64: dts: ls1028a: Add USB dt nodes

This patch adds USB dt nodes for LS1028A.

---
Changes in v2:
- Rename node from usb3@... to usb@... to meet DTSpec

 arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi |   20 ++++++++++++++++++++
 1 files changed, 20 insertions(+), 0 deletions(-)
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi +20 -0
index 8dd3501..188cfb8 100644
@@ -144,6 +144,26 @@
 			clocks = <&sysclk>;
 		};
 
+		usb0:usb@3100000 {
+			compatible= "snps,dwc3";
+			reg= <0x0 0x3100000 0x0 0x10000>;
+			interrupts= <0 80 0x4>;
+			dr_mode= "host";
+			snps,dis_rxdet_inp3_quirk;
+			snps,quirk-frame-length-adjustment = <0x20>;
+			snps,incr-burst-type-adjustment = <1>, <4>, <8>, <16>;
+		};
+
+		usb1:usb@3110000 {
+			compatible= "snps,dwc3";
+			reg= <0x0 0x3110000 0x0 0x10000>;
+			interrupts= <0 81 0x4>;
+			dr_mode= "host";
+			snps,dis_rxdet_inp3_quirk;
+			snps,quirk-frame-length-adjustment = <0x20>;
+			snps,incr-burst-type-adjustment = <1>, <4>, <8>, <16>;
+		};
+
 		i2c0: i2c@2000000 {
 			compatible = "fsl,vf610-i2c";
 			#address-cells = <1>;
Signature · 1 line
1.7.1
maintainer
#1 lore raw
Quoted 15 lines · Ran Wang

This patch adds USB dt nodes for LS1028A.

---
Changes in v2:
- Rename node from usb3@... to usb@... to meet DTSpec

 arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi |   20 ++++++++++++++++++++
 1 files changed, 20 insertions(+), 0 deletions(-)
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi +0 -0
index 8dd3501..188cfb8 100644

arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi line 147

Quoted 4 lines
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi +1 -0
@@ -144,6 +144,26 @@
 			clocks = <&sysclk>;
 		};
 
+		usb0:usb@3100000 {

^ space needed

arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi line 148

Quoted 1 line
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi +1 -0
+			compatible= "snps,dwc3";

Needs an SoC specific compatible.

Quoted 24 lines
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi +18 -0
+			reg= <0x0 0x3100000 0x0 0x10000>;
+			interrupts= <0 80 0x4>;
+			dr_mode= "host";
+			snps,dis_rxdet_inp3_quirk;
+			snps,quirk-frame-length-adjustment = <0x20>;
+			snps,incr-burst-type-adjustment = <1>, <4>, <8>, <16>;
+		};
+
+		usb1:usb@3110000 {
+			compatible= "snps,dwc3";
+			reg= <0x0 0x3110000 0x0 0x10000>;
+			interrupts= <0 81 0x4>;
+			dr_mode= "host";
+			snps,dis_rxdet_inp3_quirk;
+			snps,quirk-frame-length-adjustment = <0x20>;
+			snps,incr-burst-type-adjustment = <1>, <4>, <8>, <16>;
+		};
+
 		i2c0: i2c@2000000 {
 			compatible = "fsl,vf610-i2c";
 			#address-cells = <1>;
Signature · 1 line
1.7.1
author
#2 lore raw

Hi Rob,

Quoted 22 lines · On Thursday, May 02, 2019 07:54 Rob Herring wrote:
Quoted 8 lines · Ran Wang

This patch adds USB dt nodes for LS1028A.

---
Changes in v2:
- Rename node from usb3@... to usb@... to meet DTSpec

 arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi |   20

++++++++++++++++++++

Review

Quoted 3 lines
 1 files changed, 20 insertions(+), 0 deletions(-)
(quoted diff) +0 -0

b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi

Quoted 7 lines

index 8dd3501..188cfb8 100644

arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi +0 -0
@@ -144,6 +144,26 @@
 			clocks = <&sysclk>;
 		};
 
Quoted 2 lines

arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi line 147

Quoted 1 line
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi +1 -0
+		usb0:usb@3100000 {

^ space needed

Yes, will update this in next version.

Quoted 3 lines

arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi line 148

Quoted 1 line
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi +1 -0
+			compatible= "snps,dwc3";

Needs an SoC specific compatible.

Do you mean change compatible to "snps,dwc3", "fsl,ls1028a-dwc3" ?

As I know, so far there is no SoC specific programming for this IP, so do you think it's still necessary to add it?

Regards,
Ran

Quoted 24 lines
Quoted 24 lines
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi +18 -1
+			reg= <0x0 0x3100000 0x0 0x10000>;
+			interrupts= <0 80 0x4>;
+			dr_mode= "host";
+			snps,dis_rxdet_inp3_quirk;
+			snps,quirk-frame-length-adjustment = <0x20>;
+			snps,incr-burst-type-adjustment = <1>, <4>, <8>, <16>;
+		};
+
+		usb1:usb@3110000 {
+			compatible= "snps,dwc3";
+			reg= <0x0 0x3110000 0x0 0x10000>;
+			interrupts= <0 81 0x4>;
+			dr_mode= "host";
+			snps,dis_rxdet_inp3_quirk;
+			snps,quirk-frame-length-adjustment = <0x20>;
+			snps,incr-burst-type-adjustment = <1>, <4>, <8>, <16>;
+		};
+
 		i2c0: i2c@2000000 {
 			compatible = "fsl,vf610-i2c";
 			#address-cells = <1>;
--

1.7.1

maintainer
#3 lore raw
Quoted 29 lines · Ran Wang

Hi Rob,

Quoted 22 lines · On Thursday, May 02, 2019 07:54 Rob Herring wrote:
Quoted 8 lines · Ran Wang

This patch adds USB dt nodes for LS1028A.

---
Changes in v2:
- Rename node from usb3@... to usb@... to meet DTSpec

 arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi |   20

++++++++++++++++++++

Review

Quoted 3 lines
 1 files changed, 20 insertions(+), 0 deletions(-)
(quoted diff) +0 -0

b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi

Quoted 7 lines

index 8dd3501..188cfb8 100644

arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi +0 -0
@@ -144,6 +144,26 @@
                    clocks = <&sysclk>;
            };
 
Quoted 2 lines

arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi line 147

Quoted 1 line
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi +1 -0
+           usb0:usb@3100000 {

^ space needed

Quoted 7 lines

Yes, will update this in next version.

Quoted 3 lines

arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi line 148

Quoted 1 line
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi +1 -0
+                   compatible= "snps,dwc3";

Needs an SoC specific compatible.

Do you mean change compatible to "snps,dwc3", "fsl,ls1028a-dwc3" ?

Well, that's the wrong order, but yes.

Quoted 2 lines

As I know, so far there is no SoC specific programming for this IP, so do you think it's still necessary to add it?

Yes. All the bugs and quirks are discovered already?

Rob

author
#4 lore raw

Hi Rob,

Quoted 33 lines · Rob Herring
Quoted 31 lines · Ran Wang

Hi Rob,

Quoted 22 lines · On Thursday, May 02, 2019 07:54 Rob Herring wrote:
Quoted 8 lines · Ran Wang

This patch adds USB dt nodes for LS1028A.

---
Changes in v2:
- Rename node from usb3@... to usb@... to meet DTSpec

 arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi |   20

++++++++++++++++++++

Review

Quoted 3 lines
 1 files changed, 20 insertions(+), 0 deletions(-)
(quoted diff) +0 -0

b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi

Quoted 7 lines

index 8dd3501..188cfb8 100644

arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi +0 -0
@@ -144,6 +144,26 @@
                    clocks = <&sysclk>;
            };
 
Quoted 2 lines

arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi line 147

Quoted 1 line
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi +1 -0
+           usb0:usb@3100000 {

^ space needed

Yes, will update this in next version.

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi line 148

Quoted 1 line
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi +1 -0
+                   compatible= "snps,dwc3";

Needs an SoC specific compatible.

Do you mean change compatible to "snps,dwc3", "fsl,ls1028a-dwc3" ?

Well, that's the wrong order, but yes.

OK, will update this.

Quoted 4 lines
Quoted 2 lines

As I know, so far there is no SoC specific programming for this IP, so do you think it's still necessary to add it?

Yes. All the bugs and quirks are discovered already?

Yes, so far I don't receive any SoC specific defect report, I think it's fine.
Will work out next version patch, thanks for your time.

Regards,
Ran