Skip to contentSkip to conversation

spl: Introduce SPL_DM_SPI Kconfig define

PATCH Superseded Lukasz Majewski 2 participants 3 messages Sep 9, 2019 – Oct 12, 2019

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 spl: Introduce SPL_DM_SPI Kconfig define

This define indicates if DM_SPI shall be supported in SPL. This allows proper operation of DM converted SPI drivers in SPL, which use #if !CONFIG_IS_ENABLED(DM_SPI) to also support not yet DM/DTS converted boards.

---

Applied on top of -master branch:
SHA1: 448f11f7503995746a7b71e5e3b3a831c4651be9

This patch is a first step for converting SPI #defines to Kconfig. It was a part of "CONFIG_DM_SPI* to CONFIG_$(SPL_TPL_)DM_SPI*" patch:
https://patchwork.ozlabs.org/patch/1158141/

which in spite of not introducing the apparent build breaks, was responsible for some deltas in SPL and U-Boot proper sizes (some parts of SPI code was not compiled in). To fix those board/SoC access to real HW is necessary as well as deep understanding of SPL SPI requirements.

---
 common/spl/Kconfig | 7 +++++++
 1 file changed, 7 insertions(+)
common/spl/Kconfig +7 -0
index 7c3391cabe..183ecf6264 100644
@@ -683,6 +683,13 @@ config SPL_UBI
 	  Enable support for loading payloads from UBI. See
 	  README.ubispl for more info.
 
+if SPL_DM
+config SPL_DM_SPI
+	bool "Support SPI DM drivers in SPL"
+	help
+	  Enable support for SPI DM drivers in SPL.
+
+endif
 if SPL_UBI
 config SPL_UBI_LOAD_BY_VOLNAME
 	bool "Support loading volumes by name"
Signature · 1 line
2.11.0
#1 lore raw

PATCH 1/1 spl: Introduce SPL_DM_SPI Kconfig define

Dear Tom,

Quoted 6 lines

This define indicates if DM_SPI shall be supported in SPL. This allows proper operation of DM converted SPI drivers in SPL, which use #if !CONFIG_IS_ENABLED(DM_SPI) to also support not yet DM/DTS converted boards.

Tom, are there any issues preventing this patch from being applied to -master?

Quoted 28 lines

---

Applied on top of -master branch:
SHA1: 448f11f7503995746a7b71e5e3b3a831c4651be9

This patch is a first step for converting SPI #defines to Kconfig. It was a part of "CONFIG_DM_SPI* to CONFIG_$(SPL_TPL_)DM_SPI*" patch:
https://patchwork.ozlabs.org/patch/1158141/

which in spite of not introducing the apparent build breaks, was responsible for some deltas in SPL and U-Boot proper sizes (some parts of SPI code was not compiled in). To fix those board/SoC access to real HW is necessary as well as deep understanding of SPL SPI requirements.

---
 common/spl/Kconfig | 7 +++++++
 1 file changed, 7 insertions(+)
common/spl/Kconfig +0 -0
index 7c3391cabe..183ecf6264 100644
@@ -683,6 +683,13 @@ config SPL_UBI
 	  Enable support for loading payloads from UBI. See
 	  README.ubispl for more info.
 

common/spl/Kconfig config SPL_UBI · line 695

Quoted 10 lines
common/spl/Kconfig +7 -0
+if SPL_DM
+config SPL_DM_SPI
+	bool "Support SPI DM drivers in SPL"
+	help
+	  Enable support for SPI DM drivers in SPL.
+
+endif
 if SPL_UBI
 config SPL_UBI_LOAD_BY_VOLNAME
 	bool "Support loading volumes by name"

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20191009/a643430c/attachment.sig>

#2 lore raw

PATCH 1/1 spl: Introduce SPL_DM_SPI Kconfig define

In reply to Lukasz Majewski
Quoted 6 lines · Lukasz Majewski

This define indicates if DM_SPI shall be supported in SPL. This allows proper operation of DM converted SPI drivers in SPL, which use #if !CONFIG_IS_ENABLED(DM_SPI) to also support not yet DM/DTS converted boards.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20191012/ce2a07d3/attachment.sig>