Skip to contentSkip to conversation

add generic DT binding for RTS/CTS

PATCH In review Erwan Le Ray 3 participants 6 messages May 20, 2020 – Jun 30, 2020

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

cover add generic DT binding for RTS/CTS

Add support of generic DT binding for annoucing RTS/CTS lines. The initial binding 'st,hw-flow-control' is not needed anymore since generic binding is available, but is kept for backward compatibility.

Erwan Le Ray (2):
dt-bindings: serial: add generic DT binding for announcing RTS/CTS
lines
serial: stm32: Use generic DT binding for announcing RTS/CTS lines

 Documentation/devicetree/bindings/serial/st,stm32-uart.yaml | 4 +++-
 drivers/tty/serial/stm32-usart.c                            | 5 +++--
 2 files changed, 6 insertions(+), 3 deletions(-)
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/2 dt-bindings: serial: add generic DT binding for announcing RTS/CTS lines

Add support of generic DT binding for annoucing RTS/CTS lines. The initial binding 'st,hw-flow-control' is not needed anymore since generic binding is available, but is kept for backward compatibility.

Documentation/devicetree/bindings/serial/st,stm32-uart.yaml +3 -1
index 75b8521eb7cb..06d5f251ec88 100644
@@ -35,9 +35,11 @@ properties:
     description: label associated with this uart
 
   st,hw-flow-ctrl:
-    description: enable hardware flow control
+    description: enable hardware flow control (deprecated)
     $ref: /schemas/types.yaml#/definitions/flag
 
+  uart-has-rtscts: true
+
   dmas:
     minItems: 1
     maxItems: 2
Signature · 1 line
2.17.1
#2 lore raw

Re: [PATCH 1/2] dt-bindings: serial: add generic DT binding for announcing RTS/CTS lines

Quoted 26 lines · Erwan Le Ray

Add support of generic DT binding for annoucing RTS/CTS lines. The initial binding 'st,hw-flow-control' is not needed anymore since generic binding is available, but is kept for backward compatibility.

Documentation/devicetree/bindings/serial/st,stm32-uart.yaml +3 -1
index 75b8521eb7cb..06d5f251ec88 100644
@@ -35,9 +35,11 @@ properties:
     description: label associated with this uart
 
   st,hw-flow-ctrl:
-    description: enable hardware flow control
+    description: enable hardware flow control (deprecated)
     $ref: /schemas/types.yaml#/definitions/flag
 
+  uart-has-rtscts: true
+
   dmas:
     minItems: 1
     maxItems: 2
Signature · 1 line
2.17.1

Did this get ignored by the DT maintainers? :(
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#3 lore raw

Re: [PATCH 1/2] dt-bindings: serial: add generic DT binding for announcing RTS/CTS lines

Quoted 19 lines · Greg Kroah-Hartman
Quoted 18 lines · Erwan Le Ray

Add support of generic DT binding for annoucing RTS/CTS lines. The initial binding 'st,hw-flow-control' is not needed anymore since generic binding is available, but is kept for backward compatibility.

Documentation/devicetree/bindings/serial/st,stm32-uart.yaml +1 -1
index 75b8521eb7cb..06d5f251ec88 100644
@@ -35,9 +35,11 @@ properties:
      description: label associated with this uart
 
    st,hw-flow-ctrl:
-    description: enable hardware flow control
+    description: enable hardware flow control (deprecated)
      $ref: /schemas/types.yaml#/definitions/flag
 
Quoted 9 lines
Quoted 8 lines
Documentation/devicetree/bindings/serial/st,stm32-uart.yaml +2 -0
+  uart-has-rtscts: true
+
    dmas:
      minItems: 1
      maxItems: 2
Signature · 1 line
2.17.1

Did this get ignored by the DT maintainers? :(

Hi Rob,

Gentle reminder. Could you please provide your feedback on this patch ?

Best Regards, Erwan.
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Reviewed-by
#4 lore raw

Re: [PATCH 1/2] dt-bindings: serial: add generic DT binding for announcing RTS/CTS lines

In reply to Greg Kroah-Hartman
Quoted 20 lines · Greg Kroah-Hartman
Quoted 18 lines · Erwan Le Ray

Add support of generic DT binding for annoucing RTS/CTS lines. The initial binding 'st,hw-flow-control' is not needed anymore since generic binding is available, but is kept for backward compatibility.

Documentation/devicetree/bindings/serial/st,stm32-uart.yaml +1 -1
index 75b8521eb7cb..06d5f251ec88 100644
@@ -35,9 +35,11 @@ properties:
     description: label associated with this uart
 
   st,hw-flow-ctrl:
-    description: enable hardware flow control
+    description: enable hardware flow control (deprecated)
     $ref: /schemas/types.yaml#/definitions/flag
 
Quoted 10 lines
Quoted 8 lines
Documentation/devicetree/bindings/serial/st,stm32-uart.yaml +2 -1
+  uart-has-rtscts: true
+
   dmas:
     minItems: 1
     maxItems: 2
--

2.17.1

Did this get ignored by the DT maintainers? :(

When it doesn't go to the DT list, you are playing roulette whether I happen to see it. :(

Anyways,

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#5 lore raw

PATCH 2/2 serial: stm32: Use generic DT binding for announcing RTS/CTS lines

In reply to Erwan Le Ray

Add support of generic DT binding for annoucing RTS/CTS lines. The initial binding 'st,hw-flow-control' is not needed anymore since generic binding is available, but is kept for backward compatibility.

drivers/tty/serial/stm32-usart.c +3 -2
index 17c2f3276888..9cfcf355567a 100644
@@ -1033,8 +1033,9 @@ static struct stm32_port *stm32_of_get_stm32_port(struct platform_device *pdev)
 	if (WARN_ON(id >= STM32_MAX_PORTS))
 		return NULL;
 
-	stm32_ports[id].hw_flow_control = of_property_read_bool(np,
-							"st,hw-flow-ctrl");
+	stm32_ports[id].hw_flow_control =
+		of_property_read_bool (np, "st,hw-flow-ctrl") /*deprecated*/ ||
+		of_property_read_bool (np, "uart-has-rtscts");
 	stm32_ports[id].port.line = id;
 	stm32_ports[id].cr1_irq = USART_CR1_RXNEIE;
 	stm32_ports[id].cr3_irq = 0;
Signature · 7 lines
2.17.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel