Skip to contentSkip to conversation

drm/rcar-du: DRM_RCAR_WRITEBACK depends on DRM

PATCH Superseded Qian Cai 2 participants 3 messages Jun 8, 2020

Subsystems (3)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Qian Cai

author
#0 lore raw

PATCH 1/1 drm/rcar-du: DRM_RCAR_WRITEBACK depends on DRM

There is no need to select DRM_RCAR_WRITEBACK if DRM=n which just make the generated .config a bit ugly.

# ARM devices
#

 # end of ARM devices

CONFIG_DRM_RCAR_WRITEBACK=y

#
# Frame buffer Devices

---
 drivers/gpu/drm/rcar-du/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/rcar-du/Kconfig +1 -0
index 0919f1f159a4..d80696455d3e 100644
@@ -48,3 +48,4 @@ config DRM_RCAR_VSP
 config DRM_RCAR_WRITEBACK
 	bool
 	default y if ARM64
+	depends on DRM
Signature · 1 line
2.21.0 (Apple Git-122.2)
#1 lore raw

Hi Qian,

Thank you for the patch.

Quoted 22 lines · Qian Cai

There is no need to select DRM_RCAR_WRITEBACK if DRM=n which just make the generated .config a bit ugly.

# ARM devices
#

 # end of ARM devices

CONFIG_DRM_RCAR_WRITEBACK=y

#
# Frame buffer Devices

---
 drivers/gpu/drm/rcar-du/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/rcar-du/Kconfig +0 -0
index 0919f1f159a4..d80696455d3e 100644

drivers/gpu/drm/rcar-du/Kconfig config DRM_RCAR_VSP · line 51

Quoted 4 lines
drivers/gpu/drm/rcar-du/Kconfig +1 -0
@@ -48,3 +48,4 @@ config DRM_RCAR_VSP
 config DRM_RCAR_WRITEBACK
 	bool
 	default y if ARM64
+	depends on DRM

How about depending on DRM_RCAR_DU instead, as DRM_RCAR_WRITEBACK is used to select compilation of rcar_du_writeback.c that is part of the rcar-du driver ?

Signature · 3 lines
Regards,

Laurent Pinchart
author
#2 lore raw
Quoted 7 lines · Laurent Pinchart

How about depending on DRM_RCAR_DU instead, as DRM_RCAR_WRITEBACK is used to select compilation of rcar_du_writeback.c that is part of the rcar-du driver ?

Sure. I’ll send a v2.