drm/rcar-du: DRM_RCAR_WRITEBACK depends on DRM
Subsystems (3)
PATCH 1/1 drm/rcar-du: DRM_RCAR_WRITEBACK depends on DRM
There is no need to select DRM_RCAR_WRITEBACK if DRM=n which just make the generated .config a bit ugly.
# ARM devices
#
# end of ARM devices
CONFIG_DRM_RCAR_WRITEBACK=y
#
# Frame buffer Devices
--- drivers/gpu/drm/rcar-du/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/rcar-du/Kconfig +1 -0
@@ -48,3 +48,4 @@ config DRM_RCAR_VSP config DRM_RCAR_WRITEBACK bool default y if ARM64 + depends on DRM
Signature · 1 line
2.21.0 (Apple Git-122.2)
Hi Qian,
Thank you for the patch.
Quoted 22 lines · Qian Cai
There is no need to select
DRM_RCAR_WRITEBACKif DRM=n which just make the generated .config a bit ugly.# ARM devices
## end of ARM devices
CONFIG_DRM_RCAR_WRITEBACK=y#
# Frame buffer DevicesSigned-off-by Qian Cai <[email protected]>--- drivers/gpu/drm/rcar-du/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/gpu/drm/rcar-du/Kconfig +0
-0
drivers/gpu/drm/rcar-du/Kconfig config DRM_RCAR_VSP · line 51
Quoted 4 lines
drivers/gpu/drm/rcar-du/Kconfig +1
-0@@ -48,3 +48,4 @@ config DRM_RCAR_VSP config DRM_RCAR_WRITEBACK bool default y if ARM64 + depends on DRM
How about depending on DRM_RCAR_DU instead, as DRM_RCAR_WRITEBACK is used to select compilation of rcar_du_writeback.c that is part of the rcar-du driver ?
Signature · 3 lines
Regards, Laurent Pinchart
Quoted 7 lines · Laurent Pinchart
How about depending on
DRM_RCAR_DUinstead, asDRM_RCAR_WRITEBACKis used to select compilation ofrcar_du_writeback.cthat is part of the rcar-du driver ?
Sure. I’ll send a v2.