Skip to contentSkip to conversation

configs: pico-imx6: convert ethernet function to DM_ETH

PATCH Superseded wig.cheng at technexion.com 2 participants 2 messages Jul 28, 2020 Arm i.MX and Layerscape

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 configs: pico-imx6: convert ethernet function to DM_ETH

From: Wig Cheng <[email protected]>

Before enable _DM_ETH:
Net: FEC [PRIME]

After enable DM_ETH:

    Net:   eth0: ethernet at 2188000

Here is the test commands:
=> dhcp
BOOTP broadcast 1
DHCP client bound to address 10.88.88.152 (146 ms) *** ERROR: `serverip' not set
Cannot autoload with TFTPGET
=> ping 8.8.8.8
Using ethernet at 2188000 device
host 8.8.8.8 is alive

---
 configs/pico-imx6_defconfig | 3 +++
 1 file changed, 3 insertions(+)
configs/pico-imx6_defconfig +3 -0
index 04c132b474..5fe2850086 100644
@@ -64,6 +64,9 @@ CONFIG_DM_MMC=y
 CONFIG_FSL_USDHC=y
 CONFIG_PHYLIB=y
 CONFIG_PHY_ATHEROS=y
+CONFIG_DM_ETH=y
+CONFIG_DM_MDIO=y
+CONFIG_RGMII=y
 CONFIG_PINCTRL=y
 CONFIG_PINCTRL_IMX6=y
 CONFIG_MXC_UART=y
Signature · 1 line
2.17.1
reviewer
#1 lore raw

PATCH 1/1 configs: pico-imx6: convert ethernet function to DM_ETH

HI Wig,

Quoted 29 lines · On Tue, Jul 28, 2020 at 7:37 AM <[email protected]> wrote:

From: Wig Cheng <[email protected]>

Before enable _DM_ETH:
Net: FEC [PRIME]

After enable DM_ETH:

    Net:   eth0: ethernet at 2188000

Here is the test commands:
=> dhcp
BOOTP broadcast 1
DHCP client bound to address 10.88.88.152 (146 ms) *** ERROR: `serverip' not set
Cannot autoload with TFTPGET
=> ping 8.8.8.8
Using ethernet at 2188000 device
host 8.8.8.8 is alive

---
 configs/pico-imx6_defconfig | 3 +++
 1 file changed, 3 insertions(+)
configs/pico-imx6_defconfig +0 -0
index 04c132b474..5fe2850086 100644

configs/pico-imx6_defconfig CONFIG_DM_MMC=y · line 68

Quoted 5 lines
configs/pico-imx6_defconfig +2 -0
@@ -64,6 +64,9 @@ CONFIG_DM_MMC=y
 CONFIG_FSL_USDHC=y
 CONFIG_PHYLIB=y
 CONFIG_PHY_ATHEROS=y
+CONFIG_DM_ETH=y
+CONFIG_DM_MDIO=y

mx6 has only a single FEC instance, so there is no need for selecting DM_MDIO.

Please see this patch I have recently submitted:
https://gitlab.denx.de/u-boot/custodians/u-boot-imx/-/commit/45032991194239991726cafe4dfa6a72ddf45956

Other than that your patch looks good.