drm: panel: add support for TDO tl070wsh30 panel
Subsystems (5)
v4 cover drm: panel: add support for TDO tl070wsh30 panel
This adds support bindings and support for the TDO TL070WSH30 TFT-LCD panel module shipped with the Amlogic S400 Development Kit.
The panel has a 1024×600 resolution and uses 24 bit RGB per pixel. It provides a MIPI DSI interface to the host, a built-in LED backlight and touch controller.
Changes since v3 at [3]:
- reordered tdo vendor prefix
Changes since v2 at [2]:
- added reset gpio to panel-simple-dsi bindings
- moved bindings to panel-simple
- re-ordered prepare/unprepare
- added back refresh print
- moved regulator/reset handling in prepare/unprepare
- aligned remove/shutdown with panel-simple
- added sentinel comment into dt match table
Changes since v1 at [1]:
- added missing vendor-prefixes patch
- removed vrefresh
- fixed warning on add_panel return
- removed DRM logging
[1] https://patchwork.freedesktop.org/series/81376/#rev1
[2] https://patchwork.freedesktop.org/series/81376/#rev2
[3] https://patchwork.freedesktop.org/series/81376/#rev3
Neil Armstrong (4):
dt-bindings: vendor-prefixes: Add Shanghai Top Display
Optolelectronics vendor prefix
dt-bindings: display: panel-simple-dsi: add optional reset gpio
dt-bindings: display: panel-simple-dsi: add TDO TL070WSH30 DSI panel
bindings
drm: panel: add TDO tl070wsh30 panel driver
.../display/panel/panel-simple-dsi.yaml | 3 + .../devicetree/bindings/vendor-prefixes.yaml | 2 + drivers/gpu/drm/panel/Kconfig | 11 + drivers/gpu/drm/panel/Makefile | 1 + drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c | 250 ++++++++++++++++++ 5 files changed, 267 insertions(+) create mode 100644 drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c
Signature · 6 lines
2.22.0 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH v4 1/4 dt-bindings: vendor-prefixes: Add Shanghai Top Display Optolelectronics vendor prefix
Shanghai Top Display Optolelectronics Co., Ltd is a display manufacturer from Shanghai.
Web site of the company: http://www.shtdo.com/
--- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/vendor-prefixes.yaml +2 -0
@@ -1037,6 +1037,8 @@ patternProperties: description: Trusted Computing Group "^tcl,.*": description: Toby Churchill Ltd. + "^tdo,.*": + description: Shangai Top Display Optoelectronics Co., Ltd "^technexion,.*": description: TechNexion "^technologic,.*":
Signature · 6 lines
2.22.0 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v4 1/4] dt-bindings: vendor-prefixes: Add Shanghai Top Display Optolelectronics vendor prefix
Quoted 9 lines · Neil Armstrong
Shanghai Top Display Optolelectronics Co., Ltd is a display manufacturer from Shanghai.
Web site of the company: http://www.shtdo.com/Signed-off-by Neil Armstrong <[email protected]>--- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+)
PATCH v4 2/4 dt-bindings: display: panel-simple-dsi: add optional reset gpio
In reply to Neil ArmstrongSimple DSI panels can also have a reset GPIO signal in addition/instead of an enable GPIO signal.
This adds an optional reset-gpios property.
--- .../devicetree/bindings/display/panel/panel-simple-dsi.yaml | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml +1 -0
@@ -54,6 +54,7 @@ properties: backlight: true enable-gpios: true + reset-gpios: true port: true power-supply: true
Signature · 6 lines
2.22.0 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v4 2/4] dt-bindings: display: panel-simple-dsi: add optional reset gpio
Quoted 10 lines · Neil Armstrong
Simple DSI panels can also have a reset GPIO signal in addition/instead of an enable GPIO signal.
This adds an optional reset-gpios property.
Signed-off-by Neil Armstrong <[email protected]>--- .../devicetree/bindings/display/panel/panel-simple-dsi.yaml | 1 + 1 file changed, 1 insertion(+)
PATCH v4 3/4 dt-bindings: display: panel-simple-dsi: add TDO TL070WSH30 DSI panel bindings
In reply to Neil ArmstrongThis add the bindings for the 1024x600 TFT LCD TL070WSH30 DSI panel to panel-simple-dsi.
--- .../devicetree/bindings/display/panel/panel-simple-dsi.yaml | 2 ++ 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml +2 -0
@@ -47,6 +47,8 @@ properties: - panasonic,vvx10f004b00 # Panasonic 10" WUXGA TFT LCD panel - panasonic,vvx10f034n00 + # Shangai Top Display Optoelectronics 7" TL070WSH30 1024x600 TFT LCD panel + - tdo,tl070wsh30 reg: maxItems: 1
Signature · 6 lines
2.22.0 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v4 3/4] dt-bindings: display: panel-simple-dsi: add TDO TL070WSH30 DSI panel bindings
Quoted 7 lines · Neil Armstrong
This add the bindings for the 1024x600 TFT LCD TL070WSH30 DSI panel to panel-simple-dsi.
Signed-off-by Neil Armstrong <[email protected]>--- .../devicetree/bindings/display/panel/panel-simple-dsi.yaml | 2 ++ 1 file changed, 2 insertions(+)
PATCH v4 4/4 drm: panel: add TDO tl070wsh30 panel driver
In reply to Neil ArmstrongThis adds support for the TDO TL070WSH30 TFT-LCD panel module. The panel has a 1024×600 resolution and uses 24 bit RGB per pixel. It provides a MIPI DSI interface to the host, a built-in LED backlight and touch controller.
--- drivers/gpu/drm/panel/Kconfig | 11 + drivers/gpu/drm/panel/Makefile | 1 + drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c | 250 +++++++++++++++++++ 3 files changed, 262 insertions(+) create mode 100644 drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c
drivers/gpu/drm/panel/Kconfig +11 -0
@@ -433,6 +433,17 @@ config DRM_PANEL_SONY_ACX565AKM Say Y here if you want to enable support for the Sony ACX565AKM 800x600 3.5" panel (found on the Nokia N900). +config DRM_PANEL_TDO_TL070WSH30 + tristate "TDO TL070WSH30 DSI panel" + depends on OF + depends on DRM_MIPI_DSI + depends on BACKLIGHT_CLASS_DEVICE + help + Say Y here if you want to enable support for TDO TL070WSH30 TFT-LCD + panel module. The panel has a 1024×600 resolution and uses + 24 bit RGB per pixel. It provides a MIPI DSI interface to + the host, a built-in LED backlight and touch controller. + config DRM_PANEL_TPO_TD028TTEC1 tristate "Toppoly (TPO) TD028TTEC1 panel driver" depends on OF && SPI
drivers/gpu/drm/panel/Makefile +1 -0
@@ -45,6 +45,7 @@ obj-$(CONFIG_DRM_PANEL_SITRONIX_ST7703) += panel-sitronix-st7703.o obj-$(CONFIG_DRM_PANEL_SITRONIX_ST7789V) += panel-sitronix-st7789v.o obj-$(CONFIG_DRM_PANEL_SONY_ACX424AKP) += panel-sony-acx424akp.o obj-$(CONFIG_DRM_PANEL_SONY_ACX565AKM) += panel-sony-acx565akm.o +obj-$(CONFIG_DRM_PANEL_TDO_TL070WSH30) += panel-tdo-tl070wsh30.o obj-$(CONFIG_DRM_PANEL_TPO_TD028TTEC1) += panel-tpo-td028ttec1.o obj-$(CONFIG_DRM_PANEL_TPO_TD043MTEA1) += panel-tpo-td043mtea1.o obj-$(CONFIG_DRM_PANEL_TPO_TPG110) += panel-tpo-tpg110.o
drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c new file +250 -0
250 lines not on this page · raw message
Signature · 6 lines
2.22.0 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi Sam,
Is there anything more to change ?
Thanks,
Neil
Quoted 36 lines · Neil Armstrong
This adds support bindings and support for the TDO TL070WSH30 TFT-LCD panel module shipped with the Amlogic S400 Development Kit.
The panel has a 1024×600 resolution and uses 24 bit RGB per pixel. It provides a MIPI DSI interface to the host, a built-in LED backlight and touch controller.Changes since v3 at [3]:
- reordered tdo vendor prefixChanges since v2 at [2]:
- added reset gpio to panel-simple-dsi bindings
- moved bindings to panel-simple
- re-ordered prepare/unprepare
- added back refresh print
- moved regulator/reset handling in prepare/unprepare
- aligned remove/shutdown with panel-simple
- added sentinel comment into dt match tableChanges since v1 at [1]:
- added missing vendor-prefixes patch
- removed vrefresh
- fixed warning onadd_panelreturn
- removed DRM logging[1] https://patchwork.freedesktop.org/series/81376/#rev1
[2] https://patchwork.freedesktop.org/series/81376/#rev2
[3] https://patchwork.freedesktop.org/series/81376/#rev3Neil Armstrong (4):
dt-bindings: vendor-prefixes: Add Shanghai Top Display
Optolelectronics vendor prefix
dt-bindings: display: panel-simple-dsi: add optional reset gpio
dt-bindings: display: panel-simple-dsi: add TDO TL070WSH30 DSI panel
bindings
drm: panel: add TDO tl070wsh30 panel driver
Quoted 8 lines
.../display/panel/panel-simple-dsi.yaml | 3 + .../devicetree/bindings/vendor-prefixes.yaml | 2 + drivers/gpu/drm/panel/Kconfig | 11 + drivers/gpu/drm/panel/Makefile | 1 + drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c | 250 ++++++++++++++++++ 5 files changed, 267 insertions(+) create mode 100644 drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Sam Ravnborg
Reviewed-byHi Neil.
Quoted 3 lines · Neil Armstrong
Hi Sam,
Is there anything more to change ?
Sorry for taking so long to get back to you on this.
All patches looks good and are:
I assume you will apply the patches.
Sam
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 5 lines · Sam Ravnborg
Hi Neil.
Quoted 2 lines · Neil Armstrong
Hi Sam,
Quoted 7 lines
Quoted 1 line
Is there anything more to change ?
Sorry for taking so long to get back to you on this.
All patches looks good and are:
Reviewed-by Sam Ravnborg <[email protected]>I assume you will apply the patches.
Indeed,
Thanks !
Applying to drm-misc-next
Quoted 3 lines
Sam
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel