nfc: s3fwrn5: Change I2C interrupt trigger to EDGE_RISING
Subsystems (5)
v2 cover nfc: s3fwrn5: Change I2C interrupt trigger to EDGE_RISING
From: Bongsu Jeon <[email protected]>
For stable Samsung's I2C interrupt handling, I changed the interrupt trigger from IRQ_TYPE_LEVEL_HIGH to IRQ_TYPE_EDGE_RISING and removed the hard coded interrupt trigger type in the i2c module for the flexible control.
1/2 is the changed dt binding for the edge rising trigger. 2/2 is to remove the hard coded interrupt trigger type in the i2c module.
ChangeLog:
v2:
2/2
- remove the hard coded interrupt trigger type.
Bongsu Jeon (2):
dt-bindings: net: nfc: s3fwrn5: Change I2C interrupt trigger to
EDGE_RISING
nfc: s3fwrn5: Remove hard coded interrupt trigger type from the i2c
module
.../devicetree/bindings/net/nfc/samsung,s3fwrn5.yaml | 2 +- drivers/nfc/s3fwrn5/i2c.c | 8 +++++++- 2 files changed, 8 insertions(+), 2 deletions(-)
Signature · 1 line
2.17.1
PATCH v2 1/2 dt-bindings: net: nfc: s3fwrn5: Change I2C interrupt trigger type
From: Bongsu Jeon <[email protected]>
Change interrupt trigger from IRQ_TYPE_LEVEL_HIGH to IRQ_TYPE_EDGE_RISING
for stable NFC I2C interrupt handling.
Samsung's NFC Firmware sends an i2c frame as below.
1. NFC Firmware sets the GPIO(interrupt pin) high when there is an i2c frame to send.
2. If the CPU's I2C master has received the i2c frame, NFC F/W sets the GPIO low.
NFC driver's i2c interrupt handler would be called in the abnormal case as the NFC FW task of number 2 is delayed because of other high priority tasks.
In that case, NFC driver will try to receive the i2c frame but there isn't
any i2c frame to send in NFC.
It would cause an I2C communication problem. This case would hardly happen. But, I changed the interrupt as a defense code.
If Driver uses the TRIGGER_RISING instead of the LEVEL trigger, there would be no problem even if the NFC FW task is delayed.
--- Documentation/devicetree/bindings/net/nfc/samsung,s3fwrn5.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/net/nfc/samsung,s3fwrn5.yaml +1 -1
@@ -76,7 +76,7 @@ examples: reg = <0x27>; interrupt-parent = <&gpa1>; - interrupts = <3 IRQ_TYPE_LEVEL_HIGH>; + interrupts = <3 IRQ_TYPE_EDGE_RISING>; en-gpios = <&gpf1 4 GPIO_ACTIVE_HIGH>; wake-gpios = <&gpj0 2 GPIO_ACTIVE_HIGH>;
Signature · 1 line
2.17.1
PATCH v2 2/2 nfc: s3fwrn5: Remove hard coded interrupt trigger type from the i2c module
In reply to Bongsu JeonFrom: Bongsu Jeon <[email protected]>
For the flexible control of interrupt trigger type, remove the hard coded interrupt trigger type in the i2c module. The trigger type will be loaded
from a dts.
--- drivers/nfc/s3fwrn5/i2c.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/nfc/s3fwrn5/i2c.c +6 -1
@@ -179,6 +179,8 @@ static int s3fwrn5_i2c_probe(struct i2c_client *client, const struct i2c_device_id *id) {struct s3fwrn5_i2c_phy *phy; +struct irq_data *irq_data; +unsigned long irqflags;int ret; phy =devm_kzalloc (&client->dev,sizeof (*phy),GFP_KERNEL );
@@ -212,8 +214,11 @@ static int s3fwrn5_i2c_probe(struct i2c_client *client,if (ret <0 )return ret; + irq_data =irq_get_irq_data (client->irq); + irqflags =irqd_get_trigger_type (irq_data) |IRQF_ONESHOT ; + ret =devm_request_threaded_irq (&client->dev, phy->i2c_dev->irq,NULL , - s3fwrn5_i2c_irq_thread_fn,IRQF_TRIGGER_HIGH |IRQF_ONESHOT , + s3fwrn5_i2c_irq_thread_fn, irqflags,S3FWRN5_I2C_DRIVER_NAME , phy);if (ret)s3fwrn5_remove (phy->common.ndev);
Signature · 1 line
2.17.1
Krzysztof Kozlowski
maintainerRe: [PATCH v2 net-next 2/2] nfc: s3fwrn5: Remove hard coded interrupt trigger type from the i2c module
Quoted 25 lines · Bongsu Jeon
From: Bongsu Jeon <[email protected]>
For the flexible control of interrupt trigger type, remove the hard coded interrupt trigger type in the i2c module. The trigger type will be loaded
from a dts.Signed-off-by Bongsu Jeon <[email protected]>--- drivers/nfc/s3fwrn5/i2c.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)drivers/nfc/s3fwrn5/i2c.c +2
-0@@ -179,6 +179,8 @@ static int s3fwrn5_i2c_probe(struct i2c_client *client, const struct i2c_device_id *id) {struct s3fwrn5_i2c_phy *phy; +struct irq_data *irq_data; +unsigned long irqflags;int ret; phy =devm_kzalloc (&client->dev,sizeof (*phy),GFP_KERNEL );
drivers/nfc/s3fwrn5/i2c.c static int s3fwrn5_i2c_probe(struct i2c_client *client, · line 218
Quoted 5 lines
drivers/nfc/s3fwrn5/i2c.c +2
-0@@ -212,8 +214,11 @@ static int s3fwrn5_i2c_probe(struct i2c_client *client,if (ret <0 )return ret; + irq_data =irq_get_irq_data (client->irq); + irqflags =irqd_get_trigger_type (irq_data) |IRQF_ONESHOT ;
This patch is wrong and should not be applied. David, please give few days to review the patches. :)
The irqd_get_trigger_type is not necessary.
I'll send follow ups to correct this.
Best regards,
Krzysztof
Quoted 10 lines
drivers/nfc/s3fwrn5/i2c.c +2
-1+ ret =devm_request_threaded_irq (&client->dev, phy->i2c_dev->irq,NULL , - s3fwrn5_i2c_irq_thread_fn,IRQF_TRIGGER_HIGH |IRQF_ONESHOT , + s3fwrn5_i2c_irq_thread_fn, irqflags,S3FWRN5_I2C_DRIVER_NAME , phy);if (ret)s3fwrn5_remove (phy->common.ndev);Signature · 1 line
2.17.1
David Miller
maintainerFrom: Bongsu Jeon <[email protected]>
Date: Tue, 8 Dec 2020 23:10:10 +0900
Quoted 7 lines
From: Bongsu Jeon <[email protected]>
For stable Samsung's I2C interrupt handling, I changed the interrupt trigger from
IRQ_TYPE_LEVEL_HIGHtoIRQ_TYPE_EDGE_RISINGand removed the hard coded interrupt trigger type in the i2c module for the flexible control.
Quoted 7 lines
1/2 is the changed dt binding for the edge rising trigger. 2/2 is to remove the hard coded interrupt trigger type in the i2c module.
ChangeLog:
v2:
2/2
- remove the hard coded interrupt trigger type.
Series applied, thanks.