Skip to contentSkip to conversation

Fix mode selection for 2x tests

PATCH Superseded Bhanuprakash Modem 3 participants 21 messages May 3, 2021 – May 7, 2021 Library code

v4 of 6 Superseded Latest is v6 →

lore
Share & tools
lore
#0 lore raw

v4 cover Fix mode selection for 2x tests

When two monitors connected through MST, the second monitor also tries to use the same mode. So two such modes may not fit into the link bandwidth.

This series will find a combination of modes that fit into the BW.

IGT core helper would override the mode on all connectors that will be modeset by the next igt_display_commit() call in the test. These are all the connectors in igt_display_t that have a pending_pipe set by the test up to the point of calling this helper.

For 1x tests, cleanup the state before exiting the test.

Follow-up:
As modeset will happen one by one, we can't apply this approach on tests/kms_flip.c & tests/kms_setmode.c

Cc Imre Deak <[email protected]>
Cc Ankit Nautiyal <[email protected]>
Cc Daniel Vetter <[email protected]>

Bhanuprakash Modem (14):
lib/igt_kms: helper to override the mode on all connectors tests/kms_frontbuffer_tracking: Fix mode selection for 2x tests tests/kms_cursor_legacy: Fix mode selection for 2x tests tests/debugfs_test: Fix mode selection for MST tests/kms_content_protection: Fix mode selection for 2x tests tests/kms_plane_scaling: Fix mode selection for 2x tests tests/kms_atomic_transition: Fix mode selection for 2x tests tests/kms_plane: Reset the state before exiting the test tests/kms_plane_alpha_blend: Reset the state before exiting the test tests/kms_cursor_edge_walk: Reset the state before exiting the test tests/kms_plane_lowres: Reset the state before exiting the test tests/kms_plane_cursor: Reset the state before exiting the test tests/kms_flip_scaled_crc: Reset the state before exiting the test tests/kms_vblank: Reset the state before exiting the test

 lib/igt_kms.c                    | 72 ++++++++++++++++++++++++++++++++
 lib/igt_kms.h                    |  1 +
 tests/debugfs_test.c             | 10 +++++
 tests/kms_atomic_transition.c    | 10 +++++
 tests/kms_content_protection.c   | 41 +++++++-----------
 tests/kms_cursor_edge_walk.c     |  3 ++
 tests/kms_cursor_legacy.c        | 47 +++++++++++++++++++--
 tests/kms_flip_scaled_crc.c      |  5 +++
 tests/kms_frontbuffer_tracking.c | 33 +++++++++++++++
 tests/kms_plane.c                | 19 ++++++---
 tests/kms_plane_alpha_blend.c    |  5 ++-
 tests/kms_plane_cursor.c         |  4 ++
 tests/kms_plane_lowres.c         |  9 ++--
 tests/kms_plane_scaling.c        | 15 +++++--
 tests/kms_vblank.c               |  2 +
 15 files changed, 231 insertions(+), 45 deletions(-)

--
2.20.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#1 lore raw

PATCH v4 1/14 lib/igt_kms: helper to override the mode on all connectors

This helper will iterate through all connectors those have a pending_pipe != PIPE_NONE set by the test upto the point of calling this helper. And find the combination by using ATOMIC_TEST_ONLY then return to the test.

This helper would override the mode on all connectors that will be modeset by the next igt_display_commit() call in the test.

V2:
* Remove MST specific logic (Daniel)
V3:
* Sort connector modes in descending order
V4:
* Fine tune the logic to reduce #of interations (Ankit)
* Update the documentation (Ankit)

Cc Imre Deak <[email protected]>
Cc Ankit Nautiyal <[email protected]>
Cc Petri Latvala <[email protected]>
Cc Daniel Vetter <[email protected]>
---
 lib/igt_kms.c | 72 +++++++++++++++++++++++++++++++++++++++++++++++++++
 lib/igt_kms.h |  1 +
 2 files changed, 73 insertions(+)
lib/igt_kms.c +72 -0
index 47b829b0c..d604c1b38 100644
@@ -4048,6 +4048,78 @@ void igt_output_set_pipe(igt_output_t *output, enum pipe pipe)
 	}
 }
 
+#define for_each_connector_mode(output)		\
+	for (int i__ = 0;  i__ < output->config.connector->count_modes; i__++)
+
+static int sort_drm_modes(const void *a, const void *b)
+{
+	const drmModeModeInfo *mode1 = a, *mode2 = b;
+
+	return (mode1->clock < mode2->clock) - (mode2->clock < mode1->clock);
+}
+
+static
+bool __override_all_active_output_modes_to_fit_link_bw(igt_display_t *display,
+							igt_output_t *outputs[IGT_MAX_PIPES],
+							const int n_outputs,
+							int base)
+{
+	igt_output_t *output = NULL;
+
+	if (base >= n_outputs)
+		return false;
+
+	output = outputs[base];
+
+	for_each_connector_mode(output) {
+		igt_output_override_mode(output, &output->config.connector->modes[i__]);
+
+		if (__override_all_active_output_modes_to_fit_link_bw(display, outputs, n_outputs, base + 1))
+			return true;
+
+		if (igt_display_try_commit_atomic(display,
+				DRM_MODE_ATOMIC_TEST_ONLY |
+				DRM_MODE_ATOMIC_ALLOW_MODESET,
+				NULL) == 0)
+			return true;
+	}
+
+	return false;
+}
+
+/**
+ * igt_override_all_active_output_modes_to_fit_link_bw:
+ * @display: a pointer to an #igt_display_t structure
+ *
+ * Override the mode on all active outputs (i.e. pending_pipe != PIPE_NONE)
+ * on basis of bandwidth.
+ *
+ * Returns: true if a valid connector mode combo found, else false
+ */
+bool igt_override_all_active_output_modes_to_fit_link_bw(igt_display_t *display)
+{
+	int i, n_outputs = 0;
+	igt_output_t *outputs[IGT_MAX_PIPES];
+
+	for (i = 0 ; i < display->n_outputs; i++) {
+		igt_output_t *output = &display->outputs[i];
+
+		if (output->pending_pipe == PIPE_NONE)
+			continue;
+
+		/* Sort the modes in descending order by clock freq. */
+		qsort(output->config.connector->modes,
+		      output->config.connector->count_modes,
+		      sizeof(drmModeModeInfo),
+		      sort_drm_modes);
+
+		outputs[n_outputs++] = output;
+	}
+	igt_require_f(n_outputs, "No active outputs found.\n");
+
+	return __override_all_active_output_modes_to_fit_link_bw(display, outputs, n_outputs, 0);
+}
+
 /*
  * igt_pipe_refresh:
  * @display: a pointer to an #igt_display_t structure
lib/igt_kms.h +1 -0
index 85f0769c9..95463b1c5 100644
@@ -915,5 +915,6 @@ void igt_require_pipe(igt_display_t *display,
 
 void igt_dump_connectors_fd(int drmfd);
 void igt_dump_crtcs_fd(int drmfd);
+bool igt_override_all_active_output_modes_to_fit_link_bw(igt_display_t *display);
 
 #endif /* __IGT_KMS_H__ */
Signature · 6 lines
2.20.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Reviewed-by on v4 1/14
#2 lore raw

Re: [igt-dev] [v4 i-g-t 01/14] lib/igt_kms: helper to override the mode on all connectors

LGTM.

Quoted 114 lines · Bhanuprakash Modem

This helper will iterate through all connectors those have a pending_pipe != PIPE_NONE set by the test upto the point of calling this helper. And find the combination by using ATOMIC_TEST_ONLY then return to the test.

This helper would override the mode on all connectors that will be modeset by the next igt_display_commit() call in the test.

V2:
* Remove MST specific logic (Daniel)
V3:
* Sort connector modes in descending order
V4:
* Fine tune the logic to reduce #of interations (Ankit)
* Update the documentation (Ankit)

Cc Imre Deak <[email protected]>
Cc Ankit Nautiyal <[email protected]>
Cc Petri Latvala <[email protected]>
Cc Daniel Vetter <[email protected]>
---
  lib/igt_kms.c | 72 +++++++++++++++++++++++++++++++++++++++++++++++++++
  lib/igt_kms.h |  1 +
  2 files changed, 73 insertions(+)
lib/igt_kms.c +72 -0
index 47b829b0c..d604c1b38 100644
@@ -4048,6 +4048,78 @@ void igt_output_set_pipe(igt_output_t *output, enum pipe pipe)
  	}
  }
 
+#define for_each_connector_mode(output)		\
+	for (int i__ = 0;  i__ < output->config.connector->count_modes; i__++)
+
+static int sort_drm_modes(const void *a, const void *b)
+{
+	const drmModeModeInfo *mode1 = a, *mode2 = b;
+
+	return (mode1->clock < mode2->clock) - (mode2->clock < mode1->clock);
+}
+
+static
+bool __override_all_active_output_modes_to_fit_link_bw(igt_display_t *display,
+							igt_output_t *outputs[IGT_MAX_PIPES],
+							const int n_outputs,
+							int base)
+{
+	igt_output_t *output = NULL;
+
+	if (base >= n_outputs)
+		return false;
+
+	output = outputs[base];
+
+	for_each_connector_mode(output) {
+		igt_output_override_mode(output, &output->config.connector->modes[i__]);
+
+		if (__override_all_active_output_modes_to_fit_link_bw(display, outputs, n_outputs, base + 1))
+			return true;
+
+		if (igt_display_try_commit_atomic(display,
+				DRM_MODE_ATOMIC_TEST_ONLY |
+				DRM_MODE_ATOMIC_ALLOW_MODESET,
+				NULL) == 0)
+			return true;
+	}
+
+	return false;
+}
+
+/**
+ * igt_override_all_active_output_modes_to_fit_link_bw:
+ * @display: a pointer to an #igt_display_t structure
+ *
+ * Override the mode on all active outputs (i.e. pending_pipe != PIPE_NONE)
+ * on basis of bandwidth.
+ *
+ * Returns: true if a valid connector mode combo found, else false
+ */
+bool igt_override_all_active_output_modes_to_fit_link_bw(igt_display_t *display)
+{
+	int i, n_outputs = 0;
+	igt_output_t *outputs[IGT_MAX_PIPES];
+
+	for (i = 0 ; i < display->n_outputs; i++) {
+		igt_output_t *output = &display->outputs[i];
+
+		if (output->pending_pipe == PIPE_NONE)
+			continue;
+
+		/* Sort the modes in descending order by clock freq. */
+		qsort(output->config.connector->modes,
+		      output->config.connector->count_modes,
+		      sizeof(drmModeModeInfo),
+		      sort_drm_modes);
+
+		outputs[n_outputs++] = output;
+	}
+	igt_require_f(n_outputs, "No active outputs found.\n");
+
+	return __override_all_active_output_modes_to_fit_link_bw(display, outputs, n_outputs, 0);
+}
+
  /*
   * igt_pipe_refresh:
   * @display: a pointer to an #igt_display_t structure
lib/igt_kms.h +0 -0
index 85f0769c9..95463b1c5 100644

lib/igt_kms.h void igt_require_pipe(igt_display_t *display, · line 920

Quoted 6 lines
lib/igt_kms.h +1 -0
@@ -915,5 +915,6 @@ void igt_require_pipe(igt_display_t *display,
 
  void igt_dump_connectors_fd(int drmfd);
  void igt_dump_crtcs_fd(int drmfd);
+bool igt_override_all_active_output_modes_to_fit_link_bw(igt_display_t *display);
 
  #endif /* __IGT_KMS_H__ */

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#3 lore raw

Re: [igt-dev] [v4 i-g-t 01/14] lib/igt_kms: helper to override the mode on all connectors

Hi Bhanu,

I realized that the helper given is also called for tests which use legacy commit. Currently it tries igt_display_try_commit_atomic()

For legacy commit support, can we make use of igt_display_try_commit2( ) which takes commit style also as argument.

the function igt_display_try_commit_2() for legacy commit will do drmModesetcrtc for each pipe with the given mode individually and return false if any of them fail.

Another suggestion which I missed earlier: perhaps we can drop 'link' in the name igt_override_all_active_output_modes_to_fit_link_bw(), as its not only for MST but in general.

Regards,

Ankit

Quoted 128 lines · Ankit K

LGTM.

Quoted 123 lines · Bhanuprakash Modem

This helper will iterate through all connectors those have a pending_pipe != PIPE_NONE set by the test upto the point of calling this helper. And find the combination by using ATOMIC_TEST_ONLY then return to the test.

This helper would override the mode on all connectors that will be modeset by the next igt_display_commit() call in the test.

V2:
* Remove MST specific logic (Daniel)
V3:
* Sort connector modes in descending order
V4:
* Fine tune the logic to reduce #of interations (Ankit)
* Update the documentation (Ankit)

Cc Imre Deak <[email protected]>
Cc Ankit Nautiyal <[email protected]>
Cc Petri Latvala <[email protected]>
Cc Daniel Vetter <[email protected]>

---
  lib/igt_kms.c | 72 +++++++++++++++++++++++++++++++++++++++++++++++++++ lib/igt_kms.h |  1 +

  2 files changed, 73 insertions(+)
lib/igt_kms.c +11 -0
index 47b829b0c..d604c1b38 100644
@@ -4048,6 +4048,78 @@ void igt_output_set_pipe(igt_output_t *output, 
 enum pipe pipe)
       }
   }
   +#define for_each_connector_mode(output)        \
+    for (int i__ = 0;  i__ < output->config.connector->count_modes; 
 i__++)
+
+static int sort_drm_modes(const void *a, const void *b)
+{
+    const drmModeModeInfo *mode1 = a, *mode2 = b;
+
+    return (mode1->clock < mode2->clock) - (mode2->clock < 
 mode1->clock);
+}
+
+static
+bool __override_all_active_output_modes_to_fit_link_bw(igt_display_t 

*display,
+                            igt_output_t *outputs[IGT_MAX_PIPES], +                            const int n_outputs,
+                            int base)

lib/igt_kms.c +10 -0
+{
+    igt_output_t *output = NULL;
+
+    if (base >= n_outputs)
+        return false;
+
+    output = outputs[base];
+
+    for_each_connector_mode(output) {
+        igt_output_override_mode(output, 

&output->config.connector->modes[i__]);
+
+        if
(__override_all_active_output_modes_to_fit_link_bw(display, outputs, n_outputs, base + 1)) +            return true;

lib/igt_kms.c +16 -0
+
+        if (igt_display_try_commit_atomic(display,
+                DRM_MODE_ATOMIC_TEST_ONLY |
+                DRM_MODE_ATOMIC_ALLOW_MODESET,
+                NULL) == 0)
+            return true;
+    }
+
+    return false;
+}
+
+/**
+ * igt_override_all_active_output_modes_to_fit_link_bw:
+ * @display: a pointer to an #igt_display_t structure
+ *
+ * Override the mode on all active outputs (i.e. pending_pipe != 

PIPE_NONE)
+ * on basis of bandwidth.
+ *
+ * Returns: true if a valid connector mode combo found, else false
+ */
+bool igt_override_all_active_output_modes_to_fit_link_bw(igt_display_t *display)

lib/igt_kms.c +21 -0
+{
+    int i, n_outputs = 0;
+    igt_output_t *outputs[IGT_MAX_PIPES];
+
+    for (i = 0 ; i < display->n_outputs; i++) {
+        igt_output_t *output = &display->outputs[i];
+
+        if (output->pending_pipe == PIPE_NONE)
+            continue;
+
+        /* Sort the modes in descending order by clock freq. */
+        qsort(output->config.connector->modes,
+              output->config.connector->count_modes,
+              sizeof(drmModeModeInfo),
+              sort_drm_modes);
+
+        outputs[n_outputs++] = output;
+    }
+    igt_require_f(n_outputs, "No active outputs found.\n");
+
+    return 

__override_all_active_output_modes_to_fit_link_bw(display, outputs, n_outputs, 0);

lib/igt_kms.c +2 -0
+}
+

  /*
   * igt_pipe_refresh:
   * @display: a pointer to an #igt_display_t structure

lib/igt_kms.h +0 -0
index 85f0769c9..95463b1c5 100644
@@ -915,5 +915,6 @@ void igt_require_pipe(igt_display_t *display,
     void igt_dump_connectors_fd(int drmfd);
Quoted 8 lines

lib/igt_kms.h void igt_require_pipe(igt_display_t *display, · line 920

Quoted 4 lines
lib/igt_kms.h +1 -0
   void igt_dump_crtcs_fd(int drmfd);
+bool 
 igt_override_all_active_output_modes_to_fit_link_bw(igt_display_t *display);
     #endif /* __IGT_KMS_H__ */

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#4 lore raw

PATCH v4 2/14 tests/kms_frontbuffer_tracking: Fix mode selection for 2x tests

In reply to Bhanuprakash Modem

When two monitors connected through MST, the second monitor also tries to use the same mode. So two such modes may not fit into the link bandwidth.

This patch will find a combination of modes that fit into the BW.

V2:
* Remove MST specific logic (Daniel)

Cc Imre Deak <[email protected]>
Cc Ankit Nautiyal <[email protected]>
Cc Daniel Vetter <[email protected]>
---
 tests/kms_frontbuffer_tracking.c | 33 ++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)
tests/kms_frontbuffer_tracking.c +33 -0
index 2e74bec6f..211a5f3f8 100644
@@ -1683,6 +1683,33 @@ static void enable_prim_screen_and_wait(const struct test_mode *t)
 	do_assertions(ASSERT_NO_ACTION_CHANGE);
 }
 
+static void update_modeset_cached_params(void)
+{
+	bool found = false;
+
+	igt_output_set_pipe(prim_mode_params.output, prim_mode_params.pipe);
+	igt_output_set_pipe(scnd_mode_params.output, scnd_mode_params.pipe);
+
+	found = igt_override_all_active_output_modes_to_fit_link_bw(&drm.display);
+	igt_require_f(found, "No valid mode combo found.\n");
+
+	prim_mode_params.mode_copy = *igt_output_get_mode(prim_mode_params.output);
+	prim_mode_params.mode = &prim_mode_params.mode_copy;
+	prim_mode_params.primary.w = prim_mode_params.mode->hdisplay;
+	prim_mode_params.primary.h = prim_mode_params.mode->vdisplay;
+
+	scnd_mode_params.mode_copy = *igt_output_get_mode(scnd_mode_params.output);
+	scnd_mode_params.mode = &scnd_mode_params.mode_copy;
+	scnd_mode_params.primary.w = scnd_mode_params.mode->hdisplay;
+	scnd_mode_params.primary.h = scnd_mode_params.mode->vdisplay;
+
+	fill_fb_region(&prim_mode_params.primary, COLOR_PRIM_BG);
+	fill_fb_region(&scnd_mode_params.primary, COLOR_SCND_BG);
+
+	__set_mode_for_params(&prim_mode_params);
+	__set_mode_for_params(&scnd_mode_params);
+}
+
 static void enable_both_screens_and_wait(const struct test_mode *t)
 {
 	fill_fb_region(&prim_mode_params.primary, COLOR_PRIM_BG);
@@ -1691,6 +1718,12 @@ static void enable_both_screens_and_wait(const struct test_mode *t)
 	__set_mode_for_params(&prim_mode_params);
 	__set_mode_for_params(&scnd_mode_params);
 
+	if (igt_display_try_commit_atomic(&drm.display,
+					  DRM_MODE_ATOMIC_TEST_ONLY |
+					  DRM_MODE_ATOMIC_ALLOW_MODESET,
+					  NULL) != 0)
+		update_modeset_cached_params();
+
 	igt_display_commit2(&drm.display, drm.display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY);
 
 	wanted_crc = &blue_crcs[t->format].crc;
Signature · 6 lines
2.20.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#5 lore raw

Re: [igt-dev] [v4 i-g-t 02/14] tests/kms_frontbuffer_tracking: Fix mode selection for 2x tests

Quoted 56 lines · Bhanuprakash Modem

When two monitors connected through MST, the second monitor also tries to use the same mode. So two such modes may not fit into the link bandwidth.

This patch will find a combination of modes that fit into the BW.

V2:
* Remove MST specific logic (Daniel)

Cc Imre Deak <[email protected]>
Cc Ankit Nautiyal <[email protected]>
Cc Daniel Vetter <[email protected]>
---
  tests/kms_frontbuffer_tracking.c | 33 ++++++++++++++++++++++++++++++++
  1 file changed, 33 insertions(+)
tests/kms_frontbuffer_tracking.c +27 -0
index 2e74bec6f..211a5f3f8 100644
@@ -1683,6 +1683,33 @@ static void enable_prim_screen_and_wait(const struct test_mode *t)
  	do_assertions(ASSERT_NO_ACTION_CHANGE);
  }
 
+static void update_modeset_cached_params(void)
+{
+	bool found = false;
+
+	igt_output_set_pipe(prim_mode_params.output, prim_mode_params.pipe);
+	igt_output_set_pipe(scnd_mode_params.output, scnd_mode_params.pipe);
+
+	found = igt_override_all_active_output_modes_to_fit_link_bw(&drm.display);
+	igt_require_f(found, "No valid mode combo found.\n");
+
+	prim_mode_params.mode_copy = *igt_output_get_mode(prim_mode_params.output);
+	prim_mode_params.mode = &prim_mode_params.mode_copy;
+	prim_mode_params.primary.w = prim_mode_params.mode->hdisplay;
+	prim_mode_params.primary.h = prim_mode_params.mode->vdisplay;
+
+	scnd_mode_params.mode_copy = *igt_output_get_mode(scnd_mode_params.output);
+	scnd_mode_params.mode = &scnd_mode_params.mode_copy;
+	scnd_mode_params.primary.w = scnd_mode_params.mode->hdisplay;
+	scnd_mode_params.primary.h = scnd_mode_params.mode->vdisplay;
+
+	fill_fb_region(&prim_mode_params.primary, COLOR_PRIM_BG);
+	fill_fb_region(&scnd_mode_params.primary, COLOR_SCND_BG);
+
+	__set_mode_for_params(&prim_mode_params);
+	__set_mode_for_params(&scnd_mode_params);
+}
+
  static void enable_both_screens_and_wait(const struct test_mode *t)
  {
  	fill_fb_region(&prim_mode_params.primary, COLOR_PRIM_BG);

tests/kms_frontbuffer_tracking.c static void enable_both_screens_and_wait(const struct test_mode *t) · line 1727

Quoted 10 lines
tests/kms_frontbuffer_tracking.c +6 -0
@@ -1691,6 +1718,12 @@ static void enable_both_screens_and_wait(const struct test_mode *t)
  	__set_mode_for_params(&prim_mode_params);
  	__set_mode_for_params(&scnd_mode_params);
 
+	if (igt_display_try_commit_atomic(&drm.display,
+					  DRM_MODE_ATOMIC_TEST_ONLY |
+					  DRM_MODE_ATOMIC_ALLOW_MODESET,
+					  NULL) != 0)
+		update_modeset_cached_params();
+
  	igt_display_commit2(&drm.display, drm.display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY);

As suggested in previous patch, for legacy commit case we need to modify the  igt_override_all_active_output_modes_to_fit_link_bw(), and use try_commit2() calls.

Or else if we want to try combination of modes only for atomic commit, then we need to skip this for legacy commit.

Regards,

Ankit

tests/kms_frontbuffer_tracking.c static void enable_both_screens_and_wait(const struct test_mode *t) · line 1729

Quoted 2 lines
tests/kms_frontbuffer_tracking.c +0 -0
  	wanted_crc = &blue_crcs[t->format].crc;

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#6 lore raw

PATCH v4 3/14 tests/kms_cursor_legacy: Fix mode selection for 2x tests

In reply to Bhanuprakash Modem

When two monitors connected through MST, the second monitor also tries to use the same mode. So two such modes may not fit into the link bandwidth.

This patch will find a combination of modes that fit into the BW.

V2:
* Remove MST specific logic (Daniel)

Cc Imre Deak <[email protected]>
Cc Ankit Nautiyal <[email protected]>
Cc Daniel Vetter <[email protected]>
---
 tests/kms_cursor_legacy.c | 47 ++++++++++++++++++++++++++++++++++++---
 1 file changed, 44 insertions(+), 3 deletions(-)
tests/kms_cursor_legacy.c +44 -3
index 4723e1ff9..5f032afe2 100644
@@ -50,6 +50,15 @@ IGT_TEST_DESCRIPTION("Stress legacy cursor ioctl");
 
 igt_pipe_crc_t *pipe_crc;
 
+static void override_output_modes(igt_display_t *display, igt_output_t *output, igt_output_t *output2)
+{
+	bool found = igt_override_all_active_output_modes_to_fit_link_bw(display);
+	igt_require_f(found, "No valid mode combo found.\n");
+
+	igt_output_set_pipe(output, PIPE_NONE);
+	igt_output_set_pipe(output2, PIPE_NONE);
+}
+
 static void stress(igt_display_t *display,
 		   enum pipe pipe, int num_children, unsigned mode,
 		   int timeout)
@@ -393,6 +402,7 @@ static void flip(igt_display_t *display,
 	struct drm_mode_cursor arg[2];
 	uint64_t *results;
 	struct igt_fb fb_info, fb_info2, argb_fb, cursor_fb, cursor_fb2;
+	igt_output_t *output, *output2;
 
 	results = mmap(NULL, PAGE_SIZE, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
 	igt_assert(results != MAP_FAILED);
@@ -406,9 +416,20 @@ static void flip(igt_display_t *display,
 	if (mode >= flip_test_atomic)
 		igt_require(display->is_atomic);
 
-	igt_require(set_fb_on_crtc(display, flip_pipe, &fb_info));
-	if (flip_pipe != cursor_pipe)
-		igt_require(set_fb_on_crtc(display, cursor_pipe, &fb_info2));
+	igt_require((output = set_fb_on_crtc(display, flip_pipe, &fb_info)));
+	if (flip_pipe != cursor_pipe) {
+		igt_require((output2 = set_fb_on_crtc(display, cursor_pipe, &fb_info2)));
+
+		if (igt_display_try_commit_atomic(display,
+					  DRM_MODE_ATOMIC_TEST_ONLY |
+					  DRM_MODE_ATOMIC_ALLOW_MODESET,
+					  NULL) != 0) {
+			override_output_modes(display, output, output2);
+
+			igt_require((output = set_fb_on_crtc(display, flip_pipe, &fb_info)));
+			igt_require((output2 = set_fb_on_crtc(display, cursor_pipe, &fb_info2)));
+		}
+	}
 
 	igt_create_color_fb(display->drm_fd, fb_info.width, fb_info.height, DRM_FORMAT_ARGB8888, 0, .5, .5, .5, &cursor_fb);
 
@@ -879,6 +900,16 @@ static void two_screens_flip_vs_cursor(igt_display_t *display, int nloops, bool
 	igt_require((output = set_fb_on_crtc(display, pipe, &fb_info)));
 	igt_require((output2 = set_fb_on_crtc(display, pipe2, &fb2_info)));
 
+	if (igt_display_try_commit_atomic(display,
+					  DRM_MODE_ATOMIC_TEST_ONLY |
+					  DRM_MODE_ATOMIC_ALLOW_MODESET,
+					  NULL) != 0) {
+		override_output_modes(display, output, output2);
+
+		igt_require((output = set_fb_on_crtc(display, pipe, &fb_info)));
+		igt_require((output2 = set_fb_on_crtc(display, pipe2, &fb2_info)));
+	}
+
 	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888, 0, 1., 1., 1., &cursor_fb);
 	set_cursor_on_pipe(display, pipe, &cursor_fb);
 	populate_cursor_args(display, pipe, arg1, &cursor_fb);
@@ -1129,6 +1160,16 @@ static void two_screens_cursor_vs_flip(igt_display_t *display, int nloops, bool
 	igt_require((outputs[0] = set_fb_on_crtc(display, pipe[0], &fb_info[0])));
 	igt_require((outputs[1] = set_fb_on_crtc(display, pipe[1], &fb_info[1])));
 
+	if (igt_display_try_commit_atomic(display,
+					  DRM_MODE_ATOMIC_TEST_ONLY |
+					  DRM_MODE_ATOMIC_ALLOW_MODESET,
+					  NULL) != 0) {
+		override_output_modes(display, outputs[0], outputs[1]);
+
+		igt_require((outputs[0] = set_fb_on_crtc(display, pipe[0], &fb_info[0])));
+		igt_require((outputs[1] = set_fb_on_crtc(display, pipe[1], &fb_info[1])));
+	}
+
 	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888, 0, 1., 1., 1., &cursor_fb);
 
 	set_cursor_on_pipe(display, pipe[0], &cursor_fb);
Signature · 6 lines
2.20.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#7 lore raw

Re: [igt-dev] [v4 i-g-t 03/14] tests/kms_cursor_legacy: Fix mode selection for 2x tests

Quoted 90 lines · Bhanuprakash Modem

When two monitors connected through MST, the second monitor also tries to use the same mode. So two such modes may not fit into the link bandwidth.

This patch will find a combination of modes that fit into the BW.

V2:
* Remove MST specific logic (Daniel)

Cc Imre Deak <[email protected]>
Cc Ankit Nautiyal <[email protected]>
Cc Daniel Vetter <[email protected]>
---
  tests/kms_cursor_legacy.c | 47 ++++++++++++++++++++++++++++++++++++---
  1 file changed, 44 insertions(+), 3 deletions(-)
tests/kms_cursor_legacy.c +34 -3
index 4723e1ff9..5f032afe2 100644
@@ -50,6 +50,15 @@ IGT_TEST_DESCRIPTION("Stress legacy cursor ioctl");
 
  igt_pipe_crc_t *pipe_crc;
 
+static void override_output_modes(igt_display_t *display, igt_output_t *output, igt_output_t *output2)
+{
+	bool found = igt_override_all_active_output_modes_to_fit_link_bw(display);
+	igt_require_f(found, "No valid mode combo found.\n");
+
+	igt_output_set_pipe(output, PIPE_NONE);
+	igt_output_set_pipe(output2, PIPE_NONE);
+}
+
  static void stress(igt_display_t *display,
  		   enum pipe pipe, int num_children, unsigned mode,
  		   int timeout)
@@ -393,6 +402,7 @@ static void flip(igt_display_t *display,
  	struct drm_mode_cursor arg[2];
  	uint64_t *results;
  	struct igt_fb fb_info, fb_info2, argb_fb, cursor_fb, cursor_fb2;
+	igt_output_t *output, *output2;
 
  	results = mmap(NULL, PAGE_SIZE, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
  	igt_assert(results != MAP_FAILED);
@@ -406,9 +416,20 @@ static void flip(igt_display_t *display,
  	if (mode >= flip_test_atomic)
  		igt_require(display->is_atomic);
 
-	igt_require(set_fb_on_crtc(display, flip_pipe, &fb_info));
-	if (flip_pipe != cursor_pipe)
-		igt_require(set_fb_on_crtc(display, cursor_pipe, &fb_info2));
+	igt_require((output = set_fb_on_crtc(display, flip_pipe, &fb_info)));
+	if (flip_pipe != cursor_pipe) {
+		igt_require((output2 = set_fb_on_crtc(display, cursor_pipe, &fb_info2)));
+
+		if (igt_display_try_commit_atomic(display,
+					  DRM_MODE_ATOMIC_TEST_ONLY |
+					  DRM_MODE_ATOMIC_ALLOW_MODESET,
+					  NULL) != 0) {
+			override_output_modes(display, output, output2);
+
+			igt_require((output = set_fb_on_crtc(display, flip_pipe, &fb_info)));
+			igt_require((output2 = set_fb_on_crtc(display, cursor_pipe, &fb_info2)));
+		}
+	}
 
  	igt_create_color_fb(display->drm_fd, fb_info.width, fb_info.height, DRM_FORMAT_ARGB8888, 0, .5, .5, .5, &cursor_fb);
 
@@ -879,6 +900,16 @@ static void two_screens_flip_vs_cursor(igt_display_t *display, int nloops, bool
  	igt_require((output = set_fb_on_crtc(display, pipe, &fb_info)));
  	igt_require((output2 = set_fb_on_crtc(display, pipe2, &fb2_info)));
 
+	if (igt_display_try_commit_atomic(display,
+					  DRM_MODE_ATOMIC_TEST_ONLY |
+					  DRM_MODE_ATOMIC_ALLOW_MODESET,
+					  NULL) != 0) {
+		override_output_modes(display, output, output2);
+
+		igt_require((output = set_fb_on_crtc(display, pipe, &fb_info)));
+		igt_require((output2 = set_fb_on_crtc(display, pipe2, &fb2_info)));
+	}
+
  	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888, 0, 1., 1., 1., &cursor_fb);
  	set_cursor_on_pipe(display, pipe, &cursor_fb);
  	populate_cursor_args(display, pipe, arg1, &cursor_fb);
@@ -1129,6 +1160,16 @@ static void two_screens_cursor_vs_flip(igt_display_t *display, int nloops, bool
  	igt_require((outputs[0] = set_fb_on_crtc(display, pipe[0], &fb_info[0])));
  	igt_require((outputs[1] = set_fb_on_crtc(display, pipe[1], &fb_info[1])));
 

tests/kms_cursor_legacy.c static void two_screens_cursor_vs_flip(igt_display_t *display, int nloops, bool · line 1172

Quoted 10 lines
tests/kms_cursor_legacy.c +10 -0
+	if (igt_display_try_commit_atomic(display,
+					  DRM_MODE_ATOMIC_TEST_ONLY |
+					  DRM_MODE_ATOMIC_ALLOW_MODESET,
+					  NULL) != 0) {
+		override_output_modes(display, outputs[0], outputs[1]);
+
+		igt_require((outputs[0] = set_fb_on_crtc(display, pipe[0], &fb_info[0])));
+		igt_require((outputs[1] = set_fb_on_crtc(display, pipe[1], &fb_info[1])));
+	}
+

Here again we have 2 versions of subtests legacy and atomic, and this will not work for the legacy part.

As mentioned in previous patches, need to add support for legacy try commit.

Apart from that other changes seem reasonable to me.

Regards,

Ankit

tests/kms_cursor_legacy.c static void two_screens_cursor_vs_flip(igt_display_t *display, int nloops, bool · line 1175

Quoted 3 lines
tests/kms_cursor_legacy.c +0 -0
  	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888, 0, 1., 1., 1., &cursor_fb);
 
  	set_cursor_on_pipe(display, pipe[0], &cursor_fb);

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#8 lore raw

PATCH v4 4/14 tests/debugfs_test: Fix mode selection for MST

In reply to Bhanuprakash Modem

When two monitors connected through MST, the second monitor also tries to use the same mode. So two such modes may not fit into the link bandwidth.

This patch will find a combination of modes that fit into the BW.

Cc Imre Deak <[email protected]>
Cc Ankit Nautiyal <[email protected]>
Cc Daniel Vetter <[email protected]>
---
 tests/debugfs_test.c | 10 ++++++++++
 1 file changed, 10 insertions(+)
tests/debugfs_test.c +10 -0
index 46ba0a8be..83875fbce 100644
@@ -104,6 +104,7 @@ static void kms_tests(int fd, int debugfs)
 
 	igt_subtest("read_all_entries_display_on") {
 		/* try to light all pipes */
+retry:
 		for_each_pipe(&display, pipe) {
 			igt_output_t *output;
 
@@ -128,6 +129,15 @@ static void kms_tests(int fd, int debugfs)
 			}
 		}
 
+		if (igt_display_try_commit_atomic(&display,
+					DRM_MODE_ATOMIC_TEST_ONLY |
+					DRM_MODE_ATOMIC_ALLOW_MODESET,
+					NULL) != 0) {
+			bool found = igt_override_all_active_output_modes_to_fit_link_bw(&display);
+			igt_require_f(found, "No valid mode combo found.\n");
+			goto retry;
+		}
+
 		igt_display_commit2(&display, display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY);
 
 		read_and_discard_sysfs_entries(debugfs, 0);
Signature · 6 lines
2.20.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#9 lore raw

PATCH v4 5/14 tests/kms_content_protection: Fix mode selection for 2x tests

In reply to Bhanuprakash Modem

When two monitors connected through MST, the second monitor also tries to use the same mode. So two such modes may not fit into the link bandwidth.

This patch will find a combination of modes that fit into the BW.

Cc Imre Deak <[email protected]>
Cc Ankit Nautiyal <[email protected]>
Cc Daniel Vetter <[email protected]>
---
 tests/kms_content_protection.c | 41 +++++++++++++---------------------
 1 file changed, 16 insertions(+), 25 deletions(-)
tests/kms_content_protection.c +16 -25
index 5a75b871c..631a430f1 100644
@@ -452,39 +452,18 @@ static bool sink_hdcp2_capable(igt_output_t *output)
 	return strstr(buf, "HDCP2.2");
 }
 
-static void prepare_modeset_on_mst_output(igt_output_t *output, enum pipe pipe)
+static void prepare_modeset_on_mst_output(igt_output_t *output)
 {
-	drmModeConnectorPtr c = output->config.connector;
 	drmModeModeInfo *mode;
 	igt_plane_t *primary;
-	int i, width, height;
+	int width, height;
+	enum pipe pipe = output->pending_pipe;
 
 	mode = igt_output_get_mode(output);
 
-	/*
-	 * TODO: Add logic to use the highest possible modes on each output.
-	 * Currently using 2k modes by default on all the outputs.
-	 */
-	igt_debug("Before mode override: Output %s Mode hdisplay %d Mode vdisplay %d\n",
-		   output->name, mode->hdisplay, mode->vdisplay);
-
-	if (mode->hdisplay > 1920 && mode->vdisplay > 1080) {
-		for (i = 0; i < c->count_modes; i++) {
-			if (c->modes[i].hdisplay <= 1920 && c->modes[i].vdisplay <= 1080) {
-				mode = &c->modes[i];
-				igt_output_override_mode(output, mode);
-				break;
-			}
-		}
-	}
-
-	igt_debug("After mode overide: Output %s Mode hdisplay %d Mode vdisplay %d\n",
-		   output->name, mode->hdisplay, mode->vdisplay);
-
 	width = mode->hdisplay;
 	height = mode->vdisplay;
 
-	igt_output_set_pipe(output, pipe);
 	primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
 	igt_plane_set_fb(primary, NULL);
 	igt_plane_set_fb(primary, pipe % 2 ? &data.red : &data.green);
@@ -624,7 +603,8 @@ test_content_protection_mst(int content_type)
 
 		igt_assert_f(igt_pipe_connector_valid(pipe, output), "Output-pipe combination invalid\n");
 
-		prepare_modeset_on_mst_output(output, pipe);
+		igt_output_set_pipe(output, pipe);
+		prepare_modeset_on_mst_output(output);
 		mst_output[dp_mst_outputs++] = output;
 
 		pipe++;
@@ -635,6 +615,17 @@ test_content_protection_mst(int content_type)
 
 	igt_require_f(dp_mst_outputs > 1, "No DP MST set up with >= 2 outputs found in a single topology\n");
 
+	if (igt_display_try_commit_atomic(display,
+				DRM_MODE_ATOMIC_TEST_ONLY |
+				DRM_MODE_ATOMIC_ALLOW_MODESET,
+				NULL) != 0) {
+		bool found = igt_override_all_active_output_modes_to_fit_link_bw(display);
+		igt_require_f(found, "No valid mode combo found for MST modeset\n");
+
+		for (count = 0; count < dp_mst_outputs; count++)
+			prepare_modeset_on_mst_output(mst_output[count]);
+	}
+
 	ret = igt_display_try_commit2(display, COMMIT_ATOMIC);
 	igt_require_f(ret == 0, "Commit failure during MST modeset\n");
 
Signature · 6 lines
2.20.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#10 lore raw

PATCH v4 6/14 tests/kms_plane_scaling: Fix mode selection for 2x tests

In reply to Bhanuprakash Modem

When two monitors connected through MST, the second monitor also tries to use the same mode. So two such modes may not fit into the link bandwidth.

This patch will find a combination of modes that fit into the BW.

Cc Imre Deak <[email protected]>
Cc Ankit Nautiyal <[email protected]>
Cc Daniel Vetter <[email protected]>
---
 tests/kms_plane_scaling.c | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)
tests/kms_plane_scaling.c +12 -3
index 34efc588e..1bda5ff65 100644
@@ -630,9 +630,6 @@ static void test_scaler_with_multi_pipe_plane(data_t *d)
 	d->plane3 = igt_output_get_plane(output2, 0);
 	d->plane4 = get_num_scalers(d, pipe2) >= 2 ? igt_output_get_plane(output2, 1) : NULL;
 
-	mode1 = igt_output_get_mode(output1);
-	mode2 = igt_output_get_mode(output2);
-
 	igt_skip_on(!igt_display_has_format_mod(display, DRM_FORMAT_XRGB8888,
 						tiling));
 
@@ -658,8 +655,20 @@ static void test_scaler_with_multi_pipe_plane(data_t *d)
 	igt_plane_set_fb(d->plane3, &d->fb[2]);
 	if (d->plane4)
 		igt_plane_set_fb(d->plane4, &d->fb[3]);
+
+	if (igt_display_try_commit_atomic(display,
+				DRM_MODE_ATOMIC_TEST_ONLY |
+				DRM_MODE_ATOMIC_ALLOW_MODESET,
+				NULL) != 0) {
+		bool found = igt_override_all_active_output_modes_to_fit_link_bw(display);
+		igt_require_f(found, "No valid mode combo found.\n");
+	}
+
 	igt_display_commit2(display, COMMIT_ATOMIC);
 
+	mode1 = igt_output_get_mode(output1);
+	mode2 = igt_output_get_mode(output2);
+
 	/* Upscaling Primary */
 	igt_plane_set_size(d->plane1, mode1->hdisplay, mode1->vdisplay);
 	igt_plane_set_size(d->plane3, mode2->hdisplay, mode2->vdisplay);
Signature · 6 lines
2.20.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#11 lore raw

PATCH v4 7/14 tests/kms_atomic_transition: Fix mode selection for 2x tests

In reply to Bhanuprakash Modem

When two monitors connected through MST, the second monitor also tries to use the same mode. So two such modes may not fit into the link bandwidth.

This patch will find a combination of modes that fit into the BW.

Cc Imre Deak <[email protected]>
Cc Ankit Nautiyal <[email protected]>
Cc Daniel Vetter <[email protected]>
---
 tests/kms_atomic_transition.c | 10 ++++++++++
 1 file changed, 10 insertions(+)
tests/kms_atomic_transition.c +10 -0
index be60940d7..a408e696a 100644
@@ -100,6 +100,7 @@ run_primary_test(data_t *data, enum pipe pipe, igt_output_t *output)
 	igt_plane_set_fb(primary, NULL);
 	igt_output_set_pipe(output, PIPE_NONE);
 	igt_remove_fb(data->drm_fd, &fb);
+	igt_display_commit2(&data->display, COMMIT_ATOMIC);
 }
 
 static void *fence_inc_thread(void *arg)
@@ -793,6 +794,7 @@ static void run_modeset_tests(data_t *data, int howmany, bool nonblocking, bool
 	for (i = 0; i < data->display.n_outputs; i++)
 		igt_output_set_pipe(&data->display.outputs[i], PIPE_NONE);
 
+retry:
 	for_each_connected_output(&data->display, output) {
 		drmModeModeInfo *mode = igt_output_get_mode(output);
 
@@ -839,6 +841,14 @@ static void run_modeset_tests(data_t *data, int howmany, bool nonblocking, bool
 
 	iter_max = 1 << j;
 
+	if (igt_display_try_commit_atomic(&data->display,
+				DRM_MODE_ATOMIC_TEST_ONLY |
+				DRM_MODE_ATOMIC_ALLOW_MODESET,
+				NULL) != 0) {
+		bool found = igt_override_all_active_output_modes_to_fit_link_bw(&data->display);
+		igt_require_f(found, "No valid mode combo found.\n");
+		goto retry;
+	}
 	igt_display_commit2(&data->display, COMMIT_ATOMIC);
 
 	for (i = 0; i < iter_max; i++) {
Signature · 6 lines
2.20.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#12 lore raw

PATCH v4 8/14 tests/kms_plane: Reset the state before exiting the test

In reply to Bhanuprakash Modem

Before starting the next subtest, clean up the states to default values, those are assumed by other tests. This patch will also fix few typos & depricated macros.

Cc Imre Deak <[email protected]>
Cc Ankit Nautiyal <[email protected]>
Cc Daniel Vetter <[email protected]>
---
 tests/kms_plane.c | 19 +++++++++++++------
 1 file changed, 13 insertions(+), 6 deletions(-)
tests/kms_plane.c +13 -6
index 9fe253a8c..bea3cef00 100644
@@ -132,7 +132,7 @@ test_grab_crc(data_t *data, igt_output_t *output, enum pipe pipe,
 
 	igt_output_set_pipe(output, pipe);
 
-	primary = igt_output_get_plane(output, 0);
+	primary = igt_output_get_plane(output, DRM_PLANE_TYPE_PRIMARY);
 
 	mode = igt_output_get_mode(output);
 	if (flags & TEST_POSITION_PARTIALLY_COVERED) {
@@ -251,7 +251,11 @@ test_plane_position_with_output(data_t *data,
 	igt_plane_set_fb(sprite, NULL);
 
 	/* reset the constraint on the pipe */
-	igt_output_set_pipe(output, PIPE_ANY);
+	igt_output_set_pipe(output, PIPE_NONE);
+	igt_display_commit2(&data->display, data->display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY);
+
+	igt_remove_fb(data->drm_fd, &primary_fb);
+	igt_remove_fb(data->drm_fd, &sprite_fb);
 }
 
 static void
@@ -288,7 +292,7 @@ test_plane_position(data_t *data, enum pipe pipe, unsigned int flags)
  *     (vdisplay, hdisplay) we do get the same CRC than the full blue fb.
  */
 static void
-create_fb_for_mode__panning(data_t *data, drmModeModeInfo *mode,
+create_fb_for_mode_panning(data_t *data, drmModeModeInfo *mode,
 			    struct igt_fb *fb /* out */)
 {
 	unsigned int fb_id;
@@ -332,9 +336,9 @@ test_plane_panning_with_output(data_t *data,
 	igt_output_set_pipe(output, pipe);
 
 	mode = igt_output_get_mode(output);
-	primary = igt_output_get_plane(output, 0);
+	primary = igt_output_get_plane(output, DRM_PLANE_TYPE_PRIMARY);
 
-	create_fb_for_mode__panning(data, mode, &primary_fb);
+	create_fb_for_mode_panning(data, mode, &primary_fb);
 	igt_plane_set_fb(primary, &primary_fb);
 
 	if (flags & TEST_PANNING_TOP_LEFT)
@@ -355,8 +359,11 @@ test_plane_panning_with_output(data_t *data,
 	igt_plane_set_fb(primary, NULL);
 
 	/* reset states to neutral values, assumed by other tests */
-	igt_output_set_pipe(output, PIPE_ANY);
+	igt_output_set_pipe(output, PIPE_NONE);
 	igt_fb_set_position(&primary_fb, primary, 0, 0);
+	igt_display_commit2(&data->display, data->display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY);
+
+	igt_remove_fb(data->drm_fd, &primary_fb);
 }
 
 static void
Signature · 6 lines
2.20.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#13 lore raw

PATCH v4 9/14 tests/kms_plane_alpha_blend: Reset the state before exiting the test

In reply to Bhanuprakash Modem

Before starting the next subtest, clean up the states to default values, those are assumed by other tests. This patch will also fix few redundant checks.

Cc Imre Deak <[email protected]>
Cc Ankit Nautiyal <[email protected]>
Cc Daniel Vetter <[email protected]>
---
 tests/kms_plane_alpha_blend.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
tests/kms_plane_alpha_blend.c +3 -2
index 5e80ae36e..a37cb27c7 100644
@@ -237,8 +237,6 @@ static void prepare_crtc(data_t *data, igt_output_t *output, enum pipe pipe)
 	}
 
 	igt_plane_set_fb(primary, &data->black_fb);
-	/* reset alpha property to default */
-	reset_alpha(display, pipe);
 }
 
 static void basic_alpha(data_t *data, enum pipe pipe, igt_plane_t *plane)
@@ -507,6 +505,9 @@ static void run_test_on_pipe_planes(data_t *data, enum pipe pipe, bool blend,
 		igt_plane_set_fb(plane, NULL);
 	}
 
+	igt_output_set_pipe(output, PIPE_NONE);
+	igt_display_commit2(display, COMMIT_ATOMIC);
+
 	igt_require_f(found, "No planes with %s property found\n",
 		      blend ? "pixel blending mode" : "alpha");
 	igt_require_f(multiply, "Multiplied (plane x pixel) alpha not available\n");
Signature · 6 lines
2.20.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#14 lore raw

PATCH v4 10/14 tests/kms_cursor_edge_walk: Reset the state before exiting the test

In reply to Bhanuprakash Modem

Before starting the next subtest, clean up the states to default values, those are assumed by other tests.

Cc Imre Deak <[email protected]>
Cc Ankit Nautiyal <[email protected]>
Cc Daniel Vetter <[email protected]>
---
 tests/kms_cursor_edge_walk.c | 3 +++
 1 file changed, 3 insertions(+)
tests/kms_cursor_edge_walk.c +3 -0
index 69662afec..d1d8a9143 100644
@@ -225,6 +225,7 @@ static void cleanup_crtc(data_t *data)
 
 	igt_remove_fb(data->drm_fd, &data->primary_fb);
 	igt_remove_fb(data->drm_fd, &data->fb);
+	igt_display_commit2(display, display->is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY);
 }
 
 static void prepare_crtc(data_t *data)
@@ -268,6 +269,8 @@ static void test_crtc(data_t *data, unsigned int edges)
 	create_cursor_fb(data, data->curw, data->curh);
 
 	test_edges(data, edges);
+
+	cleanup_crtc(data);
 }
 
 static int opt_handler(int opt, int opt_index, void *_data)
Signature · 6 lines
2.20.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#15 lore raw

PATCH v4 11/14 tests/kms_plane_lowres: Reset the state before exiting the test

In reply to Bhanuprakash Modem

Before starting the next subtest, clean up the states to default values, those are assumed by other tests. This patch will also fix few redundant checks.

Cc Imre Deak <[email protected]>
Cc Ankit Nautiyal <[email protected]>
Cc Daniel Vetter <[email protected]>
---
 tests/kms_plane_lowres.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)
tests/kms_plane_lowres.c +3 -6
index 5cfe53c8b..95346e289 100644
@@ -270,16 +270,13 @@ test_planes_on_pipe(data_t *data, uint64_t modifier)
 	igt_info("Testing connector %s using pipe %s\n",
 		 igt_output_name(data->output), kmstest_pipe_name(data->pipe));
 
-	for_each_plane_on_pipe(&data->display, data->pipe, plane) {
-		data->output = igt_get_single_output_for_pipe(&data->display, data->pipe);
-		igt_require(data->output);
-
+	for_each_plane_on_pipe(&data->display, data->pipe, plane)
 		tested += test_planes_on_pipe_with_output(data, plane, modifier);
-	}
 
-	igt_assert(tested > 0);
 	igt_output_set_pipe(data->output, PIPE_NONE);
 	igt_display_commit2(&data->display, COMMIT_ATOMIC);
+
+	igt_assert(tested > 0);
 }
 
 igt_main
Signature · 6 lines
2.20.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#16 lore raw

PATCH v4 12/14 tests/kms_plane_cursor: Reset the state before exiting the test

In reply to Bhanuprakash Modem

Before starting the next subtest, clean up the states to default values, those are assumed by other tests.

Cc Imre Deak <[email protected]>
Cc Ankit Nautiyal <[email protected]>
Cc Daniel Vetter <[email protected]>
---
 tests/kms_plane_cursor.c | 4 ++++
 1 file changed, 4 insertions(+)
tests/kms_plane_cursor.c +4 -0
index bc9d42940..9bda47466 100644
@@ -93,6 +93,10 @@ static void test_fini(data_t *data)
 {
 	igt_pipe_crc_free(data->pipe_crc);
 	igt_display_reset(&data->display);
+	igt_plane_set_fb(data->primary, NULL);
+	igt_plane_set_fb(data->overlay, NULL);
+	igt_plane_set_fb(data->cursor, NULL);
+	igt_display_commit2(&data->display, COMMIT_ATOMIC);
 }
 
 /* Fills a FB with the solid color given. */
Signature · 6 lines
2.20.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#17 lore raw

PATCH v4 13/14 tests/kms_flip_scaled_crc: Reset the state before exiting the test

In reply to Bhanuprakash Modem

Before starting the next subtest, clean up the states to default values, those are assumed by other tests.

Cc Imre Deak <[email protected]>
Cc Ankit Nautiyal <[email protected]>
Cc Daniel Vetter <[email protected]>
---
 tests/kms_flip_scaled_crc.c | 5 +++++
 1 file changed, 5 insertions(+)
tests/kms_flip_scaled_crc.c +5 -0
index 4923f1235..671ba7367 100644
@@ -156,6 +156,7 @@ static void test_flip_to_scaled(data_t *data, uint32_t index, enum pipe pipe,
 	int ret;
 
 	igt_display_reset(&data->display);
+	igt_display_commit2(&data->display, COMMIT_ATOMIC);
 
 	igt_debug("running on output %s pipe %s\n", output->name,
 		  kmstest_pipe_name(pipe));
@@ -246,6 +247,10 @@ static void test_flip_to_scaled(data_t *data, uint32_t index, enum pipe pipe,
 	data->pipe_crc = NULL;
 
 	clear_lut(data, pipe);
+
+	igt_output_set_pipe(output, pipe);
+	igt_plane_set_fb(primary, NULL);
+	igt_display_commit2(&data->display, COMMIT_ATOMIC);
 }
 
 igt_main
Signature · 6 lines
2.20.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#18 lore raw

PATCH v4 14/14 tests/kms_vblank: Reset the state before exiting the test

In reply to Bhanuprakash Modem

Before starting the next subtest, clean up the states to default values, those are assumed by other tests.

Cc Imre Deak <[email protected]>
Cc Ankit Nautiyal <[email protected]>
Cc Daniel Vetter <[email protected]>
---
 tests/kms_vblank.c | 2 ++
 1 file changed, 2 insertions(+)
tests/kms_vblank.c +2 -0
index e561e41d7..93b01eba0 100644
@@ -96,6 +96,8 @@ static void prepare_crtc(data_t *data, int fd, igt_output_t *output)
 
 static void cleanup_crtc(data_t *data, int fd, igt_output_t *output)
 {
+	igt_output_set_pipe(output, PIPE_NONE);
+	igt_display_commit(&data->display);
 	igt_remove_fb(fd, &data->primary_fb);
 }
 
Signature · 6 lines
2.20.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#19 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for Fix mode selection for 2x tests (rev4)

In reply to Bhanuprakash Modem
== Series Details ==

== Series Details ==

Series: Fix mode selection for 2x tests (rev4)
URL : https://patchwork.freedesktop.org/series/88902/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_10038 -> IGTPW_5775
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/index.html

Known issues
------------

Here are the changes found in IGTPW_5775 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@amdgpu/amd_basic@semaphore:
- fi-bdw-5557u: NOTRUN -> [SKIP][1] ([fdo#109271]) +23 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/fi-bdw-5557u/igt@amdgpu/[email protected]

* igt@core_hotunplug@unbind-rebind:
- fi-bdw-5557u: NOTRUN -> [WARN][2] ([i915#2283])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/fi-bdw-5557u/igt@[email protected]

#### Possible fixes ####

* igt@i915_pm_rpm@basic-rte:
- {fi-tgl-1115g4}: [DMESG-WARN][3] -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10038/fi-tgl-1115g4/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/fi-tgl-1115g4/igt@[email protected]

* igt@kms_frontbuffer_tracking@basic:
- {fi-rkl-11500t}: [SKIP][5] ([i915#1849] / [i915#3180]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10038/fi-rkl-11500t/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/fi-rkl-11500t/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#2283]: https://gitlab.freedesktop.org/drm/intel/issues/2283
[i915#3180]: https://gitlab.freedesktop.org/drm/intel/issues/3180

Participating hosts (46 -> 40)
------------------------------

Missing (6): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-ctg-p8600 fi-dg1-1 fi-bdw-samus

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_6077 -> IGTPW_5775

CI-20190529: 20190529
CI_DRM_10038: 11b6e4accaaf1d9d04921f278c6724ee7e4d8e43 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_5775: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/index.html
IGT_6077: 126a3f6fc0e97786e2819085efc84e741093aed5 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/index.html

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#20 lore raw

[igt-dev] ✗ Fi.CI.IGT: failure for Fix mode selection for 2x tests (rev4)

In reply to Bhanuprakash Modem
== Series Details ==

== Series Details ==

Series: Fix mode selection for 2x tests (rev4)
URL : https://patchwork.freedesktop.org/series/88902/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_10038_full -> IGTPW_5775_full
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_5775_full absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_5775_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/index.html

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_5775_full:

### IGT changes ###

#### Possible regressions ####

* igt@kms_plane@plane-panning-bottom-right-pipe-a-planes:
- shard-snb: [PASS][1] -> [FAIL][2] +4 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10038/shard-snb6/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-snb6/igt@[email protected]

* igt@kms_plane@plane-panning-bottom-right-pipe-b-planes:
- shard-tglb: [PASS][3] -> [FAIL][4] +20 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10038/shard-tglb1/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-tglb2/igt@[email protected]

* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes:
- shard-kbl: NOTRUN -> [FAIL][5] +2 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-kbl7/igt@[email protected]
- shard-glk: NOTRUN -> [FAIL][6] +2 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-glk8/igt@[email protected]

* igt@kms_plane@plane-panning-top-left-pipe-c-planes:
- shard-kbl: [PASS][7] -> [FAIL][8] +10 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10038/shard-kbl4/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-kbl3/igt@[email protected]
- shard-apl: [PASS][9] -> [FAIL][10] +7 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10038/shard-apl3/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-apl2/igt@[email protected]

* igt@kms_plane@plane-position-covered-pipe-a-planes:
- shard-snb: NOTRUN -> [FAIL][11] +2 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-snb2/igt@[email protected]

* igt@kms_plane@plane-position-covered-pipe-b-planes:
- shard-glk: [PASS][12] -> [FAIL][13] +13 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10038/shard-glk9/igt@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-glk2/igt@[email protected]

* igt@kms_plane@plane-position-covered-pipe-c-planes:
- shard-apl: NOTRUN -> [FAIL][14] +1 similar issue
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-apl1/igt@[email protected]

* igt@kms_plane@plane-position-hole-dpms-pipe-a-planes:
- shard-iclb: [PASS][15] -> [FAIL][16] +14 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10038/shard-iclb5/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-iclb3/igt@[email protected]

* igt@kms_plane@plane-position-hole-dpms-pipe-c-planes:
- shard-iclb: NOTRUN -> [FAIL][17]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-iclb6/igt@[email protected]
- shard-tglb: NOTRUN -> [FAIL][18] +1 similar issue
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-tglb3/igt@[email protected]

#### Warnings ####

* igt@kms_plane@plane-position-hole-pipe-a-planes:
- shard-iclb: [FAIL][19] ([i915#2472]) -> [FAIL][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10038/shard-iclb1/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-iclb6/igt@[email protected]

Known issues
------------

Here are the changes found in IGTPW_5775_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_ctx_isolation@preservation-s3@bcs0:
- shard-kbl: NOTRUN -> [DMESG-WARN][21] ([i915#180]) +2 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-kbl2/igt@gem_ctx_isolation@[email protected]

* igt@gem_ctx_param@set-priority-not-supported:
- shard-tglb: NOTRUN -> [SKIP][22] ([fdo#109314])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-tglb5/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][23] ([fdo#109314])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-iclb2/igt@[email protected]

* igt@gem_ctx_persistence@many-contexts:
- shard-tglb: [PASS][24] -> [FAIL][25] ([i915#2410])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10038/shard-tglb3/igt@[email protected]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-tglb6/igt@[email protected]

* igt@gem_ctx_persistence@process:
- shard-snb: NOTRUN -> [SKIP][26] ([fdo#109271] / [i915#1099]) +3 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-snb5/igt@[email protected]

* igt@gem_exec_fair@basic-deadline:
- shard-glk: [PASS][27] -> [FAIL][28] ([i915#2846])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10038/shard-glk3/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-glk2/igt@[email protected]

* igt@gem_exec_fair@basic-none@rcs0:
- shard-glk: NOTRUN -> [FAIL][29] ([i915#2842])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-glk2/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-none@vcs0:
- shard-kbl: NOTRUN -> [FAIL][30] ([i915#2842]) +2 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-kbl2/igt@gem_exec_fair@[email protected]
- shard-tglb: NOTRUN -> [FAIL][31] ([i915#2842]) +4 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-tglb5/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@vcs1:
- shard-iclb: NOTRUN -> [FAIL][32] ([i915#2842]) +4 similar issues
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-iclb4/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@vecs0:
- shard-tglb: [PASS][33] -> [FAIL][34] ([i915#2842])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10038/shard-tglb8/igt@gem_exec_fair@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-tglb1/igt@gem_exec_fair@[email protected]
- shard-iclb: [PASS][35] -> [FAIL][36] ([i915#2842])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10038/shard-iclb3/igt@gem_exec_fair@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-iclb4/igt@gem_exec_fair@[email protected]

* igt@gem_exec_reloc@basic-wide-active@bcs0:
- shard-apl: NOTRUN -> [FAIL][37] ([i915#2389]) +3 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-apl7/igt@gem_exec_reloc@[email protected]

* igt@gem_pread@exhaustion:
- shard-tglb: NOTRUN -> [WARN][38] ([i915#2658])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-tglb1/igt@[email protected]
- shard-glk: NOTRUN -> [WARN][39] ([i915#2658])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-glk8/igt@[email protected]
- shard-iclb: NOTRUN -> [WARN][40] ([i915#2658])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-iclb3/igt@[email protected]
- shard-snb: NOTRUN -> [WARN][41] ([i915#2658])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-snb7/igt@[email protected]
- shard-kbl: NOTRUN -> [WARN][42] ([i915#2658])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-kbl7/igt@[email protected]

* igt@gem_render_copy@y-tiled-mc-ccs-to-vebox-y-tiled:
- shard-iclb: NOTRUN -> [SKIP][43] ([i915#768]) +1 similar issue
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-iclb4/igt@[email protected]

* igt@gem_userptr_blits@dmabuf-sync:
- shard-apl: NOTRUN -> [SKIP][44] ([fdo#109271] / [i915#3323])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-apl3/igt@[email protected]

* igt@gem_userptr_blits@dmabuf-unsync:
- shard-tglb: NOTRUN -> [SKIP][45] ([i915#3297])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-tglb8/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][46] ([i915#3297])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-iclb1/igt@[email protected]

* igt@gem_userptr_blits@vma-merge:
- shard-snb: NOTRUN -> [FAIL][47] ([i915#2724])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-snb2/igt@[email protected]

* igt@gem_vm_create@destroy-race:
- shard-tglb: [PASS][48] -> [FAIL][49] ([i915#2822])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10038/shard-tglb3/igt@[email protected]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-tglb6/igt@[email protected]

* igt@gen3_render_tiledx_blits:
- shard-iclb: NOTRUN -> [SKIP][50] ([fdo#109289])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-iclb7/igt@gen3_render_tiledx_blits.html
- shard-tglb: NOTRUN -> [SKIP][51] ([fdo#109289])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-tglb3/igt@gen3_render_tiledx_blits.html

* igt@gen9_exec_parse@allowed-all:
- shard-iclb: NOTRUN -> [SKIP][52] ([fdo#112306]) +1 similar issue
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-iclb6/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][53] ([fdo#112306]) +1 similar issue
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-tglb7/igt@[email protected]

* igt@gen9_exec_parse@batch-invalid-length:
- shard-snb: NOTRUN -> [SKIP][54] ([fdo#109271]) +353 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-snb7/igt@[email protected]

* igt@i915_pm_dc@dc6-psr:
- shard-iclb: NOTRUN -> [FAIL][55] ([i915#454])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-iclb6/igt@[email protected]
- shard-tglb: NOTRUN -> [FAIL][56] ([i915#454])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-tglb7/igt@[email protected]

* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp:
- shard-kbl: NOTRUN -> [SKIP][57] ([fdo#109271] / [i915#1937])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-kbl1/igt@i915_pm_lpsp@[email protected]
- shard-apl: NOTRUN -> [SKIP][58] ([fdo#109271] / [i915#1937])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-apl6/igt@i915_pm_lpsp@[email protected]

* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a:
- shard-glk: NOTRUN -> [SKIP][59] ([fdo#109271] / [i915#1937])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-glk5/igt@i915_pm_lpsp@[email protected]

* igt@i915_pm_rpm@modeset-pc8-residency-stress:
- shard-apl: NOTRUN -> [SKIP][60] ([fdo#109271]) +247 similar issues
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-apl8/igt@[email protected]

* igt@i915_suspend@fence-restore-untiled:
- shard-iclb: NOTRUN -> [INCOMPLETE][61] ([i915#1185])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-iclb3/igt@[email protected]

* igt@kms_big_fb@yf-tiled-addfb-size-overflow:
- shard-tglb: NOTRUN -> [SKIP][62] ([fdo#111615]) +5 similar issues
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-tglb6/igt@[email protected]

* igt@kms_big_joiner@invalid-modeset:
- shard-apl: NOTRUN -> [SKIP][63] ([fdo#109271] / [i915#2705])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-apl3/igt@[email protected]

* igt@kms_chamelium@vga-hpd:
- shard-apl: NOTRUN -> [SKIP][64] ([fdo#109271] / [fdo#111827]) +23 similar issues
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-apl2/igt@[email protected]

* igt@kms_chamelium@vga-hpd-enable-disable-mode:
- shard-glk: NOTRUN -> [SKIP][65] ([fdo#109271] / [fdo#111827]) +6 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-glk6/igt@[email protected]

* igt@kms_color@pipe-a-degamma:
- shard-tglb: NOTRUN -> [FAIL][66] ([i915#1149])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-tglb8/igt@[email protected]
- shard-iclb: NOTRUN -> [FAIL][67] ([i915#1149])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-iclb1/igt@[email protected]

* igt@kms_color_chamelium@pipe-a-degamma:
- shard-kbl: NOTRUN -> [SKIP][68] ([fdo#109271] / [fdo#111827]) +13 similar issues
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-kbl3/igt@[email protected]

* igt@kms_color_chamelium@pipe-b-ctm-red-to-blue:
- shard-iclb: NOTRUN -> [SKIP][69] ([fdo#109284] / [fdo#111827]) +2 similar issues
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-iclb1/igt@[email protected]

* igt@kms_color_chamelium@pipe-c-ctm-red-to-blue:
- shard-snb: NOTRUN -> [SKIP][70] ([fdo#109271] / [fdo#111827]) +19 similar issues
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-snb5/igt@[email protected]

* igt@kms_color_chamelium@pipe-d-ctm-red-to-blue:
- shard-tglb: NOTRUN -> [SKIP][71] ([fdo#109284] / [fdo#111827]) +4 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-tglb2/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][72] ([fdo#109278] / [fdo#109284] / [fdo#111827])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-iclb8/igt@[email protected]

* igt@kms_content_protection@srm:
- shard-kbl: NOTRUN -> [TIMEOUT][73] ([i915#1319])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-kbl2/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-512x512-offscreen:
- shard-iclb: NOTRUN -> [SKIP][74] ([fdo#109278] / [fdo#109279])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-iclb3/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][75] ([fdo#109279] / [i915#3359])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-tglb2/igt@[email protected]

* igt@kms_cursor_crc@pipe-b-cursor-32x32-onscreen:
- shard-tglb: NOTRUN -> [SKIP][76] ([i915#3319]) +1 similar issue
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-tglb8/igt@[email protected]

* igt@kms_cursor_crc@pipe-b-cursor-64x64-offscreen:
- shard-tglb: [PASS][77] -> [DMESG-WARN][78] ([i915#2868])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10038/shard-tglb6/igt@[email protected]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-tglb5/igt@[email protected]

* igt@kms_cursor_crc@pipe-d-cursor-256x256-random:
- shard-glk: NOTRUN -> [SKIP][79] ([fdo#109271]) +82 similar issues
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-glk9/igt@[email protected]

* igt@kms_cursor_crc@pipe-d-cursor-dpms:
- shard-iclb: NOTRUN -> [SKIP][80] ([fdo#109278]) +9 similar issues
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-iclb5/igt@[email protected]

* igt@kms_cursor_crc@pipe-d-cursor-max-size-rapid-movement:
- shard-tglb: NOTRUN -> [SKIP][81] ([i915#3359])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-tglb8/igt@[email protected]

* igt@kms_cursor_legacy@cursorb-vs-flipa-varying-size:
- shard-iclb: NOTRUN -> [SKIP][82] ([fdo#109274] / [fdo#109278])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-iclb6/igt@[email protected]

* igt@kms_dp_tiled_display@basic-test-pattern-with-chamelium:
- shard-tglb: NOTRUN -> [SKIP][83] ([i915#2065])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-tglb1/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][84] ([i915#2065])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-iclb3/igt@[email protected]

* igt@kms_flip@2x-flip-vs-expired-vblank@ac-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][85] -> [FAIL][86] ([i915#79])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10038/shard-glk4/igt@kms_flip@[email protected]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-glk3/igt@kms_flip@[email protected]

* igt@kms_flip@2x-flip-vs-wf_vblank-interruptible:
- shard-iclb: NOTRUN -> [SKIP][87] ([fdo#109274]) +1 similar issue
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-iclb4/igt@kms_flip@2x-flip-vs-wf_vblank-interruptible.html

* igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
- shard-kbl: [PASS][88] -> [DMESG-WARN][89] ([i915#180]) +6 similar issues
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10038/shard-kbl2/igt@kms_flip@[email protected]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-kbl1/igt@kms_flip@[email protected]
- shard-apl: [PASS][90] -> [DMESG-WARN][91] ([i915#180]) +2 similar issues
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10038/shard-apl2/igt@kms_flip@[email protected]
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-apl3/igt@kms_flip@[email protected]

* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs:
- shard-tglb: NOTRUN -> [SKIP][92] ([i915#2587])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-tglb6/igt@[email protected]

* igt@kms_frontbuffer_tracking@psr-2p-primscrn-shrfb-plflip-blt:
- shard-iclb: NOTRUN -> [SKIP][93] ([fdo#109280]) +11 similar issues
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-iclb3/igt@[email protected]

* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-draw-pwrite:
- shard-tglb: NOTRUN -> [SKIP][94] ([fdo#111825]) +14 similar issues
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-tglb3/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-draw-pwrite.html

* igt@kms_hdr@bpc-switch-suspend:
- shard-apl: NOTRUN -> [DMESG-WARN][95] ([i915#180])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-apl2/igt@[email protected]

* igt@kms_hdr@static-toggle:
- shard-iclb: NOTRUN -> [SKIP][96] ([i915#1187])
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-iclb3/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][97] ([i915#1187])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-tglb1/igt@[email protected]

* igt@kms_pipe_crc_basic@hang-read-crc-pipe-d:
- shard-kbl: NOTRUN -> [SKIP][98] ([fdo#109271] / [i915#533])
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-kbl7/igt@[email protected]

* igt@kms_pipe_crc_basic@read-crc-pipe-d-frame-sequence:
- shard-apl: NOTRUN -> [SKIP][99] ([fdo#109271] / [i915#533]) +1 similar issue
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-apl2/igt@[email protected]

* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
- shard-tglb: [PASS][100] -> [FAIL][101] ([i915#533])
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10038/shard-tglb3/igt@[email protected]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-tglb1/igt@[email protected]
- shard-glk: [PASS][102] -> [FAIL][103] ([i915#533])
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10038/shard-glk1/igt@[email protected]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-glk2/igt@[email protected]
- shard-apl: [PASS][104] -> [FAIL][105] ([i915#533])
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10038/shard-apl7/igt@[email protected]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-apl1/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb:
- shard-kbl: NOTRUN -> [FAIL][106] ([i915#265])
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-kbl6/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max:
- shard-apl: NOTRUN -> [FAIL][107] ([fdo#108145] / [i915#265]) +5 similar issues
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-apl2/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-alpha-basic:
- shard-kbl: NOTRUN -> [FAIL][108] ([fdo#108145] / [i915#265])
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-kbl2/igt@[email protected]
- shard-glk: NOTRUN -> [FAIL][109] ([fdo#108145] / [i915#265])
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-glk4/igt@[email protected]

* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2:
- shard-apl: NOTRUN -> [SKIP][110] ([fdo#109271] / [i915#658]) +6 similar issues
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-apl3/igt@[email protected]

* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-3:
- shard-kbl: NOTRUN -> [SKIP][111] ([fdo#109271] / [i915#658]) +4 similar issues
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-kbl7/igt@[email protected]

* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1:
- shard-iclb: NOTRUN -> [SKIP][112] ([i915#658])
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-iclb1/igt@[email protected]
- shard-glk: NOTRUN -> [SKIP][113] ([fdo#109271] / [i915#658]) +2 similar issues
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-glk6/igt@[email protected]

* igt@kms_psr2_su@page_flip:
- shard-tglb: NOTRUN -> [SKIP][114] ([i915#1911])
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-tglb8/igt@kms_psr2_su@page_flip.html
- shard-iclb: NOTRUN -> [SKIP][115] ([fdo#109642] / [fdo#111068] / [i915#658])
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-iclb7/igt@kms_psr2_su@page_flip.html

* igt@kms_psr@psr2_cursor_blt:
- shard-iclb: [PASS][116] -> [SKIP][117] ([fdo#109441]) +1 similar issue
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10038/shard-iclb2/igt@kms_psr@psr2_cursor_blt.html
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-iclb8/igt@kms_psr@psr2_cursor_blt.html

* igt@kms_psr@psr2_sprite_render:
- shard-tglb: NOTRUN -> [FAIL][118] ([i915#132]) +1 similar issue
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-tglb6/igt@kms_psr@psr2_sprite_render.html

* igt@kms_tv_load_detect@load-detect:
- shard-tglb: NOTRUN -> [SKIP][119] ([fdo#109309])
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-tglb8/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][120] ([fdo#109309])
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-iclb7/igt@[email protected]

* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-kbl: [PASS][121] -> [DMESG-WARN][122] ([i915#180] / [i915#295])
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10038/shard-kbl6/igt@[email protected]
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-kbl7/igt@[email protected]

* igt@kms_vrr@flip-suspend:
- shard-iclb: NOTRUN -> [SKIP][123] ([fdo#109502])
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-iclb2/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][124] ([fdo#109502])
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-tglb7/igt@[email protected]

* igt@kms_writeback@writeback-fb-id:
- shard-kbl: NOTRUN -> [SKIP][125] ([fdo#109271] / [i915#2437])
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-kbl2/igt@[email protected]

* igt@kms_writeback@writeback-invalid-parameters:
- shard-apl: NOTRUN -> [SKIP][126] ([fdo#109271] / [i915#2437])
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-apl7/igt@[email protected]

* igt@nouveau_crc@pipe-a-source-rg:
- shard-iclb: NOTRUN -> [SKIP][127] ([i915#2530])
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-iclb4/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][128] ([i915#2530]) +1 similar issue
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-tglb6/igt@[email protected]

* igt@nouveau_crc@pipe-d-source-outp-complete:
- shard-iclb: NOTRUN -> [SKIP][129] ([fdo#109278] / [i915#2530])
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-iclb3/igt@[email protected]

* igt@prime_nv_api@nv_self_import:
- shard-iclb: NOTRUN -> [SKIP][130] ([fdo#109291]) +1 similar issue
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-iclb8/igt@prime_nv_api@nv_self_import.html

* igt@prime_nv_pcopy@test1_macro:
- shard-tglb: NOTRUN -> [SKIP][131] ([fdo#109291]) +1 similar issue
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-tglb8/igt@prime_nv_pcopy@test1_macro.html

* igt@prime_nv_pcopy@test2:
- shard-kbl: NOTRUN -> [SKIP][132] ([fdo#109271]) +144 similar issues
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-kbl4/igt@[email protected]

* igt@sysfs_clients@create:
- shard-glk: NOTRUN -> [SKIP][133] ([fdo#109271] / [i915#2994])
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-glk9/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][134] ([i915#2994])
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-tglb5/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][135] ([i915#2994])
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-iclb2/igt@[email protected]

* igt@sysfs_clients@fair-7:
- shard-apl: NOTRUN -> [SKIP][136] ([fdo#109271] / [i915#2994]) +3 similar issues
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-apl1/igt@[email protected]

* igt@sysfs_clients@split-25:
- shard-kbl: NOTRUN -> [SKIP][137] ([fdo#109271] / [i915#2994]) +1 similar issue
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/shard-kbl7/igt@[email protected]

* igt@sysfs_heartbeat_interval@mixed@vcs1:
- shard-kbl:

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5775/index.html

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev