Skip to contentSkip to conversation

arm: dts: imx8mp: Generate single bootable binary

PATCH Superseded Teresa Remmet 3 participants 4 messages Aug 25, 2021 – Aug 26, 2021

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm: dts: imx8mp: Generate single bootable binary

binman conversion made flashing flash.bin
and u-boot.itb necessary. Update binman config
to create a single flash.bin image again.

This updates imx8mp_evk and phyCORE-i.MX8MP as they share the same binman config.

Updated also imx8mp_evk documentation.

Tested on phyCORE-i.MX8MP.

---
 arch/arm/dts/imx8mp-u-boot.dtsi                 | 17 ++++++++++++++++-
 .../imx8mp_evk/imximage-8mp-lpddr4.cfg          |  2 +-
 board/phytec/phycore_imx8mp/imximage-8mp-sd.cfg |  2 +-
 doc/board/nxp/imx8mp_evk.rst                    |  1 -
 4 files changed, 18 insertions(+), 4 deletions(-)
arch/arm/dts/imx8mp-u-boot.dtsi +16 -1
index a6ede2ed6e30..ace7b2051e7f 100644
@@ -82,7 +82,7 @@
 		};
 	};
 
-	flash {
+	spl {
 		mkimage {
 			args = "-n spl/u-boot-spl.cfgout -T imx8mimage -e 0x920000";
 
@@ -149,4 +149,19 @@
 			};
 		};
 	};
+
+	imx-boot {
+		filename = "flash.bin";
+		pad-byte = <0x00>;
+
+		spl: blob-ext@1 {
+			filename = "spl.bin";
+			offset = <0x0>;
+		};
+
+		uboot: blob-ext@2 {
+			filename = "u-boot.itb";
+			offset = <0x58000>;
+		};
+	};
 };
board/freescale/imx8mp_evk/imximage-8mp-lpddr4.cfg +1 -1
index b2920b4908ed..2be18de674ba 100644
@@ -7,4 +7,4 @@
 
 ROM_VERSION	v2
 BOOT_FROM	sd
-LOADER		mkimage.flash.mkimage	0x920000
+LOADER		mkimage.spl.mkimage	0x920000
board/phytec/phycore_imx8mp/imximage-8mp-sd.cfg +1 -1
index b2920b4908ed..2be18de674ba 100644
@@ -7,4 +7,4 @@
 
 ROM_VERSION	v2
 BOOT_FROM	sd
-LOADER		mkimage.flash.mkimage	0x920000
+LOADER		mkimage.spl.mkimage	0x920000
doc/board/nxp/imx8mp_evk.rst +0 -1
index 609a29f3ebc3..b996ae055e69 100644
@@ -52,7 +52,6 @@ Burn the flash.bin to the MicroSD card at offset 32KB:
 .. code-block:: bash
 
    $sudo dd if=build/flash.bin of=/dev/sd[x] bs=1K seek=32 conv=notrunc; sync
-   $sudo dd if=build/u-boot.itb of=/dev/sd[x] bs=1K seek=384 conv=notrunc; sync
 
 Boot
 ----
Signature · 1 line
2.25.1
reviewer Reviewed-by on v1 1/1
#1 lore raw

Hi Teresa,

Quoted 11 lines · Teresa Remmet

binman conversion made flashing flash.bin
and u-boot.itb necessary. Update binman config
to create a single flash.bin image again.

This updates imx8mp_evk and phyCORE-i.MX8MP as they share the same binman config.

Updated also imx8mp_evk documentation.

Tested on phyCORE-i.MX8MP.

Thanks for taking care of this.

Quoted 13 lines
---
 arch/arm/dts/imx8mp-u-boot.dtsi                 | 17 ++++++++++++++++-
 .../imx8mp_evk/imximage-8mp-lpddr4.cfg          |  2 +-
 board/phytec/phycore_imx8mp/imximage-8mp-sd.cfg |  2 +-
 doc/board/nxp/imx8mp_evk.rst                    |  1 -
 4 files changed, 18 insertions(+), 4 deletions(-)
arch/arm/dts/imx8mp-u-boot.dtsi +0 -0
index a6ede2ed6e30..ace7b2051e7f 100644

arch/arm/dts/imx8mp-u-boot.dtsi line 85

Quoted 5 lines
arch/arm/dts/imx8mp-u-boot.dtsi +1 -1
@@ -82,7 +82,7 @@
                };
        };
 
-       flash {
+       spl {

To make this more standard, could you please also pass 'filename = "spl.bin" here too?

Please check:
https://lists.denx.de/pipermail/u-boot/2021-August/458754.html

arch/arm/dts/imx8mp-u-boot.dtsi line 87

Quoted 3 lines
arch/arm/dts/imx8mp-u-boot.dtsi +1 -1
 BOOT_FROM      sd
-LOADER         mkimage.flash.mkimage   0x920000
+LOADER         mkimage.spl.mkimage     0x920000

Please use "LOADER u-boot-spl-ddr.bin 0x920000" here instead.

board/phytec/phycore_imx8mp/imximage-8mp-sd.cfg line 10

Quoted 10 lines
board/phytec/phycore_imx8mp/imximage-8mp-sd.cfg +1 -1
index b2920b4908ed..2be18de674ba 100644
@@ -7,4 +7,4 @@
 
 ROM_VERSION    v2
 BOOT_FROM      sd
-LOADER         mkimage.flash.mkimage   0x920000
+LOADER         mkimage.spl.mkimage     0x920000

Ditto.

With these changes, you can add:

Thanks

#2 lore raw

Am Mittwoch, den 25.08.2021, 12:56 -0300 schrieb Fabio Estevam:

Quoted 35 lines

Hi Teresa,

Quoted 10 lines · Teresa Remmet

binman conversion made flashing flash.bin
and u-boot.itb necessary. Update binman config
to create a single flash.bin image again.

This updates imx8mp_evk and phyCORE-i.MX8MP as they share the same binman config.

Updated also imx8mp_evk documentation.

Tested on phyCORE-i.MX8MP.

Thanks for taking care of this.

Quoted 18 lines
---
 arch/arm/dts/imx8mp-u-boot.dtsi                 | 17
++++++++++++++++-
 .../imx8mp_evk/imximage-8mp-lpddr4.cfg          |  2 +-
 board/phytec/phycore_imx8mp/imximage-8mp-sd.cfg |  2 +-
 doc/board/nxp/imx8mp_evk.rst                    |  1 -
 4 files changed, 18 insertions(+), 4 deletions(-)
arch/arm/dts/imx8mp- renamed from arch/arm/dts/imx8mp-u-boot.dtsi +0 -0

u-boot.dtsi
index a6ede2ed6e30..ace7b2051e7f 100644

arch/arm/dts/imx8mp-u-boot.dtsi +0 -0
@@ -82,7 +82,7 @@
                };
        };
 
Quoted 8 lines

arch/arm/dts/imx8mp-u-boot.dtsi line 85

Quoted 2 lines
arch/arm/dts/imx8mp-u-boot.dtsi +1 -1
-       flash {
+       spl {

To make this more standard, could you please also pass 'filename = "spl.bin" here too?

Please check:
https://lists.denx.de/pipermail/u-boot/2021-August/458754.html

Oh, I missed the latest version of your patch. I will update this accordingly. Thanks.

Teresa

Quoted 26 lines

arch/arm/dts/imx8mp-u-boot.dtsi line 87

Quoted 4 lines
arch/arm/dts/imx8mp-u-boot.dtsi +1 -1
 BOOT_FROM      sd
-LOADER         mkimage.flash.mkimage   0x920000
+LOADER         mkimage.spl.mkimage     0x920000

Please use "LOADER u-boot-spl-ddr.bin 0x920000" here instead.

board/phytec/phycore_imx8mp/imximage-8mp-sd.cfg line 10

Quoted 11 lines
board/phytec/phycore_imx8mp/imximage-8mp-sd.cfg +1 -1
index b2920b4908ed..2be18de674ba 100644
@@ -7,4 +7,4 @@
 
 ROM_VERSION    v2
 BOOT_FROM      sd
-LOADER         mkimage.flash.mkimage   0x920000
+LOADER         mkimage.spl.mkimage     0x920000

Ditto.

With these changes, you can add:

Thanks

Reviewed-by on v1 1/1
#3 lore raw
In reply to Teresa Remmet

Hello Teresa,

Quoted 11 lines · Teresa Remmet

binman conversion made flashing flash.bin
and u-boot.itb necessary. Update binman config
to create a single flash.bin image again.

This updates imx8mp_evk and phyCORE-i.MX8MP as they share the same binman config.

Updated also imx8mp_evk documentation.

Tested on phyCORE-i.MX8MP.

Quoted 7 lines
---
 arch/arm/dts/imx8mp-u-boot.dtsi                 | 17 ++++++++++++++++-
 .../imx8mp_evk/imximage-8mp-lpddr4.cfg          |  2 +-
 board/phytec/phycore_imx8mp/imximage-8mp-sd.cfg |  2 +-
 doc/board/nxp/imx8mp_evk.rst                    |  1 -
 4 files changed, 18 insertions(+), 4 deletions(-)

No more comments beside Fabios, so

bye,
Heiko

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: [email protected]