drivers: spi-nor: Add JEDEC id for W25Q16JV
PATCH v3 1/1 drivers: spi-nor: Add JEDEC id for W25Q16JV
Add a JEDEC id for the Winbond W25Q16JV 16M-BIT serial flash memory with DUAL/QUAD SPI
Changes since v2:
Chagned the name to follow "DTR" parts
Changes since v1:
Updated the name for more suffixes
--- drivers/mtd/spi/spi-nor-ids.c | 5 +++++ 1 file changed, 5 insertions(+)
drivers/mtd/spi/spi-nor-ids.c +5 -0
@@ -314,6 +314,11 @@ const struct flash_info spi_nor_ids[] = {SECT_4K |SPI_NOR_DUAL_READ |SPI_NOR_QUAD_READ | SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) }, + { +INFO ("w25q16jvm" ,0xef7015 ,0 ,64 *1024 ,32 , +SECT_4K |SPI_NOR_DUAL_READ |SPI_NOR_QUAD_READ | +SPI_NOR_HAS_LOCK |SPI_NOR_HAS_TB ) + }, { INFO("w25q32jv", 0xef7016, 0, 64 * 1024, 64, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
Signature · 1 line
2.25.1
Quoted 22 lines · Angus Ainslie
Add a JEDEC id for the Winbond W25Q16JV 16M-BIT serial flash memory with DUAL/QUAD SPI
Changes since v2:
Chagned the name to follow "DTR" parts
Changes since v1:
Updated the name for more suffixes
Signed-off-by Angus Ainslie <[email protected]>--- drivers/mtd/spi/spi-nor-ids.c | 5 +++++ 1 file changed, 5 insertions(+)drivers/mtd/spi/spi-nor-ids.c +0
-0
drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 318
Quoted 5 lines
drivers/mtd/spi/spi-nor-ids.c +2
-0@@ -314,6 +314,11 @@ const struct flash_info spi_nor_ids[] = {SECT_4K |SPI_NOR_DUAL_READ |SPI_NOR_QUAD_READ | SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) }, + { + INFO("w25q16jvm", 0xef7015, 0, 64 * 1024, 32,
Can this name as "w25q16jv-im/jm" ?
Jagan.
Quoted 4 lines
drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 318
Quoted 2 lines
drivers/mtd/spi/spi-nor-ids.c +2
-0+ { + INFO("w25q16jvm", 0xef7015, 0, 64 * 1024, 32,Can this name as "w25q16jv-im/jm" ?
FWIW, "w25q15jvm" would be the "correct" name in linux. Although for this particular flash the name in linux is "w25q16jv-im/jm"..
Anyhow, see [1] for a lengthy discussion on that name. That being said, I still don't share Tudors opinion on using that made up name, just because no one will find any flash if one searches for w25q16jvm in the internet.
-michael
Quoted 9 lines · Michael Walle
EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
Quoted 4 lines
drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 318
Quoted 2 lines
drivers/mtd/spi/spi-nor-ids.c +2
-0+ { + INFO("w25q16jvm", 0xef7015, 0, 64 * 1024, 32,Can this name as "w25q16jv-im/jm" ?
FWIW, "w25q15jvm" would be the "correct" name in linux. Although for this particular flash the name in linux is "w25q16jv-im/jm"..
would you fix it? :D
Quoted 4 lines
Anyhow, see [1] for a lengthy discussion on that name. That being said, I still don't share Tudors opinion on using that made up name, just because no one will find any flash if one searches for w25q16jvm in the internet.
The temperature range "I/J" is skipped in the name because it does not have any influence on the jedec-id. That's why we don't include the "Package Type" field in the naming convention as well.
Quoted 5 lines
-michael
Quoted 15 lines · On Thu, Jan 20, 2022 at 7:53 PM <[email protected]> wrote:
Quoted 9 lines · Michael Walle
EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
Quoted 4 lines
drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 318
Quoted 2 lines
drivers/mtd/spi/spi-nor-ids.c +2
-0+ { + INFO("w25q16jvm", 0xef7015, 0, 64 * 1024, 32,Can this name as "w25q16jv-im/jm" ?
FWIW, "w25q15jvm" would be the "correct" name in linux. Although for this particular flash the name in linux is "w25q16jv-im/jm"..
would you fix it? :D
Quoted 1 line
Quoted 7 lines
Quoted 3 lines
Anyhow, see [1] for a lengthy discussion on that name. That being said, I still don't share Tudors opinion on using that made up name, just because no one will find any flash if one searches for w25q16jvm in the internet.
The temperature range "I/J" is skipped in the name because it does not have any influence on the jedec-id. That's why we don't include the "Package Type" field in the naming convention as well.
Okay, I'm merging v3. let me know if you have any questions?
Thanks,
Jagan.
Quoted 22 lines · Jagan Teki
EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
Quoted 19 lines · On Thu, Jan 20, 2022 at 7:53 PM <[email protected]> wrote:
Quoted 9 lines · Michael Walle
EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
Quoted 4 lines
drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 318
Quoted 2 lines
drivers/mtd/spi/spi-nor-ids.c +2
-0+ { + INFO("w25q16jvm", 0xef7015, 0, 64 * 1024, 32,Can this name as "w25q16jv-im/jm" ?
FWIW, "w25q15jvm" would be the "correct" name in linux. Although for this particular flash the name in linux is "w25q16jv-im/jm"..
would you fix it? :D
Quoted 4 lines
Anyhow, see [1] for a lengthy discussion on that name. That being said, I still don't share Tudors opinion on using that made up name, just because no one will find any flash if one searches for w25q16jvm in the internet.
Quoted 6 lines
Quoted 3 lines
The temperature range "I/J" is skipped in the name because it does not have any influence on the jedec-id. That's why we don't include the "Package Type" field in the naming convention as well.
Okay, I'm merging v3. let me know if you have any questions?
For now it should be fine. But if anyone is feeling brave enough maybe we should fix the naming scheme for winbond once and for all. It seems that the flashes were we append "m" support DTR, and in fact winbond names them blabla-dtr [1]. So instead of "w25q16jvm" maybe it's better to convert to "w25q16jv-dtr". Are there any volunteers to check if my assumption is correct?
Quoted 17 lines · On 1/20/2022 7:46 AM, [email protected] wrote:
Quoted 10 lines
Quoted 10 lines
Quoted 2 lines
FWIW, "w25q15jvm" would be the "correct" name in linux. Although for this particular flash the name in linux is "w25q16jv-im/jm"..
would you fix it? :D
Quoted 4 lines
Anyhow, see [1] for a lengthy discussion on that name. That being said, I still don't share Tudors opinion on using that made up name, just because no one will find any flash if one searches for w25q16jvm in the internet.
Quoted 6 lines
Quoted 3 lines
The temperature range "I/J" is skipped in the name because it does not have any influence on the jedec-id. That's why we don't include the "Package Type" field in the naming convention as well.
Okay, I'm merging v3. let me know if you have any questions?
Quoted 7 lines
For now it should be fine. But if anyone is feeling brave enough maybe we should fix the naming scheme for winbond once and for all. It seems that the flashes were we append "m" support DTR, and in fact winbond names them blabla-dtr [1]. So instead of "w25q16jvm" maybe it's better to convert to "w25q16jv-dtr". Are there any volunteers to check if my assumption is correct?
I would be happy to do it if there's consensus that we can break downstream device-tree users that hold older compatible string :-).
I thought of w25q512jv-dtr for my patch [1] but saw "m" suffix used for other dtr parts.
On related note, that array can be sorted by Device ID.
[1] https://lore.kernel.org/u-boot/[email protected]/
Dhananjay
Quoted 26 lines · Dhananjay Phadke
EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
Quoted 23 lines · On 1/20/2022 7:46 AM, [email protected] wrote:
Quoted 10 lines
Quoted 10 lines
Quoted 2 lines
FWIW, "w25q15jvm" would be the "correct" name in linux. Although for this particular flash the name in linux is "w25q16jv-im/jm"..
would you fix it? :D
Quoted 4 lines
Anyhow, see [1] for a lengthy discussion on that name. That being said, I still don't share Tudors opinion on using that made up name, just because no one will find any flash if one searches for w25q16jvm in the internet.
Quoted 6 lines
Quoted 3 lines
The temperature range "I/J" is skipped in the name because it does not have any influence on the jedec-id. That's why we don't include the "Package Type" field in the naming convention as well.
Okay, I'm merging v3. let me know if you have any questions?
For now it should be fine. But if anyone is feeling brave enough maybe we should fix the naming scheme for winbond once and for all. It seems that the flashes were we append "m" support DTR, and in fact winbond names them blabla-dtr [1]. So instead of "w25q16jvm" maybe it's better to convert to "w25q16jv-dtr". Are there any volunteers to check if my assumption is correct?
Quoted 4 lines
Quoted 1 line
I would be happy to do it if there's consensus that we can break downstream device-tree users that hold older compatible string :-).
aren't these flashes using the generic jedec,spi-nor compatible?
Quoted 5 lines
I thought of w25q512jv-dtr for my patch [1] but saw "m" suffix used for other dtr parts.
On related note, that array can be sorted by Device ID.
better to order them alphabetically, not by jedec ID.
Quoted 6 lines
[1]
https://lore.kernel.org/u-boot/[email protected]/Dhananjay
Quoted 3 lines · On 1/21/22 6:34 AM, [email protected] wrote:
Quoted 1 line
On related note, that array can be sorted by Device ID.
better to order them alphabetically, not by jedec ID.
alphabetically by name I meant, it's easier for humans to identify a flash.
Quoted 20 lines · Jagan Teki
Quoted 19 lines · On Thu, Jan 20, 2022 at 7:53 PM <[email protected]> wrote:
Quoted 9 lines · Michael Walle
EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
Quoted 4 lines
drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 318
Quoted 2 lines
drivers/mtd/spi/spi-nor-ids.c +2
-0+ { + INFO("w25q16jvm", 0xef7015, 0, 64 * 1024, 32,Can this name as "w25q16jv-im/jm" ?
FWIW, "w25q15jvm" would be the "correct" name in linux. Although for this particular flash the name in linux is "w25q16jv-im/jm"..
would you fix it? :D
Quoted 4 lines
Anyhow, see [1] for a lengthy discussion on that name. That being said, I still don't share Tudors opinion on using that made up name, just because no one will find any flash if one searches for w25q16jvm in the internet.
Quoted 6 lines
Quoted 3 lines
The temperature range "I/J" is skipped in the name because it does not have any influence on the jedec-id. That's why we don't include the "Package Type" field in the naming convention as well.
Okay, I'm merging v3. let me know if you have any questions?
Thanks !
Quoted 2 lines
Thanks,
Jagan.
Hi Jagan,
[snip]
Quoted 3 lines · Jagan Teki
Okay, I'm merging v3. let me know if you have any questions?
I didn't see this go in yet. Should it be in u-boot master ?
Thanks
Angus
Quoted 2 lines
Thanks,
Jagan.
Hi Jagan,
Quoted 18 lines · Jagan Teki
Quoted 17 lines · Angus Ainslie
Add a JEDEC id for the Winbond W25Q16JV 16M-BIT serial flash memory with DUAL/QUAD SPI
Changes since v2:
Chagned the name to follow "DTR" parts
Changes since v1:
Updated the name for more suffixes
Signed-off-by Angus Ainslie <[email protected]>--- drivers/mtd/spi/spi-nor-ids.c | 5 +++++ 1 file changed, 5 insertions(+)
Quoted 14 lines
drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 318
Quoted 11 lines
drivers/mtd/spi/spi-nor-ids.c +0
-0@@ -314,6 +314,11 @@ const struct flash_info spi_nor_ids[] = { SECT_4K | SPI_NOR_DUAL_READ |
SPI_NOR_QUAD_READ|
SPI_NOR_HAS_LOCK|SPI_NOR_HAS_TB)
},drivers/mtd/spi/spi-nor-ids.c +2
-0+ { + INFO("w25q16jvm", 0xef7015, 0, 64 * 1024, 32,Can this name as "w25q16jv-im/jm" ?
I sent a v2 with that name and there was one comment to change it to this name.
If you prefer please use v2 instead.
https://lists.denx.de/pipermail/u-boot/2022-January/471874.html
Thanks
Angus
Quoted 1 line
Jagan.