Skip to contentSkip to conversation

drivers: spi-nor: Add JEDEC id for W25Q16JV

PATCH Superseded Angus Ainslie 2 participants 4 messages Jan 13, 2022 – Jan 15, 2022 Memory technology devices (MTD)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 drivers: spi-nor: Add JEDEC id for W25Q16JV

Add a JEDEC id for the Winbond W25Q16JV 16M-BIT serial flash memory with DUAL/QUAD SPI

Changes since v1:

Updated the name for more suffixes

---
 drivers/mtd/spi/spi-nor-ids.c | 5 +++++
 1 file changed, 5 insertions(+)
drivers/mtd/spi/spi-nor-ids.c +5 -0
index b551ebd75e..3bd0ded443 100644
@@ -314,6 +314,11 @@ const struct flash_info spi_nor_ids[] = {
 			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
 			SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
 	},
+	{
+		INFO("w25q16jv-im/jm", 0xef7015, 0, 64 * 1024,  32,
+			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
+			SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
+	},
 	{
 		INFO("w25q32jv", 0xef7016, 0, 64 * 1024,  64,
 			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
Signature · 1 line
2.25.1
#1 lore raw
Quoted 17 lines · Angus Ainslie

Add a JEDEC id for the Winbond W25Q16JV 16M-BIT serial flash memory with DUAL/QUAD SPI

Changes since v1:

Updated the name for more suffixes

---
  drivers/mtd/spi/spi-nor-ids.c | 5 +++++
  1 file changed, 5 insertions(+)
drivers/mtd/spi/spi-nor-ids.c +0 -0
index b551ebd75e..3bd0ded443 100644

drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 321

Quoted 8 lines
drivers/mtd/spi/spi-nor-ids.c +5 -0
@@ -314,6 +314,11 @@ const struct flash_info spi_nor_ids[] = {
  			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
  			SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
  	},
+	{
+		INFO("w25q16jv-im/jm", 0xef7015, 0, 64 * 1024,  32,
+			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
+			SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
+	},

Shouldn't this be w25q16jvm, which seems to be unofficial convention for *-DTR parts? I was looking for naming convention for another Winbond part -

https://lore.kernel.org/u-boot/[email protected]/

Quoted 3 lines
drivers/mtd/spi/spi-nor-ids.c +0 -0
  	{
  		INFO("w25q32jv", 0xef7016, 0, 64 * 1024,  64,
  			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
#2 lore raw

Hi Dhananjay , Jagan,

Quoted 30 lines · Dhananjay Phadke
Quoted 17 lines · Angus Ainslie

Add a JEDEC id for the Winbond W25Q16JV 16M-BIT serial flash memory with DUAL/QUAD SPI

Changes since v1:

Updated the name for more suffixes

---
  drivers/mtd/spi/spi-nor-ids.c | 5 +++++
  1 file changed, 5 insertions(+)
drivers/mtd/spi/spi-nor-ids.c +0 -0
index b551ebd75e..3bd0ded443 100644

drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 321

Quoted 8 lines
drivers/mtd/spi/spi-nor-ids.c +5 -0
@@ -314,6 +314,11 @@ const struct flash_info spi_nor_ids[] = {
  			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
  			SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
  	},
+	{
+		INFO("w25q16jv-im/jm", 0xef7015, 0, 64 * 1024,  32,
+			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
+			SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
+	},

Shouldn't this be w25q16jvm, which seems to be unofficial convention for *-DTR parts? I was looking for naming convention for another Winbond part -

Quoted 2 lines

https://lore.kernel.org/u-boot/[email protected]/

Would you like a v3 using this naming convention ?

Thanks
Angus

Quoted 3 lines
Quoted 3 lines
drivers/mtd/spi/spi-nor-ids.c +0 -0
  	{
  		INFO("w25q32jv", 0xef7016, 0, 64 * 1024,  64,
  			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
#3 lore raw
Quoted 8 lines · Angus Ainslie
Quoted 8 lines
Quoted 7 lines

      },
+    {
+        INFO("w25q16jv-im/jm", 0xef7015, 0, 64 * 1024,  32, +            SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | +            SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
+    },

Quoted 8 lines
Quoted 6 lines

Shouldn't this be w25q16jvm, which seems to be unofficial convention for *-DTR parts? I was looking for naming convention for another Winbond part -

https://lore.kernel.org/u-boot/[email protected]/

Would you like a v3 using this naming convention ?

Sure, let's try to follow this convention, I'm also doing same in my v2 patch.

Regards,
Dhananjay