Skip to contentSkip to conversation

configs/friendlyarm_nanopi_r2s: new defconfig

PATCH Superseded Gilles Talis 2 participants 3 messages Jan 15, 2022 – Jan 30, 2022

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 configs/friendlyarm_nanopi_r2s: new defconfig

The NanoPi R2S is a FriendlyElec mini-router based on:

- Rockchip RK3328 SoC
- 1GB (or 2GB) DDR4 RAM
- Gigabit Ethernet (WAN)
- Gigabit Ethernet (USB3) (LAN)
- USB 2.0 Host Port
- MicroSD slot
- Reset button
- WAN - LAN - SYS LED

https://www.friendlyarm.com/index.php?route=product/product&path=69&product_id=282

---
 DEVELOPERS                                 |  2 +
 board/friendlyarm/nanopi-r2s/extlinux.conf |  4 ++
 board/friendlyarm/nanopi-r2s/genimage.cfg  | 22 +++++++++
 board/friendlyarm/nanopi-r2s/post-build.sh |  5 ++
 board/friendlyarm/nanopi-r2s/readme.txt    | 57 ++++++++++++++++++++++
 configs/friendlyarm_nanopi_r2s_defconfig   | 34 +++++++++++++
 6 files changed, 124 insertions(+)
 create mode 100644 board/friendlyarm/nanopi-r2s/extlinux.conf
 create mode 100644 board/friendlyarm/nanopi-r2s/genimage.cfg
 create mode 100755 board/friendlyarm/nanopi-r2s/post-build.sh
 create mode 100644 board/friendlyarm/nanopi-r2s/readme.txt
 create mode 100644 configs/friendlyarm_nanopi_r2s_defconfig
DEVELOPERS +2 -0
index a91e2dfcde..ca52c0cff2 100644
@@ -1073,7 +1073,9 @@ F:	configs/qemu_*
 
 N:	Gilles Talis <[email protected]>
 F:	board/freescale/imx8mmevk/
+F:	board/friendlyarm/nanopi-r2s/
 F:	configs/freescale_imx8mmevk_defconfig
+F:	configs/friendlyarm_nanopi_r2s_defconfig
 F:	package/cctz/
 F:	package/faad2/
 F:	package/fdk-aac/
board/friendlyarm/nanopi-r2s/extlinux.conf new file +4 -0
new file mode 100644
index 0000000000..1ea0cdd8a5
@@ -0,0 +1,4 @@
+label NanoPi R2S linux
+  kernel /boot/Image
+  devicetree /boot/rk3328-nanopi-r2s.dtb
+  append root=/dev/mmcblk0p1 rw rootwait
board/friendlyarm/nanopi-r2s/genimage.cfg new file +22 -0
new file mode 100644
index 0000000000..a686b4f14e
@@ -0,0 +1,22 @@
+image sdcard.img {
+	hdimage {
+	}
+
+	partition u-boot-tpl-spl-dtb {
+		in-partition-table = "no"
+		image = "idbloader.img"
+		offset = 32K
+	}
+
+	partition u-boot-dtb {
+		in-partition-table = "no"
+		image = "u-boot.itb"
+		offset = 8M
+	}
+
+	partition rootfs {
+		partition-type = 0x83
+		offset = 16M
+		image = "rootfs.ext4"
+	}
+}
board/friendlyarm/nanopi-r2s/post-build.sh new file +5 -0
new file mode 100755
index 0000000000..1f5ff6a611
@@ -0,0 +1,5 @@
+#!/bin/sh
+
+BOARD_DIR="$(dirname $0)"
+
+install -m 0644 -D $BOARD_DIR/extlinux.conf $TARGET_DIR/boot/extlinux/extlinux.conf
board/friendlyarm/nanopi-r2s/readme.txt new file +57 -0

57 lines not on this page · raw message

configs/friendlyarm_nanopi_r2s_defconfig new file +34 -0
new file mode 100644
index 0000000000..a167a39898
@@ -0,0 +1,34 @@
+BR2_aarch64=y
+BR2_ARM_FPU_VFPV4=y
+BR2_TARGET_GENERIC_HOSTNAME="rk3328-nanopi-r2s"
+BR2_TARGET_GENERIC_ISSUE="Welcome to Nanopi R2S RK3328"
+BR2_ROOTFS_POST_BUILD_SCRIPT="board/friendlyarm/nanopi-r2s/post-build.sh"
+BR2_ROOTFS_POST_IMAGE_SCRIPT="support/scripts/genimage.sh"
+BR2_ROOTFS_POST_SCRIPT_ARGS="-c board/friendlyarm/nanopi-r2s/genimage.cfg"
+BR2_LINUX_KERNEL=y
+BR2_LINUX_KERNEL_USE_ARCH_DEFAULT_CONFIG=y
+BR2_LINUX_KERNEL_DTS_SUPPORT=y
+BR2_LINUX_KERNEL_INTREE_DTS_NAME="rockchip/rk3328-nanopi-r2s"
+BR2_LINUX_KERNEL_INSTALL_TARGET=y
+BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y
+BR2_TARGET_ROOTFS_EXT2=y
+BR2_TARGET_ROOTFS_EXT2_4=y
+BR2_TARGET_ROOTFS_EXT2_SIZE="120M"
+BR2_TARGET_ARM_TRUSTED_FIRMWARE=y
+BR2_TARGET_ARM_TRUSTED_FIRMWARE_PLATFORM="rk3328"
+BR2_TARGET_ARM_TRUSTED_FIRMWARE_IMAGES=""
+BR2_TARGET_ARM_TRUSTED_FIRMWARE_NEEDS_ARM32_TOOLCHAIN=y
+BR2_TARGET_UBOOT=y
+BR2_TARGET_UBOOT_BOARD_DEFCONFIG="nanopi-r2s-rk3328"
+BR2_TARGET_UBOOT_NEEDS_DTC=y
+BR2_TARGET_UBOOT_NEEDS_PYTHON3=y
+BR2_TARGET_UBOOT_NEEDS_ATF_BL31=y
+BR2_TARGET_UBOOT_NEEDS_ATF_BL31_ELF=y
+BR2_TARGET_UBOOT_FORMAT_CUSTOM=y
+BR2_TARGET_UBOOT_FORMAT_CUSTOM_NAME="u-boot.itb"
+BR2_TARGET_UBOOT_SPL=y
+BR2_TARGET_UBOOT_SPL_NAME="idbloader.img"
+BR2_PACKAGE_HOST_DOSFSTOOLS=y
+BR2_PACKAGE_HOST_GENIMAGE=y
+BR2_PACKAGE_HOST_MTOOLS=y
+BR2_PACKAGE_HOST_UBOOT_TOOLS=y
Signature · 6 lines
2.32.0

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

Hello Gilles,

Quoted 24 lines · On Sat, 15 Jan 2022 21:26:17 +0100 Gilles Talis <[email protected]> wrote:
configs/friendlyarm_nanopi_r2s_defconfig new file +24 -0
+BR2_aarch64=y
+BR2_ARM_FPU_VFPV4=y
+BR2_TARGET_GENERIC_HOSTNAME="rk3328-nanopi-r2s"
+BR2_TARGET_GENERIC_ISSUE="Welcome to Nanopi R2S RK3328"
+BR2_ROOTFS_POST_BUILD_SCRIPT="board/friendlyarm/nanopi-r2s/post-build.sh"
+BR2_ROOTFS_POST_IMAGE_SCRIPT="support/scripts/genimage.sh"
+BR2_ROOTFS_POST_SCRIPT_ARGS="-c board/friendlyarm/nanopi-r2s/genimage.cfg"
+BR2_LINUX_KERNEL=y
+BR2_LINUX_KERNEL_USE_ARCH_DEFAULT_CONFIG=y
+BR2_LINUX_KERNEL_DTS_SUPPORT=y
+BR2_LINUX_KERNEL_INTREE_DTS_NAME="rockchip/rk3328-nanopi-r2s"
+BR2_LINUX_KERNEL_INSTALL_TARGET=y
+BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y
+BR2_TARGET_ROOTFS_EXT2=y
+BR2_TARGET_ROOTFS_EXT2_4=y
+BR2_TARGET_ROOTFS_EXT2_SIZE="120M"
+BR2_TARGET_ARM_TRUSTED_FIRMWARE=y
+BR2_TARGET_ARM_TRUSTED_FIRMWARE_PLATFORM="rk3328"
+BR2_TARGET_ARM_TRUSTED_FIRMWARE_IMAGES=""
+BR2_TARGET_ARM_TRUSTED_FIRMWARE_NEEDS_ARM32_TOOLCHAIN=y
+BR2_TARGET_UBOOT=y
+BR2_TARGET_UBOOT_BOARD_DEFCONFIG="nanopi-r2s-rk3328"
+BR2_TARGET_UBOOT_NEEDS_DTC=y
+BR2_TARGET_UBOOT_NEEDS_PYTHON3=y

configs/friendlyarm_nanopi_r2s_defconfig line 34

Quoted 10 lines
configs/friendlyarm_nanopi_r2s_defconfig new file +10 -0
+BR2_TARGET_UBOOT_NEEDS_ATF_BL31=y
+BR2_TARGET_UBOOT_NEEDS_ATF_BL31_ELF=y
+BR2_TARGET_UBOOT_FORMAT_CUSTOM=y
+BR2_TARGET_UBOOT_FORMAT_CUSTOM_NAME="u-boot.itb"
+BR2_TARGET_UBOOT_SPL=y
+BR2_TARGET_UBOOT_SPL_NAME="idbloader.img"
+BR2_PACKAGE_HOST_DOSFSTOOLS=y
+BR2_PACKAGE_HOST_GENIMAGE=y
+BR2_PACKAGE_HOST_MTOOLS=y
+BR2_PACKAGE_HOST_UBOOT_TOOLS=y

Thanks for this v2. Unfortunately, there is one thing I did not notice when reviewing v1: you should use fixed versions of the Linux kernel, U-Boot and TF-A. Here your defconfig uses whatever is the latest, which is not the policy we have chosen for our defconfigs.

Could you fix that up by using fixed versions?

Thanks a lot!

Thomas

Signature · 7 lines
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#2 lore raw

Hi Thomas,

thanks for the review.

Quoted 46 lines · Thomas Petazzoni

Hello Gilles,

Quoted 24 lines · On Sat, 15 Jan 2022 21:26:17 +0100 Gilles Talis <[email protected]> wrote:
configs/friendlyarm_nanopi_r2s_defconfig new file +24 -0
+BR2_aarch64=y
+BR2_ARM_FPU_VFPV4=y
+BR2_TARGET_GENERIC_HOSTNAME="rk3328-nanopi-r2s"
+BR2_TARGET_GENERIC_ISSUE="Welcome to Nanopi R2S RK3328"
+BR2_ROOTFS_POST_BUILD_SCRIPT="board/friendlyarm/nanopi-r2s/post-build.sh"
+BR2_ROOTFS_POST_IMAGE_SCRIPT="support/scripts/genimage.sh"
+BR2_ROOTFS_POST_SCRIPT_ARGS="-c board/friendlyarm/nanopi-r2s/genimage.cfg"
+BR2_LINUX_KERNEL=y
+BR2_LINUX_KERNEL_USE_ARCH_DEFAULT_CONFIG=y
+BR2_LINUX_KERNEL_DTS_SUPPORT=y
+BR2_LINUX_KERNEL_INTREE_DTS_NAME="rockchip/rk3328-nanopi-r2s"
+BR2_LINUX_KERNEL_INSTALL_TARGET=y
+BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y
+BR2_TARGET_ROOTFS_EXT2=y
+BR2_TARGET_ROOTFS_EXT2_4=y
+BR2_TARGET_ROOTFS_EXT2_SIZE="120M"
+BR2_TARGET_ARM_TRUSTED_FIRMWARE=y
+BR2_TARGET_ARM_TRUSTED_FIRMWARE_PLATFORM="rk3328"
+BR2_TARGET_ARM_TRUSTED_FIRMWARE_IMAGES=""
+BR2_TARGET_ARM_TRUSTED_FIRMWARE_NEEDS_ARM32_TOOLCHAIN=y
+BR2_TARGET_UBOOT=y
+BR2_TARGET_UBOOT_BOARD_DEFCONFIG="nanopi-r2s-rk3328"
+BR2_TARGET_UBOOT_NEEDS_DTC=y
+BR2_TARGET_UBOOT_NEEDS_PYTHON3=y

configs/friendlyarm_nanopi_r2s_defconfig line 34

Quoted 10 lines
configs/friendlyarm_nanopi_r2s_defconfig new file +10 -0
+BR2_TARGET_UBOOT_NEEDS_ATF_BL31=y
+BR2_TARGET_UBOOT_NEEDS_ATF_BL31_ELF=y
+BR2_TARGET_UBOOT_FORMAT_CUSTOM=y
+BR2_TARGET_UBOOT_FORMAT_CUSTOM_NAME="u-boot.itb"
+BR2_TARGET_UBOOT_SPL=y
+BR2_TARGET_UBOOT_SPL_NAME="idbloader.img"
+BR2_PACKAGE_HOST_DOSFSTOOLS=y
+BR2_PACKAGE_HOST_GENIMAGE=y
+BR2_PACKAGE_HOST_MTOOLS=y
+BR2_PACKAGE_HOST_UBOOT_TOOLS=y

Thanks for this v2. Unfortunately, there is one thing I did not notice when reviewing v1: you should use fixed versions of the Linux kernel, U-Boot and TF-A. Here your defconfig uses whatever is the latest, which is not the policy we have chosen for our defconfigs.

Quoted 1 line

Could you fix that up by using fixed versions?

Yes. Will send a v3 shortly.

Quoted 8 lines

Thanks a lot!

Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin Embedded Linux and Kernel engineering and training
https://bootlin.com

Thanks!
Gilles.
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot