drivers/adc/rockchip-saradc: remove double semi-colon
PATCH 1/1 drivers/adc/rockchip-saradc: remove double semi-colon
--- drivers/adc/rockchip-saradc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/adc/rockchip-saradc.c +1 -1
@@ -131,7 +131,7 @@ int rockchip_saradc_of_to_plat(struct udevice *dev) } priv->data = data; - uc_pdata->data_mask = (1 << priv->data->num_bits) -1 ;; + uc_pdata->data_mask = (1 << priv->data->num_bits) -1 ; uc_pdata->data_format =ADC_DATA_FORMAT_BIN ; uc_pdata->data_timeout_us =SARADC_TIMEOUT /5 ; uc_pdata->channel_mask = (1 << priv->data->num_channels) -1 ;
Signature · 1 line
2.25.1
Hi Giulio,
Thanks for your patch, it's a good catching.
Could you please update the subject with "rockchip: adc: ", and
add a simple description in the commit message? Empy commit message is not allowed according to U-Boot patch commit rules :(
Thanks,
- Kever
Quoted 22 lines · Giulio Benetti <[email protected]> 于2022年2月4日周五 09:19写道:
Signed-off-by Giulio Benetti <[email protected]>--- drivers/adc/rockchip-saradc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/adc/rockchip-saradc.c +1
-2@@ -131,7 +131,7 @@ int rockchip_saradc_of_to_plat(struct udevice *dev) } priv->data = data; - uc_pdata->data_mask = (1 << priv->data->num_bits) -1 ;; + uc_pdata->data_mask = (1 << priv->data->num_bits) -1 ; uc_pdata->data_format =ADC_DATA_FORMAT_BIN ; uc_pdata->data_timeout_us =SARADC_TIMEOUT /5 ; uc_pdata->channel_mask = (1 << priv->data->num_channels) -1 ; --2.25.1
PATCH v2 1/1 rockchip: saradc: remove double semi-colon
Remove double semi-colon that has been forgotten while adding the driver. This is only a style fix since it doesn't change the functionality of the driver.
---V1->V2:
* Improved commit log as suggested by Kever Yang
--- drivers/adc/rockchip-saradc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/adc/rockchip-saradc.c +1 -1
@@ -131,7 +131,7 @@ int rockchip_saradc_of_to_plat(struct udevice *dev) } priv->data = data; - uc_pdata->data_mask = (1 << priv->data->num_bits) -1 ;; + uc_pdata->data_mask = (1 << priv->data->num_bits) -1 ; uc_pdata->data_format =ADC_DATA_FORMAT_BIN ; uc_pdata->data_timeout_us =SARADC_TIMEOUT /5 ; uc_pdata->channel_mask = (1 << priv->data->num_channels) -1 ;
Signature · 1 line
2.25.1
Re: [PATCH v2] rockchip: saradc: remove double semi-colon
Quoted 5 lines · Giulio Benetti
Remove double semi-colon that has been forgotten while adding the driver. This is only a style fix since it doesn't change the functionality of the driver.
Signed-off-by Giulio Benetti <[email protected]>
Thanks,
- Kever
Quoted 20 lines
---
V1->V2:
* Improved commit log as suggested by Kever Yang--- drivers/adc/rockchip-saradc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/adc/rockchip-saradc.c +1
-1@@ -131,7 +131,7 @@ int rockchip_saradc_of_to_plat(struct udevice *dev) } priv->data = data; - uc_pdata->data_mask = (1 << priv->data->num_bits) -1 ;; + uc_pdata->data_mask = (1 << priv->data->num_bits) -1 ; uc_pdata->data_format =ADC_DATA_FORMAT_BIN ; uc_pdata->data_timeout_us =SARADC_TIMEOUT /5 ; uc_pdata->channel_mask = (1 << priv->data->num_channels) -1 ;
Quoted 6 lines · Kever Yang
Hi Giulio,
Thanks for your patch, it's a good catching.
Could you please update the subject with "rockchip: adc: ", and
add a simple description in the commit message? Empy commit message is not allowed according to U-Boot patch commit rules :(
Oh, I've forgotten about this in u-boot. Just sent V2:
https://patchwork.ozlabs.org/project/uboot/patch/[email protected]/
and tagged V1 as superseded in patchwork.
Best regards
Signature · 2 lines
Giulio Benetti Benetti Engineering sas
Quoted 26 lines
Thanks,
- KeverQuoted 22 lines · Giulio Benetti <[email protected]> 于2022年2月4日周五 09:19写道:
Signed-off-by Giulio Benetti <[email protected]>--- drivers/adc/rockchip-saradc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/adc/rockchip-saradc.c +1
-2@@ -131,7 +131,7 @@ int rockchip_saradc_of_to_plat(struct udevice *dev) } priv->data = data; - uc_pdata->data_mask = (1 << priv->data->num_bits) -1 ;; + uc_pdata->data_mask = (1 << priv->data->num_bits) -1 ; uc_pdata->data_format =ADC_DATA_FORMAT_BIN ; uc_pdata->data_timeout_us =SARADC_TIMEOUT /5 ; uc_pdata->channel_mask = (1 << priv->data->num_channels) -1 ; --2.25.1