Skip to contentSkip to conversation

drivers/adc/rockchip-saradc: remove double semi-colon

PATCH Superseded Giulio Benetti 2 participants 5 messages Feb 4, 2022 – Mar 14, 2022 Arm Rockchip

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers/adc/rockchip-saradc: remove double semi-colon

---
 drivers/adc/rockchip-saradc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/adc/rockchip-saradc.c +1 -1
index e464d33f22..e0cbab6aa0 100644
@@ -131,7 +131,7 @@ int rockchip_saradc_of_to_plat(struct udevice *dev)
 	}
 
 	priv->data = data;
-	uc_pdata->data_mask = (1 << priv->data->num_bits) - 1;;
+	uc_pdata->data_mask = (1 << priv->data->num_bits) - 1;
 	uc_pdata->data_format = ADC_DATA_FORMAT_BIN;
 	uc_pdata->data_timeout_us = SARADC_TIMEOUT / 5;
 	uc_pdata->channel_mask = (1 << priv->data->num_channels) - 1;
Signature · 1 line
2.25.1
#1 lore raw

Hi Giulio,

Thanks for your patch, it's a good catching.
Could you please update the subject with "rockchip: adc: ", and
add a simple description in the commit message? Empy commit message is not allowed according to U-Boot patch commit rules :(

Thanks,
- Kever

Quoted 22 lines · Giulio Benetti <[email protected]> 于2022年2月4日周五 09:19写道:
---
 drivers/adc/rockchip-saradc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/adc/rockchip-saradc.c +1 -2
index e464d33f22..e0cbab6aa0 100644
@@ -131,7 +131,7 @@ int rockchip_saradc_of_to_plat(struct udevice *dev)
        }
 
        priv->data = data;
-       uc_pdata->data_mask = (1 << priv->data->num_bits) - 1;;
+       uc_pdata->data_mask = (1 << priv->data->num_bits) - 1;
        uc_pdata->data_format = ADC_DATA_FORMAT_BIN;
        uc_pdata->data_timeout_us = SARADC_TIMEOUT / 5;
        uc_pdata->channel_mask = (1 << priv->data->num_channels) - 1;
--

2.25.1

#2 lore raw

PATCH v2 1/1 rockchip: saradc: remove double semi-colon

Remove double semi-colon that has been forgotten while adding the driver. This is only a style fix since it doesn't change the functionality of the driver.

---
V1->V2:
* Improved commit log as suggested by Kever Yang

---
 drivers/adc/rockchip-saradc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/adc/rockchip-saradc.c +1 -1
index e464d33f22..e0cbab6aa0 100644
@@ -131,7 +131,7 @@ int rockchip_saradc_of_to_plat(struct udevice *dev)
 	}
 
 	priv->data = data;
-	uc_pdata->data_mask = (1 << priv->data->num_bits) - 1;;
+	uc_pdata->data_mask = (1 << priv->data->num_bits) - 1;
 	uc_pdata->data_format = ADC_DATA_FORMAT_BIN;
 	uc_pdata->data_timeout_us = SARADC_TIMEOUT / 5;
 	uc_pdata->channel_mask = (1 << priv->data->num_channels) - 1;
Signature · 1 line
2.25.1
Reviewed-by on v2 1/1
#3 lore raw

Re: [PATCH v2] rockchip: saradc: remove double semi-colon

Quoted 5 lines · Giulio Benetti

Remove double semi-colon that has been forgotten while adding the driver. This is only a style fix since it doesn't change the functionality of the driver.

Thanks,
- Kever

Quoted 20 lines

---
V1->V2:
* Improved commit log as suggested by Kever Yang

---
  drivers/adc/rockchip-saradc.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/adc/rockchip-saradc.c +1 -1
index e464d33f22..e0cbab6aa0 100644
@@ -131,7 +131,7 @@ int rockchip_saradc_of_to_plat(struct udevice *dev)
  	}
 
  	priv->data = data;
-	uc_pdata->data_mask = (1 << priv->data->num_bits) - 1;;
+	uc_pdata->data_mask = (1 << priv->data->num_bits) - 1;
  	uc_pdata->data_format = ADC_DATA_FORMAT_BIN;
  	uc_pdata->data_timeout_us = SARADC_TIMEOUT / 5;
  	uc_pdata->channel_mask = (1 << priv->data->num_channels) - 1;
#4 lore raw
In reply to Kever Yang
Quoted 6 lines · Kever Yang

Hi Giulio,

Thanks for your patch, it's a good catching.
Could you please update the subject with "rockchip: adc: ", and
add a simple description in the commit message? Empy commit message is not allowed according to U-Boot patch commit rules :(

Oh, I've forgotten about this in u-boot. Just sent V2:
https://patchwork.ozlabs.org/project/uboot/patch/[email protected]/

and tagged V1 as superseded in patchwork.

Best regards

Signature · 2 lines
Giulio Benetti
Benetti Engineering sas
Quoted 26 lines

Thanks,
- Kever

Quoted 22 lines · Giulio Benetti <[email protected]> 于2022年2月4日周五 09:19写道:
---
  drivers/adc/rockchip-saradc.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/adc/rockchip-saradc.c +1 -2
index e464d33f22..e0cbab6aa0 100644
@@ -131,7 +131,7 @@ int rockchip_saradc_of_to_plat(struct udevice *dev)
         }
 
         priv->data = data;
-       uc_pdata->data_mask = (1 << priv->data->num_bits) - 1;;
+       uc_pdata->data_mask = (1 << priv->data->num_bits) - 1;
         uc_pdata->data_format = ADC_DATA_FORMAT_BIN;
         uc_pdata->data_timeout_us = SARADC_TIMEOUT / 5;
         uc_pdata->channel_mask = (1 << priv->data->num_channels) - 1;
--

2.25.1