Skip to contentSkip to conversation

arm: mvebu: dts: turris_mox: fix non-working USB port

PATCH In review Marek Behún 4 participants 6 messages Mar 22, 2022 – Mar 23, 2022 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm: mvebu: dts: turris_mox: fix non-working USB port

From: Marek Behún <[email protected]>

Commit 0934dddc6436 ("arm: a37xx: Update DTS files to version from upstream Linux kernel") ported Linux's device-tree files for Armada 3720 SOCs. This broke USB port on Turris MOX, because in Linux' DTS the bus voltage supply is described as a phy-supply property of connector node, a mechanism that is not supported in U-Boot yet.

For now, fix this by adding vbus-supply to usb3 node.

Fixes 0934dddc6436 ("arm: a37xx: Update DTS files to version from upstream Linux kernel")

---
Dear Stefan, as with the network issue, could we get this to master ASAP?

---
 arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi +4 -0
index 2e05b973d2..28a36a6103 100644
@@ -21,3 +21,7 @@
 };
 
 /delete-node/ &mdio;
+
+&usb3 {
+	vbus-supply = <&exp_usb3_vbus>;
+};
Signature · 1 line
2.34.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Marek Behún

From: Marek Behún <[email protected]>

Commit 0934dddc6436 ("arm: a37xx: Update DTS files to version from upstream Linux kernel") ported Linux's device-tree files for Armada 3720 SOCs. This broke USB port on Turris MOX, because in Linux' DTS the bus voltage supply is described as a phy-supply property of connector node, a mechanism that is not supported in U-Boot yet.

Quoted 4 lines

For now, fix this by adding vbus-supply to usb3 node.

Fixes 0934dddc6436 ("arm: a37xx: Update DTS files to version from upstream Linux kernel")
Quoted 2 lines

---
Dear Stefan, as with the network issue, could we get this to master ASAP?

Sure. Let me try...

Thanks,
Stefan

Quoted 9 lines
---
  arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi | 4 ++++
  1 file changed, 4 insertions(+)
arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi +0 -0
index 2e05b973d2..28a36a6103 100644

arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi line 27

Quoted 7 lines
arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi +4 -0
@@ -21,3 +21,7 @@
  };
 
  /delete-node/ &mdio;
+
+&usb3 {
+	vbus-supply = <&exp_usb3_vbus>;
+};

Viele Grüße,
Stefan Roese

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: [email protected]
#2 lore raw

Added Tom to Cc.

Quoted 14 lines · Stefan Roese
Quoted 8 lines · Marek Behún

From: Marek Behún <[email protected]>

Commit 0934dddc6436 ("arm: a37xx: Update DTS files to version from upstream Linux kernel") ported Linux's device-tree files for Armada 3720 SOCs. This broke USB port on Turris MOX, because in Linux' DTS the bus voltage supply is described as a phy-supply property of connector node, a mechanism that is not supported in U-Boot yet.

Quoted 4 lines

For now, fix this by adding vbus-supply to usb3 node.

Fixes 0934dddc6436 ("arm: a37xx: Update DTS files to version from upstream Linux kernel")
Quoted 6 lines
Quoted 2 lines

---
Dear Stefan, as with the network issue, could we get this to master ASAP?

Sure. Let me try...

Tom, I'm having trouble with CI, Azure and Gitlab both report problems with "test.py coreboot":

https://dev.azure.com/sr0718/u-boot/_build/results?buildId=167&view=results

This should not result from this patch though.

Could you please pull this patch/fix directly?

Thanks,
Stefan

Quoted 7 lines

Thanks,
Stefan

Quoted 4 lines

---
  arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi | 4 ++++

  1 file changed, 4 insertions(+)
Quoted 15 lines

arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi line 26

Quoted 11 lines
arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi +4 -0
index 2e05b973d2..28a36a6103 100644
@@ -21,3 +21,7 @@
   };
   /delete-node/ &mdio;
+
+&usb3 {
+    vbus-supply = <&exp_usb3_vbus>;
+};

Viele Grüße,
Stefan Roese

Viele Grüße,
Stefan Roese

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: [email protected]
#3 lore raw
Quoted 23 lines · Stefan Roese

Added Tom to Cc.

Quoted 20 lines · Stefan Roese
Quoted 8 lines · Marek Behún

From: Marek Behún <[email protected]>

Commit 0934dddc6436 ("arm: a37xx: Update DTS files to version from upstream Linux kernel") ported Linux's device-tree files for Armada 3720 SOCs. This broke USB port on Turris MOX, because in Linux' DTS the bus voltage supply is described as a phy-supply property of connector node, a mechanism that is not supported in U-Boot yet.

Quoted 5 lines

For now, fix this by adding vbus-supply to usb3 node.

Fixes 0934dddc6436 ("arm: a37xx: Update DTS files to version from

upstream Linux kernel")

Quoted 2 lines

---
Dear Stefan, as with the network issue, could we get this to master ASAP?

Quoted 8 lines
Quoted 1 line

Sure. Let me try...

Tom, I'm having trouble with CI, Azure and Gitlab both report problems with "test.py coreboot":

https://dev.azure.com/sr0718/u-boot/_build/results?buildId=167&view=results

This should not result from this patch though.

Yes, Google is being funny for some reason, I just keep hitting retry until it passes.

Quoted 1 line

Could you please pull this patch/fix directly?

OK.

Signature · 1 line
Tom
Reviewed-by on v1 1/1
#4 lore raw
In reply to Marek Behún
Quoted 8 lines · On Tuesday 22 March 2022 17:17:59 Marek Behún wrote:

From: Marek Behún <[email protected]>

Commit 0934dddc6436 ("arm: a37xx: Update DTS files to version from upstream Linux kernel") ported Linux's device-tree files for Armada 3720 SOCs. This broke USB port on Turris MOX, because in Linux' DTS the bus voltage supply is described as a phy-supply property of connector node, a mechanism that is not supported in U-Boot yet.

Quoted 4 lines

For now, fix this by adding vbus-supply to usb3 node.

Fixes 0934dddc6436 ("arm: a37xx: Update DTS files to version from upstream Linux kernel")

Btw, now I tested USB2.0 and USB3.0 ports on Espressobin v5 (another Armada 3720 board) and both are working fine in U-Boot. Therefore no USB fix is needed for Espressobin DTS file.

Quoted 21 lines

---
Dear Stefan, as with the network issue, could we get this to master ASAP?

---
 arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi +4 -0
index 2e05b973d2..28a36a6103 100644
@@ -21,3 +21,7 @@
 };
 
 /delete-node/ &mdio;
+
+&usb3 {
+	vbus-supply = <&exp_usb3_vbus>;
+};
Signature · 1 line
2.34.1
#5 lore raw
In reply to Marek Behún
Quoted 8 lines · Marek Behún

From: Marek Behún <[email protected]>

Commit 0934dddc6436 ("arm: a37xx: Update DTS files to version from upstream Linux kernel") ported Linux's device-tree files for Armada 3720 SOCs. This broke USB port on Turris MOX, because in Linux' DTS the bus voltage supply is described as a phy-supply property of connector node, a mechanism that is not supported in U-Boot yet.

Quoted 5 lines

For now, fix this by adding vbus-supply to usb3 node.

Fixes 0934dddc6436 ("arm: a37xx: Update DTS files to version from upstream Linux kernel")

Applied to u-boot/master, thanks!

Signature · 1 line
Tom