arm: mvebu: dts: turris_mox: fix non-working USB port
PATCH 1/1 arm: mvebu: dts: turris_mox: fix non-working USB port
From: Marek Behún <[email protected]>
Commit 0934dddc6436 ("arm: a37xx: Update DTS files to version from upstream Linux kernel") ported Linux's device-tree files for Armada 3720 SOCs. This broke USB port on Turris MOX, because in Linux' DTS the bus voltage supply is described as a phy-supply property of connector node, a mechanism that is not supported in U-Boot yet.
For now, fix this by adding vbus-supply to usb3 node.
---
Dear Stefan, as with the network issue, could we get this to master ASAP?
--- arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi | 4 ++++ 1 file changed, 4 insertions(+)
arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi +4 -0
@@ -21,3 +21,7 @@ }; /delete-node/ &mdio; + +&usb3 { + vbus-supply = <&exp_usb3_vbus>; +};
Signature · 1 line
2.34.1
Quoted 8 lines · Marek Behún
From: Marek Behún <[email protected]>
Commit
0934dddc6436("arm: a37xx: Update DTS files to version from upstream Linux kernel") ported Linux's device-tree files for Armada 3720 SOCs. This broke USB port on Turris MOX, because in Linux' DTS the bus voltage supply is described as aphy-supplyproperty of connector node, a mechanism that is not supported in U-Boot yet.
Quoted 4 lines
For now, fix this by adding
vbus-supplyto usb3 node.Fixes 0934dddc6436 ("arm: a37xx: Update DTS files to version from upstream Linux kernel")Signed-off-by Marek Behún <[email protected]>
Quoted 2 lines
---
Dear Stefan, as with the network issue, could we get this to master ASAP?
Sure. Let me try...
Thanks,
Stefan
Quoted 9 lines
--- arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi | 4 ++++ 1 file changed, 4 insertions(+)arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi +0
-0
arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi line 27
Quoted 7 lines
arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi +4
-0@@ -21,3 +21,7 @@ }; /delete-node/ &mdio; + +&usb3 { + vbus-supply = <&exp_usb3_vbus>; +};
Viele Grüße,
Stefan Roese
Signature · 3 lines
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: [email protected]
Added Tom to Cc.
Quoted 14 lines · Stefan Roese
Quoted 8 lines · Marek Behún
From: Marek Behún <[email protected]>
Commit
0934dddc6436("arm: a37xx: Update DTS files to version from upstream Linux kernel") ported Linux's device-tree files for Armada 3720 SOCs. This broke USB port on Turris MOX, because in Linux' DTS the bus voltage supply is described as aphy-supplyproperty of connector node, a mechanism that is not supported in U-Boot yet.Quoted 4 lines
For now, fix this by adding
vbus-supplyto usb3 node.Fixes 0934dddc6436 ("arm: a37xx: Update DTS files to version from upstream Linux kernel")Signed-off-by Marek Behún <[email protected]>
Quoted 6 lines
Reviewed-by Stefan Roese <[email protected]>Quoted 2 lines
---
Dear Stefan, as with the network issue, could we get this to master ASAP?Sure. Let me try...
Tom, I'm having trouble with CI, Azure and Gitlab both report problems with "test.py coreboot":
https://dev.azure.com/sr0718/u-boot/_build/results?buildId=167&view=results
This should not result from this patch though.
Could you please pull this patch/fix directly?
Thanks,
Stefan
Quoted 7 lines
Thanks,
StefanQuoted 4 lines
---
arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi| 4 ++++1 file changed, 4 insertions(+)
Quoted 15 lines
arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi line 26
Quoted 11 lines
arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi +4
-0@@ -21,3 +21,7 @@ }; /delete-node/ &mdio; + +&usb3 { + vbus-supply = <&exp_usb3_vbus>; +};Viele Grüße,
Stefan Roese
Viele Grüße,
Stefan Roese
Signature · 3 lines
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: [email protected]
Quoted 23 lines · Stefan Roese
Added Tom to Cc.
Quoted 20 lines · Stefan Roese
Quoted 8 lines · Marek Behún
From: Marek Behún <[email protected]>
Commit
0934dddc6436("arm: a37xx: Update DTS files to version from upstream Linux kernel") ported Linux's device-tree files for Armada 3720 SOCs. This broke USB port on Turris MOX, because in Linux' DTS the bus voltage supply is described as aphy-supplyproperty of connector node, a mechanism that is not supported in U-Boot yet.Quoted 5 lines
For now, fix this by adding
vbus-supplyto usb3 node.Fixes 0934dddc6436 ("arm: a37xx: Update DTS files to version fromupstream Linux kernel")
Signed-off-by Marek Behún <[email protected]>Reviewed-by Stefan Roese <[email protected]>Quoted 2 lines
---
Dear Stefan, as with the network issue, could we get this to master ASAP?
Quoted 8 lines
Quoted 1 line
Sure. Let me try...
Tom, I'm having trouble with CI, Azure and Gitlab both report problems with "
test.pycoreboot":https://dev.azure.com/sr0718/u-boot/_build/results?buildId=167&view=results
This should not result from this patch though.
Yes, Google is being funny for some reason, I just keep hitting retry until it passes.
Quoted 1 line
Could you please pull this patch/fix directly?
OK.
Signature · 1 line
Tom
Quoted 8 lines · On Tuesday 22 March 2022 17:17:59 Marek Behún wrote:
From: Marek Behún <[email protected]>
Commit
0934dddc6436("arm: a37xx: Update DTS files to version from upstream Linux kernel") ported Linux's device-tree files for Armada 3720 SOCs. This broke USB port on Turris MOX, because in Linux' DTS the bus voltage supply is described as aphy-supplyproperty of connector node, a mechanism that is not supported in U-Boot yet.
Quoted 4 lines
For now, fix this by adding
vbus-supplyto usb3 node.Fixes 0934dddc6436 ("arm: a37xx: Update DTS files to version from upstream Linux kernel")Signed-off-by Marek Behún <[email protected]>
Btw, now I tested USB2.0 and USB3.0 ports on Espressobin v5 (another Armada 3720 board) and both are working fine in U-Boot. Therefore no USB fix is needed for Espressobin DTS file.
Quoted 21 lines
---
Dear Stefan, as with the network issue, could we get this to master ASAP?--- arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi | 4 ++++ 1 file changed, 4 insertions(+)arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi +4
-0@@ -21,3 +21,7 @@ }; /delete-node/ &mdio; + +&usb3 { + vbus-supply = <&exp_usb3_vbus>; +};Signature · 1 line
2.34.1
Quoted 8 lines · Marek Behún
From: Marek Behún <[email protected]>
Commit
0934dddc6436("arm: a37xx: Update DTS files to version from upstream Linux kernel") ported Linux's device-tree files for Armada 3720 SOCs. This broke USB port on Turris MOX, because in Linux' DTS the bus voltage supply is described as aphy-supplyproperty of connector node, a mechanism that is not supported in U-Boot yet.
Quoted 5 lines
For now, fix this by adding
vbus-supplyto usb3 node.Fixes 0934dddc6436 ("arm: a37xx: Update DTS files to version from upstream Linux kernel")Signed-off-by Marek Behún <[email protected]>Reviewed-by Stefan Roese <[email protected]>
Applied to u-boot/master, thanks!
Signature · 1 line
Tom