f2fs: fix error code in f2fs_ioc_start_atomic_write()
Subsystems (2)
PATCH 1/1 f2fs: fix error code in f2fs_ioc_start_atomic_write()
Return an error code if f2fs_iget() fails. Currently it returns success.
--- fs/f2fs/file.c | 1 + 1 file changed, 1 insertion(+)
fs/f2fs/file.c +1 -0
@@ -2047,6 +2047,7 @@ static int f2fs_ioc_start_atomic_write(struct file *filp) pinode =f2fs_iget (inode->i_sb, fi->i_pino);if (IS_ERR (pinode)) {f2fs_up_write (&F2FS_I (inode)->i_gc_rwsem[WRITE ]); + ret =PTR_ERR (pinode); goto out; }
Signature · 8 lines
2.35.1 _______________________________________________ Linux-f2fs-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
Oh, right. Thanks~!
Quoted 25 lines · Dan Carpenter
Return an error code if
f2fs_iget()fails. Currently it returns success.Fixes 3d7ad9c30607 ("f2fs: change the current atomic write way")Signed-off-by Dan Carpenter <[email protected]>--- fs/f2fs/file.c | 1 + 1 file changed, 1 insertion(+)fs/f2fs/file.c +1
-1@@ -2047,6 +2047,7 @@ static int f2fs_ioc_start_atomic_write(struct file *filp) pinode =f2fs_iget (inode->i_sb, fi->i_pino);if (IS_ERR (pinode)) {f2fs_up_write (&F2FS_I (inode)->i_gc_rwsem[WRITE ]); + ret =PTR_ERR (pinode); goto out; } --2.35.1
Jaegeuk Kim
maintainerHi Dan,
Thank you for the fix. If you don't mind, can I integrate this fix into the original patch which is in -next?
Thanks,
Quoted 23 lines · Dan Carpenter
Return an error code if
f2fs_iget()fails. Currently it returns success.Fixes 3d7ad9c30607 ("f2fs: change the current atomic write way")Signed-off-by Dan Carpenter <[email protected]>--- fs/f2fs/file.c | 1 + 1 file changed, 1 insertion(+)fs/f2fs/file.c +1
-0@@ -2047,6 +2047,7 @@ static int f2fs_ioc_start_atomic_write(struct file *filp) pinode =f2fs_iget (inode->i_sb, fi->i_pino);if (IS_ERR (pinode)) {f2fs_up_write (&F2FS_I (inode)->i_gc_rwsem[WRITE ]); + ret =PTR_ERR (pinode); goto out; }Signature · 1 line
2.35.1
Quoted 5 lines · Jaegeuk Kim
Hi Dan,
Thank you for the fix. If you don't mind, can I integrate this fix into the original patch which is in -next?
Yeah, that's not a problem. Feel free.
regards,
dan carpenter
Quoted 24 lines
Thanks,
Quoted 21 lines · Dan Carpenter
Return an error code if
f2fs_iget()fails. Currently it returns success.Fixes 3d7ad9c30607 ("f2fs: change the current atomic write way")Signed-off-by Dan Carpenter <[email protected]>--- fs/f2fs/file.c | 1 + 1 file changed, 1 insertion(+)fs/f2fs/file.c +1
-0@@ -2047,6 +2047,7 @@ static int f2fs_ioc_start_atomic_write(struct file *filp) pinode =f2fs_iget (inode->i_sb, fi->i_pino);if (IS_ERR (pinode)) {f2fs_up_write (&F2FS_I (inode)->i_gc_rwsem[WRITE ]); + ret =PTR_ERR (pinode); goto out; }
Quoted 2 lines
Quoted 2 lines
Signature · 1 line
2.35.1
_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
Jaegeuk Kim
maintainerQuoted 8 lines · Dan Carpenter
Quoted 5 lines · Jaegeuk Kim
Hi Dan,
Thank you for the fix. If you don't mind, can I integrate this fix into the original patch which is in -next?
Yeah, that's not a problem. Feel free.
Thank you~
Quoted 30 lines
regards,
dan carpenterQuoted 26 lines
Thanks,
Quoted 23 lines · Dan Carpenter
Return an error code if
f2fs_iget()fails. Currently it returns success.Fixes 3d7ad9c30607 ("f2fs: change the current atomic write way")Signed-off-by Dan Carpenter <[email protected]>--- fs/f2fs/file.c | 1 + 1 file changed, 1 insertion(+)fs/f2fs/file.c +1
-0@@ -2047,6 +2047,7 @@ static int f2fs_ioc_start_atomic_write(struct file *filp) pinode =f2fs_iget (inode->i_sb, fi->i_pino);if (IS_ERR (pinode)) {f2fs_up_write (&F2FS_I (inode)->i_gc_rwsem[WRITE ]); + ret =PTR_ERR (pinode); goto out; }Signature · 1 line
2.35.1