Skip to contentSkip to conversation

f2fs: fix error code in f2fs_ioc_start_atomic_write()

PATCH In review Dan Carpenter 3 participants 5 messages May 11, 2022 – May 12, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 f2fs: fix error code in f2fs_ioc_start_atomic_write()

Return an error code if f2fs_iget() fails. Currently it returns success.

Fixes 3d7ad9c30607 ("f2fs: change the current atomic write way")
---
 fs/f2fs/file.c | 1 +
 1 file changed, 1 insertion(+)
fs/f2fs/file.c +1 -0
index 79d1a20fbda9..cd768fadfd67 100644
@@ -2047,6 +2047,7 @@ static int f2fs_ioc_start_atomic_write(struct file *filp)
 	pinode = f2fs_iget(inode->i_sb, fi->i_pino);
 	if (IS_ERR(pinode)) {
 		f2fs_up_write(&F2FS_I(inode)->i_gc_rwsem[WRITE]);
+		ret = PTR_ERR(pinode);
 		goto out;
 	}
 
Signature · 8 lines
2.35.1



_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
#1 lore raw

Oh, right. Thanks~!

Quoted 25 lines · Dan Carpenter

Return an error code if f2fs_iget() fails. Currently it returns success.

Fixes 3d7ad9c30607 ("f2fs: change the current atomic write way")
---
 fs/f2fs/file.c | 1 +
 1 file changed, 1 insertion(+)
fs/f2fs/file.c +1 -1
index 79d1a20fbda9..cd768fadfd67 100644
@@ -2047,6 +2047,7 @@ static int f2fs_ioc_start_atomic_write(struct file *filp)
        pinode = f2fs_iget(inode->i_sb, fi->i_pino);
        if (IS_ERR(pinode)) {
                f2fs_up_write(&F2FS_I(inode)->i_gc_rwsem[WRITE]);
+               ret = PTR_ERR(pinode);
                goto out;
        }
 
--

2.35.1

maintainer
#2 lore raw
In reply to Dan Carpenter

Hi Dan,

Thank you for the fix. If you don't mind, can I integrate this fix into the original patch which is in -next?

Thanks,

Quoted 23 lines · Dan Carpenter

Return an error code if f2fs_iget() fails. Currently it returns success.

Fixes 3d7ad9c30607 ("f2fs: change the current atomic write way")
---
 fs/f2fs/file.c | 1 +
 1 file changed, 1 insertion(+)
fs/f2fs/file.c +1 -0
index 79d1a20fbda9..cd768fadfd67 100644
@@ -2047,6 +2047,7 @@ static int f2fs_ioc_start_atomic_write(struct file *filp)
 	pinode = f2fs_iget(inode->i_sb, fi->i_pino);
 	if (IS_ERR(pinode)) {
 		f2fs_up_write(&F2FS_I(inode)->i_gc_rwsem[WRITE]);
+		ret = PTR_ERR(pinode);
 		goto out;
 	}
 
Signature · 1 line
2.35.1
#3 lore raw
Quoted 5 lines · Jaegeuk Kim

Hi Dan,

Thank you for the fix. If you don't mind, can I integrate this fix into the original patch which is in -next?

Yeah, that's not a problem. Feel free.

regards,
dan carpenter

Quoted 24 lines

Thanks,

Quoted 21 lines · Dan Carpenter

Return an error code if f2fs_iget() fails. Currently it returns success.

Fixes 3d7ad9c30607 ("f2fs: change the current atomic write way")
---
 fs/f2fs/file.c | 1 +
 1 file changed, 1 insertion(+)
fs/f2fs/file.c +1 -0
index 79d1a20fbda9..cd768fadfd67 100644
@@ -2047,6 +2047,7 @@ static int f2fs_ioc_start_atomic_write(struct file *filp)
 	pinode = f2fs_iget(inode->i_sb, fi->i_pino);
 	if (IS_ERR(pinode)) {
 		f2fs_up_write(&F2FS_I(inode)->i_gc_rwsem[WRITE]);
+		ret = PTR_ERR(pinode);
 		goto out;
 	}
 
Quoted 2 lines
Quoted 2 lines
Signature · 1 line
2.35.1

_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

maintainer
#4 lore raw
Quoted 8 lines · Dan Carpenter
Quoted 5 lines · Jaegeuk Kim

Hi Dan,

Thank you for the fix. If you don't mind, can I integrate this fix into the original patch which is in -next?

Yeah, that's not a problem. Feel free.

Thank you~

Quoted 30 lines

regards,
dan carpenter

Quoted 26 lines

Thanks,

Quoted 23 lines · Dan Carpenter

Return an error code if f2fs_iget() fails. Currently it returns success.

Fixes 3d7ad9c30607 ("f2fs: change the current atomic write way")
---
 fs/f2fs/file.c | 1 +
 1 file changed, 1 insertion(+)
fs/f2fs/file.c +1 -0
index 79d1a20fbda9..cd768fadfd67 100644
@@ -2047,6 +2047,7 @@ static int f2fs_ioc_start_atomic_write(struct file *filp)
 	pinode = f2fs_iget(inode->i_sb, fi->i_pino);
 	if (IS_ERR(pinode)) {
 		f2fs_up_write(&F2FS_I(inode)->i_gc_rwsem[WRITE]);
+		ret = PTR_ERR(pinode);
 		goto out;
 	}
 
Signature · 1 line
2.35.1