Skip to contentSkip to conversation

Debix Model A board devicetree

PATCH Superseded Daniel Scally 5 participants 11 messages Oct 17, 2022 – Dec 6, 2022

Subsystems (2)

v4 of 6 Superseded Latest is v6 →

lore
Share & tools
lore
#0 lore raw

v4 cover Debix Model A board devicetree

Hello

This series adds a .dts file for the Polyhex Debix Model A board [1] A binding for the vendor is also added.

[1] http://www.polyhex.net/product/embedded-motherboard/board/nxp.html?id=483

Thanks
Dan

Daniel Scally (3):
dt-bindings: vendor-prefixes: Add Polyhex Technology Co.
dt-bindings: arm: fsl: Enumerate Debix Model A Board
arm64: dts: Add device tree for the Debix Model A Board

 .../devicetree/bindings/arm/fsl.yaml          |   1 +
 .../devicetree/bindings/vendor-prefixes.yaml  |   2 +
 arch/arm64/boot/dts/freescale/Makefile        |   1 +
 .../dts/freescale/imx8mp-debix-model-a.dts    | 529 ++++++++++++++++++
 4 files changed, 533 insertions(+)
 create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts
Signature · 1 line
2.34.1
#1 lore raw

PATCH v4 1/3 dt-bindings: vendor-prefixes: Add Polyhex Technology Co.

Add an entry for Polyhex Technology Co. to vendor-prefixes.yaml

---
Changes in v4:

- None

Changes in v3:

- None

Changes in v2:

- None

 Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/vendor-prefixes.yaml +2 -0
index 2f0151e9f6be..7ba1d2c11aa9 100644
@@ -995,6 +995,8 @@ patternProperties:
     description: PocketBook International SA
   "^polaroid,.*":
     description: Polaroid Corporation
+  "^polyhex,.*":
+    description: Polyhex Technology Co. Ltd.
   "^portwell,.*":
     description: Portwell Inc.
   "^poslab,.*":
Signature · 1 line
2.34.1
#2 lore raw

PATCH v4 2/3 dt-bindings: arm: fsl: Enumerate Debix Model A Board

In reply to Daniel Scally

Add an entry to the list of imx8mp boards denoting the Debix Model A board from Polyhex Technology Co.

---
Changes in v4:

- None

Changes in v3:

- Dropped (2GB) from the comment too (Kieran)

Changes in v2:

- Dropped 2gb suffix, added hyphens for readability (Laurent)

 Documentation/devicetree/bindings/arm/fsl.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/fsl.yaml +1 -0
index 7431579ab0e8..1cb72eda8652 100644
@@ -931,6 +931,7 @@ properties:
               - dh,imx8mp-dhcom-pdk2      # i.MX8MP DHCOM SoM on PDK2 board
               - fsl,imx8mp-evk            # i.MX8MP EVK Board
               - gateworks,imx8mp-gw74xx   # i.MX8MP Gateworks Board
+              - polyhex,imx8mp-debix-model-a # Polyhex Debix Model A Board
               - toradex,verdin-imx8mp     # Verdin iMX8M Plus Modules
               - toradex,verdin-imx8mp-nonwifi  # Verdin iMX8M Plus Modules without Wi-Fi / BT
               - toradex,verdin-imx8mp-wifi  # Verdin iMX8M Plus Wi-Fi / BT Modules
Signature · 1 line
2.34.1
#3 lore raw

PATCH v4 3/3 arm64: dts: Add device tree for the Debix Model A Board

In reply to Daniel Scally

Add a device tree file describing the Debix Model A board from Polyhex Technology Co.

---
Changes in v4 (Laurent):

- Aligned the pinctrl group values with each other

Changes in v3 (Laurent):

- Added IOB copyright notice
- Removed the eth node for the connector that's on the separate I/O board
- Re-ordered some pinctrl groups so they're alphabetical

Changes in v2:

- Fixed the interrupt flag for i2c1/pmic@25
- Fixed the node name for i2c4/rtc@51 (was "hym8563@51")
- Fixed a group control name that didn't match the bindings pattern
- Re-compared the rest of the DT with the EVK's .dts file to try to make sure it complies with the way things should be, hopefully without missing anything...

 arch/arm64/boot/dts/freescale/Makefile        |   1 +
 .../dts/freescale/imx8mp-debix-model-a.dts    | 529 ++++++++++++++++++
 2 files changed, 530 insertions(+)
 create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts
arch/arm64/boot/dts/freescale/Makefile +1 -0
index 8bf7f7ecebaa..6a33a08946ac 100644
@@ -80,6 +80,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mn-ddr4-evk.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mn-tqma8mqnl-mba8mx.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mn-var-som-symphony.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mn-venice-gw7902.dtb
+dtb-$(CONFIG_ARCH_MXC) += imx8mp-debix-model-a.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mp-dhcom-pdk2.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mp-evk.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mp-icore-mx8mp-edimm2.2.dtb
arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts new file +529 -0

529 lines not on this page · raw message

Signature · 1 line
2.34.1
#4 lore raw

Re: [PATCH v4 3/3] arm64: dts: Add device tree for the Debix Model A Board

Quoted 69 lines · Daniel Scally

Add a device tree file describing the Debix Model A board from Polyhex Technology Co.

---
Changes in v4 (Laurent):

- Aligned the pinctrl group values with each other

Changes in v3 (Laurent):

- Added IOB copyright notice
- Removed the eth node for the connector that's on the separate I/O board
- Re-ordered some pinctrl groups so they're alphabetical

Changes in v2:

- Fixed the interrupt flag for i2c1/pmic@25
- Fixed the node name for i2c4/rtc@51 (was "hym8563@51")
- Fixed a group control name that didn't match the bindings pattern
- Re-compared the rest of the DT with the EVK's .dts file to try to make sure it complies with the way things should be, hopefully without missing anything...

 arch/arm64/boot/dts/freescale/Makefile        |   1 +
 .../dts/freescale/imx8mp-debix-model-a.dts    | 529 ++++++++++++++++++
 2 files changed, 530 insertions(+)
 create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts
arch/arm64/boot/dts/freescale/Makefile +1 -0
index 8bf7f7ecebaa..6a33a08946ac 100644
@@ -80,6 +80,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mn-ddr4-evk.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mn-tqma8mqnl-mba8mx.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mn-var-som-symphony.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mn-venice-gw7902.dtb
+dtb-$(CONFIG_ARCH_MXC) += imx8mp-debix-model-a.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mp-dhcom-pdk2.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mp-evk.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mp-icore-mx8mp-edimm2.2.dtb
arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts new file +18 -0
new file mode 100644
index 000000000000..92cbd6d2b73f
@@ -0,0 +1,529 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright 2019 NXP
+ * Copyright 2022 Ideas on Board Oy
+ */
+
+/dts-v1/;
+
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/leds/common.h>
+#include <dt-bindings/usb/pd.h>
+
+#include "imx8mp.dtsi"
+
+/ {
+	model = "Polyhex Debix Model A i.MX8MPlus board";
+	compatible = "polyhex,imx8mp-debix-model-a", "fsl,imx8mp";
+

arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts line 28

Quoted 10 lines
arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts new file +10 -0
+	chosen {
+		stdout-path = &uart2;
+	};
+
+	gpio-leds {
+		compatible = "gpio-leds";
+		pinctrl-names = "default";
+		pinctrl-0 = <&pinctrl_gpio_led>;
+
+		status-led {

Did you run 'make dtbs_check'? The node name doesn't seem to match pattern defined by leds-gpio.yaml.

Quoted 56 lines
arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts new file +56 -0
+			function = LED_FUNCTION_POWER;
+			color = <LED_COLOR_ID_RED>;
+			gpios = <&gpio3 16 GPIO_ACTIVE_HIGH>;
+			default-state = "on";
+		};
+	};
+
+	reg_usdhc2_vmmc: regulator-usdhc2 {
+		compatible = "regulator-fixed";
+		pinctrl-names = "default";
+		pinctrl-0 = <&pinctrl_reg_usdhc2_vmmc>;
+		regulator-name = "VSD_3V3";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		gpio = <&gpio2 19 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+	};
+};
+
+&A53_0 {
+	cpu-supply = <&buck2>;
+};
+
+&A53_1 {
+	cpu-supply = <&buck2>;
+};
+
+&A53_2 {
+	cpu-supply = <&buck2>;
+};
+
+&A53_3 {
+	cpu-supply = <&buck2>;
+};
+
+&eqos {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_eqos>;
+	phy-connection-type = "rgmii-id";
+	phy-handle = <&ethphy0>;
+	status = "okay";
+
+	mdio {
+		compatible = "snps,dwmac-mdio";
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		ethphy0: ethernet-phy@0 {
+			compatible = "ethernet-phy-ieee802.3-c22";
+			reg = <0>;
+			reset-gpios = <&gpio4 18 GPIO_ACTIVE_LOW>;
+			reset-assert-us = <20>;
+			reset-deassert-us = <200000>;
+		};
+	};
+};

arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts line 94

Quoted 10 lines
arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts new file +10 -0
+
+&i2c1 {
+	clock-frequency = <400000>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_i2c1>;
+	status = "okay";
+
+	pmic@25 {
+		reg = <0x25>;
+		compatible = "nxp,pca9450c";

We usually start properties with compatible.

Quoted 212 lines
arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts new file +212 -0
+		pinctrl-names = "default";
+		pinctrl-0 = <&pinctrl_pmic>;
+		interrupt-parent = <&gpio1>;
+		interrupts = <3 IRQ_TYPE_EDGE_RISING>;
+
+		regulators {
+			buck1: BUCK1 {
+				regulator-name = "BUCK1";
+				regulator-min-microvolt = <600000>;
+				regulator-max-microvolt = <2187500>;
+				regulator-boot-on;
+				regulator-always-on;
+				regulator-ramp-delay = <3125>;
+			};
+
+			buck2: BUCK2 {
+				regulator-name = "BUCK2";
+				regulator-min-microvolt = <600000>;
+				regulator-max-microvolt = <2187500>;
+				regulator-boot-on;
+				regulator-always-on;
+				regulator-ramp-delay = <3125>;
+				nxp,dvs-run-voltage = <950000>;
+				nxp,dvs-standby-voltage = <850000>;
+			};
+
+			buck4: BUCK4{
+				regulator-name = "BUCK4";
+				regulator-min-microvolt = <600000>;
+				regulator-max-microvolt = <3400000>;
+				regulator-boot-on;
+				regulator-always-on;
+			};
+
+			buck5: BUCK5{
+				regulator-name = "BUCK5";
+				regulator-min-microvolt = <600000>;
+				regulator-max-microvolt = <3400000>;
+				regulator-boot-on;
+				regulator-always-on;
+			};
+
+			buck6: BUCK6 {
+				regulator-name = "BUCK6";
+				regulator-min-microvolt = <600000>;
+				regulator-max-microvolt = <3400000>;
+				regulator-boot-on;
+				regulator-always-on;
+			};
+
+			ldo1: LDO1 {
+				regulator-name = "LDO1";
+				regulator-min-microvolt = <1600000>;
+				regulator-max-microvolt = <3300000>;
+				regulator-boot-on;
+				regulator-always-on;
+			};
+
+			ldo2: LDO2 {
+				regulator-name = "LDO2";
+				regulator-min-microvolt = <800000>;
+				regulator-max-microvolt = <1150000>;
+				regulator-boot-on;
+				regulator-always-on;
+			};
+
+			ldo3: LDO3 {
+				regulator-name = "LDO3";
+				regulator-min-microvolt = <800000>;
+				regulator-max-microvolt = <3300000>;
+				regulator-boot-on;
+				regulator-always-on;
+			};
+
+			ldo4: LDO4 {
+				regulator-name = "LDO4";
+				regulator-min-microvolt = <800000>;
+				regulator-max-microvolt = <3300000>;
+				regulator-boot-on;
+				regulator-always-on;
+			};
+
+			ldo5: LDO5 {
+				regulator-name = "LDO5";
+				regulator-min-microvolt = <1800000>;
+				regulator-max-microvolt = <3300000>;
+				regulator-boot-on;
+				regulator-always-on;
+			};
+		};
+	};
+};
+
+&i2c2 {
+	clock-frequency = <100000>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_i2c2>;
+	status = "okay";
+};
+
+&i2c3 {
+	clock-frequency = <400000>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_i2c3>;
+	status = "okay";
+};
+
+&i2c4 {
+	clock-frequency = <100000>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_i2c4>;
+	status = "okay";
+
+	eeprom@50 {
+		compatible = "atmel,24c02";
+		reg = <0x50>;
+		pagesize = <16>;
+	};
+
+	rtc@51 {
+		compatible = "haoyu,hym8563";
+		reg = <0x51>;
+		#clock-cells = <0>;
+		clock-frequency = <32768>;
+		clock-output-names = "xin32k";
+		interrupt-parent = <&gpio2>;
+		interrupts = <11 IRQ_TYPE_EDGE_FALLING>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&pinctrl_rtc_int>;
+	};
+};
+
+&i2c6 {
+	clock-frequency = <400000>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_i2c6>;
+	status = "okay";
+};
+
+&iomuxc {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_hog>;
+
+	pinctrl_hog: hoggrp {
+		fsl,pins = <
+			MX8MP_IOMUXC_HDMI_DDC_SCL__HDMIMIX_HDMI_SCL			0x400001c3
+			MX8MP_IOMUXC_HDMI_DDC_SDA__HDMIMIX_HDMI_SDA			0x400001c3
+			MX8MP_IOMUXC_HDMI_HPD__HDMIMIX_HDMI_HPD				0x40000019
+			MX8MP_IOMUXC_HDMI_CEC__HDMIMIX_HDMI_CEC				0x40000019
+		>;
+	};
+
+	pinctrl_eqos: eqosgrp {
+		fsl,pins = <
+			MX8MP_IOMUXC_ENET_MDC__ENET_QOS_MDC				0x3
+			MX8MP_IOMUXC_ENET_MDIO__ENET_QOS_MDIO				0x3
+			MX8MP_IOMUXC_ENET_RD0__ENET_QOS_RGMII_RD0			0x91
+			MX8MP_IOMUXC_ENET_RD1__ENET_QOS_RGMII_RD1			0x91
+			MX8MP_IOMUXC_ENET_RD2__ENET_QOS_RGMII_RD2			0x91
+			MX8MP_IOMUXC_ENET_RD3__ENET_QOS_RGMII_RD3			0x91
+			MX8MP_IOMUXC_ENET_RXC__CCM_ENET_QOS_CLOCK_GENERATE_RX_CLK	0x91
+			MX8MP_IOMUXC_ENET_RX_CTL__ENET_QOS_RGMII_RX_CTL			0x91
+			MX8MP_IOMUXC_ENET_TD0__ENET_QOS_RGMII_TD0			0x1f
+			MX8MP_IOMUXC_ENET_TD1__ENET_QOS_RGMII_TD1			0x1f
+			MX8MP_IOMUXC_ENET_TD2__ENET_QOS_RGMII_TD2			0x1f
+			MX8MP_IOMUXC_ENET_TD3__ENET_QOS_RGMII_TD3			0x1f
+			MX8MP_IOMUXC_ENET_TX_CTL__ENET_QOS_RGMII_TX_CTL			0x1f
+			MX8MP_IOMUXC_ENET_TXC__CCM_ENET_QOS_CLOCK_GENERATE_TX_CLK	0x1f
+			MX8MP_IOMUXC_SAI1_RXFS__ENET1_1588_EVENT0_IN			0x1f
+			MX8MP_IOMUXC_SAI1_RXC__ENET1_1588_EVENT0_OUT			0x1f
+			MX8MP_IOMUXC_SAI1_TXD6__GPIO4_IO18				0x19
+		>;
+	};
+
+	pinctrl_fec: fecgrp {
+		fsl,pins = <
+			MX8MP_IOMUXC_SAI1_RXD2__ENET1_MDC				0x3
+			MX8MP_IOMUXC_SAI1_RXD3__ENET1_MDIO				0x3
+			MX8MP_IOMUXC_SAI1_RXD4__ENET1_RGMII_RD0				0x91
+			MX8MP_IOMUXC_SAI1_RXD5__ENET1_RGMII_RD1				0x91
+			MX8MP_IOMUXC_SAI1_RXD6__ENET1_RGMII_RD2				0x91
+			MX8MP_IOMUXC_SAI1_RXD7__ENET1_RGMII_RD3				0x91
+			MX8MP_IOMUXC_SAI1_TXC__ENET1_RGMII_RXC				0x91
+			MX8MP_IOMUXC_SAI1_TXFS__ENET1_RGMII_RX_CTL			0x91
+			MX8MP_IOMUXC_SAI1_TXD0__ENET1_RGMII_TD0				0x1f
+			MX8MP_IOMUXC_SAI1_TXD1__ENET1_RGMII_TD1				0x1f
+			MX8MP_IOMUXC_SAI1_TXD2__ENET1_RGMII_TD2				0x1f
+			MX8MP_IOMUXC_SAI1_TXD3__ENET1_RGMII_TD3				0x1f
+			MX8MP_IOMUXC_SAI1_TXD4__ENET1_RGMII_TX_CTL			0x1f
+			MX8MP_IOMUXC_SAI1_TXD5__ENET1_RGMII_TXC				0x1f
+			MX8MP_IOMUXC_SAI1_RXD1__ENET1_1588_EVENT1_OUT			0x1f
+			MX8MP_IOMUXC_SAI1_RXD0__ENET1_1588_EVENT1_IN			0x1f
+			MX8MP_IOMUXC_SAI1_TXD7__GPIO4_IO19				0x19
+		>;
+	};
+
+	pinctrl_gpio_led: gpioledgrp {
+		fsl,pins = <
+			MX8MP_IOMUXC_NAND_READY_B__GPIO3_IO16				0x19
+		>;
+	};
+
+	pinctrl_i2c1: i2c1grp {
+		fsl,pins = <
+			MX8MP_IOMUXC_I2C1_SCL__I2C1_SCL					0x400001c2
+			MX8MP_IOMUXC_I2C1_SDA__I2C1_SDA					0x400001c2
+		>;
+	};
+
+	pinctrl_i2c2: i2c2grp {
+		fsl,pins = <
+			MX8MP_IOMUXC_I2C2_SCL__I2C2_SCL					0x400001c2

arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts line 316

Quoted 10 lines
arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts new file +10 -0
+			MX8MP_IOMUXC_I2C2_SDA__I2C2_SDA					0x400001c2
+		>;
+	};
+
+	pinctrl_i2c3: i2c3grp {
+		fsl,pins = <
+			MX8MP_IOMUXC_I2C3_SCL__I2C3_SCL					0x400001c2
+			MX8MP_IOMUXC_I2C3_SDA__I2C3_SDA					0x400001c2
+		>;
+	};

Missing newline.

Shawn

Quoted 216 lines
arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts new file +213 -0
+	pinctrl_i2c4: i2c4grp {
+		fsl,pins = <
+			MX8MP_IOMUXC_I2C4_SCL__I2C4_SCL					0x400001c3
+			MX8MP_IOMUXC_I2C4_SDA__I2C4_SDA					0x400001c3
+		>;
+	};
+
+	pinctrl_i2c6: i2c6grp {
+		fsl,pins = <
+			MX8MP_IOMUXC_SAI5_RXFS__I2C6_SCL				0x400001c3
+			MX8MP_IOMUXC_SAI5_RXC__I2C6_SDA					0x400001c3
+		>;
+	};
+
+	pinctrl_pmic: pmicirqgrp {
+		fsl,pins = <
+			MX8MP_IOMUXC_GPIO1_IO03__GPIO1_IO03				0x41
+		>;
+	};
+
+	pinctrl_reg_usdhc2_vmmc: regusdhc2vmmcgrp {
+		fsl,pins = <
+			MX8MP_IOMUXC_SD2_RESET_B__GPIO2_IO19				0x41
+		>;
+	};
+
+	pinctrl_rtc_int: rtcintgrp {
+		fsl,pins = <
+			MX8MP_IOMUXC_SD1_STROBE__GPIO2_IO11				0x140
+		>;
+	};
+
+	pinctrl_uart2: uart2grp {
+		fsl,pins = <
+			MX8MP_IOMUXC_UART2_RXD__UART2_DCE_RX				0x14f
+			MX8MP_IOMUXC_UART2_TXD__UART2_DCE_TX				0x14f
+		>;
+	};
+
+	pinctrl_uart3: uart3grp {
+		fsl,pins = <
+			MX8MP_IOMUXC_UART3_RXD__UART3_DCE_RX				0x49
+			MX8MP_IOMUXC_UART3_TXD__UART3_DCE_TX				0x49
+		>;
+	};
+
+	pinctrl_uart4: uart4grp {
+		fsl,pins = <
+			MX8MP_IOMUXC_UART4_RXD__UART4_DCE_RX				0x49
+			MX8MP_IOMUXC_UART4_TXD__UART4_DCE_TX				0x49
+		>;
+	};
+
+	pinctrl_usb1_vbus: usb1grp {
+		fsl,pins = <
+			MX8MP_IOMUXC_SAI2_TXC__GPIO4_IO25				0x19
+			MX8MP_IOMUXC_SAI2_TXD0__GPIO4_IO26				0x19
+		>;
+	};
+
+	pinctrl_usdhc2: usdhc2grp {
+		fsl,pins = <
+			MX8MP_IOMUXC_SD2_CLK__USDHC2_CLK				0x190
+			MX8MP_IOMUXC_SD2_CMD__USDHC2_CMD				0x1d0
+			MX8MP_IOMUXC_SD2_DATA0__USDHC2_DATA0				0x1d0
+			MX8MP_IOMUXC_SD2_DATA1__USDHC2_DATA1				0x1d0
+			MX8MP_IOMUXC_SD2_DATA2__USDHC2_DATA2				0x1d0
+			MX8MP_IOMUXC_SD2_DATA3__USDHC2_DATA3				0x1d0
+			MX8MP_IOMUXC_GPIO1_IO04__USDHC2_VSELECT				0xc1
+		>;
+	};
+
+	pinctrl_usdhc2_100mhz: usdhc2-100mhzgrp {
+		fsl,pins = <
+			MX8MP_IOMUXC_SD2_CLK__USDHC2_CLK				0x194
+			MX8MP_IOMUXC_SD2_CMD__USDHC2_CMD				0x1d4
+			MX8MP_IOMUXC_SD2_DATA0__USDHC2_DATA0				0x1d4
+			MX8MP_IOMUXC_SD2_DATA1__USDHC2_DATA1				0x1d4
+			MX8MP_IOMUXC_SD2_DATA2__USDHC2_DATA2				0x1d4
+			MX8MP_IOMUXC_SD2_DATA3__USDHC2_DATA3				0x1d4
+			MX8MP_IOMUXC_GPIO1_IO04__USDHC2_VSELECT				0xc1
+		>;
+	};
+
+	pinctrl_usdhc2_200mhz: usdhc2-200mhzgrp {
+		fsl,pins = <
+			MX8MP_IOMUXC_SD2_CLK__USDHC2_CLK				0x196
+			MX8MP_IOMUXC_SD2_CMD__USDHC2_CMD				0x1d6
+			MX8MP_IOMUXC_SD2_DATA0__USDHC2_DATA0				0x1d6
+			MX8MP_IOMUXC_SD2_DATA1__USDHC2_DATA1				0x1d6
+			MX8MP_IOMUXC_SD2_DATA2__USDHC2_DATA2				0x1d6
+			MX8MP_IOMUXC_SD2_DATA3__USDHC2_DATA3				0x1d6
+			MX8MP_IOMUXC_GPIO1_IO04__USDHC2_VSELECT				0xc1
+		>;
+	};
+
+	pinctrl_usdhc2_gpio: usdhc2gpiogrp {
+		fsl,pins = <
+			MX8MP_IOMUXC_SD2_CD_B__GPIO2_IO12				0x1c4
+		>;
+	};
+
+	pinctrl_usdhc3: usdhc3grp {
+		fsl,pins = <
+			MX8MP_IOMUXC_NAND_WE_B__USDHC3_CLK				0x190
+			MX8MP_IOMUXC_NAND_WP_B__USDHC3_CMD				0x1d0
+			MX8MP_IOMUXC_NAND_DATA04__USDHC3_DATA0				0x1d0
+			MX8MP_IOMUXC_NAND_DATA05__USDHC3_DATA1				0x1d0
+			MX8MP_IOMUXC_NAND_DATA06__USDHC3_DATA2				0x1d0
+			MX8MP_IOMUXC_NAND_DATA07__USDHC3_DATA3				0x1d0
+			MX8MP_IOMUXC_NAND_RE_B__USDHC3_DATA4				0x1d0
+			MX8MP_IOMUXC_NAND_CE2_B__USDHC3_DATA5				0x1d0
+			MX8MP_IOMUXC_NAND_CE3_B__USDHC3_DATA6				0x1d0
+			MX8MP_IOMUXC_NAND_CLE__USDHC3_DATA7				0x1d0
+			MX8MP_IOMUXC_NAND_CE1_B__USDHC3_STROBE				0x190
+		>;
+	};
+
+	pinctrl_usdhc3_100mhz: usdhc3-100mhzgrp {
+		fsl,pins = <
+			MX8MP_IOMUXC_NAND_WE_B__USDHC3_CLK				0x194
+			MX8MP_IOMUXC_NAND_WP_B__USDHC3_CMD				0x1d4
+			MX8MP_IOMUXC_NAND_DATA04__USDHC3_DATA0				0x1d4
+			MX8MP_IOMUXC_NAND_DATA05__USDHC3_DATA1				0x1d4
+			MX8MP_IOMUXC_NAND_DATA06__USDHC3_DATA2				0x1d4
+			MX8MP_IOMUXC_NAND_DATA07__USDHC3_DATA3				0x1d4
+			MX8MP_IOMUXC_NAND_RE_B__USDHC3_DATA4				0x1d4
+			MX8MP_IOMUXC_NAND_CE2_B__USDHC3_DATA5				0x1d4
+			MX8MP_IOMUXC_NAND_CE3_B__USDHC3_DATA6				0x1d4
+			MX8MP_IOMUXC_NAND_CLE__USDHC3_DATA7				0x1d4
+			MX8MP_IOMUXC_NAND_CE1_B__USDHC3_STROBE				0x194
+		>;
+	};
+
+	pinctrl_usdhc3_200mhz: usdhc3-200mhzgrp {
+		fsl,pins = <
+			MX8MP_IOMUXC_NAND_WE_B__USDHC3_CLK				0x196
+			MX8MP_IOMUXC_NAND_WP_B__USDHC3_CMD				0x1d6
+			MX8MP_IOMUXC_NAND_DATA04__USDHC3_DATA0				0x1d6
+			MX8MP_IOMUXC_NAND_DATA05__USDHC3_DATA1				0x1d6
+			MX8MP_IOMUXC_NAND_DATA06__USDHC3_DATA2				0x1d6
+			MX8MP_IOMUXC_NAND_DATA07__USDHC3_DATA3				0x1d6
+			MX8MP_IOMUXC_NAND_RE_B__USDHC3_DATA4				0x1d6
+			MX8MP_IOMUXC_NAND_CE2_B__USDHC3_DATA5				0x1d6
+			MX8MP_IOMUXC_NAND_CE3_B__USDHC3_DATA6				0x1d6
+			MX8MP_IOMUXC_NAND_CLE__USDHC3_DATA7				0x1d6
+			MX8MP_IOMUXC_NAND_CE1_B__USDHC3_STROBE				0x196
+		>;
+	};
+
+	pinctrl_wdog: wdoggrp {
+		fsl,pins = <
+			MX8MP_IOMUXC_GPIO1_IO02__WDOG1_WDOG_B				0xc6
+		>;
+	};
+};
+
+&snvs_pwrkey {
+	status = "okay";
+};
+
+&uart2 {
+	/* console */
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_uart2>;
+	status = "okay";
+};
+
+&uart3 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_uart3>;
+	status = "okay";
+};
+
+&uart4 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_uart4>;
+	status = "okay";
+};
+
+/* SD Card */
+&usdhc2 {
+	assigned-clocks = <&clk IMX8MP_CLK_USDHC2>;
+	assigned-clock-rates = <400000000>;
+	pinctrl-names = "default", "state_100mhz", "state_200mhz";
+	pinctrl-0 = <&pinctrl_usdhc2>, <&pinctrl_usdhc2_gpio>;
+	pinctrl-1 = <&pinctrl_usdhc2_100mhz>, <&pinctrl_usdhc2_gpio>;
+	pinctrl-2 = <&pinctrl_usdhc2_200mhz>, <&pinctrl_usdhc2_gpio>;
+	cd-gpios = <&gpio2 12 GPIO_ACTIVE_LOW>;
+	vmmc-supply = <&reg_usdhc2_vmmc>;
+	bus-width = <4>;
+	status = "okay";
+};
+
+/* eMMc */
+&usdhc3 {
+	assigned-clocks = <&clk IMX8MP_CLK_USDHC3>;
+	assigned-clock-rates = <400000000>;
+	pinctrl-names = "default", "state_100mhz", "state_200mhz";
+	pinctrl-0 = <&pinctrl_usdhc3>;
+	pinctrl-1 = <&pinctrl_usdhc3_100mhz>;
+	pinctrl-2 = <&pinctrl_usdhc3_200mhz>;
+	bus-width = <8>;
+	non-removable;
+	status = "okay";
+};
+
+&wdog1 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_wdog>;
+	fsl,ext-reset-output;
+	status = "okay";
+};
Signature · 1 line
2.34.1
author
#5 lore raw

Re: [PATCH v4 3/3] arm64: dts: Add device tree for the Debix Model A Board

Hi Shawn - sorry for the delay on this one

Quoted 74 lines · Shawn Guo
Quoted 73 lines · Daniel Scally

Add a device tree file describing the Debix Model A board from Polyhex Technology Co.

---
Changes in v4 (Laurent):

- Aligned the pinctrl group values with each other

Changes in v3 (Laurent):

- Added IOB copyright notice
- Removed the eth node for the connector that's on the separate I/O board
- Re-ordered some pinctrl groups so they're alphabetical

Changes in v2:

- Fixed the interrupt flag for i2c1/pmic@25
- Fixed the node name for i2c4/rtc@51 (was "hym8563@51")
- Fixed a group control name that didn't match the bindings pattern
- Re-compared the rest of the DT with the EVK's .dts file to try to make sure it complies with the way things should be, hopefully without missing anything...

  arch/arm64/boot/dts/freescale/Makefile        |   1 +
  .../dts/freescale/imx8mp-debix-model-a.dts    | 529 ++++++++++++++++++
  2 files changed, 530 insertions(+)

create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts

arch/arm64/boot/dts/freescale/Makefile +1 -0
index 8bf7f7ecebaa..6a33a08946ac 100644
@@ -80,6 +80,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mn-ddr4-evk.dtb
  dtb-$(CONFIG_ARCH_MXC) += imx8mn-tqma8mqnl-mba8mx.dtb
  dtb-$(CONFIG_ARCH_MXC) += imx8mn-var-som-symphony.dtb
  dtb-$(CONFIG_ARCH_MXC) += imx8mn-venice-gw7902.dtb
+dtb-$(CONFIG_ARCH_MXC) += imx8mp-debix-model-a.dtb
  dtb-$(CONFIG_ARCH_MXC) += imx8mp-dhcom-pdk2.dtb
  dtb-$(CONFIG_ARCH_MXC) += imx8mp-evk.dtb
  dtb-$(CONFIG_ARCH_MXC) += imx8mp-icore-mx8mp-edimm2.2.dtb
arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts new file +22 -0
new file mode 100644
index 000000000000..92cbd6d2b73f
@@ -0,0 +1,529 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright 2019 NXP
+ * Copyright 2022 Ideas on Board Oy
+ */
+
+/dts-v1/;
+
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/leds/common.h>
+#include <dt-bindings/usb/pd.h>
+
+#include "imx8mp.dtsi"
+
+/ {
+	model = "Polyhex Debix Model A i.MX8MPlus board";
+	compatible = "polyhex,imx8mp-debix-model-a", "fsl,imx8mp";
+
+	chosen {
+		stdout-path = &uart2;
+	};
+
Quoted 8 lines

arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts line 28

Quoted 6 lines
arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts new file +6 -0
+	gpio-leds {
+		compatible = "gpio-leds";
+		pinctrl-names = "default";
+		pinctrl-0 = <&pinctrl_gpio_led>;
+
+		status-led {

Did you run 'make dtbs_check'? The node name doesn't seem to match pattern defined by leds-gpio.yaml.

I did yes, it doesn't complain about this because the pattern matching for leds-gpio has an "|led" in it, which is pretty broad. I'll switch to the "led-0" form though.

Quoted 60 lines
Quoted 60 lines
arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts new file +59 -0
+			function = LED_FUNCTION_POWER;
+			color = <LED_COLOR_ID_RED>;
+			gpios = <&gpio3 16 GPIO_ACTIVE_HIGH>;
+			default-state = "on";
+		};
+	};
+
+	reg_usdhc2_vmmc: regulator-usdhc2 {
+		compatible = "regulator-fixed";
+		pinctrl-names = "default";
+		pinctrl-0 = <&pinctrl_reg_usdhc2_vmmc>;
+		regulator-name = "VSD_3V3";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		gpio = <&gpio2 19 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+	};
+};
+
+&A53_0 {
+	cpu-supply = <&buck2>;
+};
+
+&A53_1 {
+	cpu-supply = <&buck2>;
+};
+
+&A53_2 {
+	cpu-supply = <&buck2>;
+};
+
+&A53_3 {
+	cpu-supply = <&buck2>;
+};
+
+&eqos {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_eqos>;
+	phy-connection-type = "rgmii-id";
+	phy-handle = <&ethphy0>;
+	status = "okay";
+
+	mdio {
+		compatible = "snps,dwmac-mdio";
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		ethphy0: ethernet-phy@0 {
+			compatible = "ethernet-phy-ieee802.3-c22";
+			reg = <0>;
+			reset-gpios = <&gpio4 18 GPIO_ACTIVE_LOW>;
+			reset-assert-us = <20>;
+			reset-deassert-us = <200000>;
+		};
+	};
+};
+
+&i2c1 {
+	clock-frequency = <400000>;
Quoted 8 lines

arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts line 94

Quoted 7 lines
arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts new file +7 -0
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_i2c1>;
+	status = "okay";
+
+	pmic@25 {
+		reg = <0x25>;
+		compatible = "nxp,pca9450c";

We usually start properties with compatible.

Ack

Quoted 216 lines
Quoted 216 lines
arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts new file +215 -0
+		pinctrl-names = "default";
+		pinctrl-0 = <&pinctrl_pmic>;
+		interrupt-parent = <&gpio1>;
+		interrupts = <3 IRQ_TYPE_EDGE_RISING>;
+
+		regulators {
+			buck1: BUCK1 {
+				regulator-name = "BUCK1";
+				regulator-min-microvolt = <600000>;
+				regulator-max-microvolt = <2187500>;
+				regulator-boot-on;
+				regulator-always-on;
+				regulator-ramp-delay = <3125>;
+			};
+
+			buck2: BUCK2 {
+				regulator-name = "BUCK2";
+				regulator-min-microvolt = <600000>;
+				regulator-max-microvolt = <2187500>;
+				regulator-boot-on;
+				regulator-always-on;
+				regulator-ramp-delay = <3125>;
+				nxp,dvs-run-voltage = <950000>;
+				nxp,dvs-standby-voltage = <850000>;
+			};
+
+			buck4: BUCK4{
+				regulator-name = "BUCK4";
+				regulator-min-microvolt = <600000>;
+				regulator-max-microvolt = <3400000>;
+				regulator-boot-on;
+				regulator-always-on;
+			};
+
+			buck5: BUCK5{
+				regulator-name = "BUCK5";
+				regulator-min-microvolt = <600000>;
+				regulator-max-microvolt = <3400000>;
+				regulator-boot-on;
+				regulator-always-on;
+			};
+
+			buck6: BUCK6 {
+				regulator-name = "BUCK6";
+				regulator-min-microvolt = <600000>;
+				regulator-max-microvolt = <3400000>;
+				regulator-boot-on;
+				regulator-always-on;
+			};
+
+			ldo1: LDO1 {
+				regulator-name = "LDO1";
+				regulator-min-microvolt = <1600000>;
+				regulator-max-microvolt = <3300000>;
+				regulator-boot-on;
+				regulator-always-on;
+			};
+
+			ldo2: LDO2 {
+				regulator-name = "LDO2";
+				regulator-min-microvolt = <800000>;
+				regulator-max-microvolt = <1150000>;
+				regulator-boot-on;
+				regulator-always-on;
+			};
+
+			ldo3: LDO3 {
+				regulator-name = "LDO3";
+				regulator-min-microvolt = <800000>;
+				regulator-max-microvolt = <3300000>;
+				regulator-boot-on;
+				regulator-always-on;
+			};
+
+			ldo4: LDO4 {
+				regulator-name = "LDO4";
+				regulator-min-microvolt = <800000>;
+				regulator-max-microvolt = <3300000>;
+				regulator-boot-on;
+				regulator-always-on;
+			};
+
+			ldo5: LDO5 {
+				regulator-name = "LDO5";
+				regulator-min-microvolt = <1800000>;
+				regulator-max-microvolt = <3300000>;
+				regulator-boot-on;
+				regulator-always-on;
+			};
+		};
+	};
+};
+
+&i2c2 {
+	clock-frequency = <100000>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_i2c2>;
+	status = "okay";
+};
+
+&i2c3 {
+	clock-frequency = <400000>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_i2c3>;
+	status = "okay";
+};
+
+&i2c4 {
+	clock-frequency = <100000>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_i2c4>;
+	status = "okay";
+
+	eeprom@50 {
+		compatible = "atmel,24c02";
+		reg = <0x50>;
+		pagesize = <16>;
+	};
+
+	rtc@51 {
+		compatible = "haoyu,hym8563";
+		reg = <0x51>;
+		#clock-cells = <0>;
+		clock-frequency = <32768>;
+		clock-output-names = "xin32k";
+		interrupt-parent = <&gpio2>;
+		interrupts = <11 IRQ_TYPE_EDGE_FALLING>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&pinctrl_rtc_int>;
+	};
+};
+
+&i2c6 {
+	clock-frequency = <400000>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_i2c6>;
+	status = "okay";
+};
+
+&iomuxc {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_hog>;
+
+	pinctrl_hog: hoggrp {
+		fsl,pins = <
+			MX8MP_IOMUXC_HDMI_DDC_SCL__HDMIMIX_HDMI_SCL			0x400001c3
+			MX8MP_IOMUXC_HDMI_DDC_SDA__HDMIMIX_HDMI_SDA			0x400001c3
+			MX8MP_IOMUXC_HDMI_HPD__HDMIMIX_HDMI_HPD				0x40000019
+			MX8MP_IOMUXC_HDMI_CEC__HDMIMIX_HDMI_CEC				0x40000019
+		>;
+	};
+
+	pinctrl_eqos: eqosgrp {
+		fsl,pins = <
+			MX8MP_IOMUXC_ENET_MDC__ENET_QOS_MDC				0x3
+			MX8MP_IOMUXC_ENET_MDIO__ENET_QOS_MDIO				0x3
+			MX8MP_IOMUXC_ENET_RD0__ENET_QOS_RGMII_RD0			0x91
+			MX8MP_IOMUXC_ENET_RD1__ENET_QOS_RGMII_RD1			0x91
+			MX8MP_IOMUXC_ENET_RD2__ENET_QOS_RGMII_RD2			0x91
+			MX8MP_IOMUXC_ENET_RD3__ENET_QOS_RGMII_RD3			0x91
+			MX8MP_IOMUXC_ENET_RXC__CCM_ENET_QOS_CLOCK_GENERATE_RX_CLK	0x91
+			MX8MP_IOMUXC_ENET_RX_CTL__ENET_QOS_RGMII_RX_CTL			0x91
+			MX8MP_IOMUXC_ENET_TD0__ENET_QOS_RGMII_TD0			0x1f
+			MX8MP_IOMUXC_ENET_TD1__ENET_QOS_RGMII_TD1			0x1f
+			MX8MP_IOMUXC_ENET_TD2__ENET_QOS_RGMII_TD2			0x1f
+			MX8MP_IOMUXC_ENET_TD3__ENET_QOS_RGMII_TD3			0x1f
+			MX8MP_IOMUXC_ENET_TX_CTL__ENET_QOS_RGMII_TX_CTL			0x1f
+			MX8MP_IOMUXC_ENET_TXC__CCM_ENET_QOS_CLOCK_GENERATE_TX_CLK	0x1f
+			MX8MP_IOMUXC_SAI1_RXFS__ENET1_1588_EVENT0_IN			0x1f
+			MX8MP_IOMUXC_SAI1_RXC__ENET1_1588_EVENT0_OUT			0x1f
+			MX8MP_IOMUXC_SAI1_TXD6__GPIO4_IO18				0x19
+		>;
+	};
+
+	pinctrl_fec: fecgrp {
+		fsl,pins = <
+			MX8MP_IOMUXC_SAI1_RXD2__ENET1_MDC				0x3
+			MX8MP_IOMUXC_SAI1_RXD3__ENET1_MDIO				0x3
+			MX8MP_IOMUXC_SAI1_RXD4__ENET1_RGMII_RD0				0x91
+			MX8MP_IOMUXC_SAI1_RXD5__ENET1_RGMII_RD1				0x91
+			MX8MP_IOMUXC_SAI1_RXD6__ENET1_RGMII_RD2				0x91
+			MX8MP_IOMUXC_SAI1_RXD7__ENET1_RGMII_RD3				0x91
+			MX8MP_IOMUXC_SAI1_TXC__ENET1_RGMII_RXC				0x91
+			MX8MP_IOMUXC_SAI1_TXFS__ENET1_RGMII_RX_CTL			0x91
+			MX8MP_IOMUXC_SAI1_TXD0__ENET1_RGMII_TD0				0x1f
+			MX8MP_IOMUXC_SAI1_TXD1__ENET1_RGMII_TD1				0x1f
+			MX8MP_IOMUXC_SAI1_TXD2__ENET1_RGMII_TD2				0x1f
+			MX8MP_IOMUXC_SAI1_TXD3__ENET1_RGMII_TD3				0x1f
+			MX8MP_IOMUXC_SAI1_TXD4__ENET1_RGMII_TX_CTL			0x1f
+			MX8MP_IOMUXC_SAI1_TXD5__ENET1_RGMII_TXC				0x1f
+			MX8MP_IOMUXC_SAI1_RXD1__ENET1_1588_EVENT1_OUT			0x1f
+			MX8MP_IOMUXC_SAI1_RXD0__ENET1_1588_EVENT1_IN			0x1f
+			MX8MP_IOMUXC_SAI1_TXD7__GPIO4_IO19				0x19
+		>;
+	};
+
+	pinctrl_gpio_led: gpioledgrp {
+		fsl,pins = <
+			MX8MP_IOMUXC_NAND_READY_B__GPIO3_IO16				0x19
+		>;
+	};
+
+	pinctrl_i2c1: i2c1grp {
+		fsl,pins = <
+			MX8MP_IOMUXC_I2C1_SCL__I2C1_SCL					0x400001c2
+			MX8MP_IOMUXC_I2C1_SDA__I2C1_SDA					0x400001c2
+		>;
+	};
+
+	pinctrl_i2c2: i2c2grp {
+		fsl,pins = <
+			MX8MP_IOMUXC_I2C2_SCL__I2C2_SCL					0x400001c2
+			MX8MP_IOMUXC_I2C2_SDA__I2C2_SDA					0x400001c2
+		>;
+	};
Quoted 8 lines

arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts line 316

Quoted 7 lines
arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts new file +7 -0
+
+	pinctrl_i2c3: i2c3grp {
+		fsl,pins = <
+			MX8MP_IOMUXC_I2C3_SCL__I2C3_SCL					0x400001c2
+			MX8MP_IOMUXC_I2C3_SDA__I2C3_SDA					0x400001c2
+		>;
+	};

Missing newline.

Thanks!

Quoted 219 lines

Shawn

Quoted 216 lines
arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts new file +213 -0
+	pinctrl_i2c4: i2c4grp {
+		fsl,pins = <
+			MX8MP_IOMUXC_I2C4_SCL__I2C4_SCL					0x400001c3
+			MX8MP_IOMUXC_I2C4_SDA__I2C4_SDA					0x400001c3
+		>;
+	};
+
+	pinctrl_i2c6: i2c6grp {
+		fsl,pins = <
+			MX8MP_IOMUXC_SAI5_RXFS__I2C6_SCL				0x400001c3
+			MX8MP_IOMUXC_SAI5_RXC__I2C6_SDA					0x400001c3
+		>;
+	};
+
+	pinctrl_pmic: pmicirqgrp {
+		fsl,pins = <
+			MX8MP_IOMUXC_GPIO1_IO03__GPIO1_IO03				0x41
+		>;
+	};
+
+	pinctrl_reg_usdhc2_vmmc: regusdhc2vmmcgrp {
+		fsl,pins = <
+			MX8MP_IOMUXC_SD2_RESET_B__GPIO2_IO19				0x41
+		>;
+	};
+
+	pinctrl_rtc_int: rtcintgrp {
+		fsl,pins = <
+			MX8MP_IOMUXC_SD1_STROBE__GPIO2_IO11				0x140
+		>;
+	};
+
+	pinctrl_uart2: uart2grp {
+		fsl,pins = <
+			MX8MP_IOMUXC_UART2_RXD__UART2_DCE_RX				0x14f
+			MX8MP_IOMUXC_UART2_TXD__UART2_DCE_TX				0x14f
+		>;
+	};
+
+	pinctrl_uart3: uart3grp {
+		fsl,pins = <
+			MX8MP_IOMUXC_UART3_RXD__UART3_DCE_RX				0x49
+			MX8MP_IOMUXC_UART3_TXD__UART3_DCE_TX				0x49
+		>;
+	};
+
+	pinctrl_uart4: uart4grp {
+		fsl,pins = <
+			MX8MP_IOMUXC_UART4_RXD__UART4_DCE_RX				0x49
+			MX8MP_IOMUXC_UART4_TXD__UART4_DCE_TX				0x49
+		>;
+	};
+
+	pinctrl_usb1_vbus: usb1grp {
+		fsl,pins = <
+			MX8MP_IOMUXC_SAI2_TXC__GPIO4_IO25				0x19
+			MX8MP_IOMUXC_SAI2_TXD0__GPIO4_IO26				0x19
+		>;
+	};
+
+	pinctrl_usdhc2: usdhc2grp {
+		fsl,pins = <
+			MX8MP_IOMUXC_SD2_CLK__USDHC2_CLK				0x190
+			MX8MP_IOMUXC_SD2_CMD__USDHC2_CMD				0x1d0
+			MX8MP_IOMUXC_SD2_DATA0__USDHC2_DATA0				0x1d0
+			MX8MP_IOMUXC_SD2_DATA1__USDHC2_DATA1				0x1d0
+			MX8MP_IOMUXC_SD2_DATA2__USDHC2_DATA2				0x1d0
+			MX8MP_IOMUXC_SD2_DATA3__USDHC2_DATA3				0x1d0
+			MX8MP_IOMUXC_GPIO1_IO04__USDHC2_VSELECT				0xc1
+		>;
+	};
+
+	pinctrl_usdhc2_100mhz: usdhc2-100mhzgrp {
+		fsl,pins = <
+			MX8MP_IOMUXC_SD2_CLK__USDHC2_CLK				0x194
+			MX8MP_IOMUXC_SD2_CMD__USDHC2_CMD				0x1d4
+			MX8MP_IOMUXC_SD2_DATA0__USDHC2_DATA0				0x1d4
+			MX8MP_IOMUXC_SD2_DATA1__USDHC2_DATA1				0x1d4
+			MX8MP_IOMUXC_SD2_DATA2__USDHC2_DATA2				0x1d4
+			MX8MP_IOMUXC_SD2_DATA3__USDHC2_DATA3				0x1d4
+			MX8MP_IOMUXC_GPIO1_IO04__USDHC2_VSELECT				0xc1
+		>;
+	};
+
+	pinctrl_usdhc2_200mhz: usdhc2-200mhzgrp {
+		fsl,pins = <
+			MX8MP_IOMUXC_SD2_CLK__USDHC2_CLK				0x196
+			MX8MP_IOMUXC_SD2_CMD__USDHC2_CMD				0x1d6
+			MX8MP_IOMUXC_SD2_DATA0__USDHC2_DATA0				0x1d6
+			MX8MP_IOMUXC_SD2_DATA1__USDHC2_DATA1				0x1d6
+			MX8MP_IOMUXC_SD2_DATA2__USDHC2_DATA2				0x1d6
+			MX8MP_IOMUXC_SD2_DATA3__USDHC2_DATA3				0x1d6
+			MX8MP_IOMUXC_GPIO1_IO04__USDHC2_VSELECT				0xc1
+		>;
+	};
+
+	pinctrl_usdhc2_gpio: usdhc2gpiogrp {
+		fsl,pins = <
+			MX8MP_IOMUXC_SD2_CD_B__GPIO2_IO12				0x1c4
+		>;
+	};
+
+	pinctrl_usdhc3: usdhc3grp {
+		fsl,pins = <
+			MX8MP_IOMUXC_NAND_WE_B__USDHC3_CLK				0x190
+			MX8MP_IOMUXC_NAND_WP_B__USDHC3_CMD				0x1d0
+			MX8MP_IOMUXC_NAND_DATA04__USDHC3_DATA0				0x1d0
+			MX8MP_IOMUXC_NAND_DATA05__USDHC3_DATA1				0x1d0
+			MX8MP_IOMUXC_NAND_DATA06__USDHC3_DATA2				0x1d0
+			MX8MP_IOMUXC_NAND_DATA07__USDHC3_DATA3				0x1d0
+			MX8MP_IOMUXC_NAND_RE_B__USDHC3_DATA4				0x1d0
+			MX8MP_IOMUXC_NAND_CE2_B__USDHC3_DATA5				0x1d0
+			MX8MP_IOMUXC_NAND_CE3_B__USDHC3_DATA6				0x1d0
+			MX8MP_IOMUXC_NAND_CLE__USDHC3_DATA7				0x1d0
+			MX8MP_IOMUXC_NAND_CE1_B__USDHC3_STROBE				0x190
+		>;
+	};
+
+	pinctrl_usdhc3_100mhz: usdhc3-100mhzgrp {
+		fsl,pins = <
+			MX8MP_IOMUXC_NAND_WE_B__USDHC3_CLK				0x194
+			MX8MP_IOMUXC_NAND_WP_B__USDHC3_CMD				0x1d4
+			MX8MP_IOMUXC_NAND_DATA04__USDHC3_DATA0				0x1d4
+			MX8MP_IOMUXC_NAND_DATA05__USDHC3_DATA1				0x1d4
+			MX8MP_IOMUXC_NAND_DATA06__USDHC3_DATA2				0x1d4
+			MX8MP_IOMUXC_NAND_DATA07__USDHC3_DATA3				0x1d4
+			MX8MP_IOMUXC_NAND_RE_B__USDHC3_DATA4				0x1d4
+			MX8MP_IOMUXC_NAND_CE2_B__USDHC3_DATA5				0x1d4
+			MX8MP_IOMUXC_NAND_CE3_B__USDHC3_DATA6				0x1d4
+			MX8MP_IOMUXC_NAND_CLE__USDHC3_DATA7				0x1d4
+			MX8MP_IOMUXC_NAND_CE1_B__USDHC3_STROBE				0x194
+		>;
+	};
+
+	pinctrl_usdhc3_200mhz: usdhc3-200mhzgrp {
+		fsl,pins = <
+			MX8MP_IOMUXC_NAND_WE_B__USDHC3_CLK				0x196
+			MX8MP_IOMUXC_NAND_WP_B__USDHC3_CMD				0x1d6
+			MX8MP_IOMUXC_NAND_DATA04__USDHC3_DATA0				0x1d6
+			MX8MP_IOMUXC_NAND_DATA05__USDHC3_DATA1				0x1d6
+			MX8MP_IOMUXC_NAND_DATA06__USDHC3_DATA2				0x1d6
+			MX8MP_IOMUXC_NAND_DATA07__USDHC3_DATA3				0x1d6
+			MX8MP_IOMUXC_NAND_RE_B__USDHC3_DATA4				0x1d6
+			MX8MP_IOMUXC_NAND_CE2_B__USDHC3_DATA5				0x1d6
+			MX8MP_IOMUXC_NAND_CE3_B__USDHC3_DATA6				0x1d6
+			MX8MP_IOMUXC_NAND_CLE__USDHC3_DATA7				0x1d6
+			MX8MP_IOMUXC_NAND_CE1_B__USDHC3_STROBE				0x196
+		>;
+	};
+
+	pinctrl_wdog: wdoggrp {
+		fsl,pins = <
+			MX8MP_IOMUXC_GPIO1_IO02__WDOG1_WDOG_B				0xc6
+		>;
+	};
+};
+
+&snvs_pwrkey {
+	status = "okay";
+};
+
+&uart2 {
+	/* console */
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_uart2>;
+	status = "okay";
+};
+
+&uart3 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_uart3>;
+	status = "okay";
+};
+
+&uart4 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_uart4>;
+	status = "okay";
+};
+
+/* SD Card */
+&usdhc2 {
+	assigned-clocks = <&clk IMX8MP_CLK_USDHC2>;
+	assigned-clock-rates = <400000000>;
+	pinctrl-names = "default", "state_100mhz", "state_200mhz";
+	pinctrl-0 = <&pinctrl_usdhc2>, <&pinctrl_usdhc2_gpio>;
+	pinctrl-1 = <&pinctrl_usdhc2_100mhz>, <&pinctrl_usdhc2_gpio>;
+	pinctrl-2 = <&pinctrl_usdhc2_200mhz>, <&pinctrl_usdhc2_gpio>;
+	cd-gpios = <&gpio2 12 GPIO_ACTIVE_LOW>;
+	vmmc-supply = <&reg_usdhc2_vmmc>;
+	bus-width = <4>;
+	status = "okay";
+};
+
+/* eMMc */
+&usdhc3 {
+	assigned-clocks = <&clk IMX8MP_CLK_USDHC3>;
+	assigned-clock-rates = <400000000>;
+	pinctrl-names = "default", "state_100mhz", "state_200mhz";
+	pinctrl-0 = <&pinctrl_usdhc3>;
+	pinctrl-1 = <&pinctrl_usdhc3_100mhz>;
+	pinctrl-2 = <&pinctrl_usdhc3_200mhz>;
+	bus-width = <8>;
+	non-removable;
+	status = "okay";
+};
+
+&wdog1 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_wdog>;
+	fsl,ext-reset-output;
+	status = "okay";
+};
Signature · 1 line
2.34.1
#6 lore raw

Re: [PATCH v4 3/3] arm64: dts: Add device tree for the Debix Model A Board

In reply to Daniel Scally

Hello Daniel,

Quoted 2 lines · Daniel Scally

Add a device tree file describing the Debix Model A board from Polyhex Technology Co.

Thanks for your patch. Some minor comments below.

Quoted 5 lines

Changes in v3 (Laurent):

- Added IOB copyright notice
- Removed the eth node for the connector that's on the separate I/O board

I'd have left the FEC node in and described the PHY, but left the FEC disabled. Only the magnetics are on the expansion board, while the PHY is on the base board.

Quoted 7 lines
arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts new file +7 -0
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright 2019 NXP
+ * Copyright 2022 Ideas on Board Oy
+ */
+
+/dts-v1/;

arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts line 17

Quoted 10 lines
arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts new file +10 -0
+
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/leds/common.h>
+#include <dt-bindings/usb/pd.h>
+
+#include "imx8mp.dtsi"
+
+/ {
+	model = "Polyhex Debix Model A i.MX8MPlus board";
+	compatible = "polyhex,imx8mp-debix-model-a", "fsl,imx8mp";

I see that Model A and Model B share the same SoC and PCB. Could you add polyhex,imx8mp-debix as a second compatible? That way, bootloader may match against that compatible when they support both. You'll need to adjust the binding accordingly.

Quoted 49 lines
arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts new file +49 -0
+
+	chosen {
+		stdout-path = &uart2;
+	};
+
+	gpio-leds {
+		compatible = "gpio-leds";
+		pinctrl-names = "default";
+		pinctrl-0 = <&pinctrl_gpio_led>;
+
+		status-led {
+			function = LED_FUNCTION_POWER;
+			color = <LED_COLOR_ID_RED>;
+			gpios = <&gpio3 16 GPIO_ACTIVE_HIGH>;
+			default-state = "on";
+		};
+	};
+
+	reg_usdhc2_vmmc: regulator-usdhc2 {
+		compatible = "regulator-fixed";
+		pinctrl-names = "default";
+		pinctrl-0 = <&pinctrl_reg_usdhc2_vmmc>;
+		regulator-name = "VSD_3V3";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		gpio = <&gpio2 19 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+	};
+};
+
+&A53_0 {
+	cpu-supply = <&buck2>;
+};
+
+&A53_1 {
+	cpu-supply = <&buck2>;
+};
+
+&A53_2 {
+	cpu-supply = <&buck2>;
+};
+
+&A53_3 {
+	cpu-supply = <&buck2>;
+};
+
+&eqos {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_eqos>;

arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts line 76

Quoted 10 lines
arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts new file +10 -0
+	phy-connection-type = "rgmii-id";
+	phy-handle = <&ethphy0>;
+	status = "okay";
+
+	mdio {
+		compatible = "snps,dwmac-mdio";
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		ethphy0: ethernet-phy@0 {

Could you append a /* RTL8211E */ comment here? This can be very useful for others who need to bring up the same chip in the future.

arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts line 78

Quoted 2 lines
arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts new file +2 -0
+			compatible = "ethernet-phy-ieee802.3-c22";
+			reg = <0>;

Is the PHY really at address 0 or does it just answer at this address because it's the broadcast address?

arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts line 243

Quoted 10 lines

+&iomuxc {

arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts new file +9 -0
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_hog>;
+
+	pinctrl_hog: hoggrp {
+		fsl,pins = <
+			MX8MP_IOMUXC_HDMI_DDC_SCL__HDMIMIX_HDMI_SCL			0x400001c3
+			MX8MP_IOMUXC_HDMI_DDC_SDA__HDMIMIX_HDMI_SDA			0x400001c3
+			MX8MP_IOMUXC_HDMI_HPD__HDMIMIX_HDMI_HPD				0x40000019
+			MX8MP_IOMUXC_HDMI_CEC__HDMIMIX_HDMI_CEC				0x40000019

Why do you hog these?

arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts line 370

Quoted 1 line
arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts new file +1 -0
+	pinctrl_usb1_vbus: usb1grp {

This is unused.

arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts line 385

Quoted 9 lines
arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts new file +9 -0
+	pinctrl_usdhc2: usdhc2grp {
+		fsl,pins = <
+			MX8MP_IOMUXC_SD2_CLK__USDHC2_CLK				0x190
+			MX8MP_IOMUXC_SD2_CMD__USDHC2_CMD				0x1d0
+			MX8MP_IOMUXC_SD2_DATA0__USDHC2_DATA0				0x1d0
+			MX8MP_IOMUXC_SD2_DATA1__USDHC2_DATA1				0x1d0
+			MX8MP_IOMUXC_SD2_DATA2__USDHC2_DATA2				0x1d0
+			MX8MP_IOMUXC_SD2_DATA3__USDHC2_DATA3				0x1d0
+			MX8MP_IOMUXC_GPIO1_IO04__USDHC2_VSELECT				0xc1

Just to make sure this doesn't fry SD-Cards by mistake: VSELECT is indeed connected to a 1.8V/3.3V switch powering vqmmc?

arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts line 500

Quoted 4 lines
arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts new file +4 -0
+/* SD Card */
+&usdhc2 {
+	assigned-clocks = <&clk IMX8MP_CLK_USDHC2>;
+	assigned-clock-rates = <400000000>;

I wonder why this is necessary. Do you see a difference in /sys/kernel/debug/mmcX/ios between having this and leaving it out?

arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts line 511

Quoted 4 lines
arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts new file +4 -0
+	status = "okay";
+};
+
+/* eMMc */

eMMC

Quoted 8 lines

+&usdhc3 {

arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts new file +7 -0
+	assigned-clocks = <&clk IMX8MP_CLK_USDHC3>;
+	assigned-clock-rates = <400000000>;
+	pinctrl-names = "default", "state_100mhz", "state_200mhz";
+	pinctrl-0 = <&pinctrl_usdhc3>;
+	pinctrl-1 = <&pinctrl_usdhc3_100mhz>;
+	pinctrl-2 = <&pinctrl_usdhc3_200mhz>;
+	bus-width = <8>;

arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts line 529

Quoted 10 lines
arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts new file +10 -0
+	non-removable;
+	status = "okay";
+};
+
+&wdog1 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_wdog>;
+	fsl,ext-reset-output;
+	status = "okay";
+};

Cheers,
Ahmad

Signature · 4 lines
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
#7 lore raw

Re: [PATCH v4 3/3] arm64: dts: Add device tree for the Debix Model A Board

Quoting Ahmad Fatoum (2022-12-01 17:10:20)

Quoted 32 lines

Hello Daniel,

Quoted 2 lines · Daniel Scally

Add a device tree file describing the Debix Model A board from Polyhex Technology Co.

Thanks for your patch. Some minor comments below.

Quoted 5 lines

Changes in v3 (Laurent):

- Added IOB copyright notice
- Removed the eth node for the connector that's on the separate I/O board

I'd have left the FEC node in and described the PHY, but left the FEC disabled. Only the magnetics are on the expansion board, while the PHY is on the base board.

Quoted 14 lines
arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts new file +14 -0
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright 2019 NXP
+ * Copyright 2022 Ideas on Board Oy
+ */
+
+/dts-v1/;
+
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/leds/common.h>
+#include <dt-bindings/usb/pd.h>
+
+#include "imx8mp.dtsi"
+
Quoted 8 lines

arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts line 17

Quoted 3 lines
arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts new file +3 -0
+/ {
+     model = "Polyhex Debix Model A i.MX8MPlus board";
+     compatible = "polyhex,imx8mp-debix-model-a", "fsl,imx8mp";

I see that Model A and Model B share the same SoC and PCB. Could you add polyhex,imx8mp-debix as a second compatible? That way, bootloader may match against that compatible when they support both. You'll need to adjust the binding accordingly.

Polyhex also make a SOM with the brand DEBIX.
- https://debix.io/hardware/debix-som-a-io-board.html

But perhaps it will be fine, as that will be "polyhex,imx8mp-debix-som" (and perhaps they'll do an A/B variant too?)

--
Kieran

Quoted 146 lines
Quoted 50 lines
arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts new file +49 -0
+
+     chosen {
+             stdout-path = &uart2;
+     };
+
+     gpio-leds {
+             compatible = "gpio-leds";
+             pinctrl-names = "default";
+             pinctrl-0 = <&pinctrl_gpio_led>;
+
+             status-led {
+                     function = LED_FUNCTION_POWER;
+                     color = <LED_COLOR_ID_RED>;
+                     gpios = <&gpio3 16 GPIO_ACTIVE_HIGH>;
+                     default-state = "on";
+             };
+     };
+
+     reg_usdhc2_vmmc: regulator-usdhc2 {
+             compatible = "regulator-fixed";
+             pinctrl-names = "default";
+             pinctrl-0 = <&pinctrl_reg_usdhc2_vmmc>;
+             regulator-name = "VSD_3V3";
+             regulator-min-microvolt = <3300000>;
+             regulator-max-microvolt = <3300000>;
+             gpio = <&gpio2 19 GPIO_ACTIVE_HIGH>;
+             enable-active-high;
+     };
+};
+
+&A53_0 {
+     cpu-supply = <&buck2>;
+};
+
+&A53_1 {
+     cpu-supply = <&buck2>;
+};
+
+&A53_2 {
+     cpu-supply = <&buck2>;
+};
+
+&A53_3 {
+     cpu-supply = <&buck2>;
+};
+
+&eqos {
+     pinctrl-names = "default";
+     pinctrl-0 = <&pinctrl_eqos>;

arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts line 76

Quoted 10 lines
arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts new file +10 -0
+     phy-connection-type = "rgmii-id";
+     phy-handle = <&ethphy0>;
+     status = "okay";
+
+     mdio {
+             compatible = "snps,dwmac-mdio";
+             #address-cells = <1>;
+             #size-cells = <0>;
+
+             ethphy0: ethernet-phy@0 {

Could you append a /* RTL8211E */ comment here? This can be very useful for others who need to bring up the same chip in the future.

arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts line 78

Quoted 2 lines
arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts new file +2 -0
+                     compatible = "ethernet-phy-ieee802.3-c22";
+                     reg = <0>;

Is the PHY really at address 0 or does it just answer at this address because it's the broadcast address?

arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts line 243

Quoted 10 lines

+&iomuxc {

arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts new file +9 -0
+     pinctrl-names = "default";
+     pinctrl-0 = <&pinctrl_hog>;
+
+     pinctrl_hog: hoggrp {
+             fsl,pins = <
+                     MX8MP_IOMUXC_HDMI_DDC_SCL__HDMIMIX_HDMI_SCL                     0x400001c3
+                     MX8MP_IOMUXC_HDMI_DDC_SDA__HDMIMIX_HDMI_SDA                     0x400001c3
+                     MX8MP_IOMUXC_HDMI_HPD__HDMIMIX_HDMI_HPD                         0x40000019
+                     MX8MP_IOMUXC_HDMI_CEC__HDMIMIX_HDMI_CEC                         0x40000019

Why do you hog these?

Quoted 1 line

+ pinctrl_usb1_vbus: usb1grp {

This is unused.

arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts line 385

Quoted 9 lines
arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts new file +9 -0
+     pinctrl_usdhc2: usdhc2grp {
+             fsl,pins = <
+                     MX8MP_IOMUXC_SD2_CLK__USDHC2_CLK                                0x190
+                     MX8MP_IOMUXC_SD2_CMD__USDHC2_CMD                                0x1d0
+                     MX8MP_IOMUXC_SD2_DATA0__USDHC2_DATA0                            0x1d0
+                     MX8MP_IOMUXC_SD2_DATA1__USDHC2_DATA1                            0x1d0
+                     MX8MP_IOMUXC_SD2_DATA2__USDHC2_DATA2                            0x1d0
+                     MX8MP_IOMUXC_SD2_DATA3__USDHC2_DATA3                            0x1d0
+                     MX8MP_IOMUXC_GPIO1_IO04__USDHC2_VSELECT                         0xc1

Just to make sure this doesn't fry SD-Cards by mistake: VSELECT is indeed connected to a 1.8V/3.3V switch powering vqmmc?

arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts line 500

Quoted 4 lines
arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts new file +4 -0
+/* SD Card */
+&usdhc2 {
+     assigned-clocks = <&clk IMX8MP_CLK_USDHC2>;
+     assigned-clock-rates = <400000000>;

I wonder why this is necessary. Do you see a difference in /sys/kernel/debug/mmcX/ios between having this and leaving it out?

arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts line 511

Quoted 4 lines
arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts new file +4 -0
+     status = "okay";
+};
+
+/* eMMc */

eMMC

Quoted 8 lines

+&usdhc3 {

arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts new file +7 -0
+     assigned-clocks = <&clk IMX8MP_CLK_USDHC3>;
+     assigned-clock-rates = <400000000>;
+     pinctrl-names = "default", "state_100mhz", "state_200mhz";
+     pinctrl-0 = <&pinctrl_usdhc3>;
+     pinctrl-1 = <&pinctrl_usdhc3_100mhz>;
+     pinctrl-2 = <&pinctrl_usdhc3_200mhz>;
+     bus-width = <8>;

arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts line 529

Quoted 10 lines
arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts new file +10 -0
+     non-removable;
+     status = "okay";
+};
+
+&wdog1 {
+     pinctrl-names = "default";
+     pinctrl-0 = <&pinctrl_wdog>;
+     fsl,ext-reset-output;
+     status = "okay";
+};

Cheers,
Ahmad

Signature · 4 lines
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
author
#8 lore raw

Re: [PATCH v4 3/3] arm64: dts: Add device tree for the Debix Model A Board

In reply to Ahmad Fatoum

Hi Ahmad - thanks for the review

Quoted 7 lines · Ahmad Fatoum

Hello Daniel,

Quoted 2 lines · Daniel Scally

Add a device tree file describing the Debix Model A board from Polyhex Technology Co.

Thanks for your patch. Some minor comments below.

Quoted 8 lines
Quoted 5 lines

Changes in v3 (Laurent):

- Added IOB copyright notice
- Removed the eth node for the connector that's on the separate I/O board

I'd have left the FEC node in and described the PHY, but left the FEC disabled. Only the magnetics are on the expansion board, while the PHY is on the base board.

Fair enough, though there's quite a lot else on the base board which we've left off simply because we're not currently using it. I'm inclined to treat this the same for now.

Quoted 13 lines
Quoted 13 lines
arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts new file +13 -0
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright 2019 NXP
+ * Copyright 2022 Ideas on Board Oy
+ */
+
+/dts-v1/;
+
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/leds/common.h>
+#include <dt-bindings/usb/pd.h>
+
+#include "imx8mp.dtsi"
Quoted 8 lines

arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts line 17

Quoted 4 lines
arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts new file +4 -0
+
+/ {
+	model = "Polyhex Debix Model A i.MX8MPlus board";
+	compatible = "polyhex,imx8mp-debix-model-a", "fsl,imx8mp";

I see that Model A and Model B share the same SoC and PCB. Could you add polyhex,imx8mp-debix as a second compatible? That way, bootloader may match against that compatible when they support both. You'll need to adjust the binding accordingly.

Sure, makes sense to me

Quoted 54 lines
Quoted 54 lines
arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts new file +53 -0
+
+	chosen {
+		stdout-path = &uart2;
+	};
+
+	gpio-leds {
+		compatible = "gpio-leds";
+		pinctrl-names = "default";
+		pinctrl-0 = <&pinctrl_gpio_led>;
+
+		status-led {
+			function = LED_FUNCTION_POWER;
+			color = <LED_COLOR_ID_RED>;
+			gpios = <&gpio3 16 GPIO_ACTIVE_HIGH>;
+			default-state = "on";
+		};
+	};
+
+	reg_usdhc2_vmmc: regulator-usdhc2 {
+		compatible = "regulator-fixed";
+		pinctrl-names = "default";
+		pinctrl-0 = <&pinctrl_reg_usdhc2_vmmc>;
+		regulator-name = "VSD_3V3";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		gpio = <&gpio2 19 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+	};
+};
+
+&A53_0 {
+	cpu-supply = <&buck2>;
+};
+
+&A53_1 {
+	cpu-supply = <&buck2>;
+};
+
+&A53_2 {
+	cpu-supply = <&buck2>;
+};
+
+&A53_3 {
+	cpu-supply = <&buck2>;
+};
+
+&eqos {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_eqos>;
+	phy-connection-type = "rgmii-id";
+	phy-handle = <&ethphy0>;
+	status = "okay";
+
Quoted 8 lines

arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts line 76

Quoted 6 lines
arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts new file +6 -0
+	mdio {
+		compatible = "snps,dwmac-mdio";
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		ethphy0: ethernet-phy@0 {

Could you append a /* RTL8211E */ comment here? This can be very useful for others who need to bring up the same chip in the future.

Sure

Quoted 5 lines

arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts line 78

Quoted 3 lines
arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts new file +2 -0
+			compatible = "ethernet-phy-ieee802.3-c22";
+			reg = <0>;

Is the PHY really at address 0 or does it just answer at this address because it's the broadcast address?

I confess I'm unsure here, the number here comes from the downstream .dts, which in this instance I've trusted...is there any way I can check?

Quoted 14 lines

arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts line 243

Quoted 12 lines

+&iomuxc {

arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts new file +9 -0
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_hog>;
+
+	pinctrl_hog: hoggrp {
+		fsl,pins = <
+			MX8MP_IOMUXC_HDMI_DDC_SCL__HDMIMIX_HDMI_SCL			0x400001c3
+			MX8MP_IOMUXC_HDMI_DDC_SDA__HDMIMIX_HDMI_SDA			0x400001c3
+			MX8MP_IOMUXC_HDMI_HPD__HDMIMIX_HDMI_HPD				0x40000019
+			MX8MP_IOMUXC_HDMI_CEC__HDMIMIX_HDMI_CEC				0x40000019

Why do you hog these?

Quoted 2 lines

arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts line 370

Quoted 1 line
arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts new file +1 -0
+	pinctrl_usb1_vbus: usb1grp {

This is unused.

Ah both for other elements of the board which aren't included in this set, as they don't work properly yet. Apologies; I'll remove those.

Quoted 13 lines

arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts line 385

Quoted 10 lines
arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts new file +9 -0
+	pinctrl_usdhc2: usdhc2grp {
+		fsl,pins = <
+			MX8MP_IOMUXC_SD2_CLK__USDHC2_CLK				0x190
+			MX8MP_IOMUXC_SD2_CMD__USDHC2_CMD				0x1d0
+			MX8MP_IOMUXC_SD2_DATA0__USDHC2_DATA0				0x1d0
+			MX8MP_IOMUXC_SD2_DATA1__USDHC2_DATA1				0x1d0
+			MX8MP_IOMUXC_SD2_DATA2__USDHC2_DATA2				0x1d0
+			MX8MP_IOMUXC_SD2_DATA3__USDHC2_DATA3				0x1d0
+			MX8MP_IOMUXC_GPIO1_IO04__USDHC2_VSELECT				0xc1

Just to make sure this doesn't fry SD-Cards by mistake: VSELECT is indeed connected to a 1.8V/3.3V switch powering vqmmc?

Quoted 7 lines

arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts line 500

Quoted 4 lines
arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts new file +4 -0
+/* SD Card */
+&usdhc2 {
+	assigned-clocks = <&clk IMX8MP_CLK_USDHC2>;
+	assigned-clock-rates = <400000000>;

I wonder why this is necessary. Do you see a difference in /sys/kernel/debug/mmcX/ios between having this and leaving it out?

I don't actually...it's present in the imx8mp-evk.dts which this is based on, but in addition to not seeing any difference there the SD card still seems fine as far as I can tell (same read / write speed in practice) - I'll take it out, thanks

Quoted 6 lines

arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts line 511

Quoted 5 lines
arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts new file +4 -0
+	status = "okay";
+};
+
+/* eMMc */

eMMC

Ack

Quoted 22 lines
Quoted 8 lines

+&usdhc3 {

arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts new file +7 -0
+	assigned-clocks = <&clk IMX8MP_CLK_USDHC3>;
+	assigned-clock-rates = <400000000>;
+	pinctrl-names = "default", "state_100mhz", "state_200mhz";
+	pinctrl-0 = <&pinctrl_usdhc3>;
+	pinctrl-1 = <&pinctrl_usdhc3_100mhz>;
+	pinctrl-2 = <&pinctrl_usdhc3_200mhz>;
+	bus-width = <8>;

arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts line 529

Quoted 10 lines
arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts new file +10 -0
+	non-removable;
+	status = "okay";
+};
+
+&wdog1 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_wdog>;
+	fsl,ext-reset-output;
+	status = "okay";
+};

Cheers,
Ahmad

#9 lore raw

Re: [PATCH v4 3/3] arm64: dts: Add device tree for the Debix Model A Board

Quoted 16 lines · Dan Scally

Hi Ahmad - thanks for the review

Quoted 13 lines · Ahmad Fatoum

Hello Daniel,

Quoted 2 lines · Daniel Scally

Add a device tree file describing the Debix Model A board from Polyhex Technology Co.

Thanks for your patch. Some minor comments below.

Quoted 5 lines

Changes in v3 (Laurent):

- Added IOB copyright notice
- Removed the eth node for the connector that's on the separate I/O board

Quoted 7 lines
Quoted 3 lines

I'd have left the FEC node in and described the PHY, but left the FEC disabled. Only the magnetics are on the expansion board, while the PHY is on the base board.

Fair enough, though there's quite a lot else on the base board which we've left off simply because we're not currently using it. I'm inclined to treat this the same for now.

Overall I think it's a good strategy, if we haven't tested a peripheral we shouldn't include it yet. Missing pieces can be added later. Of course if there are pieces that are easy to test already, we can include them.

Quoted 173 lines
Quoted 14 lines
Quoted 14 lines
arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts new file +14 -0
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright 2019 NXP
+ * Copyright 2022 Ideas on Board Oy
+ */
+
+/dts-v1/;
+
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/leds/common.h>
+#include <dt-bindings/usb/pd.h>
+
+#include "imx8mp.dtsi"
+
Quoted 8 lines

arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts line 17

Quoted 3 lines
arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts new file +3 -0
+/ {
+	model = "Polyhex Debix Model A i.MX8MPlus board";
+	compatible = "polyhex,imx8mp-debix-model-a", "fsl,imx8mp";

I see that Model A and Model B share the same SoC and PCB. Could you add polyhex,imx8mp-debix as a second compatible? That way, bootloader may match against that compatible when they support both. You'll need to adjust the binding accordingly.

Sure, makes sense to me

Quoted 54 lines
Quoted 54 lines
arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts new file +54 -0
+
+	chosen {
+		stdout-path = &uart2;
+	};
+
+	gpio-leds {
+		compatible = "gpio-leds";
+		pinctrl-names = "default";
+		pinctrl-0 = <&pinctrl_gpio_led>;
+
+		status-led {
+			function = LED_FUNCTION_POWER;
+			color = <LED_COLOR_ID_RED>;
+			gpios = <&gpio3 16 GPIO_ACTIVE_HIGH>;
+			default-state = "on";
+		};
+	};
+
+	reg_usdhc2_vmmc: regulator-usdhc2 {
+		compatible = "regulator-fixed";
+		pinctrl-names = "default";
+		pinctrl-0 = <&pinctrl_reg_usdhc2_vmmc>;
+		regulator-name = "VSD_3V3";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		gpio = <&gpio2 19 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+	};
+};
+
+&A53_0 {
+	cpu-supply = <&buck2>;
+};
+
+&A53_1 {
+	cpu-supply = <&buck2>;
+};
+
+&A53_2 {
+	cpu-supply = <&buck2>;
+};
+
+&A53_3 {
+	cpu-supply = <&buck2>;
+};
+
+&eqos {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_eqos>;
+	phy-connection-type = "rgmii-id";
+	phy-handle = <&ethphy0>;
+	status = "okay";
+
+	mdio {
Quoted 8 lines

arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts line 76

Quoted 5 lines
arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts new file +5 -0
+		compatible = "snps,dwmac-mdio";
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		ethphy0: ethernet-phy@0 {

Could you append a /* RTL8211E */ comment here? This can be very useful for others who need to bring up the same chip in the future.

Sure

Quoted 5 lines

arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts line 78

Quoted 2 lines
arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts new file +2 -0
+			compatible = "ethernet-phy-ieee802.3-c22";
+			reg = <0>;

Is the PHY really at address 0 or does it just answer at this address because it's the broadcast address?

I confess I'm unsure here, the number here comes from the downstream .dts, which in this instance I've trusted...is there any way I can check?

Quoted 13 lines

arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts line 243

Quoted 10 lines

+&iomuxc {

arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts new file +9 -0
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_hog>;
+
+	pinctrl_hog: hoggrp {
+		fsl,pins = <
+			MX8MP_IOMUXC_HDMI_DDC_SCL__HDMIMIX_HDMI_SCL			0x400001c3
+			MX8MP_IOMUXC_HDMI_DDC_SDA__HDMIMIX_HDMI_SDA			0x400001c3
+			MX8MP_IOMUXC_HDMI_HPD__HDMIMIX_HDMI_HPD				0x40000019
+			MX8MP_IOMUXC_HDMI_CEC__HDMIMIX_HDMI_CEC				0x40000019

Why do you hog these?

Quoted 3 lines

arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts line 370

Quoted 1 line
arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts new file +1 -0
+	pinctrl_usb1_vbus: usb1grp {

This is unused.

Ah both for other elements of the board which aren't included in this set, as they don't work properly yet. Apologies; I'll remove those.

Quoted 13 lines

arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts line 385

Quoted 9 lines
arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts new file +9 -0
+	pinctrl_usdhc2: usdhc2grp {
+		fsl,pins = <
+			MX8MP_IOMUXC_SD2_CLK__USDHC2_CLK				0x190
+			MX8MP_IOMUXC_SD2_CMD__USDHC2_CMD				0x1d0
+			MX8MP_IOMUXC_SD2_DATA0__USDHC2_DATA0				0x1d0
+			MX8MP_IOMUXC_SD2_DATA1__USDHC2_DATA1				0x1d0
+			MX8MP_IOMUXC_SD2_DATA2__USDHC2_DATA2				0x1d0
+			MX8MP_IOMUXC_SD2_DATA3__USDHC2_DATA3				0x1d0
+			MX8MP_IOMUXC_GPIO1_IO04__USDHC2_VSELECT				0xc1

Just to make sure this doesn't fry SD-Cards by mistake: VSELECT is indeed connected to a 1.8V/3.3V switch powering vqmmc?

Quoted 8 lines

arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts line 500

Quoted 4 lines
arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts new file +4 -0
+/* SD Card */
+&usdhc2 {
+	assigned-clocks = <&clk IMX8MP_CLK_USDHC2>;
+	assigned-clock-rates = <400000000>;

I wonder why this is necessary. Do you see a difference in /sys/kernel/debug/mmcX/ios between having this and leaving it out?

I don't actually...it's present in the imx8mp-evk.dts which this is based on, but in addition to not seeing any difference there the SD card still seems fine as far as I can tell (same read / write speed in practice) - I'll take it out, thanks

Quoted 6 lines

arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts line 511

Quoted 4 lines
arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts new file +4 -0
+	status = "okay";
+};
+
+/* eMMc */

eMMC

Ack

Quoted 18 lines
Quoted 18 lines

+&usdhc3 {

arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts new file +17 -0
+	assigned-clocks = <&clk IMX8MP_CLK_USDHC3>;
+	assigned-clock-rates = <400000000>;
+	pinctrl-names = "default", "state_100mhz", "state_200mhz";
+	pinctrl-0 = <&pinctrl_usdhc3>;
+	pinctrl-1 = <&pinctrl_usdhc3_100mhz>;
+	pinctrl-2 = <&pinctrl_usdhc3_200mhz>;
+	bus-width = <8>;
+	non-removable;
+	status = "okay";
+};
+
+&wdog1 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_wdog>;
+	fsl,ext-reset-output;
+	status = "okay";
+};
Signature · 3 lines
Regards,

Laurent Pinchart
#10 lore raw

Re: [PATCH v4 3/3] arm64: dts: Add device tree for the Debix Model A Board

Hello Laurent, Dan,

Quoted 21 lines · Laurent Pinchart
Quoted 20 lines · Dan Scally

Hi Ahmad - thanks for the review

Quoted 16 lines · Ahmad Fatoum

Hello Daniel,

Quoted 2 lines · Daniel Scally

Add a device tree file describing the Debix Model A board from Polyhex Technology Co.

Thanks for your patch. Some minor comments below.

Quoted 5 lines

Changes in v3 (Laurent):

- Added IOB copyright notice
- Removed the eth node for the connector that's on the separate I/O board

I'd have left the FEC node in and described the PHY, but left the FEC disabled. Only the magnetics are on the expansion board, while the PHY is on the base board.

Quoted 8 lines
Quoted 3 lines

Fair enough, though there's quite a lot else on the base board which we've left off simply because we're not currently using it. I'm inclined to treat this the same for now.

Overall I think it's a good strategy, if we haven't tested a peripheral we shouldn't include it yet. Missing pieces can be added later. Of course if there are pieces that are easy to test already, we can include them.

I generally agree, but I tested the FEC with the magnetics on the I/O board and the DT description from the older patch set worked correctly.

Cheers,
Ahmad

Quoted 175 lines
Quoted 174 lines
Quoted 15 lines
Quoted 15 lines
arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts new file +14 -0
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright 2019 NXP
+ * Copyright 2022 Ideas on Board Oy
+ */
+
+/dts-v1/;
+
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/leds/common.h>
+#include <dt-bindings/usb/pd.h>
+
+#include "imx8mp.dtsi"
+
Quoted 8 lines

arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts line 17

Quoted 3 lines
arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts new file +3 -0
+/ {
+	model = "Polyhex Debix Model A i.MX8MPlus board";
+	compatible = "polyhex,imx8mp-debix-model-a", "fsl,imx8mp";

I see that Model A and Model B share the same SoC and PCB. Could you add polyhex,imx8mp-debix as a second compatible? That way, bootloader may match against that compatible when they support both. You'll need to adjust the binding accordingly.

Sure, makes sense to me

Quoted 54 lines
Quoted 54 lines
arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts new file +54 -0
+
+	chosen {
+		stdout-path = &uart2;
+	};
+
+	gpio-leds {
+		compatible = "gpio-leds";
+		pinctrl-names = "default";
+		pinctrl-0 = <&pinctrl_gpio_led>;
+
+		status-led {
+			function = LED_FUNCTION_POWER;
+			color = <LED_COLOR_ID_RED>;
+			gpios = <&gpio3 16 GPIO_ACTIVE_HIGH>;
+			default-state = "on";
+		};
+	};
+
+	reg_usdhc2_vmmc: regulator-usdhc2 {
+		compatible = "regulator-fixed";
+		pinctrl-names = "default";
+		pinctrl-0 = <&pinctrl_reg_usdhc2_vmmc>;
+		regulator-name = "VSD_3V3";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		gpio = <&gpio2 19 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+	};
+};
+
+&A53_0 {
+	cpu-supply = <&buck2>;
+};
+
+&A53_1 {
+	cpu-supply = <&buck2>;
+};
+
+&A53_2 {
+	cpu-supply = <&buck2>;
+};
+
+&A53_3 {
+	cpu-supply = <&buck2>;
+};
+
+&eqos {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_eqos>;
+	phy-connection-type = "rgmii-id";
+	phy-handle = <&ethphy0>;
+	status = "okay";
+
+	mdio {
Quoted 8 lines

arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts line 76

Quoted 5 lines
arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts new file +5 -0
+		compatible = "snps,dwmac-mdio";
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		ethphy0: ethernet-phy@0 {

Could you append a /* RTL8211E */ comment here? This can be very useful for others who need to bring up the same chip in the future.

Sure

Quoted 5 lines

arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts line 78

Quoted 2 lines
arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts new file +2 -0
+			compatible = "ethernet-phy-ieee802.3-c22";
+			reg = <0>;

Is the PHY really at address 0 or does it just answer at this address because it's the broadcast address?

I confess I'm unsure here, the number here comes from the downstream .dts, which in this instance I've trusted...is there any way I can check?

Quoted 13 lines

arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts line 243

Quoted 10 lines

+&iomuxc {

arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts new file +9 -0
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_hog>;
+
+	pinctrl_hog: hoggrp {
+		fsl,pins = <
+			MX8MP_IOMUXC_HDMI_DDC_SCL__HDMIMIX_HDMI_SCL			0x400001c3
+			MX8MP_IOMUXC_HDMI_DDC_SDA__HDMIMIX_HDMI_SDA			0x400001c3
+			MX8MP_IOMUXC_HDMI_HPD__HDMIMIX_HDMI_HPD				0x40000019
+			MX8MP_IOMUXC_HDMI_CEC__HDMIMIX_HDMI_CEC				0x40000019

Why do you hog these?

Quoted 3 lines

arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts line 370

Quoted 1 line
arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts new file +1 -0
+	pinctrl_usb1_vbus: usb1grp {

This is unused.

Ah both for other elements of the board which aren't included in this set, as they don't work properly yet. Apologies; I'll remove those.

Quoted 13 lines

arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts line 385

Quoted 9 lines
arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts new file +9 -0
+	pinctrl_usdhc2: usdhc2grp {
+		fsl,pins = <
+			MX8MP_IOMUXC_SD2_CLK__USDHC2_CLK				0x190
+			MX8MP_IOMUXC_SD2_CMD__USDHC2_CMD				0x1d0
+			MX8MP_IOMUXC_SD2_DATA0__USDHC2_DATA0				0x1d0
+			MX8MP_IOMUXC_SD2_DATA1__USDHC2_DATA1				0x1d0
+			MX8MP_IOMUXC_SD2_DATA2__USDHC2_DATA2				0x1d0
+			MX8MP_IOMUXC_SD2_DATA3__USDHC2_DATA3				0x1d0
+			MX8MP_IOMUXC_GPIO1_IO04__USDHC2_VSELECT				0xc1

Just to make sure this doesn't fry SD-Cards by mistake: VSELECT is indeed connected to a 1.8V/3.3V switch powering vqmmc?

Quoted 8 lines

arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts line 500

Quoted 4 lines
arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts new file +4 -0
+/* SD Card */
+&usdhc2 {
+	assigned-clocks = <&clk IMX8MP_CLK_USDHC2>;
+	assigned-clock-rates = <400000000>;

I wonder why this is necessary. Do you see a difference in /sys/kernel/debug/mmcX/ios between having this and leaving it out?

I don't actually...it's present in the imx8mp-evk.dts which this is based on, but in addition to not seeing any difference there the SD card still seems fine as far as I can tell (same read / write speed in practice) - I'll take it out, thanks

Quoted 6 lines

arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts line 511

Quoted 4 lines
arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts new file +4 -0
+	status = "okay";
+};
+
+/* eMMc */

eMMC

Ack

Quoted 18 lines
Quoted 18 lines

+&usdhc3 {

arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts new file +17 -0
+	assigned-clocks = <&clk IMX8MP_CLK_USDHC3>;
+	assigned-clock-rates = <400000000>;
+	pinctrl-names = "default", "state_100mhz", "state_200mhz";
+	pinctrl-0 = <&pinctrl_usdhc3>;
+	pinctrl-1 = <&pinctrl_usdhc3_100mhz>;
+	pinctrl-2 = <&pinctrl_usdhc3_200mhz>;
+	bus-width = <8>;
+	non-removable;
+	status = "okay";
+};
+
+&wdog1 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_wdog>;
+	fsl,ext-reset-output;
+	status = "okay";
+};
Signature · 4 lines
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |