Skip to contentSkip to conversation

PWM and keyboard backlight driver for ARM Macs

PATCH Superseded Sasha Finkelstein 4 participants 14 messages Oct 28, 2022 – Oct 29, 2022

Subsystems (3)

v1 of 9 Superseded Latest is v9 →

lore
Share & tools
lore
#0 lore raw

cover PWM and keyboard backlight driver for ARM Macs

Hi,

This series adds support for the PWM controller present on ARM Macs and used among other things for the keyboard backlight on those laptops.

The included device tree patch also hooks up the keyboard backlight using the pwm-leds binding.

Best Regards.

Sasha Finkelstein (4):
dt-bindings: pwm: Add Apple PWM controller
pwm: Add Apple PWM controller
arm64: dts: apple: t8103: Add PWM controller
MAINTAINERS: Add entries for Apple PWM driver

 Documentation/devicetree/bindings/pwm/pwm-apple.yaml |  51 +++++++++++++
 MAINTAINERS                                          |   2 ++
 arch/arm64/boot/dts/apple/t8103-j293.dts             |  20 ++++++++
 arch/arm64/boot/dts/apple/t8103-j313.dts             |  20 ++++++++
 arch/arm64/boot/dts/apple/t8103.dtsi                 |   9 ++++
 drivers/pwm/Kconfig                                  |  12 ++++
 drivers/pwm/Makefile                                 |   1 +
 drivers/pwm/pwm-apple.c                              | 124 +++++++++++++++++++
 8 files changed, 239 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/pwm/pwm-apple.yaml
 create mode 100644 drivers/pwm/pwm-apple.c
#1 lore raw

PATCH 1/4 dt-bindings: pwm: Add Apple PWM controller

Apple SoCs such as the M1 contain a PWM controller used among other things to control the keyboard backlight.

---
 .../devicetree/bindings/pwm/pwm-apple.yaml    | 51 +++++++++++++++++++
 1 file changed, 51 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/pwm/pwm-apple.yaml
Documentation/devicetree/bindings/pwm/pwm-apple.yaml new file +51 -0
new file mode 100644
index 000000000000..39dc32e00a3f
@@ -0,0 +1,51 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/pwm/pwm-apple.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Apple FPWM controller
+
+maintainers:
+  - [email protected]
+  - Sasha Finkelstein <[email protected]>
+
+description: |+
+  PWM controller used for keyboard backlight on ARM Macs
+
+properties:
+  compatible:
+    items:
+      - enum:
+          - apple,t8103-fpwm
+          - apple,t6000-fpwm
+          - apple,t8112-fpwm
+      - const: apple,s5l-fpwm
+  reg:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+
+  power-domains:
+    maxItems: 1
+
+  "#pwm-cells":
+    const: 2
+
+required:
+  - compatible
+  - reg
+  - clocks
+
+additionalProperties: false
+
+examples:
+  - |
+    pwm: fpwm@235044000 {
+      compatible = "apple,s5l-fpwm";
+      reg = <0x2 0x35044000 0x0 0x4000>;
+      power-domains = <&ps_fpwm1>;
+      clocks = <&clkref>;
+      #pwm-cells = <2>;
+    };
Signature · 1 line
2.37.3
#2 lore raw

Re: [PATCH 1/4] dt-bindings: pwm: Add Apple PWM controller

Documentation/devicetree/bindings/pwm/pwm-apple.yaml

Quoted 14 lines · Sasha Finkelstein

Apple SoCs such as the M1 contain a PWM controller used among other things to control the keyboard backlight.

---
 .../devicetree/bindings/pwm/pwm-apple.yaml    | 51 +++++++++++++++++++
 1 file changed, 51 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/pwm/pwm-apple.yaml
Documentation/devicetree/bindings/pwm/pwm-apple.yaml new file +0 -0
new file mode 100644
index 000000000000..39dc32e00a3f

Filename matching compatible, so apple,s5l-fpwm.yaml

Quoted 4 lines
Documentation/devicetree/bindings/pwm/pwm-apple.yaml new file +3 -0
@@ -0,0 +1,51 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---

Documentation/devicetree/bindings/pwm/pwm-apple.yaml line 13

Quoted 10 lines
Documentation/devicetree/bindings/pwm/pwm-apple.yaml new file +10 -0
+$id: http://devicetree.org/schemas/pwm/pwm-apple.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Apple FPWM controller
+
+maintainers:
+  - [email protected]
+  - Sasha Finkelstein <[email protected]>
+
+description: |+

Drop |+

Documentation/devicetree/bindings/pwm/pwm-apple.yaml line 23

Quoted 10 lines
Documentation/devicetree/bindings/pwm/pwm-apple.yaml new file +10 -0
+  PWM controller used for keyboard backlight on ARM Macs
+
+properties:
+  compatible:
+    items:
+      - enum:
+          - apple,t8103-fpwm
+          - apple,t6000-fpwm
+          - apple,t8112-fpwm
+      - const: apple,s5l-fpwm

Is it then derived from Samsung platform? If yes, it is candidate for merging.

Quoted 12 lines
Documentation/devicetree/bindings/pwm/pwm-apple.yaml new file +12 -0
+  reg:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+
+  power-domains:
+    maxItems: 1
+
+  "#pwm-cells":
+    const: 2
+

Documentation/devicetree/bindings/pwm/pwm-apple.yaml line 45

Quoted 10 lines
Documentation/devicetree/bindings/pwm/pwm-apple.yaml new file +10 -0
+required:
+  - compatible
+  - reg
+  - clocks
+
+additionalProperties: false
+
+examples:
+  - |
+    pwm: fpwm@235044000 {

Generic node name, so just "pwm". Drop also label - it's not used in the example.

Best regards,
Krzysztof

#3 lore raw

Re: [PATCH 1/4] dt-bindings: pwm: Add Apple PWM controller

Quoted 15 lines · Krzysztof Kozlowski

Documentation/devicetree/bindings/pwm/pwm-apple.yaml line 23

Quoted 10 lines · Sasha Finkelstein
Documentation/devicetree/bindings/pwm/pwm-apple.yaml new file +10 -0
+  PWM controller used for keyboard backlight on ARM Macs
+
+properties:
+  compatible:
+    items:
+      - enum:
+          - apple,t8103-fpwm
+          - apple,t6000-fpwm
+          - apple,t8112-fpwm
+      - const: apple,s5l-fpwm

Is it then derived from Samsung platform? If yes, it is candidate for merging.

Apple calls it the 'AppleS5L8920XFPWM' which suggests some samsung lineage, but the register interface is different from the one in pwm-samsung driver.

maintainer
#4 lore raw

Re: [PATCH 1/4] dt-bindings: pwm: Add Apple PWM controller

In reply to Sasha Finkelstein
Quoted 9 lines · Sasha Finkelstein

Apple SoCs such as the M1 contain a PWM controller used among other things to control the keyboard backlight.

---
 .../devicetree/bindings/pwm/pwm-apple.yaml    | 51 +++++++++++++++++++
 1 file changed, 51 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/pwm/pwm-apple.yaml

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pwm/pwm-apple.example.dtb: fpwm@235044000: compatible:0: 'apple,s5l-fpwm' is not one of ['apple,t8103-fpwm', 'apple,t6000-fpwm', 'apple,t8112-fpwm']
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pwm/pwm-apple.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pwm/pwm-apple.example.dtb: fpwm@235044000: compatible: ['apple,s5l-fpwm'] is too short
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pwm/pwm-apple.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pwm/pwm-apple.example.dtb: fpwm@235044000: reg: [[2, 889470976], [0, 16384]] is too long
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pwm/pwm-apple.yaml

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/patch/

This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:

pip3 install dtschema --upgrade

Please check and re-submit.

#5 lore raw

Re: [PATCH 1/4] dt-bindings: pwm: Add Apple PWM controller

In reply to Sasha Finkelstein
Quoted 28 lines · Sasha Finkelstein

Apple SoCs such as the M1 contain a PWM controller used among other things to control the keyboard backlight.

---
 .../devicetree/bindings/pwm/pwm-apple.yaml    | 51 +++++++++++++++++++
 1 file changed, 51 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/pwm/pwm-apple.yaml
Documentation/devicetree/bindings/pwm/pwm-apple.yaml new file +13 -0
new file mode 100644
index 000000000000..39dc32e00a3f
@@ -0,0 +1,51 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/pwm/pwm-apple.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Apple FPWM controller
+
+maintainers:
+  - [email protected]
+  - Sasha Finkelstein <[email protected]>
+
+description: |+

Documentation/devicetree/bindings/pwm/pwm-apple.yaml line 23

Quoted 10 lines
Documentation/devicetree/bindings/pwm/pwm-apple.yaml new file +10 -0
+  PWM controller used for keyboard backlight on ARM Macs
+
+properties:
+  compatible:
+    items:
+      - enum:
+          - apple,t8103-fpwm
+          - apple,t6000-fpwm
+          - apple,t8112-fpwm
+      - const: apple,s5l-fpwm

Missing blank line.

Quoted 13 lines
Documentation/devicetree/bindings/pwm/pwm-apple.yaml new file +13 -0
+  reg:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+
+  power-domains:
+    maxItems: 1
+
+  "#pwm-cells":
+    const: 2
+
+required:

Documentation/devicetree/bindings/pwm/pwm-apple.yaml line 46

Quoted 10 lines
Documentation/devicetree/bindings/pwm/pwm-apple.yaml new file +10 -0
+  - compatible
+  - reg
+  - clocks
+
+additionalProperties: false
+
+examples:
+  - |
+    pwm: fpwm@235044000 {
+      compatible = "apple,s5l-fpwm";

As Rob's bot pointed out, this does not match the bindings so you did not test them before sending :(

Best regards,
Krzysztof

#6 lore raw

PATCH 2/4 pwm: Add Apple PWM controller

In reply to Sasha Finkelstein

Adds the Apple PWM controller driver.

---
 drivers/pwm/Kconfig     |  12 ++++
 drivers/pwm/Makefile    |   1 +
 drivers/pwm/pwm-apple.c | 124 ++++++++++++++++++++++++++++++++++++++++
 3 files changed, 137 insertions(+)
 create mode 100644 drivers/pwm/pwm-apple.c
drivers/pwm/Kconfig +12 -0
index 60d13a949bc5..ec6acb368073 100644
@@ -51,6 +51,18 @@ config PWM_AB8500
 	  To compile this driver as a module, choose M here: the module
 	  will be called pwm-ab8500.
 
+config PWM_APPLE
+	tristate "Apple SoC PWM support"
+	depends on ARCH_APPLE || (COMPILE_TEST && 64BIT)
+	help
+	  Generic PWM framework driver for PWM controller present on
+	  Apple SoCs
+
+	  Say Y here if you have an ARM Apple laptop, otherwise say N
+
+	  To compile this driver as a module, choose M here: the module
+	  will be called pwm-apple.
+
 config PWM_ATMEL
 	tristate "Atmel PWM support"
 	depends on ARCH_AT91 || COMPILE_TEST
drivers/pwm/Makefile +1 -0
index 7bf1a29f02b8..19899b912e00 100644
@@ -2,6 +2,7 @@
 obj-$(CONFIG_PWM)		+= core.o
 obj-$(CONFIG_PWM_SYSFS)		+= sysfs.o
 obj-$(CONFIG_PWM_AB8500)	+= pwm-ab8500.o
+obj-$(CONFIG_PWM_APPLE)		+= pwm-apple.o
 obj-$(CONFIG_PWM_ATMEL)		+= pwm-atmel.o
 obj-$(CONFIG_PWM_ATMEL_HLCDC_PWM)	+= pwm-atmel-hlcdc.o
 obj-$(CONFIG_PWM_ATMEL_TCB)	+= pwm-atmel-tcb.o
drivers/pwm/pwm-apple.c new file +124 -0

124 lines not on this page · raw message

Signature · 1 line
2.37.3
#7 lore raw

Re: [PATCH 2/4] pwm: Add Apple PWM controller

Quoted 15 lines · Sasha Finkelstein

Adds the Apple PWM controller driver.

---
 drivers/pwm/Kconfig     |  12 ++++
 drivers/pwm/Makefile    |   1 +
 drivers/pwm/pwm-apple.c | 124 ++++++++++++++++++++++++++++++++++++++++
 3 files changed, 137 insertions(+)
 create mode 100644 drivers/pwm/pwm-apple.c
drivers/pwm/Kconfig +0 -0
index 60d13a949bc5..ec6acb368073 100644

drivers/pwm/Kconfig config PWM_AB8500 · line 56

Quoted 6 lines
drivers/pwm/Kconfig +3 -0
@@ -51,6 +51,18 @@ config PWM_AB8500
 	  To compile this driver as a module, choose M here: the module
 	  will be called pwm-ab8500.
 
+config PWM_APPLE
+	tristate "Apple SoC PWM support"
+	depends on ARCH_APPLE || (COMPILE_TEST && 64BIT)

Why this code cannot be build on 32-bit?

drivers/pwm/Kconfig config PWM_AB8500 · line 60

Quoted 4 lines
drivers/pwm/Kconfig +4 -0
+	help
+	  Generic PWM framework driver for PWM controller present on
+	  Apple SoCs
+

Best regards,
Krzysztof

#8 lore raw

Re: [PATCH 2/4] pwm: Add Apple PWM controller

Quoted 7 lines · Krzysztof Kozlowski

drivers/pwm/Kconfig config PWM_AB8500 · line 56

Quoted 3 lines · Sasha Finkelstein
drivers/pwm/Kconfig +3 -0
+config PWM_APPLE
+     tristate "Apple SoC PWM support"
+     depends on ARCH_APPLE || (COMPILE_TEST && 64BIT)

Why this code cannot be build on 32-bit?

It uses 64-bit divisions, which causes it to fail to build on 32-bit mips. It should not be a
problem, since this hardware is only present on 64-bit SoCs.

#9 lore raw

Re: [PATCH 2/4] pwm: Add Apple PWM controller

Quoted 4 lines · Sasha Finkelstein
Quoted 2 lines · Krzysztof Kozlowski

On 28/10/2022 12:52, Sasha Finkelstein wrote:

Quoted 8 lines
Quoted 5 lines

drivers/pwm/Kconfig config PWM_AB8500 · line 56

Quoted 3 lines
drivers/pwm/Kconfig +3 -0
+config PWM_APPLE
+     tristate "Apple SoC PWM support"
+     depends on ARCH_APPLE || (COMPILE_TEST && 64BIT)

Why this code cannot be build on 32-bit?

It uses 64-bit divisions, which causes it to fail to build on 32-bit mips. It should not be a
problem, since this hardware is only present on 64-bit SoCs.

Does not matter, code should be portable and buildable on 32-bit. If it does not build then your code is not correct.

You need to investigate the failure. Maybe using do_div would solve (or other macros from div64.h)

Best regards,
Krzysztof

#10 lore raw

Re: [PATCH 2/4] pwm: Add Apple PWM controller

Quoted 9 lines · Krzysztof Kozlowski
Quoted 8 lines · Sasha Finkelstein
Quoted 6 lines · Krzysztof Kozlowski
Quoted 3 lines · Sasha Finkelstein
drivers/pwm/Kconfig +3 -0
+config PWM_APPLE
+     tristate "Apple SoC PWM support"
+     depends on ARCH_APPLE || (COMPILE_TEST && 64BIT)
Quoted 7 lines
Quoted 4 lines
Quoted 1 line

Why this code cannot be build on 32-bit?

It uses 64-bit divisions, which causes it to fail to build on 32-bit mips. It should not be a
problem, since this hardware is only present on 64-bit SoCs.

Does not matter, code should be portable and buildable on 32-bit. If it does not build then your code is not correct.

This statement does not apply in general. There are plenty of drivers which cannot reasonably build for 32-bit, and make no sense because no 32-bit hardware exists that could use them. Examples include anything that accesses 64-bit registers on 64-bit SoCs the normal way, and further anything that touches CPU stuff like system registers.

In *this* case, if the only issue is some 64-bit math, then yes, it should be made to build on 32-bit (especially since this is likely to also work for older 32-bit Apple SoCs). But the (COMPILE_TEST && 64BIT) pattern is definitely valid in other cases, and I've been adding it lately to shut up the kernel test bot since it makes no sense to compile test a whole pile of our drivers on 32-bit architectures - they fundamentally can't compile without adding pointless hypothetical broken fluff to the driver like split MMIO accesses (which often can't work on real hardware), and it serves no purpose.

- Hector

#11 lore raw

PATCH 3/4 arm64: dts: apple: t8103: Add PWM controller

In reply to Sasha Finkelstein

Adds PWM controller and keyboard backlight bindings for M1 MacBooks

---
 arch/arm64/boot/dts/apple/t8103-j293.dts | 20 ++++++++++++++++++++
 arch/arm64/boot/dts/apple/t8103-j313.dts | 20 ++++++++++++++++++++
 arch/arm64/boot/dts/apple/t8103.dtsi     |  9 +++++++++
 3 files changed, 49 insertions(+)
arch/arm64/boot/dts/apple/t8103-j293.dts +20 -0
index ecb10d237a05..5652cd41730a 100644
@@ -11,6 +11,7 @@
 
 #include "t8103.dtsi"
 #include "t8103-jxxx.dtsi"
+#include <dt-bindings/leds/common.h>
 
 / {
 	compatible = "apple,j293", "apple,t8103", "apple,arm-platform";
@@ -43,3 +44,22 @@ &i2c2 {
 &i2c4 {
 	status = "okay";
 };
+
+/ {
+	pwmleds {
+		compatible = "pwm-leds";
+		kbd-backlight {
+			pwms = <&fpwm1 0 40000>;
+			label = "kbd_backlight";
+			function = LED_FUNCTION_KBD_BACKLIGHT;
+			color = <LED_COLOR_ID_WHITE>;
+			max-brightness = <255>;
+			default-state = "keep";
+			pwm-names = "kbd-backlight";
+		};
+	};
+};
+
+&fpwm1 {
+	status = "okay";
+};
arch/arm64/boot/dts/apple/t8103-j313.dts +20 -0
index df741737b8e6..cff53f8770f3 100644
@@ -11,6 +11,7 @@
 
 #include "t8103.dtsi"
 #include "t8103-jxxx.dtsi"
+#include <dt-bindings/leds/common.h>
 
 / {
 	compatible = "apple,j313", "apple,t8103", "apple,arm-platform";
@@ -35,3 +36,22 @@ &pcie0_dart_2 {
 
 /delete-node/ &port01;
 /delete-node/ &port02;
+
+/ {
+	pwmleds {
+		compatible = "pwm-leds";
+		kbd-backlight {
+			pwms = <&fpwm1 0 40000>;
+			label = "kbd_backlight";
+			function = LED_FUNCTION_KBD_BACKLIGHT;
+			color = <LED_COLOR_ID_WHITE>;
+			max-brightness = <255>;
+			default-state = "keep";
+			pwm-names = "kbd-backlight";
+		};
+	};
+};
+
+&fpwm1 {
+	status = "okay";
+};
arch/arm64/boot/dts/apple/t8103.dtsi +9 -0
index 51a63b29d404..a95dc482102e 100644
@@ -191,6 +191,15 @@ i2c4: i2c@235020000 {
 			status = "disabled"; /* only used in J293 */
 		};
 
+		fpwm1: fpwm@235044000 {
+			compatible = "apple,t8103-fpwm", "apple,s5l-fpwm";
+			reg = <0x2 0x35044000 0x0 0x4000>;
+			power-domains = <&ps_fpwm1>;
+			clocks = <&clkref>;
+			#pwm-cells = <2>;
+			status = "disabled";
+		};
+
 		serial0: serial@235200000 {
 			compatible = "apple,s5l-uart";
 			reg = <0x2 0x35200000 0x0 0x1000>;
Signature · 1 line
2.37.3
#12 lore raw

Re: [PATCH 3/4] arm64: dts: apple: t8103: Add PWM controller

Quoted 22 lines · Sasha Finkelstein

Adds PWM controller and keyboard backlight bindings for M1 MacBooks

---
 arch/arm64/boot/dts/apple/t8103-j293.dts | 20 ++++++++++++++++++++
 arch/arm64/boot/dts/apple/t8103-j313.dts | 20 ++++++++++++++++++++
 arch/arm64/boot/dts/apple/t8103.dtsi     |  9 +++++++++
 3 files changed, 49 insertions(+)
arch/arm64/boot/dts/apple/t8103-j293.dts +1 -0
index ecb10d237a05..5652cd41730a 100644
@@ -11,6 +11,7 @@
 
 #include "t8103.dtsi"
 #include "t8103-jxxx.dtsi"
+#include <dt-bindings/leds/common.h>
 
 / {
 	compatible = "apple,j293", "apple,t8103", "apple,arm-platform";

arch/arm64/boot/dts/apple/t8103-j293.dts &i2c2 { · line 49

Quoted 6 lines
arch/arm64/boot/dts/apple/t8103-j293.dts +3 -0
@@ -43,3 +44,22 @@ &i2c2 {
 &i2c4 {
 	status = "okay";
 };
+
+/ {
+	pwmleds {

Node names should be generic: led-controller
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

arch/arm64/boot/dts/apple/t8103-j293.dts &i2c2 { · line 51

Quoted 2 lines
arch/arm64/boot/dts/apple/t8103-j293.dts +2 -0
+		compatible = "pwm-leds";
+		kbd-backlight {

Does not look like you tested the DTS against bindings. Please run make dtbs_check (see Documentation/devicetree/bindings/writing-schema.rst for instructions).

arch/arm64/boot/dts/apple/t8103-j293.dts &i2c2 { · line 58

Quoted 7 lines
arch/arm64/boot/dts/apple/t8103-j293.dts +7 -0
+			pwms = <&fpwm1 0 40000>;
+			label = "kbd_backlight";
+			function = LED_FUNCTION_KBD_BACKLIGHT;
+			color = <LED_COLOR_ID_WHITE>;
+			max-brightness = <255>;
+			default-state = "keep";
+			pwm-names = "kbd-backlight";

This goes just after pwms.

Quoted 20 lines
arch/arm64/boot/dts/apple/t8103-j293.dts +7 -0
+		};
+	};
+};
+
+&fpwm1 {
+	status = "okay";
+};
arch/arm64/boot/dts/apple/t8103-j313.dts +1 -0
index df741737b8e6..cff53f8770f3 100644
@@ -11,6 +11,7 @@
 
 #include "t8103.dtsi"
 #include "t8103-jxxx.dtsi"
+#include <dt-bindings/leds/common.h>
 
 / {
 	compatible = "apple,j313", "apple,t8103", "apple,arm-platform";

arch/arm64/boot/dts/apple/t8103-j313.dts &pcie0_dart_2 { · line 41

Quoted 6 lines
arch/arm64/boot/dts/apple/t8103-j313.dts +3 -0
@@ -35,3 +36,22 @@ &pcie0_dart_2 {
 
 /delete-node/ &port01;
 /delete-node/ &port02;
+
+/ {
+	pwmleds {

Same comments

Quoted 21 lines
arch/arm64/boot/dts/apple/t8103-j313.dts +16 -0
+		compatible = "pwm-leds";
+		kbd-backlight {
+			pwms = <&fpwm1 0 40000>;
+			label = "kbd_backlight";
+			function = LED_FUNCTION_KBD_BACKLIGHT;
+			color = <LED_COLOR_ID_WHITE>;
+			max-brightness = <255>;
+			default-state = "keep";
+			pwm-names = "kbd-backlight";
+		};
+	};
+};
+
+&fpwm1 {
+	status = "okay";
+};
arch/arm64/boot/dts/apple/t8103.dtsi +0 -0
index 51a63b29d404..a95dc482102e 100644

arch/arm64/boot/dts/apple/t8103.dtsi i2c4: i2c@235020000 { · line 194

Quoted 4 lines
arch/arm64/boot/dts/apple/t8103.dtsi +1 -0
@@ -191,6 +191,15 @@ i2c4: i2c@235020000 {
 			status = "disabled"; /* only used in J293 */
 		};
 
+		fpwm1: fpwm@235044000 {

Node names should be generic, so pwm.
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

arch/arm64/boot/dts/apple/t8103.dtsi i2c4: i2c@235020000 { · line 196

Quoted 2 lines
arch/arm64/boot/dts/apple/t8103.dtsi +2 -0
+			compatible = "apple,t8103-fpwm", "apple,s5l-fpwm";
+			reg = <0x2 0x35044000 0x0 0x4000>;

Best regards,
Krzysztof

#13 lore raw

PATCH 4/4 MAINTAINERS: Add entries for Apple PWM driver

In reply to Sasha Finkelstein

Add the MAINTAINERS entries for the driver

---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)
MAINTAINERS +2 -0
index e04d944005ba..4c9719a2439a 100644
@@ -1908,6 +1908,7 @@ F:	Documentation/devicetree/bindings/nvmem/apple,efuses.yaml
 F:	Documentation/devicetree/bindings/pci/apple,pcie.yaml
 F:	Documentation/devicetree/bindings/pinctrl/apple,pinctrl.yaml
 F:	Documentation/devicetree/bindings/power/apple*
+F:	Documentation/devicetree/bindings/pwm/pwm-apple.yaml
 F:	Documentation/devicetree/bindings/watchdog/apple,wdt.yaml
 F:	arch/arm64/boot/dts/apple/
 F:	drivers/clk/clk-apple-nco.c
@@ -1921,6 +1922,7 @@ F:	drivers/mailbox/apple-mailbox.c
 F:	drivers/nvme/host/apple.c
 F:	drivers/nvmem/apple-efuses.c
 F:	drivers/pinctrl/pinctrl-apple-gpio.c
+F:	drivers/pwm/pwm-apple.c
 F:	drivers/soc/apple/*
 F:	drivers/watchdog/apple_wdt.c
 F:	include/dt-bindings/interrupt-controller/apple-aic.h
Signature · 1 line
2.37.3