Skip to contentSkip to conversation

fpga: add initial KUnit tests for the subsystem

RFC PATCH Superseded Marco Pagani 2 participants 7 messages Apr 14, 2023 – Apr 15, 2023 FPGA manager framework

v3 of 10 Superseded Latest is v10 →

lore
Share & tools
lore
#0 lore raw

v3 cover fpga: add initial KUnit tests for the subsystem

This patch set introduces initial KUnit test suites for the FPGA subsystem.

Tests can be run using:
[user@localhost linux]$ ./tools/testing/kunit/kunit.py run --kunitconfig=drivers/fpga/tests

v3:
- Calling fpga_bridges_put() between reconfigurations
- Functions for registering fake modules allocate and return context structs

v2:
- Restructured code into multiple suites to test components in isolation
- Reduced code duplication using init and exit methods
- Using a get_bridges() method to build the list of bridges just before programming
- Regions and Bridges are organized topologically
- Changed bitstream/bit to images
- Allocate images dynamically
- Renamed fpga-tests to fpga-test
- Simplified Kconfig
- Add license info to the fpga-test module

Marco Pagani (4):
fpga: add fake FPGA manager
fpga: add fake FPGA bridge
fpga: add fake FPGA region
fpga: add initial KUnit test suites

 drivers/fpga/Kconfig                  |   2 +
 drivers/fpga/Makefile                 |   3 +
 drivers/fpga/tests/.kunitconfig       |   5 +
 drivers/fpga/tests/Kconfig            |  11 +
 drivers/fpga/tests/Makefile           |   6 +
 drivers/fpga/tests/fake-fpga-bridge.c | 242 +++++++++++++
 drivers/fpga/tests/fake-fpga-bridge.h |  36 ++
 drivers/fpga/tests/fake-fpga-mgr.c    | 386 +++++++++++++++++++++
 drivers/fpga/tests/fake-fpga-mgr.h    |  43 +++
 drivers/fpga/tests/fake-fpga-region.c | 259 ++++++++++++++
 drivers/fpga/tests/fake-fpga-region.h |  40 +++
 drivers/fpga/tests/fpga-test.c        | 479 ++++++++++++++++++++++++++
 12 files changed, 1512 insertions(+)
 create mode 100644 drivers/fpga/tests/.kunitconfig
 create mode 100644 drivers/fpga/tests/Kconfig
 create mode 100644 drivers/fpga/tests/Makefile
 create mode 100644 drivers/fpga/tests/fake-fpga-bridge.c
 create mode 100644 drivers/fpga/tests/fake-fpga-bridge.h
 create mode 100644 drivers/fpga/tests/fake-fpga-mgr.c
 create mode 100644 drivers/fpga/tests/fake-fpga-mgr.h
 create mode 100644 drivers/fpga/tests/fake-fpga-region.c
 create mode 100644 drivers/fpga/tests/fake-fpga-region.h
 create mode 100644 drivers/fpga/tests/fpga-test.c

base-commit: 09a9639e56c01c7a00d6c0ca63f4c7c41abe075d

Signature · 1 line
2.39.2
#1 lore raw

RFC PATCH v3 1/4 fpga: add fake FPGA manager

Add fake FPGA manager platform driver with support functions. The driver checks the programming sequence using KUnit expectations. This module is part of the KUnit tests for the FPGA subsystem.

---
 drivers/fpga/tests/fake-fpga-mgr.c | 386 +++++++++++++++++++++++++++++
 drivers/fpga/tests/fake-fpga-mgr.h |  43 ++++
 2 files changed, 429 insertions(+)
 create mode 100644 drivers/fpga/tests/fake-fpga-mgr.c
 create mode 100644 drivers/fpga/tests/fake-fpga-mgr.h
drivers/fpga/tests/fake-fpga-mgr.c new file +386 -0
new file mode 100644
index 000000000000..636df637b291
@@ -0,0 +1,386 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Driver for the fake FPGA manager
+ *
+ * Copyright (C) 2023 Red Hat, Inc.
+ *
+ * Author: Marco Pagani <[email protected]>
+ */
+
+#include <linux/types.h>
+#include <linux/device.h>
+#include <linux/platform_device.h>
+#include <linux/fpga/fpga-mgr.h>
+#include <kunit/test.h>
+
+#include "fake-fpga-mgr.h"
+
+#define FAKE_FPGA_MGR_DEV_NAME	"fake_fpga_mgr"
+
+#define FAKE_HEADER_BYTE	0x3f
+#define FAKE_HEADER_SIZE	FPGA_IMG_BLOCK
+
+struct fake_mgr_priv {
+	int rcfg_count;
+	bool op_parse_header;
+	bool op_write_init;
+	bool op_write;
+	bool op_write_sg;
+	bool op_write_complete;
+	struct kunit *test;
+};
+
+struct fake_mgr_data {
+	struct kunit *test;
+};
+
+static void check_header(struct kunit *test, const u8 *buf);
+
+static enum fpga_mgr_states op_state(struct fpga_manager *mgr)
+{
+	struct fake_mgr_priv *priv;
+
+	priv = mgr->priv;
+
+	if (priv->test)
+		kunit_info(priv->test, "Fake FPGA manager: state\n");
+
+	return FPGA_MGR_STATE_UNKNOWN;
+}
+
+static u64 op_status(struct fpga_manager *mgr)
+{
+	struct fake_mgr_priv *priv;
+
+	priv = mgr->priv;
+
+	if (priv->test)
+		kunit_info(priv->test, "Fake FPGA manager: status\n");
+
+	return 0;
+}
+
+static int op_parse_header(struct fpga_manager *mgr, struct fpga_image_info *info,
+			   const char *buf, size_t count)
+{
+	struct fake_mgr_priv *priv;
+
+	priv = mgr->priv;
+
+	if (priv->test) {
+		kunit_info(priv->test, "Fake FPGA manager: parse_header\n");
+
+		KUNIT_EXPECT_EQ(priv->test, mgr->state,
+				FPGA_MGR_STATE_PARSE_HEADER);
+
+		check_header(priv->test, buf);
+	}
+
+	priv->op_parse_header = true;
+
+	return 0;
+}
+
+static int op_write_init(struct fpga_manager *mgr, struct fpga_image_info *info,
+			 const char *buf, size_t count)
+{
+	struct fake_mgr_priv *priv;
+
+	priv = mgr->priv;
+
+	if (priv->test) {
+		kunit_info(priv->test, "Fake FPGA manager: write_init\n");
+
+		KUNIT_EXPECT_EQ(priv->test, mgr->state,
+				FPGA_MGR_STATE_WRITE_INIT);
+	}
+
+	priv->op_write_init = true;
+
+	return 0;
+}
+
+static int op_write(struct fpga_manager *mgr, const char *buf, size_t count)
+{
+	struct fake_mgr_priv *priv;
+
+	priv = mgr->priv;
+
+	if (priv->test) {
+		kunit_info(priv->test, "Fake FPGA manager: write\n");
+
+		KUNIT_EXPECT_EQ(priv->test, mgr->state,
+				FPGA_MGR_STATE_WRITE);
+	}
+
+	priv->op_write = true;
+
+	return 0;
+}
+
+static int op_write_sg(struct fpga_manager *mgr, struct sg_table *sgt)
+{
+	struct fake_mgr_priv *priv;
+
+	priv = mgr->priv;
+
+	if (priv->test) {
+		kunit_info(priv->test, "Fake FPGA manager: write_sg\n");
+
+		KUNIT_EXPECT_EQ(priv->test, mgr->state,
+				FPGA_MGR_STATE_WRITE);
+	}
+
+	priv->op_write_sg = true;
+
+	return 0;
+}
+
+static int op_write_complete(struct fpga_manager *mgr, struct fpga_image_info *info)
+{
+	struct fake_mgr_priv *priv;
+
+	priv = mgr->priv;
+
+	if (priv->test) {
+		kunit_info(priv->test, "Fake FPGA manager: write_complete\n");
+
+		KUNIT_EXPECT_EQ(priv->test, mgr->state,
+				FPGA_MGR_STATE_WRITE_COMPLETE);
+	}
+
+	priv->op_write_complete = true;
+	priv->rcfg_count++;
+
+	return 0;
+}
+
+static void op_fpga_remove(struct fpga_manager *mgr)
+{
+	struct fake_mgr_priv *priv;
+
+	priv = mgr->priv;
+
+	if (priv->test)
+		kunit_info(priv->test, "Fake FPGA manager: remove\n");
+}
+
+static const struct fpga_manager_ops fake_fpga_mgr_ops = {
+	.initial_header_size = FAKE_HEADER_SIZE,
+	.skip_header = false,
+	.state = op_state,
+	.status = op_status,
+	.parse_header = op_parse_header,
+	.write_init = op_write_init,
+	.write = op_write,
+	.write_sg = op_write_sg,
+	.write_complete = op_write_complete,
+	.fpga_remove = op_fpga_remove,
+};
+
+/**
+ * fake_fpga_mgr_register() - register a fake FPGA manager.
+ * @mgr_ctx: fake FPGA manager context data structure.
+ * @test: KUnit test context object.
+ *
+ * Return: pointer to a new fake FPGA manager on success, an ERR_PTR()
+ * encoded error code on failure.
+ */
+struct fake_fpga_mgr *
+fake_fpga_mgr_register(struct kunit *test, struct device *parent)
+{
+	struct fake_fpga_mgr *mgr_ctx;
+	struct fake_mgr_data pdata;
+	int ret;
+
+	mgr_ctx = kzalloc(sizeof(*mgr_ctx), GFP_KERNEL);
+	if (!mgr_ctx) {
+		ret = -ENOMEM;
+		goto err_mem;
+	}
+
+	mgr_ctx->pdev = platform_device_alloc(FAKE_FPGA_MGR_DEV_NAME,
+					      PLATFORM_DEVID_AUTO);
+	if (!mgr_ctx->pdev) {
+		pr_err("Fake FPGA manager device allocation failed\n");
+		ret = -ENOMEM;
+		goto err_mem;
+	}
+
+	pdata.test = test;
+	platform_device_add_data(mgr_ctx->pdev, &pdata, sizeof(pdata));
+
+	mgr_ctx->pdev->dev.parent = parent;
+	ret = platform_device_add(mgr_ctx->pdev);
+	if (ret) {
+		pr_err("Fake FPGA manager device add failed\n");
+		goto err_pdev;
+	}
+
+	mgr_ctx->mgr = platform_get_drvdata(mgr_ctx->pdev);
+
+	if (test)
+		kunit_info(test, "Fake FPGA manager registered\n");
+
+	return mgr_ctx;
+
+err_pdev:
+	platform_device_put(mgr_ctx->pdev);
+	kfree(mgr_ctx);
+err_mem:
+	return ERR_PTR(ret);
+}
+EXPORT_SYMBOL_GPL(fake_fpga_mgr_register);
+
+/**
+ * fake_fpga_mgr_unregister() - unregister a fake FPGA manager.
+ * @mgr_ctx: fake FPGA manager context data structure.
+ */
+void fake_fpga_mgr_unregister(struct fake_fpga_mgr *mgr_ctx)
+{
+	struct fake_mgr_priv *priv;
+	struct kunit *test;
+
+	if (!mgr_ctx)
+		return;
+
+	priv = mgr_ctx->mgr->priv;
+	test = priv->test;
+
+	if (mgr_ctx->pdev) {
+		platform_device_unregister(mgr_ctx->pdev);
+		if (test)
+			kunit_info(test, "Fake FPGA manager unregistered\n");
+	}
+
+	kfree(mgr_ctx);
+}
+EXPORT_SYMBOL_GPL(fake_fpga_mgr_unregister);
+
+/**
+ * fake_fpga_mgr_get_rcfg_count() - get the number of reconfigurations.
+ * @mgr_ctx: fake FPGA manager context data structure.
+ *
+ * Return: number of reconfigurations.
+ */
+int fake_fpga_mgr_get_rcfg_count(const struct fake_fpga_mgr *mgr_ctx)
+{
+	struct fake_mgr_priv *priv;
+
+	priv = mgr_ctx->mgr->priv;
+
+	return priv->rcfg_count;
+}
+EXPORT_SYMBOL_GPL(fake_fpga_mgr_get_rcfg_count);
+
+/**
+ * fake_fpga_mgr_fill_header() - fill an image buffer with the test header.
+ * @buf: image buffer.
+ */
+void fake_fpga_mgr_fill_header(u8 *buf)
+{
+	int i;
+
+	for (i = 0; i < FAKE_HEADER_SIZE; i++)
+		buf[i] = FAKE_HEADER_BYTE;
+}
+EXPORT_SYMBOL_GPL(fake_fpga_mgr_fill_header);
+
+static void check_header(struct kunit *test, const u8 *buf)
+{
+	int i;
+
+	for (i = 0; i < FAKE_HEADER_SIZE; i++)
+		KUNIT_EXPECT_EQ(test, buf[i], FAKE_HEADER_BYTE);
+}
+
+static void clear_op_flags(struct fake_mgr_priv *priv)
+{
+	priv->op_parse_header = false;
+	priv->op_write_init = false;
+	priv->op_write = false;
+	priv->op_write_sg = false;
+	priv->op_write_complete = false;
+}
+
+/**
+ * fake_fpga_mgr_check_write_buf() - check if programming using a buffer succeeded.
+ * @mgr_ctx: fake FPGA manager context data structure.
+ */
+void fake_fpga_mgr_check_write_buf(struct fake_fpga_mgr *mgr_ctx)
+{
+	struct fake_mgr_priv *priv;
+
+	priv = mgr_ctx->mgr->priv;
+
+	if (priv->test) {
+		KUNIT_EXPECT_EQ(priv->test, priv->op_parse_header, true);
+		KUNIT_EXPECT_EQ(priv->test, priv->op_write_init, true);
+		KUNIT_EXPECT_EQ(priv->test, priv->op_write, true);
+		KUNIT_EXPECT_EQ(priv->test, priv->op_write_complete, true);
+	}
+
+	clear_op_flags(priv);
+}
+EXPORT_SYMBOL_GPL(fake_fpga_mgr_check_write_buf);
+
+/**
+ * fake_fpga_mgr_check_write_sgt() - check if programming using a s.g. table succeeded.
+ * @mgr_ctx: fake FPGA manager context data structure.
+ */
+void fake_fpga_mgr_check_write_sgt(struct fake_fpga_mgr *mgr_ctx)
+{
+	struct fake_mgr_priv *priv;
+
+	priv = mgr_ctx->mgr->priv;
+
+	if (priv->test) {
+		KUNIT_EXPECT_EQ(priv->test, priv->op_parse_header, true);
+		KUNIT_EXPECT_EQ(priv->test, priv->op_write_init, true);
+		KUNIT_EXPECT_EQ(priv->test, priv->op_write_sg, true);
+		KUNIT_EXPECT_EQ(priv->test, priv->op_write_complete, true);
+	}
+
+	clear_op_flags(priv);
+}
+EXPORT_SYMBOL_GPL(fake_fpga_mgr_check_write_sgt);
+
+static int fake_fpga_mgr_probe(struct platform_device *pdev)
+{
+	struct device *dev;
+	struct fake_mgr_priv *priv;
+	struct fake_mgr_data *pdata;
+	struct fpga_manager *mgr;
+
+	dev = &pdev->dev;
+	pdata = dev_get_platdata(dev);
+
+	priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
+	if (!priv)
+		return -ENOMEM;
+
+	if (pdata)
+		priv->test = pdata->test;
+
+	mgr = devm_fpga_mgr_register(dev, "Fake FPGA Manager",
+				     &fake_fpga_mgr_ops, priv);
+	if (IS_ERR(mgr))
+		return PTR_ERR(mgr);
+
+	platform_set_drvdata(pdev, mgr);
+
+	return 0;
+}
+
+static struct platform_driver fake_fpga_mgr_drv = {
+	.driver = {
+		.name = FAKE_FPGA_MGR_DEV_NAME
+	},
+	.probe = fake_fpga_mgr_probe,
+};
+
+module_platform_driver(fake_fpga_mgr_drv);
+
+MODULE_AUTHOR("Marco Pagani <[email protected]>");
+MODULE_DESCRIPTION("Fake FPGA Manager");
+MODULE_LICENSE("GPL v2");
drivers/fpga/tests/fake-fpga-mgr.h new file +43 -0

43 lines not on this page · raw message

Signature · 1 line
2.39.2
#2 lore raw

RFC PATCH v3 2/4 fpga: add fake FPGA bridge

In reply to Marco Pagani

Add fake FPGA bridge driver with support functions. The driver includes a counter for the number of switching cycles. This module is part of the KUnit tests for the FPGA subsystem.

---
 drivers/fpga/tests/fake-fpga-bridge.c | 242 ++++++++++++++++++++++++++
 drivers/fpga/tests/fake-fpga-bridge.h |  36 ++++
 2 files changed, 278 insertions(+)
 create mode 100644 drivers/fpga/tests/fake-fpga-bridge.c
 create mode 100644 drivers/fpga/tests/fake-fpga-bridge.h
drivers/fpga/tests/fake-fpga-bridge.c new file +242 -0
new file mode 100644
index 000000000000..6a62c04a75c0
@@ -0,0 +1,242 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Driver for the fake FPGA bridge
+ *
+ * Copyright (C) 2023 Red Hat, Inc.
+ *
+ * Author: Marco Pagani <[email protected]>
+ */
+
+#include <linux/types.h>
+#include <linux/device.h>
+#include <linux/platform_device.h>
+#include <linux/fpga/fpga-bridge.h>
+#include <kunit/test.h>
+
+#include "fake-fpga-bridge.h"
+
+#define FAKE_FPGA_BRIDGE_DEV_NAME	"fake_fpga_bridge"
+
+struct fake_bridge_priv {
+	int id;
+	bool enable;
+	int cycles_count;
+	struct kunit *test;
+};
+
+struct fake_bridge_data {
+	struct kunit *test;
+};
+
+static int op_enable_show(struct fpga_bridge *bridge)
+{
+	struct fake_bridge_priv *priv;
+
+	priv = bridge->priv;
+
+	if (priv->test)
+		kunit_info(priv->test, "Fake FPGA bridge %d: enable_show\n",
+			   priv->id);
+
+	return priv->enable;
+}
+
+static int op_enable_set(struct fpga_bridge *bridge, bool enable)
+{
+	struct fake_bridge_priv *priv;
+
+	priv = bridge->priv;
+
+	if (enable && !priv->enable)
+		priv->cycles_count++;
+
+	priv->enable = enable;
+
+	if (priv->test)
+		kunit_info(priv->test, "Fake FPGA bridge %d: enable_set: %d\n",
+			   priv->id, enable);
+
+	return 0;
+}
+
+static void op_remove(struct fpga_bridge *bridge)
+{
+	struct fake_bridge_priv *priv;
+
+	priv = bridge->priv;
+
+	if (priv->test)
+		kunit_info(priv->test, "Fake FPGA bridge: remove\n");
+}
+
+static const struct fpga_bridge_ops fake_fpga_bridge_ops = {
+	.enable_show = op_enable_show,
+	.enable_set = op_enable_set,
+	.fpga_bridge_remove = op_remove,
+};
+
+/**
+ * fake_fpga_bridge_register() - register a fake FPGA bridge.
+ * @parent: parent device.
+ * @test: KUnit test context object.
+ *
+ * Return: pointer to a new fake FPGA bridge on success, an ERR_PTR()
+ * encoded error code on failure.
+ */
+struct fake_fpga_bridge *
+fake_fpga_bridge_register(struct device *parent, struct kunit *test)
+{
+	struct fake_fpga_bridge *bridge_ctx;
+	struct fake_bridge_data pdata;
+	struct fake_bridge_priv *priv;
+	int ret;
+
+	bridge_ctx = kzalloc(sizeof(*bridge_ctx), GFP_KERNEL);
+	if (!bridge_ctx) {
+		ret = -ENOMEM;
+		goto err_mem;
+	}
+
+	bridge_ctx->pdev = platform_device_alloc(FAKE_FPGA_BRIDGE_DEV_NAME,
+						 PLATFORM_DEVID_AUTO);
+	if (!bridge_ctx->pdev) {
+		pr_err("Fake FPGA bridge device allocation failed\n");
+		ret = -ENOMEM;
+		goto err_mem;
+	}
+
+	pdata.test = test;
+	platform_device_add_data(bridge_ctx->pdev, &pdata, sizeof(pdata));
+
+	bridge_ctx->pdev->dev.parent = parent;
+	ret = platform_device_add(bridge_ctx->pdev);
+	if (ret) {
+		pr_err("Fake FPGA bridge device add failed\n");
+		goto err_pdev;
+	}
+
+	bridge_ctx->bridge = platform_get_drvdata(bridge_ctx->pdev);
+
+	if (test) {
+		priv = bridge_ctx->bridge->priv;
+		kunit_info(test, "Fake FPGA bridge %d registered\n", priv->id);
+	}
+
+	return bridge_ctx;
+
+err_pdev:
+	platform_device_put(bridge_ctx->pdev);
+	kfree(bridge_ctx);
+err_mem:
+	return ERR_PTR(ret);
+}
+EXPORT_SYMBOL_GPL(fake_fpga_bridge_register);
+
+/**
+ * fake_fpga_bridge_unregister() - unregister a fake FPGA bridge.
+ * @bridge_ctx: fake FPGA bridge context data structure.
+ */
+void fake_fpga_bridge_unregister(struct fake_fpga_bridge *bridge_ctx)
+{
+	struct fake_bridge_priv *priv;
+	struct kunit *test;
+	int id;
+
+	if (!bridge_ctx)
+		return;
+
+	priv = bridge_ctx->bridge->priv;
+	test = priv->test;
+	id = priv->id;
+
+	if (bridge_ctx->pdev) {
+		platform_device_unregister(bridge_ctx->pdev);
+		if (test)
+			kunit_info(test, "Fake FPGA bridge %d unregistered\n", id);
+	}
+
+	kfree(bridge_ctx);
+}
+EXPORT_SYMBOL_GPL(fake_fpga_bridge_unregister);
+
+/**
+ * fake_fpga_bridge_get_state() - get state of a fake FPGA bridge.
+ * @bridge_ctx: fake FPGA bridge context data structure.
+ *
+ * Return: 1 if the bridge is enabled, 0 if disabled.
+ */
+int fake_fpga_bridge_get_state(const struct fake_fpga_bridge *bridge_ctx)
+{
+	return bridge_ctx->bridge->br_ops->enable_show(bridge_ctx->bridge);
+}
+EXPORT_SYMBOL_GPL(fake_fpga_bridge_get_state);
+
+/**
+ * fake_fpga_bridge_get_cycles_count() - get the number of switching cycles.
+ * @bridge_ctx: fake FPGA bridge context data structure.
+ *
+ * Return: number of switching cycles.
+ */
+int fake_fpga_bridge_get_cycles_count(const struct fake_fpga_bridge *bridge_ctx)
+{
+	struct fake_bridge_priv *priv;
+
+	priv = bridge_ctx->bridge->priv;
+
+	return priv->cycles_count;
+}
+EXPORT_SYMBOL_GPL(fake_fpga_bridge_get_cycles_count);
+
+static int fake_fpga_bridge_probe(struct platform_device *pdev)
+{
+	struct device *dev;
+	struct fpga_bridge *bridge;
+	struct fake_bridge_data *pdata;
+	struct fake_bridge_priv *priv;
+	static int id_count;
+
+	dev = &pdev->dev;
+	pdata = dev_get_platdata(dev);
+
+	priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
+	if (!priv)
+		return -ENOMEM;
+
+	priv->id = id_count++;
+	priv->enable = true;
+
+	if (pdata)
+		priv->test = pdata->test;
+
+	bridge = fpga_bridge_register(dev, "Fake FPGA Bridge",
+				      &fake_fpga_bridge_ops, priv);
+	if (IS_ERR(bridge))
+		return PTR_ERR(bridge);
+
+	platform_set_drvdata(pdev, bridge);
+
+	return 0;
+}
+
+static int fake_fpga_bridge_remove(struct platform_device *pdev)
+{
+	struct fpga_bridge *bridge = platform_get_drvdata(pdev);
+
+	fpga_bridge_unregister(bridge);
+
+	return 0;
+}
+
+static struct platform_driver fake_fpga_bridge_drv = {
+	.driver = {
+		.name = FAKE_FPGA_BRIDGE_DEV_NAME
+	},
+	.probe = fake_fpga_bridge_probe,
+	.remove = fake_fpga_bridge_remove,
+};
+
+module_platform_driver(fake_fpga_bridge_drv);
+
+MODULE_AUTHOR("Marco Pagani <[email protected]>");
+MODULE_DESCRIPTION("Fake FPGA Bridge");
+MODULE_LICENSE("GPL v2");
drivers/fpga/tests/fake-fpga-bridge.h new file +36 -0
new file mode 100644
index 000000000000..a5acfdf18056
@@ -0,0 +1,36 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * Header file for the fake FPGA bridge
+ *
+ * Copyright (C) 2023 Red Hat, Inc.
+ *
+ * Author: Marco Pagani <[email protected]>
+ */
+
+#ifndef __FPGA_FAKE_BRIDGE_H
+#define __FPGA_FAKE_BRIDGE_H
+
+#include <linux/platform_device.h>
+#include <kunit/test.h>
+
+/**
+ * struct fake_fpga_bridge - fake FPGA bridge context data structure
+ *
+ * @bridge: FPGA bridge.
+ * @pdev: platform device of the FPGA bridge.
+ */
+struct fake_fpga_bridge {
+	struct fpga_bridge *bridge;
+	struct platform_device *pdev;
+};
+
+struct fake_fpga_bridge *
+fake_fpga_bridge_register(struct device *parent, struct kunit *test);
+
+void fake_fpga_bridge_unregister(struct fake_fpga_bridge *bridge_ctx);
+
+int fake_fpga_bridge_get_state(const struct fake_fpga_bridge *bridge_ctx);
+
+int fake_fpga_bridge_get_cycles_count(const struct fake_fpga_bridge *bridge_ctx);
+
+#endif /* __FPGA_FAKE_BRIDGE_H */
Signature · 1 line
2.39.2
#3 lore raw

RFC PATCH v3 3/4 fpga: add fake FPGA region

In reply to Marco Pagani

Add fake FPGA region platform driver with support functions. This module is part of the KUnit tests for the FPGA subsystem.

---
 drivers/fpga/tests/fake-fpga-region.c | 259 ++++++++++++++++++++++++++
 drivers/fpga/tests/fake-fpga-region.h |  40 ++++
 2 files changed, 299 insertions(+)
 create mode 100644 drivers/fpga/tests/fake-fpga-region.c
 create mode 100644 drivers/fpga/tests/fake-fpga-region.h
drivers/fpga/tests/fake-fpga-region.c new file +259 -0
new file mode 100644
index 000000000000..25c0b140c6a7
@@ -0,0 +1,259 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Driver for the fake FPGA region
+ *
+ * Copyright (C) 2023 Red Hat, Inc.
+ *
+ * Author: Marco Pagani <[email protected]>
+ */
+
+#include <linux/device.h>
+#include <linux/list.h>
+#include <linux/platform_device.h>
+#include <linux/fpga/fpga-mgr.h>
+#include <linux/fpga/fpga-region.h>
+#include <linux/fpga/fpga-bridge.h>
+#include <kunit/test.h>
+
+#include "fake-fpga-region.h"
+
+#define FAKE_FPGA_REGION_DEV_NAME	"fake_fpga_region"
+
+struct fake_region_priv {
+	int id;
+	struct kunit *test;
+	struct list_head bridge_list;
+};
+
+struct bridge_elem {
+	struct fpga_bridge *bridge;
+	struct list_head node;
+};
+
+struct fake_region_data {
+	struct fpga_manager *mgr;
+	struct kunit *test;
+};
+
+/**
+ * fake_fpga_region_register() - register a fake FPGA region.
+ * @mgr: associated FPGA manager.
+ * @parent: parent device.
+ * @test: KUnit test context object.
+ *
+ * Return: pointer to a new fake FPGA region on success, an ERR_PTR() encoded
+ * error code on failure.
+ */
+struct fake_fpga_region *
+fake_fpga_region_register(struct fpga_manager *mgr, struct device *parent,
+			  struct kunit *test)
+{
+	struct fake_fpga_region *region_ctx;
+	struct fake_region_data pdata;
+	struct fake_region_priv *priv;
+	int ret;
+
+	region_ctx = kzalloc(sizeof(*region_ctx), GFP_KERNEL);
+	if (!region_ctx) {
+		ret = -ENOMEM;
+		goto err_mem;
+	}
+
+	region_ctx->pdev = platform_device_alloc(FAKE_FPGA_REGION_DEV_NAME,
+						 PLATFORM_DEVID_AUTO);
+	if (!region_ctx->pdev) {
+		pr_err("Fake FPGA region device allocation failed\n");
+		ret = -ENOMEM;
+		goto err_mem;
+	}
+
+	pdata.mgr = mgr;
+	pdata.test = test;
+	platform_device_add_data(region_ctx->pdev, &pdata, sizeof(pdata));
+
+	region_ctx->pdev->dev.parent = parent;
+	ret = platform_device_add(region_ctx->pdev);
+	if (ret) {
+		pr_err("Fake FPGA region device add failed\n");
+		goto err_pdev;
+	}
+
+	region_ctx->region = platform_get_drvdata(region_ctx->pdev);
+
+	if (test) {
+		priv = region_ctx->region->priv;
+		kunit_info(test, "Fake FPGA region %d registered\n", priv->id);
+	}
+
+	return region_ctx;
+
+err_pdev:
+	platform_device_put(region_ctx->pdev);
+	kfree(region_ctx);
+err_mem:
+	return ERR_PTR(ret);
+}
+EXPORT_SYMBOL_GPL(fake_fpga_region_register);
+
+/**
+ * fake_fpga_region_unregister() - unregister a fake FPGA region.
+ * @region_ctx: fake FPGA region context data structure.
+ */
+void fake_fpga_region_unregister(struct fake_fpga_region *region_ctx)
+{
+	struct fake_region_priv *priv;
+	struct kunit *test;
+	int id;
+
+	if (!region_ctx)
+		return;
+
+	priv = region_ctx->region->priv;
+	test = priv->test;
+	id = priv->id;
+
+	if (region_ctx->pdev) {
+		platform_device_unregister(region_ctx->pdev);
+		if (test)
+			kunit_info(test, "Fake FPGA region %d unregistered\n", id);
+	}
+
+	kfree(region_ctx);
+}
+EXPORT_SYMBOL_GPL(fake_fpga_region_unregister);
+
+/**
+ * fake_fpga_region_add_bridge() - add a bridge to a fake FPGA region.
+ * @region_ctx: fake FPGA region context data structure.
+ * @bridge: FPGA bridge.
+ *
+ * Return: 0 if registration succeeded, an error code otherwise.
+ */
+int fake_fpga_region_add_bridge(struct fake_fpga_region *region_ctx,
+				struct fpga_bridge *bridge)
+{
+	struct fake_region_priv *priv;
+	struct bridge_elem *elem;
+
+	priv = region_ctx->region->priv;
+
+	elem = devm_kzalloc(&region_ctx->pdev->dev, sizeof(*elem), GFP_KERNEL);
+	if (!elem)
+		return -ENOMEM;
+
+	/* Add bridge to the list of bridges in the private context */
+	elem->bridge = bridge;
+	list_add(&elem->node, &priv->bridge_list);
+
+	if (priv->test)
+		kunit_info(priv->test, "Bridge added to fake FPGA region %d\n",
+			   priv->id);
+
+	return 0;
+}
+EXPORT_SYMBOL_GPL(fake_fpga_region_add_bridge);
+
+int fake_fpga_region_program(struct fake_fpga_region *region_ctx)
+{
+	int ret;
+
+	ret = fpga_region_program_fpga(region_ctx->region);
+
+	/* fpga_region_program_fpga() already puts the bridges in case of errors */
+	if (!ret)
+		fpga_bridges_put(&region_ctx->region->bridge_list);
+
+	return ret;
+}
+EXPORT_SYMBOL_GPL(fake_fpga_region_program)
+
+static int fake_region_get_bridges(struct fpga_region *region)
+{
+	struct fake_region_priv *priv;
+	struct bridge_elem *elem;
+	int ret;
+
+	priv = region->priv;
+
+	/* Copy the list of bridges from the private context to the region */
+	list_for_each_entry(elem, &priv->bridge_list, node) {
+		ret = fpga_bridge_get_to_list(elem->bridge->dev.parent,
+					      region->info,
+					      &region->bridge_list);
+		if (ret)
+			break;
+	}
+
+	return ret;
+}
+
+static int fake_fpga_region_probe(struct platform_device *pdev)
+{
+	struct device *dev;
+	struct fpga_region *region;
+	struct fpga_manager *mgr;
+	struct fake_region_data *pdata;
+	struct fake_region_priv *priv;
+	struct fpga_region_info info;
+	static int id_count;
+
+	dev = &pdev->dev;
+	pdata = dev_get_platdata(dev);
+
+	if (!pdata) {
+		dev_err(&pdev->dev, "Missing platform data\n");
+		return -EINVAL;
+	}
+
+	priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
+	if (!priv)
+		return -ENOMEM;
+
+	mgr = fpga_mgr_get(pdata->mgr->dev.parent);
+	if (IS_ERR(mgr))
+		return PTR_ERR(mgr);
+
+	INIT_LIST_HEAD(&priv->bridge_list);
+	priv->id = id_count++;
+	priv->test = pdata->test;
+
+	memset(&info, 0, sizeof(info));
+	info.priv = priv;
+	info.mgr = mgr;
+	info.get_bridges = fake_region_get_bridges;
+
+	region = fpga_region_register_full(dev, &info);
+	if (IS_ERR(region)) {
+		fpga_mgr_put(mgr);
+		return PTR_ERR(region);
+	}
+
+	platform_set_drvdata(pdev, region);
+
+	return 0;
+}
+
+static int fake_fpga_region_remove(struct platform_device *pdev)
+{
+	struct fpga_region *region = platform_get_drvdata(pdev);
+	struct fpga_manager *mgr = region->mgr;
+
+	fpga_mgr_put(mgr);
+	fpga_region_unregister(region);
+
+	return 0;
+}
+
+static struct platform_driver fake_fpga_region_drv = {
+	.driver = {
+		.name = FAKE_FPGA_REGION_DEV_NAME
+	},
+	.probe = fake_fpga_region_probe,
+	.remove = fake_fpga_region_remove,
+};
+
+module_platform_driver(fake_fpga_region_drv);
+
+MODULE_AUTHOR("Marco Pagani <[email protected]>");
+MODULE_DESCRIPTION("Fake FPGA Bridge");
+MODULE_LICENSE("GPL v2");
drivers/fpga/tests/fake-fpga-region.h new file +40 -0
new file mode 100644
index 000000000000..976982c192bc
@@ -0,0 +1,40 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * Header file for the fake FPGA region
+ *
+ * Copyright (C) 2023 Red Hat, Inc.
+ *
+ * Author: Marco Pagani <[email protected]>
+ */
+
+#ifndef __FPGA_FAKE_RGN_H
+#define __FPGA_FAKE_RGN_H
+
+#include <linux/platform_device.h>
+#include <kunit/test.h>
+#include <linux/fpga/fpga-mgr.h>
+#include <linux/fpga/fpga-bridge.h>
+
+/**
+ * struct fake_fpga_region - fake FPGA region context data structure
+ *
+ * @region: FPGA region.
+ * @pdev: platform device of the FPGA region.
+ */
+struct fake_fpga_region {
+	struct fpga_region *region;
+	struct platform_device *pdev;
+};
+
+struct fake_fpga_region *
+fake_fpga_region_register(struct fpga_manager *mgr, struct device *parent,
+			  struct kunit *test);
+
+int fake_fpga_region_add_bridge(struct fake_fpga_region *region_ctx,
+				struct fpga_bridge *bridge);
+
+int fake_fpga_region_program(struct fake_fpga_region *region_ctx);
+
+void fake_fpga_region_unregister(struct fake_fpga_region *region_ctx);
+
+#endif /* __FPGA_FAKE_RGN_H */
Signature · 1 line
2.39.2
#4 lore raw

RFC PATCH v3 4/4 fpga: add initial KUnit test suites

In reply to Marco Pagani

Introduce initial KUnit tests for the FPGA subsystem. Tests are organized into three test suites. The first suite tests the FPGA Manager. The second suite tests the FPGA Bridge. Finally, the last test suite models a complete FPGA platform and tests static and partial reconfiguration.

---
 drivers/fpga/Kconfig            |   2 +
 drivers/fpga/Makefile           |   3 +
 drivers/fpga/tests/.kunitconfig |   5 +
 drivers/fpga/tests/Kconfig      |  11 +
 drivers/fpga/tests/Makefile     |   6 +
 drivers/fpga/tests/fpga-test.c  | 479 ++++++++++++++++++++++++++++++++
 6 files changed, 506 insertions(+)
 create mode 100644 drivers/fpga/tests/.kunitconfig
 create mode 100644 drivers/fpga/tests/Kconfig
 create mode 100644 drivers/fpga/tests/Makefile
 create mode 100644 drivers/fpga/tests/fpga-test.c
drivers/fpga/Kconfig +2 -0
index 0a00763b9f28..2f689ac4ba3a 100644
@@ -276,4 +276,6 @@ config FPGA_MGR_LATTICE_SYSCONFIG_SPI
 	  FPGA manager driver support for Lattice FPGAs programming over slave
 	  SPI sysCONFIG interface.
 
+source "drivers/fpga/tests/Kconfig"
+
 endif # FPGA
drivers/fpga/Makefile +3 -0
index 72e554b4d2f7..352a2612623e 100644
@@ -55,3 +55,6 @@ obj-$(CONFIG_FPGA_DFL_NIOS_INTEL_PAC_N3000)	+= dfl-n3000-nios.o
 
 # Drivers for FPGAs which implement DFL
 obj-$(CONFIG_FPGA_DFL_PCI)		+= dfl-pci.o
+
+# KUnit tests
+obj-$(CONFIG_FPGA_KUNIT_TESTS)		+= tests/
drivers/fpga/tests/.kunitconfig new file +5 -0
new file mode 100644
index 000000000000..a1c2a2974c39
@@ -0,0 +1,5 @@
+CONFIG_KUNIT=y
+CONFIG_FPGA=y
+CONFIG_FPGA_REGION=y
+CONFIG_FPGA_BRIDGE=y
+CONFIG_FPGA_KUNIT_TESTS=y
drivers/fpga/tests/Kconfig new file +11 -0
new file mode 100644
index 000000000000..1cbea75dd29b
@@ -0,0 +1,11 @@
+config FPGA_KUNIT_TESTS
+	tristate "KUnit test for the FPGA subsystem" if !KUNIT_ALL_TESTS
+	depends on FPGA && FPGA_REGION && FPGA_BRIDGE && KUNIT
+	default KUNIT_ALL_TESTS
+        help
+          This builds unit tests for the FPGA subsystem
+
+          For more information on KUnit and unit tests in general,
+          please refer to the KUnit documentation in Documentation/dev-tools/kunit/.
+
+          If unsure, say N.
drivers/fpga/tests/Makefile new file +6 -0
new file mode 100644
index 000000000000..0b052570659b
@@ -0,0 +1,6 @@
+# SPDX-License-Identifier: GPL-2.0
+
+obj-$(CONFIG_FPGA_KUNIT_TESTS) += fake-fpga-mgr.o
+obj-$(CONFIG_FPGA_KUNIT_TESTS) += fake-fpga-region.o
+obj-$(CONFIG_FPGA_KUNIT_TESTS) += fake-fpga-bridge.o
+obj-$(CONFIG_FPGA_KUNIT_TESTS) += fpga-test.o
drivers/fpga/tests/fpga-test.c new file +479 -0

479 lines not on this page · raw message

Signature · 1 line
2.39.2
#5 lore raw

Re: [RFC PATCH v3 4/4] fpga: add initial KUnit test suites

kernel test robot noticed the following build errors:

Hi Marco,

[This is a private test report for your RFC patch.] kernel test robot noticed the following build errors:

[auto build test ERROR on 09a9639e56c01c7a00d6c0ca63f4c7c41abe075d]

url:    https://github.com/intel-lab-lkp/linux/commits/Marco-Pagani/fpga-add-fake-FPGA-manager/20230415-003918
base:   09a9639e56c01c7a00d6c0ca63f4c7c41abe075d
patch link:    https://lore.kernel.org/r/20230414163636.236174-5-marpagan%40redhat.com
patch subject: [RFC PATCH v3 4/4] fpga: add initial KUnit test suites
config: s390-allmodconfig (https://download.01.org/0day-ci/archive/20230415/[email protected]/config)
compiler: s390-linux-gcc (GCC) 12.1.0

reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/5883c4e0127553e7d1bba4ecb9c84f9409844122
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Marco-Pagani/fpga-add-fake-FPGA-manager/20230415-003918
git checkout 5883c4e0127553e7d1bba4ecb9c84f9409844122
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=s390 olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=s390 SHELL=/bin/bash drivers/fpga/tests/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <[email protected]>
| Link: https://lore.kernel.org/oe-kbuild-all/[email protected]/

All errors (new ones prefixed by >>):

>> drivers/fpga/tests/fake-fpga-region.c:170:1: error: expected ',' or ';' before 'static'
     170 | static int fake_region_get_bridges(struct fpga_region *region)
         | ^~~~~~
   drivers/fpga/tests/fake-fpga-region.c: In function 'fake_fpga_region_probe':
>> drivers/fpga/tests/fake-fpga-region.c:223:28: error: 'fake_region_get_bridges' undeclared (first use in this function)
     223 |         info.get_bridges = fake_region_get_bridges;
         |                            ^~~~~~~~~~~~~~~~~~~~~~~

drivers/fpga/tests/fake-fpga-region.c:223:28: note: each undeclared identifier is reported only once for each function it appears in

vim +170 drivers/fpga/tests/fake-fpga-region.c

34b28b44394492 Marco Pagani 2023-04-14 169

34b28b44394492 Marco Pagani 2023-04-14 @170  static int fake_region_get_bridges(struct fpga_region *region)
34b28b44394492 Marco Pagani 2023-04-14  171  {
34b28b44394492 Marco Pagani 2023-04-14  172  	struct fake_region_priv *priv;
34b28b44394492 Marco Pagani 2023-04-14  173  	struct bridge_elem *elem;
34b28b44394492 Marco Pagani 2023-04-14  174  	int ret;
34b28b44394492 Marco Pagani 2023-04-14  175  
34b28b44394492 Marco Pagani 2023-04-14  176  	priv = region->priv;
34b28b44394492 Marco Pagani 2023-04-14  177  
34b28b44394492 Marco Pagani 2023-04-14  178  	/* Copy the list of bridges from the private context to the region */
34b28b44394492 Marco Pagani 2023-04-14  179  	list_for_each_entry(elem, &priv->bridge_list, node) {
34b28b44394492 Marco Pagani 2023-04-14  180  		ret = fpga_bridge_get_to_list(elem->bridge->dev.parent,
34b28b44394492 Marco Pagani 2023-04-14  181  					      region->info,
34b28b44394492 Marco Pagani 2023-04-14  182  					      &region->bridge_list);
34b28b44394492 Marco Pagani 2023-04-14  183  		if (ret)
34b28b44394492 Marco Pagani 2023-04-14  184  			break;
34b28b44394492 Marco Pagani 2023-04-14  185  	}
34b28b44394492 Marco Pagani 2023-04-14  186  
34b28b44394492 Marco Pagani 2023-04-14  187  	return ret;
34b28b44394492 Marco Pagani 2023-04-14  188  }
34b28b44394492 Marco Pagani 2023-04-14  189  
34b28b44394492 Marco Pagani 2023-04-14  190  static int fake_fpga_region_probe(struct platform_device *pdev)
34b28b44394492 Marco Pagani 2023-04-14  191  {
34b28b44394492 Marco Pagani 2023-04-14  192  	struct device *dev;
34b28b44394492 Marco Pagani 2023-04-14  193  	struct fpga_region *region;
34b28b44394492 Marco Pagani 2023-04-14  194  	struct fpga_manager *mgr;
34b28b44394492 Marco Pagani 2023-04-14  195  	struct fake_region_data *pdata;
34b28b44394492 Marco Pagani 2023-04-14  196  	struct fake_region_priv *priv;
34b28b44394492 Marco Pagani 2023-04-14  197  	struct fpga_region_info info;
34b28b44394492 Marco Pagani 2023-04-14  198  	static int id_count;
34b28b44394492 Marco Pagani 2023-04-14  199  
34b28b44394492 Marco Pagani 2023-04-14  200  	dev = &pdev->dev;
34b28b44394492 Marco Pagani 2023-04-14  201  	pdata = dev_get_platdata(dev);
34b28b44394492 Marco Pagani 2023-04-14  202  
34b28b44394492 Marco Pagani 2023-04-14  203  	if (!pdata) {
34b28b44394492 Marco Pagani 2023-04-14  204  		dev_err(&pdev->dev, "Missing platform data\n");
34b28b44394492 Marco Pagani 2023-04-14  205  		return -EINVAL;
34b28b44394492 Marco Pagani 2023-04-14  206  	}
34b28b44394492 Marco Pagani 2023-04-14  207  
34b28b44394492 Marco Pagani 2023-04-14  208  	priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
34b28b44394492 Marco Pagani 2023-04-14  209  	if (!priv)
34b28b44394492 Marco Pagani 2023-04-14  210  		return -ENOMEM;
34b28b44394492 Marco Pagani 2023-04-14  211  
34b28b44394492 Marco Pagani 2023-04-14  212  	mgr = fpga_mgr_get(pdata->mgr->dev.parent);
34b28b44394492 Marco Pagani 2023-04-14  213  	if (IS_ERR(mgr))
34b28b44394492 Marco Pagani 2023-04-14  214  		return PTR_ERR(mgr);
34b28b44394492 Marco Pagani 2023-04-14  215  
34b28b44394492 Marco Pagani 2023-04-14  216  	INIT_LIST_HEAD(&priv->bridge_list);
34b28b44394492 Marco Pagani 2023-04-14  217  	priv->id = id_count++;
34b28b44394492 Marco Pagani 2023-04-14  218  	priv->test = pdata->test;
34b28b44394492 Marco Pagani 2023-04-14  219  
34b28b44394492 Marco Pagani 2023-04-14  220  	memset(&info, 0, sizeof(info));
34b28b44394492 Marco Pagani 2023-04-14  221  	info.priv = priv;
34b28b44394492 Marco Pagani 2023-04-14  222  	info.mgr = mgr;
34b28b44394492 Marco Pagani 2023-04-14 @223  	info.get_bridges = fake_region_get_bridges;
34b28b44394492 Marco Pagani 2023-04-14  224  
34b28b44394492 Marco Pagani 2023-04-14  225  	region = fpga_region_register_full(dev, &info);
34b28b44394492 Marco Pagani 2023-04-14  226  	if (IS_ERR(region)) {
34b28b44394492 Marco Pagani 2023-04-14  227  		fpga_mgr_put(mgr);
34b28b44394492 Marco Pagani 2023-04-14  228  		return PTR_ERR(region);
34b28b44394492 Marco Pagani 2023-04-14  229  	}
34b28b44394492 Marco Pagani 2023-04-14  230  
34b28b44394492 Marco Pagani 2023-04-14  231  	platform_set_drvdata(pdev, region);
34b28b44394492 Marco Pagani 2023-04-14  232  
34b28b44394492 Marco Pagani 2023-04-14  233  	return 0;
34b28b44394492 Marco Pagani 2023-04-14  234  }
34b28b44394492 Marco Pagani 2023-04-14  235  
Signature · 2 lines
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
#6 lore raw

Re: [RFC PATCH v3 4/4] fpga: add initial KUnit test suites

In reply to Marco Pagani
kernel test robot noticed the following build errors:

Hi Marco,

[This is a private test report for your RFC patch.] kernel test robot noticed the following build errors:

[auto build test ERROR on 09a9639e56c01c7a00d6c0ca63f4c7c41abe075d]

url:    https://github.com/intel-lab-lkp/linux/commits/Marco-Pagani/fpga-add-fake-FPGA-manager/20230415-003918
base:   09a9639e56c01c7a00d6c0ca63f4c7c41abe075d
patch link:    https://lore.kernel.org/r/20230414163636.236174-5-marpagan%40redhat.com
patch subject: [RFC PATCH v3 4/4] fpga: add initial KUnit test suites
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20230415/[email protected]/config)
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/5883c4e0127553e7d1bba4ecb9c84f9409844122
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Marco-Pagani/fpga-add-fake-FPGA-manager/20230415-003918
        git checkout 5883c4e0127553e7d1bba4ecb9c84f9409844122
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=x86_64 olddefconfig
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <[email protected]>
| Link: https://lore.kernel.org/oe-kbuild-all/[email protected]/

All errors (new ones prefixed by >>):

>> drivers/fpga/tests/fake-fpga-region.c:170:1: error: expected ';' before 'static'
     170 | static int fake_region_get_bridges(struct fpga_region *region)
         | ^~~~~~
   In file included from drivers/fpga/tests/fake-fpga-region.c:12:
   drivers/fpga/tests/fake-fpga-region.c: In function 'fake_fpga_region_drv_init':
>> drivers/fpga/tests/fake-fpga-region.c:255:24: error: 'fake_fpga_region_drv' undeclared (first use in this function); did you mean 'fake_fpga_region'?
     255 | module_platform_driver(fake_fpga_region_drv);
         |                        ^~~~~~~~~~~~~~~~~~~~
   include/linux/platform_device.h:245:36: note: in definition of macro 'platform_driver_register'
     245 |         __platform_driver_register(drv, THIS_MODULE)
         |                                    ^~~
   include/linux/platform_device.h:275:9: note: in expansion of macro 'module_driver'
     275 |         module_driver(__platform_driver, platform_driver_register, \
         |         ^~~~~~~~~~~~~
   drivers/fpga/tests/fake-fpga-region.c:255:1: note: in expansion of macro 'module_platform_driver'
     255 | module_platform_driver(fake_fpga_region_drv);
         | ^~~~~~~~~~~~~~~~~~~~~~
   drivers/fpga/tests/fake-fpga-region.c:255:24: note: each undeclared identifier is reported only once for each function it appears in
     255 | module_platform_driver(fake_fpga_region_drv);
         |                        ^~~~~~~~~~~~~~~~~~~~
   include/linux/platform_device.h:245:36: note: in definition of macro 'platform_driver_register'
     245 |         __platform_driver_register(drv, THIS_MODULE)
         |                                    ^~~
   include/linux/platform_device.h:275:9: note: in expansion of macro 'module_driver'
     275 |         module_driver(__platform_driver, platform_driver_register, \
         |         ^~~~~~~~~~~~~
   drivers/fpga/tests/fake-fpga-region.c:255:1: note: in expansion of macro 'module_platform_driver'
     255 | module_platform_driver(fake_fpga_region_drv);
         | ^~~~~~~~~~~~~~~~~~~~~~
   In file included from include/linux/device.h:32,
                    from drivers/fpga/tests/fake-fpga-region.c:10:
   drivers/fpga/tests/fake-fpga-region.c: In function 'fake_fpga_region_drv_exit':
>> drivers/fpga/tests/fake-fpga-region.c:255:24: error: 'fake_fpga_region_drv' undeclared (first use in this function); did you mean 'fake_fpga_region'?
     255 | module_platform_driver(fake_fpga_region_drv);
         |                        ^~~~~~~~~~~~~~~~~~~~
   include/linux/device/driver.h:269:24: note: in definition of macro 'module_driver'
     269 |         __unregister(&(__driver) , ##__VA_ARGS__); \
         |                        ^~~~~~~~
   drivers/fpga/tests/fake-fpga-region.c:255:1: note: in expansion of macro 'module_platform_driver'
     255 | module_platform_driver(fake_fpga_region_drv);
         | ^~~~~~~~~~~~~~~~~~~~~~
   drivers/fpga/tests/fake-fpga-region.c: In function 'fake_fpga_region_drv_init':
   include/linux/device/driver.h:265:1: error: control reaches end of non-void function [-Werror=return-type]
     265 | } \
         | ^
   include/linux/platform_device.h:275:9: note: in expansion of macro 'module_driver'
     275 |         module_driver(__platform_driver, platform_driver_register, \
         |         ^~~~~~~~~~~~~
   drivers/fpga/tests/fake-fpga-region.c:255:1: note: in expansion of macro 'module_platform_driver'
     255 | module_platform_driver(fake_fpga_region_drv);
         | ^~~~~~~~~~~~~~~~~~~~~~

cc1: some warnings being treated as errors

vim +255 drivers/fpga/tests/fake-fpga-region.c

34b28b44394492 Marco Pagani 2023-04-14 169

34b28b44394492 Marco Pagani 2023-04-14 @170  static int fake_region_get_bridges(struct fpga_region *region)
34b28b44394492 Marco Pagani 2023-04-14  171  {
34b28b44394492 Marco Pagani 2023-04-14  172  	struct fake_region_priv *priv;
34b28b44394492 Marco Pagani 2023-04-14  173  	struct bridge_elem *elem;
34b28b44394492 Marco Pagani 2023-04-14  174  	int ret;
34b28b44394492 Marco Pagani 2023-04-14  175  
34b28b44394492 Marco Pagani 2023-04-14  176  	priv = region->priv;
34b28b44394492 Marco Pagani 2023-04-14  177  
34b28b44394492 Marco Pagani 2023-04-14  178  	/* Copy the list of bridges from the private context to the region */
34b28b44394492 Marco Pagani 2023-04-14  179  	list_for_each_entry(elem, &priv->bridge_list, node) {
34b28b44394492 Marco Pagani 2023-04-14  180  		ret = fpga_bridge_get_to_list(elem->bridge->dev.parent,
34b28b44394492 Marco Pagani 2023-04-14  181  					      region->info,
34b28b44394492 Marco Pagani 2023-04-14  182  					      &region->bridge_list);
34b28b44394492 Marco Pagani 2023-04-14  183  		if (ret)
34b28b44394492 Marco Pagani 2023-04-14  184  			break;
34b28b44394492 Marco Pagani 2023-04-14  185  	}
34b28b44394492 Marco Pagani 2023-04-14  186  
34b28b44394492 Marco Pagani 2023-04-14  187  	return ret;
34b28b44394492 Marco Pagani 2023-04-14  188  }
34b28b44394492 Marco Pagani 2023-04-14  189  
34b28b44394492 Marco Pagani 2023-04-14  190  static int fake_fpga_region_probe(struct platform_device *pdev)
34b28b44394492 Marco Pagani 2023-04-14  191  {
34b28b44394492 Marco Pagani 2023-04-14  192  	struct device *dev;
34b28b44394492 Marco Pagani 2023-04-14  193  	struct fpga_region *region;
34b28b44394492 Marco Pagani 2023-04-14  194  	struct fpga_manager *mgr;
34b28b44394492 Marco Pagani 2023-04-14  195  	struct fake_region_data *pdata;
34b28b44394492 Marco Pagani 2023-04-14  196  	struct fake_region_priv *priv;
34b28b44394492 Marco Pagani 2023-04-14  197  	struct fpga_region_info info;
34b28b44394492 Marco Pagani 2023-04-14  198  	static int id_count;
34b28b44394492 Marco Pagani 2023-04-14  199  
34b28b44394492 Marco Pagani 2023-04-14  200  	dev = &pdev->dev;
34b28b44394492 Marco Pagani 2023-04-14  201  	pdata = dev_get_platdata(dev);
34b28b44394492 Marco Pagani 2023-04-14  202  
34b28b44394492 Marco Pagani 2023-04-14  203  	if (!pdata) {
34b28b44394492 Marco Pagani 2023-04-14  204  		dev_err(&pdev->dev, "Missing platform data\n");
34b28b44394492 Marco Pagani 2023-04-14  205  		return -EINVAL;
34b28b44394492 Marco Pagani 2023-04-14  206  	}
34b28b44394492 Marco Pagani 2023-04-14  207  
34b28b44394492 Marco Pagani 2023-04-14  208  	priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
34b28b44394492 Marco Pagani 2023-04-14  209  	if (!priv)
34b28b44394492 Marco Pagani 2023-04-14  210  		return -ENOMEM;
34b28b44394492 Marco Pagani 2023-04-14  211  
34b28b44394492 Marco Pagani 2023-04-14  212  	mgr = fpga_mgr_get(pdata->mgr->dev.parent);
34b28b44394492 Marco Pagani 2023-04-14  213  	if (IS_ERR(mgr))
34b28b44394492 Marco Pagani 2023-04-14  214  		return PTR_ERR(mgr);
34b28b44394492 Marco Pagani 2023-04-14  215  
34b28b44394492 Marco Pagani 2023-04-14  216  	INIT_LIST_HEAD(&priv->bridge_list);
34b28b44394492 Marco Pagani 2023-04-14  217  	priv->id = id_count++;
34b28b44394492 Marco Pagani 2023-04-14  218  	priv->test = pdata->test;
34b28b44394492 Marco Pagani 2023-04-14  219  
34b28b44394492 Marco Pagani 2023-04-14  220  	memset(&info, 0, sizeof(info));
34b28b44394492 Marco Pagani 2023-04-14  221  	info.priv = priv;
34b28b44394492 Marco Pagani 2023-04-14  222  	info.mgr = mgr;
34b28b44394492 Marco Pagani 2023-04-14  223  	info.get_bridges = fake_region_get_bridges;
34b28b44394492 Marco Pagani 2023-04-14  224  
34b28b44394492 Marco Pagani 2023-04-14  225  	region = fpga_region_register_full(dev, &info);
34b28b44394492 Marco Pagani 2023-04-14  226  	if (IS_ERR(region)) {
34b28b44394492 Marco Pagani 2023-04-14  227  		fpga_mgr_put(mgr);
34b28b44394492 Marco Pagani 2023-04-14  228  		return PTR_ERR(region);
34b28b44394492 Marco Pagani 2023-04-14  229  	}
34b28b44394492 Marco Pagani 2023-04-14  230  
34b28b44394492 Marco Pagani 2023-04-14  231  	platform_set_drvdata(pdev, region);
34b28b44394492 Marco Pagani 2023-04-14  232  
34b28b44394492 Marco Pagani 2023-04-14  233  	return 0;
34b28b44394492 Marco Pagani 2023-04-14  234  }
34b28b44394492 Marco Pagani 2023-04-14  235  
34b28b44394492 Marco Pagani 2023-04-14  236  static int fake_fpga_region_remove(struct platform_device *pdev)
34b28b44394492 Marco Pagani 2023-04-14  237  {
34b28b44394492 Marco Pagani 2023-04-14  238  	struct fpga_region *region = platform_get_drvdata(pdev);
34b28b44394492 Marco Pagani 2023-04-14  239  	struct fpga_manager *mgr = region->mgr;
34b28b44394492 Marco Pagani 2023-04-14  240  
34b28b44394492 Marco Pagani 2023-04-14  241  	fpga_mgr_put(mgr);
34b28b44394492 Marco Pagani 2023-04-14  242  	fpga_region_unregister(region);
34b28b44394492 Marco Pagani 2023-04-14  243  
34b28b44394492 Marco Pagani 2023-04-14  244  	return 0;
34b28b44394492 Marco Pagani 2023-04-14  245  }
34b28b44394492 Marco Pagani 2023-04-14  246  
34b28b44394492 Marco Pagani 2023-04-14  247  static struct platform_driver fake_fpga_region_drv = {
34b28b44394492 Marco Pagani 2023-04-14  248  	.driver = {
34b28b44394492 Marco Pagani 2023-04-14  249  		.name = FAKE_FPGA_REGION_DEV_NAME
34b28b44394492 Marco Pagani 2023-04-14  250  	},
34b28b44394492 Marco Pagani 2023-04-14  251  	.probe = fake_fpga_region_probe,
34b28b44394492 Marco Pagani 2023-04-14  252  	.remove = fake_fpga_region_remove,
34b28b44394492 Marco Pagani 2023-04-14  253  };
34b28b44394492 Marco Pagani 2023-04-14  254  

34b28b44394492 Marco Pagani 2023-04-14 @255 module_platform_driver(fake_fpga_region_drv); 34b28b44394492 Marco Pagani 2023-04-14 256

Signature · 2 lines
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests