Fixing check patch styling issues
v4 cover Fixing check patch styling issues
v4 changes:
- Updated the respective patches with reviewers tags for respective patches(Dave Jiang)
v3 changes:
- Update the cover letter and commit message with full author name(Fabio/Alison)
- Correct the "typo error" in commit message(Fabio)
v2 changes:
Thanks Alison, Ira for your comments, modified the v1 patches as suggested.
Dropped the patch containing tab changes in port.c
v1 cover letter:
The following patches are cleanup or fixing the styling issues found using checkpatch
In cxl/core/mbox.c, in case of null check failure, returning errno or -ENOMEM in this case is good enough, removing the redundant dev_err message.
In cxl/core/region.c, the else is not required after the return statement, cleaned it up.
Verified the build and sanity by booting the guest VM using the freshly built components.
Raghu Halharvi (2):
cxl/mbox: Remove redundant dev_err() after failed mem alloc cxl/region: Remove else after return statement
drivers/cxl/core/mbox.c | 4 +--- drivers/cxl/core/region.c | 8 ++++---- 2 files changed, 5 insertions(+), 7 deletions(-)
Signature · 1 line
2.39.2
PATCH v4 1/2 cxl/mbox: Remove redundant dev_err() after failed mem alloc
Issue found with checkpatch
A return of errno should be good enough if the memory allocation fails, the error message here is redundant as per the coding style, removing it.
--- drivers/cxl/core/mbox.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/cxl/core/mbox.c +1 -3
@@ -1112,10 +1112,8 @@ struct cxl_dev_state *cxl_dev_state_create(struct device *dev)struct cxl_dev_state *cxlds; cxlds =devm_kzalloc (dev,sizeof (*cxlds),GFP_KERNEL ); -if (!cxlds) { -dev_err (dev,"No memory available\n" ); +if (!cxlds)return ERR_PTR (-ENOMEM ); - }mutex_init (&cxlds->mbox_mutex);mutex_init (&cxlds->event.log_lock);
Signature · 1 line
2.39.2
PATCH v4 2/2 cxl/region: Remove else after return statement
In reply to Raghu HalharviIssue found with checkpatch
The else section here is redundant after return statement, removing it. Sanity and correctness is not affected due to this fix.
--- drivers/cxl/core/region.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/cxl/core/region.c +4 -4
@@ -2666,11 +2666,11 @@ static int cxl_region_invalidate_memregion(struct cxl_region *cxlr) "Bypassing cpu_cache_invalidate_memregion() for testing!\n");clear_bit (CXL_REGION_F_INCOHERENT , &cxlr->flags);return 0 ; - }else { -dev_err (&cxlr->dev, -"Failed to synchronize CPU cache state\n" ); -return -ENXIO ; } + +dev_err (&cxlr->dev, +"Failed to synchronize CPU cache state\n" ); +return -ENXIO ; }cpu_cache_invalidate_memregion (IORES_DESC_CXL );
Signature · 1 line
2.39.2
Dave Jiang
maintainerRe: [PATCH v4 2/2] cxl/region: Remove else after return statement
Quoted 7 lines · Raghu Halharvi
Issue found with checkpatch
The else section here is redundant after return statement, removing it. Sanity and correctness is not affected due to this fix.
Reviewed-by Dave Jiang <[email protected]>Reviewed-by Dave Jiang <[email protected]>
Duplicate tags here. Just FYI. :)
Quoted 25 lines
Signed-off-by Raghu Halharvi <[email protected]>--- drivers/cxl/core/region.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)drivers/cxl/core/region.c +4
-4@@ -2666,11 +2666,11 @@ static int cxl_region_invalidate_memregion(struct cxl_region *cxlr) "Bypassing cpu_cache_invalidate_memregion() for testing!\n");clear_bit (CXL_REGION_F_INCOHERENT , &cxlr->flags);return 0 ; - }else { -dev_err (&cxlr->dev, -"Failed to synchronize CPU cache state\n" ); -return -ENXIO ; } + +dev_err (&cxlr->dev, +"Failed to synchronize CPU cache state\n" ); +return -ENXIO ; }cpu_cache_invalidate_memregion (IORES_DESC_CXL );