Skip to contentSkip to conversation

Staging: rts5208: rtsx: Moved else statement to same line with else if

PATCH Superseded Deepanshu Kartikey 3 participants 3 messages May 19, 2023 Staging

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 Staging: rts5208: rtsx: Moved else statement to same line with else if

Moved else statement to same line with else if,
this warning was given by checkpatch.pl

...
Changes in V2:
- Moved else to the same line with else if
- Moved comment on else statement to inside of it

---
 drivers/staging/rts5208/rtsx.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/staging/rts5208/rtsx.c +2 -4
index 2284a96abcff..47dacef0aaf8 100644
@@ -399,10 +399,8 @@ static int rtsx_control_thread(void *__dev)
 				chip->srb->device->id,
 				(u8)chip->srb->device->lun);
 			chip->srb->result = DID_BAD_TARGET << 16;
-		}
-
-		/* we've got a command, let's do it! */
-		else {
+		} else {
+			/* we've got a command, let's do it! */
 			scsi_show_command(chip);
 			rtsx_invoke_transport(chip->srb, chip);
 		}
Signature · 1 line
2.25.1
maintainer
#1 lore raw
Quoted 9 lines · Deepanshu Kartikey

Moved else statement to same line with else if,
this warning was given by checkpatch.pl

...
Changes in V2:
- Moved else to the same line with else if
- Moved comment on else statement to inside of it

This needs to go below:

Quoted 1 line

---

That line, so that these comments do not end up in the changelog.

thanks,

greg k-h

#2 lore raw
In reply to Deepanshu Kartikey
Quoted 5 lines · Deepanshu Kartikey

Moved else statement to same line with else if,
this warning was given by checkpatch.pl

Quoted 7 lines

...
Changes in V2:
- Moved else to the same line with else if
- Moved comment on else statement to inside of it

---
 drivers/staging/rts5208/rtsx.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

Please read my blog about how to resend a patch.

https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/

regards,
dan carpenter