Skip to contentSkip to conversation

gpio: lp3943: remove unneeded platform_set_drvdata() call

PATCH Applied Andrei Coardos 3 participants 3 messages Jul 25, 2023 – Aug 1, 2023 GPIO

lore
Share & tools
lore

Andrei Coardos

author
#0 lore raw

PATCH v2 1/1 gpio: lp3943: remove unneeded platform_set_drvdata() call

This function call was found to be unnecessary as there is no equivalent platform_get_drvdata() call, to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file.

Reviewed-by Alexandru Ardelean <[email protected]>
Signed-off-by Andrei Coardos <[email protected]>

---

Changelog V1->V2:
* https://lore.kernel.org/linux-gpio/CAHp75VdU1c1vUoRpbekPXoLg2DDcbSThwUmkdHRT2FaZ9kagRA@mail.gmail.com/T/#t
* https://lore.kernel.org/linux-gpio/ZLpdOYxo2U+uO%[email protected]/T/#t
* fixed subject line: adjusted colons where needed

 drivers/gpio/gpio-lp3943.c | 2 --
 1 file changed, 2 deletions(-)
drivers/gpio/gpio-lp3943.c +0 -2
index 79edd5db49d2..8e58242f5123 100644
@@ -199,8 +199,6 @@ static int lp3943_gpio_probe(struct platform_device *pdev)
 	lp3943_gpio->chip = lp3943_gpio_chip;
 	lp3943_gpio->chip.parent = &pdev->dev;
 
-	platform_set_drvdata(pdev, lp3943_gpio);
-
 	return devm_gpiochip_add_data(&pdev->dev, &lp3943_gpio->chip,
 				      lp3943_gpio);
 }
Signature · 1 line
2.34.1
Reviewed-by on v2 1/1
#1 lore raw
Quoted 4 lines · Andrei Coardos

This function call was found to be unnecessary as there is no equivalent platform_get_drvdata() call, to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file.

Reviewed-by Andy Shevchenko <[email protected]>
Signature · 2 lines
With Best Regards,
Andy Shevchenko
Applied
#2 lore raw
In reply to Andrei Coardos
Quoted 32 lines · Andrei Coardos

This function call was found to be unnecessary as there is no equivalent platform_get_drvdata() call, to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file.

Reviewed-by Alexandru Ardelean <[email protected]>
Signed-off-by Andrei Coardos <[email protected]>

---

Changelog V1->V2:
* https://lore.kernel.org/linux-gpio/CAHp75VdU1c1vUoRpbekPXoLg2DDcbSThwUmkdHRT2FaZ9kagRA@mail.gmail.com/T/#t
* https://lore.kernel.org/linux-gpio/ZLpdOYxo2U+uO%[email protected]/T/#t
* fixed subject line: adjusted colons where needed

 drivers/gpio/gpio-lp3943.c | 2 --
 1 file changed, 2 deletions(-)
drivers/gpio/gpio-lp3943.c +0 -3
index 79edd5db49d2..8e58242f5123 100644
@@ -199,8 +199,6 @@ static int lp3943_gpio_probe(struct platform_device *pdev)
        lp3943_gpio->chip = lp3943_gpio_chip;
        lp3943_gpio->chip.parent = &pdev->dev;
 
-       platform_set_drvdata(pdev, lp3943_gpio);
-
        return devm_gpiochip_add_data(&pdev->dev, &lp3943_gpio->chip,
                                      lp3943_gpio);
 }
--
Quoted 2 lines

2.34.1

Applied, thanks!

Bartosz