gpio :mlxbf2: remove unneeded platform_set_drvdata() call
PATCH 1/1 gpio :mlxbf2: remove unneeded platform_set_drvdata() call
This function call was found to be unnecessary as there is no equivalent platform_get_drvdata() call to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file.
Reviewed-by Alexandru Ardelean <[email protected]>
Signed-off-by Andrei Coardos <[email protected]>
--- drivers/gpio/gpio-mlxbf2.c | 2 -- 1 file changed, 2 deletions(-)
drivers/gpio/gpio-mlxbf2.c +0 -2
@@ -420,8 +420,6 @@ mlxbf2_gpio_probe(struct platform_device *pdev) } } -platform_set_drvdata (pdev, gs); - ret =devm_gpiochip_add_data (dev, &gs->gc, gs);if (ret) {dev_err (dev,"Failed adding memory mapped gpiochip\n" );
Signature · 1 line
2.34.1
Quoted 5 lines · Andrei Coardos
This function call was found to be unnecessary as there is no equivalent
platform_get_drvdata()call to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file.
The Subject is broken.
Signature · 2 lines
With Best Regards, Andy Shevchenko