Skip to contentSkip to conversation

gpio: mlxbf2: remove unneeded platform_set_drvdata() call

PATCH Superseded Andrei Coardos 3 participants 3 messages Jul 25, 2023 – Aug 1, 2023 GPIO

lore
Share & tools
lore

Andrei Coardos

author
#0 lore raw

PATCH v2 1/1 gpio: mlxbf2: remove unneeded platform_set_drvdata() call

This function call was found to be unnecessary as there is no equivalent platform_get_drvdata() call to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file.

Reviewed-by Alexandru Ardelean <[email protected]>
Signed-off-by Andrei Coardos <[email protected]>

---

Changelog V1->V2:
* https://lore.kernel.org/linux-gpio/[email protected]
* fixed subject line: adjusted colons where needed

 drivers/gpio/gpio-mlxbf2.c | 2 --
 1 file changed, 2 deletions(-)
drivers/gpio/gpio-mlxbf2.c +0 -2
index 6abe01bc39c3..cf91b6e74d88 100644
@@ -420,8 +420,6 @@ mlxbf2_gpio_probe(struct platform_device *pdev)
 		}
 	}
 
-	platform_set_drvdata(pdev, gs);
-
 	ret = devm_gpiochip_add_data(dev, &gs->gc, gs);
 	if (ret) {
 		dev_err(dev, "Failed adding memory mapped gpiochip\n");
Signature · 1 line
2.34.1
NAK
#1 lore raw
Quoted 2 lines · Andrei Coardos

This function call was found to be unnecessary as there is no equivalent platform_get_drvdata() call to access the private data of the driver.

This is simply not true.

NAK.

Quoted 2 lines

Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#2 lore raw
Quoted 9 lines · Andy Shevchenko
Quoted 2 lines · Andrei Coardos

This function call was found to be unnecessary as there is no equivalent platform_get_drvdata() call to access the private data of the driver.

This is simply not true.

NAK.

Just so you know if that's not obvious from reading the code:
platform_get_drvdata() is just a wrapper around dev_get_drvdata() which is called plenty in PM callbacks of this driver.

Bart

Quoted 8 lines
Quoted 2 lines

Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file.

--
With Best Regards,
Andy Shevchenko