bpf: File verification with LSM and fsverity
Subsystems (10)
Song Liu
maintainerv14 cover bpf: File verification with LSM and fsverity
Changes v13 => v14:
1. Add "static" for bpf_fs_kfunc_set.
2. Add Acked-by from Christian Brauner.
Changes v12 => v13:
1. Only keep 4/9 through 9/9 of v12, as the first 3 patches already applied;
2. Use new macro __bpf_kfunc_[start|end]_defs().
Changes v11 => v12:
1. Fix typo (data_ptr => sig_ptr) in bpf_get_file_xattr().
Changes v10 => v11:
1. Let __bpf_dynptr_data() return const void *. (Andrii)
2. Optimize code to reuse output from __bpf_dynptr_size(). (Andrii)
3. Add __diag_ignore_all("-Wmissing-declarations") for kfunc definition.
4. Fix an off indentation. (Andrii)
Changes v9 => v10:
1. Remove WARN_ON_ONCE() from check_reg_const_str. (Alexei)
Changes v8 => v9:
1. Fix test_progs kfunc_dynptr_param/dynptr_data_null.
Changes v7 => v8:
1. Do not use bpf_dynptr_slice* in the kernel. Add __bpf_dynptr_data* and use them in ther kernel. (Andrii)
Changes v6 => v7:
1. Change "__const_str" annotation to "__str". (Alexei, Andrii)
2. Add KF_TRUSTED_ARGS flag for both new kfuncs. (KP)
3. Only allow bpf_get_file_xattr() to read xattr with "user." prefix.
4. Add Acked-by from Eric Biggers.
Changes v5 => v6:
1. Let fsverity_init_bpf() return void. (Eric Biggers)
2. Sort things in alphabetic orders. (Eric Biggers)
Changes v4 => v5:
1. Revise commit logs. (Alexei)
Changes v3 => v4:
1. Fix error reported by CI.
2. Update comments of bpf_dynptr_slice* that they may return error pointer.
Changes v2 => v3:
1. Rebase and resolve conflicts.
Changes v1 => v2:
1. Let bpf_get_file_xattr() use const string for arg "name". (Alexei)
2. Add recursion prevention with allowlist. (Alexei)
3. Let bpf_get_file_xattr() use __vfs_getxattr() to avoid recursion, as vfs_getxattr() calls into other LSM hooks.
4. Do not use dynptr->data directly, use helper insteadd. (Andrii)
5. Fixes with bpf_get_fsverity_digest. (Eric Biggers)
6. Add documentation. (Eric Biggers)
7. Fix some compile warnings. (kernel test robot)
This set enables file verification with BPF LSM and fsverity.
In this solution, fsverity is used to provide reliable and efficient hash of files; and BPF LSM is used to implement signature verification (against asymmetric keys), and to enforce access control.
This solution can be used to implement access control in complicated cases. For example: only signed python binary and signed python script and access special files/devices/ports.
Thanks,
Song
Song Liu (6):
bpf: Add kfunc bpf_get_file_xattr
bpf, fsverity: Add kfunc bpf_get_fsverity_digest Documentation/bpf: Add documentation for filesystem kfuncs selftests/bpf: Sort config in alphabetic order selftests/bpf: Add tests for filesystem kfuncs selftests/bpf: Add test that uses fsverity and xattr to sign a file
Documentation/bpf/fs_kfuncs.rst | 21 +++ Documentation/bpf/index.rst | 1 + fs/verity/fsverity_private.h | 10 ++ fs/verity/init.c | 1 + fs/verity/measure.c | 84 +++++++++ kernel/trace/bpf_trace.c | 67 +++++++ tools/testing/selftests/bpf/bpf_kfuncs.h | 10 ++ tools/testing/selftests/bpf/config | 3 +- .../selftests/bpf/prog_tests/fs_kfuncs.c | 132 ++++++++++++++ .../bpf/prog_tests/verify_pkcs7_sig.c | 163 +++++++++++++++++- .../selftests/bpf/progs/test_fsverity.c | 46 +++++ .../selftests/bpf/progs/test_get_xattr.c | 37 ++++ .../selftests/bpf/progs/test_sig_in_xattr.c | 82 +++++++++ .../bpf/progs/test_verify_pkcs7_sig.c | 8 +- .../testing/selftests/bpf/verify_sig_setup.sh | 25 +++ 15 files changed, 681 insertions(+), 9 deletions(-) create mode 100644 Documentation/bpf/fs_kfuncs.rst create mode 100644 tools/testing/selftests/bpf/prog_tests/fs_kfuncs.c create mode 100644 tools/testing/selftests/bpf/progs/test_fsverity.c create mode 100644 tools/testing/selftests/bpf/progs/test_get_xattr.c create mode 100644 tools/testing/selftests/bpf/progs/test_sig_in_xattr.c
--
2.34.1
Song Liu
maintainerPATCH v14 1/6 bpf: Add kfunc bpf_get_file_xattr
It is common practice for security solutions to store tags/labels in xattrs. To implement similar functionalities in BPF LSM, add new kfunc bpf_get_file_xattr().
The first use case of bpf_get_file_xattr() is to implement file verifications with asymmetric keys. Specificially, security applications could use fsverity for file hashes and use xattr to store file signatures. (kfunc for fsverity hash will be added in a separate commit.)
Currently, only xattrs with "user." prefix can be read with kfunc bpf_get_file_xattr(). As use cases evolve, we may add a dedicated prefix for bpf_get_file_xattr().
To avoid recursion, bpf_get_file_xattr can be only called from LSM hooks.
--- kernel/trace/bpf_trace.c | 67 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 67 insertions(+)
kernel/trace/bpf_trace.c +67 -0
@@ -24,6 +24,7 @@#include <linux/key.h> #include <linux/verification.h> #include <linux/namei.h> +#include <linux/fileattr.h> #include <net/bpf_sk_storage.h>
@@ -1431,6 +1432,72 @@ static int __init bpf_key_sig_kfuncs_init(void)late_initcall (bpf_key_sig_kfuncs_init);#endif /* CONFIG_KEYS */ +/* filesystem kfuncs */ +__bpf_kfunc_start_defs (); + +/** +* bpf_get_file_xattr - get xattr of a file +* @file: file to get xattr from +* @name__str: name of the xattr +* @value_ptr: output buffer of the xattr value +* +* Get xattr *name__str* of *file* and store the output in *value_ptr*. +* +* For security reasons, only *name__str* with prefix "user." is allowed. +* +* Return: 0 on success, a negative value on error. +*/ +__bpf_kfunc int bpf_get_file_xattr(struct file *file, const char *name__str, +struct bpf_dynptr_kern *value_ptr) +{ +struct dentry *dentry; +u32 value_len; +void *value; +int ret; + +if (strncmp (name__str,XATTR_USER_PREFIX ,XATTR_USER_PREFIX_LEN )) +return -EPERM ; + + value_len =__bpf_dynptr_size (value_ptr); + value =__bpf_dynptr_data_rw (value_ptr, value_len); +if (!value) +return -EINVAL ; + + dentry =file_dentry (file); + ret =inode_permission (&nop_mnt_idmap, dentry->d_inode,MAY_READ ); +if (ret) +return ret; +return __vfs_getxattr (dentry, dentry->d_inode, name__str, value, value_len); +} + +__bpf_kfunc_end_defs (); + +BTF_SET8_START (fs_kfunc_set_ids) +BTF_ID_FLAGS(func, bpf_get_file_xattr, KF_SLEEPABLE | KF_TRUSTED_ARGS) +BTF_SET8_END (fs_kfunc_set_ids) + +static int bpf_get_file_xattr_filter(const struct bpf_prog *prog, u32 kfunc_id) +{ + if (!btf_id_set8_contains(&fs_kfunc_set_ids, kfunc_id)) + return 0; + + /* Only allow to attach from LSM hooks, to avoid recursion */ + return prog->type != BPF_PROG_TYPE_LSM ? -EACCES : 0; +} + +static const struct btf_kfunc_id_set bpf_fs_kfunc_set = { + .owner =THIS_MODULE , + .set = &fs_kfunc_set_ids, + .filter = bpf_get_file_xattr_filter, +}; + +static int __init bpf_fs_kfuncs_init(void) +{ +return register_btf_kfunc_id_set (BPF_PROG_TYPE_LSM , &bpf_fs_kfunc_set); +} + +late_initcall (bpf_fs_kfuncs_init); +static const struct bpf_func_proto *bpf_tracing_func_proto (enum bpf_func_id func_id,const struct bpf_prog *prog) {
Signature · 1 line
2.34.1
Re: [PATCH v14 bpf-next 1/6] bpf: Add kfunc bpf_get_file_xattr
Quoted 10 lines · Song Liu
It is common practice for security solutions to store tags/labels in xattrs. To implement similar functionalities in BPF LSM, add new kfunc
bpf_get_file_xattr().The first use case of
bpf_get_file_xattr()is to implement file verifications with asymmetric keys. Specificially, security applications could use fsverity for file hashes and use xattr to store file signatures. (kfunc for fsverity hash will be added in a separate commit.)
Quoted 8 lines
Currently, only xattrs with "user." prefix can be read with kfunc
bpf_get_file_xattr(). As use cases evolve, we may add a dedicated prefix forbpf_get_file_xattr().To avoid recursion,
bpf_get_file_xattrcan be only called from LSM hooks.Signed-off-by Song Liu <[email protected]>
Song Liu
maintainerPATCH v14 2/6 bpf, fsverity: Add kfunc bpf_get_fsverity_digest
In reply to Song Liufsverity provides fast and reliable hash of files, namely fsverity_digest. The digest can be used by security solutions to verify file contents.
Add new kfunc bpf_get_fsverity_digest() so that we can access fsverity from BPF LSM programs. This kfunc is added to fs/verity/measure.c because some data structure used in the function is private to fsverity (fs/verity/fsverity_private.h).
To avoid recursion, bpf_get_fsverity_digest is only allowed in BPF LSM programs.
--- fs/verity/fsverity_private.h | 10 +++++ fs/verity/init.c | 1 + fs/verity/measure.c | 84 ++++++++++++++++++++++++++++++++++++ 3 files changed, 95 insertions(+)
fs/verity/fsverity_private.h +10 -0
@@ -100,6 +100,16 @@ fsverity_msg(const struct inode *inode, const char *level,#define fsverity_err (inode, fmt, ...) \ fsverity_msg((inode), KERN_ERR, fmt, ##__VA_ARGS__) +/* measure.c */ + +#ifdef CONFIG_BPF_SYSCALL +void __init fsverity_init_bpf (void ); +#else +static inline void fsverity_init_bpf (void ) +{ +} +#endif +/* open.c */ int fsverity_init_merkle_tree_params(struct merkle_tree_params *params,
fs/verity/init.c +1 -0
@@ -69,6 +69,7 @@ static int __init fsverity_init(void)fsverity_init_workqueue ();fsverity_init_sysctl ();fsverity_init_signature (); +fsverity_init_bpf ();return 0 ; }late_initcall (fsverity_init)
fs/verity/measure.c +84 -0
93 lines not on this page · raw message
Signature · 1 line
2.34.1
Song Liu
maintainerPATCH v14 3/6 Documentation/bpf: Add documentation for filesystem kfuncs
In reply to Song LiuAdd a brief introduction for file system kfuncs:
bpf_get_file_xattr()
bpf_get_fsverity_digest()
The documentation highlights the strategy to avoid recursions of these kfuncs.
--- Documentation/bpf/fs_kfuncs.rst | 21 +++++++++++++++++++++ Documentation/bpf/index.rst | 1 + 2 files changed, 22 insertions(+) create mode 100644 Documentation/bpf/fs_kfuncs.rst
Documentation/bpf/fs_kfuncs.rst new file +21 -0
@@ -0,0 +1,21 @@ +.. SPDX-License-Identifier: GPL-2.0 + +.. _fs_kfuncs-header-label: + +===================== +BPF filesystem kfuncs +===================== + +BPF LSM programs need to access filesystem data from LSM hooks. The following +BPF kfuncs can be used to get these data. + + * ``bpf_get_file_xattr()`` + + * ``bpf_get_fsverity_digest()`` + +To avoid recursions, these kfuncs follow the following rules: + +1. These kfuncs are only permitted from BPF LSM function. +2. These kfuncs should not call into other LSM hooks, i.e. security_*(). For + example, ``bpf_get_file_xattr()`` does not use ``vfs_getxattr()``, because + the latter calls LSM hook ``security_inode_getxattr``.
Documentation/bpf/index.rst +1 -0
@@ -21,6 +21,7 @@ that goes into great technical depth about the BPF Architecture. helpers kfuncs cpumasks + fs_kfuncs programs maps bpf_prog_run
Signature · 1 line
2.34.1
Song Liu
maintainerPATCH v14 4/6 selftests/bpf: Sort config in alphabetic order
In reply to Song LiuMove CONFIG_VSOCKETS up, so the CONFIGs are in alphabetic order.
--- tools/testing/selftests/bpf/config | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/bpf/config +1 -1
@@ -82,7 +82,7 @@ CONFIG_SECURITY=y CONFIG_SECURITYFS=y CONFIG_TEST_BPF=m CONFIG_USERFAULTFD=y +CONFIG_VSOCKETS=y CONFIG_VXLAN=y CONFIG_XDP_SOCKETS=y CONFIG_XFRM_INTERFACE=y -CONFIG_VSOCKETS=y
Signature · 1 line
2.34.1
Song Liu
maintainerPATCH v14 5/6 selftests/bpf: Add tests for filesystem kfuncs
In reply to Song LiuAdd selftests for two new filesystem kfuncs:
1. bpf_get_file_xattr
2. bpf_get_fsverity_digest
These tests simply make sure the two kfuncs work. Another selftest will be added to demonstrate how to use these kfuncs to verify file signature.
CONFIG_FS_VERITY is added to selftests config. However, this is not sufficient to guarantee bpf_get_fsverity_digest works. This is because fsverity need to be enabled at file system level (for example, with tune2fs on ext4). If local file system doesn't have this feature enabled, just skip the test.
--- tools/testing/selftests/bpf/bpf_kfuncs.h | 3 + tools/testing/selftests/bpf/config | 1 + .../selftests/bpf/prog_tests/fs_kfuncs.c | 132 ++++++++++++++++++ .../selftests/bpf/progs/test_fsverity.c | 46 ++++++ .../selftests/bpf/progs/test_get_xattr.c | 37 +++++ 5 files changed, 219 insertions(+) create mode 100644 tools/testing/selftests/bpf/prog_tests/fs_kfuncs.c create mode 100644 tools/testing/selftests/bpf/progs/test_fsverity.c create mode 100644 tools/testing/selftests/bpf/progs/test_get_xattr.c
tools/testing/selftests/bpf/bpf_kfuncs.h +3 -0
@@ -55,4 +55,7 @@ void *bpf_cast_to_kern_ctx(void *) __ksym;void *bpf_rdonly_cast (void *obj,__u32 btf_id) __ksym; +extern int bpf_get_file_xattr(struct file *file, const char *name, + struct bpf_dynptr *value_ptr) __ksym; +extern int bpf_get_fsverity_digest(struct file *file, struct bpf_dynptr *digest_ptr) __ksym;#endif
tools/testing/selftests/bpf/config +1 -0
@@ -23,6 +23,7 @@ CONFIG_FPROBE=y CONFIG_FTRACE_SYSCALLS=y CONFIG_FUNCTION_ERROR_INJECTION=y CONFIG_FUNCTION_TRACER=y +CONFIG_FS_VERITY=y CONFIG_GENEVE=y CONFIG_IKCONFIG=y CONFIG_IKCONFIG_PROC=y
tools/testing/selftests/bpf/prog_tests/fs_kfuncs.c new file +132 -0
132 lines not on this page · raw message
tools/testing/selftests/bpf/progs/test_fsverity.c new file +46 -0
46 lines not on this page · raw message
tools/testing/selftests/bpf/progs/test_get_xattr.c new file +37 -0
@@ -0,0 +1,37 @@ +// SPDX-License-Identifier: GPL-2.0 +/* Copyright (c) 2023 Meta Platforms, Inc. and affiliates. */ + +#include "vmlinux.h" +#include <bpf/bpf_helpers.h> +#include <bpf/bpf_tracing.h> +#include "bpf_kfuncs.h" + +char _license[] SEC("license") = "GPL"; + +__u32 monitored_pid; +__u32 found_xattr; + +static const char expected_value[] ="hello" ; +char value[32 ]; + +SEC("lsm.s/file_open") +int BPF_PROG (test_file_open ,struct file *f) +{ +struct bpf_dynptr value_ptr; +__u32 pid; +int ret; + + pid =bpf_get_current_pid_tgid () >>32 ; +if (pid != monitored_pid) +return 0 ; + +bpf_dynptr_from_mem (value,sizeof (value),0 , &value_ptr); + + ret =bpf_get_file_xattr (f,"user.kfuncs" , &value_ptr); +if (ret !=sizeof (expected_value)) +return 0 ; +if (bpf_strncmp (value, ret, expected_value)) +return 0 ; + found_xattr =1 ; +return 0 ; +}
Signature · 1 line
2.34.1
kernel test robot
build botRe: [PATCH v14 bpf-next 5/6] selftests/bpf: Add tests for filesystem kfuncs
kernel test robot noticed the following build errors:
Hi Song,
kernel test robot noticed the following build errors:
[auto build test ERROR on bpf-next/master]
url: https://github.com/intel-lab-lkp/linux/commits/Song-Liu/bpf-Add-kfunc-bpf_get_file_xattr/20231129-084133 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master patch link: https://lore.kernel.org/r/20231129003656.1165061-6-song%40kernel.org patch subject: [PATCH v14 bpf-next 5/6] selftests/bpf: Add tests for filesystem kfuncs compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231130/[email protected]/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
All errors (new ones prefixed by >>):
>> progs/test_fsverity.c:16:22: error: invalid application of 'sizeof' to an incomplete type 'struct fsverity_digest'
16 | char expected_digest[sizeof(struct fsverity_digest) + SHA256_DIGEST_SIZE];
| ^ ~~~~~~~~~~~~~~~~~~~~~~~~
progs/test_fsverity.c:16:36: note: forward declaration of 'struct fsverity_digest'
16 | char expected_digest[sizeof(struct fsverity_digest) + SHA256_DIGEST_SIZE];
| ^
progs/test_fsverity.c:17:13: error: invalid application of 'sizeof' to an incomplete type 'struct fsverity_digest'
17 | char digest[sizeof(struct fsverity_digest) + SHA256_DIGEST_SIZE];
| ^ ~~~~~~~~~~~~~~~~~~~~~~~~
progs/test_fsverity.c:16:36: note: forward declaration of 'struct fsverity_digest'
16 | char expected_digest[sizeof(struct fsverity_digest) + SHA256_DIGEST_SIZE];
| ^2 errors generated.
Signature · 2 lines
0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
Song Liu
maintainerPATCH v14 6/6 selftests/bpf: Add test that uses fsverity and xattr to sign a file
In reply to Song LiuThis selftests shows a proof of concept method to use BPF LSM to enforce file signature. This test is added to verify_pkcs7_sig, so that some existing logic can be reused.
This file signature method uses fsverity, which provides reliable and efficient hash (known as digest) of the file. The file digest is signed with asymmetic key, and the signature is stored in xattr. At the run time, BPF LSM reads file digest and the signature, and then checks them against the public key.
Note that this solution does NOT require FS_VERITY_BUILTIN_SIGNATURES. fsverity is only used to provide file digest. The signature verification and access control is all implemented in BPF LSM.
--- tools/testing/selftests/bpf/bpf_kfuncs.h | 7 + .../bpf/prog_tests/verify_pkcs7_sig.c | 163 +++++++++++++++++- .../selftests/bpf/progs/test_sig_in_xattr.c | 82 +++++++++ .../bpf/progs/test_verify_pkcs7_sig.c | 8 +- .../testing/selftests/bpf/verify_sig_setup.sh | 25 +++ 5 files changed, 277 insertions(+), 8 deletions(-) create mode 100644 tools/testing/selftests/bpf/progs/test_sig_in_xattr.c
tools/testing/selftests/bpf/bpf_kfuncs.h +7 -0
@@ -58,4 +58,11 @@ void *bpf_rdonly_cast(void *obj, __u32 btf_id) __ksym; extern int bpf_get_file_xattr(struct file *file, const char *name, struct bpf_dynptr *value_ptr) __ksym; extern int bpf_get_fsverity_digest(struct file *file, struct bpf_dynptr *digest_ptr) __ksym; + +extern struct bpf_key *bpf_lookup_user_key (__u32 serial,__u64 flags) __ksym; +extern struct bpf_key *bpf_lookup_system_key (__u64 id) __ksym; +extern void bpf_key_put(struct bpf_key *key) __ksym; +extern int bpf_verify_pkcs7_signature(struct bpf_dynptr *data_ptr, + struct bpf_dynptr *sig_ptr, + struct bpf_key *trusted_keyring) __ksym;#endif
tools/testing/selftests/bpf/prog_tests/verify_pkcs7_sig.c +162 -1
187 lines not on this page · raw message
tools/testing/selftests/bpf/progs/test_sig_in_xattr.c new file +82 -0
82 lines not on this page · raw message
tools/testing/selftests/bpf/progs/test_verify_pkcs7_sig.c +1 -7
@@ -10,17 +10,11 @@#include <errno.h> #include <bpf/bpf_helpers.h> #include <bpf/bpf_tracing.h> +#include "bpf_kfuncs.h" #define MAX_DATA_SIZE (1024 * 1024)#define MAX_SIG_SIZE 1024 -extern struct bpf_key *bpf_lookup_user_key (__u32 serial,__u64 flags) __ksym; -extern struct bpf_key *bpf_lookup_system_key (__u64 id) __ksym; -extern void bpf_key_put(struct bpf_key *key) __ksym; -extern int bpf_verify_pkcs7_signature(struct bpf_dynptr *data_ptr, - struct bpf_dynptr *sig_ptr, - struct bpf_key *trusted_keyring) __ksym; -__u32 monitored_pid;__u32 user_keyring_serial;__u64 system_keyring_id;
tools/testing/selftests/bpf/verify_sig_setup.sh +25 -0
@@ -60,6 +60,27 @@ cleanup() { rm -rf ${tmp_dir} } +fsverity_create_sign_file() { + local tmp_dir="$1" + + data_file=${tmp_dir}/data-file + sig_file=${tmp_dir}/sig-file + dd if=/dev/urandom of=$data_file bs=1 count=12345 2> /dev/null + fsverity sign --key ${tmp_dir}/signing_key.pem $data_file $sig_file + + # We do not want to enable fsverity on $data_file yet. Try whether + # the file system support fsverity on a different file. + touch ${tmp_dir}/tmp-file + fsverity enable ${tmp_dir}/tmp-file +} + +fsverity_enable_file() { + local tmp_dir="$1" + + data_file=${tmp_dir}/data-file + fsverity enable $data_file +} + catch() { local exit_code="$1"
@@ -86,6 +107,10 @@ main() setup "${tmp_dir}" elif [[ "${action}" == "cleanup" ]]; then cleanup "${tmp_dir}" + elif [[ "${action}" == "fsverity-create-sign" ]]; then + fsverity_create_sign_file "${tmp_dir}" + elif [[ "${action}" == "fsverity-enable" ]]; then + fsverity_enable_file "${tmp_dir}" else echo "Unknown action: ${action}" exit 1
Signature · 1 line
2.34.1
Re: [PATCH v14 bpf-next 6/6] selftests/bpf: Add test that uses fsverity and xattr to sign a file
Quoted 1 line · Song Liu
+char digest[MAGIC_SIZE +
sizeof(struct fsverity_digest)+SHA256_DIGEST_SIZE];
when vmlinux is built without CONFIG_FS_VERITY the above fails in a weird way:
CLNG-BPF [test_maps] test_sig_in_xattr.bpf.oprogs/test_sig_in_xattr.c:36:26: error: invalid application of 'sizeof' to an incomplete type 'struct fsverity_digest'
36 | char digest[MAGIC_SIZE + sizeof(struct fsverity_digest) +
SHA256_DIGEST_SIZE];
| ^ ~~~~~~~~~~~~~~~~~~~~~~~~Is there a way to somehow print a hint during the build what configs users need to enable to pass the build ?
Song Liu
maintainerRe: [PATCH v14 bpf-next 6/6] selftests/bpf: Add test that uses fsverity and xattr to sign a file
Quoted 10 lines · Alexei Starovoitov
Quoted 1 line · Song Liu
+char digest[MAGIC_SIZE +
sizeof(struct fsverity_digest)+SHA256_DIGEST_SIZE];when vmlinux is built without
CONFIG_FS_VERITYthe above fails in a weird way:
CLNG-BPF [test_maps] test_sig_in_xattr.bpf.oprogs/test_sig_in_xattr.c:36:26: error: invalid application of 'sizeof' to an incomplete type 'structfsverity_digest'
36 | char digest[MAGIC_SIZE +sizeof(struct fsverity_digest)+
Quoted 5 lines
SHA256_DIGEST_SIZE]; | ^ ~~~~~~~~~~~~~~~~~~~~~~~~Is there a way to somehow print a hint during the build what configs users need to enable to pass the build ?
Patch 5/6 added CONFIG_FS_VERITY to tools/testing/selftests/bpf/config. This is a more general question for all required CONFIG_* specified in the file (and the config files for other selftests).
In selftests/bpf/Makefile, we have logic to find vmlinux. We can add similar logic to find .config used to build the vmlinux, and grep for each required CONFIG_* from the .config file. Does this sound like a viable solution?
Thanks,
Song
Re: [PATCH v14 bpf-next 6/6] selftests/bpf: Add test that uses fsverity and xattr to sign a file
Quoted 19 lines · Song Liu
Quoted 10 lines · Alexei Starovoitov
Quoted 1 line · Song Liu
+char digest[MAGIC_SIZE +
sizeof(struct fsverity_digest)+SHA256_DIGEST_SIZE];when vmlinux is built without
CONFIG_FS_VERITYthe above fails in a weird way:
CLNG-BPF [test_maps] test_sig_in_xattr.bpf.oprogs/test_sig_in_xattr.c:36:26: error: invalid application of 'sizeof' to an incomplete type 'structfsverity_digest'
36 | char digest[MAGIC_SIZE +sizeof(struct fsverity_digest)+Quoted 5 lines
SHA256_DIGEST_SIZE]; | ^ ~~~~~~~~~~~~~~~~~~~~~~~~Is there a way to somehow print a hint during the build what configs users need to enable to pass the build ?
Quoted 7 lines
Patch 5/6 added
CONFIG_FS_VERITYtotools/testing/selftests/bpf/config. This is a more general question for all required CONFIG_* specified in the file (and the config files for other selftests).In selftests/bpf/Makefile, we have logic to find vmlinux. We can add similar logic to find .config used to build the vmlinux, and grep for each required CONFIG_* from the .config file. Does this sound like a viable solution?
No need for new logic to parse .config.
libbpf does it already and
extern bool CONFIG_FS_VERITY __kconfig __weak;
works.
Since you hard code MAGIC_SIZE anyway I'm asking
to hard code sizeof(struct fsverity_digest) as well, since the bpf prog doesn't access it directly. It only needs to know its size.
While inside:
int BPF_PROG(test_file_open, struct file *f)
{
if (!CONFIG_FS_VERITY) {
skip_fs_verity_test = true;
return 0;}
and report it as a clean error message in test_progs.
We keep adding new config requirements selftests/bpf/config which forces all developers to keep adding new configs to their builds. In the past, when we didn't have BPF CI, that was necessary, but now BPF CI does it for us.
With clean error message from test_progs the developers can either ignore the error and proceed with their work or adjust their .config eventually. While hard selftest build error forces all devs to update .config right away and build error has no info of what needs to be done which is not developer friendly.
pw-bot: cr
Song Liu
maintainerRe: [PATCH v14 bpf-next 6/6] selftests/bpf: Add test that uses fsverity and xattr to sign a file
Quoted 41 lines · Alexei Starovoitov
Quoted 19 lines · Song Liu
Quoted 10 lines · Alexei Starovoitov
Quoted 1 line · Song Liu
+char digest[MAGIC_SIZE +
sizeof(struct fsverity_digest)+SHA256_DIGEST_SIZE];when vmlinux is built without
CONFIG_FS_VERITYthe above fails in a weird way:
CLNG-BPF [test_maps] test_sig_in_xattr.bpf.oprogs/test_sig_in_xattr.c:36:26: error: invalid application of 'sizeof' to an incomplete type 'structfsverity_digest'
36 | char digest[MAGIC_SIZE +sizeof(struct fsverity_digest)+Quoted 5 lines
SHA256_DIGEST_SIZE]; | ^ ~~~~~~~~~~~~~~~~~~~~~~~~Is there a way to somehow print a hint during the build what configs users need to enable to pass the build ?
Quoted 7 lines
Patch 5/6 added
CONFIG_FS_VERITYtotools/testing/selftests/bpf/config. This is a more general question for all required CONFIG_* specified in the file (and the config files for other selftests).In selftests/bpf/Makefile, we have logic to find vmlinux. We can add similar logic to find .config used to build the vmlinux, and grep for each required CONFIG_* from the .config file. Does this sound like a viable solution?
No need for new logic to parse .config.
libbpf does it already and
extern boolCONFIG_FS_VERITY__kconfig__weak;
works.Since you hard code
MAGIC_SIZEanyway I'm asking
to hard codesizeof(struct fsverity_digest)as well, since the bpf prog doesn't access it directly. It only needs to know its size.While inside:
intBPF_PROG(test_file_open, struct file *f)
{
Quoted 6 lines
if (!CONFIG_FS_VERITY) { skip_fs_verity_test = true; return 0;}
and report it as a clean error message in
test_progs.
Yeah, this makes sense. Let me update the tests.
Thanks,
Song
Quoted 12 lines
We keep adding new config requirements selftests/bpf/config which forces all developers to keep adding new configs to their builds. In the past, when we didn't have BPF CI, that was necessary, but now BPF CI does it for us.
With clean error message fromtest_progsthe developers can either ignore the error and proceed with their work or adjust their .config eventually. While hard selftest build error forces all devs to update .config right away and build error has no info of what needs to be done which is not developer friendly.pw-bot: cr
Song Liu
maintainerRe: [PATCH v14 bpf-next 6/6] selftests/bpf: Add test that uses fsverity and xattr to sign a file
Quoted 49 lines · Song Liu
Quoted 46 lines · Alexei Starovoitov
Quoted 19 lines · Song Liu
Quoted 10 lines · Alexei Starovoitov
Quoted 1 line · Song Liu
+char digest[MAGIC_SIZE +
sizeof(struct fsverity_digest)+SHA256_DIGEST_SIZE];when vmlinux is built without
CONFIG_FS_VERITYthe above fails in a weird way:
CLNG-BPF [test_maps] test_sig_in_xattr.bpf.oprogs/test_sig_in_xattr.c:36:26: error: invalid application of 'sizeof' to an incomplete type 'structfsverity_digest'
36 | char digest[MAGIC_SIZE +sizeof(struct fsverity_digest)+Quoted 5 lines
SHA256_DIGEST_SIZE]; | ^ ~~~~~~~~~~~~~~~~~~~~~~~~Is there a way to somehow print a hint during the build what configs users need to enable to pass the build ?
Quoted 7 lines
Patch 5/6 added
CONFIG_FS_VERITYtotools/testing/selftests/bpf/config. This is a more general question for all required CONFIG_* specified in the file (and the config files for other selftests).In selftests/bpf/Makefile, we have logic to find vmlinux. We can add similar logic to find .config used to build the vmlinux, and grep for each required CONFIG_* from the .config file. Does this sound like a viable solution?
No need for new logic to parse .config.
libbpf does it already and
extern boolCONFIG_FS_VERITY__kconfig__weak;
works.Since you hard code
MAGIC_SIZEanyway I'm asking
to hard codesizeof(struct fsverity_digest)as well, since the bpf prog doesn't access it directly. It only needs to know its size.While inside:
intBPF_PROG(test_file_open, struct file *f)
{if (!CONFIG_FS_VERITY) { skip_fs_verity_test = true; return 0;}
Quoted 3 lines
Quoted 1 line
and report it as a clean error message in
test_progs.Yeah, this makes sense. Let me update the tests.
Actually, it is easier. We already have skip-test logic for cases where FS verity is not supported (as we need to enable it in vmlinux and enable it per filesystem). So we only need to hard code sizeof(struct fsverity_digest).
Thanks,
Song
kernel test robot
build botRe: [PATCH v14 bpf-next 6/6] selftests/bpf: Add test that uses fsverity and xattr to sign a file
In reply to Song Liukernel test robot noticed the following build errors:
Hi Song,
kernel test robot noticed the following build errors:
[auto build test ERROR on bpf-next/master]
url: https://github.com/intel-lab-lkp/linux/commits/Song-Liu/bpf-Add-kfunc-bpf_get_file_xattr/20231129-084133 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master patch link: https://lore.kernel.org/r/20231129003656.1165061-7-song%40kernel.org patch subject: [PATCH v14 bpf-next 6/6] selftests/bpf: Add test that uses fsverity and xattr to sign a file compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231130/[email protected]/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
All errors (new ones prefixed by >>):
>> progs/test_sig_in_xattr.c:36:26: error: invalid application of 'sizeof' to an incomplete type 'struct fsverity_digest'
36 | char digest[MAGIC_SIZE + sizeof(struct fsverity_digest) + SHA256_DIGEST_SIZE];
| ^ ~~~~~~~~~~~~~~~~~~~~~~~~
progs/test_sig_in_xattr.c:36:40: note: forward declaration of 'struct fsverity_digest'
36 | char digest[MAGIC_SIZE + sizeof(struct fsverity_digest) + SHA256_DIGEST_SIZE];
| ^1 error generated.
Signature · 2 lines
0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki