bpf: File verification with LSM and fsverity
Status from this message: This series was applied to bpf/bpf-next.git (master)
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v15 Latest6 patches 0 repliesApplied 6/6
- v146 patches 6 repliesSuperseded
- v136 patches 13 repliesSuperseded
Earlier versions · 12
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v12 | 9 patches | 9 replies | Superseded | |
| v11 | 9 patches | 0 replies | Superseded | |
| v10 | 9 patches | 8 replies | Superseded | |
| v9 | 9 patches | 1 reply | Superseded | |
| v8 | 9 patches | 2 replies | Superseded | |
| v7 | 9 patches | 1 reply | Superseded | |
| v6 | 9 patches | 12 replies | Superseded | |
| v5 | 9 patches | 2 replies | Superseded | |
| v4 | 9 patches | 4 replies | Superseded | |
| v3 | 9 patches | 0 replies | Superseded | |
| v2 | 9 patches | 2 replies | Superseded | |
| v1 | 5 patches | 18 replies | Superseded |
Changes in v15 from the cover letter
1. Fix selftest build without CONFIG_FS_VERITY. (Alexei)
2. Add Acked-by from KP.
Patches in v15 All 6 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | bpf: Add kfunc bpf_get_file_xattrkernel/ | +67 | 0 replies | Applied |
| 2/6 | bpf, fsverity: Add kfunc bpf_get_fsverity_digestfs/ fs/ fs/ | +95 | 0 replies | Applied |
| 3/6 | Documentation/bpf: Add documentation for filesystem kfuncsDocumentation/ Documentation/ | +22 | 0 replies | Applied |
| 4/6 | selftests/bpf: Sort config in alphabetic ordertools/ | +1 | 0 replies | Applied |
| 5/6 | selftests/bpf: Add tests for filesystem kfuncstools/ tools/ tools/ +2 more | +223 | 0 replies | Applied |
| 6/6 | selftests/bpf: Add test that uses fsverity and xattr to sign a filetools/ tools/ tools/ +2 more | +280 | 0 replies | Applied |
Reviews trailers per patch
2 of 6 patches have a Reviewed-by or Acked-by.
| Patch | Christian Brauner | KP Singh | Eric Biggers |
|---|---|---|---|
| 1/6 | A-b | A-b | |
| 2/6 | A-b | ||
| 3/6 | |||
| 4/6 | |||
| 5/6 | |||
| 6/6 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v15 bpf-next 0/6] bpf: File verification with LSM and fsverity
Changes v14 => v15:
1. Fix selftest build without CONFIG_FS_VERITY. (Alexei)
2. Add Acked-by from KP.
Changes v13 => v14:
1. Add "static" for bpf_fs_kfunc_set.
2. Add Acked-by from Christian Brauner.
Changes v12 => v13:
1. Only keep 4/9 through 9/9 of v12, as the first 3 patches already applied;
2. Use new macro __bpf_kfunc_[start|end]_defs().
Changes v11 => v12:
1. Fix typo (data_ptr => sig_ptr) in bpf_get_file_xattr().
Changes v10 => v11:
1. Let __bpf_dynptr_data() return const void *. (Andrii)
2. Optimize code to reuse output from __bpf_dynptr_size(). (Andrii)
3. Add __diag_ignore_all("-Wmissing-declarations") for kfunc definition.
4. Fix an off indentation. (Andrii)
Changes v9 => v10:
1. Remove WARN_ON_ONCE() from check_reg_const_str. (Alexei)
Changes v8 => v9:
1. Fix test_progs kfunc_dynptr_param/dynptr_data_null.
Changes v7 => v8:
1. Do not use bpf_dynptr_slice* in the kernel. Add __bpf_dynptr_data* and use them in ther kernel. (Andrii)
Changes v6 => v7:
1. Change "__const_str" annotation to "__str". (Alexei, Andrii)
2. Add KF_TRUSTED_ARGS flag for both new kfuncs. (KP)
3. Only allow bpf_get_file_xattr() to read xattr with "user." prefix.
4. Add Acked-by from Eric Biggers.
Changes v5 => v6:
1. Let fsverity_init_bpf() return void. (Eric Biggers)
2. Sort things in alphabetic orders. (Eric Biggers)
Changes v4 => v5:
1. Revise commit logs. (Alexei)
Changes v3 => v4:
1. Fix error reported by CI.
2. Update comments of bpf_dynptr_slice* that they may return error pointer.
Changes v2 => v3:
1. Rebase and resolve conflicts.
Changes v1 => v2:
1. Let bpf_get_file_xattr() use const string for arg "name". (Alexei)
2. Add recursion prevention with allowlist. (Alexei)
3. Let bpf_get_file_xattr() use __vfs_getxattr() to avoid recursion, as vfs_getxattr() calls into other LSM hooks.
4. Do not use dynptr->data directly, use helper insteadd. (Andrii)
5. Fixes with bpf_get_fsverity_digest. (Eric Biggers)
6. Add documentation. (Eric Biggers)
7. Fix some compile warnings. (kernel test robot)
This set enables file verification with BPF LSM and fsverity.
In this solution, fsverity is used to provide reliable and efficient hash of files; and BPF LSM is used to implement signature verification (against asymmetric keys), and to enforce access control.
This solution can be used to implement access control in complicated cases. For example: only signed python binary and signed python script and access special files/devices/ports.
Thanks,
Song
Song Liu (6):
bpf: Add kfunc bpf_get_file_xattr
bpf, fsverity: Add kfunc bpf_get_fsverity_digest Documentation/bpf: Add documentation for filesystem kfuncs selftests/bpf: Sort config in alphabetic order selftests/bpf: Add tests for filesystem kfuncs selftests/bpf: Add test that uses fsverity and xattr to sign a file
Documentation/bpf/fs_kfuncs.rst | 21 +++ Documentation/bpf/index.rst | 1 + fs/verity/fsverity_private.h | 10 ++ fs/verity/init.c | 1 + fs/verity/measure.c | 84 +++++++++ kernel/trace/bpf_trace.c | 67 +++++++ tools/testing/selftests/bpf/bpf_kfuncs.h | 10 ++ tools/testing/selftests/bpf/config | 3 +- .../selftests/bpf/prog_tests/fs_kfuncs.c | 134 ++++++++++++++ .../bpf/prog_tests/verify_pkcs7_sig.c | 165 +++++++++++++++++- .../selftests/bpf/progs/test_fsverity.c | 48 +++++ .../selftests/bpf/progs/test_get_xattr.c | 37 ++++ .../selftests/bpf/progs/test_sig_in_xattr.c | 83 +++++++++ .../bpf/progs/test_verify_pkcs7_sig.c | 8 +- .../testing/selftests/bpf/verify_sig_setup.sh | 25 +++ 15 files changed, 688 insertions(+), 9 deletions(-) create mode 100644 Documentation/bpf/fs_kfuncs.rst create mode 100644 tools/testing/selftests/bpf/prog_tests/fs_kfuncs.c create mode 100644 tools/testing/selftests/bpf/progs/test_fsverity.c create mode 100644 tools/testing/selftests/bpf/progs/test_get_xattr.c create mode 100644 tools/testing/selftests/bpf/progs/test_sig_in_xattr.c
--
2.34.1