Skip to contentSkip to conversation

Add device tree for IBM system1 BMC

PATCH Superseded Ninad Palsule 3 participants 8 messages Jan 8, 2024 – Jan 9, 2024

Subsystems (3)

v2 of 5 Superseded Latest is v5 →

lore
Share & tools
lore
#0 lore raw

v2 cover Add device tree for IBM system1 BMC

This patchset adds device tree for IBM system1 bmc board.

Change log:
v1:
- Added device binding for IBM system1-bmc
- Added device binding for TIS I2C devices
- Added device tree for IBM system1 BMC board
- Added i2c and muxes
- Added voltage regulators
- Added GPIO, Fan ctrl, Led
- Added more compatible strings for tpm_tis_i2c
- Added power supplies, sensors, EEPROMS, TPM and more

v2:
- Incorporated review comments from Conor Dooley, Jarkko Sakkinen, Guenter Roeck, Rob Herring, Krzysztof Kozlowski
- Merge all patches into single patch.
- Split the trivial device patch.
- Cleanup commit messages.
- Fixed bootargs string.
- Fixed node names.
- Dropped tpm schema patch as it is covered by Lukas's patch.
- Dropped "tpm: tis-i2c: Add more compatible strings" patch and send it as a separate patch.

Andrew Geissler (1):
ARM: dts: aspeed: System1: IBM system1 BMC board

Ninad Palsule (2):
dt-bindings: arm: aspeed: add IBM system1-bmc
dt-bindings: Add DPS310 as trivial device

 .../bindings/arm/aspeed/aspeed.yaml           |    1 +
 .../devicetree/bindings/trivial-devices.yaml  |    2 +
 arch/arm/boot/dts/aspeed/Makefile             |    1 +
 .../dts/aspeed/aspeed-bmc-ibm-system1.dts     | 1623 +++++++++++++++++
 4 files changed, 1627 insertions(+)
 create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts
Signature · 1 line
2.39.2
#1 lore raw

PATCH v2 1/3 dt-bindings: arm: aspeed: add IBM system1-bmc

Document the new compatibles used on IBM system1-bmc

---
 Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml +1 -0
index 68f717670f78..093b28f4ecba 100644
@@ -82,6 +82,7 @@ properties:
               - facebook,yosemite4-bmc
               - ibm,everest-bmc
               - ibm,rainier-bmc
+              - ibm,system1-bmc
               - ibm,tacoma-bmc
               - inventec,starscream-bmc
               - inventec,transformer-bmc
Signature · 1 line
2.39.2
#3 lore raw

PATCH v2 2/3 dt-bindings: Add DPS310 as trivial device

In reply to Ninad Palsule

Infineon DPS310 is a barometric pressure and temperature sensor.

---
 Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/trivial-devices.yaml +2 -0
index 430a814f64a5..22b7a29876d3 100644
@@ -133,6 +133,8 @@ properties:
           - ibm,cffps1
             # IBM Common Form Factor Power Supply Versions 2
           - ibm,cffps2
+            # Infineon barometric pressure and temperature sensor
+          - infineon,dps310
             # Infineon IR36021 digital POL buck controller
           - infineon,ir36021
             # Infineon IR38060 Voltage Regulator
Signature · 1 line
2.39.2
#5 lore raw

PATCH v2 3/3 ARM: dts: aspeed: System1: IBM system1 BMC board

In reply to Ninad Palsule

From: Andrew Geissler <[email protected]>

Add a device tree for IBM system1 BMC board. It uses AST2600 SOC.
- Added base board
- Added i2c devices and muxes.
- Added different voltage regulators.
- Added GPIO pin assignements, GPIO expansion devices
- Added LED brinker devices
- Added Fan controllers
- Added EEPROM/VPD
- Added Power supplies
- Added Humidity, pressure and temperature sensors.
- Added Trusted platform module(TPM) chip

Tested:
This board is tested using the simics simulator.

---
v2:
- Incorporated review comments from Conor Dooley, Jarkko Sakkinen, Guenter Roeck, Rob Herring, Krzysztof Kozlowski
- Merge all patches into single patch.
- Split the trivial device patch.
- Cleanup commit messages.
- Fixed bootargs string.
- Fixed node names.
- Dropped tpm schema patch as it is covered by Lukas's patch.
- Dropped "tpm: tis-i2c: Add more compatible strings" patch and send it as a separate patch.

---
 arch/arm/boot/dts/aspeed/Makefile             |    1 +
 .../dts/aspeed/aspeed-bmc-ibm-system1.dts     | 1623 +++++++++++++++++
 2 files changed, 1624 insertions(+)
 create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts
arch/arm/boot/dts/aspeed/Makefile +1 -0
index 23cbc7203a8e..d551aed79286 100644
@@ -32,6 +32,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
 	aspeed-bmc-ibm-rainier.dtb \
 	aspeed-bmc-ibm-rainier-1s4u.dtb \
 	aspeed-bmc-ibm-rainier-4u.dtb \
+	aspeed-bmc-ibm-system1.dtb \
 	aspeed-bmc-intel-s2600wf.dtb \
 	aspeed-bmc-inspur-fp5280g2.dtb \
 	aspeed-bmc-inspur-nf5280m6.dtb \
arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts new file +1623 -0

1,623 lines not on this page · raw message

Signature · 1 line
2.39.2
#6 lore raw

Re: [PATCH v2 3/3] ARM: dts: aspeed: System1: IBM system1 BMC board

arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts line 487

Quoted 13 lines · Ninad Palsule
arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts new file +13 -0
+	regulator at 60 {
+		compatible = "maxim,max8952";
+		reg = <0x60>;
+
+		max8952,default-mode = <0>;
+		max8952,dvs-mode-microvolt = <1250000>, <1200000>,
+						<1050000>, <950000>;
+		max8952,sync-freq = <0>;
+		max8952,ramp-speed = <0>;
+
+		regulator-name = "VR_1.0V";
+		regulator-min-microvolt = <770000>;
+		regulator-max-microvolt = <1400000>;

A regulator labelled VR_1.0V can vary between 0.77V and 1.4V and has
exactly the same configuration as another regulator labelled VR_1.2V?
That seems... odd?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linux-aspeed/attachments/20240108/958e027d/attachment.sig>

#7 lore raw

Re: [PATCH v2 3/3] ARM: dts: aspeed: System1: IBM system1 BMC board

Hello Mark,

Quoted 18 lines · Mark Brown

arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts line 487

Quoted 13 lines · Ninad Palsule
arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts new file +13 -0
+	regulator at 60 {
+		compatible = "maxim,max8952";
+		reg = <0x60>;
+
+		max8952,default-mode = <0>;
+		max8952,dvs-mode-microvolt = <1250000>, <1200000>,
+						<1050000>, <950000>;
+		max8952,sync-freq = <0>;
+		max8952,ramp-speed = <0>;
+
+		regulator-name = "VR_1.0V";
+		regulator-min-microvolt = <770000>;
+		regulator-max-microvolt = <1400000>;

A regulator labelled VR_1.0V can vary between 0.77V and 1.4V and has exactly the same configuration as another regulator labelled VR_1.2V? That seems... odd?

That was a typo. I fixed it.

Thanks for the review.

Regards,

Ninad