Add device tree for IBM system1 BMC
Subsystems (3)
v4 cover Add device tree for IBM system1 BMC
This patchset adds device tree for IBM system1 bmc board.
Change log:
v1:
- Added device binding for IBM system1-bmc
- Added device binding for TIS I2C devices
- Added device tree for IBM system1 BMC board
- Added i2c and muxes
- Added voltage regulators
- Added GPIO, Fan ctrl, Led
- Added more compatible strings for tpm_tis_i2c
- Added power supplies, sensors, EEPROMS, TPM and more
v2:
- Incorporated review comments from Conor Dooley, Jarkko Sakkinen, Guenter Roeck, Rob Herring, Krzysztof Kozlowski
- Merge all patches into single patch.
- Split the trivial device patch.
- Cleanup commit messages.
- Fixed bootargs string.
- Fixed node names.
- Dropped tpm schema patch as it is covered by Lukas's patch.
- Dropped "tpm: tis-i2c: Add more compatible strings" patch and send it as a separate patch.
v3:
- Fixed voltage-regulators names.
- Updated commit message about TPM compatibility string.
v4:
- Removed compatibility string "nuvoton,npct75x" from TPM
Andrew Geissler (1):
ARM: dts: aspeed: System1: IBM system1 BMC board
Ninad Palsule (2):
dt-bindings: arm: aspeed: add IBM system1-bmc
dt-bindings: Add DPS310 as trivial device
.../bindings/arm/aspeed/aspeed.yaml | 1 + .../devicetree/bindings/trivial-devices.yaml | 2 + arch/arm/boot/dts/aspeed/Makefile | 1 + .../dts/aspeed/aspeed-bmc-ibm-system1.dts | 1623 +++++++++++++++++ 4 files changed, 1627 insertions(+) create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts
Signature · 1 line
2.39.2
PATCH v4 1/3 dt-bindings: arm: aspeed: add IBM system1-bmc
Document the new compatibles used on IBM system1-bmc
--- Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml +1 -0
@@ -82,6 +82,7 @@ properties: - facebook,yosemite4-bmc - ibm,everest-bmc - ibm,rainier-bmc + - ibm,system1-bmc - ibm,tacoma-bmc - inventec,starscream-bmc - inventec,transformer-bmc
Signature · 1 line
2.39.2
PATCH v4 2/3 dt-bindings: Add DPS310 as trivial device
In reply to Ninad PalsuleInfineon DPS310 is a barometric pressure and temperature sensor.
--- Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++ 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/trivial-devices.yaml +2 -0
@@ -133,6 +133,8 @@ properties: - ibm,cffps1 # IBM Common Form Factor Power Supply Versions 2 - ibm,cffps2 + # Infineon barometric pressure and temperature sensor + - infineon,dps310 # Infineon IR36021 digital POL buck controller - infineon,ir36021 # Infineon IR38060 Voltage Regulator
Signature · 1 line
2.39.2
Re: [PATCH v4 2/3] dt-bindings: Add DPS310 as trivial device
Quoted 8 lines · Ninad Palsule
Infineon DPS310 is a barometric pressure and temperature sensor.
Signed-off-by Ninad Palsule <[email protected]>--- Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++ 1 file changed, 2 insertions(+)
Applied, thanks!
Re: [PATCH v4 2/3] dt-bindings: Add DPS310 as trivial device
Hello Rob,
Thank you!
Quoted 11 lines · Rob Herring
Quoted 8 lines · Ninad Palsule
Infineon DPS310 is a barometric pressure and temperature sensor.
Signed-off-by Ninad Palsule <[email protected]>--- Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++ 1 file changed, 2 insertions(+)Applied, thanks!
PATCH v4 3/3 ARM: dts: aspeed: System1: IBM system1 BMC board
In reply to Ninad PalsuleFrom: Andrew Geissler <[email protected]>
Add a device tree for IBM system1 BMC board. It uses AST2600 SOC.
- Added base board
- Added i2c devices and muxes.
- Added different voltage regulators.
- Added GPIO pin assignements, GPIO expansion devices
- Added LED brinker devices
- Added Fan controllers
- Added EEPROM/VPD
- Added Power supplies
- Added Humidity, pressure and temperature sensors.
- Added Trusted platform module(TPM) chip.
Tested:
This board is tested using the simics simulator.
---
The compatibility string and schema for tpm device is documented in the
following patch series:
-https://lore.kernel.org/all/77fe0ccd-53ff-4773-9787-0d038434297f at linux.ibm.com/ -https://lore.kernel.org/all/3f56f0a2bb90697a23e83583a21684b75dc7eea2.1701093036.git.lukas at wunner.de/
v4:
- Removed the compatibility string "nuvoton,npct75x" from tpm node as per the Conor's review comment.
v3:
- Fixed the voltage-regulator names.
v2:
- Incorporated review comments from Conor Dooley, Jarkko Sakkinen, Guenter Roeck, Rob Herring, Krzysztof Kozlowski
- Merge all patches into single patch.
- Split the trivial device patch.
- Cleanup commit messages.
- Fixed bootargs string.
- Fixed node names.
- Dropped tpm schema patch as it is covered by Lukas's patch.
- Dropped "tpm: tis-i2c: Add more compatible strings" patch and send it as a separate patch.
--- arch/arm/boot/dts/aspeed/Makefile | 1 + .../dts/aspeed/aspeed-bmc-ibm-system1.dts | 1623 +++++++++++++++++ 2 files changed, 1624 insertions(+) create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts
arch/arm/boot/dts/aspeed/Makefile +1 -0
@@ -32,6 +32,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \ aspeed-bmc-ibm-rainier.dtb \ aspeed-bmc-ibm-rainier-1s4u.dtb \ aspeed-bmc-ibm-rainier-4u.dtb \ + aspeed-bmc-ibm-system1.dtb \ aspeed-bmc-intel-s2600wf.dtb \ aspeed-bmc-inspur-fp5280g2.dtb \ aspeed-bmc-inspur-nf5280m6.dtb \
arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts new file +1623 -0
1,623 lines not on this page · raw message
Signature · 1 line
2.39.2
Re: [PATCH v4 3/3] ARM: dts: aspeed: System1: IBM system1 BMC board
Quoted 4 lines · Ninad Palsule
From: Andrew Geissler <[email protected]>
Add a device tree for IBM system1 BMC board. It uses AST2600 SOC.
- Added base board
s/Added/Add/ to match first sentence.
Quoted 4 lines
- Added i2c devices and muxes.
- Added different voltage regulators.
- Added GPIO pin assignements, GPIO expansion devices
- Added LED brinker devices
"brinker"? "blinker" maybe (no idea what it actually is).
Quoted 1 line
- Added Fan controllers
s/Fan/fan/
Quoted 2 lines
- Added EEPROM/VPD
- Added Power supplies
s/Power/power/
Quoted 1 line
- Added Humidity, pressure and temperature sensors.
s/Humidity/humidity/
Quoted 1 line
- Added Trusted platform module(TPM) chip.
s/Trusted platform module/Trusted Platform Module /
Quoted 5 lines
Tested:
This board is tested using the simics simulator.Signed-off-by Ninad Palsule <[email protected]>Signed-off-by Andrew Geissler <[email protected]>
Your sign-off should be last since you are sending the series.
Re: [PATCH v4 3/3] ARM: dts: aspeed: System1: IBM system1 BMC board
Hello Bjorn,
Quoted 6 lines · Bjorn Helgaas
Quoted 4 lines · Ninad Palsule
From: Andrew Geissler <[email protected]>
Add a device tree for IBM system1 BMC board. It uses AST2600 SOC.
- Added base boards/Added/Add/ to match first sentence.
Fixed
Quoted 6 lines
Quoted 5 lines
- Added i2c devices and muxes.
- Added different voltage regulators.
- Added GPIO pin assignements, GPIO expansion devices
- Added LED brinker devices"brinker"? "blinker" maybe (no idea what it actually is).
Fixed. Its blinker.
Quoted 2 lines
Quoted 1 line
- Added Fan controllers
s/Fan/fan/
Fixed.
Quoted 4 lines
Quoted 3 lines
- Added EEPROM/VPD
- Added Power suppliess/Power/power/
Fixed.
Quoted 3 lines
Quoted 2 lines
- Added Humidity, pressure and temperature sensors.
s/Humidity/humidity/
Fixed.
Quoted 3 lines
Quoted 2 lines
- Added Trusted platform module(TPM) chip.
s/Trusted platform module/Trusted Platform Module /
Fixed
Quoted 7 lines
Quoted 6 lines
Tested:
This board is tested using the simics simulator.Signed-off-by Ninad Palsule <[email protected]>Signed-off-by Andrew Geissler <[email protected]>Your sign-off should be last since you are sending the series.
Fixed.
Thanks for the review.
Regards,
Ninad Palsule