Skip to contentSkip to conversation

RISC-V: Modularize common match conditions for trigger

PATCH Superseded Alvin Chang via 3 participants 10 messages Feb 23, 2024 – Feb 26, 2024 RISC-V

v2 of 6 Superseded Latest is v6 →

lore
Share & tools
lore
#0 lore raw

v2 cover RISC-V: Modularize common match conditions for trigger

According to RISC-V Debug specification, the enabled privilege levels of the trigger is common match conditions for all the types of the trigger. This series modularize the code for checking the privilege levels of type 2/3/6 triggers by implementing functions trigger_common_match() and trigger_priv_match().

Additional match conditions, such as CSR tcontrol and textra, can be further implemented into trigger_common_match() in the future.

Changes from v1:
- Fix typo
- Add commit description for changing behavior of looping the triggers when we check type 2 triggers.

Alvin Chang (4):
target/riscv: Add functions for common matching conditions of trigger target/riscv: Apply modularized matching conditions for breakpoint target/riscv: Apply modularized matching conditions for watchpoint target/riscv: Apply modularized matching conditions for icount trigger

 target/riscv/debug.c | 124 +++++++++++++++++++++++++++++--------------
 1 file changed, 83 insertions(+), 41 deletions(-)
Signature · 1 line
2.34.1
#1 lore raw

PATCH v2 1/4 target/riscv: Add functions for common matching conditions of trigger

According to RISC-V Debug specification, there are several common matching conditions before firing a trigger, including the enabled privilege levels of the trigger.

This commit adds trigger_common_match() to prepare the common matching conditions for the type 2/3/6 triggers. For now, we just implement trigger_priv_match() to check if the enabled privilege levels of the trigger match CPU's current privilege level.

---
 target/riscv/debug.c | 70 ++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 70 insertions(+)
target/riscv/debug.c +70 -0
index e30d99cc2f..3891236b82 100644
@@ -241,6 +241,76 @@ static void do_trigger_action(CPURISCVState *env, target_ulong trigger_index)
     }
 }
 
+/*
+ * Check the privilege level of specific trigger matches CPU's current privilege
+ * level.
+ */
+static bool trigger_priv_match(CPURISCVState *env, trigger_type_t type,
+                               int trigger_index)
+{
+    target_ulong ctrl = env->tdata1[trigger_index];
+
+    switch (type) {
+    case TRIGGER_TYPE_AD_MATCH:
+        /* type 2 trigger cannot be fired in VU/VS mode */
+        if (env->virt_enabled) {
+            return false;
+        }
+        /* check U/S/M bit against current privilege level */
+        if ((ctrl >> 3) & BIT(env->priv)) {
+            return true;
+        }
+        break;
+    case TRIGGER_TYPE_AD_MATCH6:
+        if (env->virt_enabled) {
+            /* check VU/VS bit against current privilege level */
+            if ((ctrl >> 23) & BIT(env->priv)) {
+                return true;
+            }
+        } else {
+            /* check U/S/M bit against current privilege level */
+            if ((ctrl >> 3) & BIT(env->priv)) {
+                return true;
+            }
+        }
+        break;
+    case TRIGGER_TYPE_INST_CNT:
+        if (env->virt_enabled) {
+            /* check VU/VS bit against current privilege level */
+            if ((ctrl >> 25) & BIT(env->priv)) {
+                return true;
+            }
+        } else {
+            /* check U/S/M bit against current privilege level */
+            if ((ctrl >> 6) & BIT(env->priv)) {
+                return true;
+            }
+        }
+        break;
+    case TRIGGER_TYPE_INT:
+    case TRIGGER_TYPE_EXCP:
+    case TRIGGER_TYPE_EXT_SRC:
+        qemu_log_mask(LOG_UNIMP, "trigger type: %d is not supported\n", type);
+        break;
+    case TRIGGER_TYPE_NO_EXIST:
+    case TRIGGER_TYPE_UNAVAIL:
+        qemu_log_mask(LOG_GUEST_ERROR, "trigger type: %d does not exist\n",
+                      type);
+        break;
+    default:
+        g_assert_not_reached();
+    }
+
+    return false;
+}
+
+/* Common matching conditions for all types of the triggers. */
+static bool trigger_common_match(CPURISCVState *env, trigger_type_t type,
+                                 int trigger_index)
+{
+    return trigger_priv_match(env, type, trigger_index);
+}
+
 /* type 2 trigger */
 
 static uint32_t type2_breakpoint_size(CPURISCVState *env, target_ulong ctrl)
Signature · 1 line
2.34.1
#2 lore raw

PATCH v2 2/4 target/riscv: Apply modularized matching conditions for breakpoint

In reply to Alvin Chang via

We have implemented trigger_common_match(), which checks if the enabled privilege levels of the trigger match CPU's current privilege level. Remove the related code in riscv_cpu_debug_check_breakpoint() and invoke trigger_common_match() to check the privilege levels of the type 2 and type 6 triggers for the breakpoints.

This commit also changes the behavior of looping the triggers. In previous implementation, if we have a type 2 trigger and env->virt_enabled is true, we directly return false to stop the loop. Now we keep looping all the triggers until we find a matched trigger.

Only the execution bit and the executed PC should be futher checked in riscv_cpu_debug_check_breakpoint().

---
 target/riscv/debug.c | 26 ++++++--------------------
 1 file changed, 6 insertions(+), 20 deletions(-)
target/riscv/debug.c +6 -20
index 3891236b82..b7b0fa8945 100644
@@ -855,21 +855,17 @@ bool riscv_cpu_debug_check_breakpoint(CPUState *cs)
         for (i = 0; i < RV_MAX_TRIGGERS; i++) {
             trigger_type = get_trigger_type(env, i);
 
+            if (!trigger_common_match(env, trigger_type, i)) {
+                continue;
+            }
+
             switch (trigger_type) {
             case TRIGGER_TYPE_AD_MATCH:
-                /* type 2 trigger cannot be fired in VU/VS mode */
-                if (env->virt_enabled) {
-                    return false;
-                }
-
                 ctrl = env->tdata1[i];
                 pc = env->tdata2[i];
 
                 if ((ctrl & TYPE2_EXEC) && (bp->pc == pc)) {
-                    /* check U/S/M bit against current privilege level */
-                    if ((ctrl >> 3) & BIT(env->priv)) {
-                        return true;
-                    }
+                    return true;
                 }
                 break;
             case TRIGGER_TYPE_AD_MATCH6:
@@ -877,17 +873,7 @@ bool riscv_cpu_debug_check_breakpoint(CPUState *cs)
                 pc = env->tdata2[i];
 
                 if ((ctrl & TYPE6_EXEC) && (bp->pc == pc)) {
-                    if (env->virt_enabled) {
-                        /* check VU/VS bit against current privilege level */
-                        if ((ctrl >> 23) & BIT(env->priv)) {
-                            return true;
-                        }
-                    } else {
-                        /* check U/S/M bit against current privilege level */
-                        if ((ctrl >> 3) & BIT(env->priv)) {
-                            return true;
-                        }
-                    }
+                    return true;
                 }
                 break;
             default:
Signature · 1 line
2.34.1
Reviewed-by on v2 2/4
#3 lore raw

Re: [PATCH v2 2/4] target/riscv: Apply modularized matching conditions for breakpoint

Quoted 12 lines · Alvin Chang via

We have implemented trigger_common_match(), which checks if the enabled privilege levels of the trigger match CPU's current privilege level. Remove the related code in riscv_cpu_debug_check_breakpoint() and invoke trigger_common_match() to check the privilege levels of the type 2 and type 6 triggers for the breakpoints.

This commit also changes the behavior of looping the triggers. In previous implementation, if we have a type 2 trigger and env->virt_enabled is true, we directly return false to stop the loop. Now we keep looping all the triggers until we find a matched trigger.

Quoted 4 lines

Only the execution bit and the executed PC should be futher checked in riscv_cpu_debug_check_breakpoint().

Alistair

Quoted 58 lines
---
 target/riscv/debug.c | 26 ++++++--------------------
 1 file changed, 6 insertions(+), 20 deletions(-)
target/riscv/debug.c +6 -21
index 3891236b82..b7b0fa8945 100644
@@ -855,21 +855,17 @@ bool riscv_cpu_debug_check_breakpoint(CPUState *cs)
         for (i = 0; i < RV_MAX_TRIGGERS; i++) {
             trigger_type = get_trigger_type(env, i);
 
+            if (!trigger_common_match(env, trigger_type, i)) {
+                continue;
+            }
+
             switch (trigger_type) {
             case TRIGGER_TYPE_AD_MATCH:
-                /* type 2 trigger cannot be fired in VU/VS mode */
-                if (env->virt_enabled) {
-                    return false;
-                }
-
                 ctrl = env->tdata1[i];
                 pc = env->tdata2[i];
 
                 if ((ctrl & TYPE2_EXEC) && (bp->pc == pc)) {
-                    /* check U/S/M bit against current privilege level */
-                    if ((ctrl >> 3) & BIT(env->priv)) {
-                        return true;
-                    }
+                    return true;
                 }
                 break;
             case TRIGGER_TYPE_AD_MATCH6:
@@ -877,17 +873,7 @@ bool riscv_cpu_debug_check_breakpoint(CPUState *cs)
                 pc = env->tdata2[i];
 
                 if ((ctrl & TYPE6_EXEC) && (bp->pc == pc)) {
-                    if (env->virt_enabled) {
-                        /* check VU/VS bit against current privilege level */
-                        if ((ctrl >> 23) & BIT(env->priv)) {
-                            return true;
-                        }
-                    } else {
-                        /* check U/S/M bit against current privilege level */
-                        if ((ctrl >> 3) & BIT(env->priv)) {
-                            return true;
-                        }
-                    }
+                    return true;
                 }
                 break;
             default:
--

2.34.1

#4 lore raw

PATCH v2 3/4 target/riscv: Apply modularized matching conditions for watchpoint

In reply to Alvin Chang via

We have implemented trigger_common_match(), which checks if the enabled privilege levels of the trigger match CPU's current privilege level. Remove the related code in riscv_cpu_debug_check_watchpoint() and invoke trigger_common_match() to check the privilege levels of the type 2 and type 6 triggers for the watchpoints.

This commit also changes the behavior of looping the triggers. In previous implementation, if we have a type 2 trigger and env->virt_enabled is true, we directly return false to stop the loop. Now we keep looping all the triggers until we find a matched trigger.

Only load/store bits and loaded/stored address should be further checked in riscv_cpu_debug_check_watchpoint().

---
 target/riscv/debug.c | 26 ++++++--------------------
 1 file changed, 6 insertions(+), 20 deletions(-)
target/riscv/debug.c +6 -20
index b7b0fa8945..9f9f332019 100644
@@ -899,13 +899,12 @@ bool riscv_cpu_debug_check_watchpoint(CPUState *cs, CPUWatchpoint *wp)
     for (i = 0; i < RV_MAX_TRIGGERS; i++) {
         trigger_type = get_trigger_type(env, i);
 
+        if (!trigger_common_match(env, trigger_type, i)) {
+            continue;
+        }
+
         switch (trigger_type) {
         case TRIGGER_TYPE_AD_MATCH:
-            /* type 2 trigger cannot be fired in VU/VS mode */
-            if (env->virt_enabled) {
-                return false;
-            }
-
             ctrl = env->tdata1[i];
             addr = env->tdata2[i];
             flags = 0;
@@ -918,10 +917,7 @@ bool riscv_cpu_debug_check_watchpoint(CPUState *cs, CPUWatchpoint *wp)
             }
 
             if ((wp->flags & flags) && (wp->vaddr == addr)) {
-                /* check U/S/M bit against current privilege level */
-                if ((ctrl >> 3) & BIT(env->priv)) {
-                    return true;
-                }
+                return true;
             }
             break;
         case TRIGGER_TYPE_AD_MATCH6:
@@ -937,17 +933,7 @@ bool riscv_cpu_debug_check_watchpoint(CPUState *cs, CPUWatchpoint *wp)
             }
 
             if ((wp->flags & flags) && (wp->vaddr == addr)) {
-                if (env->virt_enabled) {
-                    /* check VU/VS bit against current privilege level */
-                    if ((ctrl >> 23) & BIT(env->priv)) {
-                        return true;
-                    }
-                } else {
-                    /* check U/S/M bit against current privilege level */
-                    if ((ctrl >> 3) & BIT(env->priv)) {
-                        return true;
-                    }
-                }
+                return true;
             }
             break;
         default:
Signature · 1 line
2.34.1
#5 lore raw

PATCH v2 4/4 target/riscv: Apply modularized matching conditions for icount trigger

In reply to Alvin Chang via

We have implemented trigger_common_match(), which checks if the enabled privilege levels of the trigger match CPU's current privilege level. We can invoke trigger_common_match() to check the privilege levels of the type 3 triggers.

---
 target/riscv/debug.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
target/riscv/debug.c +1 -1
index 9f9f332019..eb45e2c147 100644
@@ -624,7 +624,7 @@ void helper_itrigger_match(CPURISCVState *env)
         if (get_trigger_type(env, i) != TRIGGER_TYPE_INST_CNT) {
             continue;
         }
-        if (check_itrigger_priv(env, i)) {
+        if (!trigger_common_match(env, TRIGGER_TYPE_INST_CNT, i)) {
             continue;
         }
         count = itrigger_get_count(env, i);
Signature · 1 line
2.34.1
#6 lore raw
In reply to Alvin Chang via
Quoted 2 lines · Alvin Chang via

According to RISC-V Debug specification, the enabled privilege levels of

Can you specify what version of the debug spec?

Ideally if you can link directly to the PDF that would be very useful. There are multiple versions so it's hard to keep track of.

Alistair

Quoted 26 lines

the trigger is common match conditions for all the types of the trigger. This series modularize the code for checking the privilege levels of type 2/3/6 triggers by implementing functions trigger_common_match() and trigger_priv_match().

Additional match conditions, such as CSR tcontrol and textra, can be further implemented into trigger_common_match() in the future.

Changes from v1:
- Fix typo
- Add commit description for changing behavior of looping the triggers when we check type 2 triggers.

Alvin Chang (4):
target/riscv: Add functions for common matching conditions of trigger target/riscv: Apply modularized matching conditions for breakpoint target/riscv: Apply modularized matching conditions for watchpoint target/riscv: Apply modularized matching conditions for icount trigger

 target/riscv/debug.c | 124 +++++++++++++++++++++++++++++--------------
 1 file changed, 83 insertions(+), 41 deletions(-)

--
2.34.1

#7 lore raw

Hi Alistair,

Quoted 12 lines

-----Original Message-----
From: Alistair Francis <[email protected]>
Sent: Monday, February 26, 2024 8:25 AM
To: Alvin Che-Chia Chang(張哲嘉) <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH v2 0/4] RISC-V: Modularize common match conditions for trigger

[EXTERNAL MAIL 外部信件]

Quoted 7 lines
Quoted 3 lines · Alvin Chang via

According to RISC-V Debug specification, the enabled privilege levels of

Can you specify what version of the debug spec?

In general, this series does not add any new functionalities.
The original implementation has duplicated code in type 2/3/6 triggers.
I just eliminated those code and modularized them to be trigger_common_match().
Besides, we may want to check other conditions in the future, so this function can be used for those purposes.

When I track the commit history, it seems the code is submitted in the following commits two years ago:
https://github.com/qemu/qemu/commit/95799e36c15a9ab602a388491c40f6860f6ae8bf
https://github.com/qemu/qemu/commit/b5f6379d134bd201d52380c73ff73565e6a4321e
https://github.com/qemu/qemu/commit/c32461d8eeb17490b1b1e969e2ce8f1ecd83bfbb
https://github.com/qemu/qemu/commit/c472c142a7552f5b0e40378d5643a2810ef1b111

Since they mentioned the "type 6" trigger and "Sdtrig" extension, I assume current implementation is based on Debug Spec version 1.0 There is no type 6 trigger and Sdtrig extension in Debug Spec version 0.13

Sincerely,
Alvin Chang

Quoted 34 lines

Ideally if you can link directly to the PDF that would be very useful. There are multiple versions so it's hard to keep track of.

Alistair

Quoted 28 lines

the trigger is common match conditions for all the types of the trigger. This series modularize the code for checking the privilege levels of type 2/3/6 triggers by implementing functions trigger_common_match() and trigger_priv_match().

Additional match conditions, such as CSR tcontrol and textra, can be further implemented into trigger_common_match() in the future.

Changes from v1:
- Fix typo
- Add commit description for changing behavior of looping the triggers when we check type 2 triggers.

Alvin Chang (4):
target/riscv: Add functions for common matching conditions of trigger target/riscv: Apply modularized matching conditions for breakpoint target/riscv: Apply modularized matching conditions for watchpoint target/riscv: Apply modularized matching conditions for icount
trigger

 target/riscv/debug.c | 124
+++++++++++++++++++++++++++++--------------
 1 file changed, 83 insertions(+), 41 deletions(-)

--
2.34.1

CONFIDENTIALITY NOTICE:

This e-mail (and its attachments) may contain confidential and legally privileged information or information protected from disclosure. If you are not the intended recipient, you are hereby notified that any disclosure, copying, distribution, or use of the information contained herein is strictly prohibited. In this case, please immediately notify the sender by return e-mail, delete the message (and any accompanying documents) and destroy all printed hard copies. Thank you for your cooperation.

Copyright ANDES TECHNOLOGY CORPORATION - All Rights Reserved.

#8 lore raw
Quoted 21 lines · Alvin Che-Chia Chang(張哲嘉)

Hi Alistair,

Quoted 18 lines

-----Original Message-----
From: Alistair Francis <[email protected]>
Sent: Monday, February 26, 2024 8:25 AM
To: Alvin Che-Chia Chang(張哲嘉) <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH v2 0/4] RISC-V: Modularize common match conditions for trigger

[EXTERNAL MAIL 外部信件]

Quoted 3 lines · Alvin Chang via

According to RISC-V Debug specification, the enabled privilege levels of

Quoted 6 lines
Quoted 1 line

Can you specify what version of the debug spec?

In general, this series does not add any new functionalities.
The original implementation has duplicated code in type 2/3/6 triggers.
I just eliminated those code and modularized them to be trigger_common_match().
Besides, we may want to check other conditions in the future, so this function can be used for those purposes.

Ah, you are right. I just skimmed the message

Quoted 9 lines

When I track the commit history, it seems the code is submitted in the following commits two years ago:
https://github.com/qemu/qemu/commit/95799e36c15a9ab602a388491c40f6860f6ae8bf
https://github.com/qemu/qemu/commit/b5f6379d134bd201d52380c73ff73565e6a4321e
https://github.com/qemu/qemu/commit/c32461d8eeb17490b1b1e969e2ce8f1ecd83bfbb
https://github.com/qemu/qemu/commit/c472c142a7552f5b0e40378d5643a2810ef1b111

Since they mentioned the "type 6" trigger and "Sdtrig" extension, I assume current implementation is based on Debug Spec version 1.0 There is no type 6 trigger and Sdtrig extension in Debug Spec version 0.13

Yeah, we are a weird mix-match of the two unfortunately. Which is why I wanted to be explicit about which debug spec version you are targeting.

Quoted 38 lines

Sincerely,
Alvin Chang

Quoted 34 lines

Ideally if you can link directly to the PDF that would be very useful. There are multiple versions so it's hard to keep track of.

Alistair

Quoted 28 lines

the trigger is common match conditions for all the types of the trigger. This series modularize the code for checking the privilege levels of type 2/3/6 triggers by implementing functions trigger_common_match() and trigger_priv_match().

Additional match conditions, such as CSR tcontrol and textra, can be further implemented into trigger_common_match() in the future.

Changes from v1:
- Fix typo
- Add commit description for changing behavior of looping the triggers when we check type 2 triggers.

Alvin Chang (4):
target/riscv: Add functions for common matching conditions of trigger target/riscv: Apply modularized matching conditions for breakpoint target/riscv: Apply modularized matching conditions for watchpoint target/riscv: Apply modularized matching conditions for icount
trigger

 target/riscv/debug.c | 124
+++++++++++++++++++++++++++++--------------
 1 file changed, 83 insertions(+), 41 deletions(-)

--
2.34.1

Quoted 5 lines

CONFIDENTIALITY NOTICE:

This e-mail (and its attachments) may contain confidential and legally privileged information or information protected from disclosure. If you are not the intended recipient, you are hereby notified that any disclosure, copying, distribution, or use of the information contained herein is strictly prohibited. In this case, please immediately notify the sender by return e-mail, delete the message (and any accompanying documents) and destroy all printed hard copies. Thank you for your cooperation.

Copyright ANDES TECHNOLOGY CORPORATION - All Rights Reserved.

I'm not sure what you want me to do here

Alistair

#9 lore raw

Hi Alistair,

Quoted 66 lines

-----Original Message-----
From: Alistair Francis <[email protected]>
Sent: Monday, February 26, 2024 2:45 PM
To: Alvin Che-Chia Chang(張哲嘉) <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH v2 0/4] RISC-V: Modularize common match conditions for trigger

[EXTERNAL MAIL 外部信件]

Quoted 20 lines · Alvin Che-Chia Chang(張哲嘉)

Hi Alistair,

Quoted 17 lines

-----Original Message-----
From: Alistair Francis <[email protected]>
Sent: Monday, February 26, 2024 8:25 AM
To: Alvin Che-Chia Chang(張哲嘉) <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH v2 0/4] RISC-V: Modularize common match conditions for trigger

[EXTERNAL MAIL 外部信件]

Quoted 1 line · Alvin Chang via
Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

According to RISC-V Debug specification, the enabled privilege levels of

Can you specify what version of the debug spec?

In general, this series does not add any new functionalities. The original implementation has duplicated code in type 2/3/6 triggers. I just eliminated those code and modularized them to be

trigger_common_match().

Quoted 1 line

Besides, we may want to check other conditions in the future, so this function

can be used for those purposes.

Ah, you are right. I just skimmed the message

Quoted 2 lines

When I track the commit history, it seems the code is submitted in the

following commits two years ago:

Quoted 1 line

https://github.com/qemu/qemu/commit/95799e36c15a9ab602a388491c40f68
60f

Quoted 2 lines

6ae8bf

https://github.com/qemu/qemu/commit/b5f6379d134bd201d52380c73ff7356
5e6

Quoted 2 lines

a4321e

https://github.com/qemu/qemu/commit/c32461d8eeb17490b1b1e969e2ce8f1
ecd

Quoted 2 lines

83bfbb

https://github.com/qemu/qemu/commit/c472c142a7552f5b0e40378d5643a28
10e

Quoted 8 lines
Quoted 5 lines

f1b111

Since they mentioned the "type 6" trigger and "Sdtrig" extension, I assume current implementation is based on Debug Spec version 1.0 There is no type 6 trigger and Sdtrig extension in Debug Spec version 0.13

Yeah, we are a weird mix-match of the two unfortunately. Which is why I wanted to be explicit about which debug spec version you are targeting.

Done, I explicitly mention the version of Debug Spec in the commit message. Please check patch v3.

Quoted 49 lines
Quoted 35 lines

Sincerely,
Alvin Chang

Quoted 30 lines

Ideally if you can link directly to the PDF that would be very useful. There are multiple versions so it's hard to keep track of.

Alistair

Quoted 24 lines

the trigger is common match conditions for all the types of the trigger. This series modularize the code for checking the privilege levels of type 2/3/6 triggers by implementing functions trigger_common_match() and trigger_priv_match().

Additional match conditions, such as CSR tcontrol and textra, can be further implemented into trigger_common_match() in the future.

Changes from v1:
- Fix typo
- Add commit description for changing behavior of looping the triggers when we check type 2 triggers.

Alvin Chang (4):
target/riscv: Add functions for common matching conditions of trigger target/riscv: Apply modularized matching conditions for breakpoint target/riscv: Apply modularized matching conditions for watchpoint target/riscv: Apply modularized matching conditions for icount
trigger

 target/riscv/debug.c | 124
+++++++++++++++++++++++++++++--------------
 1 file changed, 83 insertions(+), 41 deletions(-)
Quoted 7 lines
Quoted 4 lines
Quoted 4 lines

--
2.34.1

CONFIDENTIALITY NOTICE:

This e-mail (and its attachments) may contain confidential and legally

privileged information or information protected from disclosure. If you are not the intended recipient, you are hereby notified that any disclosure, copying, distribution, or use of the information contained herein is strictly prohibited. In this case, please immediately notify the sender by return e-mail, delete the message (and any accompanying documents) and destroy all printed hard copies. Thank you for your cooperation.

Quoted 1 line
Quoted 3 lines
Quoted 1 line

Copyright ANDES TECHNOLOGY CORPORATION - All Rights Reserved.

I'm not sure what you want me to do here

Oh.. It automatically shows up when I send email out of our company server. Please ignore it here.

Quoted 2 lines

Alistair

CONFIDENTIALITY NOTICE:

This e-mail (and its attachments) may contain confidential and legally privileged information or information protected from disclosure. If you are not the intended recipient, you are hereby notified that any disclosure, copying, distribution, or use of the information contained herein is strictly prohibited. In this case, please immediately notify the sender by return e-mail, delete the message (and any accompanying documents) and destroy all printed hard copies. Thank you for your cooperation.

Copyright ANDES TECHNOLOGY CORPORATION - All Rights Reserved.