hw/dma: Add error handling for loading descriptions failing
cover hw/dma: Add error handling for loading descriptions failing
The original code assumes that memory transmission is always successful, but in some cases, it gets bus-error.
Add error handling for DMA reading description failures. Do some reasonable settings, and return the corrected transmission size. Finally, return the error status.
base-commit: 1806da76cb81088ea026ca3441551782b850e393
Fea.Wang (4):
hw/dma: Enhance error handling in loading description hw/dma: Break the loop when loading descriptions fails hw/dma: Add a trace log for a description loading failure hw/net: Fix the transmission return size
hw/dma/trace-events | 3 +++ hw/dma/xilinx_axidma.c | 27 +++++++++++++++++++++++---- hw/net/xilinx_axienet.c | 2 +- 3 files changed, 27 insertions(+), 5 deletions(-)
Signature · 1 line
2.34.1
PATCH 1/4 hw/dma: Enhance error handling in loading description
Loading a description from memory may cause a bus-error. In this case, the DMA should stop working, set the error flag, and return the error value.
--- hw/dma/xilinx_axidma.c | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-)
hw/dma/xilinx_axidma.c +14 -2
@@ -71,8 +71,10 @@ enum {enum {DMASR_HALTED =1 ,DMASR_IDLE =2 , +DMASR_SLVERR =1 <<5 ,DMASR_IOC_IRQ =1 <<12 ,DMASR_DLY_IRQ =1 <<13 , +DMASR_ERR_IRQ =1 <<14 ,DMASR_IRQ_MASK =7 <<12 };
@@ -190,17 +192,27 @@ static inline int streamid_from_addr(hwaddr addr)return sid; } -static void stream_desc_load (struct Stream *s,hwaddr addr) +static MemTxResult stream_desc_load (struct Stream *s,hwaddr addr) {struct SDesc *d = &s->desc; -address_space_read (&s->dma->as, addr,MEMTXATTRS_UNSPECIFIED , d,sizeof *d); +MemTxResult result =address_space_read (&s->dma->as, + addr,MEMTXATTRS_UNSPECIFIED , + d,sizeof *d); +if (result !=MEMTX_OK ) { + s->regs[R_DMACR ] &= ~DMACR_RUNSTOP ; + s->regs[R_DMASR ] |=DMASR_HALTED ; + s->regs[R_DMASR ] |=DMASR_SLVERR ; + s->regs[R_DMASR ] |=DMASR_ERR_IRQ ; +return result; + }/* Convert from LE into host endianness. */ d->buffer_address =le64_to_cpu (d->buffer_address); d->nxtdesc =le64_to_cpu (d->nxtdesc); d->control =le32_to_cpu (d->control); d->status =le32_to_cpu (d->status); +return result; }static void stream_desc_store (struct Stream *s,hwaddr addr)
Signature · 1 line
2.34.1
Re: [PATCH 1/4] hw/dma: Enhance error handling in loading description
Quoted 6 lines · Fea.Wang
Loading a description from memory may cause a bus-error. In this case, the DMA should stop working, set the error flag, and return the error value.
Signed-off-by Fea.Wang <[email protected]>
Hi Fea,
I've got a couple of small comments:
---
hw/dma/xilinx_axidma.c enum { · line 75
Quoted 13 lines
hw/dma/xilinx_axidma.c | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-)hw/dma/xilinx_axidma.c +1
-0@@ -71,8 +71,10 @@ enum {enum {DMASR_HALTED =1 ,DMASR_IDLE =2 , +DMASR_SLVERR =1 <<5 ,
We should also add DMASR_DECERR = 1 << 6
Quoted 15 lines
hw/dma/xilinx_axidma.c +1
-0DMASR_IOC_IRQ =1 <<12 ,DMASR_DLY_IRQ =1 <<13 , +DMASR_ERR_IRQ =1 <<14 ,DMASR_IRQ_MASK =7 <<12 };
hw/dma/xilinx_axidma.c +1
-1@@ -190,17 +192,27 @@ static inline int streamid_from_addr(hwaddr addr)return sid; } -static void stream_desc_load (struct Stream *s,hwaddr addr) +static MemTxResult stream_desc_load (struct Stream *s,hwaddr addr) {struct SDesc *d = &s->desc;
hw/dma/xilinx_axidma.c static inline int streamid_from_addr(hwaddr addr) · line 207
Quoted 10 lines
hw/dma/xilinx_axidma.c +7
-1-address_space_read (&s->dma->as, addr,MEMTXATTRS_UNSPECIFIED , d, sizeof *d); +MemTxResult result =address_space_read (&s->dma->as, + addr,MEMTXATTRS_UNSPECIFIED , + d,sizeof *d); +if (result !=MEMTX_OK ) { + s->regs[R_DMACR ] &= ~DMACR_RUNSTOP ; + s->regs[R_DMASR ] |=DMASR_HALTED ; + s->regs[R_DMASR ] |=DMASR_SLVERR ;
... and map MEMTX_DECODE_ERROR to DMASR_DECERR and everything else to SLVERR, for example:
if (result == MEMTX_DECODE_ERROR) {
s->regs[R_DMASR] |= DMASR_DECERR;
} else {
s->regs[R_DMASR] |= DMASR_SLVERR;
}Quoted 17 lines
hw/dma/xilinx_axidma.c +4
-0+ s->regs[R_DMASR ] |=DMASR_ERR_IRQ ; +return result; + }/* Convert from LE into host endianness. */ d->buffer_address =le64_to_cpu (d->buffer_address); d->nxtdesc =le64_to_cpu (d->nxtdesc); d->control =le32_to_cpu (d->control); d->status =le32_to_cpu (d->status); +return result; }static void
stream_desc_store(struct Stream *s, hwaddr addr)
--
2.34.1
Re: [PATCH 1/4] hw/dma: Enhance error handling in loading description
Hi Edgar,
Thank you for recommending to me. I will make the change in the next version of the patch series.
Sincerely,
Fea
Quoted 85 lines · Edgar E. Iglesias
Quoted 6 lines · Fea.Wang
Loading a description from memory may cause a bus-error. In this case, the DMA should stop working, set the error flag, and return the error value.
Signed-off-by Fea.Wang <[email protected]>Hi Fea,
I've got a couple of small comments:
---
hw/dma/xilinx_axidma.c enum { · line 75
Quoted 13 lines
hw/dma/xilinx_axidma.c | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-)hw/dma/xilinx_axidma.c +1
-0@@ -71,8 +71,10 @@ enum {enum {DMASR_HALTED =1 ,DMASR_IDLE =2 , +DMASR_SLVERR =1 <<5 ,We should also add
DMASR_DECERR= 1 << 6Quoted 15 lines
hw/dma/xilinx_axidma.c +1
-0DMASR_IOC_IRQ =1 <<12 ,DMASR_DLY_IRQ =1 <<13 , +DMASR_ERR_IRQ =1 <<14 ,DMASR_IRQ_MASK =7 <<12 };
hw/dma/xilinx_axidma.c +1
-1@@ -190,17 +192,27 @@ static inline int streamid_from_addr(hwaddr addr)return sid; } -static void stream_desc_load (struct Stream *s,hwaddr addr) +static MemTxResult stream_desc_load (struct Stream *s,hwaddr addr) {struct SDesc *d = &s->desc;hw/dma/xilinx_axidma.c static inline int streamid_from_addr(hwaddr addr) · line 207
Quoted 10 lines
hw/dma/xilinx_axidma.c +7
-1-address_space_read (&s->dma->as, addr,MEMTXATTRS_UNSPECIFIED , d, sizeof *d); +MemTxResult result =address_space_read (&s->dma->as, + addr,MEMTXATTRS_UNSPECIFIED , + d,sizeof *d); +if (result !=MEMTX_OK ) { + s->regs[R_DMACR ] &= ~DMACR_RUNSTOP ; + s->regs[R_DMASR ] |=DMASR_HALTED ; + s->regs[R_DMASR ] |=DMASR_SLVERR ;... and map
MEMTX_DECODE_ERRORtoDMASR_DECERRand everything else to SLVERR, for example:if (result == MEMTX_DECODE_ERROR) { s->regs[R_DMASR] |= DMASR_DECERR; } else { s->regs[R_DMASR] |= DMASR_SLVERR; }Quoted 17 lines
hw/dma/xilinx_axidma.c +4
-0+ s->regs[R_DMASR ] |=DMASR_ERR_IRQ ; +return result; + }/* Convert from LE into host endianness. */ d->buffer_address =le64_to_cpu (d->buffer_address); d->nxtdesc =le64_to_cpu (d->nxtdesc); d->control =le32_to_cpu (d->control); d->status =le32_to_cpu (d->status); +return result; }static void
stream_desc_store(struct Stream *s, hwaddr addr)
--
2.34.1
Re: [PATCH 1/4] hw/dma: Enhance error handling in loading description
In reply to Fea.WangFea.Wang <[email protected]> 於 2024年6月3日 週一 下午1:48寫道:
Quoted 59 lines
Loading a description from memory may cause a bus-error. In this case, the DMA should stop working, set the error flag, and return the error value.
Signed-off-by Fea.Wang <[email protected]>--- hw/dma/xilinx_axidma.c | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-)hw/dma/xilinx_axidma.c +14
-3@@ -71,8 +71,10 @@ enum {enum {DMASR_HALTED =1 ,DMASR_IDLE =2 , +DMASR_SLVERR =1 <<5 ,DMASR_IOC_IRQ =1 <<12 ,DMASR_DLY_IRQ =1 <<13 , +DMASR_ERR_IRQ =1 <<14 ,DMASR_IRQ_MASK =7 <<12 };@@ -190,17 +192,27 @@ static inline int streamid_from_addr(hwaddr addr)return sid; } -static void stream_desc_load (struct Stream *s,hwaddr addr) +static MemTxResult stream_desc_load (struct Stream *s,hwaddr addr) {struct SDesc *d = &s->desc; -address_space_read (&s->dma->as, addr,MEMTXATTRS_UNSPECIFIED , d,sizeof *d); +MemTxResult result =address_space_read (&s->dma->as, + addr,MEMTXATTRS_UNSPECIFIED , + d,sizeof *d); +if (result !=MEMTX_OK ) { + s->regs[R_DMACR ] &= ~DMACR_RUNSTOP ; + s->regs[R_DMASR ] |=DMASR_HALTED ; + s->regs[R_DMASR ] |=DMASR_SLVERR ; + s->regs[R_DMASR ] |=DMASR_ERR_IRQ ; +return result; + }/* Convert from LE into host endianness. */ d->buffer_address =le64_to_cpu (d->buffer_address); d->nxtdesc =le64_to_cpu (d->nxtdesc); d->control =le32_to_cpu (d->control); d->status =le32_to_cpu (d->status); +return result; }static void stream_desc_store (struct Stream *s,hwaddr addr) --2.34.1
PATCH 2/4 hw/dma: Break the loop when loading descriptions fails
In reply to Fea.WangWhen calling the loading a description function, it should be noticed that the function may return a failure value. Breaking the loop is one of the possible ways to handle it.
--- hw/dma/xilinx_axidma.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
hw/dma/xilinx_axidma.c +6 -2
@@ -291,7 +291,9 @@ static void stream_process_mem2s(struct Stream *s, StreamSink *tx_data_dev, }while (1 ) { -stream_desc_load (s, s->regs[R_CURDESC ]); +if (MEMTX_OK !=stream_desc_load (s, s->regs[R_CURDESC ])) { +break ; + }if (s->desc.status &SDESC_STATUS_COMPLETE ) { s->regs[R_DMASR ] |=DMASR_HALTED ;
@@ -348,7 +350,9 @@ static size_t stream_process_s2mem(struct Stream *s, unsigned char *buf, }while (len) { -stream_desc_load (s, s->regs[R_CURDESC ]); +if (MEMTX_OK !=stream_desc_load (s, s->regs[R_CURDESC ])) { +break ; + }if (s->desc.status &SDESC_STATUS_COMPLETE ) { s->regs[R_DMASR ] |=DMASR_HALTED ;
Signature · 1 line
2.34.1
Re: [PATCH 2/4] hw/dma: Break the loop when loading descriptions fails
Quoted 6 lines · Fea.Wang
When calling the loading a description function, it should be noticed that the function may return a failure value. Breaking the loop is one of the possible ways to handle it.
Signed-off-by Fea.Wang <[email protected]>
Looks good, a nitpick comment, I would either squash this with patch #1 or move the change to return of error code in stream_desc_load() to this patch.
Quoted 36 lines
--- hw/dma/xilinx_axidma.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)hw/dma/xilinx_axidma.c +3
-1@@ -291,7 +291,9 @@ static void stream_process_mem2s(struct Stream *s, StreamSink *tx_data_dev, }while (1 ) { -stream_desc_load (s, s->regs[R_CURDESC ]); +if (MEMTX_OK !=stream_desc_load (s, s->regs[R_CURDESC ])) { +break ; + }if (s->desc.status &SDESC_STATUS_COMPLETE ) {s->regs[R_DMASR] |= DMASR_HALTED;hw/dma/xilinx_axidma.c +3
-1@@ -348,7 +350,9 @@ static size_t stream_process_s2mem(struct Stream *s, unsigned char *buf, }while (len) { -stream_desc_load (s, s->regs[R_CURDESC ]); +if (MEMTX_OK !=stream_desc_load (s, s->regs[R_CURDESC ])) { +break ; + }if (s->desc.status &SDESC_STATUS_COMPLETE ) {s->regs[R_DMASR] |= DMASR_HALTED;--
2.34.1
Re: [PATCH 2/4] hw/dma: Break the loop when loading descriptions fails
Hi Edgar,
thank you for the advice, I will squash them in the next version of the patch series.
Sincerely,
Fea
Quoted 53 lines · Edgar E. Iglesias
Quoted 6 lines · Fea.Wang
When calling the loading a description function, it should be noticed that the function may return a failure value. Breaking the loop is one of the possible ways to handle it.
Signed-off-by Fea.Wang <[email protected]>Looks good, a nitpick comment, I would either squash this with patch #1 or move the change to return of error code in
stream_desc_load()to this patch.Quoted 36 lines
--- hw/dma/xilinx_axidma.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)hw/dma/xilinx_axidma.c +3
-1@@ -291,7 +291,9 @@ static void stream_process_mem2s(struct Stream *s, StreamSink *tx_data_dev, }while (1 ) { -stream_desc_load (s, s->regs[R_CURDESC ]); +if (MEMTX_OK !=stream_desc_load (s, s->regs[R_CURDESC ])) { +break ; + }if (s->desc.status &SDESC_STATUS_COMPLETE ) {s->regs[R_DMASR] |= DMASR_HALTED;hw/dma/xilinx_axidma.c +3
-1@@ -348,7 +350,9 @@ static size_t stream_process_s2mem(struct Stream *s, unsigned char *buf, }while (len) { -stream_desc_load (s, s->regs[R_CURDESC ]); +if (MEMTX_OK !=stream_desc_load (s, s->regs[R_CURDESC ])) { +break ; + }if (s->desc.status &SDESC_STATUS_COMPLETE ) {s->regs[R_DMASR] |= DMASR_HALTED;--
2.34.1
Re: [PATCH 2/4] hw/dma: Break the loop when loading descriptions fails
In reply to Fea.WangFea.Wang <[email protected]> 於 2024年6月3日 週一 下午1:48寫道:
Quoted 40 lines
When calling the loading a description function, it should be noticed that the function may return a failure value. Breaking the loop is one of the possible ways to handle it.
Signed-off-by Fea.Wang <[email protected]>--- hw/dma/xilinx_axidma.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)hw/dma/xilinx_axidma.c +6
-3@@ -291,7 +291,9 @@ static void stream_process_mem2s(struct Stream *s, StreamSink *tx_data_dev, }while (1 ) { -stream_desc_load (s, s->regs[R_CURDESC ]); +if (MEMTX_OK !=stream_desc_load (s, s->regs[R_CURDESC ])) { +break ; + }if (s->desc.status &SDESC_STATUS_COMPLETE ) { s->regs[R_DMASR ] |=DMASR_HALTED ;@@ -348,7 +350,9 @@ static size_t stream_process_s2mem(struct Stream *s, unsigned char *buf, }while (len) { -stream_desc_load (s, s->regs[R_CURDESC ]); +if (MEMTX_OK !=stream_desc_load (s, s->regs[R_CURDESC ])) { +break ; + }if (s->desc.status &SDESC_STATUS_COMPLETE ) { s->regs[R_DMASR ] |=DMASR_HALTED ; --2.34.1
PATCH 3/4 hw/dma: Add a trace log for a description loading failure
In reply to Fea.WangDue to a description loading failure, adding a trace log makes observing the DMA behavior easy.
--- hw/dma/trace-events | 3 +++ hw/dma/xilinx_axidma.c | 3 +++ 2 files changed, 6 insertions(+)
hw/dma/trace-events +3 -0
@@ -44,3 +44,6 @@ pl330_debug_exec_stall(void) "stall of debug instruction not implemented" pl330_iomem_write(uint32_t offset, uint32_t value) "addr: 0x%08"PRIx32" data: 0x%08"PRIx32 pl330_iomem_write_clr(int i) "event interrupt lowered %d" pl330_iomem_read(uint32_t addr, uint32_t data) "addr: 0x%08"PRIx32" data: 0x%08"PRIx32 + +# xilinx_axidma.c +xilinx_axidma_loading_desc_fail(uint32_t res) "error:%d"
hw/dma/xilinx_axidma.c +3 -0
@@ -36,6 +36,7 @@#include "sysemu/dma.h" #include "hw/stream.h" #include "qom/object.h" +#include "trace.h" #define D (x)
@@ -200,6 +201,8 @@ static MemTxResult stream_desc_load(struct Stream *s, hwaddr addr) addr,MEMTXATTRS_UNSPECIFIED , d, sizeof *d);if (result !=MEMTX_OK ) { +trace_xilinx_axidma_loading_desc_fail (result); + s->regs[R_DMACR ] &= ~DMACR_RUNSTOP ; s->regs[R_DMASR ] |=DMASR_HALTED ; s->regs[R_DMASR ] |=DMASR_SLVERR ;
Signature · 1 line
2.34.1
Re: [PATCH 3/4] hw/dma: Add a trace log for a description loading failure
Quoted 4 lines · Fea.Wang
Due to a description loading failure, adding a trace log makes observing the DMA behavior easy.
Quoted 46 lines
Signed-off-by Fea.Wang <[email protected]>--- hw/dma/trace-events | 3 +++ hw/dma/xilinx_axidma.c | 3 +++ 2 files changed, 6 insertions(+)hw/dma/trace-events +0
-0@@ -44,3 +44,6 @@ pl330_debug_exec_stall(void) "stall of debug instructionnot implemented"
pl330_iomem_write(uint32_t offset, uint32_t value)"addr: 0x%08"PRIx32"
data: 0x%08"PRIx32
pl330_iomem_write_clr(int i)"event interrupt lowered %d"pl330_iomem_read(uint32_t addr, uint32_t data)"addr: 0x%08"PRIx32" data:
0x%08"PRIx32hw/dma/trace-events +3
-0+ +# xilinx_axidma.c +xilinx_axidma_loading_desc_fail(uint32_t res) "error:%d"hw/dma/xilinx_axidma.c +3
-0@@ -36,6 +36,7 @@#include "sysemu/dma.h" #include "hw/stream.h" #include "qom/object.h" +#include "trace.h" #define D (x)@@ -200,6 +201,8 @@ static MemTxResult stream_desc_load(struct Stream *s, hwaddr addr) addr,MEMTXATTRS_UNSPECIFIED , d, sizeof *d);if (result !=MEMTX_OK ) { +trace_xilinx_axidma_loading_desc_fail (result); + s->regs[R_DMACR ] &= ~DMACR_RUNSTOP ; s->regs[R_DMASR ] |=DMASR_HALTED ;s->regs[R_DMASR] |= DMASR_SLVERR;--
2.34.1
Re: [PATCH 3/4] hw/dma: Add a trace log for a description loading failure
In reply to Fea.WangFea.Wang <[email protected]> 於 2024年6月3日 週一 下午1:49寫道:
Quoted 46 lines
Due to a description loading failure, adding a trace log makes observing the DMA behavior easy.
Signed-off-by Fea.Wang <[email protected]>--- hw/dma/trace-events | 3 +++ hw/dma/xilinx_axidma.c | 3 +++ 2 files changed, 6 insertions(+)hw/dma/trace-events +3
-0@@ -44,3 +44,6 @@ pl330_debug_exec_stall(void) "stall of debug instruction not implemented" pl330_iomem_write(uint32_t offset, uint32_t value) "addr: 0x%08"PRIx32" data: 0x%08"PRIx32 pl330_iomem_write_clr(int i) "event interrupt lowered %d" pl330_iomem_read(uint32_t addr, uint32_t data) "addr: 0x%08"PRIx32" data: 0x%08"PRIx32 + +# xilinx_axidma.c +xilinx_axidma_loading_desc_fail(uint32_t res) "error:%d"hw/dma/xilinx_axidma.c +3
-1@@ -36,6 +36,7 @@#include "sysemu/dma.h" #include "hw/stream.h" #include "qom/object.h" +#include "trace.h" #define D (x)@@ -200,6 +201,8 @@ static MemTxResult stream_desc_load(struct Stream *s, hwaddr addr) addr,MEMTXATTRS_UNSPECIFIED , d, sizeof *d);if (result !=MEMTX_OK ) { +trace_xilinx_axidma_loading_desc_fail (result); + s->regs[R_DMACR ] &= ~DMACR_RUNSTOP ; s->regs[R_DMASR ] |=DMASR_HALTED ; s->regs[R_DMASR ] |=DMASR_SLVERR ; --2.34.1
PATCH 4/4 hw/net: Fix the transmission return size
In reply to Fea.WangFix the transmission return size because not all bytes could be transmitted successfully. So, return a successful length instead of a constant value.
--- hw/net/xilinx_axienet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
hw/net/xilinx_axienet.c +1 -1
@@ -847,7 +847,7 @@ static ssize_t eth_rx(NetClientState *nc, const uint8_t *buf, size_t size)axienet_eth_rx_notify (s);enet_update_irq (s); -return size; +return s->rxpos; } static size_t
Signature · 1 line
2.34.1
Re: [PATCH 4/4] hw/net: Fix the transmission return size
Quoted 5 lines · Fea.Wang
Fix the transmission return size because not all bytes could be transmitted successfully. So, return a successful length instead of a constant value.
How did you test this patch, on Linux or something else? I have some memory that we had some trouble with similar patches before.
Anyway, the change looks good to me:
Quoted 23 lines
Signed-off-by Fea.Wang <[email protected]>--- hw/net/xilinx_axienet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)hw/net/xilinx_axienet.c +1
-1@@ -847,7 +847,7 @@ static ssize_t eth_rx(NetClientState *nc, const uint8_t *buf, size_t size)axienet_eth_rx_notify (s );enet_update_irq (s); -return size; +return s->rxpos; }static
size_t
--
2.34.1
Re: [PATCH 4/4] hw/net: Fix the transmission return size
I just encountered this issue when running Linux, and the trouble will be fixed after the patches. So I think they work.
Sincerely,
Fea
Quoted 38 lines · Edgar E. Iglesias
Quoted 5 lines · Fea.Wang
Fix the transmission return size because not all bytes could be transmitted successfully. So, return a successful length instead of a constant value.
How did you test this patch, on Linux or something else? I have some memory that we had some trouble with similar patches before.
Anyway, the change looks good to me:
Reviewed-by Edgar E. Iglesias <[email protected]>Quoted 23 lines
Signed-off-by Fea.Wang <[email protected]>--- hw/net/xilinx_axienet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)hw/net/xilinx_axienet.c +1
-1@@ -847,7 +847,7 @@ static ssize_t eth_rx(NetClientState *nc, const uint8_t *buf, size_t size)axienet_eth_rx_notify (s );enet_update_irq (s); -return size; +return s->rxpos; }static
size_t
--
2.34.1
Re: [PATCH 4/4] hw/net: Fix the transmission return size
In reply to Fea.WangFea.Wang <[email protected]> 於 2024年6月3日 週一 下午1:48寫道:
Quoted 27 lines
Fix the transmission return size because not all bytes could be transmitted successfully. So, return a successful length instead of a constant value.
Signed-off-by Fea.Wang <[email protected]>--- hw/net/xilinx_axienet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)hw/net/xilinx_axienet.c +1
-2@@ -847,7 +847,7 @@ static ssize_t eth_rx(NetClientState *nc, const uint8_t *buf, size_t size)axienet_eth_rx_notify (s);enet_update_irq (s); -return size; +return s->rxpos; } static size_t --2.34.1