Skip to contentSkip to conversation

riscv: dts: starfive: jh7110-pine64-star64: enable usb0 host function

PATCH Superseded E Shattow 3 participants 5 messages Nov 26, 2024 – Nov 27, 2024

Subsystems (3)

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore

E Shattow

author
#0 lore raw

v3 cover riscv: dts: starfive: jh7110-pine64-star64: enable usb0 host function

Enable host mode JH7110 on-chip USB for Pine64 Star64 by setting host mode and connect vbus pinctrl.

This functionality depends on setting the USB over-current register to disable at bootloader phase, for example U-Boot:
https://patchwork.ozlabs.org/project/uboot/patch/[email protected]/

If the over-current register is not prepared for us then the result is no change in functional outcome with this patch applied; there is an error visible to the user and this usb configuration fails (same as it is now).

Changes since v2:
- Rebase on latest master

Changes since v1:
- Rebase on linux-next/master
- use tabs for code indent

E Shattow (1):
riscv: dts: starfive: jh7110-pine64-star64: enable usb0 host function

 .../boot/dts/starfive/jh7110-pine64-star64.dts | 18 +++++++++++++++++-
 1 file changed, 17 insertions(+), 1 deletion(-)
Signature · 1 line
2.45.2
author
#1 lore raw

PATCH v3 1/1 riscv: dts: starfive: jh7110-pine64-star64: enable usb0 host function

Pine64 Star64 set JH7110 on-chip USB host mode and vbus pin assignment

---
 .../boot/dts/starfive/jh7110-pine64-star64.dts | 18 +++++++++++++++++-
 1 file changed, 17 insertions(+), 1 deletion(-)
arch/riscv/boot/dts/starfive/jh7110-pine64-star64.dts +17 -1
index fe4a490ecc61..b764d4d92fd9 100644
@@ -80,7 +80,23 @@ &spi0 {
 	status = "okay";
 };
 
+&sysgpio {
+	usb0_pins: usb0-0 {
+		vbus-pins {
+			pinmux = <GPIOMUX(25,  GPOUT_SYS_USB_DRIVE_VBUS,
+					       GPOEN_ENABLE,
+					       GPI_NONE)>;
+			bias-disable;
+			input-disable;
+			input-schmitt-disable;
+			slew-rate = <0>;
+		};
+	};
+};
+
 &usb0 {
-	dr_mode = "peripheral";
+	dr_mode = "host";
+	pinctrl-names = "default";
+	pinctrl-0 = <&usb0_pins>;
 	status = "okay";
 };
Signature · 1 line
2.45.2
maintainer
#2 lore raw

Emil,

Quoted 2 lines · E Shattow

Pine64 Star64 set JH7110 on-chip USB host mode and vbus pin assignment

Looks like the same thing here, so same thing here :)

Thanks,
Conor.

Quoted 37 lines
---
 .../boot/dts/starfive/jh7110-pine64-star64.dts | 18 +++++++++++++++++-
 1 file changed, 17 insertions(+), 1 deletion(-)
arch/riscv/boot/dts/starfive/jh7110-pine64-star64.dts +17 -1
index fe4a490ecc61..b764d4d92fd9 100644
@@ -80,7 +80,23 @@ &spi0 {
 	status = "okay";
 };
 
+&sysgpio {
+	usb0_pins: usb0-0 {
+		vbus-pins {
+			pinmux = <GPIOMUX(25,  GPOUT_SYS_USB_DRIVE_VBUS,
+					       GPOEN_ENABLE,
+					       GPI_NONE)>;
+			bias-disable;
+			input-disable;
+			input-schmitt-disable;
+			slew-rate = <0>;
+		};
+	};
+};
+
 &usb0 {
-	dr_mode = "peripheral";
+	dr_mode = "host";
+	pinctrl-names = "default";
+	pinctrl-0 = <&usb0_pins>;
 	status = "okay";
 };
Signature · 1 line
2.45.2
Reviewed-by on v3 1/1
#3 lore raw
In reply to E Shattow
Quoted 1 line · E Shattow

Pine64 Star64 set JH7110 on-chip USB host mode and vbus pin assignment

Here I'd like it explained that the Star64 board routes 1 of the 4 USB-A ports to USB0 on the SoC rather than to the USB 3.0 <-> PCIe chip.

(Confusing for users that 1 of the 4 similar ports only does USB 2.0, but that's too late to change and not relevant here)

With that fixed:

Quoted 38 lines
---
 .../boot/dts/starfive/jh7110-pine64-star64.dts | 18 +++++++++++++++++-
 1 file changed, 17 insertions(+), 1 deletion(-)
arch/riscv/boot/dts/starfive/jh7110-pine64-star64.dts +17 -2
index fe4a490ecc61..b764d4d92fd9 100644
@@ -80,7 +80,23 @@ &spi0 {
 	status = "okay";
 };
 
+&sysgpio {
+	usb0_pins: usb0-0 {
+		vbus-pins {
+			pinmux = <GPIOMUX(25,  GPOUT_SYS_USB_DRIVE_VBUS,
+					       GPOEN_ENABLE,
+					       GPI_NONE)>;
+			bias-disable;
+			input-disable;
+			input-schmitt-disable;
+			slew-rate = <0>;
+		};
+	};
+};
+
 &usb0 {
-	dr_mode = "peripheral";
+	dr_mode = "host";
+	pinctrl-names = "default";
+	pinctrl-0 = <&usb0_pins>;
 	status = "okay";
 };
--

2.45.2

author
#4 lore raw
Quoted 10 lines · Emil Renner Berthing
Quoted 1 line · E Shattow

Pine64 Star64 set JH7110 on-chip USB host mode and vbus pin assignment

Here I'd like it explained that the Star64 board routes 1 of the 4 USB-A ports to USB0 on the SoC rather than to the USB 3.0 <-> PCIe chip.

(Confusing for users that 1 of the 4 similar ports only does USB 2.0, but that's too late to change and not relevant here)

With that fixed:

There is no (VL805) USB 3.0 <-> PCIe chip on Star64;  All 4 USB-A ports route to USB0 of the SoC. What does not exist I did not write about in the cover letter. I will expand the description in the commit message. Thank you!  -E

Quoted 37 lines
Quoted 37 lines
---
  .../boot/dts/starfive/jh7110-pine64-star64.dts | 18 +++++++++++++++++-
  1 file changed, 17 insertions(+), 1 deletion(-)
arch/riscv/boot/dts/starfive/jh7110-pine64-star64.dts +17 -2
index fe4a490ecc61..b764d4d92fd9 100644
@@ -80,7 +80,23 @@ &spi0 {
  	status = "okay";
  };
 
+&sysgpio {
+	usb0_pins: usb0-0 {
+		vbus-pins {
+			pinmux = <GPIOMUX(25,  GPOUT_SYS_USB_DRIVE_VBUS,
+					       GPOEN_ENABLE,
+					       GPI_NONE)>;
+			bias-disable;
+			input-disable;
+			input-schmitt-disable;
+			slew-rate = <0>;
+		};
+	};
+};
+
  &usb0 {
-	dr_mode = "peripheral";
+	dr_mode = "host";
+	pinctrl-names = "default";
+	pinctrl-0 = <&usb0_pins>;
  	status = "okay";
  };
--

2.45.2