Skip to contentSkip to conversation

riscv: dts: starfive: jh7110-milkv-mars: enable usb0 host function

PATCH Applied E Shattow 2 participants 3 messages Nov 27, 2024 – Dec 2, 2024

Subsystems (3)
lore
Share & tools
lore

E Shattow

author
#0 lore raw

v6 cover riscv: dts: starfive: jh7110-milkv-mars: enable usb0 host function

Enable host mode JH7110 on-chip USB for Milk-V Mars by setting host mode and connect vbus pinctrl.

This functionality depends on setting the USB over-current register to disable at bootloader phase, for example U-Boot:
https://patchwork.ozlabs.org/project/uboot/patch/[email protected]/

If the over-current register is not prepared for us then the result is no change in functional outcome with this patch applied; there is an error visible to the user and this additional usb configuration fails (same as it is now). On Milk-V Mars with four USB-A ports this applies to one of the USB-A ports and the remaining three VL805-connected USB-A ports via PCIe are not changed.

Changes since v5:
- Rebase on latest master
- Addtional detail to commit description

Changes since v4:
- Rebase on latest master

Changes since v3:
- Rebase on linux-next/master
- use tabs for code indent

Changes since v2:
- Rebase on 6.12

E Shattow (1):
riscv: dts: starfive: jh7110-milkv-mars: enable usb0 host function

 .../boot/dts/starfive/jh7110-milkv-mars.dts    | 18 +++++++++++++++++-
 1 file changed, 17 insertions(+), 1 deletion(-)
Signature · 1 line
2.45.2
author
#1 lore raw

PATCH v6 1/1 riscv: dts: starfive: jh7110-milkv-mars: enable usb0 host function

Milk-V Mars board routes one of four USB-A ports to USB0 on the SoC rather than to the VL805 USB 3.0 <-> PCIe chip.
Set JH7110 on-chip USB host mode and vbus pin assignment accordingly.

---
 .../boot/dts/starfive/jh7110-milkv-mars.dts    | 18 +++++++++++++++++-
 1 file changed, 17 insertions(+), 1 deletion(-)
arch/riscv/boot/dts/starfive/jh7110-milkv-mars.dts +17 -1
index 0d248b671d4b..3bd62ab78523 100644
@@ -53,7 +53,23 @@ &spi0 {
 	status = "okay";
 };
 
+&sysgpio {
+	usb0_pins: usb0-0 {
+		vbus-pins {
+			pinmux = <GPIOMUX(25, GPOUT_SYS_USB_DRIVE_VBUS,
+					      GPOEN_ENABLE,
+					      GPI_NONE)>;
+			bias-disable;
+			input-disable;
+			input-schmitt-disable;
+			slew-rate = <0>;
+		};
+	};
+};
+
 &usb0 {
-	dr_mode = "peripheral";
+	dr_mode = "host";
+	pinctrl-names = "default";
+	pinctrl-0 = <&usb0_pins>;
 	status = "okay";
 };
Signature · 1 line
2.45.2
maintainer Applied
#2 lore raw
In reply to E Shattow

From: Conor Dooley <[email protected]>

Quoted 8 lines · E Shattow

Enable host mode JH7110 on-chip USB for Milk-V Mars by setting host mode and connect vbus pinctrl.

This functionality depends on setting the USB over-current register to disable at bootloader phase, for example U-Boot:
https://patchwork.ozlabs.org/project/uboot/patch/[email protected]/

[...]

Applied to riscv-dt-for-next, thanks!

[1/1] riscv: dts: starfive: jh7110-milkv-mars: enable usb0 host function

      https://git.kernel.org/conor/c/708d55db3edb

Thanks,
Conor.