dt-bindings: arm: mediatek: mediatek,g3dsys: Convert to DT schema
PATCH 1/1 dt-bindings: arm: mediatek: mediatek,g3dsys: Convert to DT schema
Convert the MediaTek G3D system controller devicetree binding from the legacy text format to DT schema.
--- .../bindings/arm/mediatek/mediatek,g3dsys.txt | 30 --------- .../arm/mediatek/mediatek,g3dsys.yaml | 61 +++++++++++++++++++ 2 files changed, 61 insertions(+), 30 deletions(-) delete mode 100644 Documentation/devicetree/bindings/arm/mediatek/mediatek,g3dsys.txt create mode 100644 Documentation/devicetree/bindings/arm/mediatek/mediatek,g3dsys.yaml
Documentation/devicetree/bindings/arm/mediatek/mediatek,g3dsys.txt deleted +0 -30
@@ -1,30 +0,0 @@ -MediaTek g3dsys controller -============================ - -The MediaTek g3dsys controller provides various clocks and reset controller to -the GPU. - -Required Properties: - -- compatible: Should be: - - "mediatek,mt2701-g3dsys", "syscon": - for MT2701 SoC - - "mediatek,mt7623-g3dsys", "mediatek,mt2701-g3dsys", "syscon": - for MT7623 SoC -- #clock-cells: Must be 1 -- #reset-cells: Must be 1 - -The g3dsys controller uses the common clk binding from -Documentation/devicetree/bindings/clock/clock-bindings.txt -The available clocks are defined in dt-bindings/clock/mt*-clk.h. - -Example: - -g3dsys: clock-controller@13000000 { - compatible = "mediatek,mt7623-g3dsys", - "mediatek,mt2701-g3dsys", - "syscon"; - reg = <0 0x13000000 0 0x200>; - #clock-cells = <1>; - #reset-cells = <1>; -};
Documentation/devicetree/bindings/arm/mediatek/mediatek,g3dsys.yaml new file +61 -0
61 lines not on this page · raw message
Signature · 1 line
2.34.1
Quoted 4 lines · Udaya Kiran Challa
Documentation/devicetree/bindings/arm/mediatek/mediatek,g3dsys.yaml new file +4
-0+properties: + compatible: + oneOf: + - items:
Documentation/devicetree/bindings/arm/mediatek/mediatek,g3dsys.yaml line 30
Quoted 10 lines
Documentation/devicetree/bindings/arm/mediatek/mediatek,g3dsys.yaml new file +10
-0+ - const: mediatek,mt2701-g3dsys + - const: syscon + - items: + - const: mediatek,mt7623-g3dsys + - const: mediatek,mt2701-g3dsys + - const: syscon + + reg: + maxItems: 1 + description: Base address and length of the G3DSYS register region
Drop
Documentation/devicetree/bindings/arm/mediatek/mediatek,g3dsys.yaml line 34
Quoted 4 lines
Documentation/devicetree/bindings/arm/mediatek/mediatek,g3dsys.yaml new file +4
-0+ + "#clock-cells": + const: 1 + description: Number of cells in a clock specifier
$ git grep "Number of cells in a clock specifier"
Read the guidelines for GSoC contributors I posted on IRC used in GSoC and/or ones I wrote on social.kernel.org.
Your mentors were supposed to be Cc-ed here.
Best regards,
Krzysztof
Quoted 6 lines · Krzysztof Kozlowski
Documentation/devicetree/bindings/arm/mediatek/mediatek,g3dsys.yaml line 34
Quoted 4 lines
Documentation/devicetree/bindings/arm/mediatek/mediatek,g3dsys.yaml new file +4
-0+ + "#clock-cells": + const: 1 + description: Number of cells in a clock specifier$ git grep "Number of cells in a clock specifier"
Sorry Krzysztof, I didn't understand what you meant. I've tried executing git grep, but there are no results apart from my commit. But, I've found it in clock-binding.txt i.e., in clock.yaml in github. After careful study of guidelines.I've removed the description of provider properties. Please let me know if there is any deviation in my understanding!!
Quoted 3 lines
Read the guidelines for GSoC contributors I posted on IRC used in GSoC and/or ones I wrote on social.kernel.org.
Thank you, I've gone through the guidelines once again and updated the changes.
Quoted 1 line
Your mentors were supposed to be Cc-ed here.
I'm part of the Linux Kernel Spring Unpaid 2026 Mentorship program and I've already Cc-ed Shuah in the mailing list.
Regards,
Udaya Kiran Challa
Quoted 10 lines · Uday Kiran
Quoted 6 lines · Krzysztof Kozlowski
Documentation/devicetree/bindings/arm/mediatek/mediatek,g3dsys.yaml line 34
Quoted 4 lines
Documentation/devicetree/bindings/arm/mediatek/mediatek,g3dsys.yaml new file +4
-0+ + "#clock-cells": + const: 1 + description: Number of cells in a clock specifier$ git grep "Number of cells in a clock specifier"Sorry Krzysztof, I didn't understand what you meant. I've tried executing git grep, but there are no results apart from my commit. But, I've found it
Exactly.
Therefore why would you write a style code which does not exist in the kernel? Why doing this completely different than everyone else?
Quoted 8 lines
in clock-binding.txt i.e., in
clock.yamlin github. After careful study of guidelines.I've removed the description of provider properties. Please let me know if there is any deviation in my understanding!!Quoted 3 lines
Read the guidelines for GSoC contributors I posted on IRC used in GSoC and/or ones I wrote on social.kernel.org.
Quoted 7 lines
Thank you, I've gone through the guidelines once again and updated the changes.
Quoted 1 line
Your mentors were supposed to be Cc-ed here.
I'm part of the Linux Kernel Spring Unpaid 2026 Mentorship program and I've already Cc-ed Shuah in the mailing list.
Does that mean LFX mentorship also has sub-program like GSoC for bindings conversion? Does this program at least incorporated our feedback from two years and year ago?
Best regards,
Krzysztof
Quoted 10 lines · Krzysztof Kozlowski
Quoted 8 lines · Uday Kiran
Quoted 6 lines · Krzysztof Kozlowski
Documentation/devicetree/bindings/arm/mediatek/mediatek,g3dsys.yaml line 34
Quoted 4 lines
Documentation/devicetree/bindings/arm/mediatek/mediatek,g3dsys.yaml new file +4
-0+ + "#clock-cells": + const: 1 + description: Number of cells in a clock specifier$ git grep "Number of cells in a clock specifier"
Quoted 7 lines
Quoted 2 lines
Sorry Krzysztof, I didn't understand what you meant. I've tried executing git grep, but there are no results apart from my commit. But, I've found it
Exactly.
Therefore why would you write a style code which does not exist in the kernel? Why doing this completely different than everyone else?
I understand now that it is redundant to add the description for provider properties. I’ve removed the description and aligned the schema with existing kernel style.
Quoted 4 lines
Quoted 4 lines
in clock-binding.txt i.e., in
clock.yamlin github. After careful study of guidelines.I've removed the description of provider properties. Please let me know if there is any deviation in my understanding!!> >
Quoted 9 lines
Quoted 4 lines
Quoted 1 line
Your mentors were supposed to be Cc-ed here.
I'm part of the Linux Kernel Spring Unpaid 2026 Mentorship program and I've already Cc-ed Shuah in the mailing list.
Does that mean LFX mentorship also has sub-program like GSoC for bindings conversion? Does this program at least incorporated our feedback from two years and year ago?
It is similar in structure to GSoC, but it is not specific to bindings conversion. We can contribute on any subsystem of kernel and I'm trying to align my work with existing kernel conventions and feedback from maintainers.
Regards,
Udaya Kiran Challa